Add new DiagnosticMethodInfo public API by MichalStrehovsky · Pull Request #103220 · dotnet/runtime

MichalStrehovsky · 2024-06-10T09:19:46Z

This add support for the new public API for all runtime flavors and switches Tasks logging to use it (we could make it a separate PR, I don't mind either way). Switching tasks logging to the new API saves 1.1% in size on webapiaot because the compiler no longer needs to consider all delegates targets of reflection.

TODO:

Feature switch to disable this outside native AOT so that <StackTraceSupport>false</StackTraceSupport> really means this doesn't work.
Trimming test with the feature switch disabled
Native AOT smoke test to exercise some of the "don't have reflection metadata" paths. libraries tests always have reflection metadata for everything.
Maybe also use this in BCL instead of get_Method.
Finish the feature switch (add ILLink XML)

#96528

ghost · 2024-06-10T09:19:53Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-06-10T09:19:55Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-06-10T09:20:10Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

MichalStrehovsky · 2024-06-11T09:39:19Z

+ DiagnosticMethodInfo? dmi = DiagnosticMethodInfo.Create(@delegate);
+ return dmi?.Name ?? "<unknown>";


This could alternatively be this, but not sure how important that is:
Suggested change
DiagnosticMethodInfo?dmi=DiagnosticMethodInfo.Create(@delegate);
returndmi?.Name??"<unknown>";
if(StackTrace.IsSupported)
{
DiagnosticMethodInfo?dmi=DiagnosticMethodInfo.Create(@delegate);
returndmi!.Name;
}
else
{
return@delegate.Method.Name;
}

MichalStrehovsky · 2024-06-11T10:56:53Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-06-11T10:57:10Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2024-06-11T11:02:44Z

1.1% size savings on webapiaot! MichalStrehovsky/rt-sz#29 (comment)

MichalStrehovsky · 2024-06-12T08:37:45Z

This is ready for review, cc @dotnet/ilc-contrib

jkotas · 2024-06-12T15:14:39Z

 // For all other task than TaskContinuations we want to log. TaskContinuations log in their constructor
 Debug.Assert(m_action != null, "Must have a delegate to be in ScheduleAndStart");
- TplEventSource.Log.TraceOperationBegin(this.Id, "Task: " + m_action.Method.Name, 0);
+ TplEventSource.Log.TraceOperationBegin(this.Id, "Task: " + m_action.GetMethodName(), 0);


Is this measurably more expensive than the existing code on regular CoreCLR?

On regular coreclr there's the one extra allocation but otherwise I don't expect impact. DiagnosticMethodInfo just wraps the underlying MethodInfo.
On native AOT we unnecessarily materialize type name and class name. I thought about structuring DiagnosticMethodInfo so that it wraps MetadataReader and a bunch of handles but ended up not doing it because we'd still need strings for the open method delegate cases (or somehow wrestle metadata handles out of reflection objects in that case).

jkotas

LGTM!

MichalStrehovsky · 2024-06-10T09:19:46Z

This add support for the new public API for all runtime flavors and switches Tasks logging to use it (we could make it a separate PR, I don't mind either way). Switching tasks logging to the new API saves 1.1% in size on webapiaot because the compiler no longer needs to consider all delegates targets of reflection.

TODO:

Feature switch to disable this outside native AOT so that <StackTraceSupport>false</StackTraceSupport> really means this doesn't work.
Trimming test with the feature switch disabled
Native AOT smoke test to exercise some of the "don't have reflection metadata" paths. libraries tests always have reflection metadata for everything.
Maybe also use this in BCL instead of get_Method.
Finish the feature switch (add ILLink XML)

#96528

ghost · 2024-06-10T09:19:53Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-06-10T09:19:55Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-06-10T09:20:10Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

MichalStrehovsky · 2024-06-11T09:39:19Z

+ DiagnosticMethodInfo? dmi = DiagnosticMethodInfo.Create(@delegate);
+ return dmi?.Name ?? "<unknown>";


This could alternatively be this, but not sure how important that is:
Suggested change
DiagnosticMethodInfo?dmi=DiagnosticMethodInfo.Create(@delegate);
returndmi?.Name??"<unknown>";
if(StackTrace.IsSupported)
{
DiagnosticMethodInfo?dmi=DiagnosticMethodInfo.Create(@delegate);
returndmi!.Name;
}
else
{
return@delegate.Method.Name;
}

MichalStrehovsky · 2024-06-11T10:56:53Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-06-11T10:57:10Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2024-06-11T11:02:44Z

1.1% size savings on webapiaot! MichalStrehovsky/rt-sz#29 (comment)

MichalStrehovsky · 2024-06-12T08:37:45Z

This is ready for review, cc @dotnet/ilc-contrib

jkotas · 2024-06-12T15:14:39Z

 // For all other task than TaskContinuations we want to log. TaskContinuations log in their constructor
 Debug.Assert(m_action != null, "Must have a delegate to be in ScheduleAndStart");
- TplEventSource.Log.TraceOperationBegin(this.Id, "Task: " + m_action.Method.Name, 0);
+ TplEventSource.Log.TraceOperationBegin(this.Id, "Task: " + m_action.GetMethodName(), 0);


Is this measurably more expensive than the existing code on regular CoreCLR?

On regular coreclr there's the one extra allocation but otherwise I don't expect impact. DiagnosticMethodInfo just wraps the underlying MethodInfo.
On native AOT we unnecessarily materialize type name and class name. I thought about structuring DiagnosticMethodInfo so that it wraps MetadataReader and a bunch of handles but ended up not doing it because we'd still need strings for the open method delegate cases (or somehow wrestle metadata handles out of reflection objects in that case).

jkotas

LGTM!

MichalStrehovsky · 2024-06-10T09:19:46Z

This add support for the new public API for all runtime flavors and switches Tasks logging to use it (we could make it a separate PR, I don't mind either way). Switching tasks logging to the new API saves 1.1% in size on webapiaot because the compiler no longer needs to consider all delegates targets of reflection.

TODO:

Feature switch to disable this outside native AOT so that <StackTraceSupport>false</StackTraceSupport> really means this doesn't work.
Trimming test with the feature switch disabled
Native AOT smoke test to exercise some of the "don't have reflection metadata" paths. libraries tests always have reflection metadata for everything.
Maybe also use this in BCL instead of get_Method.
Finish the feature switch (add ILLink XML)

#96528

ghost · 2024-06-10T09:19:53Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-06-10T09:19:55Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-06-10T09:20:10Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

MichalStrehovsky · 2024-06-11T09:39:19Z

+ DiagnosticMethodInfo? dmi = DiagnosticMethodInfo.Create(@delegate);
+ return dmi?.Name ?? "<unknown>";


This could alternatively be this, but not sure how important that is:
Suggested change
DiagnosticMethodInfo?dmi=DiagnosticMethodInfo.Create(@delegate);
returndmi?.Name??"<unknown>";
if(StackTrace.IsSupported)
{
DiagnosticMethodInfo?dmi=DiagnosticMethodInfo.Create(@delegate);
returndmi!.Name;
}
else
{
return@delegate.Method.Name;
}

MichalStrehovsky · 2024-06-11T10:56:53Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-06-11T10:57:10Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2024-06-11T11:02:44Z

1.1% size savings on webapiaot! MichalStrehovsky/rt-sz#29 (comment)

MichalStrehovsky · 2024-06-12T08:37:45Z

This is ready for review, cc @dotnet/ilc-contrib

jkotas · 2024-06-12T15:14:39Z

 // For all other task than TaskContinuations we want to log. TaskContinuations log in their constructor
 Debug.Assert(m_action != null, "Must have a delegate to be in ScheduleAndStart");
- TplEventSource.Log.TraceOperationBegin(this.Id, "Task: " + m_action.Method.Name, 0);
+ TplEventSource.Log.TraceOperationBegin(this.Id, "Task: " + m_action.GetMethodName(), 0);


Is this measurably more expensive than the existing code on regular CoreCLR?

On regular coreclr there's the one extra allocation but otherwise I don't expect impact. DiagnosticMethodInfo just wraps the underlying MethodInfo.
On native AOT we unnecessarily materialize type name and class name. I thought about structuring DiagnosticMethodInfo so that it wraps MetadataReader and a bunch of handles but ended up not doing it because we'd still need strings for the open method delegate cases (or somehow wrestle metadata handles out of reflection objects in that case).

jkotas

LGTM!

MichalStrehovsky · 2024-06-10T09:19:46Z

This add support for the new public API for all runtime flavors and switches Tasks logging to use it (we could make it a separate PR, I don't mind either way). Switching tasks logging to the new API saves 1.1% in size on webapiaot because the compiler no longer needs to consider all delegates targets of reflection.

TODO:

Feature switch to disable this outside native AOT so that <StackTraceSupport>false</StackTraceSupport> really means this doesn't work.
Trimming test with the feature switch disabled
Native AOT smoke test to exercise some of the "don't have reflection metadata" paths. libraries tests always have reflection metadata for everything.
Maybe also use this in BCL instead of get_Method.
Finish the feature switch (add ILLink XML)

#96528

ghost · 2024-06-10T09:19:53Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-06-10T09:19:55Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-06-10T09:20:10Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

MichalStrehovsky · 2024-06-11T09:39:19Z

+ DiagnosticMethodInfo? dmi = DiagnosticMethodInfo.Create(@delegate);
+ return dmi?.Name ?? "<unknown>";


This could alternatively be this, but not sure how important that is:
Suggested change
DiagnosticMethodInfo?dmi=DiagnosticMethodInfo.Create(@delegate);
returndmi?.Name??"<unknown>";
if(StackTrace.IsSupported)
{
DiagnosticMethodInfo?dmi=DiagnosticMethodInfo.Create(@delegate);
returndmi!.Name;
}
else
{
return@delegate.Method.Name;
}

MichalStrehovsky · 2024-06-11T10:56:53Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-06-11T10:57:10Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2024-06-11T11:02:44Z

1.1% size savings on webapiaot! MichalStrehovsky/rt-sz#29 (comment)

MichalStrehovsky · 2024-06-12T08:37:45Z

This is ready for review, cc @dotnet/ilc-contrib

jkotas · 2024-06-12T15:14:39Z

 // For all other task than TaskContinuations we want to log. TaskContinuations log in their constructor
 Debug.Assert(m_action != null, "Must have a delegate to be in ScheduleAndStart");
- TplEventSource.Log.TraceOperationBegin(this.Id, "Task: " + m_action.Method.Name, 0);
+ TplEventSource.Log.TraceOperationBegin(this.Id, "Task: " + m_action.GetMethodName(), 0);


Is this measurably more expensive than the existing code on regular CoreCLR?

On regular coreclr there's the one extra allocation but otherwise I don't expect impact. DiagnosticMethodInfo just wraps the underlying MethodInfo.
On native AOT we unnecessarily materialize type name and class name. I thought about structuring DiagnosticMethodInfo so that it wraps MetadataReader and a bunch of handles but ended up not doing it because we'd still need strings for the open method delegate cases (or somehow wrestle metadata handles out of reflection objects in that case).

jkotas

LGTM!

MichalStrehovsky · 2024-06-10T09:19:46Z

This add support for the new public API for all runtime flavors and switches Tasks logging to use it (we could make it a separate PR, I don't mind either way). Switching tasks logging to the new API saves 1.1% in size on webapiaot because the compiler no longer needs to consider all delegates targets of reflection.

TODO:

Feature switch to disable this outside native AOT so that <StackTraceSupport>false</StackTraceSupport> really means this doesn't work.
Trimming test with the feature switch disabled
Native AOT smoke test to exercise some of the "don't have reflection metadata" paths. libraries tests always have reflection metadata for everything.
Maybe also use this in BCL instead of get_Method.
Finish the feature switch (add ILLink XML)

#96528

ghost · 2024-06-10T09:19:53Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-06-10T09:19:55Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-06-10T09:20:10Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

MichalStrehovsky · 2024-06-11T09:39:19Z

+ DiagnosticMethodInfo? dmi = DiagnosticMethodInfo.Create(@delegate);
+ return dmi?.Name ?? "<unknown>";


This could alternatively be this, but not sure how important that is:
Suggested change
DiagnosticMethodInfo?dmi=DiagnosticMethodInfo.Create(@delegate);
returndmi?.Name??"<unknown>";
if(StackTrace.IsSupported)
{
DiagnosticMethodInfo?dmi=DiagnosticMethodInfo.Create(@delegate);
returndmi!.Name;
}
else
{
return@delegate.Method.Name;
}

MichalStrehovsky · 2024-06-11T10:56:53Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-06-11T10:57:10Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2024-06-11T11:02:44Z

1.1% size savings on webapiaot! MichalStrehovsky/rt-sz#29 (comment)

MichalStrehovsky · 2024-06-12T08:37:45Z

This is ready for review, cc @dotnet/ilc-contrib

jkotas · 2024-06-12T15:14:39Z

 // For all other task than TaskContinuations we want to log. TaskContinuations log in their constructor
 Debug.Assert(m_action != null, "Must have a delegate to be in ScheduleAndStart");
- TplEventSource.Log.TraceOperationBegin(this.Id, "Task: " + m_action.Method.Name, 0);
+ TplEventSource.Log.TraceOperationBegin(this.Id, "Task: " + m_action.GetMethodName(), 0);


Is this measurably more expensive than the existing code on regular CoreCLR?

On regular coreclr there's the one extra allocation but otherwise I don't expect impact. DiagnosticMethodInfo just wraps the underlying MethodInfo.
On native AOT we unnecessarily materialize type name and class name. I thought about structuring DiagnosticMethodInfo so that it wraps MetadataReader and a bunch of handles but ended up not doing it because we'd still need strings for the open method delegate cases (or somehow wrestle metadata handles out of reflection objects in that case).

jkotas

LGTM!

MichalStrehovsky · 2024-06-10T09:19:46Z

This add support for the new public API for all runtime flavors and switches Tasks logging to use it (we could make it a separate PR, I don't mind either way). Switching tasks logging to the new API saves 1.1% in size on webapiaot because the compiler no longer needs to consider all delegates targets of reflection.

TODO:

Feature switch to disable this outside native AOT so that <StackTraceSupport>false</StackTraceSupport> really means this doesn't work.
Trimming test with the feature switch disabled
Native AOT smoke test to exercise some of the "don't have reflection metadata" paths. libraries tests always have reflection metadata for everything.
Maybe also use this in BCL instead of get_Method.
Finish the feature switch (add ILLink XML)

#96528

ghost · 2024-06-10T09:19:53Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-06-10T09:19:55Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-06-10T09:20:10Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

MichalStrehovsky · 2024-06-11T09:39:19Z

+ DiagnosticMethodInfo? dmi = DiagnosticMethodInfo.Create(@delegate);
+ return dmi?.Name ?? "<unknown>";


This could alternatively be this, but not sure how important that is:
Suggested change
DiagnosticMethodInfo?dmi=DiagnosticMethodInfo.Create(@delegate);
returndmi?.Name??"<unknown>";
if(StackTrace.IsSupported)
{
DiagnosticMethodInfo?dmi=DiagnosticMethodInfo.Create(@delegate);
returndmi!.Name;
}
else
{
return@delegate.Method.Name;
}

MichalStrehovsky · 2024-06-11T10:56:53Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-06-11T10:57:10Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2024-06-11T11:02:44Z

1.1% size savings on webapiaot! MichalStrehovsky/rt-sz#29 (comment)

MichalStrehovsky · 2024-06-12T08:37:45Z

This is ready for review, cc @dotnet/ilc-contrib

jkotas · 2024-06-12T15:14:39Z

 // For all other task than TaskContinuations we want to log. TaskContinuations log in their constructor
 Debug.Assert(m_action != null, "Must have a delegate to be in ScheduleAndStart");
- TplEventSource.Log.TraceOperationBegin(this.Id, "Task: " + m_action.Method.Name, 0);
+ TplEventSource.Log.TraceOperationBegin(this.Id, "Task: " + m_action.GetMethodName(), 0);


Is this measurably more expensive than the existing code on regular CoreCLR?

On regular coreclr there's the one extra allocation but otherwise I don't expect impact. DiagnosticMethodInfo just wraps the underlying MethodInfo.
On native AOT we unnecessarily materialize type name and class name. I thought about structuring DiagnosticMethodInfo so that it wraps MetadataReader and a bunch of handles but ended up not doing it because we'd still need strings for the open method delegate cases (or somehow wrestle metadata handles out of reflection objects in that case).

jkotas

LGTM!

MichalStrehovsky · 2024-06-10T09:19:46Z

This add support for the new public API for all runtime flavors and switches Tasks logging to use it (we could make it a separate PR, I don't mind either way). Switching tasks logging to the new API saves 1.1% in size on webapiaot because the compiler no longer needs to consider all delegates targets of reflection.

TODO:

Feature switch to disable this outside native AOT so that <StackTraceSupport>false</StackTraceSupport> really means this doesn't work.
Trimming test with the feature switch disabled
Native AOT smoke test to exercise some of the "don't have reflection metadata" paths. libraries tests always have reflection metadata for everything.
Maybe also use this in BCL instead of get_Method.
Finish the feature switch (add ILLink XML)

#96528

ghost · 2024-06-10T09:19:53Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-06-10T09:19:55Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-06-10T09:20:10Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

MichalStrehovsky · 2024-06-11T09:39:19Z

+ DiagnosticMethodInfo? dmi = DiagnosticMethodInfo.Create(@delegate);
+ return dmi?.Name ?? "<unknown>";


This could alternatively be this, but not sure how important that is:
Suggested change
DiagnosticMethodInfo?dmi=DiagnosticMethodInfo.Create(@delegate);
returndmi?.Name??"<unknown>";
if(StackTrace.IsSupported)
{
DiagnosticMethodInfo?dmi=DiagnosticMethodInfo.Create(@delegate);
returndmi!.Name;
}
else
{
return@delegate.Method.Name;
}

MichalStrehovsky · 2024-06-11T10:56:53Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-06-11T10:57:10Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2024-06-11T11:02:44Z

1.1% size savings on webapiaot! MichalStrehovsky/rt-sz#29 (comment)

MichalStrehovsky · 2024-06-12T08:37:45Z

This is ready for review, cc @dotnet/ilc-contrib

jkotas · 2024-06-12T15:14:39Z

 // For all other task than TaskContinuations we want to log. TaskContinuations log in their constructor
 Debug.Assert(m_action != null, "Must have a delegate to be in ScheduleAndStart");
- TplEventSource.Log.TraceOperationBegin(this.Id, "Task: " + m_action.Method.Name, 0);
+ TplEventSource.Log.TraceOperationBegin(this.Id, "Task: " + m_action.GetMethodName(), 0);


Is this measurably more expensive than the existing code on regular CoreCLR?

On regular coreclr there's the one extra allocation but otherwise I don't expect impact. DiagnosticMethodInfo just wraps the underlying MethodInfo.
On native AOT we unnecessarily materialize type name and class name. I thought about structuring DiagnosticMethodInfo so that it wraps MetadataReader and a bunch of handles but ended up not doing it because we'd still need strings for the open method delegate cases (or somehow wrestle metadata handles out of reflection objects in that case).

jkotas

LGTM!

MichalStrehovsky · 2024-06-10T09:19:46Z

This add support for the new public API for all runtime flavors and switches Tasks logging to use it (we could make it a separate PR, I don't mind either way). Switching tasks logging to the new API saves 1.1% in size on webapiaot because the compiler no longer needs to consider all delegates targets of reflection.

TODO:

Feature switch to disable this outside native AOT so that <StackTraceSupport>false</StackTraceSupport> really means this doesn't work.
Trimming test with the feature switch disabled
Native AOT smoke test to exercise some of the "don't have reflection metadata" paths. libraries tests always have reflection metadata for everything.
Maybe also use this in BCL instead of get_Method.
Finish the feature switch (add ILLink XML)

#96528

ghost · 2024-06-10T09:19:53Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-06-10T09:19:55Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

dotnet-policy-service · 2024-06-10T09:20:10Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

MichalStrehovsky · 2024-06-11T09:39:19Z

+ DiagnosticMethodInfo? dmi = DiagnosticMethodInfo.Create(@delegate);
+ return dmi?.Name ?? "<unknown>";


This could alternatively be this, but not sure how important that is:
Suggested change
DiagnosticMethodInfo?dmi=DiagnosticMethodInfo.Create(@delegate);
returndmi?.Name??"<unknown>";
if(StackTrace.IsSupported)
{
DiagnosticMethodInfo?dmi=DiagnosticMethodInfo.Create(@delegate);
returndmi!.Name;
}
else
{
return@delegate.Method.Name;
}

MichalStrehovsky · 2024-06-11T10:56:53Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-06-11T10:57:10Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2024-06-11T11:02:44Z

1.1% size savings on webapiaot! MichalStrehovsky/rt-sz#29 (comment)

MichalStrehovsky · 2024-06-12T08:37:45Z

This is ready for review, cc @dotnet/ilc-contrib

jkotas · 2024-06-12T15:14:39Z

 // For all other task than TaskContinuations we want to log. TaskContinuations log in their constructor
 Debug.Assert(m_action != null, "Must have a delegate to be in ScheduleAndStart");
- TplEventSource.Log.TraceOperationBegin(this.Id, "Task: " + m_action.Method.Name, 0);
+ TplEventSource.Log.TraceOperationBegin(this.Id, "Task: " + m_action.GetMethodName(), 0);


Is this measurably more expensive than the existing code on regular CoreCLR?

On regular coreclr there's the one extra allocation but otherwise I don't expect impact. DiagnosticMethodInfo just wraps the underlying MethodInfo.
On native AOT we unnecessarily materialize type name and class name. I thought about structuring DiagnosticMethodInfo so that it wraps MetadataReader and a bunch of handles but ended up not doing it because we'd still need strings for the open method delegate cases (or somehow wrestle metadata handles out of reflection objects in that case).

jkotas

LGTM!

Add new DiagnosticMethodInfo public API
a4f8036

MichalStrehovsky added the area-System.Diagnostics label Jun 10, 2024

ghost added the new-api-needs-documentation label Jun 10, 2024

dotnet-policy-serviceBot assigned MichalStrehovsky Jun 10, 2024

MichalStrehovsky marked this pull request as draft June 10, 2024 09:22

{bad luck brian}
de5cf36

MichalStrehovsky mentioned this pull request Jun 11, 2024
Assertion failed: The class hierarchy should declare the method #103268
Closed

MichalStrehovsky added 3 commits June 11, 2024 06:31

Skip CoreCLR and Mono bugs
6397898

More tests
21783d3

Use in Tasks logging
dd48955

github-actionsBot mentioned this pull request Jun 11, 2024
103220 MichalStrehovsky/rt-sz#29
Closed

build-analysisBot mentioned this pull request Jun 11, 2024
[browser][ST] Wasm tests timeout #103246
Closed

MichalStrehovsky commented Jun 11, 2024
View reviewed changes

This was referenced Jun 11, 2024
Wasm test failure: Unable to evaluate script: target frame detached #102957
Closed
[wasm][chrome] Unable to evaluate script: disconnected: unable to send message to renderer #103061
Closed

Update ILLink.Substitutions.Shared.xml
406ac37

MichalStrehovsky marked this pull request as ready for review June 12, 2024 08:37

jkotas reviewed Jun 12, 2024
View reviewed changes

jkotas approved these changes Jun 13, 2024
View reviewed changes

MichalStrehovsky merged commit 5b79b76 into dotnet:mainJun 13, 2024

MichalStrehovsky deleted the diagmethodinfo branch June 13, 2024 07:45

MichalStrehovsky mentioned this pull request Jun 13, 2024
[API Proposal]: Diagnostic method information #96528
Closed

build-analysisBot mentioned this pull request Jun 13, 2024
System.Net.Security.Tests.SslStreamTlsResumeTests failing #103354
Closed

filipnavara mentioned this pull request Jul 6, 2024
Stack Trace missing for NativeAOT App getsentry/sentry-dotnet#3439
Closed

github-actionsBot locked and limited conversation to collaborators Jul 13, 2024

Add new DiagnosticMethodInfo public API
a4f8036

MichalStrehovsky added the area-System.Diagnostics label Jun 10, 2024

ghost added the new-api-needs-documentation label Jun 10, 2024

dotnet-policy-serviceBot assigned MichalStrehovsky Jun 10, 2024

MichalStrehovsky marked this pull request as draft June 10, 2024 09:22

{bad luck brian}
de5cf36

MichalStrehovsky mentioned this pull request Jun 11, 2024
Assertion failed: The class hierarchy should declare the method #103268
Closed

MichalStrehovsky added 3 commits June 11, 2024 06:31

Skip CoreCLR and Mono bugs
6397898

More tests
21783d3

Use in Tasks logging
dd48955

github-actionsBot mentioned this pull request Jun 11, 2024
103220 MichalStrehovsky/rt-sz#29
Closed

build-analysisBot mentioned this pull request Jun 11, 2024
[browser][ST] Wasm tests timeout #103246
Closed

MichalStrehovsky commented Jun 11, 2024
View reviewed changes

This was referenced Jun 11, 2024
Wasm test failure: Unable to evaluate script: target frame detached #102957
Closed
[wasm][chrome] Unable to evaluate script: disconnected: unable to send message to renderer #103061
Closed

Update ILLink.Substitutions.Shared.xml
406ac37

MichalStrehovsky marked this pull request as ready for review June 12, 2024 08:37

jkotas reviewed Jun 12, 2024
View reviewed changes

jkotas approved these changes Jun 13, 2024
View reviewed changes

MichalStrehovsky merged commit 5b79b76 into dotnet:mainJun 13, 2024

MichalStrehovsky deleted the diagmethodinfo branch June 13, 2024 07:45

MichalStrehovsky mentioned this pull request Jun 13, 2024
[API Proposal]: Diagnostic method information #96528
Closed

build-analysisBot mentioned this pull request Jun 13, 2024
System.Net.Security.Tests.SslStreamTlsResumeTests failing #103354
Closed

filipnavara mentioned this pull request Jul 6, 2024
Stack Trace missing for NativeAOT App getsentry/sentry-dotnet#3439
Closed

github-actionsBot locked and limited conversation to collaborators Jul 13, 2024

Add new DiagnosticMethodInfo public API
a4f8036

MichalStrehovsky added the area-System.Diagnostics label Jun 10, 2024

ghost added the new-api-needs-documentation label Jun 10, 2024

dotnet-policy-serviceBot assigned MichalStrehovsky Jun 10, 2024

MichalStrehovsky marked this pull request as draft June 10, 2024 09:22

{bad luck brian}
de5cf36

MichalStrehovsky mentioned this pull request Jun 11, 2024
Assertion failed: The class hierarchy should declare the method #103268
Closed

MichalStrehovsky added 3 commits June 11, 2024 06:31

Skip CoreCLR and Mono bugs
6397898

More tests
21783d3

Use in Tasks logging
dd48955

github-actionsBot mentioned this pull request Jun 11, 2024
103220 MichalStrehovsky/rt-sz#29
Closed

build-analysisBot mentioned this pull request Jun 11, 2024
[browser][ST] Wasm tests timeout #103246
Closed

MichalStrehovsky commented Jun 11, 2024
View reviewed changes

This was referenced Jun 11, 2024
Wasm test failure: Unable to evaluate script: target frame detached #102957
Closed
[wasm][chrome] Unable to evaluate script: disconnected: unable to send message to renderer #103061
Closed

Update ILLink.Substitutions.Shared.xml
406ac37

MichalStrehovsky marked this pull request as ready for review June 12, 2024 08:37

jkotas reviewed Jun 12, 2024
View reviewed changes

jkotas approved these changes Jun 13, 2024
View reviewed changes

MichalStrehovsky merged commit 5b79b76 into dotnet:mainJun 13, 2024

MichalStrehovsky deleted the diagmethodinfo branch June 13, 2024 07:45

MichalStrehovsky mentioned this pull request Jun 13, 2024
[API Proposal]: Diagnostic method information #96528
Closed

build-analysisBot mentioned this pull request Jun 13, 2024
System.Net.Security.Tests.SslStreamTlsResumeTests failing #103354
Closed

filipnavara mentioned this pull request Jul 6, 2024
Stack Trace missing for NativeAOT App getsentry/sentry-dotnet#3439
Closed

github-actionsBot locked and limited conversation to collaborators Jul 13, 2024

Add new DiagnosticMethodInfo public API
a4f8036

MichalStrehovsky added the area-System.Diagnostics label Jun 10, 2024

ghost added the new-api-needs-documentation label Jun 10, 2024

dotnet-policy-serviceBot assigned MichalStrehovsky Jun 10, 2024

MichalStrehovsky marked this pull request as draft June 10, 2024 09:22

{bad luck brian}
de5cf36

MichalStrehovsky mentioned this pull request Jun 11, 2024
Assertion failed: The class hierarchy should declare the method #103268
Closed

MichalStrehovsky added 3 commits June 11, 2024 06:31

Skip CoreCLR and Mono bugs
6397898

More tests
21783d3

Use in Tasks logging
dd48955

github-actionsBot mentioned this pull request Jun 11, 2024
103220 MichalStrehovsky/rt-sz#29
Closed

build-analysisBot mentioned this pull request Jun 11, 2024
[browser][ST] Wasm tests timeout #103246
Closed

MichalStrehovsky commented Jun 11, 2024
View reviewed changes

This was referenced Jun 11, 2024
Wasm test failure: Unable to evaluate script: target frame detached #102957
Closed
[wasm][chrome] Unable to evaluate script: disconnected: unable to send message to renderer #103061
Closed

Update ILLink.Substitutions.Shared.xml
406ac37

MichalStrehovsky marked this pull request as ready for review June 12, 2024 08:37

jkotas reviewed Jun 12, 2024
View reviewed changes

jkotas approved these changes Jun 13, 2024
View reviewed changes

MichalStrehovsky merged commit 5b79b76 into dotnet:mainJun 13, 2024

MichalStrehovsky deleted the diagmethodinfo branch June 13, 2024 07:45

MichalStrehovsky mentioned this pull request Jun 13, 2024
[API Proposal]: Diagnostic method information #96528
Closed

build-analysisBot mentioned this pull request Jun 13, 2024
System.Net.Security.Tests.SslStreamTlsResumeTests failing #103354
Closed

filipnavara mentioned this pull request Jul 6, 2024
Stack Trace missing for NativeAOT App getsentry/sentry-dotnet#3439
Closed

github-actionsBot locked and limited conversation to collaborators Jul 13, 2024

Add new DiagnosticMethodInfo public API
a4f8036

MichalStrehovsky added the area-System.Diagnostics label Jun 10, 2024

ghost added the new-api-needs-documentation label Jun 10, 2024

dotnet-policy-serviceBot assigned MichalStrehovsky Jun 10, 2024

MichalStrehovsky marked this pull request as draft June 10, 2024 09:22

{bad luck brian}
de5cf36

MichalStrehovsky mentioned this pull request Jun 11, 2024
Assertion failed: The class hierarchy should declare the method #103268
Closed

MichalStrehovsky added 3 commits June 11, 2024 06:31

Skip CoreCLR and Mono bugs
6397898

More tests
21783d3

Use in Tasks logging
dd48955

github-actionsBot mentioned this pull request Jun 11, 2024
103220 MichalStrehovsky/rt-sz#29
Closed

build-analysisBot mentioned this pull request Jun 11, 2024
[browser][ST] Wasm tests timeout #103246
Closed

MichalStrehovsky commented Jun 11, 2024
View reviewed changes

This was referenced Jun 11, 2024
Wasm test failure: Unable to evaluate script: target frame detached #102957
Closed
[wasm][chrome] Unable to evaluate script: disconnected: unable to send message to renderer #103061
Closed

Update ILLink.Substitutions.Shared.xml
406ac37

MichalStrehovsky marked this pull request as ready for review June 12, 2024 08:37

jkotas reviewed Jun 12, 2024
View reviewed changes

jkotas approved these changes Jun 13, 2024
View reviewed changes

MichalStrehovsky merged commit 5b79b76 into dotnet:mainJun 13, 2024

MichalStrehovsky deleted the diagmethodinfo branch June 13, 2024 07:45

MichalStrehovsky mentioned this pull request Jun 13, 2024
[API Proposal]: Diagnostic method information #96528
Closed

build-analysisBot mentioned this pull request Jun 13, 2024
System.Net.Security.Tests.SslStreamTlsResumeTests failing #103354
Closed

filipnavara mentioned this pull request Jul 6, 2024
Stack Trace missing for NativeAOT App getsentry/sentry-dotnet#3439
Closed

github-actionsBot locked and limited conversation to collaborators Jul 13, 2024

Add new DiagnosticMethodInfo public API
a4f8036

MichalStrehovsky added the area-System.Diagnostics label Jun 10, 2024

ghost added the new-api-needs-documentation label Jun 10, 2024

dotnet-policy-serviceBot assigned MichalStrehovsky Jun 10, 2024

MichalStrehovsky marked this pull request as draft June 10, 2024 09:22

{bad luck brian}
de5cf36

MichalStrehovsky mentioned this pull request Jun 11, 2024
Assertion failed: The class hierarchy should declare the method #103268
Closed

MichalStrehovsky added 3 commits June 11, 2024 06:31

Skip CoreCLR and Mono bugs
6397898

More tests
21783d3

Use in Tasks logging
dd48955

github-actionsBot mentioned this pull request Jun 11, 2024
103220 MichalStrehovsky/rt-sz#29
Closed

build-analysisBot mentioned this pull request Jun 11, 2024
[browser][ST] Wasm tests timeout #103246
Closed

MichalStrehovsky commented Jun 11, 2024
View reviewed changes

This was referenced Jun 11, 2024
Wasm test failure: Unable to evaluate script: target frame detached #102957
Closed
[wasm][chrome] Unable to evaluate script: disconnected: unable to send message to renderer #103061
Closed

Update ILLink.Substitutions.Shared.xml
406ac37

MichalStrehovsky marked this pull request as ready for review June 12, 2024 08:37

jkotas reviewed Jun 12, 2024
View reviewed changes

jkotas approved these changes Jun 13, 2024
View reviewed changes

MichalStrehovsky merged commit 5b79b76 into dotnet:mainJun 13, 2024

MichalStrehovsky deleted the diagmethodinfo branch June 13, 2024 07:45

MichalStrehovsky mentioned this pull request Jun 13, 2024
[API Proposal]: Diagnostic method information #96528
Closed

build-analysisBot mentioned this pull request Jun 13, 2024
System.Net.Security.Tests.SslStreamTlsResumeTests failing #103354
Closed

filipnavara mentioned this pull request Jul 6, 2024
Stack Trace missing for NativeAOT App getsentry/sentry-dotnet#3439
Closed

github-actionsBot locked and limited conversation to collaborators Jul 13, 2024

Add new DiagnosticMethodInfo public API
a4f8036

MichalStrehovsky added the area-System.Diagnostics label Jun 10, 2024

ghost added the new-api-needs-documentation label Jun 10, 2024

dotnet-policy-serviceBot assigned MichalStrehovsky Jun 10, 2024

MichalStrehovsky marked this pull request as draft June 10, 2024 09:22

{bad luck brian}
de5cf36

MichalStrehovsky mentioned this pull request Jun 11, 2024
Assertion failed: The class hierarchy should declare the method #103268
Closed

MichalStrehovsky added 3 commits June 11, 2024 06:31

Skip CoreCLR and Mono bugs
6397898

More tests
21783d3

Use in Tasks logging
dd48955

github-actionsBot mentioned this pull request Jun 11, 2024
103220 MichalStrehovsky/rt-sz#29
Closed

build-analysisBot mentioned this pull request Jun 11, 2024
[browser][ST] Wasm tests timeout #103246
Closed

MichalStrehovsky commented Jun 11, 2024
View reviewed changes

This was referenced Jun 11, 2024
Wasm test failure: Unable to evaluate script: target frame detached #102957
Closed
[wasm][chrome] Unable to evaluate script: disconnected: unable to send message to renderer #103061
Closed

Update ILLink.Substitutions.Shared.xml
406ac37

MichalStrehovsky marked this pull request as ready for review June 12, 2024 08:37

jkotas reviewed Jun 12, 2024
View reviewed changes

jkotas approved these changes Jun 13, 2024
View reviewed changes

MichalStrehovsky merged commit 5b79b76 into dotnet:mainJun 13, 2024

MichalStrehovsky deleted the diagmethodinfo branch June 13, 2024 07:45

MichalStrehovsky mentioned this pull request Jun 13, 2024
[API Proposal]: Diagnostic method information #96528
Closed

build-analysisBot mentioned this pull request Jun 13, 2024
System.Net.Security.Tests.SslStreamTlsResumeTests failing #103354
Closed

filipnavara mentioned this pull request Jul 6, 2024
Stack Trace missing for NativeAOT App getsentry/sentry-dotnet#3439
Closed

github-actionsBot locked and limited conversation to collaborators Jul 13, 2024

Add new DiagnosticMethodInfo public API
a4f8036

MichalStrehovsky added the area-System.Diagnostics label Jun 10, 2024

ghost added the new-api-needs-documentation label Jun 10, 2024

dotnet-policy-serviceBot assigned MichalStrehovsky Jun 10, 2024

MichalStrehovsky marked this pull request as draft June 10, 2024 09:22

{bad luck brian}
de5cf36

MichalStrehovsky mentioned this pull request Jun 11, 2024
Assertion failed: The class hierarchy should declare the method #103268
Closed

MichalStrehovsky added 3 commits June 11, 2024 06:31

Skip CoreCLR and Mono bugs
6397898

More tests
21783d3

Use in Tasks logging
dd48955

github-actionsBot mentioned this pull request Jun 11, 2024
103220 MichalStrehovsky/rt-sz#29
Closed

build-analysisBot mentioned this pull request Jun 11, 2024
[browser][ST] Wasm tests timeout #103246
Closed

MichalStrehovsky commented Jun 11, 2024
View reviewed changes

This was referenced Jun 11, 2024
Wasm test failure: Unable to evaluate script: target frame detached #102957
Closed
[wasm][chrome] Unable to evaluate script: disconnected: unable to send message to renderer #103061
Closed

Update ILLink.Substitutions.Shared.xml
406ac37

MichalStrehovsky marked this pull request as ready for review June 12, 2024 08:37

jkotas reviewed Jun 12, 2024
View reviewed changes

jkotas approved these changes Jun 13, 2024
View reviewed changes

MichalStrehovsky merged commit 5b79b76 into dotnet:mainJun 13, 2024

MichalStrehovsky deleted the diagmethodinfo branch June 13, 2024 07:45

MichalStrehovsky mentioned this pull request Jun 13, 2024
[API Proposal]: Diagnostic method information #96528
Closed

build-analysisBot mentioned this pull request Jun 13, 2024
System.Net.Security.Tests.SslStreamTlsResumeTests failing #103354
Closed

filipnavara mentioned this pull request Jul 6, 2024
Stack Trace missing for NativeAOT App getsentry/sentry-dotnet#3439
Closed

github-actionsBot locked and limited conversation to collaborators Jul 13, 2024

		DiagnosticMethodInfo? dmi = DiagnosticMethodInfo.Create(@delegate);
		return dmi?.Name ?? "<unknown>";

-DiagnosticMethodInfo?dmi=DiagnosticMethodInfo.Create(@delegate);
-returndmi?.Name??"<unknown>";
+if(StackTrace.IsSupported)
+{
+DiagnosticMethodInfo?dmi=DiagnosticMethodInfo.Create(@delegate);
+returndmi!.Name;
+}
+ else
+{
+return@delegate.Method.Name;
+}

Uh oh!

Conversation

MichalStrehovsky commented Jun 10, 2024• edited by jkotas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jun 10, 2024

Uh oh!

ghost commented Jun 10, 2024

Uh oh!

dotnet-policy-serviceBot commented Jun 10, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MichalStrehovsky commented Jun 11, 2024

Uh oh!

azure-pipelinesBot commented Jun 11, 2024

Uh oh!

MichalStrehovsky commented Jun 11, 2024

Uh oh!

MichalStrehovsky commented Jun 12, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

MichalStrehovsky commented Jun 10, 2024• edited by jkotas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jun 10, 2024

Uh oh!

ghost commented Jun 10, 2024

Uh oh!

dotnet-policy-serviceBot commented Jun 10, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MichalStrehovsky commented Jun 11, 2024

Uh oh!

azure-pipelinesBot commented Jun 11, 2024

Uh oh!

MichalStrehovsky commented Jun 11, 2024

Uh oh!

MichalStrehovsky commented Jun 12, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

MichalStrehovsky commented Jun 10, 2024• edited by jkotas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Jun 10, 2024

Uh oh!

ghost commented Jun 10, 2024

MichalStrehovsky commented Jun 10, 2024•
edited by jkotas
Loading

MichalStrehovsky commented Jun 10, 2024•
edited by jkotas
Loading

MichalStrehovsky commented Jun 10, 2024•
edited by jkotas
Loading

MichalStrehovsky commented Jun 10, 2024•
edited by jkotas
Loading