[main] Update dependencies from dotnet/arcade - #103279

Merged
akoeplinger merged 4 commits into
mainfrom
darc-main-92f07a0d-b69c-4e84-8263-881d34bec968
Jun 12, 2024
Merged

[main] Update dependencies from dotnet/arcade#103279
akoeplinger merged 4 commits into
mainfrom
darc-main-92f07a0d-b69c-4e84-8263-881d34bec968

Conversation

@dotnet-maestro

@dotnet-maestrodotnet-maestroBot commented Jun 11, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20240611.10
  • Date Produced: June 12, 2024 3:03:13 AM UTC
  • Commit: ef3e671d0a92f5e7ebef53cd15b44b33dd04ef25
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
18fbbff
…611.1
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.1
@ghostghost added the area-codeflow for labeling automated codeflow label Jun 11, 2024
@DragosDanielBoia

DragosDanielBoia commented Jun 11, 2024

Copy link
Copy Markdown
Contributor

@dotnet-policy-service rerun

1 similar comment
@DragosDanielBoia

DragosDanielBoia commented Jun 11, 2024

Copy link
Copy Markdown
Contributor

@dotnet-policy-service rerun

This was referenced Jun 11, 2024
Closed
Open
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
d19db56
…611.10
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10
This was referenced Jun 12, 2024
Closed
Closed
Closed
Closed
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
f0385a4
…611.10
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10
@agocke

agocke commented Jun 12, 2024

Copy link
Copy Markdown
Member

@ViktorHofer can you take a look at these new test failures from arcade?

@build-analysisbuild-analysisBot mentioned this pull request Jun 12, 2024
Closed
@lewing

lewing commented Jun 12, 2024

Copy link
Copy Markdown
Member

The official build is blocked on this update

@ViktorHofer

ViktorHofer commented Jun 12, 2024

Copy link
Copy Markdown
Member

The official build is blocked on this update

Resolving the test failures will probably take some time. What exactly do you need from this update to unblock official builds?

@lewing

lewing commented Jun 12, 2024

Copy link
Copy Markdown
Member

The official build is blocked on this update

Resolving the test failures will probably take some time. What exactly do you need from this update to unblock official builds?

when it wasn't failing from infra it was failing from https://dev.azure.com/dnceng/internal/_build/results?buildId=2471323&view=logs&j=5c24930e-0ae1-546c-7353-8c3b261a7651&t=90d1b216-f511-5956-2766-23f92c36b673&l=21

@ViktorHofer

ViktorHofer commented Jun 12, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Ok, so you just need the eng/common publish-using-darc.ps1 update. Would you mind opening a separate PR just with that?

@lewing

lewing commented Jun 12, 2024

Copy link
Copy Markdown
Member

Ok, so you just need the eng/common publish-using-darc.ps1 update. Would you mind opening a separate PR just with that?

#103355

@lewinglewing mentioned this pull request Jun 12, 2024
Merged
@agocke

agocke commented Jun 12, 2024

Copy link
Copy Markdown
Member

@ViktorHofer Can we back out the breaking changes in the meantime, to avoid holding up Arcade flow?

Overall, I'd rather not pick and choose arcade changes. It puts us in a split state.

@ViktorHofer

ViktorHofer commented Jun 12, 2024•
edited
Loading

Copy link
Copy Markdown
Member

@ViktorHofer Can we back out the breaking changes in the meantime, to avoid holding up Arcade flow?

We are talking about an external component here, xunit. We might be able to pin to an older version in runtime but as we compile against a newer version in Arcade and reference those components (i.e. XUnitExtensions and XUnitAssert) that might not work.

Other repositories already took a dependency on the newer xunit version (templating & sdk) so we can't (and don't want to) go back on an older version of xunit in Arcade.

Given that #103355 fixes the official build, I'm not sure if there's a better option here.

The issue here is just that some of our tests are written incorrectly as they assert on a behavior which was never guaranteed and which now changed with the xunit update.

@akoeplinger
Fix BasicEventSourceTest
bed2ef0
xunit added a new event source that we need to filter out: xunit/xunit#2884
@akoeplinger

akoeplinger commented Jun 12, 2024

Copy link
Copy Markdown
Member

/ba-g test failure in System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds is unrelated

@akoeplinger
akoeplinger merged commit 92534ff into mainJun 12, 2024
@akoeplinger
akoeplinger deleted the darc-main-92f07a0d-b69c-4e84-8263-881d34bec968 branch June 12, 2024 21:17
@build-analysisbuild-analysisBot mentioned this pull request Jun 12, 2024
Closed
@MihaZupanMihaZupan mentioned this pull request Jun 13, 2024
Closed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewinglewing approved these changes

Assignees

No one assigned

Labels

area-codeflowfor labeling automated codeflow

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DragosDanielBoia@agocke@lewing@ViktorHofer@akoeplinger
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[main] Update dependencies from dotnet/arcade - #103279
Merged
akoeplinger merged 4 commits into
mainfrom 
darc-main-92f07a0d-b69c-4e84-8263-881d34bec968
Jun 12, 2024
Merged
[main] Update dependencies from dotnet/arcade#103279
akoeplinger merged 4 commits into
mainfrom 
darc-main-92f07a0d-b69c-4e84-8263-881d34bec968
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Jun 11, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20240611.10
  • Date Produced: June 12, 2024 3:03:13 AM UTC
  • Commit: ef3e671d0a92f5e7ebef53cd15b44b33dd04ef25
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
18fbbff
…611.1
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Jun 11, 2024
@DragosDanielBoia
DragosDanielBoia
commented
Jun 11, 2024

Copy link


Copy Markdown

Contributor
@dotnet-policy-service rerun

1 similar comment

@DragosDanielBoia
DragosDanielBoia
commented
Jun 11, 2024

Copy link


Copy Markdown

Contributor
@dotnet-policy-service rerun

This was referenced Jun 11, 2024

Closed


Open

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
d19db56
…611.10
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10

This was referenced Jun 12, 2024

Closed


Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
f0385a4
…611.10
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10
@agocke
agocke
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
@ViktorHofer can you take a look at these new test failures from arcade?
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2024

Closed

@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
Resolving the test failures will probably take some time. What exactly do you need from this update to unblock official builds?
@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
Resolving the test failures will probably take some time. What exactly do you need from this update to unblock official builds?
when it wasn't failing from infra it was failing from https://dev.azure.com/dnceng/internal/_build/results?buildId=2471323&view=logs&j=5c24930e-0ae1-546c-7353-8c3b261a7651&t=90d1b216-f511-5956-2766-23f92c36b673&l=21
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Ok, so you just need the eng/common publish-using-darc.ps1 update. Would you mind opening a separate PR just with that?
@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
Ok, so you just need the eng/common publish-using-darc.ps1 update. Would you mind opening a separate PR just with that?
#103355
@lewinglewing
mentioned this pull request
Jun 12, 2024
 Merged

@agocke
agocke
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
@ViktorHofer Can we back out the breaking changes in the meantime, to avoid holding up Arcade flow?
Overall, I'd rather not pick and choose arcade changes. It puts us in a split state.
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@ViktorHofer Can we back out the breaking changes in the meantime, to avoid holding up Arcade flow?
We are talking about an external component here, xunit. We might be able to pin to an older version in runtime but as we compile against a newer version in Arcade and reference those components (i.e. XUnitExtensions and XUnitAssert) that might not work.
Other repositories already took a dependency on the newer xunit version (templating & sdk) so we can't (and don't want to) go back on an older version of xunit in Arcade.
Given that #103355 fixes the official build, I'm not sure if there's a better option here.
The issue here is just that some of our tests are written incorrectly as they assert on a behavior which was never guaranteed and which now changed with the xunit update.
@akoeplinger
Fix BasicEventSourceTest
bed2ef0
xunit added a new event source that we need to filter out: xunit/xunit#2884
@akoeplinger
akoeplinger
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
/ba-g test failure in System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds is unrelated
@akoeplinger
akoeplinger
merged commit 92534ff
into
mainJun 12, 2024
@akoeplinger
akoeplinger
deleted the

darc-main-92f07a0d-b69c-4e84-8263-881d34bec968

branch
June 12, 2024 21:17
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2024

Closed

@MihaZupanMihaZupan
mentioned this pull request
Jun 13, 2024

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@DragosDanielBoia@agocke@lewing@ViktorHofer@akoeplinger

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[main] Update dependencies from dotnet/arcade - #103279
Merged
akoeplinger merged 4 commits into
mainfrom 
darc-main-92f07a0d-b69c-4e84-8263-881d34bec968
Jun 12, 2024
Merged
[main] Update dependencies from dotnet/arcade#103279
akoeplinger merged 4 commits into
mainfrom 
darc-main-92f07a0d-b69c-4e84-8263-881d34bec968
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Jun 11, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20240611.10
  • Date Produced: June 12, 2024 3:03:13 AM UTC
  • Commit: ef3e671d0a92f5e7ebef53cd15b44b33dd04ef25
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
18fbbff
…611.1
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Jun 11, 2024
@DragosDanielBoia
DragosDanielBoia
commented
Jun 11, 2024

Copy link


Copy Markdown

Contributor
@dotnet-policy-service rerun

1 similar comment

@DragosDanielBoia
DragosDanielBoia
commented
Jun 11, 2024

Copy link


Copy Markdown

Contributor
@dotnet-policy-service rerun

This was referenced Jun 11, 2024

Closed


Open

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
d19db56
…611.10
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10

This was referenced Jun 12, 2024

Closed


Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
f0385a4
…611.10
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10
@agocke
agocke
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
@ViktorHofer can you take a look at these new test failures from arcade?
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2024

Closed

@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
Resolving the test failures will probably take some time. What exactly do you need from this update to unblock official builds?
@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
Resolving the test failures will probably take some time. What exactly do you need from this update to unblock official builds?
when it wasn't failing from infra it was failing from https://dev.azure.com/dnceng/internal/_build/results?buildId=2471323&view=logs&j=5c24930e-0ae1-546c-7353-8c3b261a7651&t=90d1b216-f511-5956-2766-23f92c36b673&l=21
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Ok, so you just need the eng/common publish-using-darc.ps1 update. Would you mind opening a separate PR just with that?
@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
Ok, so you just need the eng/common publish-using-darc.ps1 update. Would you mind opening a separate PR just with that?
#103355
@lewinglewing
mentioned this pull request
Jun 12, 2024
 Merged

@agocke
agocke
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
@ViktorHofer Can we back out the breaking changes in the meantime, to avoid holding up Arcade flow?
Overall, I'd rather not pick and choose arcade changes. It puts us in a split state.
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@ViktorHofer Can we back out the breaking changes in the meantime, to avoid holding up Arcade flow?
We are talking about an external component here, xunit. We might be able to pin to an older version in runtime but as we compile against a newer version in Arcade and reference those components (i.e. XUnitExtensions and XUnitAssert) that might not work.
Other repositories already took a dependency on the newer xunit version (templating & sdk) so we can't (and don't want to) go back on an older version of xunit in Arcade.
Given that #103355 fixes the official build, I'm not sure if there's a better option here.
The issue here is just that some of our tests are written incorrectly as they assert on a behavior which was never guaranteed and which now changed with the xunit update.
@akoeplinger
Fix BasicEventSourceTest
bed2ef0
xunit added a new event source that we need to filter out: xunit/xunit#2884
@akoeplinger
akoeplinger
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
/ba-g test failure in System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds is unrelated
@akoeplinger
akoeplinger
merged commit 92534ff
into
mainJun 12, 2024
@akoeplinger
akoeplinger
deleted the

darc-main-92f07a0d-b69c-4e84-8263-881d34bec968

branch
June 12, 2024 21:17
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2024

Closed

@MihaZupanMihaZupan
mentioned this pull request
Jun 13, 2024

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@DragosDanielBoia@agocke@lewing@ViktorHofer@akoeplinger

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[main] Update dependencies from dotnet/arcade - #103279
Merged
akoeplinger merged 4 commits into
mainfrom 
darc-main-92f07a0d-b69c-4e84-8263-881d34bec968
Jun 12, 2024
Merged
[main] Update dependencies from dotnet/arcade#103279
akoeplinger merged 4 commits into
mainfrom 
darc-main-92f07a0d-b69c-4e84-8263-881d34bec968
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Jun 11, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20240611.10
  • Date Produced: June 12, 2024 3:03:13 AM UTC
  • Commit: ef3e671d0a92f5e7ebef53cd15b44b33dd04ef25
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
18fbbff
…611.1
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Jun 11, 2024
@DragosDanielBoia
DragosDanielBoia
commented
Jun 11, 2024

Copy link


Copy Markdown

Contributor
@dotnet-policy-service rerun

1 similar comment

@DragosDanielBoia
DragosDanielBoia
commented
Jun 11, 2024

Copy link


Copy Markdown

Contributor
@dotnet-policy-service rerun

This was referenced Jun 11, 2024

Closed


Open

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
d19db56
…611.10
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10

This was referenced Jun 12, 2024

Closed


Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
f0385a4
…611.10
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10
@agocke
agocke
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
@ViktorHofer can you take a look at these new test failures from arcade?
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2024

Closed

@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
Resolving the test failures will probably take some time. What exactly do you need from this update to unblock official builds?
@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
Resolving the test failures will probably take some time. What exactly do you need from this update to unblock official builds?
when it wasn't failing from infra it was failing from https://dev.azure.com/dnceng/internal/_build/results?buildId=2471323&view=logs&j=5c24930e-0ae1-546c-7353-8c3b261a7651&t=90d1b216-f511-5956-2766-23f92c36b673&l=21
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Ok, so you just need the eng/common publish-using-darc.ps1 update. Would you mind opening a separate PR just with that?
@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
Ok, so you just need the eng/common publish-using-darc.ps1 update. Would you mind opening a separate PR just with that?
#103355
@lewinglewing
mentioned this pull request
Jun 12, 2024
 Merged

@agocke
agocke
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
@ViktorHofer Can we back out the breaking changes in the meantime, to avoid holding up Arcade flow?
Overall, I'd rather not pick and choose arcade changes. It puts us in a split state.
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@ViktorHofer Can we back out the breaking changes in the meantime, to avoid holding up Arcade flow?
We are talking about an external component here, xunit. We might be able to pin to an older version in runtime but as we compile against a newer version in Arcade and reference those components (i.e. XUnitExtensions and XUnitAssert) that might not work.
Other repositories already took a dependency on the newer xunit version (templating & sdk) so we can't (and don't want to) go back on an older version of xunit in Arcade.
Given that #103355 fixes the official build, I'm not sure if there's a better option here.
The issue here is just that some of our tests are written incorrectly as they assert on a behavior which was never guaranteed and which now changed with the xunit update.
@akoeplinger
Fix BasicEventSourceTest
bed2ef0
xunit added a new event source that we need to filter out: xunit/xunit#2884
@akoeplinger
akoeplinger
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
/ba-g test failure in System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds is unrelated
@akoeplinger
akoeplinger
merged commit 92534ff
into
mainJun 12, 2024
@akoeplinger
akoeplinger
deleted the

darc-main-92f07a0d-b69c-4e84-8263-881d34bec968

branch
June 12, 2024 21:17
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2024

Closed

@MihaZupanMihaZupan
mentioned this pull request
Jun 13, 2024

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@DragosDanielBoia@agocke@lewing@ViktorHofer@akoeplinger

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[main] Update dependencies from dotnet/arcade - #103279
Merged
akoeplinger merged 4 commits into
mainfrom 
darc-main-92f07a0d-b69c-4e84-8263-881d34bec968
Jun 12, 2024
Merged
[main] Update dependencies from dotnet/arcade#103279
akoeplinger merged 4 commits into
mainfrom 
darc-main-92f07a0d-b69c-4e84-8263-881d34bec968
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Jun 11, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20240611.10
  • Date Produced: June 12, 2024 3:03:13 AM UTC
  • Commit: ef3e671d0a92f5e7ebef53cd15b44b33dd04ef25
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
18fbbff
…611.1
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Jun 11, 2024
@DragosDanielBoia
DragosDanielBoia
commented
Jun 11, 2024

Copy link


Copy Markdown

Contributor
@dotnet-policy-service rerun

1 similar comment

@DragosDanielBoia
DragosDanielBoia
commented
Jun 11, 2024

Copy link


Copy Markdown

Contributor
@dotnet-policy-service rerun

This was referenced Jun 11, 2024

Closed


Open

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
d19db56
…611.10
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10

This was referenced Jun 12, 2024

Closed


Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
f0385a4
…611.10
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10
@agocke
agocke
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
@ViktorHofer can you take a look at these new test failures from arcade?
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2024

Closed

@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
Resolving the test failures will probably take some time. What exactly do you need from this update to unblock official builds?
@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
Resolving the test failures will probably take some time. What exactly do you need from this update to unblock official builds?
when it wasn't failing from infra it was failing from https://dev.azure.com/dnceng/internal/_build/results?buildId=2471323&view=logs&j=5c24930e-0ae1-546c-7353-8c3b261a7651&t=90d1b216-f511-5956-2766-23f92c36b673&l=21
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Ok, so you just need the eng/common publish-using-darc.ps1 update. Would you mind opening a separate PR just with that?
@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
Ok, so you just need the eng/common publish-using-darc.ps1 update. Would you mind opening a separate PR just with that?
#103355
@lewinglewing
mentioned this pull request
Jun 12, 2024
 Merged

@agocke
agocke
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
@ViktorHofer Can we back out the breaking changes in the meantime, to avoid holding up Arcade flow?
Overall, I'd rather not pick and choose arcade changes. It puts us in a split state.
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@ViktorHofer Can we back out the breaking changes in the meantime, to avoid holding up Arcade flow?
We are talking about an external component here, xunit. We might be able to pin to an older version in runtime but as we compile against a newer version in Arcade and reference those components (i.e. XUnitExtensions and XUnitAssert) that might not work.
Other repositories already took a dependency on the newer xunit version (templating & sdk) so we can't (and don't want to) go back on an older version of xunit in Arcade.
Given that #103355 fixes the official build, I'm not sure if there's a better option here.
The issue here is just that some of our tests are written incorrectly as they assert on a behavior which was never guaranteed and which now changed with the xunit update.
@akoeplinger
Fix BasicEventSourceTest
bed2ef0
xunit added a new event source that we need to filter out: xunit/xunit#2884
@akoeplinger
akoeplinger
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
/ba-g test failure in System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds is unrelated
@akoeplinger
akoeplinger
merged commit 92534ff
into
mainJun 12, 2024
@akoeplinger
akoeplinger
deleted the

darc-main-92f07a0d-b69c-4e84-8263-881d34bec968

branch
June 12, 2024 21:17
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2024

Closed

@MihaZupanMihaZupan
mentioned this pull request
Jun 13, 2024

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@DragosDanielBoia@agocke@lewing@ViktorHofer@akoeplinger

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[main] Update dependencies from dotnet/arcade - #103279
Merged
akoeplinger merged 4 commits into
mainfrom 
darc-main-92f07a0d-b69c-4e84-8263-881d34bec968
Jun 12, 2024
Merged
[main] Update dependencies from dotnet/arcade#103279
akoeplinger merged 4 commits into
mainfrom 
darc-main-92f07a0d-b69c-4e84-8263-881d34bec968
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Jun 11, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20240611.10
  • Date Produced: June 12, 2024 3:03:13 AM UTC
  • Commit: ef3e671d0a92f5e7ebef53cd15b44b33dd04ef25
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
18fbbff
…611.1
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Jun 11, 2024
@DragosDanielBoia
DragosDanielBoia
commented
Jun 11, 2024

Copy link


Copy Markdown

Contributor
@dotnet-policy-service rerun

1 similar comment

@DragosDanielBoia
DragosDanielBoia
commented
Jun 11, 2024

Copy link


Copy Markdown

Contributor
@dotnet-policy-service rerun

This was referenced Jun 11, 2024

Closed


Open

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
d19db56
…611.10
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10

This was referenced Jun 12, 2024

Closed


Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
f0385a4
…611.10
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10
@agocke
agocke
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
@ViktorHofer can you take a look at these new test failures from arcade?
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2024

Closed

@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
Resolving the test failures will probably take some time. What exactly do you need from this update to unblock official builds?
@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
Resolving the test failures will probably take some time. What exactly do you need from this update to unblock official builds?
when it wasn't failing from infra it was failing from https://dev.azure.com/dnceng/internal/_build/results?buildId=2471323&view=logs&j=5c24930e-0ae1-546c-7353-8c3b261a7651&t=90d1b216-f511-5956-2766-23f92c36b673&l=21
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Ok, so you just need the eng/common publish-using-darc.ps1 update. Would you mind opening a separate PR just with that?
@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
Ok, so you just need the eng/common publish-using-darc.ps1 update. Would you mind opening a separate PR just with that?
#103355
@lewinglewing
mentioned this pull request
Jun 12, 2024
 Merged

@agocke
agocke
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
@ViktorHofer Can we back out the breaking changes in the meantime, to avoid holding up Arcade flow?
Overall, I'd rather not pick and choose arcade changes. It puts us in a split state.
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@ViktorHofer Can we back out the breaking changes in the meantime, to avoid holding up Arcade flow?
We are talking about an external component here, xunit. We might be able to pin to an older version in runtime but as we compile against a newer version in Arcade and reference those components (i.e. XUnitExtensions and XUnitAssert) that might not work.
Other repositories already took a dependency on the newer xunit version (templating & sdk) so we can't (and don't want to) go back on an older version of xunit in Arcade.
Given that #103355 fixes the official build, I'm not sure if there's a better option here.
The issue here is just that some of our tests are written incorrectly as they assert on a behavior which was never guaranteed and which now changed with the xunit update.
@akoeplinger
Fix BasicEventSourceTest
bed2ef0
xunit added a new event source that we need to filter out: xunit/xunit#2884
@akoeplinger
akoeplinger
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
/ba-g test failure in System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds is unrelated
@akoeplinger
akoeplinger
merged commit 92534ff
into
mainJun 12, 2024
@akoeplinger
akoeplinger
deleted the

darc-main-92f07a0d-b69c-4e84-8263-881d34bec968

branch
June 12, 2024 21:17
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2024

Closed

@MihaZupanMihaZupan
mentioned this pull request
Jun 13, 2024

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@DragosDanielBoia@agocke@lewing@ViktorHofer@akoeplinger

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[main] Update dependencies from dotnet/arcade - #103279
Merged
akoeplinger merged 4 commits into
mainfrom 
darc-main-92f07a0d-b69c-4e84-8263-881d34bec968
Jun 12, 2024
Merged
[main] Update dependencies from dotnet/arcade#103279
akoeplinger merged 4 commits into
mainfrom 
darc-main-92f07a0d-b69c-4e84-8263-881d34bec968
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Jun 11, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20240611.10
  • Date Produced: June 12, 2024 3:03:13 AM UTC
  • Commit: ef3e671d0a92f5e7ebef53cd15b44b33dd04ef25
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
18fbbff
…611.1
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Jun 11, 2024
@DragosDanielBoia
DragosDanielBoia
commented
Jun 11, 2024

Copy link


Copy Markdown

Contributor
@dotnet-policy-service rerun

1 similar comment

@DragosDanielBoia
DragosDanielBoia
commented
Jun 11, 2024

Copy link


Copy Markdown

Contributor
@dotnet-policy-service rerun

This was referenced Jun 11, 2024

Closed


Open

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
d19db56
…611.10
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10

This was referenced Jun 12, 2024

Closed


Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
f0385a4
…611.10
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10
@agocke
agocke
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
@ViktorHofer can you take a look at these new test failures from arcade?
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2024

Closed

@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
Resolving the test failures will probably take some time. What exactly do you need from this update to unblock official builds?
@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
Resolving the test failures will probably take some time. What exactly do you need from this update to unblock official builds?
when it wasn't failing from infra it was failing from https://dev.azure.com/dnceng/internal/_build/results?buildId=2471323&view=logs&j=5c24930e-0ae1-546c-7353-8c3b261a7651&t=90d1b216-f511-5956-2766-23f92c36b673&l=21
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Ok, so you just need the eng/common publish-using-darc.ps1 update. Would you mind opening a separate PR just with that?
@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
Ok, so you just need the eng/common publish-using-darc.ps1 update. Would you mind opening a separate PR just with that?
#103355
@lewinglewing
mentioned this pull request
Jun 12, 2024
 Merged

@agocke
agocke
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
@ViktorHofer Can we back out the breaking changes in the meantime, to avoid holding up Arcade flow?
Overall, I'd rather not pick and choose arcade changes. It puts us in a split state.
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@ViktorHofer Can we back out the breaking changes in the meantime, to avoid holding up Arcade flow?
We are talking about an external component here, xunit. We might be able to pin to an older version in runtime but as we compile against a newer version in Arcade and reference those components (i.e. XUnitExtensions and XUnitAssert) that might not work.
Other repositories already took a dependency on the newer xunit version (templating & sdk) so we can't (and don't want to) go back on an older version of xunit in Arcade.
Given that #103355 fixes the official build, I'm not sure if there's a better option here.
The issue here is just that some of our tests are written incorrectly as they assert on a behavior which was never guaranteed and which now changed with the xunit update.
@akoeplinger
Fix BasicEventSourceTest
bed2ef0
xunit added a new event source that we need to filter out: xunit/xunit#2884
@akoeplinger
akoeplinger
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
/ba-g test failure in System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds is unrelated
@akoeplinger
akoeplinger
merged commit 92534ff
into
mainJun 12, 2024
@akoeplinger
akoeplinger
deleted the

darc-main-92f07a0d-b69c-4e84-8263-881d34bec968

branch
June 12, 2024 21:17
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2024

Closed

@MihaZupanMihaZupan
mentioned this pull request
Jun 13, 2024

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@DragosDanielBoia@agocke@lewing@ViktorHofer@akoeplinger

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[main] Update dependencies from dotnet/arcade - #103279
Merged
akoeplinger merged 4 commits into
mainfrom 
darc-main-92f07a0d-b69c-4e84-8263-881d34bec968
Jun 12, 2024
Merged
[main] Update dependencies from dotnet/arcade#103279
akoeplinger merged 4 commits into
mainfrom 
darc-main-92f07a0d-b69c-4e84-8263-881d34bec968
Conversation
@dotnet-maestro
@dotnet-maestrodotnet-maestroBot
commented
Jun 11, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
This pull request updates the following dependencies
From https://github.com/dotnet/arcade
  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20240611.10
  • Date Produced: June 12, 2024 3:03:13 AM UTC
  • Commit: ef3e671d0a92f5e7ebef53cd15b44b33dd04ef25
  • Branch: refs/heads/main
@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
18fbbff
…611.1
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.1
@ghostghost
added
the 
area-codeflow
for labeling automated codeflow
label
Jun 11, 2024
@DragosDanielBoia
DragosDanielBoia
commented
Jun 11, 2024

Copy link


Copy Markdown

Contributor
@dotnet-policy-service rerun

1 similar comment

@DragosDanielBoia
DragosDanielBoia
commented
Jun 11, 2024

Copy link


Copy Markdown

Contributor
@dotnet-policy-service rerun

This was referenced Jun 11, 2024

Closed


Open

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
d19db56
…611.10
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10

This was referenced Jun 12, 2024

Closed


Closed


Closed


Closed

@dotnet-maestro
Update dependencies fromhttps://github.com/dotnet/arcadebuild 20240…
f0385a4
…611.10
Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
From Version 9.0.0-beta.24306.4 -> To Version 9.0.0-beta.24311.10
@agocke
agocke
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
@ViktorHofer can you take a look at these new test failures from arcade?
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2024

Closed

@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
Resolving the test failures will probably take some time. What exactly do you need from this update to unblock official builds?
@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
The official build is blocked on this update
Resolving the test failures will probably take some time. What exactly do you need from this update to unblock official builds?
when it wasn't failing from infra it was failing from https://dev.azure.com/dnceng/internal/_build/results?buildId=2471323&view=logs&j=5c24930e-0ae1-546c-7353-8c3b261a7651&t=90d1b216-f511-5956-2766-23f92c36b673&l=21
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Ok, so you just need the eng/common publish-using-darc.ps1 update. Would you mind opening a separate PR just with that?
@lewing
lewing
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
Ok, so you just need the eng/common publish-using-darc.ps1 update. Would you mind opening a separate PR just with that?
#103355
@lewinglewing
mentioned this pull request
Jun 12, 2024
 Merged

@agocke
agocke
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
@ViktorHofer Can we back out the breaking changes in the meantime, to avoid holding up Arcade flow?
Overall, I'd rather not pick and choose arcade changes. It puts us in a split state.
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@ViktorHofer Can we back out the breaking changes in the meantime, to avoid holding up Arcade flow?
We are talking about an external component here, xunit. We might be able to pin to an older version in runtime but as we compile against a newer version in Arcade and reference those components (i.e. XUnitExtensions and XUnitAssert) that might not work.
Other repositories already took a dependency on the newer xunit version (templating & sdk) so we can't (and don't want to) go back on an older version of xunit in Arcade.
Given that #103355 fixes the official build, I'm not sure if there's a better option here.
The issue here is just that some of our tests are written incorrectly as they assert on a behavior which was never guaranteed and which now changed with the xunit update.
@akoeplinger
Fix BasicEventSourceTest
bed2ef0
xunit added a new event source that we need to filter out: xunit/xunit#2884
@akoeplinger
akoeplinger
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
/ba-g test failure in System.Net.Security.Tests.SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds is unrelated
@akoeplinger
akoeplinger
merged commit 92534ff
into
mainJun 12, 2024
@akoeplinger
akoeplinger
deleted the

darc-main-92f07a0d-b69c-4e84-8263-881d34bec968

branch
June 12, 2024 21:17
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 12, 2024

Closed

@MihaZupanMihaZupan
mentioned this pull request
Jun 13, 2024

Closed

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing approved these changes

Assignees


No one assigned


Labels

area-codeflowfor labeling automated codeflow

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@DragosDanielBoia@agocke@lewing@ViktorHofer@akoeplinger