Uh oh!
There was an error while loading. Please reload this page.
Add JsonSchemaExporter. - #103322
Conversation
ghost
commented
Jun 11, 2024
Note regarding the |
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
gregsdennis
left a comment
There was a problem hiding this comment.
The conversions look mostly good. I've left some comments mostly to make other readers aware of the JSON Schema side of things.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Summarizing my inline comments here that were intended to give other reviewers some JSON Schema context. Usage of |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
d5f9a62 to
54274cfCompare
Fix#102788. This implementation differs somewhat compared to the stj-schema-mapper prototype in a few ways:
OnSchemaNodeGeneratedcallback is invoked for$refschemas.$refschemas are only being generated for recursive types.{ }and{"not": true }node schemas are normalized intotrueandfalserespectively.