Skip to content

Update SDK to 9.0 Preview 5 - #103332

Merged
MichalStrehovsky merged 2 commits into
dotnet:mainfrom
MichalStrehovsky:p5
Jun 13, 2024
Merged

Update SDK to 9.0 Preview 5#103332
MichalStrehovsky merged 2 commits into
dotnet:mainfrom
MichalStrehovsky:p5

Conversation

@MichalStrehovsky

@MichalStrehovskyMichalStrehovsky commented Jun 12, 2024

Copy link
Copy Markdown
Member

No description provided.

@dotnet-policy-service

dotnet-policy-serviceBot commented Jun 12, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@MichalStrehovsky

MichalStrehovsky commented Jun 12, 2024

Copy link
Copy Markdown
MemberAuthor

Failures in the WASM legs. Not sure where the WASM legs are getting a 9.0.0-preview.5.24272.2 version of the runtime, I don't see such reference anywhere.

 Discovered: Wasi.Build.Tests (found 1 of 12 test case)
Starting: Wasi.Build.Tests (parallel test collections = on [2 threads], stop on fail = off)
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [STARTING]
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [FAIL]
Expected 0 exit code but got 150: /root/helix/work/workitem/e/dotnet-latest/dotnet run --no-silent --no-build -c Release
Standard Output:
[Release_tg0m0nmq_ivw] You must install or update .NET to run this application.
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] App: /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/9.0.0-ci/WasmAppHost/WasmAppHost.dll
[Release_tg0m0nmq_ivw] Architecture: x64
[Release_tg0m0nmq_ivw] Framework: 'Microsoft.NETCore.App', version '9.0.0-preview.5.24306.7' (x64)
[Release_tg0m0nmq_ivw] .NET location: /root/helix/work/workitem/e/dotnet-latest/
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] The following frameworks were found:
[Release_tg0m0nmq_ivw] 8.0.7 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_tg0m0nmq_ivw] 9.0.0-preview.5.24272.2 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] Learn more:
[Release_tg0m0nmq_ivw] https://aka.ms/dotnet/app-launch-failed
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] To install missing framework, download:
[Release_tg0m0nmq_ivw] https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0-preview.5.24306.7&arch=x64&rid=linux-x64&os=ubuntu.22.04

@akoeplinger

akoeplinger commented Jun 12, 2024•
edited
Loading

Copy link
Copy Markdown
Member

@MichalStrehovsky we use SdkVersionForWorkloadTesting to install an SDK for the Wasm.BuildTests, which is currently set to 9.0.100-preview.6.24277.1

runtime/eng/Versions.props

Line 257 in f6dc71b

<SdkVersionForWorkloadTesting>$(MicrosoftDotNetApiCompatTaskVersion)</SdkVersionForWorkloadTesting>

It turns out that that version of the SDK has 9.0.0-preview.5.24272.2 of the runtime: https://github.com/dotnet/sdk/blob/29b15d1fca51ca7f1d4db87c2b15e39dcaf7bb53/eng/Version.Details.xml#L18-L21

Since the version is lower it fails. A newer runtime version flowed into the SDK in the meantime so another flow from SDK into runtime should fix this. I triggered the subscription, watch #103195

@ViktorHofer

ViktorHofer commented Jun 12, 2024

Copy link
Copy Markdown
Member

If I understand this correctly this sounds like a cyclic dependency. Can we avoid this by specifying the available runtime version / SDK when invoking that component?

This was referenced Jun 12, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@akoeplinger

akoeplinger commented Jun 12, 2024

Copy link
Copy Markdown
Member

I'm not sure how, we build WasmAppHost.dll with the sdk from global.json so it embeds the runtime version into .runtimeconfig.json and then we run it on a different sdk which doesn't have that version.

I don't think it's a big deal since normally there is some time before we bump the sdk in global.json so the flow would've already happened. Eventually we want to move these tests into the VMR anyway since it's much easier to test end-to-end there.

@ViktorHofer

ViktorHofer commented Jun 12, 2024

Copy link
Copy Markdown
Member

dotnet exec --fx-version ... <-- Version of the installed Shared Framework to use to run the application.

@akoeplinger

akoeplinger commented Jun 12, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Ok, that'd work but we'd need to know the version of the shared framework which is a bit cumbersome to get (we'd need to look into what is bundled in the SDK) and might introduce other hard to diagnose failures. I still think we can live with it currently.

This was referenced Jun 12, 2024
Closed
Open
Closed
Open
@MichalStrehovsky
MichalStrehovsky merged commit 4443a7d into dotnet:mainJun 13, 2024
MichalStrehovsky added a commit that referenced this pull request Jun 13, 2024
@MichalStrehovsky
Try fixing x86 Windows legs
e8dbf12
I think we had a bad interaction between #103332 and #103273.
Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
@MichalStrehovskyMichalStrehovsky mentioned this pull request Jun 13, 2024
Merged
@EgorBoEgorBo mentioned this pull request Jun 13, 2024
Closed
lewing pushed a commit that referenced this pull request Jun 13, 2024
@MichalStrehovsky
Try fixing x86 Windows legs (#103411)
6927fea
I think we had a bad interaction between #103332 and #103273.
Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@marafmarafAwaiting requested review from marafmaraf is a code owner
@ilonatommyilonatommyAwaiting requested review from ilonatommyilonatommy is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MichalStrehovsky@akoeplinger@ViktorHofer
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Update SDK to 9.0 Preview 5 by MichalStrehovsky · Pull Request #103332 · dotnet/runtime · GitHub
Skip to content
Update SDK to 9.0 Preview 5 - #103332
Merged
MichalStrehovsky merged 2 commits into
dotnet:mainfrom 
MichalStrehovsky:p5
Jun 13, 2024
Merged
Update SDK to 9.0 Preview 5#103332
MichalStrehovsky merged 2 commits into
dotnet:mainfrom 
MichalStrehovsky:p5
Conversation
@MichalStrehovsky
@MichalStrehovskyMichalStrehovsky
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 12, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
@MichalStrehovsky
MichalStrehovsky
commented
Jun 12, 2024

Copy link


Copy Markdown

MemberAuthor
Failures in the WASM legs. Not sure where the WASM legs are getting a 9.0.0-preview.5.24272.2 version of the runtime, I don't see such reference anywhere.
 Discovered: Wasi.Build.Tests (found 1 of 12 test case)
Starting: Wasi.Build.Tests (parallel test collections = on [2 threads], stop on fail = off)
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [STARTING]
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [FAIL]
Expected 0 exit code but got 150: /root/helix/work/workitem/e/dotnet-latest/dotnet run --no-silent --no-build -c Release
Standard Output:
[Release_tg0m0nmq_ivw] You must install or update .NET to run this application.
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] App: /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/9.0.0-ci/WasmAppHost/WasmAppHost.dll
[Release_tg0m0nmq_ivw] Architecture: x64
[Release_tg0m0nmq_ivw] Framework: 'Microsoft.NETCore.App', version '9.0.0-preview.5.24306.7' (x64)
[Release_tg0m0nmq_ivw] .NET location: /root/helix/work/workitem/e/dotnet-latest/
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] The following frameworks were found:
[Release_tg0m0nmq_ivw] 8.0.7 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_tg0m0nmq_ivw] 9.0.0-preview.5.24272.2 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] Learn more:
[Release_tg0m0nmq_ivw] https://aka.ms/dotnet/app-launch-failed
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] To install missing framework, download:
[Release_tg0m0nmq_ivw] https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0-preview.5.24306.7&arch=x64&rid=linux-x64&os=ubuntu.22.04

@akoeplinger
akoeplinger
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@MichalStrehovsky we use SdkVersionForWorkloadTesting to install an SDK for the Wasm.BuildTests, which is currently set to 9.0.100-preview.6.24277.1
runtime/eng/Versions.props

Line 257
in
f6dc71b
 <SdkVersionForWorkloadTesting>$(MicrosoftDotNetApiCompatTaskVersion)</SdkVersionForWorkloadTesting> 
It turns out that that version of the SDK has 9.0.0-preview.5.24272.2 of the runtime: https://github.com/dotnet/sdk/blob/29b15d1fca51ca7f1d4db87c2b15e39dcaf7bb53/eng/Version.Details.xml#L18-L21
Since the version is lower it fails. A newer runtime version flowed into the SDK in the meantime so another flow from SDK into runtime should fix this. I triggered the subscription, watch #103195
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
If I understand this correctly this sounds like a cyclic dependency. Can we avoid this by specifying the available runtime version / SDK when invoking that component?

This was referenced Jun 12, 2024

Closed


Closed


Closed


Closed


Closed


Closed


Closed

@akoeplinger
akoeplinger
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
I'm not sure how, we build WasmAppHost.dll with the sdk from global.json so it embeds the runtime version into .runtimeconfig.json and then we run it on a different sdk which doesn't have that version.
I don't think it's a big deal since normally there is some time before we bump the sdk in global.json so the flow would've already happened. Eventually we want to move these tests into the VMR anyway since it's much easier to test end-to-end there.
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
dotnet exec --fx-version ... <-- Version of the installed Shared Framework to use to run the application.
@akoeplinger
akoeplinger
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Ok, that'd work but we'd need to know the version of the shared framework which is a bit cumbersome to get (we'd need to look into what is bundled in the SDK) and might introduce other hard to diagnose failures. I still think we can live with it currently.

This was referenced Jun 12, 2024

Closed


Open


Closed


Open

@MichalStrehovsky
MichalStrehovsky
merged commit 4443a7d
into
dotnet:mainJun 13, 2024
MichalStrehovsky added a commit
that referenced
this pull request
Jun 13, 2024
@MichalStrehovsky
Try fixing x86 Windows legs
e8dbf12
I think we had a bad interaction between #103332 and #103273.
Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Jun 13, 2024
 Merged

@EgorBoEgorBo
mentioned this pull request
Jun 13, 2024

Closed

lewing pushed a commit
that referenced
this pull request
Jun 13, 2024
@MichalStrehovsky
Try fixing x86 Windows legs (#103411)
6927fea
I think we had a bad interaction between #103332 and #103273.
Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@marafmarafAwaiting requested review from marafmaraf is a code owner
@ilonatommyilonatommyAwaiting requested review from ilonatommyilonatommy is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@MichalStrehovsky@akoeplinger@ViktorHofer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update SDK to 9.0 Preview 5 by MichalStrehovsky · Pull Request #103332 · dotnet/runtime · GitHub
Skip to content
Update SDK to 9.0 Preview 5 - #103332
Merged
MichalStrehovsky merged 2 commits into
dotnet:mainfrom 
MichalStrehovsky:p5
Jun 13, 2024
Merged
Update SDK to 9.0 Preview 5#103332
MichalStrehovsky merged 2 commits into
dotnet:mainfrom 
MichalStrehovsky:p5
Conversation
@MichalStrehovsky
@MichalStrehovskyMichalStrehovsky
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 12, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
@MichalStrehovsky
MichalStrehovsky
commented
Jun 12, 2024

Copy link


Copy Markdown

MemberAuthor
Failures in the WASM legs. Not sure where the WASM legs are getting a 9.0.0-preview.5.24272.2 version of the runtime, I don't see such reference anywhere.
 Discovered: Wasi.Build.Tests (found 1 of 12 test case)
Starting: Wasi.Build.Tests (parallel test collections = on [2 threads], stop on fail = off)
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [STARTING]
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [FAIL]
Expected 0 exit code but got 150: /root/helix/work/workitem/e/dotnet-latest/dotnet run --no-silent --no-build -c Release
Standard Output:
[Release_tg0m0nmq_ivw] You must install or update .NET to run this application.
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] App: /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/9.0.0-ci/WasmAppHost/WasmAppHost.dll
[Release_tg0m0nmq_ivw] Architecture: x64
[Release_tg0m0nmq_ivw] Framework: 'Microsoft.NETCore.App', version '9.0.0-preview.5.24306.7' (x64)
[Release_tg0m0nmq_ivw] .NET location: /root/helix/work/workitem/e/dotnet-latest/
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] The following frameworks were found:
[Release_tg0m0nmq_ivw] 8.0.7 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_tg0m0nmq_ivw] 9.0.0-preview.5.24272.2 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] Learn more:
[Release_tg0m0nmq_ivw] https://aka.ms/dotnet/app-launch-failed
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] To install missing framework, download:
[Release_tg0m0nmq_ivw] https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0-preview.5.24306.7&arch=x64&rid=linux-x64&os=ubuntu.22.04

@akoeplinger
akoeplinger
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@MichalStrehovsky we use SdkVersionForWorkloadTesting to install an SDK for the Wasm.BuildTests, which is currently set to 9.0.100-preview.6.24277.1
runtime/eng/Versions.props

Line 257
in
f6dc71b
 <SdkVersionForWorkloadTesting>$(MicrosoftDotNetApiCompatTaskVersion)</SdkVersionForWorkloadTesting> 
It turns out that that version of the SDK has 9.0.0-preview.5.24272.2 of the runtime: https://github.com/dotnet/sdk/blob/29b15d1fca51ca7f1d4db87c2b15e39dcaf7bb53/eng/Version.Details.xml#L18-L21
Since the version is lower it fails. A newer runtime version flowed into the SDK in the meantime so another flow from SDK into runtime should fix this. I triggered the subscription, watch #103195
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
If I understand this correctly this sounds like a cyclic dependency. Can we avoid this by specifying the available runtime version / SDK when invoking that component?

This was referenced Jun 12, 2024

Closed


Closed


Closed


Closed


Closed


Closed


Closed

@akoeplinger
akoeplinger
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
I'm not sure how, we build WasmAppHost.dll with the sdk from global.json so it embeds the runtime version into .runtimeconfig.json and then we run it on a different sdk which doesn't have that version.
I don't think it's a big deal since normally there is some time before we bump the sdk in global.json so the flow would've already happened. Eventually we want to move these tests into the VMR anyway since it's much easier to test end-to-end there.
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
dotnet exec --fx-version ... <-- Version of the installed Shared Framework to use to run the application.
@akoeplinger
akoeplinger
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Ok, that'd work but we'd need to know the version of the shared framework which is a bit cumbersome to get (we'd need to look into what is bundled in the SDK) and might introduce other hard to diagnose failures. I still think we can live with it currently.

This was referenced Jun 12, 2024

Closed


Open


Closed


Open

@MichalStrehovsky
MichalStrehovsky
merged commit 4443a7d
into
dotnet:mainJun 13, 2024
MichalStrehovsky added a commit
that referenced
this pull request
Jun 13, 2024
@MichalStrehovsky
Try fixing x86 Windows legs
e8dbf12
I think we had a bad interaction between #103332 and #103273.
Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Jun 13, 2024
 Merged

@EgorBoEgorBo
mentioned this pull request
Jun 13, 2024

Closed

lewing pushed a commit
that referenced
this pull request
Jun 13, 2024
@MichalStrehovsky
Try fixing x86 Windows legs (#103411)
6927fea
I think we had a bad interaction between #103332 and #103273.
Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@marafmarafAwaiting requested review from marafmaraf is a code owner
@ilonatommyilonatommyAwaiting requested review from ilonatommyilonatommy is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@MichalStrehovsky@akoeplinger@ViktorHofer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update SDK to 9.0 Preview 5 by MichalStrehovsky · Pull Request #103332 · dotnet/runtime · GitHub
Skip to content
Update SDK to 9.0 Preview 5 - #103332
Merged
MichalStrehovsky merged 2 commits into
dotnet:mainfrom 
MichalStrehovsky:p5
Jun 13, 2024
Merged
Update SDK to 9.0 Preview 5#103332
MichalStrehovsky merged 2 commits into
dotnet:mainfrom 
MichalStrehovsky:p5
Conversation
@MichalStrehovsky
@MichalStrehovskyMichalStrehovsky
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 12, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
@MichalStrehovsky
MichalStrehovsky
commented
Jun 12, 2024

Copy link


Copy Markdown

MemberAuthor
Failures in the WASM legs. Not sure where the WASM legs are getting a 9.0.0-preview.5.24272.2 version of the runtime, I don't see such reference anywhere.
 Discovered: Wasi.Build.Tests (found 1 of 12 test case)
Starting: Wasi.Build.Tests (parallel test collections = on [2 threads], stop on fail = off)
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [STARTING]
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [FAIL]
Expected 0 exit code but got 150: /root/helix/work/workitem/e/dotnet-latest/dotnet run --no-silent --no-build -c Release
Standard Output:
[Release_tg0m0nmq_ivw] You must install or update .NET to run this application.
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] App: /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/9.0.0-ci/WasmAppHost/WasmAppHost.dll
[Release_tg0m0nmq_ivw] Architecture: x64
[Release_tg0m0nmq_ivw] Framework: 'Microsoft.NETCore.App', version '9.0.0-preview.5.24306.7' (x64)
[Release_tg0m0nmq_ivw] .NET location: /root/helix/work/workitem/e/dotnet-latest/
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] The following frameworks were found:
[Release_tg0m0nmq_ivw] 8.0.7 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_tg0m0nmq_ivw] 9.0.0-preview.5.24272.2 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] Learn more:
[Release_tg0m0nmq_ivw] https://aka.ms/dotnet/app-launch-failed
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] To install missing framework, download:
[Release_tg0m0nmq_ivw] https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0-preview.5.24306.7&arch=x64&rid=linux-x64&os=ubuntu.22.04

@akoeplinger
akoeplinger
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@MichalStrehovsky we use SdkVersionForWorkloadTesting to install an SDK for the Wasm.BuildTests, which is currently set to 9.0.100-preview.6.24277.1
runtime/eng/Versions.props

Line 257
in
f6dc71b
 <SdkVersionForWorkloadTesting>$(MicrosoftDotNetApiCompatTaskVersion)</SdkVersionForWorkloadTesting> 
It turns out that that version of the SDK has 9.0.0-preview.5.24272.2 of the runtime: https://github.com/dotnet/sdk/blob/29b15d1fca51ca7f1d4db87c2b15e39dcaf7bb53/eng/Version.Details.xml#L18-L21
Since the version is lower it fails. A newer runtime version flowed into the SDK in the meantime so another flow from SDK into runtime should fix this. I triggered the subscription, watch #103195
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
If I understand this correctly this sounds like a cyclic dependency. Can we avoid this by specifying the available runtime version / SDK when invoking that component?

This was referenced Jun 12, 2024

Closed


Closed


Closed


Closed


Closed


Closed


Closed

@akoeplinger
akoeplinger
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
I'm not sure how, we build WasmAppHost.dll with the sdk from global.json so it embeds the runtime version into .runtimeconfig.json and then we run it on a different sdk which doesn't have that version.
I don't think it's a big deal since normally there is some time before we bump the sdk in global.json so the flow would've already happened. Eventually we want to move these tests into the VMR anyway since it's much easier to test end-to-end there.
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
dotnet exec --fx-version ... <-- Version of the installed Shared Framework to use to run the application.
@akoeplinger
akoeplinger
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Ok, that'd work but we'd need to know the version of the shared framework which is a bit cumbersome to get (we'd need to look into what is bundled in the SDK) and might introduce other hard to diagnose failures. I still think we can live with it currently.

This was referenced Jun 12, 2024

Closed


Open


Closed


Open

@MichalStrehovsky
MichalStrehovsky
merged commit 4443a7d
into
dotnet:mainJun 13, 2024
MichalStrehovsky added a commit
that referenced
this pull request
Jun 13, 2024
@MichalStrehovsky
Try fixing x86 Windows legs
e8dbf12
I think we had a bad interaction between #103332 and #103273.
Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Jun 13, 2024
 Merged

@EgorBoEgorBo
mentioned this pull request
Jun 13, 2024

Closed

lewing pushed a commit
that referenced
this pull request
Jun 13, 2024
@MichalStrehovsky
Try fixing x86 Windows legs (#103411)
6927fea
I think we had a bad interaction between #103332 and #103273.
Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@marafmarafAwaiting requested review from marafmaraf is a code owner
@ilonatommyilonatommyAwaiting requested review from ilonatommyilonatommy is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@MichalStrehovsky@akoeplinger@ViktorHofer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Update SDK to 9.0 Preview 5 by MichalStrehovsky · Pull Request #103332 · dotnet/runtime · GitHub
Skip to content
Update SDK to 9.0 Preview 5 - #103332
Merged
MichalStrehovsky merged 2 commits into
dotnet:mainfrom 
MichalStrehovsky:p5
Jun 13, 2024
Merged
Update SDK to 9.0 Preview 5#103332
MichalStrehovsky merged 2 commits into
dotnet:mainfrom 
MichalStrehovsky:p5
Conversation
@MichalStrehovsky
@MichalStrehovskyMichalStrehovsky
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 12, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
@MichalStrehovsky
MichalStrehovsky
commented
Jun 12, 2024

Copy link


Copy Markdown

MemberAuthor
Failures in the WASM legs. Not sure where the WASM legs are getting a 9.0.0-preview.5.24272.2 version of the runtime, I don't see such reference anywhere.
 Discovered: Wasi.Build.Tests (found 1 of 12 test case)
Starting: Wasi.Build.Tests (parallel test collections = on [2 threads], stop on fail = off)
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [STARTING]
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [FAIL]
Expected 0 exit code but got 150: /root/helix/work/workitem/e/dotnet-latest/dotnet run --no-silent --no-build -c Release
Standard Output:
[Release_tg0m0nmq_ivw] You must install or update .NET to run this application.
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] App: /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/9.0.0-ci/WasmAppHost/WasmAppHost.dll
[Release_tg0m0nmq_ivw] Architecture: x64
[Release_tg0m0nmq_ivw] Framework: 'Microsoft.NETCore.App', version '9.0.0-preview.5.24306.7' (x64)
[Release_tg0m0nmq_ivw] .NET location: /root/helix/work/workitem/e/dotnet-latest/
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] The following frameworks were found:
[Release_tg0m0nmq_ivw] 8.0.7 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_tg0m0nmq_ivw] 9.0.0-preview.5.24272.2 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] Learn more:
[Release_tg0m0nmq_ivw] https://aka.ms/dotnet/app-launch-failed
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] To install missing framework, download:
[Release_tg0m0nmq_ivw] https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0-preview.5.24306.7&arch=x64&rid=linux-x64&os=ubuntu.22.04

@akoeplinger
akoeplinger
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@MichalStrehovsky we use SdkVersionForWorkloadTesting to install an SDK for the Wasm.BuildTests, which is currently set to 9.0.100-preview.6.24277.1
runtime/eng/Versions.props

Line 257
in
f6dc71b
 <SdkVersionForWorkloadTesting>$(MicrosoftDotNetApiCompatTaskVersion)</SdkVersionForWorkloadTesting> 
It turns out that that version of the SDK has 9.0.0-preview.5.24272.2 of the runtime: https://github.com/dotnet/sdk/blob/29b15d1fca51ca7f1d4db87c2b15e39dcaf7bb53/eng/Version.Details.xml#L18-L21
Since the version is lower it fails. A newer runtime version flowed into the SDK in the meantime so another flow from SDK into runtime should fix this. I triggered the subscription, watch #103195
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
If I understand this correctly this sounds like a cyclic dependency. Can we avoid this by specifying the available runtime version / SDK when invoking that component?

This was referenced Jun 12, 2024

Closed


Closed


Closed


Closed


Closed


Closed


Closed

@akoeplinger
akoeplinger
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
I'm not sure how, we build WasmAppHost.dll with the sdk from global.json so it embeds the runtime version into .runtimeconfig.json and then we run it on a different sdk which doesn't have that version.
I don't think it's a big deal since normally there is some time before we bump the sdk in global.json so the flow would've already happened. Eventually we want to move these tests into the VMR anyway since it's much easier to test end-to-end there.
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
dotnet exec --fx-version ... <-- Version of the installed Shared Framework to use to run the application.
@akoeplinger
akoeplinger
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Ok, that'd work but we'd need to know the version of the shared framework which is a bit cumbersome to get (we'd need to look into what is bundled in the SDK) and might introduce other hard to diagnose failures. I still think we can live with it currently.

This was referenced Jun 12, 2024

Closed


Open


Closed


Open

@MichalStrehovsky
MichalStrehovsky
merged commit 4443a7d
into
dotnet:mainJun 13, 2024
MichalStrehovsky added a commit
that referenced
this pull request
Jun 13, 2024
@MichalStrehovsky
Try fixing x86 Windows legs
e8dbf12
I think we had a bad interaction between #103332 and #103273.
Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Jun 13, 2024
 Merged

@EgorBoEgorBo
mentioned this pull request
Jun 13, 2024

Closed

lewing pushed a commit
that referenced
this pull request
Jun 13, 2024
@MichalStrehovsky
Try fixing x86 Windows legs (#103411)
6927fea
I think we had a bad interaction between #103332 and #103273.
Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@marafmarafAwaiting requested review from marafmaraf is a code owner
@ilonatommyilonatommyAwaiting requested review from ilonatommyilonatommy is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@MichalStrehovsky@akoeplinger@ViktorHofer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update SDK to 9.0 Preview 5 by MichalStrehovsky · Pull Request #103332 · dotnet/runtime · GitHub
Skip to content
Update SDK to 9.0 Preview 5 - #103332
Merged
MichalStrehovsky merged 2 commits into
dotnet:mainfrom 
MichalStrehovsky:p5
Jun 13, 2024
Merged
Update SDK to 9.0 Preview 5#103332
MichalStrehovsky merged 2 commits into
dotnet:mainfrom 
MichalStrehovsky:p5
Conversation
@MichalStrehovsky
@MichalStrehovskyMichalStrehovsky
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 12, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
@MichalStrehovsky
MichalStrehovsky
commented
Jun 12, 2024

Copy link


Copy Markdown

MemberAuthor
Failures in the WASM legs. Not sure where the WASM legs are getting a 9.0.0-preview.5.24272.2 version of the runtime, I don't see such reference anywhere.
 Discovered: Wasi.Build.Tests (found 1 of 12 test case)
Starting: Wasi.Build.Tests (parallel test collections = on [2 threads], stop on fail = off)
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [STARTING]
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [FAIL]
Expected 0 exit code but got 150: /root/helix/work/workitem/e/dotnet-latest/dotnet run --no-silent --no-build -c Release
Standard Output:
[Release_tg0m0nmq_ivw] You must install or update .NET to run this application.
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] App: /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/9.0.0-ci/WasmAppHost/WasmAppHost.dll
[Release_tg0m0nmq_ivw] Architecture: x64
[Release_tg0m0nmq_ivw] Framework: 'Microsoft.NETCore.App', version '9.0.0-preview.5.24306.7' (x64)
[Release_tg0m0nmq_ivw] .NET location: /root/helix/work/workitem/e/dotnet-latest/
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] The following frameworks were found:
[Release_tg0m0nmq_ivw] 8.0.7 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_tg0m0nmq_ivw] 9.0.0-preview.5.24272.2 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] Learn more:
[Release_tg0m0nmq_ivw] https://aka.ms/dotnet/app-launch-failed
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] To install missing framework, download:
[Release_tg0m0nmq_ivw] https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0-preview.5.24306.7&arch=x64&rid=linux-x64&os=ubuntu.22.04

@akoeplinger
akoeplinger
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@MichalStrehovsky we use SdkVersionForWorkloadTesting to install an SDK for the Wasm.BuildTests, which is currently set to 9.0.100-preview.6.24277.1
runtime/eng/Versions.props

Line 257
in
f6dc71b
 <SdkVersionForWorkloadTesting>$(MicrosoftDotNetApiCompatTaskVersion)</SdkVersionForWorkloadTesting> 
It turns out that that version of the SDK has 9.0.0-preview.5.24272.2 of the runtime: https://github.com/dotnet/sdk/blob/29b15d1fca51ca7f1d4db87c2b15e39dcaf7bb53/eng/Version.Details.xml#L18-L21
Since the version is lower it fails. A newer runtime version flowed into the SDK in the meantime so another flow from SDK into runtime should fix this. I triggered the subscription, watch #103195
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
If I understand this correctly this sounds like a cyclic dependency. Can we avoid this by specifying the available runtime version / SDK when invoking that component?

This was referenced Jun 12, 2024

Closed


Closed


Closed


Closed


Closed


Closed


Closed

@akoeplinger
akoeplinger
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
I'm not sure how, we build WasmAppHost.dll with the sdk from global.json so it embeds the runtime version into .runtimeconfig.json and then we run it on a different sdk which doesn't have that version.
I don't think it's a big deal since normally there is some time before we bump the sdk in global.json so the flow would've already happened. Eventually we want to move these tests into the VMR anyway since it's much easier to test end-to-end there.
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
dotnet exec --fx-version ... <-- Version of the installed Shared Framework to use to run the application.
@akoeplinger
akoeplinger
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Ok, that'd work but we'd need to know the version of the shared framework which is a bit cumbersome to get (we'd need to look into what is bundled in the SDK) and might introduce other hard to diagnose failures. I still think we can live with it currently.

This was referenced Jun 12, 2024

Closed


Open


Closed


Open

@MichalStrehovsky
MichalStrehovsky
merged commit 4443a7d
into
dotnet:mainJun 13, 2024
MichalStrehovsky added a commit
that referenced
this pull request
Jun 13, 2024
@MichalStrehovsky
Try fixing x86 Windows legs
e8dbf12
I think we had a bad interaction between #103332 and #103273.
Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Jun 13, 2024
 Merged

@EgorBoEgorBo
mentioned this pull request
Jun 13, 2024

Closed

lewing pushed a commit
that referenced
this pull request
Jun 13, 2024
@MichalStrehovsky
Try fixing x86 Windows legs (#103411)
6927fea
I think we had a bad interaction between #103332 and #103273.
Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@marafmarafAwaiting requested review from marafmaraf is a code owner
@ilonatommyilonatommyAwaiting requested review from ilonatommyilonatommy is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@MichalStrehovsky@akoeplinger@ViktorHofer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Update SDK to 9.0 Preview 5 by MichalStrehovsky · Pull Request #103332 · dotnet/runtime · GitHub
Skip to content
Update SDK to 9.0 Preview 5 - #103332
Merged
MichalStrehovsky merged 2 commits into
dotnet:mainfrom 
MichalStrehovsky:p5
Jun 13, 2024
Merged
Update SDK to 9.0 Preview 5#103332
MichalStrehovsky merged 2 commits into
dotnet:mainfrom 
MichalStrehovsky:p5
Conversation
@MichalStrehovsky
@MichalStrehovskyMichalStrehovsky
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 12, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
@MichalStrehovsky
MichalStrehovsky
commented
Jun 12, 2024

Copy link


Copy Markdown

MemberAuthor
Failures in the WASM legs. Not sure where the WASM legs are getting a 9.0.0-preview.5.24272.2 version of the runtime, I don't see such reference anywhere.
 Discovered: Wasi.Build.Tests (found 1 of 12 test case)
Starting: Wasi.Build.Tests (parallel test collections = on [2 threads], stop on fail = off)
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [STARTING]
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [FAIL]
Expected 0 exit code but got 150: /root/helix/work/workitem/e/dotnet-latest/dotnet run --no-silent --no-build -c Release
Standard Output:
[Release_tg0m0nmq_ivw] You must install or update .NET to run this application.
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] App: /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/9.0.0-ci/WasmAppHost/WasmAppHost.dll
[Release_tg0m0nmq_ivw] Architecture: x64
[Release_tg0m0nmq_ivw] Framework: 'Microsoft.NETCore.App', version '9.0.0-preview.5.24306.7' (x64)
[Release_tg0m0nmq_ivw] .NET location: /root/helix/work/workitem/e/dotnet-latest/
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] The following frameworks were found:
[Release_tg0m0nmq_ivw] 8.0.7 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_tg0m0nmq_ivw] 9.0.0-preview.5.24272.2 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] Learn more:
[Release_tg0m0nmq_ivw] https://aka.ms/dotnet/app-launch-failed
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] To install missing framework, download:
[Release_tg0m0nmq_ivw] https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0-preview.5.24306.7&arch=x64&rid=linux-x64&os=ubuntu.22.04

@akoeplinger
akoeplinger
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@MichalStrehovsky we use SdkVersionForWorkloadTesting to install an SDK for the Wasm.BuildTests, which is currently set to 9.0.100-preview.6.24277.1
runtime/eng/Versions.props

Line 257
in
f6dc71b
 <SdkVersionForWorkloadTesting>$(MicrosoftDotNetApiCompatTaskVersion)</SdkVersionForWorkloadTesting> 
It turns out that that version of the SDK has 9.0.0-preview.5.24272.2 of the runtime: https://github.com/dotnet/sdk/blob/29b15d1fca51ca7f1d4db87c2b15e39dcaf7bb53/eng/Version.Details.xml#L18-L21
Since the version is lower it fails. A newer runtime version flowed into the SDK in the meantime so another flow from SDK into runtime should fix this. I triggered the subscription, watch #103195
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
If I understand this correctly this sounds like a cyclic dependency. Can we avoid this by specifying the available runtime version / SDK when invoking that component?

This was referenced Jun 12, 2024

Closed


Closed


Closed


Closed


Closed


Closed


Closed

@akoeplinger
akoeplinger
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
I'm not sure how, we build WasmAppHost.dll with the sdk from global.json so it embeds the runtime version into .runtimeconfig.json and then we run it on a different sdk which doesn't have that version.
I don't think it's a big deal since normally there is some time before we bump the sdk in global.json so the flow would've already happened. Eventually we want to move these tests into the VMR anyway since it's much easier to test end-to-end there.
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
dotnet exec --fx-version ... <-- Version of the installed Shared Framework to use to run the application.
@akoeplinger
akoeplinger
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Ok, that'd work but we'd need to know the version of the shared framework which is a bit cumbersome to get (we'd need to look into what is bundled in the SDK) and might introduce other hard to diagnose failures. I still think we can live with it currently.

This was referenced Jun 12, 2024

Closed


Open


Closed


Open

@MichalStrehovsky
MichalStrehovsky
merged commit 4443a7d
into
dotnet:mainJun 13, 2024
MichalStrehovsky added a commit
that referenced
this pull request
Jun 13, 2024
@MichalStrehovsky
Try fixing x86 Windows legs
e8dbf12
I think we had a bad interaction between #103332 and #103273.
Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Jun 13, 2024
 Merged

@EgorBoEgorBo
mentioned this pull request
Jun 13, 2024

Closed

lewing pushed a commit
that referenced
this pull request
Jun 13, 2024
@MichalStrehovsky
Try fixing x86 Windows legs (#103411)
6927fea
I think we had a bad interaction between #103332 and #103273.
Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@marafmarafAwaiting requested review from marafmaraf is a code owner
@ilonatommyilonatommyAwaiting requested review from ilonatommyilonatommy is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@MichalStrehovsky@akoeplinger@ViktorHofer

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Update SDK to 9.0 Preview 5 by MichalStrehovsky · Pull Request #103332 · dotnet/runtime · GitHub
Skip to content
Update SDK to 9.0 Preview 5 - #103332
Merged
MichalStrehovsky merged 2 commits into
dotnet:mainfrom 
MichalStrehovsky:p5
Jun 13, 2024
Merged
Update SDK to 9.0 Preview 5#103332
MichalStrehovsky merged 2 commits into
dotnet:mainfrom 
MichalStrehovsky:p5
Conversation
@MichalStrehovsky
@MichalStrehovskyMichalStrehovsky
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
 No description provided. 
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 12, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/runtime-infrastructure

See info in area-owners.md if you want to be subscribed.
@MichalStrehovsky
MichalStrehovsky
commented
Jun 12, 2024

Copy link


Copy Markdown

MemberAuthor
Failures in the WASM legs. Not sure where the WASM legs are getting a 9.0.0-preview.5.24272.2 version of the runtime, I don't see such reference anywhere.
 Discovered: Wasi.Build.Tests (found 1 of 12 test case)
Starting: Wasi.Build.Tests (parallel test collections = on [2 threads], stop on fail = off)
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [STARTING]
Wasi.Build.Tests.ILStripTests.WasmStripILAfterAOT_TestDefaultAndOverride(stripILAfterAOT: "", expectILStripping: True, singleFileBundle: False) [FAIL]
Expected 0 exit code but got 150: /root/helix/work/workitem/e/dotnet-latest/dotnet run --no-silent --no-build -c Release
Standard Output:
[Release_tg0m0nmq_ivw] You must install or update .NET to run this application.
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] App: /root/helix/work/workitem/e/dotnet-latest/packs/Microsoft.NET.Runtime.WebAssembly.Wasi.Sdk/9.0.0-ci/WasmAppHost/WasmAppHost.dll
[Release_tg0m0nmq_ivw] Architecture: x64
[Release_tg0m0nmq_ivw] Framework: 'Microsoft.NETCore.App', version '9.0.0-preview.5.24306.7' (x64)
[Release_tg0m0nmq_ivw] .NET location: /root/helix/work/workitem/e/dotnet-latest/
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] The following frameworks were found:
[Release_tg0m0nmq_ivw] 8.0.7 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_tg0m0nmq_ivw] 9.0.0-preview.5.24272.2 at [/root/helix/work/workitem/e/dotnet-latest/shared/Microsoft.NETCore.App]
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] Learn more:
[Release_tg0m0nmq_ivw] https://aka.ms/dotnet/app-launch-failed
[Release_tg0m0nmq_ivw] [Release_tg0m0nmq_ivw] To install missing framework, download:
[Release_tg0m0nmq_ivw] https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=9.0.0-preview.5.24306.7&arch=x64&rid=linux-x64&os=ubuntu.22.04

@akoeplinger
akoeplinger
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@MichalStrehovsky we use SdkVersionForWorkloadTesting to install an SDK for the Wasm.BuildTests, which is currently set to 9.0.100-preview.6.24277.1
runtime/eng/Versions.props

Line 257
in
f6dc71b
 <SdkVersionForWorkloadTesting>$(MicrosoftDotNetApiCompatTaskVersion)</SdkVersionForWorkloadTesting> 
It turns out that that version of the SDK has 9.0.0-preview.5.24272.2 of the runtime: https://github.com/dotnet/sdk/blob/29b15d1fca51ca7f1d4db87c2b15e39dcaf7bb53/eng/Version.Details.xml#L18-L21
Since the version is lower it fails. A newer runtime version flowed into the SDK in the meantime so another flow from SDK into runtime should fix this. I triggered the subscription, watch #103195
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
If I understand this correctly this sounds like a cyclic dependency. Can we avoid this by specifying the available runtime version / SDK when invoking that component?

This was referenced Jun 12, 2024

Closed


Closed


Closed


Closed


Closed


Closed


Closed

@akoeplinger
akoeplinger
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
I'm not sure how, we build WasmAppHost.dll with the sdk from global.json so it embeds the runtime version into .runtimeconfig.json and then we run it on a different sdk which doesn't have that version.
I don't think it's a big deal since normally there is some time before we bump the sdk in global.json so the flow would've already happened. Eventually we want to move these tests into the VMR anyway since it's much easier to test end-to-end there.
@ViktorHofer
ViktorHofer
commented
Jun 12, 2024

Copy link


Copy Markdown

Member
dotnet exec --fx-version ... <-- Version of the installed Shared Framework to use to run the application.
@akoeplinger
akoeplinger
commented
Jun 12, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Ok, that'd work but we'd need to know the version of the shared framework which is a bit cumbersome to get (we'd need to look into what is bundled in the SDK) and might introduce other hard to diagnose failures. I still think we can live with it currently.

This was referenced Jun 12, 2024

Closed


Open


Closed


Open

@MichalStrehovsky
MichalStrehovsky
merged commit 4443a7d
into
dotnet:mainJun 13, 2024
MichalStrehovsky added a commit
that referenced
this pull request
Jun 13, 2024
@MichalStrehovsky
Try fixing x86 Windows legs
e8dbf12
I think we had a bad interaction between #103332 and #103273.
Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
@MichalStrehovskyMichalStrehovsky
mentioned this pull request
Jun 13, 2024
 Merged

@EgorBoEgorBo
mentioned this pull request
Jun 13, 2024

Closed

lewing pushed a commit
that referenced
this pull request
Jun 13, 2024
@MichalStrehovsky
Try fixing x86 Windows legs (#103411)
6927fea
I think we had a bad interaction between #103332 and #103273.
Windows x86 with native AOT got broken in Preview 5 (#86573 (comment)).
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Jul 13, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@marafmarafAwaiting requested review from marafmaraf is a code owner
@ilonatommyilonatommyAwaiting requested review from ilonatommyilonatommy is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner
@pavelsavarapavelsavaraAwaiting requested review from pavelsavarapavelsavara is a code owner

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-Infrastructure

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@MichalStrehovsky@akoeplinger@ViktorHofer