update proxy setting on registry changes by wfurt · Pull Request #103364 · dotnet/runtime

wfurt · 2024-06-12T18:30:15Z

update proxy configuration on registry changes on Windows. That for example allows to start Fiddler and start capturing traffic without need to restart the process. It can of course also pick changes user does directly via Setting widget.

fixes#46910 and contributes to #95252.
It does not implement new API #95252 proposed but it seems to fix the use case it is describing.
Perhaps it can be closed as well @ManickaP?

Note that this does not apply to existing connections. e.g. the updated setting applies only when new connection is needed. If that is problem, it can perhaps be mitigated by either idea or absolute time on connection pool..

It also cannot detect changes to PAC or cases when something changes inside "auto" but there is no registry change.

…roxyUpdate

jkotas · 2024-06-13T05:08:13Z

+ proxy.UpdateConfiguration();
+ }
+
+ private void UpdateConfiguration()


Is it possible for multiple UpdateConfiguration() callbacks to run in parallel if there are multiple registry edits done in sequence?
We may want to ensure that the most recent UpdateConfiguration wins in this case.

The notifications do not have content. e.g. I think it would work just fine as long as the updates would finish in sequence they started.
The problem may be if let say there are part A and B. B get updated and that starts update reading old A. A updates, new config update starts and finishes before first update is done. The first task may be winner writing older configuration.
If we feel this is concern we have several options. We can simply lock the proxy object in the callback. Since that is only one place the only contention would be registry notification. But I'm not sure if that can cause any troubles for the thread pool. We can also update ThreadPool.RegisterWaitForSingleObject to fire only once but then we need new registration every time and I don't know how expensive that is (relative to all the other processing) I was also originally thinking about swapping the order of RegNotifyChangeKeyValue and UpdateConfiguration but I think we may miss some notifications in that case.

I do not see a problem with taking the lock.

ManickaP · 2024-06-13T08:04:12Z

It does not implement new API #95252 proposed but it seems to fix the use case it is describing.
Perhaps it can be closed as well @ManickaP?

We didn't want to implement new API, we wanted to change the behavior which at the moment is fetch once per whole process lifetime. So we also talked about rechecking environment variables every time you call GetSystemProxy, which this PR doesn't handle AFAICT.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

…date

…roxyUpdate

wfurt · 2024-06-21T16:01:38Z

all tests failures are known issues. This is ready for another review round.

rzikm

LGTM

wfurt · 2024-06-12T18:30:15Z

update proxy configuration on registry changes on Windows. That for example allows to start Fiddler and start capturing traffic without need to restart the process. It can of course also pick changes user does directly via Setting widget.

fixes#46910 and contributes to #95252.
It does not implement new API #95252 proposed but it seems to fix the use case it is describing.
Perhaps it can be closed as well @ManickaP?

Note that this does not apply to existing connections. e.g. the updated setting applies only when new connection is needed. If that is problem, it can perhaps be mitigated by either idea or absolute time on connection pool..

It also cannot detect changes to PAC or cases when something changes inside "auto" but there is no registry change.

…roxyUpdate

jkotas · 2024-06-13T05:08:13Z

+ proxy.UpdateConfiguration();
+ }
+
+ private void UpdateConfiguration()


Is it possible for multiple UpdateConfiguration() callbacks to run in parallel if there are multiple registry edits done in sequence?
We may want to ensure that the most recent UpdateConfiguration wins in this case.

The notifications do not have content. e.g. I think it would work just fine as long as the updates would finish in sequence they started.
The problem may be if let say there are part A and B. B get updated and that starts update reading old A. A updates, new config update starts and finishes before first update is done. The first task may be winner writing older configuration.
If we feel this is concern we have several options. We can simply lock the proxy object in the callback. Since that is only one place the only contention would be registry notification. But I'm not sure if that can cause any troubles for the thread pool. We can also update ThreadPool.RegisterWaitForSingleObject to fire only once but then we need new registration every time and I don't know how expensive that is (relative to all the other processing) I was also originally thinking about swapping the order of RegNotifyChangeKeyValue and UpdateConfiguration but I think we may miss some notifications in that case.

I do not see a problem with taking the lock.

ManickaP · 2024-06-13T08:04:12Z

It does not implement new API #95252 proposed but it seems to fix the use case it is describing.
Perhaps it can be closed as well @ManickaP?

We didn't want to implement new API, we wanted to change the behavior which at the moment is fetch once per whole process lifetime. So we also talked about rechecking environment variables every time you call GetSystemProxy, which this PR doesn't handle AFAICT.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

…date

…roxyUpdate

wfurt · 2024-06-21T16:01:38Z

all tests failures are known issues. This is ready for another review round.

rzikm

LGTM

wfurt · 2024-06-12T18:30:15Z

update proxy configuration on registry changes on Windows. That for example allows to start Fiddler and start capturing traffic without need to restart the process. It can of course also pick changes user does directly via Setting widget.

fixes#46910 and contributes to #95252.
It does not implement new API #95252 proposed but it seems to fix the use case it is describing.
Perhaps it can be closed as well @ManickaP?

Note that this does not apply to existing connections. e.g. the updated setting applies only when new connection is needed. If that is problem, it can perhaps be mitigated by either idea or absolute time on connection pool..

It also cannot detect changes to PAC or cases when something changes inside "auto" but there is no registry change.

…roxyUpdate

jkotas · 2024-06-13T05:08:13Z

+ proxy.UpdateConfiguration();
+ }
+
+ private void UpdateConfiguration()


Is it possible for multiple UpdateConfiguration() callbacks to run in parallel if there are multiple registry edits done in sequence?
We may want to ensure that the most recent UpdateConfiguration wins in this case.

The notifications do not have content. e.g. I think it would work just fine as long as the updates would finish in sequence they started.
The problem may be if let say there are part A and B. B get updated and that starts update reading old A. A updates, new config update starts and finishes before first update is done. The first task may be winner writing older configuration.
If we feel this is concern we have several options. We can simply lock the proxy object in the callback. Since that is only one place the only contention would be registry notification. But I'm not sure if that can cause any troubles for the thread pool. We can also update ThreadPool.RegisterWaitForSingleObject to fire only once but then we need new registration every time and I don't know how expensive that is (relative to all the other processing) I was also originally thinking about swapping the order of RegNotifyChangeKeyValue and UpdateConfiguration but I think we may miss some notifications in that case.

I do not see a problem with taking the lock.

ManickaP · 2024-06-13T08:04:12Z

It does not implement new API #95252 proposed but it seems to fix the use case it is describing.
Perhaps it can be closed as well @ManickaP?

We didn't want to implement new API, we wanted to change the behavior which at the moment is fetch once per whole process lifetime. So we also talked about rechecking environment variables every time you call GetSystemProxy, which this PR doesn't handle AFAICT.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

…date

…roxyUpdate

wfurt · 2024-06-21T16:01:38Z

all tests failures are known issues. This is ready for another review round.

rzikm

LGTM

wfurt · 2024-06-12T18:30:15Z

update proxy configuration on registry changes on Windows. That for example allows to start Fiddler and start capturing traffic without need to restart the process. It can of course also pick changes user does directly via Setting widget.

fixes#46910 and contributes to #95252.
It does not implement new API #95252 proposed but it seems to fix the use case it is describing.
Perhaps it can be closed as well @ManickaP?

Note that this does not apply to existing connections. e.g. the updated setting applies only when new connection is needed. If that is problem, it can perhaps be mitigated by either idea or absolute time on connection pool..

It also cannot detect changes to PAC or cases when something changes inside "auto" but there is no registry change.

…roxyUpdate

jkotas · 2024-06-13T05:08:13Z

+ proxy.UpdateConfiguration();
+ }
+
+ private void UpdateConfiguration()


Is it possible for multiple UpdateConfiguration() callbacks to run in parallel if there are multiple registry edits done in sequence?
We may want to ensure that the most recent UpdateConfiguration wins in this case.

The notifications do not have content. e.g. I think it would work just fine as long as the updates would finish in sequence they started.
The problem may be if let say there are part A and B. B get updated and that starts update reading old A. A updates, new config update starts and finishes before first update is done. The first task may be winner writing older configuration.
If we feel this is concern we have several options. We can simply lock the proxy object in the callback. Since that is only one place the only contention would be registry notification. But I'm not sure if that can cause any troubles for the thread pool. We can also update ThreadPool.RegisterWaitForSingleObject to fire only once but then we need new registration every time and I don't know how expensive that is (relative to all the other processing) I was also originally thinking about swapping the order of RegNotifyChangeKeyValue and UpdateConfiguration but I think we may miss some notifications in that case.

I do not see a problem with taking the lock.

ManickaP · 2024-06-13T08:04:12Z

It does not implement new API #95252 proposed but it seems to fix the use case it is describing.
Perhaps it can be closed as well @ManickaP?

We didn't want to implement new API, we wanted to change the behavior which at the moment is fetch once per whole process lifetime. So we also talked about rechecking environment variables every time you call GetSystemProxy, which this PR doesn't handle AFAICT.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

…date

…roxyUpdate

wfurt · 2024-06-21T16:01:38Z

all tests failures are known issues. This is ready for another review round.

rzikm

LGTM

wfurt · 2024-06-12T18:30:15Z

update proxy configuration on registry changes on Windows. That for example allows to start Fiddler and start capturing traffic without need to restart the process. It can of course also pick changes user does directly via Setting widget.

fixes#46910 and contributes to #95252.
It does not implement new API #95252 proposed but it seems to fix the use case it is describing.
Perhaps it can be closed as well @ManickaP?

Note that this does not apply to existing connections. e.g. the updated setting applies only when new connection is needed. If that is problem, it can perhaps be mitigated by either idea or absolute time on connection pool..

It also cannot detect changes to PAC or cases when something changes inside "auto" but there is no registry change.

…roxyUpdate

jkotas · 2024-06-13T05:08:13Z

+ proxy.UpdateConfiguration();
+ }
+
+ private void UpdateConfiguration()


Is it possible for multiple UpdateConfiguration() callbacks to run in parallel if there are multiple registry edits done in sequence?
We may want to ensure that the most recent UpdateConfiguration wins in this case.

The notifications do not have content. e.g. I think it would work just fine as long as the updates would finish in sequence they started.
The problem may be if let say there are part A and B. B get updated and that starts update reading old A. A updates, new config update starts and finishes before first update is done. The first task may be winner writing older configuration.
If we feel this is concern we have several options. We can simply lock the proxy object in the callback. Since that is only one place the only contention would be registry notification. But I'm not sure if that can cause any troubles for the thread pool. We can also update ThreadPool.RegisterWaitForSingleObject to fire only once but then we need new registration every time and I don't know how expensive that is (relative to all the other processing) I was also originally thinking about swapping the order of RegNotifyChangeKeyValue and UpdateConfiguration but I think we may miss some notifications in that case.

I do not see a problem with taking the lock.

ManickaP · 2024-06-13T08:04:12Z

It does not implement new API #95252 proposed but it seems to fix the use case it is describing.
Perhaps it can be closed as well @ManickaP?

We didn't want to implement new API, we wanted to change the behavior which at the moment is fetch once per whole process lifetime. So we also talked about rechecking environment variables every time you call GetSystemProxy, which this PR doesn't handle AFAICT.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

…date

…roxyUpdate

wfurt · 2024-06-21T16:01:38Z

all tests failures are known issues. This is ready for another review round.

rzikm

LGTM

wfurt · 2024-06-12T18:30:15Z

update proxy configuration on registry changes on Windows. That for example allows to start Fiddler and start capturing traffic without need to restart the process. It can of course also pick changes user does directly via Setting widget.

fixes#46910 and contributes to #95252.
It does not implement new API #95252 proposed but it seems to fix the use case it is describing.
Perhaps it can be closed as well @ManickaP?

Note that this does not apply to existing connections. e.g. the updated setting applies only when new connection is needed. If that is problem, it can perhaps be mitigated by either idea or absolute time on connection pool..

It also cannot detect changes to PAC or cases when something changes inside "auto" but there is no registry change.

…roxyUpdate

jkotas · 2024-06-13T05:08:13Z

+ proxy.UpdateConfiguration();
+ }
+
+ private void UpdateConfiguration()


Is it possible for multiple UpdateConfiguration() callbacks to run in parallel if there are multiple registry edits done in sequence?
We may want to ensure that the most recent UpdateConfiguration wins in this case.

The notifications do not have content. e.g. I think it would work just fine as long as the updates would finish in sequence they started.
The problem may be if let say there are part A and B. B get updated and that starts update reading old A. A updates, new config update starts and finishes before first update is done. The first task may be winner writing older configuration.
If we feel this is concern we have several options. We can simply lock the proxy object in the callback. Since that is only one place the only contention would be registry notification. But I'm not sure if that can cause any troubles for the thread pool. We can also update ThreadPool.RegisterWaitForSingleObject to fire only once but then we need new registration every time and I don't know how expensive that is (relative to all the other processing) I was also originally thinking about swapping the order of RegNotifyChangeKeyValue and UpdateConfiguration but I think we may miss some notifications in that case.

I do not see a problem with taking the lock.

ManickaP · 2024-06-13T08:04:12Z

It does not implement new API #95252 proposed but it seems to fix the use case it is describing.
Perhaps it can be closed as well @ManickaP?

We didn't want to implement new API, we wanted to change the behavior which at the moment is fetch once per whole process lifetime. So we also talked about rechecking environment variables every time you call GetSystemProxy, which this PR doesn't handle AFAICT.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

…date

…roxyUpdate

wfurt · 2024-06-21T16:01:38Z

all tests failures are known issues. This is ready for another review round.

rzikm

LGTM

wfurt · 2024-06-12T18:30:15Z

update proxy configuration on registry changes on Windows. That for example allows to start Fiddler and start capturing traffic without need to restart the process. It can of course also pick changes user does directly via Setting widget.

fixes#46910 and contributes to #95252.
It does not implement new API #95252 proposed but it seems to fix the use case it is describing.
Perhaps it can be closed as well @ManickaP?

Note that this does not apply to existing connections. e.g. the updated setting applies only when new connection is needed. If that is problem, it can perhaps be mitigated by either idea or absolute time on connection pool..

It also cannot detect changes to PAC or cases when something changes inside "auto" but there is no registry change.

…roxyUpdate

jkotas · 2024-06-13T05:08:13Z

+ proxy.UpdateConfiguration();
+ }
+
+ private void UpdateConfiguration()


Is it possible for multiple UpdateConfiguration() callbacks to run in parallel if there are multiple registry edits done in sequence?
We may want to ensure that the most recent UpdateConfiguration wins in this case.

The notifications do not have content. e.g. I think it would work just fine as long as the updates would finish in sequence they started.
The problem may be if let say there are part A and B. B get updated and that starts update reading old A. A updates, new config update starts and finishes before first update is done. The first task may be winner writing older configuration.
If we feel this is concern we have several options. We can simply lock the proxy object in the callback. Since that is only one place the only contention would be registry notification. But I'm not sure if that can cause any troubles for the thread pool. We can also update ThreadPool.RegisterWaitForSingleObject to fire only once but then we need new registration every time and I don't know how expensive that is (relative to all the other processing) I was also originally thinking about swapping the order of RegNotifyChangeKeyValue and UpdateConfiguration but I think we may miss some notifications in that case.

I do not see a problem with taking the lock.

ManickaP · 2024-06-13T08:04:12Z

It does not implement new API #95252 proposed but it seems to fix the use case it is describing.
Perhaps it can be closed as well @ManickaP?

We didn't want to implement new API, we wanted to change the behavior which at the moment is fetch once per whole process lifetime. So we also talked about rechecking environment variables every time you call GetSystemProxy, which this PR doesn't handle AFAICT.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

…date

…roxyUpdate

wfurt · 2024-06-21T16:01:38Z

all tests failures are known issues. This is ready for another review round.

rzikm

LGTM

wfurt · 2024-06-12T18:30:15Z

update proxy configuration on registry changes on Windows. That for example allows to start Fiddler and start capturing traffic without need to restart the process. It can of course also pick changes user does directly via Setting widget.

fixes#46910 and contributes to #95252.
It does not implement new API #95252 proposed but it seems to fix the use case it is describing.
Perhaps it can be closed as well @ManickaP?

Note that this does not apply to existing connections. e.g. the updated setting applies only when new connection is needed. If that is problem, it can perhaps be mitigated by either idea or absolute time on connection pool..

It also cannot detect changes to PAC or cases when something changes inside "auto" but there is no registry change.

…roxyUpdate

jkotas · 2024-06-13T05:08:13Z

+ proxy.UpdateConfiguration();
+ }
+
+ private void UpdateConfiguration()


Is it possible for multiple UpdateConfiguration() callbacks to run in parallel if there are multiple registry edits done in sequence?
We may want to ensure that the most recent UpdateConfiguration wins in this case.

The notifications do not have content. e.g. I think it would work just fine as long as the updates would finish in sequence they started.
The problem may be if let say there are part A and B. B get updated and that starts update reading old A. A updates, new config update starts and finishes before first update is done. The first task may be winner writing older configuration.
If we feel this is concern we have several options. We can simply lock the proxy object in the callback. Since that is only one place the only contention would be registry notification. But I'm not sure if that can cause any troubles for the thread pool. We can also update ThreadPool.RegisterWaitForSingleObject to fire only once but then we need new registration every time and I don't know how expensive that is (relative to all the other processing) I was also originally thinking about swapping the order of RegNotifyChangeKeyValue and UpdateConfiguration but I think we may miss some notifications in that case.

I do not see a problem with taking the lock.

ManickaP · 2024-06-13T08:04:12Z

It does not implement new API #95252 proposed but it seems to fix the use case it is describing.
Perhaps it can be closed as well @ManickaP?

We didn't want to implement new API, we wanted to change the behavior which at the moment is fetch once per whole process lifetime. So we also talked about rechecking environment variables every time you call GetSystemProxy, which this PR doesn't handle AFAICT.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

…date

…roxyUpdate

wfurt · 2024-06-21T16:01:38Z

all tests failures are known issues. This is ready for another review round.

rzikm

LGTM

update proxy setting on registry changes
efac2ca

wfurt added the area-System.Net.Http label Jun 12, 2024

wfurt added this to the 9.0.0 milestone Jun 12, 2024

wfurt requested a review from a teamJune 12, 2024 18:30

wfurt self-assigned this Jun 12, 2024

udpate
c58cac2

build-analysisBot mentioned this pull request Jun 12, 2024
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed

wfurt added 5 commits June 12, 2024 20:58

build fixes
1605f7f

console
a0fd110

registry
208217c

Merge branch 'proxyUpdate' ofhttps://github.com/wfurt/runtimeinto p…
e9824cc
…roxyUpdate

winhttp
af18353

This was referenced Jun 13, 2024
Debug assertion failure in System.Net.Http.HttpConnection.SendAsync #100616
Closed
CI timeout in System.Data.Tests.DataSetTest2.Bug537229_BinFormatSerializer_Test #103350
Closed
System.Net.Security.Tests.SslStreamTlsResumeTests failing #103354
Closed

invalid
4fcfb12

jkotas reviewed Jun 13, 2024
View reviewed changes

This was referenced Jun 13, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed
Dead lettering tests #101524
Closed

ManickaP reviewed Jun 13, 2024
View reviewed changes

Comment thread...tem.Net.Http.WinHttpHandler/tests/UnitTests/System.Net.Http.WinHttpHandler.Unit.Tests.csproj Outdated
Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs Outdated

ManickaP mentioned this pull request Jun 13, 2024
WebProxy.GetSystemProxy #95252
Open

stephentoub reviewed Jun 13, 2024
View reviewed changes

wfurt added 3 commits June 13, 2024 21:42

feedback
690fe35

feedback
5fc1f3f

'feedback'
f9a321a

build-analysisBot mentioned this pull request Jun 15, 2024
SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds failed in CI #103449
Closed

jkotas reviewed Jun 15, 2024
View reviewed changes

Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs Outdated

jkotas reviewed Jun 15, 2024
View reviewed changes

Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs

Apply suggestions from code review
3ff0740
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

This was referenced Jun 18, 2024
GC/Regressions/v2.0-beta2/452950 failed in CI #103494
Closed
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open

wfurt added 3 commits June 20, 2024 12:48

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto proxyUp…
401353b
…date

Merge branch 'proxyUpdate' ofhttps://github.com/wfurt/runtimeinto p…
455f61e
…roxyUpdate

MemberNotNull
92adec5

rzikm self-requested a review July 2, 2024 16:00

rzikm approved these changes Jul 2, 2024
View reviewed changes

wfurt merged commit e71e0f4 into dotnet:mainJul 8, 2024

wfurt deleted the proxyUpdate branch July 8, 2024 04:22

github-actionsBot locked and limited conversation to collaborators Aug 7, 2024

update proxy setting on registry changes
efac2ca

wfurt added the area-System.Net.Http label Jun 12, 2024

wfurt added this to the 9.0.0 milestone Jun 12, 2024

wfurt requested a review from a teamJune 12, 2024 18:30

wfurt self-assigned this Jun 12, 2024

udpate
c58cac2

build-analysisBot mentioned this pull request Jun 12, 2024
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed

wfurt added 5 commits June 12, 2024 20:58

build fixes
1605f7f

console
a0fd110

registry
208217c

Merge branch 'proxyUpdate' ofhttps://github.com/wfurt/runtimeinto p…
e9824cc
…roxyUpdate

winhttp
af18353

This was referenced Jun 13, 2024
Debug assertion failure in System.Net.Http.HttpConnection.SendAsync #100616
Closed
CI timeout in System.Data.Tests.DataSetTest2.Bug537229_BinFormatSerializer_Test #103350
Closed
System.Net.Security.Tests.SslStreamTlsResumeTests failing #103354
Closed

invalid
4fcfb12

jkotas reviewed Jun 13, 2024
View reviewed changes

This was referenced Jun 13, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed
Dead lettering tests #101524
Closed

ManickaP reviewed Jun 13, 2024
View reviewed changes

Comment thread...tem.Net.Http.WinHttpHandler/tests/UnitTests/System.Net.Http.WinHttpHandler.Unit.Tests.csproj Outdated
Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs Outdated

ManickaP mentioned this pull request Jun 13, 2024
WebProxy.GetSystemProxy #95252
Open

stephentoub reviewed Jun 13, 2024
View reviewed changes

wfurt added 3 commits June 13, 2024 21:42

feedback
690fe35

feedback
5fc1f3f

'feedback'
f9a321a

build-analysisBot mentioned this pull request Jun 15, 2024
SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds failed in CI #103449
Closed

jkotas reviewed Jun 15, 2024
View reviewed changes

Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs Outdated

jkotas reviewed Jun 15, 2024
View reviewed changes

Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs

Apply suggestions from code review
3ff0740
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

This was referenced Jun 18, 2024
GC/Regressions/v2.0-beta2/452950 failed in CI #103494
Closed
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open

wfurt added 3 commits June 20, 2024 12:48

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto proxyUp…
401353b
…date

Merge branch 'proxyUpdate' ofhttps://github.com/wfurt/runtimeinto p…
455f61e
…roxyUpdate

MemberNotNull
92adec5

rzikm self-requested a review July 2, 2024 16:00

rzikm approved these changes Jul 2, 2024
View reviewed changes

wfurt merged commit e71e0f4 into dotnet:mainJul 8, 2024

wfurt deleted the proxyUpdate branch July 8, 2024 04:22

github-actionsBot locked and limited conversation to collaborators Aug 7, 2024

update proxy setting on registry changes
efac2ca

wfurt added the area-System.Net.Http label Jun 12, 2024

wfurt added this to the 9.0.0 milestone Jun 12, 2024

wfurt requested a review from a teamJune 12, 2024 18:30

wfurt self-assigned this Jun 12, 2024

udpate
c58cac2

build-analysisBot mentioned this pull request Jun 12, 2024
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed

wfurt added 5 commits June 12, 2024 20:58

build fixes
1605f7f

console
a0fd110

registry
208217c

Merge branch 'proxyUpdate' ofhttps://github.com/wfurt/runtimeinto p…
e9824cc
…roxyUpdate

winhttp
af18353

This was referenced Jun 13, 2024
Debug assertion failure in System.Net.Http.HttpConnection.SendAsync #100616
Closed
CI timeout in System.Data.Tests.DataSetTest2.Bug537229_BinFormatSerializer_Test #103350
Closed
System.Net.Security.Tests.SslStreamTlsResumeTests failing #103354
Closed

invalid
4fcfb12

jkotas reviewed Jun 13, 2024
View reviewed changes

This was referenced Jun 13, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed
Dead lettering tests #101524
Closed

ManickaP reviewed Jun 13, 2024
View reviewed changes

Comment thread...tem.Net.Http.WinHttpHandler/tests/UnitTests/System.Net.Http.WinHttpHandler.Unit.Tests.csproj Outdated
Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs Outdated

ManickaP mentioned this pull request Jun 13, 2024
WebProxy.GetSystemProxy #95252
Open

stephentoub reviewed Jun 13, 2024
View reviewed changes

wfurt added 3 commits June 13, 2024 21:42

feedback
690fe35

feedback
5fc1f3f

'feedback'
f9a321a

build-analysisBot mentioned this pull request Jun 15, 2024
SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds failed in CI #103449
Closed

jkotas reviewed Jun 15, 2024
View reviewed changes

Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs Outdated

jkotas reviewed Jun 15, 2024
View reviewed changes

Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs

Apply suggestions from code review
3ff0740
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

This was referenced Jun 18, 2024
GC/Regressions/v2.0-beta2/452950 failed in CI #103494
Closed
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open

wfurt added 3 commits June 20, 2024 12:48

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto proxyUp…
401353b
…date

Merge branch 'proxyUpdate' ofhttps://github.com/wfurt/runtimeinto p…
455f61e
…roxyUpdate

MemberNotNull
92adec5

rzikm self-requested a review July 2, 2024 16:00

rzikm approved these changes Jul 2, 2024
View reviewed changes

wfurt merged commit e71e0f4 into dotnet:mainJul 8, 2024

wfurt deleted the proxyUpdate branch July 8, 2024 04:22

github-actionsBot locked and limited conversation to collaborators Aug 7, 2024

update proxy setting on registry changes
efac2ca

wfurt added the area-System.Net.Http label Jun 12, 2024

wfurt added this to the 9.0.0 milestone Jun 12, 2024

wfurt requested a review from a teamJune 12, 2024 18:30

wfurt self-assigned this Jun 12, 2024

udpate
c58cac2

build-analysisBot mentioned this pull request Jun 12, 2024
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed

wfurt added 5 commits June 12, 2024 20:58

build fixes
1605f7f

console
a0fd110

registry
208217c

Merge branch 'proxyUpdate' ofhttps://github.com/wfurt/runtimeinto p…
e9824cc
…roxyUpdate

winhttp
af18353

This was referenced Jun 13, 2024
Debug assertion failure in System.Net.Http.HttpConnection.SendAsync #100616
Closed
CI timeout in System.Data.Tests.DataSetTest2.Bug537229_BinFormatSerializer_Test #103350
Closed
System.Net.Security.Tests.SslStreamTlsResumeTests failing #103354
Closed

invalid
4fcfb12

jkotas reviewed Jun 13, 2024
View reviewed changes

This was referenced Jun 13, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed
Dead lettering tests #101524
Closed

ManickaP reviewed Jun 13, 2024
View reviewed changes

Comment thread...tem.Net.Http.WinHttpHandler/tests/UnitTests/System.Net.Http.WinHttpHandler.Unit.Tests.csproj Outdated
Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs Outdated

ManickaP mentioned this pull request Jun 13, 2024
WebProxy.GetSystemProxy #95252
Open

stephentoub reviewed Jun 13, 2024
View reviewed changes

wfurt added 3 commits June 13, 2024 21:42

feedback
690fe35

feedback
5fc1f3f

'feedback'
f9a321a

build-analysisBot mentioned this pull request Jun 15, 2024
SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds failed in CI #103449
Closed

jkotas reviewed Jun 15, 2024
View reviewed changes

Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs Outdated

jkotas reviewed Jun 15, 2024
View reviewed changes

Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs

Apply suggestions from code review
3ff0740
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

This was referenced Jun 18, 2024
GC/Regressions/v2.0-beta2/452950 failed in CI #103494
Closed
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open

wfurt added 3 commits June 20, 2024 12:48

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto proxyUp…
401353b
…date

Merge branch 'proxyUpdate' ofhttps://github.com/wfurt/runtimeinto p…
455f61e
…roxyUpdate

MemberNotNull
92adec5

rzikm self-requested a review July 2, 2024 16:00

rzikm approved these changes Jul 2, 2024
View reviewed changes

wfurt merged commit e71e0f4 into dotnet:mainJul 8, 2024

wfurt deleted the proxyUpdate branch July 8, 2024 04:22

github-actionsBot locked and limited conversation to collaborators Aug 7, 2024

update proxy setting on registry changes
efac2ca

wfurt added the area-System.Net.Http label Jun 12, 2024

wfurt added this to the 9.0.0 milestone Jun 12, 2024

wfurt requested a review from a teamJune 12, 2024 18:30

wfurt self-assigned this Jun 12, 2024

udpate
c58cac2

build-analysisBot mentioned this pull request Jun 12, 2024
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed

wfurt added 5 commits June 12, 2024 20:58

build fixes
1605f7f

console
a0fd110

registry
208217c

Merge branch 'proxyUpdate' ofhttps://github.com/wfurt/runtimeinto p…
e9824cc
…roxyUpdate

winhttp
af18353

This was referenced Jun 13, 2024
Debug assertion failure in System.Net.Http.HttpConnection.SendAsync #100616
Closed
CI timeout in System.Data.Tests.DataSetTest2.Bug537229_BinFormatSerializer_Test #103350
Closed
System.Net.Security.Tests.SslStreamTlsResumeTests failing #103354
Closed

invalid
4fcfb12

jkotas reviewed Jun 13, 2024
View reviewed changes

This was referenced Jun 13, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed
Dead lettering tests #101524
Closed

ManickaP reviewed Jun 13, 2024
View reviewed changes

Comment thread...tem.Net.Http.WinHttpHandler/tests/UnitTests/System.Net.Http.WinHttpHandler.Unit.Tests.csproj Outdated
Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs Outdated

ManickaP mentioned this pull request Jun 13, 2024
WebProxy.GetSystemProxy #95252
Open

stephentoub reviewed Jun 13, 2024
View reviewed changes

wfurt added 3 commits June 13, 2024 21:42

feedback
690fe35

feedback
5fc1f3f

'feedback'
f9a321a

build-analysisBot mentioned this pull request Jun 15, 2024
SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds failed in CI #103449
Closed

jkotas reviewed Jun 15, 2024
View reviewed changes

Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs Outdated

jkotas reviewed Jun 15, 2024
View reviewed changes

Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs

Apply suggestions from code review
3ff0740
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

This was referenced Jun 18, 2024
GC/Regressions/v2.0-beta2/452950 failed in CI #103494
Closed
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open

wfurt added 3 commits June 20, 2024 12:48

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto proxyUp…
401353b
…date

Merge branch 'proxyUpdate' ofhttps://github.com/wfurt/runtimeinto p…
455f61e
…roxyUpdate

MemberNotNull
92adec5

rzikm self-requested a review July 2, 2024 16:00

rzikm approved these changes Jul 2, 2024
View reviewed changes

wfurt merged commit e71e0f4 into dotnet:mainJul 8, 2024

wfurt deleted the proxyUpdate branch July 8, 2024 04:22

github-actionsBot locked and limited conversation to collaborators Aug 7, 2024

update proxy setting on registry changes
efac2ca

wfurt added the area-System.Net.Http label Jun 12, 2024

wfurt added this to the 9.0.0 milestone Jun 12, 2024

wfurt requested a review from a teamJune 12, 2024 18:30

wfurt self-assigned this Jun 12, 2024

udpate
c58cac2

build-analysisBot mentioned this pull request Jun 12, 2024
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed

wfurt added 5 commits June 12, 2024 20:58

build fixes
1605f7f

console
a0fd110

registry
208217c

Merge branch 'proxyUpdate' ofhttps://github.com/wfurt/runtimeinto p…
e9824cc
…roxyUpdate

winhttp
af18353

This was referenced Jun 13, 2024
Debug assertion failure in System.Net.Http.HttpConnection.SendAsync #100616
Closed
CI timeout in System.Data.Tests.DataSetTest2.Bug537229_BinFormatSerializer_Test #103350
Closed
System.Net.Security.Tests.SslStreamTlsResumeTests failing #103354
Closed

invalid
4fcfb12

jkotas reviewed Jun 13, 2024
View reviewed changes

This was referenced Jun 13, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed
Dead lettering tests #101524
Closed

ManickaP reviewed Jun 13, 2024
View reviewed changes

Comment thread...tem.Net.Http.WinHttpHandler/tests/UnitTests/System.Net.Http.WinHttpHandler.Unit.Tests.csproj Outdated
Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs Outdated

ManickaP mentioned this pull request Jun 13, 2024
WebProxy.GetSystemProxy #95252
Open

stephentoub reviewed Jun 13, 2024
View reviewed changes

wfurt added 3 commits June 13, 2024 21:42

feedback
690fe35

feedback
5fc1f3f

'feedback'
f9a321a

build-analysisBot mentioned this pull request Jun 15, 2024
SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds failed in CI #103449
Closed

jkotas reviewed Jun 15, 2024
View reviewed changes

Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs Outdated

jkotas reviewed Jun 15, 2024
View reviewed changes

Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs

Apply suggestions from code review
3ff0740
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

This was referenced Jun 18, 2024
GC/Regressions/v2.0-beta2/452950 failed in CI #103494
Closed
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open

wfurt added 3 commits June 20, 2024 12:48

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto proxyUp…
401353b
…date

Merge branch 'proxyUpdate' ofhttps://github.com/wfurt/runtimeinto p…
455f61e
…roxyUpdate

MemberNotNull
92adec5

rzikm self-requested a review July 2, 2024 16:00

rzikm approved these changes Jul 2, 2024
View reviewed changes

wfurt merged commit e71e0f4 into dotnet:mainJul 8, 2024

wfurt deleted the proxyUpdate branch July 8, 2024 04:22

github-actionsBot locked and limited conversation to collaborators Aug 7, 2024

update proxy setting on registry changes
efac2ca

wfurt added the area-System.Net.Http label Jun 12, 2024

wfurt added this to the 9.0.0 milestone Jun 12, 2024

wfurt requested a review from a teamJune 12, 2024 18:30

wfurt self-assigned this Jun 12, 2024

udpate
c58cac2

build-analysisBot mentioned this pull request Jun 12, 2024
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed

wfurt added 5 commits June 12, 2024 20:58

build fixes
1605f7f

console
a0fd110

registry
208217c

Merge branch 'proxyUpdate' ofhttps://github.com/wfurt/runtimeinto p…
e9824cc
…roxyUpdate

winhttp
af18353

This was referenced Jun 13, 2024
Debug assertion failure in System.Net.Http.HttpConnection.SendAsync #100616
Closed
CI timeout in System.Data.Tests.DataSetTest2.Bug537229_BinFormatSerializer_Test #103350
Closed
System.Net.Security.Tests.SslStreamTlsResumeTests failing #103354
Closed

invalid
4fcfb12

jkotas reviewed Jun 13, 2024
View reviewed changes

This was referenced Jun 13, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed
Dead lettering tests #101524
Closed

ManickaP reviewed Jun 13, 2024
View reviewed changes

Comment thread...tem.Net.Http.WinHttpHandler/tests/UnitTests/System.Net.Http.WinHttpHandler.Unit.Tests.csproj Outdated
Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs Outdated

ManickaP mentioned this pull request Jun 13, 2024
WebProxy.GetSystemProxy #95252
Open

stephentoub reviewed Jun 13, 2024
View reviewed changes

wfurt added 3 commits June 13, 2024 21:42

feedback
690fe35

feedback
5fc1f3f

'feedback'
f9a321a

build-analysisBot mentioned this pull request Jun 15, 2024
SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds failed in CI #103449
Closed

jkotas reviewed Jun 15, 2024
View reviewed changes

Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs Outdated

jkotas reviewed Jun 15, 2024
View reviewed changes

Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs

Apply suggestions from code review
3ff0740
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

This was referenced Jun 18, 2024
GC/Regressions/v2.0-beta2/452950 failed in CI #103494
Closed
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open

wfurt added 3 commits June 20, 2024 12:48

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto proxyUp…
401353b
…date

Merge branch 'proxyUpdate' ofhttps://github.com/wfurt/runtimeinto p…
455f61e
…roxyUpdate

MemberNotNull
92adec5

rzikm self-requested a review July 2, 2024 16:00

rzikm approved these changes Jul 2, 2024
View reviewed changes

wfurt merged commit e71e0f4 into dotnet:mainJul 8, 2024

wfurt deleted the proxyUpdate branch July 8, 2024 04:22

github-actionsBot locked and limited conversation to collaborators Aug 7, 2024

update proxy setting on registry changes
efac2ca

wfurt added the area-System.Net.Http label Jun 12, 2024

wfurt added this to the 9.0.0 milestone Jun 12, 2024

wfurt requested a review from a teamJune 12, 2024 18:30

wfurt self-assigned this Jun 12, 2024

udpate
c58cac2

build-analysisBot mentioned this pull request Jun 12, 2024
Intermittent build failure in AfterSourceBuild: "Could not write state file" #76488
Closed

wfurt added 5 commits June 12, 2024 20:58

build fixes
1605f7f

console
a0fd110

registry
208217c

Merge branch 'proxyUpdate' ofhttps://github.com/wfurt/runtimeinto p…
e9824cc
…roxyUpdate

winhttp
af18353

This was referenced Jun 13, 2024
Debug assertion failure in System.Net.Http.HttpConnection.SendAsync #100616
Closed
CI timeout in System.Data.Tests.DataSetTest2.Bug537229_BinFormatSerializer_Test #103350
Closed
System.Net.Security.Tests.SslStreamTlsResumeTests failing #103354
Closed

invalid
4fcfb12

jkotas reviewed Jun 13, 2024
View reviewed changes

This was referenced Jun 13, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed
Dead lettering tests #101524
Closed

ManickaP reviewed Jun 13, 2024
View reviewed changes

Comment thread...tem.Net.Http.WinHttpHandler/tests/UnitTests/System.Net.Http.WinHttpHandler.Unit.Tests.csproj Outdated
Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs Outdated

ManickaP mentioned this pull request Jun 13, 2024
WebProxy.GetSystemProxy #95252
Open

stephentoub reviewed Jun 13, 2024
View reviewed changes

wfurt added 3 commits June 13, 2024 21:42

feedback
690fe35

feedback
5fc1f3f

'feedback'
f9a321a

build-analysisBot mentioned this pull request Jun 15, 2024
SslStreamTlsResumeTests.ClientDisableTlsResume_Succeeds failed in CI #103449
Closed

jkotas reviewed Jun 15, 2024
View reviewed changes

Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs Outdated

jkotas reviewed Jun 15, 2024
View reviewed changes

Comment threadsrc/libraries/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpWindowsProxy.cs

Apply suggestions from code review
3ff0740
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

This was referenced Jun 18, 2024
GC/Regressions/v2.0-beta2/452950 failed in CI #103494
Closed
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open

wfurt added 3 commits June 20, 2024 12:48

Merge branch 'main' ofhttps://github.com/dotnet/runtimeinto proxyUp…
401353b
…date

Merge branch 'proxyUpdate' ofhttps://github.com/wfurt/runtimeinto p…
455f61e
…roxyUpdate

MemberNotNull
92adec5

rzikm self-requested a review July 2, 2024 16:00

rzikm approved these changes Jul 2, 2024
View reviewed changes

wfurt merged commit e71e0f4 into dotnet:mainJul 8, 2024

wfurt deleted the proxyUpdate branch July 8, 2024 04:22

github-actionsBot locked and limited conversation to collaborators Aug 7, 2024

Uh oh!

Conversation

wfurt commented Jun 12, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ManickaP commented Jun 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wfurt commented Jun 21, 2024

Uh oh!

rzikm left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

wfurt commented Jun 12, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ManickaP commented Jun 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wfurt commented Jun 21, 2024

Uh oh!

rzikm left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

wfurt commented Jun 12, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!