Performance improvements in `JsonValue`. by eiriktsarpalis · Pull Request #103733 · dotnet/runtime

eiriktsarpalis · 2024-06-19T21:28:49Z

One of the oddities of JsonNode design is that it permits encapsulation of arbitrary .NET objects via the JsonValue type. This is known to create performance problems since it's not possible to introspect JsonValue instances without serializing and deserializing the underlying object first. The problem is fairly pervasive since JSON primitives such as boolean, numbers and strings are all represented using JsonValue.

This PR refactors the implementation of JsonValue so that common primitive types and deserialized values backed by JsonElement are fully segregated from the implementation that admits arbitrary objects. Consequently this change records substantial performance improvements:

Method	Branch	Mean	Ratio	Allocated	Alloc Ratio
DeepEquals	main	2,859.165 ns	1.00	4224 B	1.00
DeepEquals	PR	270.130 ns	0.09	-	0.00

DeepEquals_JsonElement	main	660.551 ns	1.00	328 B	1.00
DeepEquals_JsonElement	PR	432.391 ns	0.65	-	0.00

GetValueKind	main	612.784 ns	1.000	616 B	1.00
GetValueKind	PR	5.243 ns	0.009	-	0.00

GetValueKind_JsonElement	main	15.557 ns	1.00	-	NA
GetValueKind_JsonElement	PR	11.111 ns	0.71	-	NA

dotnet-policy-service · 2024-06-19T21:29:17Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

gregsdennis · 2024-06-19T22:08:38Z

Just confirming that we're not losing the ability to store arbitrary objects in JsonValue. I actually utilize this in my JSON-e implementation.

eiriktsarpalis · 2024-06-19T22:58:28Z

Just confirming that we're not losing the ability to store arbitrary objects in JsonValue. I actually utilize this in my JSON-e implementation.

We couldn't do that. This change simply isolates that use case from the hot path scenaria.

…d escaping.

eiriktsarpalis · 2024-06-20T20:52:22Z

/ba-g suppressing unrelated test failure to merge ahead of snap.

* Performance improvements in JsonValue. * Fixdotnet#103715. * Add more test cases and fix a number of bugs related to DeepEquals and escaping. * Fix number handling corner case.

eiriktsarpalis · 2024-06-19T21:28:49Z

One of the oddities of JsonNode design is that it permits encapsulation of arbitrary .NET objects via the JsonValue type. This is known to create performance problems since it's not possible to introspect JsonValue instances without serializing and deserializing the underlying object first. The problem is fairly pervasive since JSON primitives such as boolean, numbers and strings are all represented using JsonValue.

This PR refactors the implementation of JsonValue so that common primitive types and deserialized values backed by JsonElement are fully segregated from the implementation that admits arbitrary objects. Consequently this change records substantial performance improvements:

Method	Branch	Mean	Ratio	Allocated	Alloc Ratio
DeepEquals	main	2,859.165 ns	1.00	4224 B	1.00
DeepEquals	PR	270.130 ns	0.09	-	0.00

DeepEquals_JsonElement	main	660.551 ns	1.00	328 B	1.00
DeepEquals_JsonElement	PR	432.391 ns	0.65	-	0.00

GetValueKind	main	612.784 ns	1.000	616 B	1.00
GetValueKind	PR	5.243 ns	0.009	-	0.00

GetValueKind_JsonElement	main	15.557 ns	1.00	-	NA
GetValueKind_JsonElement	PR	11.111 ns	0.71	-	NA

dotnet-policy-service · 2024-06-19T21:29:17Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

gregsdennis · 2024-06-19T22:08:38Z

Just confirming that we're not losing the ability to store arbitrary objects in JsonValue. I actually utilize this in my JSON-e implementation.

eiriktsarpalis · 2024-06-19T22:58:28Z

Just confirming that we're not losing the ability to store arbitrary objects in JsonValue. I actually utilize this in my JSON-e implementation.

We couldn't do that. This change simply isolates that use case from the hot path scenaria.

…d escaping.

eiriktsarpalis · 2024-06-20T20:52:22Z

/ba-g suppressing unrelated test failure to merge ahead of snap.

* Performance improvements in JsonValue. * Fixdotnet#103715. * Add more test cases and fix a number of bugs related to DeepEquals and escaping. * Fix number handling corner case.

eiriktsarpalis · 2024-06-19T21:28:49Z

One of the oddities of JsonNode design is that it permits encapsulation of arbitrary .NET objects via the JsonValue type. This is known to create performance problems since it's not possible to introspect JsonValue instances without serializing and deserializing the underlying object first. The problem is fairly pervasive since JSON primitives such as boolean, numbers and strings are all represented using JsonValue.

This PR refactors the implementation of JsonValue so that common primitive types and deserialized values backed by JsonElement are fully segregated from the implementation that admits arbitrary objects. Consequently this change records substantial performance improvements:

Method	Branch	Mean	Ratio	Allocated	Alloc Ratio
DeepEquals	main	2,859.165 ns	1.00	4224 B	1.00
DeepEquals	PR	270.130 ns	0.09	-	0.00

DeepEquals_JsonElement	main	660.551 ns	1.00	328 B	1.00
DeepEquals_JsonElement	PR	432.391 ns	0.65	-	0.00

GetValueKind	main	612.784 ns	1.000	616 B	1.00
GetValueKind	PR	5.243 ns	0.009	-	0.00

GetValueKind_JsonElement	main	15.557 ns	1.00	-	NA
GetValueKind_JsonElement	PR	11.111 ns	0.71	-	NA

dotnet-policy-service · 2024-06-19T21:29:17Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

gregsdennis · 2024-06-19T22:08:38Z

Just confirming that we're not losing the ability to store arbitrary objects in JsonValue. I actually utilize this in my JSON-e implementation.

eiriktsarpalis · 2024-06-19T22:58:28Z

Just confirming that we're not losing the ability to store arbitrary objects in JsonValue. I actually utilize this in my JSON-e implementation.

We couldn't do that. This change simply isolates that use case from the hot path scenaria.

…d escaping.

eiriktsarpalis · 2024-06-20T20:52:22Z

/ba-g suppressing unrelated test failure to merge ahead of snap.

* Performance improvements in JsonValue. * Fixdotnet#103715. * Add more test cases and fix a number of bugs related to DeepEquals and escaping. * Fix number handling corner case.

eiriktsarpalis · 2024-06-19T21:28:49Z

One of the oddities of JsonNode design is that it permits encapsulation of arbitrary .NET objects via the JsonValue type. This is known to create performance problems since it's not possible to introspect JsonValue instances without serializing and deserializing the underlying object first. The problem is fairly pervasive since JSON primitives such as boolean, numbers and strings are all represented using JsonValue.

This PR refactors the implementation of JsonValue so that common primitive types and deserialized values backed by JsonElement are fully segregated from the implementation that admits arbitrary objects. Consequently this change records substantial performance improvements:

Method	Branch	Mean	Ratio	Allocated	Alloc Ratio
DeepEquals	main	2,859.165 ns	1.00	4224 B	1.00
DeepEquals	PR	270.130 ns	0.09	-	0.00

DeepEquals_JsonElement	main	660.551 ns	1.00	328 B	1.00
DeepEquals_JsonElement	PR	432.391 ns	0.65	-	0.00

GetValueKind	main	612.784 ns	1.000	616 B	1.00
GetValueKind	PR	5.243 ns	0.009	-	0.00

GetValueKind_JsonElement	main	15.557 ns	1.00	-	NA
GetValueKind_JsonElement	PR	11.111 ns	0.71	-	NA

dotnet-policy-service · 2024-06-19T21:29:17Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

gregsdennis · 2024-06-19T22:08:38Z

Just confirming that we're not losing the ability to store arbitrary objects in JsonValue. I actually utilize this in my JSON-e implementation.

eiriktsarpalis · 2024-06-19T22:58:28Z

Just confirming that we're not losing the ability to store arbitrary objects in JsonValue. I actually utilize this in my JSON-e implementation.

We couldn't do that. This change simply isolates that use case from the hot path scenaria.

…d escaping.

eiriktsarpalis · 2024-06-20T20:52:22Z

/ba-g suppressing unrelated test failure to merge ahead of snap.

* Performance improvements in JsonValue. * Fixdotnet#103715. * Add more test cases and fix a number of bugs related to DeepEquals and escaping. * Fix number handling corner case.

eiriktsarpalis · 2024-06-19T21:28:49Z

One of the oddities of JsonNode design is that it permits encapsulation of arbitrary .NET objects via the JsonValue type. This is known to create performance problems since it's not possible to introspect JsonValue instances without serializing and deserializing the underlying object first. The problem is fairly pervasive since JSON primitives such as boolean, numbers and strings are all represented using JsonValue.

This PR refactors the implementation of JsonValue so that common primitive types and deserialized values backed by JsonElement are fully segregated from the implementation that admits arbitrary objects. Consequently this change records substantial performance improvements:

Method	Branch	Mean	Ratio	Allocated	Alloc Ratio
DeepEquals	main	2,859.165 ns	1.00	4224 B	1.00
DeepEquals	PR	270.130 ns	0.09	-	0.00

DeepEquals_JsonElement	main	660.551 ns	1.00	328 B	1.00
DeepEquals_JsonElement	PR	432.391 ns	0.65	-	0.00

GetValueKind	main	612.784 ns	1.000	616 B	1.00
GetValueKind	PR	5.243 ns	0.009	-	0.00

GetValueKind_JsonElement	main	15.557 ns	1.00	-	NA
GetValueKind_JsonElement	PR	11.111 ns	0.71	-	NA

dotnet-policy-service · 2024-06-19T21:29:17Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

gregsdennis · 2024-06-19T22:08:38Z

Just confirming that we're not losing the ability to store arbitrary objects in JsonValue. I actually utilize this in my JSON-e implementation.

eiriktsarpalis · 2024-06-19T22:58:28Z

Just confirming that we're not losing the ability to store arbitrary objects in JsonValue. I actually utilize this in my JSON-e implementation.

We couldn't do that. This change simply isolates that use case from the hot path scenaria.

…d escaping.

eiriktsarpalis · 2024-06-20T20:52:22Z

/ba-g suppressing unrelated test failure to merge ahead of snap.

* Performance improvements in JsonValue. * Fixdotnet#103715. * Add more test cases and fix a number of bugs related to DeepEquals and escaping. * Fix number handling corner case.

eiriktsarpalis · 2024-06-19T21:28:49Z

One of the oddities of JsonNode design is that it permits encapsulation of arbitrary .NET objects via the JsonValue type. This is known to create performance problems since it's not possible to introspect JsonValue instances without serializing and deserializing the underlying object first. The problem is fairly pervasive since JSON primitives such as boolean, numbers and strings are all represented using JsonValue.

This PR refactors the implementation of JsonValue so that common primitive types and deserialized values backed by JsonElement are fully segregated from the implementation that admits arbitrary objects. Consequently this change records substantial performance improvements:

Method	Branch	Mean	Ratio	Allocated	Alloc Ratio
DeepEquals	main	2,859.165 ns	1.00	4224 B	1.00
DeepEquals	PR	270.130 ns	0.09	-	0.00

DeepEquals_JsonElement	main	660.551 ns	1.00	328 B	1.00
DeepEquals_JsonElement	PR	432.391 ns	0.65	-	0.00

GetValueKind	main	612.784 ns	1.000	616 B	1.00
GetValueKind	PR	5.243 ns	0.009	-	0.00

GetValueKind_JsonElement	main	15.557 ns	1.00	-	NA
GetValueKind_JsonElement	PR	11.111 ns	0.71	-	NA

dotnet-policy-service · 2024-06-19T21:29:17Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

gregsdennis · 2024-06-19T22:08:38Z

Just confirming that we're not losing the ability to store arbitrary objects in JsonValue. I actually utilize this in my JSON-e implementation.

eiriktsarpalis · 2024-06-19T22:58:28Z

Just confirming that we're not losing the ability to store arbitrary objects in JsonValue. I actually utilize this in my JSON-e implementation.

We couldn't do that. This change simply isolates that use case from the hot path scenaria.

…d escaping.

eiriktsarpalis · 2024-06-20T20:52:22Z

/ba-g suppressing unrelated test failure to merge ahead of snap.

* Performance improvements in JsonValue. * Fixdotnet#103715. * Add more test cases and fix a number of bugs related to DeepEquals and escaping. * Fix number handling corner case.

eiriktsarpalis · 2024-06-19T21:28:49Z

One of the oddities of JsonNode design is that it permits encapsulation of arbitrary .NET objects via the JsonValue type. This is known to create performance problems since it's not possible to introspect JsonValue instances without serializing and deserializing the underlying object first. The problem is fairly pervasive since JSON primitives such as boolean, numbers and strings are all represented using JsonValue.

This PR refactors the implementation of JsonValue so that common primitive types and deserialized values backed by JsonElement are fully segregated from the implementation that admits arbitrary objects. Consequently this change records substantial performance improvements:

Method	Branch	Mean	Ratio	Allocated	Alloc Ratio
DeepEquals	main	2,859.165 ns	1.00	4224 B	1.00
DeepEquals	PR	270.130 ns	0.09	-	0.00

DeepEquals_JsonElement	main	660.551 ns	1.00	328 B	1.00
DeepEquals_JsonElement	PR	432.391 ns	0.65	-	0.00

GetValueKind	main	612.784 ns	1.000	616 B	1.00
GetValueKind	PR	5.243 ns	0.009	-	0.00

GetValueKind_JsonElement	main	15.557 ns	1.00	-	NA
GetValueKind_JsonElement	PR	11.111 ns	0.71	-	NA

dotnet-policy-service · 2024-06-19T21:29:17Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

gregsdennis · 2024-06-19T22:08:38Z

Just confirming that we're not losing the ability to store arbitrary objects in JsonValue. I actually utilize this in my JSON-e implementation.

eiriktsarpalis · 2024-06-19T22:58:28Z

Just confirming that we're not losing the ability to store arbitrary objects in JsonValue. I actually utilize this in my JSON-e implementation.

We couldn't do that. This change simply isolates that use case from the hot path scenaria.

…d escaping.

eiriktsarpalis · 2024-06-20T20:52:22Z

/ba-g suppressing unrelated test failure to merge ahead of snap.

* Performance improvements in JsonValue. * Fixdotnet#103715. * Add more test cases and fix a number of bugs related to DeepEquals and escaping. * Fix number handling corner case.

eiriktsarpalis · 2024-06-19T21:28:49Z

One of the oddities of JsonNode design is that it permits encapsulation of arbitrary .NET objects via the JsonValue type. This is known to create performance problems since it's not possible to introspect JsonValue instances without serializing and deserializing the underlying object first. The problem is fairly pervasive since JSON primitives such as boolean, numbers and strings are all represented using JsonValue.

This PR refactors the implementation of JsonValue so that common primitive types and deserialized values backed by JsonElement are fully segregated from the implementation that admits arbitrary objects. Consequently this change records substantial performance improvements:

Method	Branch	Mean	Ratio	Allocated	Alloc Ratio
DeepEquals	main	2,859.165 ns	1.00	4224 B	1.00
DeepEquals	PR	270.130 ns	0.09	-	0.00

DeepEquals_JsonElement	main	660.551 ns	1.00	328 B	1.00
DeepEquals_JsonElement	PR	432.391 ns	0.65	-	0.00

GetValueKind	main	612.784 ns	1.000	616 B	1.00
GetValueKind	PR	5.243 ns	0.009	-	0.00

GetValueKind_JsonElement	main	15.557 ns	1.00	-	NA
GetValueKind_JsonElement	PR	11.111 ns	0.71	-	NA

dotnet-policy-service · 2024-06-19T21:29:17Z

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

gregsdennis · 2024-06-19T22:08:38Z

Just confirming that we're not losing the ability to store arbitrary objects in JsonValue. I actually utilize this in my JSON-e implementation.

eiriktsarpalis · 2024-06-19T22:58:28Z

Just confirming that we're not losing the ability to store arbitrary objects in JsonValue. I actually utilize this in my JSON-e implementation.

We couldn't do that. This change simply isolates that use case from the hot path scenaria.

…d escaping.

eiriktsarpalis · 2024-06-20T20:52:22Z

/ba-g suppressing unrelated test failure to merge ahead of snap.

* Performance improvements in JsonValue. * Fixdotnet#103715. * Add more test cases and fix a number of bugs related to DeepEquals and escaping. * Fix number handling corner case.

eiriktsarpalis added 2 commits June 19, 2024 22:18

Performance improvements in JsonValue.
124e54c

Fixdotnet#103715.
91c9d3c

eiriktsarpalis requested a review from stephentoub June 19, 2024 21:28

ghost added the area-System.Text.Json label Jun 19, 2024

eiriktsarpalis added this to the 9.0.0 milestone Jun 19, 2024

eiriktsarpalis self-assigned this Jun 19, 2024

eiriktsarpalis added the tenet-performance Performance related issue label Jun 19, 2024

eiriktsarpalis requested review from jozkee and krwq June 19, 2024 21:31

stephentoub reviewed Jun 19, 2024
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonNode.cs

stephentoub reviewed Jun 19, 2024
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonObject.IDictionary.cs

stephentoub approved these changes Jun 20, 2024
View reviewed changes

This was referenced Jun 20, 2024
Debug assertion failure in System.Net.Http.HttpConnection.SendAsync #100616
Closed
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open

jozkee approved these changes Jun 20, 2024
View reviewed changes

Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValueOfElement.cs
Comment threadsrc/libraries/System.Text.Json/src/System/Text/Json/Nodes/JsonValue.CreateOverloads.cs

eiriktsarpalis added 2 commits June 20, 2024 16:56

Add more test cases and fix a number of bugs related to DeepEquals an…
b59f3fc
…d escaping.

Fix number handling corner case.
b7485ed

This was referenced Jun 20, 2024
Add JsonElement.ValueSpan #77666
Closed
System.Text.Json: add ability to do semantic comparisons of JSON values à la JToken.DeepEquals() #33388
Closed

eiriktsarpalis merged commit d9b9676 into dotnet:mainJun 20, 2024

eiriktsarpalis deleted the jsonnode-perf branch June 20, 2024 20:52

build-analysisBot mentioned this pull request Jun 20, 2024
[Test Failure] System.Net.Http.WinHttpHandlerFunctional.Tests.BidirectionStreamingTest.BackwardsCompatibility_DowngradeToHttp11 #103754
Closed

eiriktsarpalis mentioned this pull request Jun 20, 2024
System.Text.Json.Nodes.Tests.JsonObjectTests.NullPropertyNameFail [FAIL] #103784
Closed

matouskozak mentioned this pull request Jun 26, 2024
[Perf] Linux/arm64: 3 Improvements on 6/20/2024 11:40:03 PM dotnet/perf-autofiling-issues#37025
Closed

jkurdek mentioned this pull request Jun 26, 2024
[Perf] Linux/x64: 2 Regressions on 6/20/2024 11:40:03 PM dotnet/perf-autofiling-issues#36936
Open

lewing mentioned this pull request Jul 1, 2024
[Perf] Linux/x64: 16 Improvements on 6/20/2024 11:40:03 PM dotnet/perf-autofiling-issues#37195
Open

radekdoulik mentioned this pull request Jul 3, 2024
[Perf] Linux/x64: 13 Improvements on 6/19/2024 8:15:59 AM dotnet/perf-autofiling-issues#37032
Open

github-actionsBot locked and limited conversation to collaborators Jul 21, 2024