Uh oh!
There was an error while loading. Please reload this page.
Enable TryFormat_MatchesToString for HybridGlobalization - #104026
Merged
Conversation
for HybridGlobalization`TryFormat_MatchesToString for HybridGlobalizationilonatommy
commented
Jun 26, 2024
MemberAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jun 26, 2024
Open
ilonatommy
commented
Jun 26, 2024
MemberAuthor
We are not running NodeJS on Windows on CI. |
ilonatommy
marked this pull request as ready for review
June 26, 2024 18:37
mkhamoyan
approved these changes
Jun 27, 2024
ilonatommy
marked this pull request as draft
June 27, 2024 07:18
ilonatommy
commented
Jun 27, 2024
MemberAuthor
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Uh oh!
There was an error while loading. Please reload this page.
pavelsavara
approved these changes
Jun 27, 2024
ilonatommy
marked this pull request as ready for review
June 27, 2024 09:55
ilonatommy
commented
Jun 27, 2024
MemberAuthor
/ba-g |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#95623. I cannot reproduce locally.
This PR fixes NodeJS Windows runs, they were not triggered by extra platforms. It also removes a duplicated run of libraries on Windows with Chrome host - it was both in extra platforms and in runtime.