Uh oh!
There was an error while loading. Please reload this page.
Arm64/SVE: Implemented ConvertToint64 and ConvertToUInt64 - #104069
Merged
Conversation
updating branch due to assert issue.
| { | ||
| case NI_Sve_ConvertToInt32: | ||
| case NI_Sve_ConvertToUInt32: | ||
| case NI_Sve_ConvertToInt64: |
Contributor
There was a problem hiding this comment.
I expected to have entries for ConvertToSingle and ConvertToDouble here as well. Did you confirm this works for scenario where maskSize != operSize in lowering?
| (embOp->GetHWIntrinsicId() == NI_Sve_ConvertToUInt32)); | ||
| assert((embOp->GetHWIntrinsicId() == NI_Sve_ConvertToInt32) || | ||
| (embOp->GetHWIntrinsicId() == NI_Sve_ConvertToUInt32) || | ||
| (embOp->GetHWIntrinsicId() == NI_Sve_ConvertToInt64) || |
| opt = intrinEmbMask.baseType == TYP_DOUBLE ? INS_OPTS_D_TO_S : INS_OPTS_SCALABLE_S; | ||
| embOpt = intrinEmbMask.baseType == TYP_DOUBLE ? INS_OPTS_D_TO_S : INS_OPTS_SCALABLE_S; | ||
| break; | ||
| } |
Contributor
There was a problem hiding this comment.
This also needs handling of ConvertToSingle
embOpt = intrinEmbMask.baseType == TYP_DOUBLE ? INS_OPTS_D_TO_S : INS_OPTS_SCALABLE_S;and ConvertToDouble:
embOpt = intrinEmbMask.baseType == TYP_FLOAT ? INS_OPTS_S_TO_D : INS_OPTS_SCALABLE_D;which means you can combine ConvertToSingle with Convert*32 and ConvertToDouble with Convert*64.
ConvertToint64, ConvertToUInt64, ConvertToDouble and ConvertToSingleConvertToint64 and ConvertToUInt64ebepho
marked this pull request as ready for review
June 28, 2024 00:54
kunalspathak
suggested changes
Jun 28, 2024
kunalspathak
left a comment
Contributor
There was a problem hiding this comment.
Added some comments around test. code changes looks good.
| }"; | ||
| const string SimpleVecOpTest_ValidationLogicForCndSelForNarrowing = @"for (var i = 0; i < Op1ElementCount; i++) | ||
| const string SimpleVecOpTest_ValidationLogicForCndSelNarrowing = @"for (var i = 0; i < Op1ElementCount; i++) |
ContributorAuthor
There was a problem hiding this comment.
I reverted this change -- shouldn't have been in this PR
| ("SveSimpleVecOpDifferentRetTypeTest.template", new Dictionary<string, string> { ["TestName"] = "Sve_ConvertToInt32_int_double", ["Isa"] = "Sve", ["LoadIsa"] = "Sve", ["Method"] = "ConvertToInt32", ["RetVectorType"] = "Vector", ["RetBaseType"] = "Int32", ["Op1VectorType"] = "Vector", ["Op1BaseType"] = "Double", ["LargestVectorSize"] = "64", ["NextValueOp1"] = "TestLibrary.Generator.GetDouble()", ["ValidateIterResult"] = "Helpers.ConvertDoubleToInt32(firstOp[i]) != result[i]", ["GetIterResult"] = "Helpers.ConvertDoubleToInt32(leftOp[i])"}), | ||
| ("SveSimpleVecOpDifferentRetTypeTest.template", new Dictionary<string, string> { ["TestName"] = "Sve_ConvertToUInt32_uint_float", ["Isa"] = "Sve", ["LoadIsa"] = "Sve", ["Method"] = "ConvertToUInt32", ["RetVectorType"] = "Vector", ["RetBaseType"] = "UInt32", ["Op1VectorType"] = "Vector", ["Op1BaseType"] = "Single", ["LargestVectorSize"] = "64", ["NextValueOp1"] = "TestLibrary.Generator.GetSingle()", ["ValidateIterResult"] = "Helpers.ConvertToUInt32(firstOp[i]) != result[i]", ["GetIterResult"] = "Helpers.ConvertToUInt32(leftOp[i])"}), | ||
| ("SveSimpleVecOpDifferentRetTypeTest.template", new Dictionary<string, string> { ["TestName"] = "Sve_ConvertToUInt32_uint_double", ["Isa"] = "Sve", ["LoadIsa"] = "Sve", ["Method"] = "ConvertToUInt32", ["RetVectorType"] = "Vector", ["RetBaseType"] = "UInt32", ["Op1VectorType"] = "Vector", ["Op1BaseType"] = "Double", ["LargestVectorSize"] = "64", ["NextValueOp1"] = "TestLibrary.Generator.GetDouble()", ["ValidateIterResult"] = "Helpers.ConvertDoubleToUInt32(firstOp[i]) != result[i]", ["GetIterResult"] = "Helpers.ConvertDoubleToUInt32(leftOp[i])"}), | ||
Contributor
There was a problem hiding this comment.
can you delete the 2 empty lines?
| ("_TernaryOpTestTemplate.template", "SecureHashTernOpTest.template", new Dictionary<string, string> { ["TemplateName"] = "SecureHash", ["TemplateValidationLogic"] = SecureHashOpTest_ValidationLogic }), | ||
| ("_SveUnaryOpTestTemplate.template", "SveSimpleVecOpTest.template", new Dictionary<string, string> { ["TemplateName"] = "Simple", ["TemplateValidationLogic"] = SimpleVecOpTest_ValidationLogic, ["TemplateValidationLogicForCndSel"] = SimpleVecOpTest_ValidationLogicForCndSel }), | ||
| ("_SveUnaryOpDifferentRetTypeTestTemplate.template", "SveSimpleVecOpDifferentRetTypeTest.template", new Dictionary<string, string> { ["TemplateName"] = "Simple", ["TemplateValidationLogic"] = SimpleVecOpTest_ValidationLogicForNarrowing, ["TemplateValidationLogicForCndSel"] = SimpleVecOpTest_ValidationLogicForCndSelForNarrowing }), | ||
| ("_SveUnaryOpDifferentRetTypeTestTemplate.template", "SveSimpleVecOpDifferentRetTypeTest.template", new Dictionary<string, string> { ["TemplateName"] = "Simple", ["TemplateValidationLogic"] = SimpleVecOpTest_ValidationLogicForNarrowing, ["TemplateValidationLogicForCndSel"] = SimpleVecOpTest_ValidationLogicForCndSelNarrowing }), |
| const string SimpleVecOpTest_ValidationLogicForCndSelForNarrowing = @"for (var i = 0; i < Op1ElementCount; i++) | ||
| { | ||
| {Op1BaseType} iterResult = (mask[i] != 0) ? {GetIterResult} : falseVal[i]; | ||
| {RetBaseType} iterResult = (mask[i] != 0) ? {GetIterResult} : falseVal[i]; |
Contributor
There was a problem hiding this comment.
Suggested change
| {RetBaseType}iterResult=(mask[i]!=0)?{GetIterResult}:falseVal[i]; | |
| {Op1BaseType}iterResult=(mask[i]!=0)?{GetIterResult}:falseVal[i]; |
ContributorAuthor
There was a problem hiding this comment.
I'm going to test this version one more time. Not sure why these changes even appeared, but I think they were supposed to be part of the ConvertToInt32 commit. These changes may be necessary for the tests to run properly.
kunalspathak
commented
Jun 28, 2024
Contributor
/azp |
Supported commands
See additional documentation. |
This was referenced Jun 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #99957
ConvertToInt64andConvertToUInt64stress test output:cc @dotnet/arm64-contrib