Optimize Vector128<long> multiplication for arm64 - #104177

Merged
EgorBo merged 8 commits into
dotnet:mainfrom
EgorBo:mul-long-arm64
Jul 2, 2024
Merged

Optimize Vector128<long> multiplication for arm64#104177
EgorBo merged 8 commits into
dotnet:mainfrom
EgorBo:mul-long-arm64

Conversation

@EgorBo

@EgorBoEgorBo commented Jun 28, 2024

Copy link
Copy Markdown
Member

Follow up to #103555 for arm64

@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 28, 2024
@EgorBo

EgorBo commented Jun 28, 2024

Copy link
Copy Markdown
MemberAuthor

@EgorBot -arm64 -profiler

usingSystem.IO.Hashing;usingBenchmarkDotNet.Attributes;publicclassBench{staticreadonlybyte[]Data=newbyte[1000000];[Benchmark]publicbyte[]BenchXxHash128(){XxHash128hash=new();hash.Append(Data);returnhash.GetHashAndReset();}}

@dotnet-policy-service

dotnet-policy-serviceBot commented Jun 28, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

tannergooding
tannergooding reviewed Jun 28, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/hwintrinsicarm64.cpp Outdated
tannergooding
tannergooding reviewed Jun 28, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp
Comment on lines +21932 to +21957
case TYP_LONG:
case TYP_ULONG:
{
assert(simdSize == 16);

// Make op1 and op2 multi-use:
GenTree* op1Dup = fgMakeMultiUse(&op1);
GenTree* op2Dup = fgMakeMultiUse(&op2);

// long left0 = op1.GetElement(0)
// long left1 = op1.GetElement(1)
GenTree* left0 = gtNewSimdGetElementNode(TYP_LONG, op1, gtNewIconNode(0), simdBaseJitType, 16);
GenTree* left1 = gtNewSimdGetElementNode(TYP_LONG, op1Dup, gtNewIconNode(1), simdBaseJitType, 16);

// long right0 = op2.GetElement(0)
// long right1 = op2.GetElement(1)
GenTree* right0 = gtNewSimdGetElementNode(TYP_LONG, op2, gtNewIconNode(0), simdBaseJitType, 16);
GenTree* right1 = gtNewSimdGetElementNode(TYP_LONG, op2Dup, gtNewIconNode(1), simdBaseJitType, 16);

// Vector128<long> vec = Vector128.Create(left0 * right0, left1 * right1)
op1 = gtNewOperNode(GT_MUL, TYP_LONG, left0, right0);
op2 = gtNewOperNode(GT_MUL, TYP_LONG, left1, right1);
GenTree* vec = gtNewSimdCreateScalarUnsafeNode(TYP_SIMD16, op1, simdBaseJitType, 16);
return gtNewSimdHWIntrinsicNode(TYP_SIMD16, vec, gtNewIconNode(1), op2, NI_AdvSimd_Insert,
simdBaseJitType, 16);
}

@tannergoodingtannergoodingJun 28, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just avoiding the cost of inlining, unrolling, and simplifying the work the JIT would have to do?

@EgorBot

EgorBot commented Jun 28, 2024

Copy link
Copy Markdown
Benchmark results on Arm64
BenchmarkDotNet v0.13.12, Ubuntu 22.04.4 LTS (Jammy Jellyfish)
Unknown processor
Job-OMCIXQ : .NET 9.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD
Job-KTSNVH : .NET 9.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD
MethodToolchainMeanErrorRatio
BenchXxHash128Main116.9 μs0.05 μs1.00
BenchXxHash128PR109.8 μs0.04 μs0.94

BDN_Artifacts.zip

Flame graphs: Main vs PR 🔥
Hot asm: Main vs PR
Hot functions: Main vs PR

For clean perf results, make sure you have just one [Benchmark] in your app.

@build-analysisbuild-analysisBot mentioned this pull request Jun 28, 2024
Closed
@neon-sunset

neon-sunset commented Jul 1, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

I wanted to ask is there a reason LLVM's codegen variant did not work? On some cores, UMOV/SMOV has pretty bad latency vs code that avoids a round-trip to scalar registers.

@build-analysisbuild-analysisBot mentioned this pull request Jul 1, 2024
Closed
tannergooding
tannergooding reviewed Jul 1, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp Outdated
Comment on lines +22005 to +22006
return gtNewSimdHWIntrinsicNode(type, vec, gtNewIconNode(1), op2, NI_AdvSimd_Insert,
simdBaseJitType, 16);

@tannergoodingtannergoodingJul 1, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Use gtNewSimdWithElementNode(type, vec, gtNewIconNode(1), op2, simdBaseJitType, simdSize) which ensures all the optimal handling takes place.

@EgorBoEgorBoJul 2, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Applied

@EgorBo
EgorBo marked this pull request as ready for review July 2, 2024 18:03
@EgorBo
EgorBo merged commit 6e039a8 into dotnet:mainJul 2, 2024
@EgorBo
EgorBo deleted the mul-long-arm64 branch July 2, 2024 18:03
tannergooding
tannergooding reviewed Jul 2, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp
Comment on lines +21981 to +21982
op1 = gtNewBitCastNode(TYP_LONG, op1);
op2 = gtNewBitCastNode(TYP_LONG, op2);

@tannergoodingtannergoodingJul 2, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bitcast instead of ToScalar? If this is generating better code, it seems like a pretty "core" scenario we're not handling from the ToScalar path

@EgorBoEgorBoJul 2, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannergooding because op2 can be either 8-byte TYP_SIMD8 or 8-byte scalar (TYP_LONG) so bitcast allowed me to simplify handling. In my initial version I forgot that this path is used for both MUL(vector, vector) and MUL(vector, scalar) (where scalar is broadcasted)

@tannergoodingtannergoodingJul 2, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense, 👍

@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 2, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergoodingtannergoodingtannergooding approved these changes

Assignees

@EgorBoEgorBo

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@EgorBo@EgorBot@neon-sunset@tannergooding
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Optimize Vector128<long> multiplication for arm64 - #104177
Merged
EgorBo merged 8 commits into
dotnet:mainfrom 
EgorBo:mul-long-arm64
Jul 2, 2024
Merged
Optimize Vector128<long> multiplication for arm64#104177
EgorBo merged 8 commits into
dotnet:mainfrom 
EgorBo:mul-long-arm64
Conversation
@EgorBo
@EgorBoEgorBo
commented
Jun 28, 2024

Copy link


Copy Markdown

Member
Follow up to #103555 for arm64
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 28, 2024
@EgorBo
EgorBo
commented
Jun 28, 2024

Copy link


Copy Markdown

MemberAuthor
@EgorBot -arm64 -profiler
usingSystem.IO.Hashing;usingBenchmarkDotNet.Attributes;publicclassBench{staticreadonlybyte[]Data=newbyte[1000000];[Benchmark]publicbyte[]BenchXxHash128(){XxHash128hash=new();hash.Append(Data);returnhash.GetHashAndReset();}}
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 28, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
tannergooding
tannergooding
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/hwintrinsicarm64.cpp
Outdated

tannergooding
tannergooding
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp

Comment on lines

+21932
 to 
+21957

 case TYP_LONG:
 case TYP_ULONG:
 {
 assert(simdSize == 16);

 // Make op1 and op2 multi-use:
 GenTree* op1Dup = fgMakeMultiUse(&op1);
 GenTree* op2Dup = fgMakeMultiUse(&op2);

 // long left0 = op1.GetElement(0)
 // long left1 = op1.GetElement(1)
 GenTree* left0 = gtNewSimdGetElementNode(TYP_LONG, op1, gtNewIconNode(0), simdBaseJitType, 16);
 GenTree* left1 = gtNewSimdGetElementNode(TYP_LONG, op1Dup, gtNewIconNode(1), simdBaseJitType, 16);

 // long right0 = op2.GetElement(0)
 // long right1 = op2.GetElement(1)
 GenTree* right0 = gtNewSimdGetElementNode(TYP_LONG, op2, gtNewIconNode(0), simdBaseJitType, 16);
 GenTree* right1 = gtNewSimdGetElementNode(TYP_LONG, op2Dup, gtNewIconNode(1), simdBaseJitType, 16);

 // Vector128<long> vec = Vector128.Create(left0 * right0, left1 * right1)
 op1 = gtNewOperNode(GT_MUL, TYP_LONG, left0, right0);
 op2 = gtNewOperNode(GT_MUL, TYP_LONG, left1, right1);
 GenTree* vec = gtNewSimdCreateScalarUnsafeNode(TYP_SIMD16, op1, simdBaseJitType, 16);
 return gtNewSimdHWIntrinsicNode(TYP_SIMD16, vec, gtNewIconNode(1), op2, NI_AdvSimd_Insert,
 simdBaseJitType, 16);
 }
@tannergoodingtannergoodingJun 28, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just avoiding the cost of inlining, unrolling, and simplifying the work the JIT would have to do?
@EgorBot
EgorBot
commented
Jun 28, 2024

Copy link


Copy Markdown

Benchmark results on Arm64
BenchmarkDotNet v0.13.12, Ubuntu 22.04.4 LTS (Jammy Jellyfish)
Unknown processor
Job-OMCIXQ : .NET 9.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD
Job-KTSNVH : .NET 9.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD

MethodToolchainMeanErrorRatio
BenchXxHash128Main116.9 μs0.05 μs1.00
BenchXxHash128PR109.8 μs0.04 μs0.94
BDN_Artifacts.zip
Flame graphs: Main vs PR 🔥

Hot asm: Main vs PR

Hot functions: Main vs PR
For clean perf results, make sure you have just one [Benchmark] in your app.
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 28, 2024

Closed

@neon-sunset
neon-sunset
commented
Jul 1, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
I wanted to ask is there a reason LLVM's codegen variant did not work? On some cores, UMOV/SMOV has pretty bad latency vs code that avoids a round-trip to scalar registers.
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 1, 2024

Closed

tannergooding
tannergooding
reviewed
Jul 1, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp
Outdated


Comment on lines

+22005
 to 
+22006

 return gtNewSimdHWIntrinsicNode(type, vec, gtNewIconNode(1), op2, NI_AdvSimd_Insert,
 simdBaseJitType, 16);
@tannergoodingtannergoodingJul 1, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Use gtNewSimdWithElementNode(type, vec, gtNewIconNode(1), op2, simdBaseJitType, simdSize) which ensures all the optimal handling takes place.
@EgorBoEgorBoJul 2, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Applied
@EgorBo
EgorBo
marked this pull request as ready for review
July 2, 2024 18:03
@EgorBo
EgorBo
merged commit 6e039a8
into
dotnet:mainJul 2, 2024
@EgorBo
EgorBo
deleted the

mul-long-arm64

branch
July 2, 2024 18:03
tannergooding
tannergooding
reviewed
Jul 2, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp

Comment on lines

+21981
 to 
+21982

 op1 = gtNewBitCastNode(TYP_LONG, op1);
 op2 = gtNewBitCastNode(TYP_LONG, op2);
@tannergoodingtannergoodingJul 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bitcast instead of ToScalar? If this is generating better code, it seems like a pretty "core" scenario we're not handling from the ToScalar path
@EgorBoEgorBoJul 2, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannergooding because op2 can be either 8-byte TYP_SIMD8 or 8-byte scalar (TYP_LONG) so bitcast allowed me to simplify handling. In my initial version I forgot that this path is used for both MUL(vector, vector) and MUL(vector, scalar) (where scalar is broadcasted)
@tannergoodingtannergoodingJul 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense, 👍
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 2, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes

Assignees

@EgorBoEgorBo

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@EgorBo@EgorBot@neon-sunset@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Optimize Vector128<long> multiplication for arm64 - #104177
Merged
EgorBo merged 8 commits into
dotnet:mainfrom 
EgorBo:mul-long-arm64
Jul 2, 2024
Merged
Optimize Vector128<long> multiplication for arm64#104177
EgorBo merged 8 commits into
dotnet:mainfrom 
EgorBo:mul-long-arm64
Conversation
@EgorBo
@EgorBoEgorBo
commented
Jun 28, 2024

Copy link


Copy Markdown

Member
Follow up to #103555 for arm64
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 28, 2024
@EgorBo
EgorBo
commented
Jun 28, 2024

Copy link


Copy Markdown

MemberAuthor
@EgorBot -arm64 -profiler
usingSystem.IO.Hashing;usingBenchmarkDotNet.Attributes;publicclassBench{staticreadonlybyte[]Data=newbyte[1000000];[Benchmark]publicbyte[]BenchXxHash128(){XxHash128hash=new();hash.Append(Data);returnhash.GetHashAndReset();}}
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 28, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
tannergooding
tannergooding
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/hwintrinsicarm64.cpp
Outdated

tannergooding
tannergooding
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp

Comment on lines

+21932
 to 
+21957

 case TYP_LONG:
 case TYP_ULONG:
 {
 assert(simdSize == 16);

 // Make op1 and op2 multi-use:
 GenTree* op1Dup = fgMakeMultiUse(&op1);
 GenTree* op2Dup = fgMakeMultiUse(&op2);

 // long left0 = op1.GetElement(0)
 // long left1 = op1.GetElement(1)
 GenTree* left0 = gtNewSimdGetElementNode(TYP_LONG, op1, gtNewIconNode(0), simdBaseJitType, 16);
 GenTree* left1 = gtNewSimdGetElementNode(TYP_LONG, op1Dup, gtNewIconNode(1), simdBaseJitType, 16);

 // long right0 = op2.GetElement(0)
 // long right1 = op2.GetElement(1)
 GenTree* right0 = gtNewSimdGetElementNode(TYP_LONG, op2, gtNewIconNode(0), simdBaseJitType, 16);
 GenTree* right1 = gtNewSimdGetElementNode(TYP_LONG, op2Dup, gtNewIconNode(1), simdBaseJitType, 16);

 // Vector128<long> vec = Vector128.Create(left0 * right0, left1 * right1)
 op1 = gtNewOperNode(GT_MUL, TYP_LONG, left0, right0);
 op2 = gtNewOperNode(GT_MUL, TYP_LONG, left1, right1);
 GenTree* vec = gtNewSimdCreateScalarUnsafeNode(TYP_SIMD16, op1, simdBaseJitType, 16);
 return gtNewSimdHWIntrinsicNode(TYP_SIMD16, vec, gtNewIconNode(1), op2, NI_AdvSimd_Insert,
 simdBaseJitType, 16);
 }
@tannergoodingtannergoodingJun 28, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just avoiding the cost of inlining, unrolling, and simplifying the work the JIT would have to do?
@EgorBot
EgorBot
commented
Jun 28, 2024

Copy link


Copy Markdown

Benchmark results on Arm64
BenchmarkDotNet v0.13.12, Ubuntu 22.04.4 LTS (Jammy Jellyfish)
Unknown processor
Job-OMCIXQ : .NET 9.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD
Job-KTSNVH : .NET 9.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD

MethodToolchainMeanErrorRatio
BenchXxHash128Main116.9 μs0.05 μs1.00
BenchXxHash128PR109.8 μs0.04 μs0.94
BDN_Artifacts.zip
Flame graphs: Main vs PR 🔥

Hot asm: Main vs PR

Hot functions: Main vs PR
For clean perf results, make sure you have just one [Benchmark] in your app.
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 28, 2024

Closed

@neon-sunset
neon-sunset
commented
Jul 1, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
I wanted to ask is there a reason LLVM's codegen variant did not work? On some cores, UMOV/SMOV has pretty bad latency vs code that avoids a round-trip to scalar registers.
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 1, 2024

Closed

tannergooding
tannergooding
reviewed
Jul 1, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp
Outdated


Comment on lines

+22005
 to 
+22006

 return gtNewSimdHWIntrinsicNode(type, vec, gtNewIconNode(1), op2, NI_AdvSimd_Insert,
 simdBaseJitType, 16);
@tannergoodingtannergoodingJul 1, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Use gtNewSimdWithElementNode(type, vec, gtNewIconNode(1), op2, simdBaseJitType, simdSize) which ensures all the optimal handling takes place.
@EgorBoEgorBoJul 2, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Applied
@EgorBo
EgorBo
marked this pull request as ready for review
July 2, 2024 18:03
@EgorBo
EgorBo
merged commit 6e039a8
into
dotnet:mainJul 2, 2024
@EgorBo
EgorBo
deleted the

mul-long-arm64

branch
July 2, 2024 18:03
tannergooding
tannergooding
reviewed
Jul 2, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp

Comment on lines

+21981
 to 
+21982

 op1 = gtNewBitCastNode(TYP_LONG, op1);
 op2 = gtNewBitCastNode(TYP_LONG, op2);
@tannergoodingtannergoodingJul 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bitcast instead of ToScalar? If this is generating better code, it seems like a pretty "core" scenario we're not handling from the ToScalar path
@EgorBoEgorBoJul 2, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannergooding because op2 can be either 8-byte TYP_SIMD8 or 8-byte scalar (TYP_LONG) so bitcast allowed me to simplify handling. In my initial version I forgot that this path is used for both MUL(vector, vector) and MUL(vector, scalar) (where scalar is broadcasted)
@tannergoodingtannergoodingJul 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense, 👍
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 2, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes

Assignees

@EgorBoEgorBo

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@EgorBo@EgorBot@neon-sunset@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Optimize Vector128<long> multiplication for arm64 - #104177
Merged
EgorBo merged 8 commits into
dotnet:mainfrom 
EgorBo:mul-long-arm64
Jul 2, 2024
Merged
Optimize Vector128<long> multiplication for arm64#104177
EgorBo merged 8 commits into
dotnet:mainfrom 
EgorBo:mul-long-arm64
Conversation
@EgorBo
@EgorBoEgorBo
commented
Jun 28, 2024

Copy link


Copy Markdown

Member
Follow up to #103555 for arm64
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 28, 2024
@EgorBo
EgorBo
commented
Jun 28, 2024

Copy link


Copy Markdown

MemberAuthor
@EgorBot -arm64 -profiler
usingSystem.IO.Hashing;usingBenchmarkDotNet.Attributes;publicclassBench{staticreadonlybyte[]Data=newbyte[1000000];[Benchmark]publicbyte[]BenchXxHash128(){XxHash128hash=new();hash.Append(Data);returnhash.GetHashAndReset();}}
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 28, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
tannergooding
tannergooding
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/hwintrinsicarm64.cpp
Outdated

tannergooding
tannergooding
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp

Comment on lines

+21932
 to 
+21957

 case TYP_LONG:
 case TYP_ULONG:
 {
 assert(simdSize == 16);

 // Make op1 and op2 multi-use:
 GenTree* op1Dup = fgMakeMultiUse(&op1);
 GenTree* op2Dup = fgMakeMultiUse(&op2);

 // long left0 = op1.GetElement(0)
 // long left1 = op1.GetElement(1)
 GenTree* left0 = gtNewSimdGetElementNode(TYP_LONG, op1, gtNewIconNode(0), simdBaseJitType, 16);
 GenTree* left1 = gtNewSimdGetElementNode(TYP_LONG, op1Dup, gtNewIconNode(1), simdBaseJitType, 16);

 // long right0 = op2.GetElement(0)
 // long right1 = op2.GetElement(1)
 GenTree* right0 = gtNewSimdGetElementNode(TYP_LONG, op2, gtNewIconNode(0), simdBaseJitType, 16);
 GenTree* right1 = gtNewSimdGetElementNode(TYP_LONG, op2Dup, gtNewIconNode(1), simdBaseJitType, 16);

 // Vector128<long> vec = Vector128.Create(left0 * right0, left1 * right1)
 op1 = gtNewOperNode(GT_MUL, TYP_LONG, left0, right0);
 op2 = gtNewOperNode(GT_MUL, TYP_LONG, left1, right1);
 GenTree* vec = gtNewSimdCreateScalarUnsafeNode(TYP_SIMD16, op1, simdBaseJitType, 16);
 return gtNewSimdHWIntrinsicNode(TYP_SIMD16, vec, gtNewIconNode(1), op2, NI_AdvSimd_Insert,
 simdBaseJitType, 16);
 }
@tannergoodingtannergoodingJun 28, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just avoiding the cost of inlining, unrolling, and simplifying the work the JIT would have to do?
@EgorBot
EgorBot
commented
Jun 28, 2024

Copy link


Copy Markdown

Benchmark results on Arm64
BenchmarkDotNet v0.13.12, Ubuntu 22.04.4 LTS (Jammy Jellyfish)
Unknown processor
Job-OMCIXQ : .NET 9.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD
Job-KTSNVH : .NET 9.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD

MethodToolchainMeanErrorRatio
BenchXxHash128Main116.9 μs0.05 μs1.00
BenchXxHash128PR109.8 μs0.04 μs0.94
BDN_Artifacts.zip
Flame graphs: Main vs PR 🔥

Hot asm: Main vs PR

Hot functions: Main vs PR
For clean perf results, make sure you have just one [Benchmark] in your app.
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 28, 2024

Closed

@neon-sunset
neon-sunset
commented
Jul 1, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
I wanted to ask is there a reason LLVM's codegen variant did not work? On some cores, UMOV/SMOV has pretty bad latency vs code that avoids a round-trip to scalar registers.
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 1, 2024

Closed

tannergooding
tannergooding
reviewed
Jul 1, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp
Outdated


Comment on lines

+22005
 to 
+22006

 return gtNewSimdHWIntrinsicNode(type, vec, gtNewIconNode(1), op2, NI_AdvSimd_Insert,
 simdBaseJitType, 16);
@tannergoodingtannergoodingJul 1, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Use gtNewSimdWithElementNode(type, vec, gtNewIconNode(1), op2, simdBaseJitType, simdSize) which ensures all the optimal handling takes place.
@EgorBoEgorBoJul 2, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Applied
@EgorBo
EgorBo
marked this pull request as ready for review
July 2, 2024 18:03
@EgorBo
EgorBo
merged commit 6e039a8
into
dotnet:mainJul 2, 2024
@EgorBo
EgorBo
deleted the

mul-long-arm64

branch
July 2, 2024 18:03
tannergooding
tannergooding
reviewed
Jul 2, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp

Comment on lines

+21981
 to 
+21982

 op1 = gtNewBitCastNode(TYP_LONG, op1);
 op2 = gtNewBitCastNode(TYP_LONG, op2);
@tannergoodingtannergoodingJul 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bitcast instead of ToScalar? If this is generating better code, it seems like a pretty "core" scenario we're not handling from the ToScalar path
@EgorBoEgorBoJul 2, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannergooding because op2 can be either 8-byte TYP_SIMD8 or 8-byte scalar (TYP_LONG) so bitcast allowed me to simplify handling. In my initial version I forgot that this path is used for both MUL(vector, vector) and MUL(vector, scalar) (where scalar is broadcasted)
@tannergoodingtannergoodingJul 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense, 👍
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 2, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes

Assignees

@EgorBoEgorBo

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@EgorBo@EgorBot@neon-sunset@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Optimize Vector128<long> multiplication for arm64 - #104177
Merged
EgorBo merged 8 commits into
dotnet:mainfrom 
EgorBo:mul-long-arm64
Jul 2, 2024
Merged
Optimize Vector128<long> multiplication for arm64#104177
EgorBo merged 8 commits into
dotnet:mainfrom 
EgorBo:mul-long-arm64
Conversation
@EgorBo
@EgorBoEgorBo
commented
Jun 28, 2024

Copy link


Copy Markdown

Member
Follow up to #103555 for arm64
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 28, 2024
@EgorBo
EgorBo
commented
Jun 28, 2024

Copy link


Copy Markdown

MemberAuthor
@EgorBot -arm64 -profiler
usingSystem.IO.Hashing;usingBenchmarkDotNet.Attributes;publicclassBench{staticreadonlybyte[]Data=newbyte[1000000];[Benchmark]publicbyte[]BenchXxHash128(){XxHash128hash=new();hash.Append(Data);returnhash.GetHashAndReset();}}
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 28, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
tannergooding
tannergooding
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/hwintrinsicarm64.cpp
Outdated

tannergooding
tannergooding
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp

Comment on lines

+21932
 to 
+21957

 case TYP_LONG:
 case TYP_ULONG:
 {
 assert(simdSize == 16);

 // Make op1 and op2 multi-use:
 GenTree* op1Dup = fgMakeMultiUse(&op1);
 GenTree* op2Dup = fgMakeMultiUse(&op2);

 // long left0 = op1.GetElement(0)
 // long left1 = op1.GetElement(1)
 GenTree* left0 = gtNewSimdGetElementNode(TYP_LONG, op1, gtNewIconNode(0), simdBaseJitType, 16);
 GenTree* left1 = gtNewSimdGetElementNode(TYP_LONG, op1Dup, gtNewIconNode(1), simdBaseJitType, 16);

 // long right0 = op2.GetElement(0)
 // long right1 = op2.GetElement(1)
 GenTree* right0 = gtNewSimdGetElementNode(TYP_LONG, op2, gtNewIconNode(0), simdBaseJitType, 16);
 GenTree* right1 = gtNewSimdGetElementNode(TYP_LONG, op2Dup, gtNewIconNode(1), simdBaseJitType, 16);

 // Vector128<long> vec = Vector128.Create(left0 * right0, left1 * right1)
 op1 = gtNewOperNode(GT_MUL, TYP_LONG, left0, right0);
 op2 = gtNewOperNode(GT_MUL, TYP_LONG, left1, right1);
 GenTree* vec = gtNewSimdCreateScalarUnsafeNode(TYP_SIMD16, op1, simdBaseJitType, 16);
 return gtNewSimdHWIntrinsicNode(TYP_SIMD16, vec, gtNewIconNode(1), op2, NI_AdvSimd_Insert,
 simdBaseJitType, 16);
 }
@tannergoodingtannergoodingJun 28, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just avoiding the cost of inlining, unrolling, and simplifying the work the JIT would have to do?
@EgorBot
EgorBot
commented
Jun 28, 2024

Copy link


Copy Markdown

Benchmark results on Arm64
BenchmarkDotNet v0.13.12, Ubuntu 22.04.4 LTS (Jammy Jellyfish)
Unknown processor
Job-OMCIXQ : .NET 9.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD
Job-KTSNVH : .NET 9.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD

MethodToolchainMeanErrorRatio
BenchXxHash128Main116.9 μs0.05 μs1.00
BenchXxHash128PR109.8 μs0.04 μs0.94
BDN_Artifacts.zip
Flame graphs: Main vs PR 🔥

Hot asm: Main vs PR

Hot functions: Main vs PR
For clean perf results, make sure you have just one [Benchmark] in your app.
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 28, 2024

Closed

@neon-sunset
neon-sunset
commented
Jul 1, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
I wanted to ask is there a reason LLVM's codegen variant did not work? On some cores, UMOV/SMOV has pretty bad latency vs code that avoids a round-trip to scalar registers.
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 1, 2024

Closed

tannergooding
tannergooding
reviewed
Jul 1, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp
Outdated


Comment on lines

+22005
 to 
+22006

 return gtNewSimdHWIntrinsicNode(type, vec, gtNewIconNode(1), op2, NI_AdvSimd_Insert,
 simdBaseJitType, 16);
@tannergoodingtannergoodingJul 1, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Use gtNewSimdWithElementNode(type, vec, gtNewIconNode(1), op2, simdBaseJitType, simdSize) which ensures all the optimal handling takes place.
@EgorBoEgorBoJul 2, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Applied
@EgorBo
EgorBo
marked this pull request as ready for review
July 2, 2024 18:03
@EgorBo
EgorBo
merged commit 6e039a8
into
dotnet:mainJul 2, 2024
@EgorBo
EgorBo
deleted the

mul-long-arm64

branch
July 2, 2024 18:03
tannergooding
tannergooding
reviewed
Jul 2, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp

Comment on lines

+21981
 to 
+21982

 op1 = gtNewBitCastNode(TYP_LONG, op1);
 op2 = gtNewBitCastNode(TYP_LONG, op2);
@tannergoodingtannergoodingJul 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bitcast instead of ToScalar? If this is generating better code, it seems like a pretty "core" scenario we're not handling from the ToScalar path
@EgorBoEgorBoJul 2, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannergooding because op2 can be either 8-byte TYP_SIMD8 or 8-byte scalar (TYP_LONG) so bitcast allowed me to simplify handling. In my initial version I forgot that this path is used for both MUL(vector, vector) and MUL(vector, scalar) (where scalar is broadcasted)
@tannergoodingtannergoodingJul 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense, 👍
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 2, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes

Assignees

@EgorBoEgorBo

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@EgorBo@EgorBot@neon-sunset@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Optimize Vector128<long> multiplication for arm64 - #104177
Merged
EgorBo merged 8 commits into
dotnet:mainfrom 
EgorBo:mul-long-arm64
Jul 2, 2024
Merged
Optimize Vector128<long> multiplication for arm64#104177
EgorBo merged 8 commits into
dotnet:mainfrom 
EgorBo:mul-long-arm64
Conversation
@EgorBo
@EgorBoEgorBo
commented
Jun 28, 2024

Copy link


Copy Markdown

Member
Follow up to #103555 for arm64
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 28, 2024
@EgorBo
EgorBo
commented
Jun 28, 2024

Copy link


Copy Markdown

MemberAuthor
@EgorBot -arm64 -profiler
usingSystem.IO.Hashing;usingBenchmarkDotNet.Attributes;publicclassBench{staticreadonlybyte[]Data=newbyte[1000000];[Benchmark]publicbyte[]BenchXxHash128(){XxHash128hash=new();hash.Append(Data);returnhash.GetHashAndReset();}}
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 28, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
tannergooding
tannergooding
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/hwintrinsicarm64.cpp
Outdated

tannergooding
tannergooding
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp

Comment on lines

+21932
 to 
+21957

 case TYP_LONG:
 case TYP_ULONG:
 {
 assert(simdSize == 16);

 // Make op1 and op2 multi-use:
 GenTree* op1Dup = fgMakeMultiUse(&op1);
 GenTree* op2Dup = fgMakeMultiUse(&op2);

 // long left0 = op1.GetElement(0)
 // long left1 = op1.GetElement(1)
 GenTree* left0 = gtNewSimdGetElementNode(TYP_LONG, op1, gtNewIconNode(0), simdBaseJitType, 16);
 GenTree* left1 = gtNewSimdGetElementNode(TYP_LONG, op1Dup, gtNewIconNode(1), simdBaseJitType, 16);

 // long right0 = op2.GetElement(0)
 // long right1 = op2.GetElement(1)
 GenTree* right0 = gtNewSimdGetElementNode(TYP_LONG, op2, gtNewIconNode(0), simdBaseJitType, 16);
 GenTree* right1 = gtNewSimdGetElementNode(TYP_LONG, op2Dup, gtNewIconNode(1), simdBaseJitType, 16);

 // Vector128<long> vec = Vector128.Create(left0 * right0, left1 * right1)
 op1 = gtNewOperNode(GT_MUL, TYP_LONG, left0, right0);
 op2 = gtNewOperNode(GT_MUL, TYP_LONG, left1, right1);
 GenTree* vec = gtNewSimdCreateScalarUnsafeNode(TYP_SIMD16, op1, simdBaseJitType, 16);
 return gtNewSimdHWIntrinsicNode(TYP_SIMD16, vec, gtNewIconNode(1), op2, NI_AdvSimd_Insert,
 simdBaseJitType, 16);
 }
@tannergoodingtannergoodingJun 28, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just avoiding the cost of inlining, unrolling, and simplifying the work the JIT would have to do?
@EgorBot
EgorBot
commented
Jun 28, 2024

Copy link


Copy Markdown

Benchmark results on Arm64
BenchmarkDotNet v0.13.12, Ubuntu 22.04.4 LTS (Jammy Jellyfish)
Unknown processor
Job-OMCIXQ : .NET 9.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD
Job-KTSNVH : .NET 9.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD

MethodToolchainMeanErrorRatio
BenchXxHash128Main116.9 μs0.05 μs1.00
BenchXxHash128PR109.8 μs0.04 μs0.94
BDN_Artifacts.zip
Flame graphs: Main vs PR 🔥

Hot asm: Main vs PR

Hot functions: Main vs PR
For clean perf results, make sure you have just one [Benchmark] in your app.
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 28, 2024

Closed

@neon-sunset
neon-sunset
commented
Jul 1, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
I wanted to ask is there a reason LLVM's codegen variant did not work? On some cores, UMOV/SMOV has pretty bad latency vs code that avoids a round-trip to scalar registers.
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 1, 2024

Closed

tannergooding
tannergooding
reviewed
Jul 1, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp
Outdated


Comment on lines

+22005
 to 
+22006

 return gtNewSimdHWIntrinsicNode(type, vec, gtNewIconNode(1), op2, NI_AdvSimd_Insert,
 simdBaseJitType, 16);
@tannergoodingtannergoodingJul 1, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Use gtNewSimdWithElementNode(type, vec, gtNewIconNode(1), op2, simdBaseJitType, simdSize) which ensures all the optimal handling takes place.
@EgorBoEgorBoJul 2, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Applied
@EgorBo
EgorBo
marked this pull request as ready for review
July 2, 2024 18:03
@EgorBo
EgorBo
merged commit 6e039a8
into
dotnet:mainJul 2, 2024
@EgorBo
EgorBo
deleted the

mul-long-arm64

branch
July 2, 2024 18:03
tannergooding
tannergooding
reviewed
Jul 2, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp

Comment on lines

+21981
 to 
+21982

 op1 = gtNewBitCastNode(TYP_LONG, op1);
 op2 = gtNewBitCastNode(TYP_LONG, op2);
@tannergoodingtannergoodingJul 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bitcast instead of ToScalar? If this is generating better code, it seems like a pretty "core" scenario we're not handling from the ToScalar path
@EgorBoEgorBoJul 2, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannergooding because op2 can be either 8-byte TYP_SIMD8 or 8-byte scalar (TYP_LONG) so bitcast allowed me to simplify handling. In my initial version I forgot that this path is used for both MUL(vector, vector) and MUL(vector, scalar) (where scalar is broadcasted)
@tannergoodingtannergoodingJul 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense, 👍
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 2, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes

Assignees

@EgorBoEgorBo

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@EgorBo@EgorBot@neon-sunset@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Optimize Vector128<long> multiplication for arm64 - #104177
Merged
EgorBo merged 8 commits into
dotnet:mainfrom 
EgorBo:mul-long-arm64
Jul 2, 2024
Merged
Optimize Vector128<long> multiplication for arm64#104177
EgorBo merged 8 commits into
dotnet:mainfrom 
EgorBo:mul-long-arm64
Conversation
@EgorBo
@EgorBoEgorBo
commented
Jun 28, 2024

Copy link


Copy Markdown

Member
Follow up to #103555 for arm64
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 28, 2024
@EgorBo
EgorBo
commented
Jun 28, 2024

Copy link


Copy Markdown

MemberAuthor
@EgorBot -arm64 -profiler
usingSystem.IO.Hashing;usingBenchmarkDotNet.Attributes;publicclassBench{staticreadonlybyte[]Data=newbyte[1000000];[Benchmark]publicbyte[]BenchXxHash128(){XxHash128hash=new();hash.Append(Data);returnhash.GetHashAndReset();}}
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 28, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
tannergooding
tannergooding
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/hwintrinsicarm64.cpp
Outdated

tannergooding
tannergooding
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp

Comment on lines

+21932
 to 
+21957

 case TYP_LONG:
 case TYP_ULONG:
 {
 assert(simdSize == 16);

 // Make op1 and op2 multi-use:
 GenTree* op1Dup = fgMakeMultiUse(&op1);
 GenTree* op2Dup = fgMakeMultiUse(&op2);

 // long left0 = op1.GetElement(0)
 // long left1 = op1.GetElement(1)
 GenTree* left0 = gtNewSimdGetElementNode(TYP_LONG, op1, gtNewIconNode(0), simdBaseJitType, 16);
 GenTree* left1 = gtNewSimdGetElementNode(TYP_LONG, op1Dup, gtNewIconNode(1), simdBaseJitType, 16);

 // long right0 = op2.GetElement(0)
 // long right1 = op2.GetElement(1)
 GenTree* right0 = gtNewSimdGetElementNode(TYP_LONG, op2, gtNewIconNode(0), simdBaseJitType, 16);
 GenTree* right1 = gtNewSimdGetElementNode(TYP_LONG, op2Dup, gtNewIconNode(1), simdBaseJitType, 16);

 // Vector128<long> vec = Vector128.Create(left0 * right0, left1 * right1)
 op1 = gtNewOperNode(GT_MUL, TYP_LONG, left0, right0);
 op2 = gtNewOperNode(GT_MUL, TYP_LONG, left1, right1);
 GenTree* vec = gtNewSimdCreateScalarUnsafeNode(TYP_SIMD16, op1, simdBaseJitType, 16);
 return gtNewSimdHWIntrinsicNode(TYP_SIMD16, vec, gtNewIconNode(1), op2, NI_AdvSimd_Insert,
 simdBaseJitType, 16);
 }
@tannergoodingtannergoodingJun 28, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just avoiding the cost of inlining, unrolling, and simplifying the work the JIT would have to do?
@EgorBot
EgorBot
commented
Jun 28, 2024

Copy link


Copy Markdown

Benchmark results on Arm64
BenchmarkDotNet v0.13.12, Ubuntu 22.04.4 LTS (Jammy Jellyfish)
Unknown processor
Job-OMCIXQ : .NET 9.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD
Job-KTSNVH : .NET 9.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD

MethodToolchainMeanErrorRatio
BenchXxHash128Main116.9 μs0.05 μs1.00
BenchXxHash128PR109.8 μs0.04 μs0.94
BDN_Artifacts.zip
Flame graphs: Main vs PR 🔥

Hot asm: Main vs PR

Hot functions: Main vs PR
For clean perf results, make sure you have just one [Benchmark] in your app.
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 28, 2024

Closed

@neon-sunset
neon-sunset
commented
Jul 1, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
I wanted to ask is there a reason LLVM's codegen variant did not work? On some cores, UMOV/SMOV has pretty bad latency vs code that avoids a round-trip to scalar registers.
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 1, 2024

Closed

tannergooding
tannergooding
reviewed
Jul 1, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp
Outdated


Comment on lines

+22005
 to 
+22006

 return gtNewSimdHWIntrinsicNode(type, vec, gtNewIconNode(1), op2, NI_AdvSimd_Insert,
 simdBaseJitType, 16);
@tannergoodingtannergoodingJul 1, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Use gtNewSimdWithElementNode(type, vec, gtNewIconNode(1), op2, simdBaseJitType, simdSize) which ensures all the optimal handling takes place.
@EgorBoEgorBoJul 2, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Applied
@EgorBo
EgorBo
marked this pull request as ready for review
July 2, 2024 18:03
@EgorBo
EgorBo
merged commit 6e039a8
into
dotnet:mainJul 2, 2024
@EgorBo
EgorBo
deleted the

mul-long-arm64

branch
July 2, 2024 18:03
tannergooding
tannergooding
reviewed
Jul 2, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp

Comment on lines

+21981
 to 
+21982

 op1 = gtNewBitCastNode(TYP_LONG, op1);
 op2 = gtNewBitCastNode(TYP_LONG, op2);
@tannergoodingtannergoodingJul 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bitcast instead of ToScalar? If this is generating better code, it seems like a pretty "core" scenario we're not handling from the ToScalar path
@EgorBoEgorBoJul 2, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannergooding because op2 can be either 8-byte TYP_SIMD8 or 8-byte scalar (TYP_LONG) so bitcast allowed me to simplify handling. In my initial version I forgot that this path is used for both MUL(vector, vector) and MUL(vector, scalar) (where scalar is broadcasted)
@tannergoodingtannergoodingJul 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense, 👍
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 2, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes

Assignees

@EgorBoEgorBo

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@EgorBo@EgorBot@neon-sunset@tannergooding

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Optimize Vector128<long> multiplication for arm64 - #104177
Merged
EgorBo merged 8 commits into
dotnet:mainfrom 
EgorBo:mul-long-arm64
Jul 2, 2024
Merged
Optimize Vector128<long> multiplication for arm64#104177
EgorBo merged 8 commits into
dotnet:mainfrom 
EgorBo:mul-long-arm64
Conversation
@EgorBo
@EgorBoEgorBo
commented
Jun 28, 2024

Copy link


Copy Markdown

Member
Follow up to #103555 for arm64
@ghostghost
added
the 
area-CodeGen-coreclr
CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
label
Jun 28, 2024
@EgorBo
EgorBo
commented
Jun 28, 2024

Copy link


Copy Markdown

MemberAuthor
@EgorBot -arm64 -profiler
usingSystem.IO.Hashing;usingBenchmarkDotNet.Attributes;publicclassBench{staticreadonlybyte[]Data=newbyte[1000000];[Benchmark]publicbyte[]BenchXxHash128(){XxHash128hash=new();hash.Append(Data);returnhash.GetHashAndReset();}}
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jun 28, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch

See info in area-owners.md if you want to be subscribed.
tannergooding
tannergooding
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/hwintrinsicarm64.cpp
Outdated

tannergooding
tannergooding
reviewed
Jun 28, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp

Comment on lines

+21932
 to 
+21957

 case TYP_LONG:
 case TYP_ULONG:
 {
 assert(simdSize == 16);

 // Make op1 and op2 multi-use:
 GenTree* op1Dup = fgMakeMultiUse(&op1);
 GenTree* op2Dup = fgMakeMultiUse(&op2);

 // long left0 = op1.GetElement(0)
 // long left1 = op1.GetElement(1)
 GenTree* left0 = gtNewSimdGetElementNode(TYP_LONG, op1, gtNewIconNode(0), simdBaseJitType, 16);
 GenTree* left1 = gtNewSimdGetElementNode(TYP_LONG, op1Dup, gtNewIconNode(1), simdBaseJitType, 16);

 // long right0 = op2.GetElement(0)
 // long right1 = op2.GetElement(1)
 GenTree* right0 = gtNewSimdGetElementNode(TYP_LONG, op2, gtNewIconNode(0), simdBaseJitType, 16);
 GenTree* right1 = gtNewSimdGetElementNode(TYP_LONG, op2Dup, gtNewIconNode(1), simdBaseJitType, 16);

 // Vector128<long> vec = Vector128.Create(left0 * right0, left1 * right1)
 op1 = gtNewOperNode(GT_MUL, TYP_LONG, left0, right0);
 op2 = gtNewOperNode(GT_MUL, TYP_LONG, left1, right1);
 GenTree* vec = gtNewSimdCreateScalarUnsafeNode(TYP_SIMD16, op1, simdBaseJitType, 16);
 return gtNewSimdHWIntrinsicNode(TYP_SIMD16, vec, gtNewIconNode(1), op2, NI_AdvSimd_Insert,
 simdBaseJitType, 16);
 }
@tannergoodingtannergoodingJun 28, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just avoiding the cost of inlining, unrolling, and simplifying the work the JIT would have to do?
@EgorBot
EgorBot
commented
Jun 28, 2024

Copy link


Copy Markdown

Benchmark results on Arm64
BenchmarkDotNet v0.13.12, Ubuntu 22.04.4 LTS (Jammy Jellyfish)
Unknown processor
Job-OMCIXQ : .NET 9.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD
Job-KTSNVH : .NET 9.0.0 (42.42.42.42424), Arm64 RyuJIT AdvSIMD

MethodToolchainMeanErrorRatio
BenchXxHash128Main116.9 μs0.05 μs1.00
BenchXxHash128PR109.8 μs0.04 μs0.94
BDN_Artifacts.zip
Flame graphs: Main vs PR 🔥

Hot asm: Main vs PR

Hot functions: Main vs PR
For clean perf results, make sure you have just one [Benchmark] in your app.
@build-analysisbuild-analysisBot
mentioned this pull request
Jun 28, 2024

Closed

@neon-sunset
neon-sunset
commented
Jul 1, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
I wanted to ask is there a reason LLVM's codegen variant did not work? On some cores, UMOV/SMOV has pretty bad latency vs code that avoids a round-trip to scalar registers.
@build-analysisbuild-analysisBot
mentioned this pull request
Jul 1, 2024

Closed

tannergooding
tannergooding
reviewed
Jul 1, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp
Outdated


Comment on lines

+22005
 to 
+22006

 return gtNewSimdHWIntrinsicNode(type, vec, gtNewIconNode(1), op2, NI_AdvSimd_Insert,
 simdBaseJitType, 16);
@tannergoodingtannergoodingJul 1, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Use gtNewSimdWithElementNode(type, vec, gtNewIconNode(1), op2, simdBaseJitType, simdSize) which ensures all the optimal handling takes place.
@EgorBoEgorBoJul 2, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Applied
@EgorBo
EgorBo
marked this pull request as ready for review
July 2, 2024 18:03
@EgorBo
EgorBo
merged commit 6e039a8
into
dotnet:mainJul 2, 2024
@EgorBo
EgorBo
deleted the

mul-long-arm64

branch
July 2, 2024 18:03
tannergooding
tannergooding
reviewed
Jul 2, 2024
View reviewed changes
Comment threadsrc/coreclr/jit/gentree.cpp

Comment on lines

+21981
 to 
+21982

 op1 = gtNewBitCastNode(TYP_LONG, op1);
 op2 = gtNewBitCastNode(TYP_LONG, op2);
@tannergoodingtannergoodingJul 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bitcast instead of ToScalar? If this is generating better code, it seems like a pretty "core" scenario we're not handling from the ToScalar path
@EgorBoEgorBoJul 2, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannergooding because op2 can be either 8-byte TYP_SIMD8 or 8-byte scalar (TYP_LONG) so bitcast allowed me to simplify handling. In my initial version I forgot that this path is used for both MUL(vector, vector) and MUL(vector, scalar) (where scalar is broadcasted)
@tannergoodingtannergoodingJul 2, 2024

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes sense, 👍
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 2, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@tannergoodingtannergoodingtannergooding approved these changes

Assignees

@EgorBoEgorBo

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@EgorBo@EgorBot@neon-sunset@tannergooding