Skip to content

Implement IAlternateEqualityComparer<ReadOnlySpan<char>, string> on EqualityComparer<string>.Default - #104202

Merged
stephentoub merged 5 commits into
dotnet:mainfrom
stephentoub:equalitycomparerdefaultalternate
Jul 2, 2024
Merged

Implement IAlternateEqualityComparer<ReadOnlySpan<char>, string> on EqualityComparer<string>.Default#104202
stephentoub merged 5 commits into
dotnet:mainfrom
stephentoub:equalitycomparerdefaultalternate

Conversation

@stephentoub

@stephentoubstephentoub commented Jun 30, 2024

Copy link
Copy Markdown
Member

Fixes#102906

@ghostghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 30, 2024
@stephentoub
stephentoubforce-pushed the equalitycomparerdefaultalternate branch 2 times, most recently from 69a192b to b627e2cCompareJune 30, 2024 03:32
jkotas
jkotas reviewed Jun 30, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Collections/Generic/EqualityComparer.cs Outdated
@build-analysisbuild-analysisBot mentioned this pull request Jun 30, 2024
Closed
MichalPetryka
MichalPetryka reviewed Jun 30, 2024
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Collections/Generic/EqualityComparer.cs Outdated
Comment threadsrc/coreclr/vm/jitinterface.cpp
jkotas
jkotas reviewed Jun 30, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/jitinterface.cpp
jkotas
jkotas reviewed Jun 30, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/jitinterface.cpp Outdated
@stephentoub
stephentoubforce-pushed the equalitycomparerdefaultalternate branch from 894ce80 to a6e4488CompareJuly 1, 2024 02:49
@jkotasjkotas added area-System.Collections and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 1, 2024
This was referenced Jul 1, 2024
Open
Open
Closed
@stephentoub
stephentoub marked this pull request as ready for review July 1, 2024 13:56
@stephentoub
stephentoubforce-pushed the equalitycomparerdefaultalternate branch from 5b1ec8f to d13131eCompareJuly 1, 2024 13:56
eiriktsarpalis
eiriktsarpalis reviewed Jul 1, 2024
View reviewed changes

@eiriktsarpaliseiriktsarpalis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing lots of build errors, but they appear to be infra related?

@build-analysisbuild-analysisBot mentioned this pull request Jul 1, 2024
Open
@stephentoubstephentoub mentioned this pull request Jul 1, 2024
Merged
tannergooding
tannergooding approved these changes Jul 1, 2024
View reviewed changes

@tannergoodingtannergooding left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Managed side changes LGTM.

@stephentoubstephentoub reopened this Jul 1, 2024
@build-analysisbuild-analysisBot mentioned this pull request Jul 1, 2024
Closed
@jkotas

jkotas commented Jul 1, 2024

Copy link
Copy Markdown
Member

/azp run runtime-nativeaot-outerloop

@azure-pipelines

azure-pipelinesBot commented Jul 1, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

jkotas
jkotas approved these changes Jul 1, 2024
View reviewed changes

@jkotasjkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (once the naot test run passed with no failures related to this change)

@build-analysisbuild-analysisBot mentioned this pull request Jul 1, 2024
Closed
@jkotasjkotas mentioned this pull request Jul 1, 2024
Closed
@stephentoubstephentoub mentioned this pull request Jul 2, 2024
Open
@stephentoub
stephentoub merged commit aa280ad into dotnet:mainJul 2, 2024
@stephentoub
stephentoub deleted the equalitycomparerdefaultalternate branch July 2, 2024 01:39
@jkotasjkotas mentioned this pull request Jul 3, 2024
Closed
@matouskozakmatouskozak mentioned this pull request Jul 9, 2024
Closed
@LoopedBard3

LoopedBard3 commented Jul 9, 2024

Copy link
Copy Markdown
Member

Improvements:
Linux x64: dotnet/perf-autofiling-issues#37870
Windows x64: dotnet/perf-autofiling-issues#37858, dotnet/perf-autofiling-issues#37822

@lewinglewing mentioned this pull request Jul 9, 2024
Open
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 9, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eiriktsarpaliseiriktsarpaliseiriktsarpalis approved these changes
@jkotasjkotasjkotas approved these changes
@tannergoodingtannergoodingtannergooding approved these changes
@marek-safarmarek-safarAwaiting requested review from marek-safar
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner
+1 more reviewer
@MichalPetrykaMichalPetrykaMichalPetryka left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@stephentoubstephentoub

Labels

area-System.Collections

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement IAlternateEqualityComparer<ReadOnlySpan<char>, string> on EqualityComparer<string>.Default

6 participants

@stephentoub@jkotas@LoopedBard3@eiriktsarpalis@tannergooding@MichalPetryka