Update mono-interp to handle the same Vector.As APIs as mono-jit by tannergooding · Pull Request #104217 · dotnet/runtime

tannergooding · 2024-07-01T01:02:17Z

This is a simplified version of #104049, trying to handle the smaller set of existing scenarios to start.

dotnet-policy-service · 2024-07-01T01:02:50Z

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

tannergooding · 2024-07-01T03:43:33Z

CC. @kg this should be ready for review

kg · 2024-07-01T03:55:44Z

lgtm, but i'd feel better if vlad or milos also looked at it. if the regressions this is fixing don't go away, i can update the jiterpreter.

tannergooding · 2024-07-01T04:04:57Z

if the regressions this is fixing don't go away, i can update the jiterpreter.

Sounds good! This should help some, but there's some others that still need to be handled as well. I was having troubles handling them all at once in #104049, so I decided to break it apart into smaller chunks instead starting with this one.

I'm going to get AsVector, AsQuaternion, AsPlane, AsVector4, and AsVector128(Vector4) next since those are also same size bitcasts and should be straightforward. Then that will leave AsVector128(Vector2), AsVector128(Vector3), and AsVector128Unsafe after that as the ones that change sizes and I believe were the ones causing the most issues in my previous attempt.

-- Could you give a brief explanation on the difference between the handling here and that in the jiterpreter? Does the logic not get shared between them for the SIMD acceleration?

kg · 2024-07-01T04:26:47Z

if the regressions this is fixing don't go away, i can update the jiterpreter.
Sounds good! This should help some, but there's some others that still need to be handled as well. I was having troubles handling them all at once in #104049, so I decided to break it apart into smaller chunks instead starting with this one.
I'm going to get AsVector, AsQuaternion, AsPlane, AsVector4, and AsVector128(Vector4) next since those are also same size bitcasts and should be straightforward. Then that will leave AsVector128(Vector2), AsVector128(Vector3), and AsVector128Unsafe after that as the ones that change sizes and I believe were the ones causing the most issues in my previous attempt.
-- Could you give a brief explanation on the difference between the handling here and that in the jiterpreter? Does the logic not get shared between them for the SIMD acceleration?

The jiterpreter has a generic path for interpreter SIMD opcodes that dispatches directly to the C helper, but with a wasm opcode mapping or dedicated implementation (i think this would need the latter), it can generate native jitcode directly. For this bitcast I think we'd just emit a single vector memory move.

tannergooding · 2024-07-01T18:33:14Z

@BrzVlad, @kotlarmilos, this should be ready for review

kotlarmilos

LGTM! @BrzVlad Please sign-off before merge.

kotlarmilos · 2024-07-02T06:44:00Z

+
+	g_assert (vector_type->type == MONO_TYPE_GENERICINST);
+	klass = mono_class_from_mono_type_internal (vector_type);
+	g_assert (


Should we also check the namespace?

We aren't doing so in simd-intrinsics.c, notably, but we could if desired.
I believe the expectation is that we're already only hitting this path for System.Runtime.Intrinsics or System.Numerics due to the higher level functions that can dispatch to these code paths.

tannergooding · 2024-07-02T16:59:50Z

Failure is the general timeout for this leg that is already tracked.

tannergooding · 2024-07-01T01:02:17Z

This is a simplified version of #104049, trying to handle the smaller set of existing scenarios to start.

dotnet-policy-service · 2024-07-01T01:02:50Z

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

tannergooding · 2024-07-01T03:43:33Z

CC. @kg this should be ready for review

kg · 2024-07-01T03:55:44Z

lgtm, but i'd feel better if vlad or milos also looked at it. if the regressions this is fixing don't go away, i can update the jiterpreter.

tannergooding · 2024-07-01T04:04:57Z

if the regressions this is fixing don't go away, i can update the jiterpreter.

Sounds good! This should help some, but there's some others that still need to be handled as well. I was having troubles handling them all at once in #104049, so I decided to break it apart into smaller chunks instead starting with this one.

I'm going to get AsVector, AsQuaternion, AsPlane, AsVector4, and AsVector128(Vector4) next since those are also same size bitcasts and should be straightforward. Then that will leave AsVector128(Vector2), AsVector128(Vector3), and AsVector128Unsafe after that as the ones that change sizes and I believe were the ones causing the most issues in my previous attempt.

-- Could you give a brief explanation on the difference between the handling here and that in the jiterpreter? Does the logic not get shared between them for the SIMD acceleration?

kg · 2024-07-01T04:26:47Z

if the regressions this is fixing don't go away, i can update the jiterpreter.
Sounds good! This should help some, but there's some others that still need to be handled as well. I was having troubles handling them all at once in #104049, so I decided to break it apart into smaller chunks instead starting with this one.
I'm going to get AsVector, AsQuaternion, AsPlane, AsVector4, and AsVector128(Vector4) next since those are also same size bitcasts and should be straightforward. Then that will leave AsVector128(Vector2), AsVector128(Vector3), and AsVector128Unsafe after that as the ones that change sizes and I believe were the ones causing the most issues in my previous attempt.
-- Could you give a brief explanation on the difference between the handling here and that in the jiterpreter? Does the logic not get shared between them for the SIMD acceleration?

The jiterpreter has a generic path for interpreter SIMD opcodes that dispatches directly to the C helper, but with a wasm opcode mapping or dedicated implementation (i think this would need the latter), it can generate native jitcode directly. For this bitcast I think we'd just emit a single vector memory move.

tannergooding · 2024-07-01T18:33:14Z

@BrzVlad, @kotlarmilos, this should be ready for review

kotlarmilos

LGTM! @BrzVlad Please sign-off before merge.

kotlarmilos · 2024-07-02T06:44:00Z

+
+	g_assert (vector_type->type == MONO_TYPE_GENERICINST);
+	klass = mono_class_from_mono_type_internal (vector_type);
+	g_assert (


Should we also check the namespace?

We aren't doing so in simd-intrinsics.c, notably, but we could if desired.
I believe the expectation is that we're already only hitting this path for System.Runtime.Intrinsics or System.Numerics due to the higher level functions that can dispatch to these code paths.

tannergooding · 2024-07-02T16:59:50Z

Failure is the general timeout for this leg that is already tracked.

tannergooding · 2024-07-01T01:02:17Z

This is a simplified version of #104049, trying to handle the smaller set of existing scenarios to start.

dotnet-policy-service · 2024-07-01T01:02:50Z

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

tannergooding · 2024-07-01T03:43:33Z

CC. @kg this should be ready for review

kg · 2024-07-01T03:55:44Z

lgtm, but i'd feel better if vlad or milos also looked at it. if the regressions this is fixing don't go away, i can update the jiterpreter.

tannergooding · 2024-07-01T04:04:57Z

if the regressions this is fixing don't go away, i can update the jiterpreter.

Sounds good! This should help some, but there's some others that still need to be handled as well. I was having troubles handling them all at once in #104049, so I decided to break it apart into smaller chunks instead starting with this one.

I'm going to get AsVector, AsQuaternion, AsPlane, AsVector4, and AsVector128(Vector4) next since those are also same size bitcasts and should be straightforward. Then that will leave AsVector128(Vector2), AsVector128(Vector3), and AsVector128Unsafe after that as the ones that change sizes and I believe were the ones causing the most issues in my previous attempt.

-- Could you give a brief explanation on the difference between the handling here and that in the jiterpreter? Does the logic not get shared between them for the SIMD acceleration?

kg · 2024-07-01T04:26:47Z

if the regressions this is fixing don't go away, i can update the jiterpreter.
Sounds good! This should help some, but there's some others that still need to be handled as well. I was having troubles handling them all at once in #104049, so I decided to break it apart into smaller chunks instead starting with this one.
I'm going to get AsVector, AsQuaternion, AsPlane, AsVector4, and AsVector128(Vector4) next since those are also same size bitcasts and should be straightforward. Then that will leave AsVector128(Vector2), AsVector128(Vector3), and AsVector128Unsafe after that as the ones that change sizes and I believe were the ones causing the most issues in my previous attempt.
-- Could you give a brief explanation on the difference between the handling here and that in the jiterpreter? Does the logic not get shared between them for the SIMD acceleration?

The jiterpreter has a generic path for interpreter SIMD opcodes that dispatches directly to the C helper, but with a wasm opcode mapping or dedicated implementation (i think this would need the latter), it can generate native jitcode directly. For this bitcast I think we'd just emit a single vector memory move.

tannergooding · 2024-07-01T18:33:14Z

@BrzVlad, @kotlarmilos, this should be ready for review

kotlarmilos

LGTM! @BrzVlad Please sign-off before merge.

kotlarmilos · 2024-07-02T06:44:00Z

+
+	g_assert (vector_type->type == MONO_TYPE_GENERICINST);
+	klass = mono_class_from_mono_type_internal (vector_type);
+	g_assert (


Should we also check the namespace?

We aren't doing so in simd-intrinsics.c, notably, but we could if desired.
I believe the expectation is that we're already only hitting this path for System.Runtime.Intrinsics or System.Numerics due to the higher level functions that can dispatch to these code paths.

tannergooding · 2024-07-02T16:59:50Z

Failure is the general timeout for this leg that is already tracked.

tannergooding · 2024-07-01T01:02:17Z

This is a simplified version of #104049, trying to handle the smaller set of existing scenarios to start.

dotnet-policy-service · 2024-07-01T01:02:50Z

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

tannergooding · 2024-07-01T03:43:33Z

CC. @kg this should be ready for review

kg · 2024-07-01T03:55:44Z

lgtm, but i'd feel better if vlad or milos also looked at it. if the regressions this is fixing don't go away, i can update the jiterpreter.

tannergooding · 2024-07-01T04:04:57Z

if the regressions this is fixing don't go away, i can update the jiterpreter.

Sounds good! This should help some, but there's some others that still need to be handled as well. I was having troubles handling them all at once in #104049, so I decided to break it apart into smaller chunks instead starting with this one.

I'm going to get AsVector, AsQuaternion, AsPlane, AsVector4, and AsVector128(Vector4) next since those are also same size bitcasts and should be straightforward. Then that will leave AsVector128(Vector2), AsVector128(Vector3), and AsVector128Unsafe after that as the ones that change sizes and I believe were the ones causing the most issues in my previous attempt.

-- Could you give a brief explanation on the difference between the handling here and that in the jiterpreter? Does the logic not get shared between them for the SIMD acceleration?

kg · 2024-07-01T04:26:47Z

if the regressions this is fixing don't go away, i can update the jiterpreter.
Sounds good! This should help some, but there's some others that still need to be handled as well. I was having troubles handling them all at once in #104049, so I decided to break it apart into smaller chunks instead starting with this one.
I'm going to get AsVector, AsQuaternion, AsPlane, AsVector4, and AsVector128(Vector4) next since those are also same size bitcasts and should be straightforward. Then that will leave AsVector128(Vector2), AsVector128(Vector3), and AsVector128Unsafe after that as the ones that change sizes and I believe were the ones causing the most issues in my previous attempt.
-- Could you give a brief explanation on the difference between the handling here and that in the jiterpreter? Does the logic not get shared between them for the SIMD acceleration?

The jiterpreter has a generic path for interpreter SIMD opcodes that dispatches directly to the C helper, but with a wasm opcode mapping or dedicated implementation (i think this would need the latter), it can generate native jitcode directly. For this bitcast I think we'd just emit a single vector memory move.

tannergooding · 2024-07-01T18:33:14Z

@BrzVlad, @kotlarmilos, this should be ready for review

kotlarmilos

LGTM! @BrzVlad Please sign-off before merge.

kotlarmilos · 2024-07-02T06:44:00Z

+
+	g_assert (vector_type->type == MONO_TYPE_GENERICINST);
+	klass = mono_class_from_mono_type_internal (vector_type);
+	g_assert (


Should we also check the namespace?

We aren't doing so in simd-intrinsics.c, notably, but we could if desired.
I believe the expectation is that we're already only hitting this path for System.Runtime.Intrinsics or System.Numerics due to the higher level functions that can dispatch to these code paths.

tannergooding · 2024-07-02T16:59:50Z

Failure is the general timeout for this leg that is already tracked.

tannergooding · 2024-07-01T01:02:17Z

This is a simplified version of #104049, trying to handle the smaller set of existing scenarios to start.

dotnet-policy-service · 2024-07-01T01:02:50Z

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

tannergooding · 2024-07-01T03:43:33Z

CC. @kg this should be ready for review

kg · 2024-07-01T03:55:44Z

lgtm, but i'd feel better if vlad or milos also looked at it. if the regressions this is fixing don't go away, i can update the jiterpreter.

tannergooding · 2024-07-01T04:04:57Z

if the regressions this is fixing don't go away, i can update the jiterpreter.

Sounds good! This should help some, but there's some others that still need to be handled as well. I was having troubles handling them all at once in #104049, so I decided to break it apart into smaller chunks instead starting with this one.

I'm going to get AsVector, AsQuaternion, AsPlane, AsVector4, and AsVector128(Vector4) next since those are also same size bitcasts and should be straightforward. Then that will leave AsVector128(Vector2), AsVector128(Vector3), and AsVector128Unsafe after that as the ones that change sizes and I believe were the ones causing the most issues in my previous attempt.

-- Could you give a brief explanation on the difference between the handling here and that in the jiterpreter? Does the logic not get shared between them for the SIMD acceleration?

kg · 2024-07-01T04:26:47Z

if the regressions this is fixing don't go away, i can update the jiterpreter.
Sounds good! This should help some, but there's some others that still need to be handled as well. I was having troubles handling them all at once in #104049, so I decided to break it apart into smaller chunks instead starting with this one.
I'm going to get AsVector, AsQuaternion, AsPlane, AsVector4, and AsVector128(Vector4) next since those are also same size bitcasts and should be straightforward. Then that will leave AsVector128(Vector2), AsVector128(Vector3), and AsVector128Unsafe after that as the ones that change sizes and I believe were the ones causing the most issues in my previous attempt.
-- Could you give a brief explanation on the difference between the handling here and that in the jiterpreter? Does the logic not get shared between them for the SIMD acceleration?

The jiterpreter has a generic path for interpreter SIMD opcodes that dispatches directly to the C helper, but with a wasm opcode mapping or dedicated implementation (i think this would need the latter), it can generate native jitcode directly. For this bitcast I think we'd just emit a single vector memory move.

tannergooding · 2024-07-01T18:33:14Z

@BrzVlad, @kotlarmilos, this should be ready for review

kotlarmilos

LGTM! @BrzVlad Please sign-off before merge.

kotlarmilos · 2024-07-02T06:44:00Z

+
+	g_assert (vector_type->type == MONO_TYPE_GENERICINST);
+	klass = mono_class_from_mono_type_internal (vector_type);
+	g_assert (


Should we also check the namespace?

We aren't doing so in simd-intrinsics.c, notably, but we could if desired.
I believe the expectation is that we're already only hitting this path for System.Runtime.Intrinsics or System.Numerics due to the higher level functions that can dispatch to these code paths.

tannergooding · 2024-07-02T16:59:50Z

Failure is the general timeout for this leg that is already tracked.

tannergooding · 2024-07-01T01:02:17Z

This is a simplified version of #104049, trying to handle the smaller set of existing scenarios to start.

dotnet-policy-service · 2024-07-01T01:02:50Z

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

tannergooding · 2024-07-01T03:43:33Z

CC. @kg this should be ready for review

kg · 2024-07-01T03:55:44Z

lgtm, but i'd feel better if vlad or milos also looked at it. if the regressions this is fixing don't go away, i can update the jiterpreter.

tannergooding · 2024-07-01T04:04:57Z

if the regressions this is fixing don't go away, i can update the jiterpreter.

Sounds good! This should help some, but there's some others that still need to be handled as well. I was having troubles handling them all at once in #104049, so I decided to break it apart into smaller chunks instead starting with this one.

I'm going to get AsVector, AsQuaternion, AsPlane, AsVector4, and AsVector128(Vector4) next since those are also same size bitcasts and should be straightforward. Then that will leave AsVector128(Vector2), AsVector128(Vector3), and AsVector128Unsafe after that as the ones that change sizes and I believe were the ones causing the most issues in my previous attempt.

-- Could you give a brief explanation on the difference between the handling here and that in the jiterpreter? Does the logic not get shared between them for the SIMD acceleration?

kg · 2024-07-01T04:26:47Z

if the regressions this is fixing don't go away, i can update the jiterpreter.
Sounds good! This should help some, but there's some others that still need to be handled as well. I was having troubles handling them all at once in #104049, so I decided to break it apart into smaller chunks instead starting with this one.
I'm going to get AsVector, AsQuaternion, AsPlane, AsVector4, and AsVector128(Vector4) next since those are also same size bitcasts and should be straightforward. Then that will leave AsVector128(Vector2), AsVector128(Vector3), and AsVector128Unsafe after that as the ones that change sizes and I believe were the ones causing the most issues in my previous attempt.
-- Could you give a brief explanation on the difference between the handling here and that in the jiterpreter? Does the logic not get shared between them for the SIMD acceleration?

The jiterpreter has a generic path for interpreter SIMD opcodes that dispatches directly to the C helper, but with a wasm opcode mapping or dedicated implementation (i think this would need the latter), it can generate native jitcode directly. For this bitcast I think we'd just emit a single vector memory move.

tannergooding · 2024-07-01T18:33:14Z

@BrzVlad, @kotlarmilos, this should be ready for review

kotlarmilos

LGTM! @BrzVlad Please sign-off before merge.

kotlarmilos · 2024-07-02T06:44:00Z

+
+	g_assert (vector_type->type == MONO_TYPE_GENERICINST);
+	klass = mono_class_from_mono_type_internal (vector_type);
+	g_assert (


Should we also check the namespace?

We aren't doing so in simd-intrinsics.c, notably, but we could if desired.
I believe the expectation is that we're already only hitting this path for System.Runtime.Intrinsics or System.Numerics due to the higher level functions that can dispatch to these code paths.

tannergooding · 2024-07-02T16:59:50Z

Failure is the general timeout for this leg that is already tracked.

tannergooding · 2024-07-01T01:02:17Z

This is a simplified version of #104049, trying to handle the smaller set of existing scenarios to start.

dotnet-policy-service · 2024-07-01T01:02:50Z

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

tannergooding · 2024-07-01T03:43:33Z

CC. @kg this should be ready for review

kg · 2024-07-01T03:55:44Z

lgtm, but i'd feel better if vlad or milos also looked at it. if the regressions this is fixing don't go away, i can update the jiterpreter.

tannergooding · 2024-07-01T04:04:57Z

if the regressions this is fixing don't go away, i can update the jiterpreter.

Sounds good! This should help some, but there's some others that still need to be handled as well. I was having troubles handling them all at once in #104049, so I decided to break it apart into smaller chunks instead starting with this one.

I'm going to get AsVector, AsQuaternion, AsPlane, AsVector4, and AsVector128(Vector4) next since those are also same size bitcasts and should be straightforward. Then that will leave AsVector128(Vector2), AsVector128(Vector3), and AsVector128Unsafe after that as the ones that change sizes and I believe were the ones causing the most issues in my previous attempt.

-- Could you give a brief explanation on the difference between the handling here and that in the jiterpreter? Does the logic not get shared between them for the SIMD acceleration?

kg · 2024-07-01T04:26:47Z

if the regressions this is fixing don't go away, i can update the jiterpreter.
Sounds good! This should help some, but there's some others that still need to be handled as well. I was having troubles handling them all at once in #104049, so I decided to break it apart into smaller chunks instead starting with this one.
I'm going to get AsVector, AsQuaternion, AsPlane, AsVector4, and AsVector128(Vector4) next since those are also same size bitcasts and should be straightforward. Then that will leave AsVector128(Vector2), AsVector128(Vector3), and AsVector128Unsafe after that as the ones that change sizes and I believe were the ones causing the most issues in my previous attempt.
-- Could you give a brief explanation on the difference between the handling here and that in the jiterpreter? Does the logic not get shared between them for the SIMD acceleration?

The jiterpreter has a generic path for interpreter SIMD opcodes that dispatches directly to the C helper, but with a wasm opcode mapping or dedicated implementation (i think this would need the latter), it can generate native jitcode directly. For this bitcast I think we'd just emit a single vector memory move.

tannergooding · 2024-07-01T18:33:14Z

@BrzVlad, @kotlarmilos, this should be ready for review

kotlarmilos

LGTM! @BrzVlad Please sign-off before merge.

kotlarmilos · 2024-07-02T06:44:00Z

+
+	g_assert (vector_type->type == MONO_TYPE_GENERICINST);
+	klass = mono_class_from_mono_type_internal (vector_type);
+	g_assert (


Should we also check the namespace?

We aren't doing so in simd-intrinsics.c, notably, but we could if desired.
I believe the expectation is that we're already only hitting this path for System.Runtime.Intrinsics or System.Numerics due to the higher level functions that can dispatch to these code paths.

tannergooding · 2024-07-02T16:59:50Z

Failure is the general timeout for this leg that is already tracked.

tannergooding · 2024-07-01T01:02:17Z

This is a simplified version of #104049, trying to handle the smaller set of existing scenarios to start.

dotnet-policy-service · 2024-07-01T01:02:50Z

Tagging subscribers to this area: @BrzVlad, @kotlarmilos
See info in area-owners.md if you want to be subscribed.

tannergooding · 2024-07-01T03:43:33Z

CC. @kg this should be ready for review

kg · 2024-07-01T03:55:44Z

lgtm, but i'd feel better if vlad or milos also looked at it. if the regressions this is fixing don't go away, i can update the jiterpreter.

tannergooding · 2024-07-01T04:04:57Z

if the regressions this is fixing don't go away, i can update the jiterpreter.

Sounds good! This should help some, but there's some others that still need to be handled as well. I was having troubles handling them all at once in #104049, so I decided to break it apart into smaller chunks instead starting with this one.

I'm going to get AsVector, AsQuaternion, AsPlane, AsVector4, and AsVector128(Vector4) next since those are also same size bitcasts and should be straightforward. Then that will leave AsVector128(Vector2), AsVector128(Vector3), and AsVector128Unsafe after that as the ones that change sizes and I believe were the ones causing the most issues in my previous attempt.

-- Could you give a brief explanation on the difference between the handling here and that in the jiterpreter? Does the logic not get shared between them for the SIMD acceleration?

kg · 2024-07-01T04:26:47Z

if the regressions this is fixing don't go away, i can update the jiterpreter.
Sounds good! This should help some, but there's some others that still need to be handled as well. I was having troubles handling them all at once in #104049, so I decided to break it apart into smaller chunks instead starting with this one.
I'm going to get AsVector, AsQuaternion, AsPlane, AsVector4, and AsVector128(Vector4) next since those are also same size bitcasts and should be straightforward. Then that will leave AsVector128(Vector2), AsVector128(Vector3), and AsVector128Unsafe after that as the ones that change sizes and I believe were the ones causing the most issues in my previous attempt.
-- Could you give a brief explanation on the difference between the handling here and that in the jiterpreter? Does the logic not get shared between them for the SIMD acceleration?

The jiterpreter has a generic path for interpreter SIMD opcodes that dispatches directly to the C helper, but with a wasm opcode mapping or dedicated implementation (i think this would need the latter), it can generate native jitcode directly. For this bitcast I think we'd just emit a single vector memory move.

tannergooding · 2024-07-01T18:33:14Z

@BrzVlad, @kotlarmilos, this should be ready for review

kotlarmilos

LGTM! @BrzVlad Please sign-off before merge.

kotlarmilos · 2024-07-02T06:44:00Z

+
+	g_assert (vector_type->type == MONO_TYPE_GENERICINST);
+	klass = mono_class_from_mono_type_internal (vector_type);
+	g_assert (


Should we also check the namespace?

We aren't doing so in simd-intrinsics.c, notably, but we could if desired.
I believe the expectation is that we're already only hitting this path for System.Runtime.Intrinsics or System.Numerics due to the higher level functions that can dispatch to these code paths.

tannergooding · 2024-07-02T16:59:50Z

Failure is the general timeout for this leg that is already tracked.

Update mono-interp to handle the same Vector.As APIs as mono-jit
3a1c476

ghost added the area-Codegen-Interpreter-mono label Jul 1, 2024

dotnet-policy-serviceBot assigned tannergooding Jul 1, 2024

tannergooding marked this pull request as ready for review July 1, 2024 03:43

tannergooding requested review from BrzVlad, fanyang-mono and kotlarmilos as code owners July 1, 2024 03:43

build-analysisBot mentioned this pull request Jul 1, 2024
[browser] test failure: Tests timed out. Killing driver service #103524
Open

kotlarmilos approved these changes Jul 2, 2024
View reviewed changes

BrzVlad approved these changes Jul 2, 2024
View reviewed changes

build-analysisBot mentioned this pull request Jul 2, 2024
[wasm][mt] fail: System.TypeLoadException: Could not load type of field" #102615
Open

fanyang-mono approved these changes Jul 2, 2024
View reviewed changes

tannergooding merged commit c65d921 into dotnet:mainJul 2, 2024

tannergooding deleted the mono-vectoras-interp branch July 2, 2024 16:59

This was referenced Jul 2, 2024
[browser] System.Buffers.ArrayPool.Tests.ArrayPoolUnitTests fails with out of memory #101436
Closed
System.Buffers.Tests timeout on wasm MT #102040
Open

radekdoulik mentioned this pull request Jul 10, 2024
[wasm][perf] Tracking #96444
Open

github-actionsBot locked and limited conversation to collaborators Aug 2, 2024