') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Delete FEATURE_READYTORUN_COMPILER ifdef by MichalStrehovsky · Pull Request #104727 · dotnet/runtime · GitHub
Skip to content

Delete FEATURE_READYTORUN_COMPILER ifdef - #104727

Merged
MichalStrehovsky merged 2 commits into
mainfrom
MichalStrehovsky-patch-3
Jul 12, 2024
Merged

Delete FEATURE_READYTORUN_COMPILER ifdef#104727
MichalStrehovsky merged 2 commits into
mainfrom
MichalStrehovsky-patch-3

Conversation

@MichalStrehovsky

@MichalStrehovskyMichalStrehovsky commented Jul 11, 2024

Copy link
Copy Markdown
Member

#103361 resurrected this long-deleted ifdef (it's crossgen1-specific define).

I actually wonder if we should roll back all changes to getHeapClassSize - @EgorBo's #104411 doesn't fix getHeapClassSize to work with valuetypes and we don't have any failing tests, so maybe it doesn't need to handle valuetypes?

@MichalStrehovsky
Delete FEATURE_READYTORUN_COMPILER ifdef
b9e6cc0
#103361 resurrected this long-deleted ifdef (crossgen1-specific code).
@ghostghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 11, 2024
@dotnet-policy-service

dotnet-policy-serviceBot commented Jul 11, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

This was referenced Jul 11, 2024
Open
Closed
@AndyAyersMS

AndyAyersMS commented Jul 11, 2024

Copy link
Copy Markdown
Member

I actually wonder if we should roll back all changes to getHeapClassSize - @EgorBo's #104411 doesn't fix getHeapClassSize to work with valuetypes and we don't have any failing tests, so maybe it doesn't need to handle valuetypes?

I think we could, yes, since we're mapping boxed value types to the internal box ref class.

@MichalStrehovsky

MichalStrehovsky commented Jul 11, 2024

Copy link
Copy Markdown
MemberAuthor

I think we could, yes, since we're mapping boxed value types to the internal box ref class.

I've done that so that we don't need to synchronize this to the managed impl.

@MichalStrehovsky
MichalStrehovsky merged commit c09ec65 into mainJul 12, 2024
@MichalStrehovsky
MichalStrehovsky deleted the MichalStrehovsky-patch-3 branch July 12, 2024 07:37
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 11, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndyAyersMSAndyAyersMSAndyAyersMS approved these changes

Assignees

@MichalStrehovskyMichalStrehovsky

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MichalStrehovsky@AndyAyersMS