Cleanup some code under FEATURE_STUBS_AS_IL by huoyaoyuan · Pull Request #104731 · dotnet/runtime

huoyaoyuan · 2024-07-11T13:48:19Z

There's no actually no IL stubs under this feature switch now, only asm stubs.

This PR addresses the simple cases. On all platforms except Windows x86, single cast delegate is written in invariant assembly code.

Remaining code under the feature switch is COM call stub, which is more complicated and is better separated out.

jkotas · 2024-07-17T14:49:15Z

Code quality

If this helps with code quality, could you please make the same change in

runtime/src/coreclr/tools/Common/TypeSystem/IL/Stubs/DelegateMethodILEmitter.cs

Lines 59 to 60 in 3f607bd

codeStream.EmitLdArg(0);
codeStream.Emit(ILOpcode.ldfld,emit.NewToken(functionPointerField.InstantiateAsOpen()));

as well? It is naot equivalent of this stub.

huoyaoyuan · 2024-07-17T15:53:50Z

The same tests in DI are still failing. Can it be related to the signature instantiation in ILC?

runtime/src/coreclr/tools/Common/TypeSystem/IL/Stubs/DelegateMethodILEmitter.cs

Lines 63 to 81 in 3f607bd

if(method.OwningType.HasInstantiation)
{
// If the owning type is generic, the signature will contain T's and U's.
// We need !0's and !1's.
TypeDesc[]typesToReplace=newTypeDesc[method.OwningType.Instantiation.Length];
TypeDesc[]replacementTypes=newTypeDesc[typesToReplace.Length];
for(inti=0;i<typesToReplace.Length;i++)
{
typesToReplace[i]=method.OwningType.Instantiation[i];
replacementTypes[i]=context.GetSignatureVariable(i,method:false);
}
TypeDesc[]parameters=newTypeDesc[method.Signature.Length];
for(inti=0;i<parameters.Length;i++)
{
parameters[i]=method.Signature[i].ReplaceTypesInConstructionOfType(typesToReplace,replacementTypes);
}
TypeDescreturnType=method.Signature.ReturnType.ReplaceTypesInConstructionOfType(typesToReplace,replacementTypes);
signature=newMethodSignature(signature.Flags,signature.GenericParameterCount,returnType,parameters);
}

Is it also required for coreclr?

jkotas · 2024-07-18T04:25:29Z

The same tests in DI are still failing. Can it be related to the signature instantiation in ILC?

We should not need a special signature instantiation like that in CoreCLR. I suspect that it is related to a special delegate calling convention used for delegate Invocation in some cases. The delegate target cannot be called via pointer - it must be called as Delegate.Invoke method so that the special calling convention kicks in.

Do you know if the Invoke method is used in the DI on a performance critical path?

This is proving to be much harder than what I thought it is going to be.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

jkotas · 2024-09-19T06:43:24Z

I have pushed a commit with a small change to handle the new IL stub in stub manager. The manual debugger test from #104731 (comment) works fine now.

jkotas

LGTM. Thank you!

jkotas · 2024-09-19T15:48:39Z

Remaining code under the feature switch is COM call stub, which is more complicated and is better separated out.

Do you plan to work on cleaning up the remaining code under the feature switch?

huoyaoyuan · 2024-09-19T16:23:37Z

Do you plan to work on cleaning up the remaining code under the feature switch?

Aaron suggested me to avoid converting COM interop related code because the effort needed for reviewing. I'm already busy now until October.

If you can confirm the review effort on behalf of interop team, I can start to investigate this when I finish urgent tasks.

jkotas · 2024-09-20T06:13:04Z

I gave it a shot in #108048.

* Use direct SinglecastDelegateInvokeStub on windows x86 * Cleanup ifdefs * EmitDebugBreak is unused * Use IL stub for Delegate.Invoke * Remove SinglecastDelegateInvokeStub in asm * Fix method name and argument count * Code quality * Delete JIT_InternalThrow and CorInfoException * Apply the same codegen to ilc * Add KeepAlive * Emit recursive call instead * Add tests for indirect delegate invocation * Use public reflection instead. * Use ldvirtftn to bypass this check * Use winner from CompareExchange * Return Stub from GetInvokeMethodStub * Delete NEWSTUB_FL_MULTICAST and dependents * Handle new stub in ILStubManager --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>

huoyaoyuan · 2024-07-11T13:48:19Z

There's no actually no IL stubs under this feature switch now, only asm stubs.

This PR addresses the simple cases. On all platforms except Windows x86, single cast delegate is written in invariant assembly code.

Remaining code under the feature switch is COM call stub, which is more complicated and is better separated out.

jkotas · 2024-07-17T14:49:15Z

Code quality

If this helps with code quality, could you please make the same change in

runtime/src/coreclr/tools/Common/TypeSystem/IL/Stubs/DelegateMethodILEmitter.cs

Lines 59 to 60 in 3f607bd

codeStream.EmitLdArg(0);
codeStream.Emit(ILOpcode.ldfld,emit.NewToken(functionPointerField.InstantiateAsOpen()));

as well? It is naot equivalent of this stub.

huoyaoyuan · 2024-07-17T15:53:50Z

The same tests in DI are still failing. Can it be related to the signature instantiation in ILC?

runtime/src/coreclr/tools/Common/TypeSystem/IL/Stubs/DelegateMethodILEmitter.cs

Lines 63 to 81 in 3f607bd

if(method.OwningType.HasInstantiation)
{
// If the owning type is generic, the signature will contain T's and U's.
// We need !0's and !1's.
TypeDesc[]typesToReplace=newTypeDesc[method.OwningType.Instantiation.Length];
TypeDesc[]replacementTypes=newTypeDesc[typesToReplace.Length];
for(inti=0;i<typesToReplace.Length;i++)
{
typesToReplace[i]=method.OwningType.Instantiation[i];
replacementTypes[i]=context.GetSignatureVariable(i,method:false);
}
TypeDesc[]parameters=newTypeDesc[method.Signature.Length];
for(inti=0;i<parameters.Length;i++)
{
parameters[i]=method.Signature[i].ReplaceTypesInConstructionOfType(typesToReplace,replacementTypes);
}
TypeDescreturnType=method.Signature.ReturnType.ReplaceTypesInConstructionOfType(typesToReplace,replacementTypes);
signature=newMethodSignature(signature.Flags,signature.GenericParameterCount,returnType,parameters);
}

Is it also required for coreclr?

jkotas · 2024-07-18T04:25:29Z

The same tests in DI are still failing. Can it be related to the signature instantiation in ILC?

We should not need a special signature instantiation like that in CoreCLR. I suspect that it is related to a special delegate calling convention used for delegate Invocation in some cases. The delegate target cannot be called via pointer - it must be called as Delegate.Invoke method so that the special calling convention kicks in.

Do you know if the Invoke method is used in the DI on a performance critical path?

This is proving to be much harder than what I thought it is going to be.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

jkotas · 2024-09-19T06:43:24Z

I have pushed a commit with a small change to handle the new IL stub in stub manager. The manual debugger test from #104731 (comment) works fine now.

jkotas

LGTM. Thank you!

jkotas · 2024-09-19T15:48:39Z

Remaining code under the feature switch is COM call stub, which is more complicated and is better separated out.

Do you plan to work on cleaning up the remaining code under the feature switch?

huoyaoyuan · 2024-09-19T16:23:37Z

Do you plan to work on cleaning up the remaining code under the feature switch?

Aaron suggested me to avoid converting COM interop related code because the effort needed for reviewing. I'm already busy now until October.

If you can confirm the review effort on behalf of interop team, I can start to investigate this when I finish urgent tasks.

jkotas · 2024-09-20T06:13:04Z

I gave it a shot in #108048.

* Use direct SinglecastDelegateInvokeStub on windows x86 * Cleanup ifdefs * EmitDebugBreak is unused * Use IL stub for Delegate.Invoke * Remove SinglecastDelegateInvokeStub in asm * Fix method name and argument count * Code quality * Delete JIT_InternalThrow and CorInfoException * Apply the same codegen to ilc * Add KeepAlive * Emit recursive call instead * Add tests for indirect delegate invocation * Use public reflection instead. * Use ldvirtftn to bypass this check * Use winner from CompareExchange * Return Stub from GetInvokeMethodStub * Delete NEWSTUB_FL_MULTICAST and dependents * Handle new stub in ILStubManager --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>

huoyaoyuan · 2024-07-11T13:48:19Z

There's no actually no IL stubs under this feature switch now, only asm stubs.

This PR addresses the simple cases. On all platforms except Windows x86, single cast delegate is written in invariant assembly code.

Remaining code under the feature switch is COM call stub, which is more complicated and is better separated out.

jkotas · 2024-07-17T14:49:15Z

Code quality

If this helps with code quality, could you please make the same change in

runtime/src/coreclr/tools/Common/TypeSystem/IL/Stubs/DelegateMethodILEmitter.cs

Lines 59 to 60 in 3f607bd

codeStream.EmitLdArg(0);
codeStream.Emit(ILOpcode.ldfld,emit.NewToken(functionPointerField.InstantiateAsOpen()));

as well? It is naot equivalent of this stub.

huoyaoyuan · 2024-07-17T15:53:50Z

The same tests in DI are still failing. Can it be related to the signature instantiation in ILC?

runtime/src/coreclr/tools/Common/TypeSystem/IL/Stubs/DelegateMethodILEmitter.cs

Lines 63 to 81 in 3f607bd

if(method.OwningType.HasInstantiation)
{
// If the owning type is generic, the signature will contain T's and U's.
// We need !0's and !1's.
TypeDesc[]typesToReplace=newTypeDesc[method.OwningType.Instantiation.Length];
TypeDesc[]replacementTypes=newTypeDesc[typesToReplace.Length];
for(inti=0;i<typesToReplace.Length;i++)
{
typesToReplace[i]=method.OwningType.Instantiation[i];
replacementTypes[i]=context.GetSignatureVariable(i,method:false);
}
TypeDesc[]parameters=newTypeDesc[method.Signature.Length];
for(inti=0;i<parameters.Length;i++)
{
parameters[i]=method.Signature[i].ReplaceTypesInConstructionOfType(typesToReplace,replacementTypes);
}
TypeDescreturnType=method.Signature.ReturnType.ReplaceTypesInConstructionOfType(typesToReplace,replacementTypes);
signature=newMethodSignature(signature.Flags,signature.GenericParameterCount,returnType,parameters);
}

Is it also required for coreclr?

jkotas · 2024-07-18T04:25:29Z

The same tests in DI are still failing. Can it be related to the signature instantiation in ILC?

We should not need a special signature instantiation like that in CoreCLR. I suspect that it is related to a special delegate calling convention used for delegate Invocation in some cases. The delegate target cannot be called via pointer - it must be called as Delegate.Invoke method so that the special calling convention kicks in.

Do you know if the Invoke method is used in the DI on a performance critical path?

This is proving to be much harder than what I thought it is going to be.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

jkotas · 2024-09-19T06:43:24Z

I have pushed a commit with a small change to handle the new IL stub in stub manager. The manual debugger test from #104731 (comment) works fine now.

jkotas

LGTM. Thank you!

jkotas · 2024-09-19T15:48:39Z

Remaining code under the feature switch is COM call stub, which is more complicated and is better separated out.

Do you plan to work on cleaning up the remaining code under the feature switch?

huoyaoyuan · 2024-09-19T16:23:37Z

Do you plan to work on cleaning up the remaining code under the feature switch?

Aaron suggested me to avoid converting COM interop related code because the effort needed for reviewing. I'm already busy now until October.

If you can confirm the review effort on behalf of interop team, I can start to investigate this when I finish urgent tasks.

jkotas · 2024-09-20T06:13:04Z

I gave it a shot in #108048.

* Use direct SinglecastDelegateInvokeStub on windows x86 * Cleanup ifdefs * EmitDebugBreak is unused * Use IL stub for Delegate.Invoke * Remove SinglecastDelegateInvokeStub in asm * Fix method name and argument count * Code quality * Delete JIT_InternalThrow and CorInfoException * Apply the same codegen to ilc * Add KeepAlive * Emit recursive call instead * Add tests for indirect delegate invocation * Use public reflection instead. * Use ldvirtftn to bypass this check * Use winner from CompareExchange * Return Stub from GetInvokeMethodStub * Delete NEWSTUB_FL_MULTICAST and dependents * Handle new stub in ILStubManager --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>

huoyaoyuan · 2024-07-11T13:48:19Z

There's no actually no IL stubs under this feature switch now, only asm stubs.

This PR addresses the simple cases. On all platforms except Windows x86, single cast delegate is written in invariant assembly code.

Remaining code under the feature switch is COM call stub, which is more complicated and is better separated out.

jkotas · 2024-07-17T14:49:15Z

Code quality

If this helps with code quality, could you please make the same change in

runtime/src/coreclr/tools/Common/TypeSystem/IL/Stubs/DelegateMethodILEmitter.cs

Lines 59 to 60 in 3f607bd

codeStream.EmitLdArg(0);
codeStream.Emit(ILOpcode.ldfld,emit.NewToken(functionPointerField.InstantiateAsOpen()));

as well? It is naot equivalent of this stub.

huoyaoyuan · 2024-07-17T15:53:50Z

The same tests in DI are still failing. Can it be related to the signature instantiation in ILC?

runtime/src/coreclr/tools/Common/TypeSystem/IL/Stubs/DelegateMethodILEmitter.cs

Lines 63 to 81 in 3f607bd

if(method.OwningType.HasInstantiation)
{
// If the owning type is generic, the signature will contain T's and U's.
// We need !0's and !1's.
TypeDesc[]typesToReplace=newTypeDesc[method.OwningType.Instantiation.Length];
TypeDesc[]replacementTypes=newTypeDesc[typesToReplace.Length];
for(inti=0;i<typesToReplace.Length;i++)
{
typesToReplace[i]=method.OwningType.Instantiation[i];
replacementTypes[i]=context.GetSignatureVariable(i,method:false);
}
TypeDesc[]parameters=newTypeDesc[method.Signature.Length];
for(inti=0;i<parameters.Length;i++)
{
parameters[i]=method.Signature[i].ReplaceTypesInConstructionOfType(typesToReplace,replacementTypes);
}
TypeDescreturnType=method.Signature.ReturnType.ReplaceTypesInConstructionOfType(typesToReplace,replacementTypes);
signature=newMethodSignature(signature.Flags,signature.GenericParameterCount,returnType,parameters);
}

Is it also required for coreclr?

jkotas · 2024-07-18T04:25:29Z

The same tests in DI are still failing. Can it be related to the signature instantiation in ILC?

We should not need a special signature instantiation like that in CoreCLR. I suspect that it is related to a special delegate calling convention used for delegate Invocation in some cases. The delegate target cannot be called via pointer - it must be called as Delegate.Invoke method so that the special calling convention kicks in.

Do you know if the Invoke method is used in the DI on a performance critical path?

This is proving to be much harder than what I thought it is going to be.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

jkotas · 2024-09-19T06:43:24Z

I have pushed a commit with a small change to handle the new IL stub in stub manager. The manual debugger test from #104731 (comment) works fine now.

jkotas

LGTM. Thank you!

jkotas · 2024-09-19T15:48:39Z

Remaining code under the feature switch is COM call stub, which is more complicated and is better separated out.

Do you plan to work on cleaning up the remaining code under the feature switch?

huoyaoyuan · 2024-09-19T16:23:37Z

Do you plan to work on cleaning up the remaining code under the feature switch?

Aaron suggested me to avoid converting COM interop related code because the effort needed for reviewing. I'm already busy now until October.

If you can confirm the review effort on behalf of interop team, I can start to investigate this when I finish urgent tasks.

jkotas · 2024-09-20T06:13:04Z

I gave it a shot in #108048.

* Use direct SinglecastDelegateInvokeStub on windows x86 * Cleanup ifdefs * EmitDebugBreak is unused * Use IL stub for Delegate.Invoke * Remove SinglecastDelegateInvokeStub in asm * Fix method name and argument count * Code quality * Delete JIT_InternalThrow and CorInfoException * Apply the same codegen to ilc * Add KeepAlive * Emit recursive call instead * Add tests for indirect delegate invocation * Use public reflection instead. * Use ldvirtftn to bypass this check * Use winner from CompareExchange * Return Stub from GetInvokeMethodStub * Delete NEWSTUB_FL_MULTICAST and dependents * Handle new stub in ILStubManager --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>

huoyaoyuan · 2024-07-11T13:48:19Z

There's no actually no IL stubs under this feature switch now, only asm stubs.

This PR addresses the simple cases. On all platforms except Windows x86, single cast delegate is written in invariant assembly code.

Remaining code under the feature switch is COM call stub, which is more complicated and is better separated out.

jkotas · 2024-07-17T14:49:15Z

Code quality

If this helps with code quality, could you please make the same change in

runtime/src/coreclr/tools/Common/TypeSystem/IL/Stubs/DelegateMethodILEmitter.cs

Lines 59 to 60 in 3f607bd

codeStream.EmitLdArg(0);
codeStream.Emit(ILOpcode.ldfld,emit.NewToken(functionPointerField.InstantiateAsOpen()));

as well? It is naot equivalent of this stub.

huoyaoyuan · 2024-07-17T15:53:50Z

The same tests in DI are still failing. Can it be related to the signature instantiation in ILC?

runtime/src/coreclr/tools/Common/TypeSystem/IL/Stubs/DelegateMethodILEmitter.cs

Lines 63 to 81 in 3f607bd

if(method.OwningType.HasInstantiation)
{
// If the owning type is generic, the signature will contain T's and U's.
// We need !0's and !1's.
TypeDesc[]typesToReplace=newTypeDesc[method.OwningType.Instantiation.Length];
TypeDesc[]replacementTypes=newTypeDesc[typesToReplace.Length];
for(inti=0;i<typesToReplace.Length;i++)
{
typesToReplace[i]=method.OwningType.Instantiation[i];
replacementTypes[i]=context.GetSignatureVariable(i,method:false);
}
TypeDesc[]parameters=newTypeDesc[method.Signature.Length];
for(inti=0;i<parameters.Length;i++)
{
parameters[i]=method.Signature[i].ReplaceTypesInConstructionOfType(typesToReplace,replacementTypes);
}
TypeDescreturnType=method.Signature.ReturnType.ReplaceTypesInConstructionOfType(typesToReplace,replacementTypes);
signature=newMethodSignature(signature.Flags,signature.GenericParameterCount,returnType,parameters);
}

Is it also required for coreclr?

jkotas · 2024-07-18T04:25:29Z

The same tests in DI are still failing. Can it be related to the signature instantiation in ILC?

We should not need a special signature instantiation like that in CoreCLR. I suspect that it is related to a special delegate calling convention used for delegate Invocation in some cases. The delegate target cannot be called via pointer - it must be called as Delegate.Invoke method so that the special calling convention kicks in.

Do you know if the Invoke method is used in the DI on a performance critical path?

This is proving to be much harder than what I thought it is going to be.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

jkotas · 2024-09-19T06:43:24Z

I have pushed a commit with a small change to handle the new IL stub in stub manager. The manual debugger test from #104731 (comment) works fine now.

jkotas

LGTM. Thank you!

jkotas · 2024-09-19T15:48:39Z

Remaining code under the feature switch is COM call stub, which is more complicated and is better separated out.

Do you plan to work on cleaning up the remaining code under the feature switch?

huoyaoyuan · 2024-09-19T16:23:37Z

Do you plan to work on cleaning up the remaining code under the feature switch?

Aaron suggested me to avoid converting COM interop related code because the effort needed for reviewing. I'm already busy now until October.

If you can confirm the review effort on behalf of interop team, I can start to investigate this when I finish urgent tasks.

jkotas · 2024-09-20T06:13:04Z

I gave it a shot in #108048.

* Use direct SinglecastDelegateInvokeStub on windows x86 * Cleanup ifdefs * EmitDebugBreak is unused * Use IL stub for Delegate.Invoke * Remove SinglecastDelegateInvokeStub in asm * Fix method name and argument count * Code quality * Delete JIT_InternalThrow and CorInfoException * Apply the same codegen to ilc * Add KeepAlive * Emit recursive call instead * Add tests for indirect delegate invocation * Use public reflection instead. * Use ldvirtftn to bypass this check * Use winner from CompareExchange * Return Stub from GetInvokeMethodStub * Delete NEWSTUB_FL_MULTICAST and dependents * Handle new stub in ILStubManager --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>

huoyaoyuan · 2024-07-11T13:48:19Z

There's no actually no IL stubs under this feature switch now, only asm stubs.

This PR addresses the simple cases. On all platforms except Windows x86, single cast delegate is written in invariant assembly code.

Remaining code under the feature switch is COM call stub, which is more complicated and is better separated out.

jkotas · 2024-07-17T14:49:15Z

Code quality

If this helps with code quality, could you please make the same change in

runtime/src/coreclr/tools/Common/TypeSystem/IL/Stubs/DelegateMethodILEmitter.cs

Lines 59 to 60 in 3f607bd

codeStream.EmitLdArg(0);
codeStream.Emit(ILOpcode.ldfld,emit.NewToken(functionPointerField.InstantiateAsOpen()));

as well? It is naot equivalent of this stub.

huoyaoyuan · 2024-07-17T15:53:50Z

The same tests in DI are still failing. Can it be related to the signature instantiation in ILC?

runtime/src/coreclr/tools/Common/TypeSystem/IL/Stubs/DelegateMethodILEmitter.cs

Lines 63 to 81 in 3f607bd

if(method.OwningType.HasInstantiation)
{
// If the owning type is generic, the signature will contain T's and U's.
// We need !0's and !1's.
TypeDesc[]typesToReplace=newTypeDesc[method.OwningType.Instantiation.Length];
TypeDesc[]replacementTypes=newTypeDesc[typesToReplace.Length];
for(inti=0;i<typesToReplace.Length;i++)
{
typesToReplace[i]=method.OwningType.Instantiation[i];
replacementTypes[i]=context.GetSignatureVariable(i,method:false);
}
TypeDesc[]parameters=newTypeDesc[method.Signature.Length];
for(inti=0;i<parameters.Length;i++)
{
parameters[i]=method.Signature[i].ReplaceTypesInConstructionOfType(typesToReplace,replacementTypes);
}
TypeDescreturnType=method.Signature.ReturnType.ReplaceTypesInConstructionOfType(typesToReplace,replacementTypes);
signature=newMethodSignature(signature.Flags,signature.GenericParameterCount,returnType,parameters);
}

Is it also required for coreclr?

jkotas · 2024-07-18T04:25:29Z

The same tests in DI are still failing. Can it be related to the signature instantiation in ILC?

We should not need a special signature instantiation like that in CoreCLR. I suspect that it is related to a special delegate calling convention used for delegate Invocation in some cases. The delegate target cannot be called via pointer - it must be called as Delegate.Invoke method so that the special calling convention kicks in.

Do you know if the Invoke method is used in the DI on a performance critical path?

This is proving to be much harder than what I thought it is going to be.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

jkotas · 2024-09-19T06:43:24Z

I have pushed a commit with a small change to handle the new IL stub in stub manager. The manual debugger test from #104731 (comment) works fine now.

jkotas

LGTM. Thank you!

jkotas · 2024-09-19T15:48:39Z

Remaining code under the feature switch is COM call stub, which is more complicated and is better separated out.

Do you plan to work on cleaning up the remaining code under the feature switch?

huoyaoyuan · 2024-09-19T16:23:37Z

Do you plan to work on cleaning up the remaining code under the feature switch?

Aaron suggested me to avoid converting COM interop related code because the effort needed for reviewing. I'm already busy now until October.

If you can confirm the review effort on behalf of interop team, I can start to investigate this when I finish urgent tasks.

jkotas · 2024-09-20T06:13:04Z

I gave it a shot in #108048.

* Use direct SinglecastDelegateInvokeStub on windows x86 * Cleanup ifdefs * EmitDebugBreak is unused * Use IL stub for Delegate.Invoke * Remove SinglecastDelegateInvokeStub in asm * Fix method name and argument count * Code quality * Delete JIT_InternalThrow and CorInfoException * Apply the same codegen to ilc * Add KeepAlive * Emit recursive call instead * Add tests for indirect delegate invocation * Use public reflection instead. * Use ldvirtftn to bypass this check * Use winner from CompareExchange * Return Stub from GetInvokeMethodStub * Delete NEWSTUB_FL_MULTICAST and dependents * Handle new stub in ILStubManager --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>

huoyaoyuan · 2024-07-11T13:48:19Z

There's no actually no IL stubs under this feature switch now, only asm stubs.

This PR addresses the simple cases. On all platforms except Windows x86, single cast delegate is written in invariant assembly code.

Remaining code under the feature switch is COM call stub, which is more complicated and is better separated out.

jkotas · 2024-07-17T14:49:15Z

Code quality

If this helps with code quality, could you please make the same change in

runtime/src/coreclr/tools/Common/TypeSystem/IL/Stubs/DelegateMethodILEmitter.cs

Lines 59 to 60 in 3f607bd

codeStream.EmitLdArg(0);
codeStream.Emit(ILOpcode.ldfld,emit.NewToken(functionPointerField.InstantiateAsOpen()));

as well? It is naot equivalent of this stub.

huoyaoyuan · 2024-07-17T15:53:50Z

The same tests in DI are still failing. Can it be related to the signature instantiation in ILC?

runtime/src/coreclr/tools/Common/TypeSystem/IL/Stubs/DelegateMethodILEmitter.cs

Lines 63 to 81 in 3f607bd

if(method.OwningType.HasInstantiation)
{
// If the owning type is generic, the signature will contain T's and U's.
// We need !0's and !1's.
TypeDesc[]typesToReplace=newTypeDesc[method.OwningType.Instantiation.Length];
TypeDesc[]replacementTypes=newTypeDesc[typesToReplace.Length];
for(inti=0;i<typesToReplace.Length;i++)
{
typesToReplace[i]=method.OwningType.Instantiation[i];
replacementTypes[i]=context.GetSignatureVariable(i,method:false);
}
TypeDesc[]parameters=newTypeDesc[method.Signature.Length];
for(inti=0;i<parameters.Length;i++)
{
parameters[i]=method.Signature[i].ReplaceTypesInConstructionOfType(typesToReplace,replacementTypes);
}
TypeDescreturnType=method.Signature.ReturnType.ReplaceTypesInConstructionOfType(typesToReplace,replacementTypes);
signature=newMethodSignature(signature.Flags,signature.GenericParameterCount,returnType,parameters);
}

Is it also required for coreclr?

jkotas · 2024-07-18T04:25:29Z

The same tests in DI are still failing. Can it be related to the signature instantiation in ILC?

We should not need a special signature instantiation like that in CoreCLR. I suspect that it is related to a special delegate calling convention used for delegate Invocation in some cases. The delegate target cannot be called via pointer - it must be called as Delegate.Invoke method so that the special calling convention kicks in.

Do you know if the Invoke method is used in the DI on a performance critical path?

This is proving to be much harder than what I thought it is going to be.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

jkotas · 2024-09-19T06:43:24Z

I have pushed a commit with a small change to handle the new IL stub in stub manager. The manual debugger test from #104731 (comment) works fine now.

jkotas

LGTM. Thank you!

jkotas · 2024-09-19T15:48:39Z

Remaining code under the feature switch is COM call stub, which is more complicated and is better separated out.

Do you plan to work on cleaning up the remaining code under the feature switch?

huoyaoyuan · 2024-09-19T16:23:37Z

Do you plan to work on cleaning up the remaining code under the feature switch?

Aaron suggested me to avoid converting COM interop related code because the effort needed for reviewing. I'm already busy now until October.

If you can confirm the review effort on behalf of interop team, I can start to investigate this when I finish urgent tasks.

jkotas · 2024-09-20T06:13:04Z

I gave it a shot in #108048.

* Use direct SinglecastDelegateInvokeStub on windows x86 * Cleanup ifdefs * EmitDebugBreak is unused * Use IL stub for Delegate.Invoke * Remove SinglecastDelegateInvokeStub in asm * Fix method name and argument count * Code quality * Delete JIT_InternalThrow and CorInfoException * Apply the same codegen to ilc * Add KeepAlive * Emit recursive call instead * Add tests for indirect delegate invocation * Use public reflection instead. * Use ldvirtftn to bypass this check * Use winner from CompareExchange * Return Stub from GetInvokeMethodStub * Delete NEWSTUB_FL_MULTICAST and dependents * Handle new stub in ILStubManager --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>

huoyaoyuan · 2024-07-11T13:48:19Z

There's no actually no IL stubs under this feature switch now, only asm stubs.

This PR addresses the simple cases. On all platforms except Windows x86, single cast delegate is written in invariant assembly code.

Remaining code under the feature switch is COM call stub, which is more complicated and is better separated out.

jkotas · 2024-07-17T14:49:15Z

Code quality

If this helps with code quality, could you please make the same change in

runtime/src/coreclr/tools/Common/TypeSystem/IL/Stubs/DelegateMethodILEmitter.cs

Lines 59 to 60 in 3f607bd

codeStream.EmitLdArg(0);
codeStream.Emit(ILOpcode.ldfld,emit.NewToken(functionPointerField.InstantiateAsOpen()));

as well? It is naot equivalent of this stub.

huoyaoyuan · 2024-07-17T15:53:50Z

The same tests in DI are still failing. Can it be related to the signature instantiation in ILC?

runtime/src/coreclr/tools/Common/TypeSystem/IL/Stubs/DelegateMethodILEmitter.cs

Lines 63 to 81 in 3f607bd

if(method.OwningType.HasInstantiation)
{
// If the owning type is generic, the signature will contain T's and U's.
// We need !0's and !1's.
TypeDesc[]typesToReplace=newTypeDesc[method.OwningType.Instantiation.Length];
TypeDesc[]replacementTypes=newTypeDesc[typesToReplace.Length];
for(inti=0;i<typesToReplace.Length;i++)
{
typesToReplace[i]=method.OwningType.Instantiation[i];
replacementTypes[i]=context.GetSignatureVariable(i,method:false);
}
TypeDesc[]parameters=newTypeDesc[method.Signature.Length];
for(inti=0;i<parameters.Length;i++)
{
parameters[i]=method.Signature[i].ReplaceTypesInConstructionOfType(typesToReplace,replacementTypes);
}
TypeDescreturnType=method.Signature.ReturnType.ReplaceTypesInConstructionOfType(typesToReplace,replacementTypes);
signature=newMethodSignature(signature.Flags,signature.GenericParameterCount,returnType,parameters);
}

Is it also required for coreclr?

jkotas · 2024-07-18T04:25:29Z

The same tests in DI are still failing. Can it be related to the signature instantiation in ILC?

We should not need a special signature instantiation like that in CoreCLR. I suspect that it is related to a special delegate calling convention used for delegate Invocation in some cases. The delegate target cannot be called via pointer - it must be called as Delegate.Invoke method so that the special calling convention kicks in.

Do you know if the Invoke method is used in the DI on a performance critical path?

This is proving to be much harder than what I thought it is going to be.

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

jkotas · 2024-09-19T06:43:24Z

I have pushed a commit with a small change to handle the new IL stub in stub manager. The manual debugger test from #104731 (comment) works fine now.

jkotas

LGTM. Thank you!

jkotas · 2024-09-19T15:48:39Z

Remaining code under the feature switch is COM call stub, which is more complicated and is better separated out.

Do you plan to work on cleaning up the remaining code under the feature switch?

huoyaoyuan · 2024-09-19T16:23:37Z

Do you plan to work on cleaning up the remaining code under the feature switch?

Aaron suggested me to avoid converting COM interop related code because the effort needed for reviewing. I'm already busy now until October.

If you can confirm the review effort on behalf of interop team, I can start to investigate this when I finish urgent tasks.

jkotas · 2024-09-20T06:13:04Z

I gave it a shot in #108048.

* Use direct SinglecastDelegateInvokeStub on windows x86 * Cleanup ifdefs * EmitDebugBreak is unused * Use IL stub for Delegate.Invoke * Remove SinglecastDelegateInvokeStub in asm * Fix method name and argument count * Code quality * Delete JIT_InternalThrow and CorInfoException * Apply the same codegen to ilc * Add KeepAlive * Emit recursive call instead * Add tests for indirect delegate invocation * Use public reflection instead. * Use ldvirtftn to bypass this check * Use winner from CompareExchange * Return Stub from GetInvokeMethodStub * Delete NEWSTUB_FL_MULTICAST and dependents * Handle new stub in ILStubManager --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>

huoyaoyuan added 4 commits July 11, 2024 21:03

Use direct SinglecastDelegateInvokeStub on windows x86
c06cc3f

Cleanup ifdefs
4845202

EmitDebugBreak is unused
faf25e7

endif format
09fcf2b

ghost added the area-VM-coreclr label Jul 11, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jul 11, 2024

huoyaoyuan added 2 commits July 11, 2024 21:52

Restore comment
19057f9

Fix JIT_InternalThrowFromHelper reference
157325b

This was referenced Jul 11, 2024
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
The job running on agent NetCore-Public ran longer than the maximum time #104044
Closed

jkotas changed the title ~~Cleanup some code under FEATURE_STUBS_AS_AL~~Cleanup some code under FEATURE_STUBS_AS_ILJul 12, 2024

jkotas reviewed Jul 12, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/i386/asmhelpers.asm Outdated

huoyaoyuan added 2 commits July 16, 2024 00:03

Use IL stub for Delegate.Invoke
c98be47

Remove SinglecastDelegateInvokeStub in asm
72fd2d6

build-analysisBot mentioned this pull request Jul 15, 2024
Test failure WindowsAlternateDataStreamOverwrite #83659
Closed

huoyaoyuan added 2 commits July 17, 2024 19:24

Fix method name and argument count
e60b3f1

Code quality
7f117aa

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/jitinterface.h Outdated

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stubmgr.cpp Outdated

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stubmgr.cpp Outdated

Delete JIT_InternalThrow and CorInfoException
cd648fa

huoyaoyuan commented Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/comdelegate.cpp Outdated

huoyaoyuan mentioned this pull request Jul 17, 2024
JIT unnecessary stack load/stores for tail jump with stack args involved #105031
Open

Apply the same codegen to ilc
b078f3a

build-analysisBot mentioned this pull request Jul 17, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

huoyaoyuan mentioned this pull request Jul 18, 2024
Some delegate invoke thunks fail to compile with where T : allows ref struct delegates #105029
Closed

huoyaoyuan mentioned this pull request Jul 18, 2024
JIT: potential GC hole with collectible code in delegate #105082
Open

jkotas mentioned this pull request Sep 18, 2024
Cleanup delegate-related code #107966
Merged

Apply suggestions from code review
8992882
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

build-analysisBot mentioned this pull request Sep 18, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

huoyaoyuan added 3 commits September 18, 2024 20:02

Merge branch 'main' into stubs-as-il
e06998c

Return Stub from GetInvokeMethodStub
c221eed

Delete NEWSTUB_FL_MULTICAST and dependents
1c640f8

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/dllimport.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/dllimport.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stublink.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stublink.h Outdated

huoyaoyuan added 4 commits September 19, 2024 10:59

Rename
e39afa1

Renumber
eebbc01

Merge branch 'main'
c2cf515

Format
bc1a766

jkotas reviewed Sep 19, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/method.hpp Outdated

jkotas added 2 commits September 18, 2024 22:15

Update src/coreclr/vm/method.hpp
ee674a3

Handle new stub in ILStubManager
fdd83eb

jkotas approved these changes Sep 19, 2024
View reviewed changes

build-analysisBot mentioned this pull request Sep 19, 2024
Test failure: System.Security.Cryptography.X509Certificates.Tests.PfxIterationCountTests_X509Certificate2.Import_IterationCountLimitExceeded_ThrowsInAllottedTime #105609
Closed

jkotas merged commit cc17a46 into dotnet:mainSep 19, 2024

huoyaoyuan deleted the stubs-as-il branch September 19, 2024 16:18

BruceForstall mentioned this pull request Sep 20, 2024
Test build failure: "coreclr Common Pri1 Test Build AnyOS AnyCPU checked" CI job fails #108076
Closed

AndyAyersMS mentioned this pull request Sep 24, 2024
[Perf] Windows/x64: 9 Improvements on 9/19/2024 4:00:38 PM dotnet/perf-autofiling-issues#41692
Closed

huoyaoyuan mentioned this pull request Oct 18, 2024
Fix Delegate dispatch. dotnet/runtimelab#2721
Merged

github-actionsBot locked and limited conversation to collaborators Oct 20, 2024

huoyaoyuan added 4 commits July 11, 2024 21:03

Use direct SinglecastDelegateInvokeStub on windows x86
c06cc3f

Cleanup ifdefs
4845202

EmitDebugBreak is unused
faf25e7

endif format
09fcf2b

ghost added the area-VM-coreclr label Jul 11, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jul 11, 2024

huoyaoyuan added 2 commits July 11, 2024 21:52

Restore comment
19057f9

Fix JIT_InternalThrowFromHelper reference
157325b

This was referenced Jul 11, 2024
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
The job running on agent NetCore-Public ran longer than the maximum time #104044
Closed

jkotas changed the title ~~Cleanup some code under FEATURE_STUBS_AS_AL~~Cleanup some code under FEATURE_STUBS_AS_ILJul 12, 2024

jkotas reviewed Jul 12, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/i386/asmhelpers.asm Outdated

huoyaoyuan added 2 commits July 16, 2024 00:03

Use IL stub for Delegate.Invoke
c98be47

Remove SinglecastDelegateInvokeStub in asm
72fd2d6

build-analysisBot mentioned this pull request Jul 15, 2024
Test failure WindowsAlternateDataStreamOverwrite #83659
Closed

huoyaoyuan added 2 commits July 17, 2024 19:24

Fix method name and argument count
e60b3f1

Code quality
7f117aa

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/jitinterface.h Outdated

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stubmgr.cpp Outdated

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stubmgr.cpp Outdated

Delete JIT_InternalThrow and CorInfoException
cd648fa

huoyaoyuan commented Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/comdelegate.cpp Outdated

huoyaoyuan mentioned this pull request Jul 17, 2024
JIT unnecessary stack load/stores for tail jump with stack args involved #105031
Open

Apply the same codegen to ilc
b078f3a

build-analysisBot mentioned this pull request Jul 17, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

huoyaoyuan mentioned this pull request Jul 18, 2024
Some delegate invoke thunks fail to compile with where T : allows ref struct delegates #105029
Closed

huoyaoyuan mentioned this pull request Jul 18, 2024
JIT: potential GC hole with collectible code in delegate #105082
Open

jkotas mentioned this pull request Sep 18, 2024
Cleanup delegate-related code #107966
Merged

Apply suggestions from code review
8992882
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

build-analysisBot mentioned this pull request Sep 18, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

huoyaoyuan added 3 commits September 18, 2024 20:02

Merge branch 'main' into stubs-as-il
e06998c

Return Stub from GetInvokeMethodStub
c221eed

Delete NEWSTUB_FL_MULTICAST and dependents
1c640f8

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/dllimport.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/dllimport.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stublink.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stublink.h Outdated

huoyaoyuan added 4 commits September 19, 2024 10:59

Rename
e39afa1

Renumber
eebbc01

Merge branch 'main'
c2cf515

Format
bc1a766

jkotas reviewed Sep 19, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/method.hpp Outdated

jkotas added 2 commits September 18, 2024 22:15

Update src/coreclr/vm/method.hpp
ee674a3

Handle new stub in ILStubManager
fdd83eb

jkotas approved these changes Sep 19, 2024
View reviewed changes

build-analysisBot mentioned this pull request Sep 19, 2024
Test failure: System.Security.Cryptography.X509Certificates.Tests.PfxIterationCountTests_X509Certificate2.Import_IterationCountLimitExceeded_ThrowsInAllottedTime #105609
Closed

jkotas merged commit cc17a46 into dotnet:mainSep 19, 2024

huoyaoyuan deleted the stubs-as-il branch September 19, 2024 16:18

BruceForstall mentioned this pull request Sep 20, 2024
Test build failure: "coreclr Common Pri1 Test Build AnyOS AnyCPU checked" CI job fails #108076
Closed

AndyAyersMS mentioned this pull request Sep 24, 2024
[Perf] Windows/x64: 9 Improvements on 9/19/2024 4:00:38 PM dotnet/perf-autofiling-issues#41692
Closed

huoyaoyuan mentioned this pull request Oct 18, 2024
Fix Delegate dispatch. dotnet/runtimelab#2721
Merged

github-actionsBot locked and limited conversation to collaborators Oct 20, 2024

huoyaoyuan added 4 commits July 11, 2024 21:03

Use direct SinglecastDelegateInvokeStub on windows x86
c06cc3f

Cleanup ifdefs
4845202

EmitDebugBreak is unused
faf25e7

endif format
09fcf2b

ghost added the area-VM-coreclr label Jul 11, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jul 11, 2024

huoyaoyuan added 2 commits July 11, 2024 21:52

Restore comment
19057f9

Fix JIT_InternalThrowFromHelper reference
157325b

This was referenced Jul 11, 2024
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
The job running on agent NetCore-Public ran longer than the maximum time #104044
Closed

jkotas changed the title ~~Cleanup some code under FEATURE_STUBS_AS_AL~~Cleanup some code under FEATURE_STUBS_AS_ILJul 12, 2024

jkotas reviewed Jul 12, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/i386/asmhelpers.asm Outdated

huoyaoyuan added 2 commits July 16, 2024 00:03

Use IL stub for Delegate.Invoke
c98be47

Remove SinglecastDelegateInvokeStub in asm
72fd2d6

build-analysisBot mentioned this pull request Jul 15, 2024
Test failure WindowsAlternateDataStreamOverwrite #83659
Closed

huoyaoyuan added 2 commits July 17, 2024 19:24

Fix method name and argument count
e60b3f1

Code quality
7f117aa

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/jitinterface.h Outdated

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stubmgr.cpp Outdated

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stubmgr.cpp Outdated

Delete JIT_InternalThrow and CorInfoException
cd648fa

huoyaoyuan commented Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/comdelegate.cpp Outdated

huoyaoyuan mentioned this pull request Jul 17, 2024
JIT unnecessary stack load/stores for tail jump with stack args involved #105031
Open

Apply the same codegen to ilc
b078f3a

build-analysisBot mentioned this pull request Jul 17, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

huoyaoyuan mentioned this pull request Jul 18, 2024
Some delegate invoke thunks fail to compile with where T : allows ref struct delegates #105029
Closed

huoyaoyuan mentioned this pull request Jul 18, 2024
JIT: potential GC hole with collectible code in delegate #105082
Open

jkotas mentioned this pull request Sep 18, 2024
Cleanup delegate-related code #107966
Merged

Apply suggestions from code review
8992882
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

build-analysisBot mentioned this pull request Sep 18, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

huoyaoyuan added 3 commits September 18, 2024 20:02

Merge branch 'main' into stubs-as-il
e06998c

Return Stub from GetInvokeMethodStub
c221eed

Delete NEWSTUB_FL_MULTICAST and dependents
1c640f8

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/dllimport.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/dllimport.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stublink.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stublink.h Outdated

huoyaoyuan added 4 commits September 19, 2024 10:59

Rename
e39afa1

Renumber
eebbc01

Merge branch 'main'
c2cf515

Format
bc1a766

jkotas reviewed Sep 19, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/method.hpp Outdated

jkotas added 2 commits September 18, 2024 22:15

Update src/coreclr/vm/method.hpp
ee674a3

Handle new stub in ILStubManager
fdd83eb

jkotas approved these changes Sep 19, 2024
View reviewed changes

build-analysisBot mentioned this pull request Sep 19, 2024
Test failure: System.Security.Cryptography.X509Certificates.Tests.PfxIterationCountTests_X509Certificate2.Import_IterationCountLimitExceeded_ThrowsInAllottedTime #105609
Closed

jkotas merged commit cc17a46 into dotnet:mainSep 19, 2024

huoyaoyuan deleted the stubs-as-il branch September 19, 2024 16:18

BruceForstall mentioned this pull request Sep 20, 2024
Test build failure: "coreclr Common Pri1 Test Build AnyOS AnyCPU checked" CI job fails #108076
Closed

AndyAyersMS mentioned this pull request Sep 24, 2024
[Perf] Windows/x64: 9 Improvements on 9/19/2024 4:00:38 PM dotnet/perf-autofiling-issues#41692
Closed

huoyaoyuan mentioned this pull request Oct 18, 2024
Fix Delegate dispatch. dotnet/runtimelab#2721
Merged

github-actionsBot locked and limited conversation to collaborators Oct 20, 2024

huoyaoyuan added 4 commits July 11, 2024 21:03

Use direct SinglecastDelegateInvokeStub on windows x86
c06cc3f

Cleanup ifdefs
4845202

EmitDebugBreak is unused
faf25e7

endif format
09fcf2b

ghost added the area-VM-coreclr label Jul 11, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jul 11, 2024

huoyaoyuan added 2 commits July 11, 2024 21:52

Restore comment
19057f9

Fix JIT_InternalThrowFromHelper reference
157325b

This was referenced Jul 11, 2024
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
The job running on agent NetCore-Public ran longer than the maximum time #104044
Closed

jkotas changed the title ~~Cleanup some code under FEATURE_STUBS_AS_AL~~Cleanup some code under FEATURE_STUBS_AS_ILJul 12, 2024

jkotas reviewed Jul 12, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/i386/asmhelpers.asm Outdated

huoyaoyuan added 2 commits July 16, 2024 00:03

Use IL stub for Delegate.Invoke
c98be47

Remove SinglecastDelegateInvokeStub in asm
72fd2d6

build-analysisBot mentioned this pull request Jul 15, 2024
Test failure WindowsAlternateDataStreamOverwrite #83659
Closed

huoyaoyuan added 2 commits July 17, 2024 19:24

Fix method name and argument count
e60b3f1

Code quality
7f117aa

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/jitinterface.h Outdated

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stubmgr.cpp Outdated

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stubmgr.cpp Outdated

Delete JIT_InternalThrow and CorInfoException
cd648fa

huoyaoyuan commented Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/comdelegate.cpp Outdated

huoyaoyuan mentioned this pull request Jul 17, 2024
JIT unnecessary stack load/stores for tail jump with stack args involved #105031
Open

Apply the same codegen to ilc
b078f3a

build-analysisBot mentioned this pull request Jul 17, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

huoyaoyuan mentioned this pull request Jul 18, 2024
Some delegate invoke thunks fail to compile with where T : allows ref struct delegates #105029
Closed

huoyaoyuan mentioned this pull request Jul 18, 2024
JIT: potential GC hole with collectible code in delegate #105082
Open

jkotas mentioned this pull request Sep 18, 2024
Cleanup delegate-related code #107966
Merged

Apply suggestions from code review
8992882
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

build-analysisBot mentioned this pull request Sep 18, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

huoyaoyuan added 3 commits September 18, 2024 20:02

Merge branch 'main' into stubs-as-il
e06998c

Return Stub from GetInvokeMethodStub
c221eed

Delete NEWSTUB_FL_MULTICAST and dependents
1c640f8

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/dllimport.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/dllimport.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stublink.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stublink.h Outdated

huoyaoyuan added 4 commits September 19, 2024 10:59

Rename
e39afa1

Renumber
eebbc01

Merge branch 'main'
c2cf515

Format
bc1a766

jkotas reviewed Sep 19, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/method.hpp Outdated

jkotas added 2 commits September 18, 2024 22:15

Update src/coreclr/vm/method.hpp
ee674a3

Handle new stub in ILStubManager
fdd83eb

jkotas approved these changes Sep 19, 2024
View reviewed changes

build-analysisBot mentioned this pull request Sep 19, 2024
Test failure: System.Security.Cryptography.X509Certificates.Tests.PfxIterationCountTests_X509Certificate2.Import_IterationCountLimitExceeded_ThrowsInAllottedTime #105609
Closed

jkotas merged commit cc17a46 into dotnet:mainSep 19, 2024

huoyaoyuan deleted the stubs-as-il branch September 19, 2024 16:18

BruceForstall mentioned this pull request Sep 20, 2024
Test build failure: "coreclr Common Pri1 Test Build AnyOS AnyCPU checked" CI job fails #108076
Closed

AndyAyersMS mentioned this pull request Sep 24, 2024
[Perf] Windows/x64: 9 Improvements on 9/19/2024 4:00:38 PM dotnet/perf-autofiling-issues#41692
Closed

huoyaoyuan mentioned this pull request Oct 18, 2024
Fix Delegate dispatch. dotnet/runtimelab#2721
Merged

github-actionsBot locked and limited conversation to collaborators Oct 20, 2024

huoyaoyuan added 4 commits July 11, 2024 21:03

Use direct SinglecastDelegateInvokeStub on windows x86
c06cc3f

Cleanup ifdefs
4845202

EmitDebugBreak is unused
faf25e7

endif format
09fcf2b

ghost added the area-VM-coreclr label Jul 11, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jul 11, 2024

huoyaoyuan added 2 commits July 11, 2024 21:52

Restore comment
19057f9

Fix JIT_InternalThrowFromHelper reference
157325b

This was referenced Jul 11, 2024
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
The job running on agent NetCore-Public ran longer than the maximum time #104044
Closed

jkotas changed the title ~~Cleanup some code under FEATURE_STUBS_AS_AL~~Cleanup some code under FEATURE_STUBS_AS_ILJul 12, 2024

jkotas reviewed Jul 12, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/i386/asmhelpers.asm Outdated

huoyaoyuan added 2 commits July 16, 2024 00:03

Use IL stub for Delegate.Invoke
c98be47

Remove SinglecastDelegateInvokeStub in asm
72fd2d6

build-analysisBot mentioned this pull request Jul 15, 2024
Test failure WindowsAlternateDataStreamOverwrite #83659
Closed

huoyaoyuan added 2 commits July 17, 2024 19:24

Fix method name and argument count
e60b3f1

Code quality
7f117aa

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/jitinterface.h Outdated

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stubmgr.cpp Outdated

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stubmgr.cpp Outdated

Delete JIT_InternalThrow and CorInfoException
cd648fa

huoyaoyuan commented Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/comdelegate.cpp Outdated

huoyaoyuan mentioned this pull request Jul 17, 2024
JIT unnecessary stack load/stores for tail jump with stack args involved #105031
Open

Apply the same codegen to ilc
b078f3a

build-analysisBot mentioned this pull request Jul 17, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

huoyaoyuan mentioned this pull request Jul 18, 2024
Some delegate invoke thunks fail to compile with where T : allows ref struct delegates #105029
Closed

huoyaoyuan mentioned this pull request Jul 18, 2024
JIT: potential GC hole with collectible code in delegate #105082
Open

jkotas mentioned this pull request Sep 18, 2024
Cleanup delegate-related code #107966
Merged

Apply suggestions from code review
8992882
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

build-analysisBot mentioned this pull request Sep 18, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

huoyaoyuan added 3 commits September 18, 2024 20:02

Merge branch 'main' into stubs-as-il
e06998c

Return Stub from GetInvokeMethodStub
c221eed

Delete NEWSTUB_FL_MULTICAST and dependents
1c640f8

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/dllimport.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/dllimport.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stublink.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stublink.h Outdated

huoyaoyuan added 4 commits September 19, 2024 10:59

Rename
e39afa1

Renumber
eebbc01

Merge branch 'main'
c2cf515

Format
bc1a766

jkotas reviewed Sep 19, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/method.hpp Outdated

jkotas added 2 commits September 18, 2024 22:15

Update src/coreclr/vm/method.hpp
ee674a3

Handle new stub in ILStubManager
fdd83eb

jkotas approved these changes Sep 19, 2024
View reviewed changes

build-analysisBot mentioned this pull request Sep 19, 2024
Test failure: System.Security.Cryptography.X509Certificates.Tests.PfxIterationCountTests_X509Certificate2.Import_IterationCountLimitExceeded_ThrowsInAllottedTime #105609
Closed

jkotas merged commit cc17a46 into dotnet:mainSep 19, 2024

huoyaoyuan deleted the stubs-as-il branch September 19, 2024 16:18

BruceForstall mentioned this pull request Sep 20, 2024
Test build failure: "coreclr Common Pri1 Test Build AnyOS AnyCPU checked" CI job fails #108076
Closed

AndyAyersMS mentioned this pull request Sep 24, 2024
[Perf] Windows/x64: 9 Improvements on 9/19/2024 4:00:38 PM dotnet/perf-autofiling-issues#41692
Closed

huoyaoyuan mentioned this pull request Oct 18, 2024
Fix Delegate dispatch. dotnet/runtimelab#2721
Merged

github-actionsBot locked and limited conversation to collaborators Oct 20, 2024

huoyaoyuan added 4 commits July 11, 2024 21:03

Use direct SinglecastDelegateInvokeStub on windows x86
c06cc3f

Cleanup ifdefs
4845202

EmitDebugBreak is unused
faf25e7

endif format
09fcf2b

ghost added the area-VM-coreclr label Jul 11, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jul 11, 2024

huoyaoyuan added 2 commits July 11, 2024 21:52

Restore comment
19057f9

Fix JIT_InternalThrowFromHelper reference
157325b

This was referenced Jul 11, 2024
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
The job running on agent NetCore-Public ran longer than the maximum time #104044
Closed

jkotas changed the title ~~Cleanup some code under FEATURE_STUBS_AS_AL~~Cleanup some code under FEATURE_STUBS_AS_ILJul 12, 2024

jkotas reviewed Jul 12, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/i386/asmhelpers.asm Outdated

huoyaoyuan added 2 commits July 16, 2024 00:03

Use IL stub for Delegate.Invoke
c98be47

Remove SinglecastDelegateInvokeStub in asm
72fd2d6

build-analysisBot mentioned this pull request Jul 15, 2024
Test failure WindowsAlternateDataStreamOverwrite #83659
Closed

huoyaoyuan added 2 commits July 17, 2024 19:24

Fix method name and argument count
e60b3f1

Code quality
7f117aa

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/jitinterface.h Outdated

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stubmgr.cpp Outdated

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stubmgr.cpp Outdated

Delete JIT_InternalThrow and CorInfoException
cd648fa

huoyaoyuan commented Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/comdelegate.cpp Outdated

huoyaoyuan mentioned this pull request Jul 17, 2024
JIT unnecessary stack load/stores for tail jump with stack args involved #105031
Open

Apply the same codegen to ilc
b078f3a

build-analysisBot mentioned this pull request Jul 17, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

huoyaoyuan mentioned this pull request Jul 18, 2024
Some delegate invoke thunks fail to compile with where T : allows ref struct delegates #105029
Closed

huoyaoyuan mentioned this pull request Jul 18, 2024
JIT: potential GC hole with collectible code in delegate #105082
Open

jkotas mentioned this pull request Sep 18, 2024
Cleanup delegate-related code #107966
Merged

Apply suggestions from code review
8992882
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

build-analysisBot mentioned this pull request Sep 18, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

huoyaoyuan added 3 commits September 18, 2024 20:02

Merge branch 'main' into stubs-as-il
e06998c

Return Stub from GetInvokeMethodStub
c221eed

Delete NEWSTUB_FL_MULTICAST and dependents
1c640f8

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/dllimport.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/dllimport.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stublink.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stublink.h Outdated

huoyaoyuan added 4 commits September 19, 2024 10:59

Rename
e39afa1

Renumber
eebbc01

Merge branch 'main'
c2cf515

Format
bc1a766

jkotas reviewed Sep 19, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/method.hpp Outdated

jkotas added 2 commits September 18, 2024 22:15

Update src/coreclr/vm/method.hpp
ee674a3

Handle new stub in ILStubManager
fdd83eb

jkotas approved these changes Sep 19, 2024
View reviewed changes

build-analysisBot mentioned this pull request Sep 19, 2024
Test failure: System.Security.Cryptography.X509Certificates.Tests.PfxIterationCountTests_X509Certificate2.Import_IterationCountLimitExceeded_ThrowsInAllottedTime #105609
Closed

jkotas merged commit cc17a46 into dotnet:mainSep 19, 2024

huoyaoyuan deleted the stubs-as-il branch September 19, 2024 16:18

BruceForstall mentioned this pull request Sep 20, 2024
Test build failure: "coreclr Common Pri1 Test Build AnyOS AnyCPU checked" CI job fails #108076
Closed

AndyAyersMS mentioned this pull request Sep 24, 2024
[Perf] Windows/x64: 9 Improvements on 9/19/2024 4:00:38 PM dotnet/perf-autofiling-issues#41692
Closed

huoyaoyuan mentioned this pull request Oct 18, 2024
Fix Delegate dispatch. dotnet/runtimelab#2721
Merged

github-actionsBot locked and limited conversation to collaborators Oct 20, 2024

huoyaoyuan added 4 commits July 11, 2024 21:03

Use direct SinglecastDelegateInvokeStub on windows x86
c06cc3f

Cleanup ifdefs
4845202

EmitDebugBreak is unused
faf25e7

endif format
09fcf2b

ghost added the area-VM-coreclr label Jul 11, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jul 11, 2024

huoyaoyuan added 2 commits July 11, 2024 21:52

Restore comment
19057f9

Fix JIT_InternalThrowFromHelper reference
157325b

This was referenced Jul 11, 2024
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
The job running on agent NetCore-Public ran longer than the maximum time #104044
Closed

jkotas changed the title ~~Cleanup some code under FEATURE_STUBS_AS_AL~~Cleanup some code under FEATURE_STUBS_AS_ILJul 12, 2024

jkotas reviewed Jul 12, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/i386/asmhelpers.asm Outdated

huoyaoyuan added 2 commits July 16, 2024 00:03

Use IL stub for Delegate.Invoke
c98be47

Remove SinglecastDelegateInvokeStub in asm
72fd2d6

build-analysisBot mentioned this pull request Jul 15, 2024
Test failure WindowsAlternateDataStreamOverwrite #83659
Closed

huoyaoyuan added 2 commits July 17, 2024 19:24

Fix method name and argument count
e60b3f1

Code quality
7f117aa

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/jitinterface.h Outdated

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stubmgr.cpp Outdated

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stubmgr.cpp Outdated

Delete JIT_InternalThrow and CorInfoException
cd648fa

huoyaoyuan commented Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/comdelegate.cpp Outdated

huoyaoyuan mentioned this pull request Jul 17, 2024
JIT unnecessary stack load/stores for tail jump with stack args involved #105031
Open

Apply the same codegen to ilc
b078f3a

build-analysisBot mentioned this pull request Jul 17, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

huoyaoyuan mentioned this pull request Jul 18, 2024
Some delegate invoke thunks fail to compile with where T : allows ref struct delegates #105029
Closed

huoyaoyuan mentioned this pull request Jul 18, 2024
JIT: potential GC hole with collectible code in delegate #105082
Open

jkotas mentioned this pull request Sep 18, 2024
Cleanup delegate-related code #107966
Merged

Apply suggestions from code review
8992882
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

build-analysisBot mentioned this pull request Sep 18, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

huoyaoyuan added 3 commits September 18, 2024 20:02

Merge branch 'main' into stubs-as-il
e06998c

Return Stub from GetInvokeMethodStub
c221eed

Delete NEWSTUB_FL_MULTICAST and dependents
1c640f8

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/dllimport.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/dllimport.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stublink.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stublink.h Outdated

huoyaoyuan added 4 commits September 19, 2024 10:59

Rename
e39afa1

Renumber
eebbc01

Merge branch 'main'
c2cf515

Format
bc1a766

jkotas reviewed Sep 19, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/method.hpp Outdated

jkotas added 2 commits September 18, 2024 22:15

Update src/coreclr/vm/method.hpp
ee674a3

Handle new stub in ILStubManager
fdd83eb

jkotas approved these changes Sep 19, 2024
View reviewed changes

build-analysisBot mentioned this pull request Sep 19, 2024
Test failure: System.Security.Cryptography.X509Certificates.Tests.PfxIterationCountTests_X509Certificate2.Import_IterationCountLimitExceeded_ThrowsInAllottedTime #105609
Closed

jkotas merged commit cc17a46 into dotnet:mainSep 19, 2024

huoyaoyuan deleted the stubs-as-il branch September 19, 2024 16:18

BruceForstall mentioned this pull request Sep 20, 2024
Test build failure: "coreclr Common Pri1 Test Build AnyOS AnyCPU checked" CI job fails #108076
Closed

AndyAyersMS mentioned this pull request Sep 24, 2024
[Perf] Windows/x64: 9 Improvements on 9/19/2024 4:00:38 PM dotnet/perf-autofiling-issues#41692
Closed

huoyaoyuan mentioned this pull request Oct 18, 2024
Fix Delegate dispatch. dotnet/runtimelab#2721
Merged

github-actionsBot locked and limited conversation to collaborators Oct 20, 2024

huoyaoyuan added 4 commits July 11, 2024 21:03

Use direct SinglecastDelegateInvokeStub on windows x86
c06cc3f

Cleanup ifdefs
4845202

EmitDebugBreak is unused
faf25e7

endif format
09fcf2b

ghost added the area-VM-coreclr label Jul 11, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jul 11, 2024

huoyaoyuan added 2 commits July 11, 2024 21:52

Restore comment
19057f9

Fix JIT_InternalThrowFromHelper reference
157325b

This was referenced Jul 11, 2024
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
The job running on agent NetCore-Public ran longer than the maximum time #104044
Closed

jkotas changed the title ~~Cleanup some code under FEATURE_STUBS_AS_AL~~Cleanup some code under FEATURE_STUBS_AS_ILJul 12, 2024

jkotas reviewed Jul 12, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/i386/asmhelpers.asm Outdated

huoyaoyuan added 2 commits July 16, 2024 00:03

Use IL stub for Delegate.Invoke
c98be47

Remove SinglecastDelegateInvokeStub in asm
72fd2d6

build-analysisBot mentioned this pull request Jul 15, 2024
Test failure WindowsAlternateDataStreamOverwrite #83659
Closed

huoyaoyuan added 2 commits July 17, 2024 19:24

Fix method name and argument count
e60b3f1

Code quality
7f117aa

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/jitinterface.h Outdated

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stubmgr.cpp Outdated

jkotas reviewed Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stubmgr.cpp Outdated

Delete JIT_InternalThrow and CorInfoException
cd648fa

huoyaoyuan commented Jul 17, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/comdelegate.cpp Outdated

huoyaoyuan mentioned this pull request Jul 17, 2024
JIT unnecessary stack load/stores for tail jump with stack args involved #105031
Open

Apply the same codegen to ilc
b078f3a

build-analysisBot mentioned this pull request Jul 17, 2024
System.IO.Net5Compat.Tests and System.IO.Tests suddenly exiting with error 137 #100558
Closed

huoyaoyuan mentioned this pull request Jul 18, 2024
Some delegate invoke thunks fail to compile with where T : allows ref struct delegates #105029
Closed

huoyaoyuan mentioned this pull request Jul 18, 2024
JIT: potential GC hole with collectible code in delegate #105082
Open

jkotas mentioned this pull request Sep 18, 2024
Cleanup delegate-related code #107966
Merged

Apply suggestions from code review
8992882
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

build-analysisBot mentioned this pull request Sep 18, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

huoyaoyuan added 3 commits September 18, 2024 20:02

Merge branch 'main' into stubs-as-il
e06998c

Return Stub from GetInvokeMethodStub
c221eed

Delete NEWSTUB_FL_MULTICAST and dependents
1c640f8

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/dllimport.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/dllimport.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stublink.h Outdated

jkotas reviewed Sep 18, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/stublink.h Outdated

huoyaoyuan added 4 commits September 19, 2024 10:59

Rename
e39afa1

Renumber
eebbc01

Merge branch 'main'
c2cf515

Format
bc1a766

jkotas reviewed Sep 19, 2024
View reviewed changes

Comment threadsrc/coreclr/vm/method.hpp Outdated

jkotas added 2 commits September 18, 2024 22:15

Update src/coreclr/vm/method.hpp
ee674a3

Handle new stub in ILStubManager
fdd83eb

jkotas approved these changes Sep 19, 2024
View reviewed changes

build-analysisBot mentioned this pull request Sep 19, 2024
Test failure: System.Security.Cryptography.X509Certificates.Tests.PfxIterationCountTests_X509Certificate2.Import_IterationCountLimitExceeded_ThrowsInAllottedTime #105609
Closed

jkotas merged commit cc17a46 into dotnet:mainSep 19, 2024

huoyaoyuan deleted the stubs-as-il branch September 19, 2024 16:18

BruceForstall mentioned this pull request Sep 20, 2024
Test build failure: "coreclr Common Pri1 Test Build AnyOS AnyCPU checked" CI job fails #108076
Closed

AndyAyersMS mentioned this pull request Sep 24, 2024
[Perf] Windows/x64: 9 Improvements on 9/19/2024 4:00:38 PM dotnet/perf-autofiling-issues#41692
Closed

huoyaoyuan mentioned this pull request Oct 18, 2024
Fix Delegate dispatch. dotnet/runtimelab#2721
Merged

github-actionsBot locked and limited conversation to collaborators Oct 20, 2024

Uh oh!

Conversation

huoyaoyuan commented Jul 11, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas commented Jul 17, 2024

Uh oh!

Uh oh!

huoyaoyuan commented Jul 17, 2024

Uh oh!

jkotas commented Jul 18, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas commented Sep 19, 2024

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

jkotas commented Sep 19, 2024

Uh oh!

huoyaoyuan commented Sep 19, 2024

Uh oh!

jkotas commented Sep 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

huoyaoyuan commented Jul 11, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas commented Jul 17, 2024

Uh oh!

Uh oh!

huoyaoyuan commented Jul 17, 2024

Uh oh!

jkotas commented Jul 18, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkotas commented Sep 19, 2024

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

jkotas commented Sep 19, 2024

Uh oh!

huoyaoyuan commented Sep 19, 2024

Uh oh!

jkotas commented Sep 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

huoyaoyuan commented Jul 11, 2024•
edited
Loading

jkotas commented Jul 18, 2024•
edited
Loading

huoyaoyuan commented Jul 11, 2024•
edited
Loading

jkotas commented Jul 18, 2024•
edited
Loading

huoyaoyuan commented Jul 11, 2024•
edited
Loading

jkotas commented Jul 18, 2024•
edited
Loading

huoyaoyuan commented Jul 11, 2024•
edited
Loading