Extend usage of GC_ALLOC_ALIGN8 - #104781

Merged
noahfalk merged 1 commit into
dotnet:mainfrom
noahfalk:64_bit_alignment
Jul 13, 2024
Merged

Extend usage of GC_ALLOC_ALIGN8#104781
noahfalk merged 1 commit into
dotnet:mainfrom
noahfalk:64_bit_alignment

Conversation

@noahfalk

@noahfalknoahfalk commented Jul 12, 2024

Copy link
Copy Markdown
Member

In the past we added FEATURE_64BIT_ALIGNMENT to support 8 byte alignment requirements on ARM, but for performance we also like to 8 byte align double arrays on other architectures. The GC has a GC_ALLOC_ALIGN8 flag that does that but it was only being used in the ARM case and we had a more complicated workaround being used elsewhere. This change expands GC_ALLOC_ALIGN8 so it is supported on all architectures and converges all our aligned double arrays to use that approach.

This change is also present in #100356 but extracting it out in a separate PR to make it easy to get it reviewed and merged.

@Maoni0@jkotas@AaronRobinsonMSFT@davidwrighton

@ghostghost added the area-GC-coreclr label Jul 12, 2024
@noahfalk

noahfalk commented Jul 12, 2024

Copy link
Copy Markdown
MemberAuthor

fyi @chrisnas

@dotnet-policy-service

dotnet-policy-serviceBot commented Jul 12, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

@noahfalk

noahfalk commented Jul 12, 2024

Copy link
Copy Markdown
MemberAuthor

There is a CI failure in GC which looks like it may be caused by this change - I am investigating.

jkotas
jkotas reviewed Jul 12, 2024
View reviewed changes
Comment threadsrc/coreclr/gc/gcpriv.h
This was referenced Jul 12, 2024
Open
Closed
@noahfalk

noahfalk commented Jul 12, 2024

Copy link
Copy Markdown
MemberAuthor

Just to capture it for the future, this is the GC assert seen prior to when I added RESPECT_LARGE_ALIGNMENT. No claim that it is causal, just that the assert was present prior to defining RESPECT_LARGE_ALIGNMENT and did not reoccur once RESPECT_LARGE_ALIGMENT was defined.

Console log: 'System.Text.Json.Tests' from job 42ba0bbf-f0ef-4f63-949a-afbdfdbee1e5 workitem 79ac3492-77e3-4ba8-bf03-035a305e4d33 (windows.10.amd64.open.rt) executed on machine a001XFN running Windows-10-10.0.14393-SP0
...
C:\h\w\C4520AF1\w\A820090F\e>"C:\h\w\C4520AF1\p\dotnet.exe" exec --runtimeconfig System.Text.Json.Tests.runtimeconfig.json --depsfile System.Text.Json.Tests.deps.json xunit.console.dll System.Text.Json.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing Discovering: System.Text.Json.Tests (method display = ClassAndMethod, method display options = None)
Discovered: System.Text.Json.Tests (found 8609 of 8681 test cases)
Starting: System.Text.Json.Tests (parallel test collections = on [4 threads], stop on fail = off)
Assert failure(PID 9704 [0x000025e8], Thread: 1104 [0x0450]): new_current_total_committed_bookkeeping == current_total_committed_bookkeeping
CORECLR! WKS::gc_heap::verify_committed_bytes + 0x5A (0x71ac02aa)
CORECLR! WKS::gc_heap::plan_phase + 0x1F8B (0x71ab8c99)
CORECLR! WKS::gc_heap::gc1 + 0x155 (0x71aae971)
CORECLR! WKS::gc_heap::garbage_collect + 0x3E0 (0x71aae795)
CORECLR! WKS::GCHeap::GarbageCollectGeneration + 0x24C (0x71a9eb24)
CORECLR! WKS::gc_heap::trigger_gc_for_alloc + 0x40 (0x71abf5cc)
CORECLR! WKS::gc_heap::try_allocate_more_space + 0x12F (0x71abf7e4)
CORECLR! WKS::gc_heap::allocate_more_space + 0x14 (0x71aa3419)
CORECLR! WKS::GCHeap::Alloc + 0x185 (0x71a9dda5)
CORECLR! Alloc + 0x147 (0x7186ccda)
File: D:\a\_work\1\s\src\coreclr\gc\gc.cpp:47449
Image: C:\h\w\C4520AF1\p\dotnet.exe

@noahfalk

noahfalk commented Jul 12, 2024

Copy link
Copy Markdown
MemberAuthor

It appears that the bookkeeping assert is a previously known issue: #102706

@noahfalk
Extend usage of GC_ALLOC_ALIGN8
3a7c4ea
In the past we added FEATURE_64BIT_ALIGNMENT to support 8 byte alignment
requirements on ARM, but for performance we also like to 8 byte align
double arrays on other architectures. The GC has a GC_ALLOC_ALIGN8 flag
that does that but it was only being used in the ARM case and we had
a more complicated workaround being used elsewhere. This change expands
GC_ALLOC_ALIGN8 so it is supported on all architectures and converges
all our aligned double arrays to use that approach.
GC_ALLOC_ALIGN8 only implies that the initial allocation is 8 byte
aligned, not that it will stay aligned after relocation. On ARM it will
stay aligned because RESPECT_LARGE_ALIGNMENT is defined but
on other 32 bit architectures it is not guaranteed to stay aligned.
@jkotasjkotas mentioned this pull request Jul 13, 2024
Closed
@noahfalk
noahfalk merged commit 46338d5 into dotnet:mainJul 13, 2024
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 12, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes

Assignees

@noahfalknoahfalk

Labels

area-GC-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@noahfalk@jkotas@AaronRobinsonMSFT
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Extend usage of GC_ALLOC_ALIGN8 - #104781
Merged
noahfalk merged 1 commit into
dotnet:mainfrom 
noahfalk:64_bit_alignment
Jul 13, 2024
Merged
Extend usage of GC_ALLOC_ALIGN8#104781
noahfalk merged 1 commit into
dotnet:mainfrom 
noahfalk:64_bit_alignment
Conversation
@noahfalk
@noahfalknoahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

Member
In the past we added FEATURE_64BIT_ALIGNMENT to support 8 byte alignment requirements on ARM, but for performance we also like to 8 byte align double arrays on other architectures. The GC has a GC_ALLOC_ALIGN8 flag that does that but it was only being used in the ARM case and we had a more complicated workaround being used elsewhere. This change expands GC_ALLOC_ALIGN8 so it is supported on all architectures and converges all our aligned double arrays to use that approach.
This change is also present in #100356 but extracting it out in a separate PR to make it easy to get it reviewed and merged.
@Maoni0@jkotas@AaronRobinsonMSFT@davidwrighton
@ghostghost
added
the 
area-GC-coreclr

label
Jul 12, 2024
@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
fyi @chrisnas
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 12, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/gc

See info in area-owners.md if you want to be subscribed.
@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
There is a CI failure in GC which looks like it may be caused by this change - I am investigating.
jkotas
jkotas
reviewed
Jul 12, 2024
View reviewed changes
Comment threadsrc/coreclr/gc/gcpriv.h

This was referenced Jul 12, 2024

Open


Closed

@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
Just to capture it for the future, this is the GC assert seen prior to when I added RESPECT_LARGE_ALIGNMENT. No claim that it is causal, just that the assert was present prior to defining RESPECT_LARGE_ALIGNMENT and did not reoccur once RESPECT_LARGE_ALIGMENT was defined.
Console log: 'System.Text.Json.Tests' from job 42ba0bbf-f0ef-4f63-949a-afbdfdbee1e5 workitem 79ac3492-77e3-4ba8-bf03-035a305e4d33 (windows.10.amd64.open.rt) executed on machine a001XFN running Windows-10-10.0.14393-SP0
...
C:\h\w\C4520AF1\w\A820090F\e>"C:\h\w\C4520AF1\p\dotnet.exe" exec --runtimeconfig System.Text.Json.Tests.runtimeconfig.json --depsfile System.Text.Json.Tests.deps.json xunit.console.dll System.Text.Json.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing Discovering: System.Text.Json.Tests (method display = ClassAndMethod, method display options = None)
Discovered: System.Text.Json.Tests (found 8609 of 8681 test cases)
Starting: System.Text.Json.Tests (parallel test collections = on [4 threads], stop on fail = off)
Assert failure(PID 9704 [0x000025e8], Thread: 1104 [0x0450]): new_current_total_committed_bookkeeping == current_total_committed_bookkeeping
CORECLR! WKS::gc_heap::verify_committed_bytes + 0x5A (0x71ac02aa)
CORECLR! WKS::gc_heap::plan_phase + 0x1F8B (0x71ab8c99)
CORECLR! WKS::gc_heap::gc1 + 0x155 (0x71aae971)
CORECLR! WKS::gc_heap::garbage_collect + 0x3E0 (0x71aae795)
CORECLR! WKS::GCHeap::GarbageCollectGeneration + 0x24C (0x71a9eb24)
CORECLR! WKS::gc_heap::trigger_gc_for_alloc + 0x40 (0x71abf5cc)
CORECLR! WKS::gc_heap::try_allocate_more_space + 0x12F (0x71abf7e4)
CORECLR! WKS::gc_heap::allocate_more_space + 0x14 (0x71aa3419)
CORECLR! WKS::GCHeap::Alloc + 0x185 (0x71a9dda5)
CORECLR! Alloc + 0x147 (0x7186ccda)
File: D:\a\_work\1\s\src\coreclr\gc\gc.cpp:47449
Image: C:\h\w\C4520AF1\p\dotnet.exe

@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
It appears that the bookkeeping assert is a previously known issue: #102706
@noahfalk
Extend usage of GC_ALLOC_ALIGN8
3a7c4ea
In the past we added FEATURE_64BIT_ALIGNMENT to support 8 byte alignment
requirements on ARM, but for performance we also like to 8 byte align
double arrays on other architectures. The GC has a GC_ALLOC_ALIGN8 flag
that does that but it was only being used in the ARM case and we had
a more complicated workaround being used elsewhere. This change expands
GC_ALLOC_ALIGN8 so it is supported on all architectures and converges
all our aligned double arrays to use that approach.
GC_ALLOC_ALIGN8 only implies that the initial allocation is 8 byte
aligned, not that it will stay aligned after relocation. On ARM it will
stay aligned because RESPECT_LARGE_ALIGNMENT is defined but
on other 32 bit architectures it is not guaranteed to stay aligned.
@jkotasjkotas
mentioned this pull request
Jul 13, 2024

Closed

@noahfalk
noahfalk
merged commit 46338d5
into
dotnet:mainJul 13, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 12, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes

Assignees

@noahfalknoahfalk

Labels

area-GC-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@noahfalk@jkotas@AaronRobinsonMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Extend usage of GC_ALLOC_ALIGN8 - #104781
Merged
noahfalk merged 1 commit into
dotnet:mainfrom 
noahfalk:64_bit_alignment
Jul 13, 2024
Merged
Extend usage of GC_ALLOC_ALIGN8#104781
noahfalk merged 1 commit into
dotnet:mainfrom 
noahfalk:64_bit_alignment
Conversation
@noahfalk
@noahfalknoahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

Member
In the past we added FEATURE_64BIT_ALIGNMENT to support 8 byte alignment requirements on ARM, but for performance we also like to 8 byte align double arrays on other architectures. The GC has a GC_ALLOC_ALIGN8 flag that does that but it was only being used in the ARM case and we had a more complicated workaround being used elsewhere. This change expands GC_ALLOC_ALIGN8 so it is supported on all architectures and converges all our aligned double arrays to use that approach.
This change is also present in #100356 but extracting it out in a separate PR to make it easy to get it reviewed and merged.
@Maoni0@jkotas@AaronRobinsonMSFT@davidwrighton
@ghostghost
added
the 
area-GC-coreclr

label
Jul 12, 2024
@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
fyi @chrisnas
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 12, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/gc

See info in area-owners.md if you want to be subscribed.
@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
There is a CI failure in GC which looks like it may be caused by this change - I am investigating.
jkotas
jkotas
reviewed
Jul 12, 2024
View reviewed changes
Comment threadsrc/coreclr/gc/gcpriv.h

This was referenced Jul 12, 2024

Open


Closed

@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
Just to capture it for the future, this is the GC assert seen prior to when I added RESPECT_LARGE_ALIGNMENT. No claim that it is causal, just that the assert was present prior to defining RESPECT_LARGE_ALIGNMENT and did not reoccur once RESPECT_LARGE_ALIGMENT was defined.
Console log: 'System.Text.Json.Tests' from job 42ba0bbf-f0ef-4f63-949a-afbdfdbee1e5 workitem 79ac3492-77e3-4ba8-bf03-035a305e4d33 (windows.10.amd64.open.rt) executed on machine a001XFN running Windows-10-10.0.14393-SP0
...
C:\h\w\C4520AF1\w\A820090F\e>"C:\h\w\C4520AF1\p\dotnet.exe" exec --runtimeconfig System.Text.Json.Tests.runtimeconfig.json --depsfile System.Text.Json.Tests.deps.json xunit.console.dll System.Text.Json.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing Discovering: System.Text.Json.Tests (method display = ClassAndMethod, method display options = None)
Discovered: System.Text.Json.Tests (found 8609 of 8681 test cases)
Starting: System.Text.Json.Tests (parallel test collections = on [4 threads], stop on fail = off)
Assert failure(PID 9704 [0x000025e8], Thread: 1104 [0x0450]): new_current_total_committed_bookkeeping == current_total_committed_bookkeeping
CORECLR! WKS::gc_heap::verify_committed_bytes + 0x5A (0x71ac02aa)
CORECLR! WKS::gc_heap::plan_phase + 0x1F8B (0x71ab8c99)
CORECLR! WKS::gc_heap::gc1 + 0x155 (0x71aae971)
CORECLR! WKS::gc_heap::garbage_collect + 0x3E0 (0x71aae795)
CORECLR! WKS::GCHeap::GarbageCollectGeneration + 0x24C (0x71a9eb24)
CORECLR! WKS::gc_heap::trigger_gc_for_alloc + 0x40 (0x71abf5cc)
CORECLR! WKS::gc_heap::try_allocate_more_space + 0x12F (0x71abf7e4)
CORECLR! WKS::gc_heap::allocate_more_space + 0x14 (0x71aa3419)
CORECLR! WKS::GCHeap::Alloc + 0x185 (0x71a9dda5)
CORECLR! Alloc + 0x147 (0x7186ccda)
File: D:\a\_work\1\s\src\coreclr\gc\gc.cpp:47449
Image: C:\h\w\C4520AF1\p\dotnet.exe

@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
It appears that the bookkeeping assert is a previously known issue: #102706
@noahfalk
Extend usage of GC_ALLOC_ALIGN8
3a7c4ea
In the past we added FEATURE_64BIT_ALIGNMENT to support 8 byte alignment
requirements on ARM, but for performance we also like to 8 byte align
double arrays on other architectures. The GC has a GC_ALLOC_ALIGN8 flag
that does that but it was only being used in the ARM case and we had
a more complicated workaround being used elsewhere. This change expands
GC_ALLOC_ALIGN8 so it is supported on all architectures and converges
all our aligned double arrays to use that approach.
GC_ALLOC_ALIGN8 only implies that the initial allocation is 8 byte
aligned, not that it will stay aligned after relocation. On ARM it will
stay aligned because RESPECT_LARGE_ALIGNMENT is defined but
on other 32 bit architectures it is not guaranteed to stay aligned.
@jkotasjkotas
mentioned this pull request
Jul 13, 2024

Closed

@noahfalk
noahfalk
merged commit 46338d5
into
dotnet:mainJul 13, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 12, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes

Assignees

@noahfalknoahfalk

Labels

area-GC-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@noahfalk@jkotas@AaronRobinsonMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Extend usage of GC_ALLOC_ALIGN8 - #104781
Merged
noahfalk merged 1 commit into
dotnet:mainfrom 
noahfalk:64_bit_alignment
Jul 13, 2024
Merged
Extend usage of GC_ALLOC_ALIGN8#104781
noahfalk merged 1 commit into
dotnet:mainfrom 
noahfalk:64_bit_alignment
Conversation
@noahfalk
@noahfalknoahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

Member
In the past we added FEATURE_64BIT_ALIGNMENT to support 8 byte alignment requirements on ARM, but for performance we also like to 8 byte align double arrays on other architectures. The GC has a GC_ALLOC_ALIGN8 flag that does that but it was only being used in the ARM case and we had a more complicated workaround being used elsewhere. This change expands GC_ALLOC_ALIGN8 so it is supported on all architectures and converges all our aligned double arrays to use that approach.
This change is also present in #100356 but extracting it out in a separate PR to make it easy to get it reviewed and merged.
@Maoni0@jkotas@AaronRobinsonMSFT@davidwrighton
@ghostghost
added
the 
area-GC-coreclr

label
Jul 12, 2024
@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
fyi @chrisnas
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 12, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/gc

See info in area-owners.md if you want to be subscribed.
@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
There is a CI failure in GC which looks like it may be caused by this change - I am investigating.
jkotas
jkotas
reviewed
Jul 12, 2024
View reviewed changes
Comment threadsrc/coreclr/gc/gcpriv.h

This was referenced Jul 12, 2024

Open


Closed

@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
Just to capture it for the future, this is the GC assert seen prior to when I added RESPECT_LARGE_ALIGNMENT. No claim that it is causal, just that the assert was present prior to defining RESPECT_LARGE_ALIGNMENT and did not reoccur once RESPECT_LARGE_ALIGMENT was defined.
Console log: 'System.Text.Json.Tests' from job 42ba0bbf-f0ef-4f63-949a-afbdfdbee1e5 workitem 79ac3492-77e3-4ba8-bf03-035a305e4d33 (windows.10.amd64.open.rt) executed on machine a001XFN running Windows-10-10.0.14393-SP0
...
C:\h\w\C4520AF1\w\A820090F\e>"C:\h\w\C4520AF1\p\dotnet.exe" exec --runtimeconfig System.Text.Json.Tests.runtimeconfig.json --depsfile System.Text.Json.Tests.deps.json xunit.console.dll System.Text.Json.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing Discovering: System.Text.Json.Tests (method display = ClassAndMethod, method display options = None)
Discovered: System.Text.Json.Tests (found 8609 of 8681 test cases)
Starting: System.Text.Json.Tests (parallel test collections = on [4 threads], stop on fail = off)
Assert failure(PID 9704 [0x000025e8], Thread: 1104 [0x0450]): new_current_total_committed_bookkeeping == current_total_committed_bookkeeping
CORECLR! WKS::gc_heap::verify_committed_bytes + 0x5A (0x71ac02aa)
CORECLR! WKS::gc_heap::plan_phase + 0x1F8B (0x71ab8c99)
CORECLR! WKS::gc_heap::gc1 + 0x155 (0x71aae971)
CORECLR! WKS::gc_heap::garbage_collect + 0x3E0 (0x71aae795)
CORECLR! WKS::GCHeap::GarbageCollectGeneration + 0x24C (0x71a9eb24)
CORECLR! WKS::gc_heap::trigger_gc_for_alloc + 0x40 (0x71abf5cc)
CORECLR! WKS::gc_heap::try_allocate_more_space + 0x12F (0x71abf7e4)
CORECLR! WKS::gc_heap::allocate_more_space + 0x14 (0x71aa3419)
CORECLR! WKS::GCHeap::Alloc + 0x185 (0x71a9dda5)
CORECLR! Alloc + 0x147 (0x7186ccda)
File: D:\a\_work\1\s\src\coreclr\gc\gc.cpp:47449
Image: C:\h\w\C4520AF1\p\dotnet.exe

@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
It appears that the bookkeeping assert is a previously known issue: #102706
@noahfalk
Extend usage of GC_ALLOC_ALIGN8
3a7c4ea
In the past we added FEATURE_64BIT_ALIGNMENT to support 8 byte alignment
requirements on ARM, but for performance we also like to 8 byte align
double arrays on other architectures. The GC has a GC_ALLOC_ALIGN8 flag
that does that but it was only being used in the ARM case and we had
a more complicated workaround being used elsewhere. This change expands
GC_ALLOC_ALIGN8 so it is supported on all architectures and converges
all our aligned double arrays to use that approach.
GC_ALLOC_ALIGN8 only implies that the initial allocation is 8 byte
aligned, not that it will stay aligned after relocation. On ARM it will
stay aligned because RESPECT_LARGE_ALIGNMENT is defined but
on other 32 bit architectures it is not guaranteed to stay aligned.
@jkotasjkotas
mentioned this pull request
Jul 13, 2024

Closed

@noahfalk
noahfalk
merged commit 46338d5
into
dotnet:mainJul 13, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 12, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes

Assignees

@noahfalknoahfalk

Labels

area-GC-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@noahfalk@jkotas@AaronRobinsonMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Extend usage of GC_ALLOC_ALIGN8 - #104781
Merged
noahfalk merged 1 commit into
dotnet:mainfrom 
noahfalk:64_bit_alignment
Jul 13, 2024
Merged
Extend usage of GC_ALLOC_ALIGN8#104781
noahfalk merged 1 commit into
dotnet:mainfrom 
noahfalk:64_bit_alignment
Conversation
@noahfalk
@noahfalknoahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

Member
In the past we added FEATURE_64BIT_ALIGNMENT to support 8 byte alignment requirements on ARM, but for performance we also like to 8 byte align double arrays on other architectures. The GC has a GC_ALLOC_ALIGN8 flag that does that but it was only being used in the ARM case and we had a more complicated workaround being used elsewhere. This change expands GC_ALLOC_ALIGN8 so it is supported on all architectures and converges all our aligned double arrays to use that approach.
This change is also present in #100356 but extracting it out in a separate PR to make it easy to get it reviewed and merged.
@Maoni0@jkotas@AaronRobinsonMSFT@davidwrighton
@ghostghost
added
the 
area-GC-coreclr

label
Jul 12, 2024
@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
fyi @chrisnas
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 12, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/gc

See info in area-owners.md if you want to be subscribed.
@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
There is a CI failure in GC which looks like it may be caused by this change - I am investigating.
jkotas
jkotas
reviewed
Jul 12, 2024
View reviewed changes
Comment threadsrc/coreclr/gc/gcpriv.h

This was referenced Jul 12, 2024

Open


Closed

@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
Just to capture it for the future, this is the GC assert seen prior to when I added RESPECT_LARGE_ALIGNMENT. No claim that it is causal, just that the assert was present prior to defining RESPECT_LARGE_ALIGNMENT and did not reoccur once RESPECT_LARGE_ALIGMENT was defined.
Console log: 'System.Text.Json.Tests' from job 42ba0bbf-f0ef-4f63-949a-afbdfdbee1e5 workitem 79ac3492-77e3-4ba8-bf03-035a305e4d33 (windows.10.amd64.open.rt) executed on machine a001XFN running Windows-10-10.0.14393-SP0
...
C:\h\w\C4520AF1\w\A820090F\e>"C:\h\w\C4520AF1\p\dotnet.exe" exec --runtimeconfig System.Text.Json.Tests.runtimeconfig.json --depsfile System.Text.Json.Tests.deps.json xunit.console.dll System.Text.Json.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing Discovering: System.Text.Json.Tests (method display = ClassAndMethod, method display options = None)
Discovered: System.Text.Json.Tests (found 8609 of 8681 test cases)
Starting: System.Text.Json.Tests (parallel test collections = on [4 threads], stop on fail = off)
Assert failure(PID 9704 [0x000025e8], Thread: 1104 [0x0450]): new_current_total_committed_bookkeeping == current_total_committed_bookkeeping
CORECLR! WKS::gc_heap::verify_committed_bytes + 0x5A (0x71ac02aa)
CORECLR! WKS::gc_heap::plan_phase + 0x1F8B (0x71ab8c99)
CORECLR! WKS::gc_heap::gc1 + 0x155 (0x71aae971)
CORECLR! WKS::gc_heap::garbage_collect + 0x3E0 (0x71aae795)
CORECLR! WKS::GCHeap::GarbageCollectGeneration + 0x24C (0x71a9eb24)
CORECLR! WKS::gc_heap::trigger_gc_for_alloc + 0x40 (0x71abf5cc)
CORECLR! WKS::gc_heap::try_allocate_more_space + 0x12F (0x71abf7e4)
CORECLR! WKS::gc_heap::allocate_more_space + 0x14 (0x71aa3419)
CORECLR! WKS::GCHeap::Alloc + 0x185 (0x71a9dda5)
CORECLR! Alloc + 0x147 (0x7186ccda)
File: D:\a\_work\1\s\src\coreclr\gc\gc.cpp:47449
Image: C:\h\w\C4520AF1\p\dotnet.exe

@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
It appears that the bookkeeping assert is a previously known issue: #102706
@noahfalk
Extend usage of GC_ALLOC_ALIGN8
3a7c4ea
In the past we added FEATURE_64BIT_ALIGNMENT to support 8 byte alignment
requirements on ARM, but for performance we also like to 8 byte align
double arrays on other architectures. The GC has a GC_ALLOC_ALIGN8 flag
that does that but it was only being used in the ARM case and we had
a more complicated workaround being used elsewhere. This change expands
GC_ALLOC_ALIGN8 so it is supported on all architectures and converges
all our aligned double arrays to use that approach.
GC_ALLOC_ALIGN8 only implies that the initial allocation is 8 byte
aligned, not that it will stay aligned after relocation. On ARM it will
stay aligned because RESPECT_LARGE_ALIGNMENT is defined but
on other 32 bit architectures it is not guaranteed to stay aligned.
@jkotasjkotas
mentioned this pull request
Jul 13, 2024

Closed

@noahfalk
noahfalk
merged commit 46338d5
into
dotnet:mainJul 13, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 12, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes

Assignees

@noahfalknoahfalk

Labels

area-GC-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@noahfalk@jkotas@AaronRobinsonMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Extend usage of GC_ALLOC_ALIGN8 - #104781
Merged
noahfalk merged 1 commit into
dotnet:mainfrom 
noahfalk:64_bit_alignment
Jul 13, 2024
Merged
Extend usage of GC_ALLOC_ALIGN8#104781
noahfalk merged 1 commit into
dotnet:mainfrom 
noahfalk:64_bit_alignment
Conversation
@noahfalk
@noahfalknoahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

Member
In the past we added FEATURE_64BIT_ALIGNMENT to support 8 byte alignment requirements on ARM, but for performance we also like to 8 byte align double arrays on other architectures. The GC has a GC_ALLOC_ALIGN8 flag that does that but it was only being used in the ARM case and we had a more complicated workaround being used elsewhere. This change expands GC_ALLOC_ALIGN8 so it is supported on all architectures and converges all our aligned double arrays to use that approach.
This change is also present in #100356 but extracting it out in a separate PR to make it easy to get it reviewed and merged.
@Maoni0@jkotas@AaronRobinsonMSFT@davidwrighton
@ghostghost
added
the 
area-GC-coreclr

label
Jul 12, 2024
@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
fyi @chrisnas
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 12, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/gc

See info in area-owners.md if you want to be subscribed.
@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
There is a CI failure in GC which looks like it may be caused by this change - I am investigating.
jkotas
jkotas
reviewed
Jul 12, 2024
View reviewed changes
Comment threadsrc/coreclr/gc/gcpriv.h

This was referenced Jul 12, 2024

Open


Closed

@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
Just to capture it for the future, this is the GC assert seen prior to when I added RESPECT_LARGE_ALIGNMENT. No claim that it is causal, just that the assert was present prior to defining RESPECT_LARGE_ALIGNMENT and did not reoccur once RESPECT_LARGE_ALIGMENT was defined.
Console log: 'System.Text.Json.Tests' from job 42ba0bbf-f0ef-4f63-949a-afbdfdbee1e5 workitem 79ac3492-77e3-4ba8-bf03-035a305e4d33 (windows.10.amd64.open.rt) executed on machine a001XFN running Windows-10-10.0.14393-SP0
...
C:\h\w\C4520AF1\w\A820090F\e>"C:\h\w\C4520AF1\p\dotnet.exe" exec --runtimeconfig System.Text.Json.Tests.runtimeconfig.json --depsfile System.Text.Json.Tests.deps.json xunit.console.dll System.Text.Json.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing Discovering: System.Text.Json.Tests (method display = ClassAndMethod, method display options = None)
Discovered: System.Text.Json.Tests (found 8609 of 8681 test cases)
Starting: System.Text.Json.Tests (parallel test collections = on [4 threads], stop on fail = off)
Assert failure(PID 9704 [0x000025e8], Thread: 1104 [0x0450]): new_current_total_committed_bookkeeping == current_total_committed_bookkeeping
CORECLR! WKS::gc_heap::verify_committed_bytes + 0x5A (0x71ac02aa)
CORECLR! WKS::gc_heap::plan_phase + 0x1F8B (0x71ab8c99)
CORECLR! WKS::gc_heap::gc1 + 0x155 (0x71aae971)
CORECLR! WKS::gc_heap::garbage_collect + 0x3E0 (0x71aae795)
CORECLR! WKS::GCHeap::GarbageCollectGeneration + 0x24C (0x71a9eb24)
CORECLR! WKS::gc_heap::trigger_gc_for_alloc + 0x40 (0x71abf5cc)
CORECLR! WKS::gc_heap::try_allocate_more_space + 0x12F (0x71abf7e4)
CORECLR! WKS::gc_heap::allocate_more_space + 0x14 (0x71aa3419)
CORECLR! WKS::GCHeap::Alloc + 0x185 (0x71a9dda5)
CORECLR! Alloc + 0x147 (0x7186ccda)
File: D:\a\_work\1\s\src\coreclr\gc\gc.cpp:47449
Image: C:\h\w\C4520AF1\p\dotnet.exe

@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
It appears that the bookkeeping assert is a previously known issue: #102706
@noahfalk
Extend usage of GC_ALLOC_ALIGN8
3a7c4ea
In the past we added FEATURE_64BIT_ALIGNMENT to support 8 byte alignment
requirements on ARM, but for performance we also like to 8 byte align
double arrays on other architectures. The GC has a GC_ALLOC_ALIGN8 flag
that does that but it was only being used in the ARM case and we had
a more complicated workaround being used elsewhere. This change expands
GC_ALLOC_ALIGN8 so it is supported on all architectures and converges
all our aligned double arrays to use that approach.
GC_ALLOC_ALIGN8 only implies that the initial allocation is 8 byte
aligned, not that it will stay aligned after relocation. On ARM it will
stay aligned because RESPECT_LARGE_ALIGNMENT is defined but
on other 32 bit architectures it is not guaranteed to stay aligned.
@jkotasjkotas
mentioned this pull request
Jul 13, 2024

Closed

@noahfalk
noahfalk
merged commit 46338d5
into
dotnet:mainJul 13, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 12, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes

Assignees

@noahfalknoahfalk

Labels

area-GC-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@noahfalk@jkotas@AaronRobinsonMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Extend usage of GC_ALLOC_ALIGN8 - #104781
Merged
noahfalk merged 1 commit into
dotnet:mainfrom 
noahfalk:64_bit_alignment
Jul 13, 2024
Merged
Extend usage of GC_ALLOC_ALIGN8#104781
noahfalk merged 1 commit into
dotnet:mainfrom 
noahfalk:64_bit_alignment
Conversation
@noahfalk
@noahfalknoahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

Member
In the past we added FEATURE_64BIT_ALIGNMENT to support 8 byte alignment requirements on ARM, but for performance we also like to 8 byte align double arrays on other architectures. The GC has a GC_ALLOC_ALIGN8 flag that does that but it was only being used in the ARM case and we had a more complicated workaround being used elsewhere. This change expands GC_ALLOC_ALIGN8 so it is supported on all architectures and converges all our aligned double arrays to use that approach.
This change is also present in #100356 but extracting it out in a separate PR to make it easy to get it reviewed and merged.
@Maoni0@jkotas@AaronRobinsonMSFT@davidwrighton
@ghostghost
added
the 
area-GC-coreclr

label
Jul 12, 2024
@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
fyi @chrisnas
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 12, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/gc

See info in area-owners.md if you want to be subscribed.
@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
There is a CI failure in GC which looks like it may be caused by this change - I am investigating.
jkotas
jkotas
reviewed
Jul 12, 2024
View reviewed changes
Comment threadsrc/coreclr/gc/gcpriv.h

This was referenced Jul 12, 2024

Open


Closed

@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
Just to capture it for the future, this is the GC assert seen prior to when I added RESPECT_LARGE_ALIGNMENT. No claim that it is causal, just that the assert was present prior to defining RESPECT_LARGE_ALIGNMENT and did not reoccur once RESPECT_LARGE_ALIGMENT was defined.
Console log: 'System.Text.Json.Tests' from job 42ba0bbf-f0ef-4f63-949a-afbdfdbee1e5 workitem 79ac3492-77e3-4ba8-bf03-035a305e4d33 (windows.10.amd64.open.rt) executed on machine a001XFN running Windows-10-10.0.14393-SP0
...
C:\h\w\C4520AF1\w\A820090F\e>"C:\h\w\C4520AF1\p\dotnet.exe" exec --runtimeconfig System.Text.Json.Tests.runtimeconfig.json --depsfile System.Text.Json.Tests.deps.json xunit.console.dll System.Text.Json.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing Discovering: System.Text.Json.Tests (method display = ClassAndMethod, method display options = None)
Discovered: System.Text.Json.Tests (found 8609 of 8681 test cases)
Starting: System.Text.Json.Tests (parallel test collections = on [4 threads], stop on fail = off)
Assert failure(PID 9704 [0x000025e8], Thread: 1104 [0x0450]): new_current_total_committed_bookkeeping == current_total_committed_bookkeeping
CORECLR! WKS::gc_heap::verify_committed_bytes + 0x5A (0x71ac02aa)
CORECLR! WKS::gc_heap::plan_phase + 0x1F8B (0x71ab8c99)
CORECLR! WKS::gc_heap::gc1 + 0x155 (0x71aae971)
CORECLR! WKS::gc_heap::garbage_collect + 0x3E0 (0x71aae795)
CORECLR! WKS::GCHeap::GarbageCollectGeneration + 0x24C (0x71a9eb24)
CORECLR! WKS::gc_heap::trigger_gc_for_alloc + 0x40 (0x71abf5cc)
CORECLR! WKS::gc_heap::try_allocate_more_space + 0x12F (0x71abf7e4)
CORECLR! WKS::gc_heap::allocate_more_space + 0x14 (0x71aa3419)
CORECLR! WKS::GCHeap::Alloc + 0x185 (0x71a9dda5)
CORECLR! Alloc + 0x147 (0x7186ccda)
File: D:\a\_work\1\s\src\coreclr\gc\gc.cpp:47449
Image: C:\h\w\C4520AF1\p\dotnet.exe

@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
It appears that the bookkeeping assert is a previously known issue: #102706
@noahfalk
Extend usage of GC_ALLOC_ALIGN8
3a7c4ea
In the past we added FEATURE_64BIT_ALIGNMENT to support 8 byte alignment
requirements on ARM, but for performance we also like to 8 byte align
double arrays on other architectures. The GC has a GC_ALLOC_ALIGN8 flag
that does that but it was only being used in the ARM case and we had
a more complicated workaround being used elsewhere. This change expands
GC_ALLOC_ALIGN8 so it is supported on all architectures and converges
all our aligned double arrays to use that approach.
GC_ALLOC_ALIGN8 only implies that the initial allocation is 8 byte
aligned, not that it will stay aligned after relocation. On ARM it will
stay aligned because RESPECT_LARGE_ALIGNMENT is defined but
on other 32 bit architectures it is not guaranteed to stay aligned.
@jkotasjkotas
mentioned this pull request
Jul 13, 2024

Closed

@noahfalk
noahfalk
merged commit 46338d5
into
dotnet:mainJul 13, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 12, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes

Assignees

@noahfalknoahfalk

Labels

area-GC-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@noahfalk@jkotas@AaronRobinsonMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Extend usage of GC_ALLOC_ALIGN8 - #104781
Merged
noahfalk merged 1 commit into
dotnet:mainfrom 
noahfalk:64_bit_alignment
Jul 13, 2024
Merged
Extend usage of GC_ALLOC_ALIGN8#104781
noahfalk merged 1 commit into
dotnet:mainfrom 
noahfalk:64_bit_alignment
Conversation
@noahfalk
@noahfalknoahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

Member
In the past we added FEATURE_64BIT_ALIGNMENT to support 8 byte alignment requirements on ARM, but for performance we also like to 8 byte align double arrays on other architectures. The GC has a GC_ALLOC_ALIGN8 flag that does that but it was only being used in the ARM case and we had a more complicated workaround being used elsewhere. This change expands GC_ALLOC_ALIGN8 so it is supported on all architectures and converges all our aligned double arrays to use that approach.
This change is also present in #100356 but extracting it out in a separate PR to make it easy to get it reviewed and merged.
@Maoni0@jkotas@AaronRobinsonMSFT@davidwrighton
@ghostghost
added
the 
area-GC-coreclr

label
Jul 12, 2024
@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
fyi @chrisnas
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 12, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/gc

See info in area-owners.md if you want to be subscribed.
@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
There is a CI failure in GC which looks like it may be caused by this change - I am investigating.
jkotas
jkotas
reviewed
Jul 12, 2024
View reviewed changes
Comment threadsrc/coreclr/gc/gcpriv.h

This was referenced Jul 12, 2024

Open


Closed

@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
Just to capture it for the future, this is the GC assert seen prior to when I added RESPECT_LARGE_ALIGNMENT. No claim that it is causal, just that the assert was present prior to defining RESPECT_LARGE_ALIGNMENT and did not reoccur once RESPECT_LARGE_ALIGMENT was defined.
Console log: 'System.Text.Json.Tests' from job 42ba0bbf-f0ef-4f63-949a-afbdfdbee1e5 workitem 79ac3492-77e3-4ba8-bf03-035a305e4d33 (windows.10.amd64.open.rt) executed on machine a001XFN running Windows-10-10.0.14393-SP0
...
C:\h\w\C4520AF1\w\A820090F\e>"C:\h\w\C4520AF1\p\dotnet.exe" exec --runtimeconfig System.Text.Json.Tests.runtimeconfig.json --depsfile System.Text.Json.Tests.deps.json xunit.console.dll System.Text.Json.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing Discovering: System.Text.Json.Tests (method display = ClassAndMethod, method display options = None)
Discovered: System.Text.Json.Tests (found 8609 of 8681 test cases)
Starting: System.Text.Json.Tests (parallel test collections = on [4 threads], stop on fail = off)
Assert failure(PID 9704 [0x000025e8], Thread: 1104 [0x0450]): new_current_total_committed_bookkeeping == current_total_committed_bookkeeping
CORECLR! WKS::gc_heap::verify_committed_bytes + 0x5A (0x71ac02aa)
CORECLR! WKS::gc_heap::plan_phase + 0x1F8B (0x71ab8c99)
CORECLR! WKS::gc_heap::gc1 + 0x155 (0x71aae971)
CORECLR! WKS::gc_heap::garbage_collect + 0x3E0 (0x71aae795)
CORECLR! WKS::GCHeap::GarbageCollectGeneration + 0x24C (0x71a9eb24)
CORECLR! WKS::gc_heap::trigger_gc_for_alloc + 0x40 (0x71abf5cc)
CORECLR! WKS::gc_heap::try_allocate_more_space + 0x12F (0x71abf7e4)
CORECLR! WKS::gc_heap::allocate_more_space + 0x14 (0x71aa3419)
CORECLR! WKS::GCHeap::Alloc + 0x185 (0x71a9dda5)
CORECLR! Alloc + 0x147 (0x7186ccda)
File: D:\a\_work\1\s\src\coreclr\gc\gc.cpp:47449
Image: C:\h\w\C4520AF1\p\dotnet.exe

@noahfalk
noahfalk
commented
Jul 12, 2024

Copy link


Copy Markdown

MemberAuthor
It appears that the bookkeeping assert is a previously known issue: #102706
@noahfalk
Extend usage of GC_ALLOC_ALIGN8
3a7c4ea
In the past we added FEATURE_64BIT_ALIGNMENT to support 8 byte alignment
requirements on ARM, but for performance we also like to 8 byte align
double arrays on other architectures. The GC has a GC_ALLOC_ALIGN8 flag
that does that but it was only being used in the ARM case and we had
a more complicated workaround being used elsewhere. This change expands
GC_ALLOC_ALIGN8 so it is supported on all architectures and converges
all our aligned double arrays to use that approach.
GC_ALLOC_ALIGN8 only implies that the initial allocation is 8 byte
aligned, not that it will stay aligned after relocation. On ARM it will
stay aligned because RESPECT_LARGE_ALIGNMENT is defined but
on other 32 bit architectures it is not guaranteed to stay aligned.
@jkotasjkotas
mentioned this pull request
Jul 13, 2024

Closed

@noahfalk
noahfalk
merged commit 46338d5
into
dotnet:mainJul 13, 2024
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 12, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas approved these changes
@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes

Assignees

@noahfalknoahfalk

Labels

area-GC-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@noahfalk@jkotas@AaronRobinsonMSFT