Add ee_alloc_context (NativeAOT) by noahfalk · Pull Request #104851 · dotnet/runtime

noahfalk · 2024-07-13T07:58:04Z

This change is some preparatory refactoring for the randomized allocation sampling feature. We need to add more state onto allocation context but we don't want to do a breaking change of the GC interface. The new state only needs to be visible to the EE but we want it physically near the existing alloc context state for good cache locality. To accomplish this we created a new ee_alloc_context struct which contains an instance of gc_alloc_context within it.

The new field ee_alloc_context::combined_limit should be used by fast allocation helpers to determine when to go down the slow path. Most of the time combined_limit has the same value as alloc_limit, but periodically we need to emit an allocation sampling event on an object that is somewhere in the middle of an AC. Using combined_limit rather than alloc_limit as the slow path trigger allows us to keep all the sampling event logic in the slow path.

There is another PR for CoreCLR making the same change: #104849

jkotas · 2024-07-13T17:05:50Z

In a future PR we will add a field called combined_limit

I think you can add it in this PR. Adding the extra field is going to touch a lot of the same lines as this PR.

jkotas · 2024-07-13T17:13:16Z

(Also, same comment as #104851 (comment).)

noahfalk · 2024-07-19T01:14:49Z

@jkotas @MichalStrehovsky - I've applied the feedback from the CoreCLR issue to this one as well. Is anything else needed before you can signoff?

jkotas · 2024-07-29T01:04:10Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-07-29T01:04:19Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-07-29T16:33:58Z

nativeaot-outerloop (Build windows-x64 Release NativeAOT_Checked timeouts look like infrastructure issues, but they do not go away with reruns. Either the Helix queues are overloaded, or there is a bug that makes the tests run a lot slower.

jkotas

Looks good to me otherwise

noahfalk · 2024-07-30T10:25:35Z

I've updated for the feedback so far. Everything is addressed except NativeAOT SOS which has to be handled out-of-band. Looking at the time I think I may need to call it quits on this for .NET 9 and instead treat it as .NET 10 on a slower cadence. At this point I don't think I have more time available right now to do a staged checkin, revalidate testing after the ongoing changes, and continue to have time in reserve to respond to potential post-checkin issues.

This change is some preparatory refactoring for the randomized allocation sampling feature. We need to add more state onto allocation context but we don't want to do a breaking change of the GC interface. The new state only needs to be visible to the EE but we want it physically near the existing alloc context state for good cache locality. To accomplish this we created a new ee_alloc_context struct which contains an instance of gc_alloc_context within it. The new ee_alloc_context::combined_limit should be used by fast allocation helpers to determine when to go down the slow path. Most of the time combined_limit has the same value as alloc_limit, but periodically we need to emit an allocation sampling event on an object that is somewhere in the middle of an AC. Using combined_limit rather than alloc_limit as the slow path trigger allows us to keep all the sampling event logic in the slow path.

- removed unnecessary UpdateCombinedLimit() in thread detach - updated comment for workaround on 96081 - swapped to updating combined_limit inside GcEnumAllocContexts() instead of in RestartEE()

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

noahfalk · 2024-07-13T07:58:04Z

This change is some preparatory refactoring for the randomized allocation sampling feature. We need to add more state onto allocation context but we don't want to do a breaking change of the GC interface. The new state only needs to be visible to the EE but we want it physically near the existing alloc context state for good cache locality. To accomplish this we created a new ee_alloc_context struct which contains an instance of gc_alloc_context within it.

The new field ee_alloc_context::combined_limit should be used by fast allocation helpers to determine when to go down the slow path. Most of the time combined_limit has the same value as alloc_limit, but periodically we need to emit an allocation sampling event on an object that is somewhere in the middle of an AC. Using combined_limit rather than alloc_limit as the slow path trigger allows us to keep all the sampling event logic in the slow path.

There is another PR for CoreCLR making the same change: #104849

jkotas · 2024-07-13T17:05:50Z

In a future PR we will add a field called combined_limit

I think you can add it in this PR. Adding the extra field is going to touch a lot of the same lines as this PR.

jkotas · 2024-07-13T17:13:16Z

(Also, same comment as #104851 (comment).)

noahfalk · 2024-07-19T01:14:49Z

@jkotas @MichalStrehovsky - I've applied the feedback from the CoreCLR issue to this one as well. Is anything else needed before you can signoff?

jkotas · 2024-07-29T01:04:10Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-07-29T01:04:19Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-07-29T16:33:58Z

nativeaot-outerloop (Build windows-x64 Release NativeAOT_Checked timeouts look like infrastructure issues, but they do not go away with reruns. Either the Helix queues are overloaded, or there is a bug that makes the tests run a lot slower.

jkotas

Looks good to me otherwise

noahfalk · 2024-07-30T10:25:35Z

I've updated for the feedback so far. Everything is addressed except NativeAOT SOS which has to be handled out-of-band. Looking at the time I think I may need to call it quits on this for .NET 9 and instead treat it as .NET 10 on a slower cadence. At this point I don't think I have more time available right now to do a staged checkin, revalidate testing after the ongoing changes, and continue to have time in reserve to respond to potential post-checkin issues.

This change is some preparatory refactoring for the randomized allocation sampling feature. We need to add more state onto allocation context but we don't want to do a breaking change of the GC interface. The new state only needs to be visible to the EE but we want it physically near the existing alloc context state for good cache locality. To accomplish this we created a new ee_alloc_context struct which contains an instance of gc_alloc_context within it. The new ee_alloc_context::combined_limit should be used by fast allocation helpers to determine when to go down the slow path. Most of the time combined_limit has the same value as alloc_limit, but periodically we need to emit an allocation sampling event on an object that is somewhere in the middle of an AC. Using combined_limit rather than alloc_limit as the slow path trigger allows us to keep all the sampling event logic in the slow path.

- removed unnecessary UpdateCombinedLimit() in thread detach - updated comment for workaround on 96081 - swapped to updating combined_limit inside GcEnumAllocContexts() instead of in RestartEE()

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

noahfalk · 2024-07-13T07:58:04Z

This change is some preparatory refactoring for the randomized allocation sampling feature. We need to add more state onto allocation context but we don't want to do a breaking change of the GC interface. The new state only needs to be visible to the EE but we want it physically near the existing alloc context state for good cache locality. To accomplish this we created a new ee_alloc_context struct which contains an instance of gc_alloc_context within it.

The new field ee_alloc_context::combined_limit should be used by fast allocation helpers to determine when to go down the slow path. Most of the time combined_limit has the same value as alloc_limit, but periodically we need to emit an allocation sampling event on an object that is somewhere in the middle of an AC. Using combined_limit rather than alloc_limit as the slow path trigger allows us to keep all the sampling event logic in the slow path.

There is another PR for CoreCLR making the same change: #104849

jkotas · 2024-07-13T17:05:50Z

In a future PR we will add a field called combined_limit

I think you can add it in this PR. Adding the extra field is going to touch a lot of the same lines as this PR.

jkotas · 2024-07-13T17:13:16Z

(Also, same comment as #104851 (comment).)

noahfalk · 2024-07-19T01:14:49Z

@jkotas @MichalStrehovsky - I've applied the feedback from the CoreCLR issue to this one as well. Is anything else needed before you can signoff?

jkotas · 2024-07-29T01:04:10Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-07-29T01:04:19Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-07-29T16:33:58Z

nativeaot-outerloop (Build windows-x64 Release NativeAOT_Checked timeouts look like infrastructure issues, but they do not go away with reruns. Either the Helix queues are overloaded, or there is a bug that makes the tests run a lot slower.

jkotas

Looks good to me otherwise

noahfalk · 2024-07-30T10:25:35Z

I've updated for the feedback so far. Everything is addressed except NativeAOT SOS which has to be handled out-of-band. Looking at the time I think I may need to call it quits on this for .NET 9 and instead treat it as .NET 10 on a slower cadence. At this point I don't think I have more time available right now to do a staged checkin, revalidate testing after the ongoing changes, and continue to have time in reserve to respond to potential post-checkin issues.

This change is some preparatory refactoring for the randomized allocation sampling feature. We need to add more state onto allocation context but we don't want to do a breaking change of the GC interface. The new state only needs to be visible to the EE but we want it physically near the existing alloc context state for good cache locality. To accomplish this we created a new ee_alloc_context struct which contains an instance of gc_alloc_context within it. The new ee_alloc_context::combined_limit should be used by fast allocation helpers to determine when to go down the slow path. Most of the time combined_limit has the same value as alloc_limit, but periodically we need to emit an allocation sampling event on an object that is somewhere in the middle of an AC. Using combined_limit rather than alloc_limit as the slow path trigger allows us to keep all the sampling event logic in the slow path.

- removed unnecessary UpdateCombinedLimit() in thread detach - updated comment for workaround on 96081 - swapped to updating combined_limit inside GcEnumAllocContexts() instead of in RestartEE()

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

noahfalk · 2024-07-13T07:58:04Z

This change is some preparatory refactoring for the randomized allocation sampling feature. We need to add more state onto allocation context but we don't want to do a breaking change of the GC interface. The new state only needs to be visible to the EE but we want it physically near the existing alloc context state for good cache locality. To accomplish this we created a new ee_alloc_context struct which contains an instance of gc_alloc_context within it.

The new field ee_alloc_context::combined_limit should be used by fast allocation helpers to determine when to go down the slow path. Most of the time combined_limit has the same value as alloc_limit, but periodically we need to emit an allocation sampling event on an object that is somewhere in the middle of an AC. Using combined_limit rather than alloc_limit as the slow path trigger allows us to keep all the sampling event logic in the slow path.

There is another PR for CoreCLR making the same change: #104849

jkotas · 2024-07-13T17:05:50Z

In a future PR we will add a field called combined_limit

I think you can add it in this PR. Adding the extra field is going to touch a lot of the same lines as this PR.

jkotas · 2024-07-13T17:13:16Z

(Also, same comment as #104851 (comment).)

noahfalk · 2024-07-19T01:14:49Z

@jkotas @MichalStrehovsky - I've applied the feedback from the CoreCLR issue to this one as well. Is anything else needed before you can signoff?

jkotas · 2024-07-29T01:04:10Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-07-29T01:04:19Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-07-29T16:33:58Z

nativeaot-outerloop (Build windows-x64 Release NativeAOT_Checked timeouts look like infrastructure issues, but they do not go away with reruns. Either the Helix queues are overloaded, or there is a bug that makes the tests run a lot slower.

jkotas

Looks good to me otherwise

noahfalk · 2024-07-30T10:25:35Z

I've updated for the feedback so far. Everything is addressed except NativeAOT SOS which has to be handled out-of-band. Looking at the time I think I may need to call it quits on this for .NET 9 and instead treat it as .NET 10 on a slower cadence. At this point I don't think I have more time available right now to do a staged checkin, revalidate testing after the ongoing changes, and continue to have time in reserve to respond to potential post-checkin issues.

This change is some preparatory refactoring for the randomized allocation sampling feature. We need to add more state onto allocation context but we don't want to do a breaking change of the GC interface. The new state only needs to be visible to the EE but we want it physically near the existing alloc context state for good cache locality. To accomplish this we created a new ee_alloc_context struct which contains an instance of gc_alloc_context within it. The new ee_alloc_context::combined_limit should be used by fast allocation helpers to determine when to go down the slow path. Most of the time combined_limit has the same value as alloc_limit, but periodically we need to emit an allocation sampling event on an object that is somewhere in the middle of an AC. Using combined_limit rather than alloc_limit as the slow path trigger allows us to keep all the sampling event logic in the slow path.

- removed unnecessary UpdateCombinedLimit() in thread detach - updated comment for workaround on 96081 - swapped to updating combined_limit inside GcEnumAllocContexts() instead of in RestartEE()

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

noahfalk · 2024-07-13T07:58:04Z

This change is some preparatory refactoring for the randomized allocation sampling feature. We need to add more state onto allocation context but we don't want to do a breaking change of the GC interface. The new state only needs to be visible to the EE but we want it physically near the existing alloc context state for good cache locality. To accomplish this we created a new ee_alloc_context struct which contains an instance of gc_alloc_context within it.

The new field ee_alloc_context::combined_limit should be used by fast allocation helpers to determine when to go down the slow path. Most of the time combined_limit has the same value as alloc_limit, but periodically we need to emit an allocation sampling event on an object that is somewhere in the middle of an AC. Using combined_limit rather than alloc_limit as the slow path trigger allows us to keep all the sampling event logic in the slow path.

There is another PR for CoreCLR making the same change: #104849

jkotas · 2024-07-13T17:05:50Z

In a future PR we will add a field called combined_limit

I think you can add it in this PR. Adding the extra field is going to touch a lot of the same lines as this PR.

jkotas · 2024-07-13T17:13:16Z

(Also, same comment as #104851 (comment).)

noahfalk · 2024-07-19T01:14:49Z

@jkotas @MichalStrehovsky - I've applied the feedback from the CoreCLR issue to this one as well. Is anything else needed before you can signoff?

jkotas · 2024-07-29T01:04:10Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-07-29T01:04:19Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-07-29T16:33:58Z

nativeaot-outerloop (Build windows-x64 Release NativeAOT_Checked timeouts look like infrastructure issues, but they do not go away with reruns. Either the Helix queues are overloaded, or there is a bug that makes the tests run a lot slower.

jkotas

Looks good to me otherwise

noahfalk · 2024-07-30T10:25:35Z

I've updated for the feedback so far. Everything is addressed except NativeAOT SOS which has to be handled out-of-band. Looking at the time I think I may need to call it quits on this for .NET 9 and instead treat it as .NET 10 on a slower cadence. At this point I don't think I have more time available right now to do a staged checkin, revalidate testing after the ongoing changes, and continue to have time in reserve to respond to potential post-checkin issues.

This change is some preparatory refactoring for the randomized allocation sampling feature. We need to add more state onto allocation context but we don't want to do a breaking change of the GC interface. The new state only needs to be visible to the EE but we want it physically near the existing alloc context state for good cache locality. To accomplish this we created a new ee_alloc_context struct which contains an instance of gc_alloc_context within it. The new ee_alloc_context::combined_limit should be used by fast allocation helpers to determine when to go down the slow path. Most of the time combined_limit has the same value as alloc_limit, but periodically we need to emit an allocation sampling event on an object that is somewhere in the middle of an AC. Using combined_limit rather than alloc_limit as the slow path trigger allows us to keep all the sampling event logic in the slow path.

- removed unnecessary UpdateCombinedLimit() in thread detach - updated comment for workaround on 96081 - swapped to updating combined_limit inside GcEnumAllocContexts() instead of in RestartEE()

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

noahfalk · 2024-07-13T07:58:04Z

This change is some preparatory refactoring for the randomized allocation sampling feature. We need to add more state onto allocation context but we don't want to do a breaking change of the GC interface. The new state only needs to be visible to the EE but we want it physically near the existing alloc context state for good cache locality. To accomplish this we created a new ee_alloc_context struct which contains an instance of gc_alloc_context within it.

The new field ee_alloc_context::combined_limit should be used by fast allocation helpers to determine when to go down the slow path. Most of the time combined_limit has the same value as alloc_limit, but periodically we need to emit an allocation sampling event on an object that is somewhere in the middle of an AC. Using combined_limit rather than alloc_limit as the slow path trigger allows us to keep all the sampling event logic in the slow path.

There is another PR for CoreCLR making the same change: #104849

jkotas · 2024-07-13T17:05:50Z

In a future PR we will add a field called combined_limit

I think you can add it in this PR. Adding the extra field is going to touch a lot of the same lines as this PR.

jkotas · 2024-07-13T17:13:16Z

(Also, same comment as #104851 (comment).)

noahfalk · 2024-07-19T01:14:49Z

@jkotas @MichalStrehovsky - I've applied the feedback from the CoreCLR issue to this one as well. Is anything else needed before you can signoff?

jkotas · 2024-07-29T01:04:10Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-07-29T01:04:19Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-07-29T16:33:58Z

nativeaot-outerloop (Build windows-x64 Release NativeAOT_Checked timeouts look like infrastructure issues, but they do not go away with reruns. Either the Helix queues are overloaded, or there is a bug that makes the tests run a lot slower.

jkotas

Looks good to me otherwise

noahfalk · 2024-07-30T10:25:35Z

I've updated for the feedback so far. Everything is addressed except NativeAOT SOS which has to be handled out-of-band. Looking at the time I think I may need to call it quits on this for .NET 9 and instead treat it as .NET 10 on a slower cadence. At this point I don't think I have more time available right now to do a staged checkin, revalidate testing after the ongoing changes, and continue to have time in reserve to respond to potential post-checkin issues.

This change is some preparatory refactoring for the randomized allocation sampling feature. We need to add more state onto allocation context but we don't want to do a breaking change of the GC interface. The new state only needs to be visible to the EE but we want it physically near the existing alloc context state for good cache locality. To accomplish this we created a new ee_alloc_context struct which contains an instance of gc_alloc_context within it. The new ee_alloc_context::combined_limit should be used by fast allocation helpers to determine when to go down the slow path. Most of the time combined_limit has the same value as alloc_limit, but periodically we need to emit an allocation sampling event on an object that is somewhere in the middle of an AC. Using combined_limit rather than alloc_limit as the slow path trigger allows us to keep all the sampling event logic in the slow path.

- removed unnecessary UpdateCombinedLimit() in thread detach - updated comment for workaround on 96081 - swapped to updating combined_limit inside GcEnumAllocContexts() instead of in RestartEE()

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

noahfalk · 2024-07-13T07:58:04Z

This change is some preparatory refactoring for the randomized allocation sampling feature. We need to add more state onto allocation context but we don't want to do a breaking change of the GC interface. The new state only needs to be visible to the EE but we want it physically near the existing alloc context state for good cache locality. To accomplish this we created a new ee_alloc_context struct which contains an instance of gc_alloc_context within it.

The new field ee_alloc_context::combined_limit should be used by fast allocation helpers to determine when to go down the slow path. Most of the time combined_limit has the same value as alloc_limit, but periodically we need to emit an allocation sampling event on an object that is somewhere in the middle of an AC. Using combined_limit rather than alloc_limit as the slow path trigger allows us to keep all the sampling event logic in the slow path.

There is another PR for CoreCLR making the same change: #104849

jkotas · 2024-07-13T17:05:50Z

In a future PR we will add a field called combined_limit

I think you can add it in this PR. Adding the extra field is going to touch a lot of the same lines as this PR.

jkotas · 2024-07-13T17:13:16Z

(Also, same comment as #104851 (comment).)

noahfalk · 2024-07-19T01:14:49Z

@jkotas @MichalStrehovsky - I've applied the feedback from the CoreCLR issue to this one as well. Is anything else needed before you can signoff?

jkotas · 2024-07-29T01:04:10Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-07-29T01:04:19Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-07-29T16:33:58Z

nativeaot-outerloop (Build windows-x64 Release NativeAOT_Checked timeouts look like infrastructure issues, but they do not go away with reruns. Either the Helix queues are overloaded, or there is a bug that makes the tests run a lot slower.

jkotas

Looks good to me otherwise

noahfalk · 2024-07-30T10:25:35Z

I've updated for the feedback so far. Everything is addressed except NativeAOT SOS which has to be handled out-of-band. Looking at the time I think I may need to call it quits on this for .NET 9 and instead treat it as .NET 10 on a slower cadence. At this point I don't think I have more time available right now to do a staged checkin, revalidate testing after the ongoing changes, and continue to have time in reserve to respond to potential post-checkin issues.

This change is some preparatory refactoring for the randomized allocation sampling feature. We need to add more state onto allocation context but we don't want to do a breaking change of the GC interface. The new state only needs to be visible to the EE but we want it physically near the existing alloc context state for good cache locality. To accomplish this we created a new ee_alloc_context struct which contains an instance of gc_alloc_context within it. The new ee_alloc_context::combined_limit should be used by fast allocation helpers to determine when to go down the slow path. Most of the time combined_limit has the same value as alloc_limit, but periodically we need to emit an allocation sampling event on an object that is somewhere in the middle of an AC. Using combined_limit rather than alloc_limit as the slow path trigger allows us to keep all the sampling event logic in the slow path.

- removed unnecessary UpdateCombinedLimit() in thread detach - updated comment for workaround on 96081 - swapped to updating combined_limit inside GcEnumAllocContexts() instead of in RestartEE()

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

noahfalk · 2024-07-13T07:58:04Z

This change is some preparatory refactoring for the randomized allocation sampling feature. We need to add more state onto allocation context but we don't want to do a breaking change of the GC interface. The new state only needs to be visible to the EE but we want it physically near the existing alloc context state for good cache locality. To accomplish this we created a new ee_alloc_context struct which contains an instance of gc_alloc_context within it.

The new field ee_alloc_context::combined_limit should be used by fast allocation helpers to determine when to go down the slow path. Most of the time combined_limit has the same value as alloc_limit, but periodically we need to emit an allocation sampling event on an object that is somewhere in the middle of an AC. Using combined_limit rather than alloc_limit as the slow path trigger allows us to keep all the sampling event logic in the slow path.

There is another PR for CoreCLR making the same change: #104849

jkotas · 2024-07-13T17:05:50Z

In a future PR we will add a field called combined_limit

I think you can add it in this PR. Adding the extra field is going to touch a lot of the same lines as this PR.

jkotas · 2024-07-13T17:13:16Z

(Also, same comment as #104851 (comment).)

noahfalk · 2024-07-19T01:14:49Z

@jkotas @MichalStrehovsky - I've applied the feedback from the CoreCLR issue to this one as well. Is anything else needed before you can signoff?

jkotas · 2024-07-29T01:04:10Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2024-07-29T01:04:19Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2024-07-29T16:33:58Z

nativeaot-outerloop (Build windows-x64 Release NativeAOT_Checked timeouts look like infrastructure issues, but they do not go away with reruns. Either the Helix queues are overloaded, or there is a bug that makes the tests run a lot slower.

jkotas

Looks good to me otherwise

noahfalk · 2024-07-30T10:25:35Z

I've updated for the feedback so far. Everything is addressed except NativeAOT SOS which has to be handled out-of-band. Looking at the time I think I may need to call it quits on this for .NET 9 and instead treat it as .NET 10 on a slower cadence. At this point I don't think I have more time available right now to do a staged checkin, revalidate testing after the ongoing changes, and continue to have time in reserve to respond to potential post-checkin issues.

This change is some preparatory refactoring for the randomized allocation sampling feature. We need to add more state onto allocation context but we don't want to do a breaking change of the GC interface. The new state only needs to be visible to the EE but we want it physically near the existing alloc context state for good cache locality. To accomplish this we created a new ee_alloc_context struct which contains an instance of gc_alloc_context within it. The new ee_alloc_context::combined_limit should be used by fast allocation helpers to determine when to go down the slow path. Most of the time combined_limit has the same value as alloc_limit, but periodically we need to emit an allocation sampling event on an object that is somewhere in the middle of an AC. Using combined_limit rather than alloc_limit as the slow path trigger allows us to keep all the sampling event logic in the slow path.

- removed unnecessary UpdateCombinedLimit() in thread detach - updated comment for workaround on 96081 - swapped to updating combined_limit inside GcEnumAllocContexts() instead of in RestartEE()

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

ghost added the area-NativeAOT-coreclr label Jul 13, 2024

dotnet-policy-serviceBot assigned noahfalk Jul 13, 2024

noahfalk force-pushed the combined_limit_nativeaot branch 2 times, most recently from e35512a to f01e191Compare July 13, 2024 10:18

noahfalk force-pushed the combined_limit_nativeaot branch 2 times, most recently from 8d9bb20 to 01933faCompare July 14, 2024 07:59

jkotas reviewed Jul 15, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.inl Outdated

noahfalk force-pushed the combined_limit_nativeaot branch from 01933fa to 96af2fcCompare July 15, 2024 06:08

noahfalk mentioned this pull request Jul 15, 2024
Add ee_alloc_context #104849
Merged

noahfalk marked this pull request as ready for review July 15, 2024 10:07

noahfalk requested a review from MichalStrehovsky as a code owner July 15, 2024 10:07

noahfalk mentioned this pull request Jul 15, 2024
CI failure for System.Net.Security.Tests.TelemetryTest #104886
Closed

build-analysisBot mentioned this pull request Jul 15, 2024
System.Net.Security.Tests.TelemetryTest.SuccessfulHandshake_ActivityRecorded failures in CI #104883
Closed

jkotas reviewed Jul 15, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.cpp Outdated
Comment threadsrc/coreclr/nativeaot/Runtime/thread.inl Outdated

jkotas reviewed Jul 16, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/gcenv.ee.cpp Outdated

noahfalk mentioned this pull request Jul 16, 2024
Randomized allocation sampling #104955
Merged

jkotas reviewed Jul 29, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/DebugHeader.cpp

jkotas reviewed Jul 29, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.h
Comment threadsrc/coreclr/nativeaot/Runtime/thread.h

noahfalk force-pushed the combined_limit_nativeaot branch from 57dd3f5 to bc70bf5Compare July 30, 2024 10:16

build-analysisBot mentioned this pull request Jul 30, 2024
System.IO.Pipelines.Tests.PipeWriterTests.CompleteWithLargeWriteThrows fails in CI #103586
Open

build-analysisBot mentioned this pull request Jul 30, 2024
Roslyn analyzer throws error AD0001 NullReferenceException dotnet/dnceng#3305
Closed
3 tasks

tommcdon mentioned this pull request Aug 26, 2024
Add randomized allocation sampling #100356
Closed

noahfalkand others added 4 commits October 14, 2024 21:43

PR feedback
03da7d8
- removed unnecessary UpdateCombinedLimit() in thread detach - updated comment for workaround on 96081 - swapped to updating combined_limit inside GcEnumAllocContexts() instead of in RestartEE()

Update src/coreclr/nativeaot/Runtime/gcenv.ee.cpp
c457c29
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Reduce unnecessary combined_limit writes
36ecf6d

noahfalk force-pushed the combined_limit_nativeaot branch from bc70bf5 to 36ecf6dCompare October 15, 2024 04:58

jkotas approved these changes Oct 15, 2024
View reviewed changes

Bumping the debug header major version
6f634cb

noahfalk merged commit 588bc45 into dotnet:mainOct 16, 2024

github-actionsBot locked and limited conversation to collaborators Nov 15, 2024

ghost added the area-NativeAOT-coreclr label Jul 13, 2024

dotnet-policy-serviceBot assigned noahfalk Jul 13, 2024

noahfalk force-pushed the combined_limit_nativeaot branch 2 times, most recently from e35512a to f01e191Compare July 13, 2024 10:18

noahfalk force-pushed the combined_limit_nativeaot branch 2 times, most recently from 8d9bb20 to 01933faCompare July 14, 2024 07:59

jkotas reviewed Jul 15, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.inl Outdated

noahfalk force-pushed the combined_limit_nativeaot branch from 01933fa to 96af2fcCompare July 15, 2024 06:08

noahfalk mentioned this pull request Jul 15, 2024
Add ee_alloc_context #104849
Merged

noahfalk marked this pull request as ready for review July 15, 2024 10:07

noahfalk requested a review from MichalStrehovsky as a code owner July 15, 2024 10:07

noahfalk mentioned this pull request Jul 15, 2024
CI failure for System.Net.Security.Tests.TelemetryTest #104886
Closed

build-analysisBot mentioned this pull request Jul 15, 2024
System.Net.Security.Tests.TelemetryTest.SuccessfulHandshake_ActivityRecorded failures in CI #104883
Closed

jkotas reviewed Jul 15, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.cpp Outdated
Comment threadsrc/coreclr/nativeaot/Runtime/thread.inl Outdated

jkotas reviewed Jul 16, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/gcenv.ee.cpp Outdated

noahfalk mentioned this pull request Jul 16, 2024
Randomized allocation sampling #104955
Merged

jkotas reviewed Jul 29, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/DebugHeader.cpp

jkotas reviewed Jul 29, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.h
Comment threadsrc/coreclr/nativeaot/Runtime/thread.h

noahfalk force-pushed the combined_limit_nativeaot branch from 57dd3f5 to bc70bf5Compare July 30, 2024 10:16

build-analysisBot mentioned this pull request Jul 30, 2024
System.IO.Pipelines.Tests.PipeWriterTests.CompleteWithLargeWriteThrows fails in CI #103586
Open

build-analysisBot mentioned this pull request Jul 30, 2024
Roslyn analyzer throws error AD0001 NullReferenceException dotnet/dnceng#3305
Closed
3 tasks

tommcdon mentioned this pull request Aug 26, 2024
Add randomized allocation sampling #100356
Closed

noahfalkand others added 4 commits October 14, 2024 21:43

PR feedback
03da7d8
- removed unnecessary UpdateCombinedLimit() in thread detach - updated comment for workaround on 96081 - swapped to updating combined_limit inside GcEnumAllocContexts() instead of in RestartEE()

Update src/coreclr/nativeaot/Runtime/gcenv.ee.cpp
c457c29
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Reduce unnecessary combined_limit writes
36ecf6d

noahfalk force-pushed the combined_limit_nativeaot branch from bc70bf5 to 36ecf6dCompare October 15, 2024 04:58

jkotas approved these changes Oct 15, 2024
View reviewed changes

Bumping the debug header major version
6f634cb

noahfalk merged commit 588bc45 into dotnet:mainOct 16, 2024

github-actionsBot locked and limited conversation to collaborators Nov 15, 2024

ghost added the area-NativeAOT-coreclr label Jul 13, 2024

dotnet-policy-serviceBot assigned noahfalk Jul 13, 2024

noahfalk force-pushed the combined_limit_nativeaot branch 2 times, most recently from e35512a to f01e191Compare July 13, 2024 10:18

noahfalk force-pushed the combined_limit_nativeaot branch 2 times, most recently from 8d9bb20 to 01933faCompare July 14, 2024 07:59

jkotas reviewed Jul 15, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.inl Outdated

noahfalk force-pushed the combined_limit_nativeaot branch from 01933fa to 96af2fcCompare July 15, 2024 06:08

noahfalk mentioned this pull request Jul 15, 2024
Add ee_alloc_context #104849
Merged

noahfalk marked this pull request as ready for review July 15, 2024 10:07

noahfalk requested a review from MichalStrehovsky as a code owner July 15, 2024 10:07

noahfalk mentioned this pull request Jul 15, 2024
CI failure for System.Net.Security.Tests.TelemetryTest #104886
Closed

build-analysisBot mentioned this pull request Jul 15, 2024
System.Net.Security.Tests.TelemetryTest.SuccessfulHandshake_ActivityRecorded failures in CI #104883
Closed

jkotas reviewed Jul 15, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.cpp Outdated
Comment threadsrc/coreclr/nativeaot/Runtime/thread.inl Outdated

jkotas reviewed Jul 16, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/gcenv.ee.cpp Outdated

noahfalk mentioned this pull request Jul 16, 2024
Randomized allocation sampling #104955
Merged

jkotas reviewed Jul 29, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/DebugHeader.cpp

jkotas reviewed Jul 29, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.h
Comment threadsrc/coreclr/nativeaot/Runtime/thread.h

noahfalk force-pushed the combined_limit_nativeaot branch from 57dd3f5 to bc70bf5Compare July 30, 2024 10:16

build-analysisBot mentioned this pull request Jul 30, 2024
System.IO.Pipelines.Tests.PipeWriterTests.CompleteWithLargeWriteThrows fails in CI #103586
Open

build-analysisBot mentioned this pull request Jul 30, 2024
Roslyn analyzer throws error AD0001 NullReferenceException dotnet/dnceng#3305
Closed
3 tasks

tommcdon mentioned this pull request Aug 26, 2024
Add randomized allocation sampling #100356
Closed

noahfalkand others added 4 commits October 14, 2024 21:43

PR feedback
03da7d8
- removed unnecessary UpdateCombinedLimit() in thread detach - updated comment for workaround on 96081 - swapped to updating combined_limit inside GcEnumAllocContexts() instead of in RestartEE()

Update src/coreclr/nativeaot/Runtime/gcenv.ee.cpp
c457c29
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Reduce unnecessary combined_limit writes
36ecf6d

noahfalk force-pushed the combined_limit_nativeaot branch from bc70bf5 to 36ecf6dCompare October 15, 2024 04:58

jkotas approved these changes Oct 15, 2024
View reviewed changes

Bumping the debug header major version
6f634cb

noahfalk merged commit 588bc45 into dotnet:mainOct 16, 2024

github-actionsBot locked and limited conversation to collaborators Nov 15, 2024

ghost added the area-NativeAOT-coreclr label Jul 13, 2024

dotnet-policy-serviceBot assigned noahfalk Jul 13, 2024

noahfalk force-pushed the combined_limit_nativeaot branch 2 times, most recently from e35512a to f01e191Compare July 13, 2024 10:18

noahfalk force-pushed the combined_limit_nativeaot branch 2 times, most recently from 8d9bb20 to 01933faCompare July 14, 2024 07:59

jkotas reviewed Jul 15, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.inl Outdated

noahfalk force-pushed the combined_limit_nativeaot branch from 01933fa to 96af2fcCompare July 15, 2024 06:08

noahfalk mentioned this pull request Jul 15, 2024
Add ee_alloc_context #104849
Merged

noahfalk marked this pull request as ready for review July 15, 2024 10:07

noahfalk requested a review from MichalStrehovsky as a code owner July 15, 2024 10:07

noahfalk mentioned this pull request Jul 15, 2024
CI failure for System.Net.Security.Tests.TelemetryTest #104886
Closed

build-analysisBot mentioned this pull request Jul 15, 2024
System.Net.Security.Tests.TelemetryTest.SuccessfulHandshake_ActivityRecorded failures in CI #104883
Closed

jkotas reviewed Jul 15, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.cpp Outdated
Comment threadsrc/coreclr/nativeaot/Runtime/thread.inl Outdated

jkotas reviewed Jul 16, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/gcenv.ee.cpp Outdated

noahfalk mentioned this pull request Jul 16, 2024
Randomized allocation sampling #104955
Merged

jkotas reviewed Jul 29, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/DebugHeader.cpp

jkotas reviewed Jul 29, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.h
Comment threadsrc/coreclr/nativeaot/Runtime/thread.h

noahfalk force-pushed the combined_limit_nativeaot branch from 57dd3f5 to bc70bf5Compare July 30, 2024 10:16

build-analysisBot mentioned this pull request Jul 30, 2024
System.IO.Pipelines.Tests.PipeWriterTests.CompleteWithLargeWriteThrows fails in CI #103586
Open

build-analysisBot mentioned this pull request Jul 30, 2024
Roslyn analyzer throws error AD0001 NullReferenceException dotnet/dnceng#3305
Closed
3 tasks

tommcdon mentioned this pull request Aug 26, 2024
Add randomized allocation sampling #100356
Closed

noahfalkand others added 4 commits October 14, 2024 21:43

PR feedback
03da7d8
- removed unnecessary UpdateCombinedLimit() in thread detach - updated comment for workaround on 96081 - swapped to updating combined_limit inside GcEnumAllocContexts() instead of in RestartEE()

Update src/coreclr/nativeaot/Runtime/gcenv.ee.cpp
c457c29
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Reduce unnecessary combined_limit writes
36ecf6d

noahfalk force-pushed the combined_limit_nativeaot branch from bc70bf5 to 36ecf6dCompare October 15, 2024 04:58

jkotas approved these changes Oct 15, 2024
View reviewed changes

Bumping the debug header major version
6f634cb

noahfalk merged commit 588bc45 into dotnet:mainOct 16, 2024

github-actionsBot locked and limited conversation to collaborators Nov 15, 2024

ghost added the area-NativeAOT-coreclr label Jul 13, 2024

dotnet-policy-serviceBot assigned noahfalk Jul 13, 2024

noahfalk force-pushed the combined_limit_nativeaot branch 2 times, most recently from e35512a to f01e191Compare July 13, 2024 10:18

noahfalk force-pushed the combined_limit_nativeaot branch 2 times, most recently from 8d9bb20 to 01933faCompare July 14, 2024 07:59

jkotas reviewed Jul 15, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.inl Outdated

noahfalk force-pushed the combined_limit_nativeaot branch from 01933fa to 96af2fcCompare July 15, 2024 06:08

noahfalk mentioned this pull request Jul 15, 2024
Add ee_alloc_context #104849
Merged

noahfalk marked this pull request as ready for review July 15, 2024 10:07

noahfalk requested a review from MichalStrehovsky as a code owner July 15, 2024 10:07

noahfalk mentioned this pull request Jul 15, 2024
CI failure for System.Net.Security.Tests.TelemetryTest #104886
Closed

build-analysisBot mentioned this pull request Jul 15, 2024
System.Net.Security.Tests.TelemetryTest.SuccessfulHandshake_ActivityRecorded failures in CI #104883
Closed

jkotas reviewed Jul 15, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.cpp Outdated
Comment threadsrc/coreclr/nativeaot/Runtime/thread.inl Outdated

jkotas reviewed Jul 16, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/gcenv.ee.cpp Outdated

noahfalk mentioned this pull request Jul 16, 2024
Randomized allocation sampling #104955
Merged

jkotas reviewed Jul 29, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/DebugHeader.cpp

jkotas reviewed Jul 29, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.h
Comment threadsrc/coreclr/nativeaot/Runtime/thread.h

noahfalk force-pushed the combined_limit_nativeaot branch from 57dd3f5 to bc70bf5Compare July 30, 2024 10:16

build-analysisBot mentioned this pull request Jul 30, 2024
System.IO.Pipelines.Tests.PipeWriterTests.CompleteWithLargeWriteThrows fails in CI #103586
Open

build-analysisBot mentioned this pull request Jul 30, 2024
Roslyn analyzer throws error AD0001 NullReferenceException dotnet/dnceng#3305
Closed
3 tasks

tommcdon mentioned this pull request Aug 26, 2024
Add randomized allocation sampling #100356
Closed

noahfalkand others added 4 commits October 14, 2024 21:43

PR feedback
03da7d8
- removed unnecessary UpdateCombinedLimit() in thread detach - updated comment for workaround on 96081 - swapped to updating combined_limit inside GcEnumAllocContexts() instead of in RestartEE()

Update src/coreclr/nativeaot/Runtime/gcenv.ee.cpp
c457c29
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Reduce unnecessary combined_limit writes
36ecf6d

noahfalk force-pushed the combined_limit_nativeaot branch from bc70bf5 to 36ecf6dCompare October 15, 2024 04:58

jkotas approved these changes Oct 15, 2024
View reviewed changes

Bumping the debug header major version
6f634cb

noahfalk merged commit 588bc45 into dotnet:mainOct 16, 2024

github-actionsBot locked and limited conversation to collaborators Nov 15, 2024

ghost added the area-NativeAOT-coreclr label Jul 13, 2024

dotnet-policy-serviceBot assigned noahfalk Jul 13, 2024

noahfalk force-pushed the combined_limit_nativeaot branch 2 times, most recently from e35512a to f01e191Compare July 13, 2024 10:18

noahfalk force-pushed the combined_limit_nativeaot branch 2 times, most recently from 8d9bb20 to 01933faCompare July 14, 2024 07:59

jkotas reviewed Jul 15, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.inl Outdated

noahfalk force-pushed the combined_limit_nativeaot branch from 01933fa to 96af2fcCompare July 15, 2024 06:08

noahfalk mentioned this pull request Jul 15, 2024
Add ee_alloc_context #104849
Merged

noahfalk marked this pull request as ready for review July 15, 2024 10:07

noahfalk requested a review from MichalStrehovsky as a code owner July 15, 2024 10:07

noahfalk mentioned this pull request Jul 15, 2024
CI failure for System.Net.Security.Tests.TelemetryTest #104886
Closed

build-analysisBot mentioned this pull request Jul 15, 2024
System.Net.Security.Tests.TelemetryTest.SuccessfulHandshake_ActivityRecorded failures in CI #104883
Closed

jkotas reviewed Jul 15, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.cpp Outdated
Comment threadsrc/coreclr/nativeaot/Runtime/thread.inl Outdated

jkotas reviewed Jul 16, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/gcenv.ee.cpp Outdated

noahfalk mentioned this pull request Jul 16, 2024
Randomized allocation sampling #104955
Merged

jkotas reviewed Jul 29, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/DebugHeader.cpp

jkotas reviewed Jul 29, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.h
Comment threadsrc/coreclr/nativeaot/Runtime/thread.h

noahfalk force-pushed the combined_limit_nativeaot branch from 57dd3f5 to bc70bf5Compare July 30, 2024 10:16

build-analysisBot mentioned this pull request Jul 30, 2024
System.IO.Pipelines.Tests.PipeWriterTests.CompleteWithLargeWriteThrows fails in CI #103586
Open

build-analysisBot mentioned this pull request Jul 30, 2024
Roslyn analyzer throws error AD0001 NullReferenceException dotnet/dnceng#3305
Closed
3 tasks

tommcdon mentioned this pull request Aug 26, 2024
Add randomized allocation sampling #100356
Closed

noahfalkand others added 4 commits October 14, 2024 21:43

PR feedback
03da7d8
- removed unnecessary UpdateCombinedLimit() in thread detach - updated comment for workaround on 96081 - swapped to updating combined_limit inside GcEnumAllocContexts() instead of in RestartEE()

Update src/coreclr/nativeaot/Runtime/gcenv.ee.cpp
c457c29
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Reduce unnecessary combined_limit writes
36ecf6d

noahfalk force-pushed the combined_limit_nativeaot branch from bc70bf5 to 36ecf6dCompare October 15, 2024 04:58

jkotas approved these changes Oct 15, 2024
View reviewed changes

Bumping the debug header major version
6f634cb

noahfalk merged commit 588bc45 into dotnet:mainOct 16, 2024

github-actionsBot locked and limited conversation to collaborators Nov 15, 2024

ghost added the area-NativeAOT-coreclr label Jul 13, 2024

dotnet-policy-serviceBot assigned noahfalk Jul 13, 2024

noahfalk force-pushed the combined_limit_nativeaot branch 2 times, most recently from e35512a to f01e191Compare July 13, 2024 10:18

noahfalk force-pushed the combined_limit_nativeaot branch 2 times, most recently from 8d9bb20 to 01933faCompare July 14, 2024 07:59

jkotas reviewed Jul 15, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.inl Outdated

noahfalk force-pushed the combined_limit_nativeaot branch from 01933fa to 96af2fcCompare July 15, 2024 06:08

noahfalk mentioned this pull request Jul 15, 2024
Add ee_alloc_context #104849
Merged

noahfalk marked this pull request as ready for review July 15, 2024 10:07

noahfalk requested a review from MichalStrehovsky as a code owner July 15, 2024 10:07

noahfalk mentioned this pull request Jul 15, 2024
CI failure for System.Net.Security.Tests.TelemetryTest #104886
Closed

build-analysisBot mentioned this pull request Jul 15, 2024
System.Net.Security.Tests.TelemetryTest.SuccessfulHandshake_ActivityRecorded failures in CI #104883
Closed

jkotas reviewed Jul 15, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.cpp Outdated
Comment threadsrc/coreclr/nativeaot/Runtime/thread.inl Outdated

jkotas reviewed Jul 16, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/gcenv.ee.cpp Outdated

noahfalk mentioned this pull request Jul 16, 2024
Randomized allocation sampling #104955
Merged

jkotas reviewed Jul 29, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/DebugHeader.cpp

jkotas reviewed Jul 29, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.h
Comment threadsrc/coreclr/nativeaot/Runtime/thread.h

noahfalk force-pushed the combined_limit_nativeaot branch from 57dd3f5 to bc70bf5Compare July 30, 2024 10:16

build-analysisBot mentioned this pull request Jul 30, 2024
System.IO.Pipelines.Tests.PipeWriterTests.CompleteWithLargeWriteThrows fails in CI #103586
Open

build-analysisBot mentioned this pull request Jul 30, 2024
Roslyn analyzer throws error AD0001 NullReferenceException dotnet/dnceng#3305
Closed
3 tasks

tommcdon mentioned this pull request Aug 26, 2024
Add randomized allocation sampling #100356
Closed

noahfalkand others added 4 commits October 14, 2024 21:43

PR feedback
03da7d8
- removed unnecessary UpdateCombinedLimit() in thread detach - updated comment for workaround on 96081 - swapped to updating combined_limit inside GcEnumAllocContexts() instead of in RestartEE()

Update src/coreclr/nativeaot/Runtime/gcenv.ee.cpp
c457c29
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Reduce unnecessary combined_limit writes
36ecf6d

noahfalk force-pushed the combined_limit_nativeaot branch from bc70bf5 to 36ecf6dCompare October 15, 2024 04:58

jkotas approved these changes Oct 15, 2024
View reviewed changes

Bumping the debug header major version
6f634cb

noahfalk merged commit 588bc45 into dotnet:mainOct 16, 2024

github-actionsBot locked and limited conversation to collaborators Nov 15, 2024

ghost added the area-NativeAOT-coreclr label Jul 13, 2024

dotnet-policy-serviceBot assigned noahfalk Jul 13, 2024

noahfalk force-pushed the combined_limit_nativeaot branch 2 times, most recently from e35512a to f01e191Compare July 13, 2024 10:18

noahfalk force-pushed the combined_limit_nativeaot branch 2 times, most recently from 8d9bb20 to 01933faCompare July 14, 2024 07:59

jkotas reviewed Jul 15, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.inl Outdated

noahfalk force-pushed the combined_limit_nativeaot branch from 01933fa to 96af2fcCompare July 15, 2024 06:08

noahfalk mentioned this pull request Jul 15, 2024
Add ee_alloc_context #104849
Merged

noahfalk marked this pull request as ready for review July 15, 2024 10:07

noahfalk requested a review from MichalStrehovsky as a code owner July 15, 2024 10:07

noahfalk mentioned this pull request Jul 15, 2024
CI failure for System.Net.Security.Tests.TelemetryTest #104886
Closed

build-analysisBot mentioned this pull request Jul 15, 2024
System.Net.Security.Tests.TelemetryTest.SuccessfulHandshake_ActivityRecorded failures in CI #104883
Closed

jkotas reviewed Jul 15, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.cpp Outdated
Comment threadsrc/coreclr/nativeaot/Runtime/thread.inl Outdated

jkotas reviewed Jul 16, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/gcenv.ee.cpp Outdated

noahfalk mentioned this pull request Jul 16, 2024
Randomized allocation sampling #104955
Merged

jkotas reviewed Jul 29, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/DebugHeader.cpp

jkotas reviewed Jul 29, 2024
View reviewed changes

Comment threadsrc/coreclr/nativeaot/Runtime/thread.h
Comment threadsrc/coreclr/nativeaot/Runtime/thread.h

noahfalk force-pushed the combined_limit_nativeaot branch from 57dd3f5 to bc70bf5Compare July 30, 2024 10:16

build-analysisBot mentioned this pull request Jul 30, 2024
System.IO.Pipelines.Tests.PipeWriterTests.CompleteWithLargeWriteThrows fails in CI #103586
Open

build-analysisBot mentioned this pull request Jul 30, 2024
Roslyn analyzer throws error AD0001 NullReferenceException dotnet/dnceng#3305
Closed
3 tasks

tommcdon mentioned this pull request Aug 26, 2024
Add randomized allocation sampling #100356
Closed

noahfalkand others added 4 commits October 14, 2024 21:43

PR feedback
03da7d8
- removed unnecessary UpdateCombinedLimit() in thread detach - updated comment for workaround on 96081 - swapped to updating combined_limit inside GcEnumAllocContexts() instead of in RestartEE()

Update src/coreclr/nativeaot/Runtime/gcenv.ee.cpp
c457c29
Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Reduce unnecessary combined_limit writes
36ecf6d

noahfalk force-pushed the combined_limit_nativeaot branch from bc70bf5 to 36ecf6dCompare October 15, 2024 04:58

jkotas approved these changes Oct 15, 2024
View reviewed changes

Bumping the debug header major version
6f634cb

noahfalk merged commit 588bc45 into dotnet:mainOct 16, 2024

github-actionsBot locked and limited conversation to collaborators Nov 15, 2024

Uh oh!

Conversation

noahfalk commented Jul 13, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkotas commented Jul 13, 2024

Uh oh!

jkotas commented Jul 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

noahfalk commented Jul 19, 2024

Uh oh!

jkotas commented Jul 29, 2024

Uh oh!

azure-pipelinesBot commented Jul 29, 2024

Uh oh!

Uh oh!

jkotas commented Jul 29, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

noahfalk commented Jul 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

noahfalk commented Jul 13, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkotas commented Jul 13, 2024

Uh oh!

jkotas commented Jul 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

noahfalk commented Jul 19, 2024

Uh oh!

jkotas commented Jul 29, 2024

Uh oh!

azure-pipelinesBot commented Jul 29, 2024

Uh oh!

Uh oh!

jkotas commented Jul 29, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

noahfalk commented Jul 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

noahfalk commented Jul 13, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

noahfalk commented Jul 13, 2024•
edited
Loading

jkotas commented Jul 29, 2024•
edited
Loading

noahfalk commented Jul 13, 2024•
edited
Loading

jkotas commented Jul 29, 2024•
edited
Loading

noahfalk commented Jul 13, 2024•
edited
Loading

jkotas commented Jul 29, 2024•
edited
Loading

noahfalk commented Jul 13, 2024•
edited
Loading