Skip to content

Fix crash in DAC enum memory code that brings down createdump - #104939

Merged
mikem8361 merged 2 commits into
dotnet:mainfrom
mikem8361:dacenummem
Jul 16, 2024
Merged

Fix crash in DAC enum memory code that brings down createdump#104939
mikem8361 merged 2 commits into
dotnet:mainfrom
mikem8361:dacenummem

Conversation

@mikem8361

@mikem8361mikem8361 commented Jul 16, 2024

Copy link
Copy Markdown
Contributor

Either a recent change in a MT's virtual method slot allocation or createdump is just getting unlucky now and the slot hasn't been filled in yet is causing this crash. The DAC EnumMemoryRegions API is calling ExceptionTypeOverridesStackTraceGetter() which enumerates all the virtual method slots in the ExceptionObject's MT looking for "get_StackTrace" and check if it has been overridden. All the code involved hasn't change in a very long time.

GetMethodDescForSlot gets called for a slot that has no PCODE (GetRestoredSlot() returns null). There is a comment in that function about slots not being filled in yet and code on the runtime side (ifdef'ed out in the DAC) that fills it in.

The stack trace of the crash:

* thread #1, name = 'createdump', stop reason = signal SIGSEGV: invalid address (fault address: 0x0)
* frame #0: 0x00007fffc46fc6c0 0x00007f8568876eed libmscordaccore.so`Precode::GetType(this=0x0000000000000000) + 29 at precode.h:447
frame #1: 0x00007fffc46fc6f0 0x00007f8568876dc9 libmscordaccore.so`Precode::GetPrecodeFromEntryPoint(addr=0, fSpeculative=YES) + 153 at precode.h:557
frame #2: 0x00007fffc46fc750 0x00007f8568880074 libmscordaccore.so`MethodDesc::GetMethodDescFromStubAddr(addr=0, fSpeculative=NO) + 52 at method.cpp:2628
frame #3: 0x00007fffc46fc7a0 0x00007f85688a692a libmscordaccore.so`MethodTable::GetMethodDescForSlotAddress(addr=0, fSpeculative=NO) + 90 at methodtable.cpp:6211
frame #4: 0x00007fffc46fc7d0 0x00007f856887ba41 libmscordaccore.so`MethodTable::GetMethodDescForSlot(this=0x00007f8565d9f030, slot=11) + 161 at methodtable.inl:426
frame #5: 0x00007fffc46fc810 0x00007f85688ccc93 libmscordaccore.so`ExceptionTypeOverridesStackTraceGetter(pMT=PTR_MethodTable @ 0x00007fffc46fcb50) + 259 at excep.cpp:7956
frame #6: 0x00007fffc46fc870 0x00007f856899b6de libmscordaccore.so`ClrDataAccess::DumpManagedExcepObject(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE, objRef=OBJECTREF @ 0x00007fffc46fd658) + 3422 at enummem.cpp:527
frame #7: 0x00007fffc46fcef0 0x00007f8568996abd libmscordaccore.so`ClrDataAccess::EnumMemDumpAllThreadsStack(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 909 at enummem.cpp:1143
frame #8: 0x00007fffc46fe360 0x00007f85689a1c28 libmscordaccore.so`ClrDataAccess::EnumMemoryRegionsWorkerMicroTriage(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 200 at enummem.cpp:1714
frame #9: 0x00007fffc46fe830 0x00007f85689a7809 libmscordaccore.so`ClrDataAccess::EnumMemoryRegionsWrapper(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 329 at enummem.cpp:1920
frame #10: 0x00007fffc46fe940 0x00007f85689a7f18 libmscordaccore.so`ClrDataAccess::EnumMemoryRegions(this=0x000055bc91c4d210, callback=0x000055bc91c2eae0, miniDumpFlags=1181100, flags=CLRDATA_ENUM_MEM_HEAP2) + 632 at enummem.cpp:2033
frame #11: 0x00007fffc46fea70 0x000055bc8fdb2e20 createdump`CrashInfo::EnumerateMemoryRegionsWithDAC(this=0x000055bc91c2eae0, dumpType=Triage) + 352 at crashinfo.cpp:410
frame #12: 0x00007fffc46fead0 0x000055bc8fda6f58 createdump`CreateDump(options=0x00007fffc4702cd0) + 1160 at createdumpunix.cpp:75
frame #13: 0x00007fffc4702c30 0x000055bc8fda59b7 createdump`createdump_main(argc=11, argv=0x00007fffc4702ec0) + 2199 at createdumpmain.cpp:222
frame #14: 0x00007fffc4702d30 0x000055bc8fda48e2 createdump`main(argc=11, argv=0x00007fffc4702e68) + 34 at main.cpp:20
frame #15: 0x00007fffc4702d60 0x00007f8568c8ad90 libc.so.6`__libc_start_call_main(main=(createdump`main at main.cpp:19), argc=11, argv=0x00007fffc4702e68) + 128 at libc_start_call_main.h:58
frame #16: 0x00007fffc4702e00 0x00007f8568c8ae40 libc.so.6`__libc_start_main_impl(main=(createdump`main at main.cpp:19), argc=11, argv=0x00007fffc4702e68, init=(_rtld_global), fini=<unavailable>, rtld_fini=<unavailable>, stack_end=0x00007fffc4702e58) + 128 at libc-start.c:392
frame #17: 0x00007fffc4702e50 0x000055bc8fda47f5 createdump`_start + 37(lldb) k

@mikem8361
mikem8361 requested a review from jkotasJuly 16, 2024 01:47
@mikem8361mikem8361 self-assigned this Jul 16, 2024
@ghostghost added the area-VM-coreclr label Jul 16, 2024
@dotnet-policy-service

dotnet-policy-serviceBot commented Jul 16, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@jkotas

jkotas commented Jul 16, 2024

Copy link
Copy Markdown
Member

This is regression introduced by #101580

jkotas
jkotas reviewed Jul 16, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/methodtable.inl Outdated
This was referenced Jul 16, 2024
Open
Closed
Closed
Closed
davidwrighton
davidwrighton approved these changes Jul 16, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/excep.cpp
@mikem8361mikem8361 mentioned this pull request Jul 16, 2024
Merged
@mikem8361
mikem8361 merged commit 5e7de53 into dotnet:mainJul 16, 2024
@mikem8361
mikem8361 deleted the dacenummem branch July 16, 2024 22:42
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Aug 16, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkotasjkotasjkotas left review comments
@davidwrightondavidwrightondavidwrighton approved these changes

Assignees

@mikem8361mikem8361

Labels

area-VM-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mikem8361@jkotas@davidwrighton
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Fix crash in DAC enum memory code that brings down createdump by mikem8361 · Pull Request #104939 · dotnet/runtime · GitHub
Skip to content
Fix crash in DAC enum memory code that brings down createdump - #104939
Merged
mikem8361 merged 2 commits into
dotnet:mainfrom 
mikem8361:dacenummem
Jul 16, 2024
Merged
Fix crash in DAC enum memory code that brings down createdump#104939
mikem8361 merged 2 commits into
dotnet:mainfrom 
mikem8361:dacenummem
Conversation
@mikem8361
@mikem8361mikem8361
commented
Jul 16, 2024

Copy link


Copy Markdown

Contributor
Either a recent change in a MT's virtual method slot allocation or createdump is just getting unlucky now and the slot hasn't been filled in yet is causing this crash. The DAC EnumMemoryRegions API is calling ExceptionTypeOverridesStackTraceGetter() which enumerates all the virtual method slots in the ExceptionObject's MT looking for "get_StackTrace" and check if it has been overridden. All the code involved hasn't change in a very long time.
GetMethodDescForSlot gets called for a slot that has no PCODE (GetRestoredSlot() returns null). There is a comment in that function about slots not being filled in yet and code on the runtime side (ifdef'ed out in the DAC) that fills it in.
The stack trace of the crash:
* thread #1, name = 'createdump', stop reason = signal SIGSEGV: invalid address (fault address: 0x0)
* frame #0: 0x00007fffc46fc6c0 0x00007f8568876eed libmscordaccore.so`Precode::GetType(this=0x0000000000000000) + 29 at precode.h:447
frame #1: 0x00007fffc46fc6f0 0x00007f8568876dc9 libmscordaccore.so`Precode::GetPrecodeFromEntryPoint(addr=0, fSpeculative=YES) + 153 at precode.h:557
frame #2: 0x00007fffc46fc750 0x00007f8568880074 libmscordaccore.so`MethodDesc::GetMethodDescFromStubAddr(addr=0, fSpeculative=NO) + 52 at method.cpp:2628
frame #3: 0x00007fffc46fc7a0 0x00007f85688a692a libmscordaccore.so`MethodTable::GetMethodDescForSlotAddress(addr=0, fSpeculative=NO) + 90 at methodtable.cpp:6211
frame #4: 0x00007fffc46fc7d0 0x00007f856887ba41 libmscordaccore.so`MethodTable::GetMethodDescForSlot(this=0x00007f8565d9f030, slot=11) + 161 at methodtable.inl:426
frame #5: 0x00007fffc46fc810 0x00007f85688ccc93 libmscordaccore.so`ExceptionTypeOverridesStackTraceGetter(pMT=PTR_MethodTable @ 0x00007fffc46fcb50) + 259 at excep.cpp:7956
frame #6: 0x00007fffc46fc870 0x00007f856899b6de libmscordaccore.so`ClrDataAccess::DumpManagedExcepObject(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE, objRef=OBJECTREF @ 0x00007fffc46fd658) + 3422 at enummem.cpp:527
frame #7: 0x00007fffc46fcef0 0x00007f8568996abd libmscordaccore.so`ClrDataAccess::EnumMemDumpAllThreadsStack(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 909 at enummem.cpp:1143
frame #8: 0x00007fffc46fe360 0x00007f85689a1c28 libmscordaccore.so`ClrDataAccess::EnumMemoryRegionsWorkerMicroTriage(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 200 at enummem.cpp:1714
frame #9: 0x00007fffc46fe830 0x00007f85689a7809 libmscordaccore.so`ClrDataAccess::EnumMemoryRegionsWrapper(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 329 at enummem.cpp:1920
frame #10: 0x00007fffc46fe940 0x00007f85689a7f18 libmscordaccore.so`ClrDataAccess::EnumMemoryRegions(this=0x000055bc91c4d210, callback=0x000055bc91c2eae0, miniDumpFlags=1181100, flags=CLRDATA_ENUM_MEM_HEAP2) + 632 at enummem.cpp:2033
frame #11: 0x00007fffc46fea70 0x000055bc8fdb2e20 createdump`CrashInfo::EnumerateMemoryRegionsWithDAC(this=0x000055bc91c2eae0, dumpType=Triage) + 352 at crashinfo.cpp:410
frame #12: 0x00007fffc46fead0 0x000055bc8fda6f58 createdump`CreateDump(options=0x00007fffc4702cd0) + 1160 at createdumpunix.cpp:75
frame #13: 0x00007fffc4702c30 0x000055bc8fda59b7 createdump`createdump_main(argc=11, argv=0x00007fffc4702ec0) + 2199 at createdumpmain.cpp:222
frame #14: 0x00007fffc4702d30 0x000055bc8fda48e2 createdump`main(argc=11, argv=0x00007fffc4702e68) + 34 at main.cpp:20
frame #15: 0x00007fffc4702d60 0x00007f8568c8ad90 libc.so.6`__libc_start_call_main(main=(createdump`main at main.cpp:19), argc=11, argv=0x00007fffc4702e68) + 128 at libc_start_call_main.h:58
frame #16: 0x00007fffc4702e00 0x00007f8568c8ae40 libc.so.6`__libc_start_main_impl(main=(createdump`main at main.cpp:19), argc=11, argv=0x00007fffc4702e68, init=(_rtld_global), fini=<unavailable>, rtld_fini=<unavailable>, stack_end=0x00007fffc4702e58) + 128 at libc-start.c:392
frame #17: 0x00007fffc4702e50 0x000055bc8fda47f5 createdump`_start + 37(lldb) k

@mikem8361
mikem8361
requested a review
from jkotasJuly 16, 2024 01:47
@mikem8361mikem8361
self-assigned this
Jul 16, 2024
@ghostghost
added
the 
area-VM-coreclr

label
Jul 16, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 16, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
@jkotas
jkotas
commented
Jul 16, 2024

Copy link


Copy Markdown

Member
This is regression introduced by #101580
jkotas
jkotas
reviewed
Jul 16, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/methodtable.inl
Outdated


This was referenced Jul 16, 2024

Open


Closed


Closed


Closed

davidwrighton
davidwrighton
approved these changes
Jul 16, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/excep.cpp
@mikem8361mikem8361
mentioned this pull request
Jul 16, 2024
 Merged

@mikem8361
mikem8361
merged commit 5e7de53
into
dotnet:mainJul 16, 2024
@mikem8361
mikem8361
deleted the

dacenummem

branch
July 16, 2024 22:42
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 16, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas left review comments
@davidwrightondavidwrightondavidwrighton approved these changes

Assignees

@mikem8361mikem8361

Labels

area-VM-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mikem8361@jkotas@davidwrighton

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix crash in DAC enum memory code that brings down createdump by mikem8361 · Pull Request #104939 · dotnet/runtime · GitHub
Skip to content
Fix crash in DAC enum memory code that brings down createdump - #104939
Merged
mikem8361 merged 2 commits into
dotnet:mainfrom 
mikem8361:dacenummem
Jul 16, 2024
Merged
Fix crash in DAC enum memory code that brings down createdump#104939
mikem8361 merged 2 commits into
dotnet:mainfrom 
mikem8361:dacenummem
Conversation
@mikem8361
@mikem8361mikem8361
commented
Jul 16, 2024

Copy link


Copy Markdown

Contributor
Either a recent change in a MT's virtual method slot allocation or createdump is just getting unlucky now and the slot hasn't been filled in yet is causing this crash. The DAC EnumMemoryRegions API is calling ExceptionTypeOverridesStackTraceGetter() which enumerates all the virtual method slots in the ExceptionObject's MT looking for "get_StackTrace" and check if it has been overridden. All the code involved hasn't change in a very long time.
GetMethodDescForSlot gets called for a slot that has no PCODE (GetRestoredSlot() returns null). There is a comment in that function about slots not being filled in yet and code on the runtime side (ifdef'ed out in the DAC) that fills it in.
The stack trace of the crash:
* thread #1, name = 'createdump', stop reason = signal SIGSEGV: invalid address (fault address: 0x0)
* frame #0: 0x00007fffc46fc6c0 0x00007f8568876eed libmscordaccore.so`Precode::GetType(this=0x0000000000000000) + 29 at precode.h:447
frame #1: 0x00007fffc46fc6f0 0x00007f8568876dc9 libmscordaccore.so`Precode::GetPrecodeFromEntryPoint(addr=0, fSpeculative=YES) + 153 at precode.h:557
frame #2: 0x00007fffc46fc750 0x00007f8568880074 libmscordaccore.so`MethodDesc::GetMethodDescFromStubAddr(addr=0, fSpeculative=NO) + 52 at method.cpp:2628
frame #3: 0x00007fffc46fc7a0 0x00007f85688a692a libmscordaccore.so`MethodTable::GetMethodDescForSlotAddress(addr=0, fSpeculative=NO) + 90 at methodtable.cpp:6211
frame #4: 0x00007fffc46fc7d0 0x00007f856887ba41 libmscordaccore.so`MethodTable::GetMethodDescForSlot(this=0x00007f8565d9f030, slot=11) + 161 at methodtable.inl:426
frame #5: 0x00007fffc46fc810 0x00007f85688ccc93 libmscordaccore.so`ExceptionTypeOverridesStackTraceGetter(pMT=PTR_MethodTable @ 0x00007fffc46fcb50) + 259 at excep.cpp:7956
frame #6: 0x00007fffc46fc870 0x00007f856899b6de libmscordaccore.so`ClrDataAccess::DumpManagedExcepObject(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE, objRef=OBJECTREF @ 0x00007fffc46fd658) + 3422 at enummem.cpp:527
frame #7: 0x00007fffc46fcef0 0x00007f8568996abd libmscordaccore.so`ClrDataAccess::EnumMemDumpAllThreadsStack(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 909 at enummem.cpp:1143
frame #8: 0x00007fffc46fe360 0x00007f85689a1c28 libmscordaccore.so`ClrDataAccess::EnumMemoryRegionsWorkerMicroTriage(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 200 at enummem.cpp:1714
frame #9: 0x00007fffc46fe830 0x00007f85689a7809 libmscordaccore.so`ClrDataAccess::EnumMemoryRegionsWrapper(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 329 at enummem.cpp:1920
frame #10: 0x00007fffc46fe940 0x00007f85689a7f18 libmscordaccore.so`ClrDataAccess::EnumMemoryRegions(this=0x000055bc91c4d210, callback=0x000055bc91c2eae0, miniDumpFlags=1181100, flags=CLRDATA_ENUM_MEM_HEAP2) + 632 at enummem.cpp:2033
frame #11: 0x00007fffc46fea70 0x000055bc8fdb2e20 createdump`CrashInfo::EnumerateMemoryRegionsWithDAC(this=0x000055bc91c2eae0, dumpType=Triage) + 352 at crashinfo.cpp:410
frame #12: 0x00007fffc46fead0 0x000055bc8fda6f58 createdump`CreateDump(options=0x00007fffc4702cd0) + 1160 at createdumpunix.cpp:75
frame #13: 0x00007fffc4702c30 0x000055bc8fda59b7 createdump`createdump_main(argc=11, argv=0x00007fffc4702ec0) + 2199 at createdumpmain.cpp:222
frame #14: 0x00007fffc4702d30 0x000055bc8fda48e2 createdump`main(argc=11, argv=0x00007fffc4702e68) + 34 at main.cpp:20
frame #15: 0x00007fffc4702d60 0x00007f8568c8ad90 libc.so.6`__libc_start_call_main(main=(createdump`main at main.cpp:19), argc=11, argv=0x00007fffc4702e68) + 128 at libc_start_call_main.h:58
frame #16: 0x00007fffc4702e00 0x00007f8568c8ae40 libc.so.6`__libc_start_main_impl(main=(createdump`main at main.cpp:19), argc=11, argv=0x00007fffc4702e68, init=(_rtld_global), fini=<unavailable>, rtld_fini=<unavailable>, stack_end=0x00007fffc4702e58) + 128 at libc-start.c:392
frame #17: 0x00007fffc4702e50 0x000055bc8fda47f5 createdump`_start + 37(lldb) k

@mikem8361
mikem8361
requested a review
from jkotasJuly 16, 2024 01:47
@mikem8361mikem8361
self-assigned this
Jul 16, 2024
@ghostghost
added
the 
area-VM-coreclr

label
Jul 16, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 16, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
@jkotas
jkotas
commented
Jul 16, 2024

Copy link


Copy Markdown

Member
This is regression introduced by #101580
jkotas
jkotas
reviewed
Jul 16, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/methodtable.inl
Outdated


This was referenced Jul 16, 2024

Open


Closed


Closed


Closed

davidwrighton
davidwrighton
approved these changes
Jul 16, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/excep.cpp
@mikem8361mikem8361
mentioned this pull request
Jul 16, 2024
 Merged

@mikem8361
mikem8361
merged commit 5e7de53
into
dotnet:mainJul 16, 2024
@mikem8361
mikem8361
deleted the

dacenummem

branch
July 16, 2024 22:42
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 16, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas left review comments
@davidwrightondavidwrightondavidwrighton approved these changes

Assignees

@mikem8361mikem8361

Labels

area-VM-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mikem8361@jkotas@davidwrighton

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix crash in DAC enum memory code that brings down createdump by mikem8361 · Pull Request #104939 · dotnet/runtime · GitHub
Skip to content
Fix crash in DAC enum memory code that brings down createdump - #104939
Merged
mikem8361 merged 2 commits into
dotnet:mainfrom 
mikem8361:dacenummem
Jul 16, 2024
Merged
Fix crash in DAC enum memory code that brings down createdump#104939
mikem8361 merged 2 commits into
dotnet:mainfrom 
mikem8361:dacenummem
Conversation
@mikem8361
@mikem8361mikem8361
commented
Jul 16, 2024

Copy link


Copy Markdown

Contributor
Either a recent change in a MT's virtual method slot allocation or createdump is just getting unlucky now and the slot hasn't been filled in yet is causing this crash. The DAC EnumMemoryRegions API is calling ExceptionTypeOverridesStackTraceGetter() which enumerates all the virtual method slots in the ExceptionObject's MT looking for "get_StackTrace" and check if it has been overridden. All the code involved hasn't change in a very long time.
GetMethodDescForSlot gets called for a slot that has no PCODE (GetRestoredSlot() returns null). There is a comment in that function about slots not being filled in yet and code on the runtime side (ifdef'ed out in the DAC) that fills it in.
The stack trace of the crash:
* thread #1, name = 'createdump', stop reason = signal SIGSEGV: invalid address (fault address: 0x0)
* frame #0: 0x00007fffc46fc6c0 0x00007f8568876eed libmscordaccore.so`Precode::GetType(this=0x0000000000000000) + 29 at precode.h:447
frame #1: 0x00007fffc46fc6f0 0x00007f8568876dc9 libmscordaccore.so`Precode::GetPrecodeFromEntryPoint(addr=0, fSpeculative=YES) + 153 at precode.h:557
frame #2: 0x00007fffc46fc750 0x00007f8568880074 libmscordaccore.so`MethodDesc::GetMethodDescFromStubAddr(addr=0, fSpeculative=NO) + 52 at method.cpp:2628
frame #3: 0x00007fffc46fc7a0 0x00007f85688a692a libmscordaccore.so`MethodTable::GetMethodDescForSlotAddress(addr=0, fSpeculative=NO) + 90 at methodtable.cpp:6211
frame #4: 0x00007fffc46fc7d0 0x00007f856887ba41 libmscordaccore.so`MethodTable::GetMethodDescForSlot(this=0x00007f8565d9f030, slot=11) + 161 at methodtable.inl:426
frame #5: 0x00007fffc46fc810 0x00007f85688ccc93 libmscordaccore.so`ExceptionTypeOverridesStackTraceGetter(pMT=PTR_MethodTable @ 0x00007fffc46fcb50) + 259 at excep.cpp:7956
frame #6: 0x00007fffc46fc870 0x00007f856899b6de libmscordaccore.so`ClrDataAccess::DumpManagedExcepObject(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE, objRef=OBJECTREF @ 0x00007fffc46fd658) + 3422 at enummem.cpp:527
frame #7: 0x00007fffc46fcef0 0x00007f8568996abd libmscordaccore.so`ClrDataAccess::EnumMemDumpAllThreadsStack(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 909 at enummem.cpp:1143
frame #8: 0x00007fffc46fe360 0x00007f85689a1c28 libmscordaccore.so`ClrDataAccess::EnumMemoryRegionsWorkerMicroTriage(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 200 at enummem.cpp:1714
frame #9: 0x00007fffc46fe830 0x00007f85689a7809 libmscordaccore.so`ClrDataAccess::EnumMemoryRegionsWrapper(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 329 at enummem.cpp:1920
frame #10: 0x00007fffc46fe940 0x00007f85689a7f18 libmscordaccore.so`ClrDataAccess::EnumMemoryRegions(this=0x000055bc91c4d210, callback=0x000055bc91c2eae0, miniDumpFlags=1181100, flags=CLRDATA_ENUM_MEM_HEAP2) + 632 at enummem.cpp:2033
frame #11: 0x00007fffc46fea70 0x000055bc8fdb2e20 createdump`CrashInfo::EnumerateMemoryRegionsWithDAC(this=0x000055bc91c2eae0, dumpType=Triage) + 352 at crashinfo.cpp:410
frame #12: 0x00007fffc46fead0 0x000055bc8fda6f58 createdump`CreateDump(options=0x00007fffc4702cd0) + 1160 at createdumpunix.cpp:75
frame #13: 0x00007fffc4702c30 0x000055bc8fda59b7 createdump`createdump_main(argc=11, argv=0x00007fffc4702ec0) + 2199 at createdumpmain.cpp:222
frame #14: 0x00007fffc4702d30 0x000055bc8fda48e2 createdump`main(argc=11, argv=0x00007fffc4702e68) + 34 at main.cpp:20
frame #15: 0x00007fffc4702d60 0x00007f8568c8ad90 libc.so.6`__libc_start_call_main(main=(createdump`main at main.cpp:19), argc=11, argv=0x00007fffc4702e68) + 128 at libc_start_call_main.h:58
frame #16: 0x00007fffc4702e00 0x00007f8568c8ae40 libc.so.6`__libc_start_main_impl(main=(createdump`main at main.cpp:19), argc=11, argv=0x00007fffc4702e68, init=(_rtld_global), fini=<unavailable>, rtld_fini=<unavailable>, stack_end=0x00007fffc4702e58) + 128 at libc-start.c:392
frame #17: 0x00007fffc4702e50 0x000055bc8fda47f5 createdump`_start + 37(lldb) k

@mikem8361
mikem8361
requested a review
from jkotasJuly 16, 2024 01:47
@mikem8361mikem8361
self-assigned this
Jul 16, 2024
@ghostghost
added
the 
area-VM-coreclr

label
Jul 16, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 16, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
@jkotas
jkotas
commented
Jul 16, 2024

Copy link


Copy Markdown

Member
This is regression introduced by #101580
jkotas
jkotas
reviewed
Jul 16, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/methodtable.inl
Outdated


This was referenced Jul 16, 2024

Open


Closed


Closed


Closed

davidwrighton
davidwrighton
approved these changes
Jul 16, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/excep.cpp
@mikem8361mikem8361
mentioned this pull request
Jul 16, 2024
 Merged

@mikem8361
mikem8361
merged commit 5e7de53
into
dotnet:mainJul 16, 2024
@mikem8361
mikem8361
deleted the

dacenummem

branch
July 16, 2024 22:42
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 16, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas left review comments
@davidwrightondavidwrightondavidwrighton approved these changes

Assignees

@mikem8361mikem8361

Labels

area-VM-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mikem8361@jkotas@davidwrighton

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Fix crash in DAC enum memory code that brings down createdump by mikem8361 · Pull Request #104939 · dotnet/runtime · GitHub
Skip to content
Fix crash in DAC enum memory code that brings down createdump - #104939
Merged
mikem8361 merged 2 commits into
dotnet:mainfrom 
mikem8361:dacenummem
Jul 16, 2024
Merged
Fix crash in DAC enum memory code that brings down createdump#104939
mikem8361 merged 2 commits into
dotnet:mainfrom 
mikem8361:dacenummem
Conversation
@mikem8361
@mikem8361mikem8361
commented
Jul 16, 2024

Copy link


Copy Markdown

Contributor
Either a recent change in a MT's virtual method slot allocation or createdump is just getting unlucky now and the slot hasn't been filled in yet is causing this crash. The DAC EnumMemoryRegions API is calling ExceptionTypeOverridesStackTraceGetter() which enumerates all the virtual method slots in the ExceptionObject's MT looking for "get_StackTrace" and check if it has been overridden. All the code involved hasn't change in a very long time.
GetMethodDescForSlot gets called for a slot that has no PCODE (GetRestoredSlot() returns null). There is a comment in that function about slots not being filled in yet and code on the runtime side (ifdef'ed out in the DAC) that fills it in.
The stack trace of the crash:
* thread #1, name = 'createdump', stop reason = signal SIGSEGV: invalid address (fault address: 0x0)
* frame #0: 0x00007fffc46fc6c0 0x00007f8568876eed libmscordaccore.so`Precode::GetType(this=0x0000000000000000) + 29 at precode.h:447
frame #1: 0x00007fffc46fc6f0 0x00007f8568876dc9 libmscordaccore.so`Precode::GetPrecodeFromEntryPoint(addr=0, fSpeculative=YES) + 153 at precode.h:557
frame #2: 0x00007fffc46fc750 0x00007f8568880074 libmscordaccore.so`MethodDesc::GetMethodDescFromStubAddr(addr=0, fSpeculative=NO) + 52 at method.cpp:2628
frame #3: 0x00007fffc46fc7a0 0x00007f85688a692a libmscordaccore.so`MethodTable::GetMethodDescForSlotAddress(addr=0, fSpeculative=NO) + 90 at methodtable.cpp:6211
frame #4: 0x00007fffc46fc7d0 0x00007f856887ba41 libmscordaccore.so`MethodTable::GetMethodDescForSlot(this=0x00007f8565d9f030, slot=11) + 161 at methodtable.inl:426
frame #5: 0x00007fffc46fc810 0x00007f85688ccc93 libmscordaccore.so`ExceptionTypeOverridesStackTraceGetter(pMT=PTR_MethodTable @ 0x00007fffc46fcb50) + 259 at excep.cpp:7956
frame #6: 0x00007fffc46fc870 0x00007f856899b6de libmscordaccore.so`ClrDataAccess::DumpManagedExcepObject(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE, objRef=OBJECTREF @ 0x00007fffc46fd658) + 3422 at enummem.cpp:527
frame #7: 0x00007fffc46fcef0 0x00007f8568996abd libmscordaccore.so`ClrDataAccess::EnumMemDumpAllThreadsStack(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 909 at enummem.cpp:1143
frame #8: 0x00007fffc46fe360 0x00007f85689a1c28 libmscordaccore.so`ClrDataAccess::EnumMemoryRegionsWorkerMicroTriage(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 200 at enummem.cpp:1714
frame #9: 0x00007fffc46fe830 0x00007f85689a7809 libmscordaccore.so`ClrDataAccess::EnumMemoryRegionsWrapper(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 329 at enummem.cpp:1920
frame #10: 0x00007fffc46fe940 0x00007f85689a7f18 libmscordaccore.so`ClrDataAccess::EnumMemoryRegions(this=0x000055bc91c4d210, callback=0x000055bc91c2eae0, miniDumpFlags=1181100, flags=CLRDATA_ENUM_MEM_HEAP2) + 632 at enummem.cpp:2033
frame #11: 0x00007fffc46fea70 0x000055bc8fdb2e20 createdump`CrashInfo::EnumerateMemoryRegionsWithDAC(this=0x000055bc91c2eae0, dumpType=Triage) + 352 at crashinfo.cpp:410
frame #12: 0x00007fffc46fead0 0x000055bc8fda6f58 createdump`CreateDump(options=0x00007fffc4702cd0) + 1160 at createdumpunix.cpp:75
frame #13: 0x00007fffc4702c30 0x000055bc8fda59b7 createdump`createdump_main(argc=11, argv=0x00007fffc4702ec0) + 2199 at createdumpmain.cpp:222
frame #14: 0x00007fffc4702d30 0x000055bc8fda48e2 createdump`main(argc=11, argv=0x00007fffc4702e68) + 34 at main.cpp:20
frame #15: 0x00007fffc4702d60 0x00007f8568c8ad90 libc.so.6`__libc_start_call_main(main=(createdump`main at main.cpp:19), argc=11, argv=0x00007fffc4702e68) + 128 at libc_start_call_main.h:58
frame #16: 0x00007fffc4702e00 0x00007f8568c8ae40 libc.so.6`__libc_start_main_impl(main=(createdump`main at main.cpp:19), argc=11, argv=0x00007fffc4702e68, init=(_rtld_global), fini=<unavailable>, rtld_fini=<unavailable>, stack_end=0x00007fffc4702e58) + 128 at libc-start.c:392
frame #17: 0x00007fffc4702e50 0x000055bc8fda47f5 createdump`_start + 37(lldb) k

@mikem8361
mikem8361
requested a review
from jkotasJuly 16, 2024 01:47
@mikem8361mikem8361
self-assigned this
Jul 16, 2024
@ghostghost
added
the 
area-VM-coreclr

label
Jul 16, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 16, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
@jkotas
jkotas
commented
Jul 16, 2024

Copy link


Copy Markdown

Member
This is regression introduced by #101580
jkotas
jkotas
reviewed
Jul 16, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/methodtable.inl
Outdated


This was referenced Jul 16, 2024

Open


Closed


Closed


Closed

davidwrighton
davidwrighton
approved these changes
Jul 16, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/excep.cpp
@mikem8361mikem8361
mentioned this pull request
Jul 16, 2024
 Merged

@mikem8361
mikem8361
merged commit 5e7de53
into
dotnet:mainJul 16, 2024
@mikem8361
mikem8361
deleted the

dacenummem

branch
July 16, 2024 22:42
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 16, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas left review comments
@davidwrightondavidwrightondavidwrighton approved these changes

Assignees

@mikem8361mikem8361

Labels

area-VM-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mikem8361@jkotas@davidwrighton

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix crash in DAC enum memory code that brings down createdump by mikem8361 · Pull Request #104939 · dotnet/runtime · GitHub
Skip to content
Fix crash in DAC enum memory code that brings down createdump - #104939
Merged
mikem8361 merged 2 commits into
dotnet:mainfrom 
mikem8361:dacenummem
Jul 16, 2024
Merged
Fix crash in DAC enum memory code that brings down createdump#104939
mikem8361 merged 2 commits into
dotnet:mainfrom 
mikem8361:dacenummem
Conversation
@mikem8361
@mikem8361mikem8361
commented
Jul 16, 2024

Copy link


Copy Markdown

Contributor
Either a recent change in a MT's virtual method slot allocation or createdump is just getting unlucky now and the slot hasn't been filled in yet is causing this crash. The DAC EnumMemoryRegions API is calling ExceptionTypeOverridesStackTraceGetter() which enumerates all the virtual method slots in the ExceptionObject's MT looking for "get_StackTrace" and check if it has been overridden. All the code involved hasn't change in a very long time.
GetMethodDescForSlot gets called for a slot that has no PCODE (GetRestoredSlot() returns null). There is a comment in that function about slots not being filled in yet and code on the runtime side (ifdef'ed out in the DAC) that fills it in.
The stack trace of the crash:
* thread #1, name = 'createdump', stop reason = signal SIGSEGV: invalid address (fault address: 0x0)
* frame #0: 0x00007fffc46fc6c0 0x00007f8568876eed libmscordaccore.so`Precode::GetType(this=0x0000000000000000) + 29 at precode.h:447
frame #1: 0x00007fffc46fc6f0 0x00007f8568876dc9 libmscordaccore.so`Precode::GetPrecodeFromEntryPoint(addr=0, fSpeculative=YES) + 153 at precode.h:557
frame #2: 0x00007fffc46fc750 0x00007f8568880074 libmscordaccore.so`MethodDesc::GetMethodDescFromStubAddr(addr=0, fSpeculative=NO) + 52 at method.cpp:2628
frame #3: 0x00007fffc46fc7a0 0x00007f85688a692a libmscordaccore.so`MethodTable::GetMethodDescForSlotAddress(addr=0, fSpeculative=NO) + 90 at methodtable.cpp:6211
frame #4: 0x00007fffc46fc7d0 0x00007f856887ba41 libmscordaccore.so`MethodTable::GetMethodDescForSlot(this=0x00007f8565d9f030, slot=11) + 161 at methodtable.inl:426
frame #5: 0x00007fffc46fc810 0x00007f85688ccc93 libmscordaccore.so`ExceptionTypeOverridesStackTraceGetter(pMT=PTR_MethodTable @ 0x00007fffc46fcb50) + 259 at excep.cpp:7956
frame #6: 0x00007fffc46fc870 0x00007f856899b6de libmscordaccore.so`ClrDataAccess::DumpManagedExcepObject(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE, objRef=OBJECTREF @ 0x00007fffc46fd658) + 3422 at enummem.cpp:527
frame #7: 0x00007fffc46fcef0 0x00007f8568996abd libmscordaccore.so`ClrDataAccess::EnumMemDumpAllThreadsStack(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 909 at enummem.cpp:1143
frame #8: 0x00007fffc46fe360 0x00007f85689a1c28 libmscordaccore.so`ClrDataAccess::EnumMemoryRegionsWorkerMicroTriage(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 200 at enummem.cpp:1714
frame #9: 0x00007fffc46fe830 0x00007f85689a7809 libmscordaccore.so`ClrDataAccess::EnumMemoryRegionsWrapper(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 329 at enummem.cpp:1920
frame #10: 0x00007fffc46fe940 0x00007f85689a7f18 libmscordaccore.so`ClrDataAccess::EnumMemoryRegions(this=0x000055bc91c4d210, callback=0x000055bc91c2eae0, miniDumpFlags=1181100, flags=CLRDATA_ENUM_MEM_HEAP2) + 632 at enummem.cpp:2033
frame #11: 0x00007fffc46fea70 0x000055bc8fdb2e20 createdump`CrashInfo::EnumerateMemoryRegionsWithDAC(this=0x000055bc91c2eae0, dumpType=Triage) + 352 at crashinfo.cpp:410
frame #12: 0x00007fffc46fead0 0x000055bc8fda6f58 createdump`CreateDump(options=0x00007fffc4702cd0) + 1160 at createdumpunix.cpp:75
frame #13: 0x00007fffc4702c30 0x000055bc8fda59b7 createdump`createdump_main(argc=11, argv=0x00007fffc4702ec0) + 2199 at createdumpmain.cpp:222
frame #14: 0x00007fffc4702d30 0x000055bc8fda48e2 createdump`main(argc=11, argv=0x00007fffc4702e68) + 34 at main.cpp:20
frame #15: 0x00007fffc4702d60 0x00007f8568c8ad90 libc.so.6`__libc_start_call_main(main=(createdump`main at main.cpp:19), argc=11, argv=0x00007fffc4702e68) + 128 at libc_start_call_main.h:58
frame #16: 0x00007fffc4702e00 0x00007f8568c8ae40 libc.so.6`__libc_start_main_impl(main=(createdump`main at main.cpp:19), argc=11, argv=0x00007fffc4702e68, init=(_rtld_global), fini=<unavailable>, rtld_fini=<unavailable>, stack_end=0x00007fffc4702e58) + 128 at libc-start.c:392
frame #17: 0x00007fffc4702e50 0x000055bc8fda47f5 createdump`_start + 37(lldb) k

@mikem8361
mikem8361
requested a review
from jkotasJuly 16, 2024 01:47
@mikem8361mikem8361
self-assigned this
Jul 16, 2024
@ghostghost
added
the 
area-VM-coreclr

label
Jul 16, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 16, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
@jkotas
jkotas
commented
Jul 16, 2024

Copy link


Copy Markdown

Member
This is regression introduced by #101580
jkotas
jkotas
reviewed
Jul 16, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/methodtable.inl
Outdated


This was referenced Jul 16, 2024

Open


Closed


Closed


Closed

davidwrighton
davidwrighton
approved these changes
Jul 16, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/excep.cpp
@mikem8361mikem8361
mentioned this pull request
Jul 16, 2024
 Merged

@mikem8361
mikem8361
merged commit 5e7de53
into
dotnet:mainJul 16, 2024
@mikem8361
mikem8361
deleted the

dacenummem

branch
July 16, 2024 22:42
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 16, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas left review comments
@davidwrightondavidwrightondavidwrighton approved these changes

Assignees

@mikem8361mikem8361

Labels

area-VM-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mikem8361@jkotas@davidwrighton

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Fix crash in DAC enum memory code that brings down createdump by mikem8361 · Pull Request #104939 · dotnet/runtime · GitHub
Skip to content
Fix crash in DAC enum memory code that brings down createdump - #104939
Merged
mikem8361 merged 2 commits into
dotnet:mainfrom 
mikem8361:dacenummem
Jul 16, 2024
Merged
Fix crash in DAC enum memory code that brings down createdump#104939
mikem8361 merged 2 commits into
dotnet:mainfrom 
mikem8361:dacenummem
Conversation
@mikem8361
@mikem8361mikem8361
commented
Jul 16, 2024

Copy link


Copy Markdown

Contributor
Either a recent change in a MT's virtual method slot allocation or createdump is just getting unlucky now and the slot hasn't been filled in yet is causing this crash. The DAC EnumMemoryRegions API is calling ExceptionTypeOverridesStackTraceGetter() which enumerates all the virtual method slots in the ExceptionObject's MT looking for "get_StackTrace" and check if it has been overridden. All the code involved hasn't change in a very long time.
GetMethodDescForSlot gets called for a slot that has no PCODE (GetRestoredSlot() returns null). There is a comment in that function about slots not being filled in yet and code on the runtime side (ifdef'ed out in the DAC) that fills it in.
The stack trace of the crash:
* thread #1, name = 'createdump', stop reason = signal SIGSEGV: invalid address (fault address: 0x0)
* frame #0: 0x00007fffc46fc6c0 0x00007f8568876eed libmscordaccore.so`Precode::GetType(this=0x0000000000000000) + 29 at precode.h:447
frame #1: 0x00007fffc46fc6f0 0x00007f8568876dc9 libmscordaccore.so`Precode::GetPrecodeFromEntryPoint(addr=0, fSpeculative=YES) + 153 at precode.h:557
frame #2: 0x00007fffc46fc750 0x00007f8568880074 libmscordaccore.so`MethodDesc::GetMethodDescFromStubAddr(addr=0, fSpeculative=NO) + 52 at method.cpp:2628
frame #3: 0x00007fffc46fc7a0 0x00007f85688a692a libmscordaccore.so`MethodTable::GetMethodDescForSlotAddress(addr=0, fSpeculative=NO) + 90 at methodtable.cpp:6211
frame #4: 0x00007fffc46fc7d0 0x00007f856887ba41 libmscordaccore.so`MethodTable::GetMethodDescForSlot(this=0x00007f8565d9f030, slot=11) + 161 at methodtable.inl:426
frame #5: 0x00007fffc46fc810 0x00007f85688ccc93 libmscordaccore.so`ExceptionTypeOverridesStackTraceGetter(pMT=PTR_MethodTable @ 0x00007fffc46fcb50) + 259 at excep.cpp:7956
frame #6: 0x00007fffc46fc870 0x00007f856899b6de libmscordaccore.so`ClrDataAccess::DumpManagedExcepObject(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE, objRef=OBJECTREF @ 0x00007fffc46fd658) + 3422 at enummem.cpp:527
frame #7: 0x00007fffc46fcef0 0x00007f8568996abd libmscordaccore.so`ClrDataAccess::EnumMemDumpAllThreadsStack(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 909 at enummem.cpp:1143
frame #8: 0x00007fffc46fe360 0x00007f85689a1c28 libmscordaccore.so`ClrDataAccess::EnumMemoryRegionsWorkerMicroTriage(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 200 at enummem.cpp:1714
frame #9: 0x00007fffc46fe830 0x00007f85689a7809 libmscordaccore.so`ClrDataAccess::EnumMemoryRegionsWrapper(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 329 at enummem.cpp:1920
frame #10: 0x00007fffc46fe940 0x00007f85689a7f18 libmscordaccore.so`ClrDataAccess::EnumMemoryRegions(this=0x000055bc91c4d210, callback=0x000055bc91c2eae0, miniDumpFlags=1181100, flags=CLRDATA_ENUM_MEM_HEAP2) + 632 at enummem.cpp:2033
frame #11: 0x00007fffc46fea70 0x000055bc8fdb2e20 createdump`CrashInfo::EnumerateMemoryRegionsWithDAC(this=0x000055bc91c2eae0, dumpType=Triage) + 352 at crashinfo.cpp:410
frame #12: 0x00007fffc46fead0 0x000055bc8fda6f58 createdump`CreateDump(options=0x00007fffc4702cd0) + 1160 at createdumpunix.cpp:75
frame #13: 0x00007fffc4702c30 0x000055bc8fda59b7 createdump`createdump_main(argc=11, argv=0x00007fffc4702ec0) + 2199 at createdumpmain.cpp:222
frame #14: 0x00007fffc4702d30 0x000055bc8fda48e2 createdump`main(argc=11, argv=0x00007fffc4702e68) + 34 at main.cpp:20
frame #15: 0x00007fffc4702d60 0x00007f8568c8ad90 libc.so.6`__libc_start_call_main(main=(createdump`main at main.cpp:19), argc=11, argv=0x00007fffc4702e68) + 128 at libc_start_call_main.h:58
frame #16: 0x00007fffc4702e00 0x00007f8568c8ae40 libc.so.6`__libc_start_main_impl(main=(createdump`main at main.cpp:19), argc=11, argv=0x00007fffc4702e68, init=(_rtld_global), fini=<unavailable>, rtld_fini=<unavailable>, stack_end=0x00007fffc4702e58) + 128 at libc-start.c:392
frame #17: 0x00007fffc4702e50 0x000055bc8fda47f5 createdump`_start + 37(lldb) k

@mikem8361
mikem8361
requested a review
from jkotasJuly 16, 2024 01:47
@mikem8361mikem8361
self-assigned this
Jul 16, 2024
@ghostghost
added
the 
area-VM-coreclr

label
Jul 16, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 16, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
@jkotas
jkotas
commented
Jul 16, 2024

Copy link


Copy Markdown

Member
This is regression introduced by #101580
jkotas
jkotas
reviewed
Jul 16, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/methodtable.inl
Outdated


This was referenced Jul 16, 2024

Open


Closed


Closed


Closed

davidwrighton
davidwrighton
approved these changes
Jul 16, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/excep.cpp
@mikem8361mikem8361
mentioned this pull request
Jul 16, 2024
 Merged

@mikem8361
mikem8361
merged commit 5e7de53
into
dotnet:mainJul 16, 2024
@mikem8361
mikem8361
deleted the

dacenummem

branch
July 16, 2024 22:42
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 16, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas left review comments
@davidwrightondavidwrightondavidwrighton approved these changes

Assignees

@mikem8361mikem8361

Labels

area-VM-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mikem8361@jkotas@davidwrighton

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Fix crash in DAC enum memory code that brings down createdump by mikem8361 · Pull Request #104939 · dotnet/runtime · GitHub
Skip to content
Fix crash in DAC enum memory code that brings down createdump - #104939
Merged
mikem8361 merged 2 commits into
dotnet:mainfrom 
mikem8361:dacenummem
Jul 16, 2024
Merged
Fix crash in DAC enum memory code that brings down createdump#104939
mikem8361 merged 2 commits into
dotnet:mainfrom 
mikem8361:dacenummem
Conversation
@mikem8361
@mikem8361mikem8361
commented
Jul 16, 2024

Copy link


Copy Markdown

Contributor
Either a recent change in a MT's virtual method slot allocation or createdump is just getting unlucky now and the slot hasn't been filled in yet is causing this crash. The DAC EnumMemoryRegions API is calling ExceptionTypeOverridesStackTraceGetter() which enumerates all the virtual method slots in the ExceptionObject's MT looking for "get_StackTrace" and check if it has been overridden. All the code involved hasn't change in a very long time.
GetMethodDescForSlot gets called for a slot that has no PCODE (GetRestoredSlot() returns null). There is a comment in that function about slots not being filled in yet and code on the runtime side (ifdef'ed out in the DAC) that fills it in.
The stack trace of the crash:
* thread #1, name = 'createdump', stop reason = signal SIGSEGV: invalid address (fault address: 0x0)
* frame #0: 0x00007fffc46fc6c0 0x00007f8568876eed libmscordaccore.so`Precode::GetType(this=0x0000000000000000) + 29 at precode.h:447
frame #1: 0x00007fffc46fc6f0 0x00007f8568876dc9 libmscordaccore.so`Precode::GetPrecodeFromEntryPoint(addr=0, fSpeculative=YES) + 153 at precode.h:557
frame #2: 0x00007fffc46fc750 0x00007f8568880074 libmscordaccore.so`MethodDesc::GetMethodDescFromStubAddr(addr=0, fSpeculative=NO) + 52 at method.cpp:2628
frame #3: 0x00007fffc46fc7a0 0x00007f85688a692a libmscordaccore.so`MethodTable::GetMethodDescForSlotAddress(addr=0, fSpeculative=NO) + 90 at methodtable.cpp:6211
frame #4: 0x00007fffc46fc7d0 0x00007f856887ba41 libmscordaccore.so`MethodTable::GetMethodDescForSlot(this=0x00007f8565d9f030, slot=11) + 161 at methodtable.inl:426
frame #5: 0x00007fffc46fc810 0x00007f85688ccc93 libmscordaccore.so`ExceptionTypeOverridesStackTraceGetter(pMT=PTR_MethodTable @ 0x00007fffc46fcb50) + 259 at excep.cpp:7956
frame #6: 0x00007fffc46fc870 0x00007f856899b6de libmscordaccore.so`ClrDataAccess::DumpManagedExcepObject(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE, objRef=OBJECTREF @ 0x00007fffc46fd658) + 3422 at enummem.cpp:527
frame #7: 0x00007fffc46fcef0 0x00007f8568996abd libmscordaccore.so`ClrDataAccess::EnumMemDumpAllThreadsStack(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 909 at enummem.cpp:1143
frame #8: 0x00007fffc46fe360 0x00007f85689a1c28 libmscordaccore.so`ClrDataAccess::EnumMemoryRegionsWorkerMicroTriage(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 200 at enummem.cpp:1714
frame #9: 0x00007fffc46fe830 0x00007f85689a7809 libmscordaccore.so`ClrDataAccess::EnumMemoryRegionsWrapper(this=0x000055bc91c4d210, flags=CLRDATA_ENUM_MEM_TRIAGE) + 329 at enummem.cpp:1920
frame #10: 0x00007fffc46fe940 0x00007f85689a7f18 libmscordaccore.so`ClrDataAccess::EnumMemoryRegions(this=0x000055bc91c4d210, callback=0x000055bc91c2eae0, miniDumpFlags=1181100, flags=CLRDATA_ENUM_MEM_HEAP2) + 632 at enummem.cpp:2033
frame #11: 0x00007fffc46fea70 0x000055bc8fdb2e20 createdump`CrashInfo::EnumerateMemoryRegionsWithDAC(this=0x000055bc91c2eae0, dumpType=Triage) + 352 at crashinfo.cpp:410
frame #12: 0x00007fffc46fead0 0x000055bc8fda6f58 createdump`CreateDump(options=0x00007fffc4702cd0) + 1160 at createdumpunix.cpp:75
frame #13: 0x00007fffc4702c30 0x000055bc8fda59b7 createdump`createdump_main(argc=11, argv=0x00007fffc4702ec0) + 2199 at createdumpmain.cpp:222
frame #14: 0x00007fffc4702d30 0x000055bc8fda48e2 createdump`main(argc=11, argv=0x00007fffc4702e68) + 34 at main.cpp:20
frame #15: 0x00007fffc4702d60 0x00007f8568c8ad90 libc.so.6`__libc_start_call_main(main=(createdump`main at main.cpp:19), argc=11, argv=0x00007fffc4702e68) + 128 at libc_start_call_main.h:58
frame #16: 0x00007fffc4702e00 0x00007f8568c8ae40 libc.so.6`__libc_start_main_impl(main=(createdump`main at main.cpp:19), argc=11, argv=0x00007fffc4702e68, init=(_rtld_global), fini=<unavailable>, rtld_fini=<unavailable>, stack_end=0x00007fffc4702e58) + 128 at libc-start.c:392
frame #17: 0x00007fffc4702e50 0x000055bc8fda47f5 createdump`_start + 37(lldb) k

@mikem8361
mikem8361
requested a review
from jkotasJuly 16, 2024 01:47
@mikem8361mikem8361
self-assigned this
Jul 16, 2024
@ghostghost
added
the 
area-VM-coreclr

label
Jul 16, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Jul 16, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
@jkotas
jkotas
commented
Jul 16, 2024

Copy link


Copy Markdown

Member
This is regression introduced by #101580
jkotas
jkotas
reviewed
Jul 16, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/methodtable.inl
Outdated


This was referenced Jul 16, 2024

Open


Closed


Closed


Closed

davidwrighton
davidwrighton
approved these changes
Jul 16, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/excep.cpp
@mikem8361mikem8361
mentioned this pull request
Jul 16, 2024
 Merged

@mikem8361
mikem8361
merged commit 5e7de53
into
dotnet:mainJul 16, 2024
@mikem8361
mikem8361
deleted the

dacenummem

branch
July 16, 2024 22:42
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Aug 16, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@jkotasjkotasjkotas left review comments
@davidwrightondavidwrightondavidwrighton approved these changes

Assignees

@mikem8361mikem8361

Labels

area-VM-coreclr

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@mikem8361@jkotas@davidwrighton