Uh oh!
There was an error while loading. Please reload this page.
ILLink analyzer: add warnings for DAM on type - #105994
Merged
Merged
Conversation
Instead, report them immediately.
ReflectionAccessAnalyzer will need to be able to produce diagnostics with differing locations for a single call to GetReflectionAccessDiagnostics, to support warnings for DynamicallyAccessedMembers on type. This matches ReflectionMarker in ILLink and ILC, where MarkTypeForDynamicallyAccessedMembers takes a MessageOrigin rather than a DiagnosticContext.
sbomer
commented
Aug 13, 2024
MemberAuthor
@dotnet/illink PTAL |
jtschuster
approved these changes
Aug 16, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Fix typos
This was referenced Aug 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements analyzer warnings for DynamicallyAccessedMembers annotations on types.
The warnings are generated the same way ILLink does in "library mode" - so the presence of DAM on a type is sufficient to warn on any referenced members that have RUC or DAM annotations. It doesn't need object.GetType() to be called on an instance of a derived type.
Fixes#104742
Fixes#102002
Depends on #105956