Uh oh!
There was an error while loading. Please reload this page.
Add DiagnosticSource to CheckNonEventSourcesRunning - #106337
Merged
matouskozak merged 2 commits intoAug 14, 2024
Merged
Conversation
matouskozak
commented
Aug 13, 2024
MemberAuthor
/azp run runtime-ioslikesimulator |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tarekgh
commented
Aug 13, 2024
Member
CC @davmason |
matouskozak
marked this pull request as ready for review
August 14, 2024 06:56
matouskozak
requested review from
antonfirsov, mikelle-rogers, tommcdon and vitek-karasAugust 14, 2024 06:56
vitek-karas
approved these changes
Aug 14, 2024
matouskozak
deleted the
add-DiagnosticSource-to-CheckNonEventSourcesRunning
branch
October 3, 2024 13:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The introduction of
ActiveSourcesinSystem.Net(#103922) started causing failures whereMicrosoft-Diagnostics-DiagnosticSourceruns on iOS tests which wasn't expected. This PR addsMicrosoft-Diagnostics-DiagnosticSourceto theCheckNoEventSourcesRunningbuilt-inEventSourcelist so that it's no longer considered as running (suggested at #104881 (comment)).Should fix#104881