Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions src/coreclr/inc/corinfo.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -930,7 +930,6 @@ struct PatchpointInfo;
// Cookie types consumed by the code generator (these are opaque values
// not inspected by the code generator):

typedef struct CORINFO_ASSEMBLY_STRUCT_* CORINFO_ASSEMBLY_HANDLE;
typedef struct CORINFO_MODULE_STRUCT_* CORINFO_MODULE_HANDLE;
typedef struct CORINFO_DEPENDENCY_STRUCT_* CORINFO_DEPENDENCY_HANDLE;
typedef struct CORINFO_CLASS_STRUCT_* CORINFO_CLASS_HANDLE;
Expand DownExpand Up@@ -2321,18 +2320,9 @@ class ICorStaticInfo
CORINFO_CLASS_HANDLE cls
) = 0;

virtual CORINFO_MODULE_HANDLE getClassModule (
CORINFO_CLASS_HANDLE cls
) = 0;

// Returns the assembly that contains the module "mod".
virtual CORINFO_ASSEMBLY_HANDLE getModuleAssembly (
Comment thread
hez2010 marked this conversation as resolved.
CORINFO_MODULE_HANDLE mod
) = 0;

// Returns the name of the assembly "assem".
virtual const char* getAssemblyName (
CORINFO_ASSEMBLY_HANDLE assem
// Returns the assembly name of the class "cls", or nullptr if there is none.
virtual const char* getClassAssemblyName (
CORINFO_CLASS_HANDLE cls
) = 0;

// Allocate and delete process-lifetime objects. Should only be
Expand Down
8 changes: 1 addition & 7 deletions src/coreclr/inc/icorjitinfoimpl_generated.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -193,15 +193,9 @@ bool isValueClass(
uint32_t getClassAttribs(
CORINFO_CLASS_HANDLE cls) override;

CORINFO_MODULE_HANDLE getClassModule(
const char* getClassAssemblyName(
CORINFO_CLASS_HANDLE cls) override;

CORINFO_ASSEMBLY_HANDLE getModuleAssembly(
CORINFO_MODULE_HANDLE mod) override;

const char* getAssemblyName(
CORINFO_ASSEMBLY_HANDLE assem) override;

void* LongLifetimeMalloc(
size_t sz) override;

Expand Down
10 changes: 5 additions & 5 deletions src/coreclr/inc/jiteeversionguid.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,11 +43,11 @@ typedef const GUID *LPCGUID;
#define GUID_DEFINED
#endif // !GUID_DEFINED

constexpr GUID JITEEVersionIdentifier = { /* 7f7fd340-4779-455a-8046-628f3cd8c3c7 */
0x7f7fd340,
0x4779,
0x455a,
{0x80, 0x46, 0x62, 0x8f, 0x3c, 0xd8, 0xc3, 0xc7}
constexpr GUID JITEEVersionIdentifier = { /* b75a5475-ff22-4078-9551-2024ce03d383 */
0xb75a5475,
0xff22,
0x4078,
{0x95, 0x51, 0x20, 0x24, 0xce, 0x03, 0xd3, 0x83}
};

//////////////////////////////////////////////////////////////////////////////////////////////////////////
Expand Down
4 changes: 1 addition & 3 deletions src/coreclr/jit/ICorJitInfo_names_generated.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,9 +45,7 @@ DEF_CLR_API(getTypeInstantiationArgument)
DEF_CLR_API(printClassName)
DEF_CLR_API(isValueClass)
DEF_CLR_API(getClassAttribs)
DEF_CLR_API(getClassModule)
DEF_CLR_API(getModuleAssembly)
DEF_CLR_API(getAssemblyName)
DEF_CLR_API(getClassAssemblyName)
DEF_CLR_API(LongLifetimeMalloc)
DEF_CLR_API(LongLifetimeFree)
DEF_CLR_API(getIsClassInitedFlagAddress)
Expand Down
26 changes: 4 additions & 22 deletions src/coreclr/jit/ICorJitInfo_wrapper_generated.hpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -416,30 +416,12 @@ uint32_t WrapICorJitInfo::getClassAttribs(
return temp;
}

CORINFO_MODULE_HANDLE WrapICorJitInfo::getClassModule(
const char* WrapICorJitInfo::getClassAssemblyName(
CORINFO_CLASS_HANDLE cls)
{
API_ENTER(getClassModule);
CORINFO_MODULE_HANDLE temp = wrapHnd->getClassModule(cls);
API_LEAVE(getClassModule);
return temp;
}

CORINFO_ASSEMBLY_HANDLE WrapICorJitInfo::getModuleAssembly(
CORINFO_MODULE_HANDLE mod)
{
API_ENTER(getModuleAssembly);
CORINFO_ASSEMBLY_HANDLE temp = wrapHnd->getModuleAssembly(mod);
API_LEAVE(getModuleAssembly);
return temp;
}

const char* WrapICorJitInfo::getAssemblyName(
CORINFO_ASSEMBLY_HANDLE assem)
{
API_ENTER(getAssemblyName);
const char* temp = wrapHnd->getAssemblyName(assem);
API_LEAVE(getAssemblyName);
API_ENTER(getClassAssemblyName);
const char* temp = wrapHnd->getClassAssemblyName(cls);
API_LEAVE(getClassAssemblyName);
return temp;
}

Expand Down
53 changes: 20 additions & 33 deletions src/coreclr/jit/compiler.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -2586,8 +2586,7 @@ void Compiler::compInitOptions(JitFlags* jitFlags)
// We have an exclusion list. See if this method is in an assembly that is on the list.
// Note that we check this for every method, since we might inline across modules, and
// if the inlinee module is on the list, we don't want to use the altjit for it.
const char* methodAssemblyName = info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
const char* methodAssemblyName = eeGetClassAssemblyName(info.compClassHnd);
if (s_pAltJitExcludeAssembliesList->IsInList(methodAssemblyName))
{
opts.altJit = false;
Expand All@@ -2614,8 +2613,7 @@ void Compiler::compInitOptions(JitFlags* jitFlags)
bool assemblyInIncludeList = true; // assume we'll dump, if there's not an include list (or it's empty).
if (s_pJitDisasmIncludeAssembliesList != nullptr && !s_pJitDisasmIncludeAssembliesList->IsEmpty())
{
const char* assemblyName = info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
const char* assemblyName = eeGetClassAssemblyName(info.compClassHnd);
if (!s_pJitDisasmIncludeAssembliesList->IsInList(assemblyName))
{
Comment thread
hez2010 marked this conversation as resolved.
// We have a list, and the current assembly is not in it, so we won't dump.
Expand DownExpand Up@@ -6335,39 +6333,29 @@ int Compiler::compCompile(CORINFO_MODULE_HANDLE classPtr,
#ifdef DEBUG
if (JitConfig.EnableExtraSuperPmiQueries())
{
// This call to getClassModule/getModuleAssembly/getAssemblyName fails in crossgen2 due to these
// APIs being unimplemented. So disable this extra info for pre-jit mode. See
// https://github.com/dotnet/runtime/issues/48888.
//
// Ditto for some of the class name queries for generic params.
//
if (!compileFlags->IsSet(JitFlags::JIT_FLAG_PREJIT))
{
// Get the assembly name, to aid finding any particular SuperPMI method context function
(void)info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
// Get the assembly name, to aid finding any particular SuperPMI method context function
(void)eeGetClassAssemblyName(info.compClassHnd);

// Fetch class names for the method's generic parameters.
//
CORINFO_SIG_INFO sig;
info.compCompHnd->getMethodSig(info.compMethodHnd, &sig, nullptr);
// Fetch class names for the method's generic parameters.
//
CORINFO_SIG_INFO sig;
info.compCompHnd->getMethodSig(info.compMethodHnd, &sig, nullptr);

const unsigned classInst = sig.sigInst.classInstCount;
if (classInst > 0)
const unsigned classInst = sig.sigInst.classInstCount;
if (classInst > 0)
{
for (unsigned i = 0; i < classInst; i++)
{
for (unsigned i = 0; i < classInst; i++)
{
eeGetClassName(sig.sigInst.classInst[i]);
}
eeGetClassName(sig.sigInst.classInst[i]);
}
}

const unsigned methodInst = sig.sigInst.methInstCount;
if (methodInst > 0)
const unsigned methodInst = sig.sigInst.methInstCount;
if (methodInst > 0)
{
for (unsigned i = 0; i < methodInst; i++)
{
for (unsigned i = 0; i < methodInst; i++)
{
eeGetClassName(sig.sigInst.methInst[i]);
}
eeGetClassName(sig.sigInst.methInst[i]);
}
}
}
Expand DownExpand Up@@ -9221,8 +9209,7 @@ void JitTimer::PrintCsvMethodStats(Compiler* comp)
}
else
{
const char* methodAssemblyName = comp->info.compCompHnd->getAssemblyName(
comp->info.compCompHnd->getModuleAssembly(comp->info.compCompHnd->getClassModule(comp->info.compClassHnd)));
const char* methodAssemblyName = comp->eeGetClassAssemblyName(comp->info.compClassHnd);
fprintf(s_csvFile, "\"%s\",", methodAssemblyName);
}
fprintf(s_csvFile, "%u,", comp->info.compILCodeSize);
Expand Down
2 changes: 2 additions & 0 deletions src/coreclr/jit/compiler.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -8337,6 +8337,8 @@ class Compiler
void eePrintObjectDescription(const char* prefix, CORINFO_OBJECT_HANDLE handle);
const char* eeGetShortClassName(CORINFO_CLASS_HANDLE clsHnd);

const char* eeGetClassAssemblyName(CORINFO_CLASS_HANDLE clsHnd);

#if defined(DEBUG)
unsigned eeTryGetClassSize(CORINFO_CLASS_HANDLE clsHnd);
#endif
Expand Down
21 changes: 21 additions & 0 deletions src/coreclr/jit/eeinterface.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -596,6 +596,27 @@ const char* Compiler::eeGetShortClassName(CORINFO_CLASS_HANDLE clsHnd)
return printer.GetBuffer();
}

//------------------------------------------------------------------------
// eeGetClassAssemblyName:
// Get the assembly name of a type.
// If missing information (in SPMI), then return a placeholder string.
//
// Parameters:
// clsHnd - the handle of the class
//
// Return value:
// The name string.
//
const char* Compiler::eeGetClassAssemblyName(CORINFO_CLASS_HANDLE clsHnd)
{
const char* assemblyName = "<unknown assembly>";
eeRunFunctorWithSPMIErrorTrap([&]() {
assemblyName = info.compCompHnd->getClassAssemblyName(clsHnd);
});

return assemblyName != nullptr ? assemblyName : "<no assembly>";
}

void Compiler::eePrintObjectDescription(const char* prefix, CORINFO_OBJECT_HANDLE handle)
{
const size_t maxStrSize = 64;
Expand Down
17 changes: 11 additions & 6 deletions src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs
Original file line numberDiff line numberDiff line change
Expand Up@@ -2092,12 +2092,17 @@ private uint getClassAttribsInternal(TypeDesc type)
return (uint)result;
}

private CORINFO_MODULE_STRUCT_* getClassModule(CORINFO_CLASS_STRUCT_* cls)
{ throw new NotImplementedException("getClassModule"); }
private CORINFO_ASSEMBLY_STRUCT_* getModuleAssembly(CORINFO_MODULE_STRUCT_* mod)
{ throw new NotImplementedException("getModuleAssembly"); }
private byte* getAssemblyName(CORINFO_ASSEMBLY_STRUCT_* assem)
{ throw new NotImplementedException("getAssemblyName"); }
private byte* getClassAssemblyName(CORINFO_CLASS_STRUCT_* cls)
{
TypeDesc type = HandleToObject(cls);

if (type is MetadataType mdType)
{
return (byte*)GetPin(StringToUTF8(mdType.Module.Assembly.GetName().Name));
}

return null;
}

#pragma warning disable CA1822 // Mark members as static
private void* LongLifetimeMalloc(UIntPtr sz)
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions src/coreclr/inc/corinfo.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -930,7 +930,6 @@ struct PatchpointInfo;
// Cookie types consumed by the code generator (these are opaque values
// not inspected by the code generator):

typedef struct CORINFO_ASSEMBLY_STRUCT_* CORINFO_ASSEMBLY_HANDLE;
typedef struct CORINFO_MODULE_STRUCT_* CORINFO_MODULE_HANDLE;
typedef struct CORINFO_DEPENDENCY_STRUCT_* CORINFO_DEPENDENCY_HANDLE;
typedef struct CORINFO_CLASS_STRUCT_* CORINFO_CLASS_HANDLE;
Expand DownExpand Up@@ -2321,18 +2320,9 @@ class ICorStaticInfo
CORINFO_CLASS_HANDLE cls
) = 0;

virtual CORINFO_MODULE_HANDLE getClassModule (
CORINFO_CLASS_HANDLE cls
) = 0;

// Returns the assembly that contains the module "mod".
virtual CORINFO_ASSEMBLY_HANDLE getModuleAssembly (
Comment thread
hez2010 marked this conversation as resolved.
CORINFO_MODULE_HANDLE mod
) = 0;

// Returns the name of the assembly "assem".
virtual const char* getAssemblyName (
CORINFO_ASSEMBLY_HANDLE assem
// Returns the assembly name of the class "cls", or nullptr if there is none.
virtual const char* getClassAssemblyName (
CORINFO_CLASS_HANDLE cls
) = 0;

// Allocate and delete process-lifetime objects. Should only be
Expand Down
8 changes: 1 addition & 7 deletions src/coreclr/inc/icorjitinfoimpl_generated.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -193,15 +193,9 @@ bool isValueClass(
uint32_t getClassAttribs(
CORINFO_CLASS_HANDLE cls) override;

CORINFO_MODULE_HANDLE getClassModule(
const char* getClassAssemblyName(
CORINFO_CLASS_HANDLE cls) override;

CORINFO_ASSEMBLY_HANDLE getModuleAssembly(
CORINFO_MODULE_HANDLE mod) override;

const char* getAssemblyName(
CORINFO_ASSEMBLY_HANDLE assem) override;

void* LongLifetimeMalloc(
size_t sz) override;

Expand Down
10 changes: 5 additions & 5 deletions src/coreclr/inc/jiteeversionguid.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,11 +43,11 @@ typedef const GUID *LPCGUID;
#define GUID_DEFINED
#endif // !GUID_DEFINED

constexpr GUID JITEEVersionIdentifier = { /* 7f7fd340-4779-455a-8046-628f3cd8c3c7 */
0x7f7fd340,
0x4779,
0x455a,
{0x80, 0x46, 0x62, 0x8f, 0x3c, 0xd8, 0xc3, 0xc7}
constexpr GUID JITEEVersionIdentifier = { /* b75a5475-ff22-4078-9551-2024ce03d383 */
0xb75a5475,
0xff22,
0x4078,
{0x95, 0x51, 0x20, 0x24, 0xce, 0x03, 0xd3, 0x83}
};

//////////////////////////////////////////////////////////////////////////////////////////////////////////
Expand Down
4 changes: 1 addition & 3 deletions src/coreclr/jit/ICorJitInfo_names_generated.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,9 +45,7 @@ DEF_CLR_API(getTypeInstantiationArgument)
DEF_CLR_API(printClassName)
DEF_CLR_API(isValueClass)
DEF_CLR_API(getClassAttribs)
DEF_CLR_API(getClassModule)
DEF_CLR_API(getModuleAssembly)
DEF_CLR_API(getAssemblyName)
DEF_CLR_API(getClassAssemblyName)
DEF_CLR_API(LongLifetimeMalloc)
DEF_CLR_API(LongLifetimeFree)
DEF_CLR_API(getIsClassInitedFlagAddress)
Expand Down
26 changes: 4 additions & 22 deletions src/coreclr/jit/ICorJitInfo_wrapper_generated.hpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -416,30 +416,12 @@ uint32_t WrapICorJitInfo::getClassAttribs(
return temp;
}

CORINFO_MODULE_HANDLE WrapICorJitInfo::getClassModule(
const char* WrapICorJitInfo::getClassAssemblyName(
CORINFO_CLASS_HANDLE cls)
{
API_ENTER(getClassModule);
CORINFO_MODULE_HANDLE temp = wrapHnd->getClassModule(cls);
API_LEAVE(getClassModule);
return temp;
}

CORINFO_ASSEMBLY_HANDLE WrapICorJitInfo::getModuleAssembly(
CORINFO_MODULE_HANDLE mod)
{
API_ENTER(getModuleAssembly);
CORINFO_ASSEMBLY_HANDLE temp = wrapHnd->getModuleAssembly(mod);
API_LEAVE(getModuleAssembly);
return temp;
}

const char* WrapICorJitInfo::getAssemblyName(
CORINFO_ASSEMBLY_HANDLE assem)
{
API_ENTER(getAssemblyName);
const char* temp = wrapHnd->getAssemblyName(assem);
API_LEAVE(getAssemblyName);
API_ENTER(getClassAssemblyName);
const char* temp = wrapHnd->getClassAssemblyName(cls);
API_LEAVE(getClassAssemblyName);
return temp;
}

Expand Down
53 changes: 20 additions & 33 deletions src/coreclr/jit/compiler.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -2586,8 +2586,7 @@ void Compiler::compInitOptions(JitFlags* jitFlags)
// We have an exclusion list. See if this method is in an assembly that is on the list.
// Note that we check this for every method, since we might inline across modules, and
// if the inlinee module is on the list, we don't want to use the altjit for it.
const char* methodAssemblyName = info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
const char* methodAssemblyName = eeGetClassAssemblyName(info.compClassHnd);
if (s_pAltJitExcludeAssembliesList->IsInList(methodAssemblyName))
{
opts.altJit = false;
Expand All@@ -2614,8 +2613,7 @@ void Compiler::compInitOptions(JitFlags* jitFlags)
bool assemblyInIncludeList = true; // assume we'll dump, if there's not an include list (or it's empty).
if (s_pJitDisasmIncludeAssembliesList != nullptr && !s_pJitDisasmIncludeAssembliesList->IsEmpty())
{
const char* assemblyName = info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
const char* assemblyName = eeGetClassAssemblyName(info.compClassHnd);
if (!s_pJitDisasmIncludeAssembliesList->IsInList(assemblyName))
{
Comment thread
hez2010 marked this conversation as resolved.
// We have a list, and the current assembly is not in it, so we won't dump.
Expand DownExpand Up@@ -6335,39 +6333,29 @@ int Compiler::compCompile(CORINFO_MODULE_HANDLE classPtr,
#ifdef DEBUG
if (JitConfig.EnableExtraSuperPmiQueries())
{
// This call to getClassModule/getModuleAssembly/getAssemblyName fails in crossgen2 due to these
// APIs being unimplemented. So disable this extra info for pre-jit mode. See
// https://github.com/dotnet/runtime/issues/48888.
//
// Ditto for some of the class name queries for generic params.
//
if (!compileFlags->IsSet(JitFlags::JIT_FLAG_PREJIT))
{
// Get the assembly name, to aid finding any particular SuperPMI method context function
(void)info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
// Get the assembly name, to aid finding any particular SuperPMI method context function
(void)eeGetClassAssemblyName(info.compClassHnd);

// Fetch class names for the method's generic parameters.
//
CORINFO_SIG_INFO sig;
info.compCompHnd->getMethodSig(info.compMethodHnd, &sig, nullptr);
// Fetch class names for the method's generic parameters.
//
CORINFO_SIG_INFO sig;
info.compCompHnd->getMethodSig(info.compMethodHnd, &sig, nullptr);

const unsigned classInst = sig.sigInst.classInstCount;
if (classInst > 0)
const unsigned classInst = sig.sigInst.classInstCount;
if (classInst > 0)
{
for (unsigned i = 0; i < classInst; i++)
{
for (unsigned i = 0; i < classInst; i++)
{
eeGetClassName(sig.sigInst.classInst[i]);
}
eeGetClassName(sig.sigInst.classInst[i]);
}
}

const unsigned methodInst = sig.sigInst.methInstCount;
if (methodInst > 0)
const unsigned methodInst = sig.sigInst.methInstCount;
if (methodInst > 0)
{
for (unsigned i = 0; i < methodInst; i++)
{
for (unsigned i = 0; i < methodInst; i++)
{
eeGetClassName(sig.sigInst.methInst[i]);
}
eeGetClassName(sig.sigInst.methInst[i]);
}
}
}
Expand DownExpand Up@@ -9221,8 +9209,7 @@ void JitTimer::PrintCsvMethodStats(Compiler* comp)
}
else
{
const char* methodAssemblyName = comp->info.compCompHnd->getAssemblyName(
comp->info.compCompHnd->getModuleAssembly(comp->info.compCompHnd->getClassModule(comp->info.compClassHnd)));
const char* methodAssemblyName = comp->eeGetClassAssemblyName(comp->info.compClassHnd);
fprintf(s_csvFile, "\"%s\",", methodAssemblyName);
}
fprintf(s_csvFile, "%u,", comp->info.compILCodeSize);
Expand Down
2 changes: 2 additions & 0 deletions src/coreclr/jit/compiler.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -8337,6 +8337,8 @@ class Compiler
void eePrintObjectDescription(const char* prefix, CORINFO_OBJECT_HANDLE handle);
const char* eeGetShortClassName(CORINFO_CLASS_HANDLE clsHnd);

const char* eeGetClassAssemblyName(CORINFO_CLASS_HANDLE clsHnd);

#if defined(DEBUG)
unsigned eeTryGetClassSize(CORINFO_CLASS_HANDLE clsHnd);
#endif
Expand Down
21 changes: 21 additions & 0 deletions src/coreclr/jit/eeinterface.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -596,6 +596,27 @@ const char* Compiler::eeGetShortClassName(CORINFO_CLASS_HANDLE clsHnd)
return printer.GetBuffer();
}

//------------------------------------------------------------------------
// eeGetClassAssemblyName:
// Get the assembly name of a type.
// If missing information (in SPMI), then return a placeholder string.
//
// Parameters:
// clsHnd - the handle of the class
//
// Return value:
// The name string.
//
const char* Compiler::eeGetClassAssemblyName(CORINFO_CLASS_HANDLE clsHnd)
{
const char* assemblyName = "<unknown assembly>";
eeRunFunctorWithSPMIErrorTrap([&]() {
assemblyName = info.compCompHnd->getClassAssemblyName(clsHnd);
});

return assemblyName != nullptr ? assemblyName : "<no assembly>";
}

void Compiler::eePrintObjectDescription(const char* prefix, CORINFO_OBJECT_HANDLE handle)
{
const size_t maxStrSize = 64;
Expand Down
17 changes: 11 additions & 6 deletions src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs
Original file line numberDiff line numberDiff line change
Expand Up@@ -2092,12 +2092,17 @@ private uint getClassAttribsInternal(TypeDesc type)
return (uint)result;
}

private CORINFO_MODULE_STRUCT_* getClassModule(CORINFO_CLASS_STRUCT_* cls)
{ throw new NotImplementedException("getClassModule"); }
private CORINFO_ASSEMBLY_STRUCT_* getModuleAssembly(CORINFO_MODULE_STRUCT_* mod)
{ throw new NotImplementedException("getModuleAssembly"); }
private byte* getAssemblyName(CORINFO_ASSEMBLY_STRUCT_* assem)
{ throw new NotImplementedException("getAssemblyName"); }
private byte* getClassAssemblyName(CORINFO_CLASS_STRUCT_* cls)
{
TypeDesc type = HandleToObject(cls);

if (type is MetadataType mdType)
{
return (byte*)GetPin(StringToUTF8(mdType.Module.Assembly.GetName().Name));
}

return null;
}

#pragma warning disable CA1822 // Mark members as static
private void* LongLifetimeMalloc(UIntPtr sz)
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions src/coreclr/inc/corinfo.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -930,7 +930,6 @@ struct PatchpointInfo;
// Cookie types consumed by the code generator (these are opaque values
// not inspected by the code generator):

typedef struct CORINFO_ASSEMBLY_STRUCT_* CORINFO_ASSEMBLY_HANDLE;
typedef struct CORINFO_MODULE_STRUCT_* CORINFO_MODULE_HANDLE;
typedef struct CORINFO_DEPENDENCY_STRUCT_* CORINFO_DEPENDENCY_HANDLE;
typedef struct CORINFO_CLASS_STRUCT_* CORINFO_CLASS_HANDLE;
Expand DownExpand Up@@ -2321,18 +2320,9 @@ class ICorStaticInfo
CORINFO_CLASS_HANDLE cls
) = 0;

virtual CORINFO_MODULE_HANDLE getClassModule (
CORINFO_CLASS_HANDLE cls
) = 0;

// Returns the assembly that contains the module "mod".
virtual CORINFO_ASSEMBLY_HANDLE getModuleAssembly (
Comment thread
hez2010 marked this conversation as resolved.
CORINFO_MODULE_HANDLE mod
) = 0;

// Returns the name of the assembly "assem".
virtual const char* getAssemblyName (
CORINFO_ASSEMBLY_HANDLE assem
// Returns the assembly name of the class "cls", or nullptr if there is none.
virtual const char* getClassAssemblyName (
CORINFO_CLASS_HANDLE cls
) = 0;

// Allocate and delete process-lifetime objects. Should only be
Expand Down
8 changes: 1 addition & 7 deletions src/coreclr/inc/icorjitinfoimpl_generated.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -193,15 +193,9 @@ bool isValueClass(
uint32_t getClassAttribs(
CORINFO_CLASS_HANDLE cls) override;

CORINFO_MODULE_HANDLE getClassModule(
const char* getClassAssemblyName(
CORINFO_CLASS_HANDLE cls) override;

CORINFO_ASSEMBLY_HANDLE getModuleAssembly(
CORINFO_MODULE_HANDLE mod) override;

const char* getAssemblyName(
CORINFO_ASSEMBLY_HANDLE assem) override;

void* LongLifetimeMalloc(
size_t sz) override;

Expand Down
10 changes: 5 additions & 5 deletions src/coreclr/inc/jiteeversionguid.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,11 +43,11 @@ typedef const GUID *LPCGUID;
#define GUID_DEFINED
#endif // !GUID_DEFINED

constexpr GUID JITEEVersionIdentifier = { /* 7f7fd340-4779-455a-8046-628f3cd8c3c7 */
0x7f7fd340,
0x4779,
0x455a,
{0x80, 0x46, 0x62, 0x8f, 0x3c, 0xd8, 0xc3, 0xc7}
constexpr GUID JITEEVersionIdentifier = { /* b75a5475-ff22-4078-9551-2024ce03d383 */
0xb75a5475,
0xff22,
0x4078,
{0x95, 0x51, 0x20, 0x24, 0xce, 0x03, 0xd3, 0x83}
};

//////////////////////////////////////////////////////////////////////////////////////////////////////////
Expand Down
4 changes: 1 addition & 3 deletions src/coreclr/jit/ICorJitInfo_names_generated.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,9 +45,7 @@ DEF_CLR_API(getTypeInstantiationArgument)
DEF_CLR_API(printClassName)
DEF_CLR_API(isValueClass)
DEF_CLR_API(getClassAttribs)
DEF_CLR_API(getClassModule)
DEF_CLR_API(getModuleAssembly)
DEF_CLR_API(getAssemblyName)
DEF_CLR_API(getClassAssemblyName)
DEF_CLR_API(LongLifetimeMalloc)
DEF_CLR_API(LongLifetimeFree)
DEF_CLR_API(getIsClassInitedFlagAddress)
Expand Down
26 changes: 4 additions & 22 deletions src/coreclr/jit/ICorJitInfo_wrapper_generated.hpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -416,30 +416,12 @@ uint32_t WrapICorJitInfo::getClassAttribs(
return temp;
}

CORINFO_MODULE_HANDLE WrapICorJitInfo::getClassModule(
const char* WrapICorJitInfo::getClassAssemblyName(
CORINFO_CLASS_HANDLE cls)
{
API_ENTER(getClassModule);
CORINFO_MODULE_HANDLE temp = wrapHnd->getClassModule(cls);
API_LEAVE(getClassModule);
return temp;
}

CORINFO_ASSEMBLY_HANDLE WrapICorJitInfo::getModuleAssembly(
CORINFO_MODULE_HANDLE mod)
{
API_ENTER(getModuleAssembly);
CORINFO_ASSEMBLY_HANDLE temp = wrapHnd->getModuleAssembly(mod);
API_LEAVE(getModuleAssembly);
return temp;
}

const char* WrapICorJitInfo::getAssemblyName(
CORINFO_ASSEMBLY_HANDLE assem)
{
API_ENTER(getAssemblyName);
const char* temp = wrapHnd->getAssemblyName(assem);
API_LEAVE(getAssemblyName);
API_ENTER(getClassAssemblyName);
const char* temp = wrapHnd->getClassAssemblyName(cls);
API_LEAVE(getClassAssemblyName);
return temp;
}

Expand Down
53 changes: 20 additions & 33 deletions src/coreclr/jit/compiler.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -2586,8 +2586,7 @@ void Compiler::compInitOptions(JitFlags* jitFlags)
// We have an exclusion list. See if this method is in an assembly that is on the list.
// Note that we check this for every method, since we might inline across modules, and
// if the inlinee module is on the list, we don't want to use the altjit for it.
const char* methodAssemblyName = info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
const char* methodAssemblyName = eeGetClassAssemblyName(info.compClassHnd);
if (s_pAltJitExcludeAssembliesList->IsInList(methodAssemblyName))
{
opts.altJit = false;
Expand All@@ -2614,8 +2613,7 @@ void Compiler::compInitOptions(JitFlags* jitFlags)
bool assemblyInIncludeList = true; // assume we'll dump, if there's not an include list (or it's empty).
if (s_pJitDisasmIncludeAssembliesList != nullptr && !s_pJitDisasmIncludeAssembliesList->IsEmpty())
{
const char* assemblyName = info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
const char* assemblyName = eeGetClassAssemblyName(info.compClassHnd);
if (!s_pJitDisasmIncludeAssembliesList->IsInList(assemblyName))
{
Comment thread
hez2010 marked this conversation as resolved.
// We have a list, and the current assembly is not in it, so we won't dump.
Expand DownExpand Up@@ -6335,39 +6333,29 @@ int Compiler::compCompile(CORINFO_MODULE_HANDLE classPtr,
#ifdef DEBUG
if (JitConfig.EnableExtraSuperPmiQueries())
{
// This call to getClassModule/getModuleAssembly/getAssemblyName fails in crossgen2 due to these
// APIs being unimplemented. So disable this extra info for pre-jit mode. See
// https://github.com/dotnet/runtime/issues/48888.
//
// Ditto for some of the class name queries for generic params.
//
if (!compileFlags->IsSet(JitFlags::JIT_FLAG_PREJIT))
{
// Get the assembly name, to aid finding any particular SuperPMI method context function
(void)info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
// Get the assembly name, to aid finding any particular SuperPMI method context function
(void)eeGetClassAssemblyName(info.compClassHnd);

// Fetch class names for the method's generic parameters.
//
CORINFO_SIG_INFO sig;
info.compCompHnd->getMethodSig(info.compMethodHnd, &sig, nullptr);
// Fetch class names for the method's generic parameters.
//
CORINFO_SIG_INFO sig;
info.compCompHnd->getMethodSig(info.compMethodHnd, &sig, nullptr);

const unsigned classInst = sig.sigInst.classInstCount;
if (classInst > 0)
const unsigned classInst = sig.sigInst.classInstCount;
if (classInst > 0)
{
for (unsigned i = 0; i < classInst; i++)
{
for (unsigned i = 0; i < classInst; i++)
{
eeGetClassName(sig.sigInst.classInst[i]);
}
eeGetClassName(sig.sigInst.classInst[i]);
}
}

const unsigned methodInst = sig.sigInst.methInstCount;
if (methodInst > 0)
const unsigned methodInst = sig.sigInst.methInstCount;
if (methodInst > 0)
{
for (unsigned i = 0; i < methodInst; i++)
{
for (unsigned i = 0; i < methodInst; i++)
{
eeGetClassName(sig.sigInst.methInst[i]);
}
eeGetClassName(sig.sigInst.methInst[i]);
}
}
}
Expand DownExpand Up@@ -9221,8 +9209,7 @@ void JitTimer::PrintCsvMethodStats(Compiler* comp)
}
else
{
const char* methodAssemblyName = comp->info.compCompHnd->getAssemblyName(
comp->info.compCompHnd->getModuleAssembly(comp->info.compCompHnd->getClassModule(comp->info.compClassHnd)));
const char* methodAssemblyName = comp->eeGetClassAssemblyName(comp->info.compClassHnd);
fprintf(s_csvFile, "\"%s\",", methodAssemblyName);
}
fprintf(s_csvFile, "%u,", comp->info.compILCodeSize);
Expand Down
2 changes: 2 additions & 0 deletions src/coreclr/jit/compiler.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -8337,6 +8337,8 @@ class Compiler
void eePrintObjectDescription(const char* prefix, CORINFO_OBJECT_HANDLE handle);
const char* eeGetShortClassName(CORINFO_CLASS_HANDLE clsHnd);

const char* eeGetClassAssemblyName(CORINFO_CLASS_HANDLE clsHnd);

#if defined(DEBUG)
unsigned eeTryGetClassSize(CORINFO_CLASS_HANDLE clsHnd);
#endif
Expand Down
21 changes: 21 additions & 0 deletions src/coreclr/jit/eeinterface.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -596,6 +596,27 @@ const char* Compiler::eeGetShortClassName(CORINFO_CLASS_HANDLE clsHnd)
return printer.GetBuffer();
}

//------------------------------------------------------------------------
// eeGetClassAssemblyName:
// Get the assembly name of a type.
// If missing information (in SPMI), then return a placeholder string.
//
// Parameters:
// clsHnd - the handle of the class
//
// Return value:
// The name string.
//
const char* Compiler::eeGetClassAssemblyName(CORINFO_CLASS_HANDLE clsHnd)
{
const char* assemblyName = "<unknown assembly>";
eeRunFunctorWithSPMIErrorTrap([&]() {
assemblyName = info.compCompHnd->getClassAssemblyName(clsHnd);
});

return assemblyName != nullptr ? assemblyName : "<no assembly>";
}

void Compiler::eePrintObjectDescription(const char* prefix, CORINFO_OBJECT_HANDLE handle)
{
const size_t maxStrSize = 64;
Expand Down
17 changes: 11 additions & 6 deletions src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs
Original file line numberDiff line numberDiff line change
Expand Up@@ -2092,12 +2092,17 @@ private uint getClassAttribsInternal(TypeDesc type)
return (uint)result;
}

private CORINFO_MODULE_STRUCT_* getClassModule(CORINFO_CLASS_STRUCT_* cls)
{ throw new NotImplementedException("getClassModule"); }
private CORINFO_ASSEMBLY_STRUCT_* getModuleAssembly(CORINFO_MODULE_STRUCT_* mod)
{ throw new NotImplementedException("getModuleAssembly"); }
private byte* getAssemblyName(CORINFO_ASSEMBLY_STRUCT_* assem)
{ throw new NotImplementedException("getAssemblyName"); }
private byte* getClassAssemblyName(CORINFO_CLASS_STRUCT_* cls)
{
TypeDesc type = HandleToObject(cls);

if (type is MetadataType mdType)
{
return (byte*)GetPin(StringToUTF8(mdType.Module.Assembly.GetName().Name));
}

return null;
}

#pragma warning disable CA1822 // Mark members as static
private void* LongLifetimeMalloc(UIntPtr sz)
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions src/coreclr/inc/corinfo.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -930,7 +930,6 @@ struct PatchpointInfo;
// Cookie types consumed by the code generator (these are opaque values
// not inspected by the code generator):

typedef struct CORINFO_ASSEMBLY_STRUCT_* CORINFO_ASSEMBLY_HANDLE;
typedef struct CORINFO_MODULE_STRUCT_* CORINFO_MODULE_HANDLE;
typedef struct CORINFO_DEPENDENCY_STRUCT_* CORINFO_DEPENDENCY_HANDLE;
typedef struct CORINFO_CLASS_STRUCT_* CORINFO_CLASS_HANDLE;
Expand DownExpand Up@@ -2321,18 +2320,9 @@ class ICorStaticInfo
CORINFO_CLASS_HANDLE cls
) = 0;

virtual CORINFO_MODULE_HANDLE getClassModule (
CORINFO_CLASS_HANDLE cls
) = 0;

// Returns the assembly that contains the module "mod".
virtual CORINFO_ASSEMBLY_HANDLE getModuleAssembly (
Comment thread
hez2010 marked this conversation as resolved.
CORINFO_MODULE_HANDLE mod
) = 0;

// Returns the name of the assembly "assem".
virtual const char* getAssemblyName (
CORINFO_ASSEMBLY_HANDLE assem
// Returns the assembly name of the class "cls", or nullptr if there is none.
virtual const char* getClassAssemblyName (
CORINFO_CLASS_HANDLE cls
) = 0;

// Allocate and delete process-lifetime objects. Should only be
Expand Down
8 changes: 1 addition & 7 deletions src/coreclr/inc/icorjitinfoimpl_generated.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -193,15 +193,9 @@ bool isValueClass(
uint32_t getClassAttribs(
CORINFO_CLASS_HANDLE cls) override;

CORINFO_MODULE_HANDLE getClassModule(
const char* getClassAssemblyName(
CORINFO_CLASS_HANDLE cls) override;

CORINFO_ASSEMBLY_HANDLE getModuleAssembly(
CORINFO_MODULE_HANDLE mod) override;

const char* getAssemblyName(
CORINFO_ASSEMBLY_HANDLE assem) override;

void* LongLifetimeMalloc(
size_t sz) override;

Expand Down
10 changes: 5 additions & 5 deletions src/coreclr/inc/jiteeversionguid.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,11 +43,11 @@ typedef const GUID *LPCGUID;
#define GUID_DEFINED
#endif // !GUID_DEFINED

constexpr GUID JITEEVersionIdentifier = { /* 7f7fd340-4779-455a-8046-628f3cd8c3c7 */
0x7f7fd340,
0x4779,
0x455a,
{0x80, 0x46, 0x62, 0x8f, 0x3c, 0xd8, 0xc3, 0xc7}
constexpr GUID JITEEVersionIdentifier = { /* b75a5475-ff22-4078-9551-2024ce03d383 */
0xb75a5475,
0xff22,
0x4078,
{0x95, 0x51, 0x20, 0x24, 0xce, 0x03, 0xd3, 0x83}
};

//////////////////////////////////////////////////////////////////////////////////////////////////////////
Expand Down
4 changes: 1 addition & 3 deletions src/coreclr/jit/ICorJitInfo_names_generated.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,9 +45,7 @@ DEF_CLR_API(getTypeInstantiationArgument)
DEF_CLR_API(printClassName)
DEF_CLR_API(isValueClass)
DEF_CLR_API(getClassAttribs)
DEF_CLR_API(getClassModule)
DEF_CLR_API(getModuleAssembly)
DEF_CLR_API(getAssemblyName)
DEF_CLR_API(getClassAssemblyName)
DEF_CLR_API(LongLifetimeMalloc)
DEF_CLR_API(LongLifetimeFree)
DEF_CLR_API(getIsClassInitedFlagAddress)
Expand Down
26 changes: 4 additions & 22 deletions src/coreclr/jit/ICorJitInfo_wrapper_generated.hpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -416,30 +416,12 @@ uint32_t WrapICorJitInfo::getClassAttribs(
return temp;
}

CORINFO_MODULE_HANDLE WrapICorJitInfo::getClassModule(
const char* WrapICorJitInfo::getClassAssemblyName(
CORINFO_CLASS_HANDLE cls)
{
API_ENTER(getClassModule);
CORINFO_MODULE_HANDLE temp = wrapHnd->getClassModule(cls);
API_LEAVE(getClassModule);
return temp;
}

CORINFO_ASSEMBLY_HANDLE WrapICorJitInfo::getModuleAssembly(
CORINFO_MODULE_HANDLE mod)
{
API_ENTER(getModuleAssembly);
CORINFO_ASSEMBLY_HANDLE temp = wrapHnd->getModuleAssembly(mod);
API_LEAVE(getModuleAssembly);
return temp;
}

const char* WrapICorJitInfo::getAssemblyName(
CORINFO_ASSEMBLY_HANDLE assem)
{
API_ENTER(getAssemblyName);
const char* temp = wrapHnd->getAssemblyName(assem);
API_LEAVE(getAssemblyName);
API_ENTER(getClassAssemblyName);
const char* temp = wrapHnd->getClassAssemblyName(cls);
API_LEAVE(getClassAssemblyName);
return temp;
}

Expand Down
53 changes: 20 additions & 33 deletions src/coreclr/jit/compiler.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -2586,8 +2586,7 @@ void Compiler::compInitOptions(JitFlags* jitFlags)
// We have an exclusion list. See if this method is in an assembly that is on the list.
// Note that we check this for every method, since we might inline across modules, and
// if the inlinee module is on the list, we don't want to use the altjit for it.
const char* methodAssemblyName = info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
const char* methodAssemblyName = eeGetClassAssemblyName(info.compClassHnd);
if (s_pAltJitExcludeAssembliesList->IsInList(methodAssemblyName))
{
opts.altJit = false;
Expand All@@ -2614,8 +2613,7 @@ void Compiler::compInitOptions(JitFlags* jitFlags)
bool assemblyInIncludeList = true; // assume we'll dump, if there's not an include list (or it's empty).
if (s_pJitDisasmIncludeAssembliesList != nullptr && !s_pJitDisasmIncludeAssembliesList->IsEmpty())
{
const char* assemblyName = info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
const char* assemblyName = eeGetClassAssemblyName(info.compClassHnd);
if (!s_pJitDisasmIncludeAssembliesList->IsInList(assemblyName))
{
Comment thread
hez2010 marked this conversation as resolved.
// We have a list, and the current assembly is not in it, so we won't dump.
Expand DownExpand Up@@ -6335,39 +6333,29 @@ int Compiler::compCompile(CORINFO_MODULE_HANDLE classPtr,
#ifdef DEBUG
if (JitConfig.EnableExtraSuperPmiQueries())
{
// This call to getClassModule/getModuleAssembly/getAssemblyName fails in crossgen2 due to these
// APIs being unimplemented. So disable this extra info for pre-jit mode. See
// https://github.com/dotnet/runtime/issues/48888.
//
// Ditto for some of the class name queries for generic params.
//
if (!compileFlags->IsSet(JitFlags::JIT_FLAG_PREJIT))
{
// Get the assembly name, to aid finding any particular SuperPMI method context function
(void)info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
// Get the assembly name, to aid finding any particular SuperPMI method context function
(void)eeGetClassAssemblyName(info.compClassHnd);

// Fetch class names for the method's generic parameters.
//
CORINFO_SIG_INFO sig;
info.compCompHnd->getMethodSig(info.compMethodHnd, &sig, nullptr);
// Fetch class names for the method's generic parameters.
//
CORINFO_SIG_INFO sig;
info.compCompHnd->getMethodSig(info.compMethodHnd, &sig, nullptr);

const unsigned classInst = sig.sigInst.classInstCount;
if (classInst > 0)
const unsigned classInst = sig.sigInst.classInstCount;
if (classInst > 0)
{
for (unsigned i = 0; i < classInst; i++)
{
for (unsigned i = 0; i < classInst; i++)
{
eeGetClassName(sig.sigInst.classInst[i]);
}
eeGetClassName(sig.sigInst.classInst[i]);
}
}

const unsigned methodInst = sig.sigInst.methInstCount;
if (methodInst > 0)
const unsigned methodInst = sig.sigInst.methInstCount;
if (methodInst > 0)
{
for (unsigned i = 0; i < methodInst; i++)
{
for (unsigned i = 0; i < methodInst; i++)
{
eeGetClassName(sig.sigInst.methInst[i]);
}
eeGetClassName(sig.sigInst.methInst[i]);
}
}
}
Expand DownExpand Up@@ -9221,8 +9209,7 @@ void JitTimer::PrintCsvMethodStats(Compiler* comp)
}
else
{
const char* methodAssemblyName = comp->info.compCompHnd->getAssemblyName(
comp->info.compCompHnd->getModuleAssembly(comp->info.compCompHnd->getClassModule(comp->info.compClassHnd)));
const char* methodAssemblyName = comp->eeGetClassAssemblyName(comp->info.compClassHnd);
fprintf(s_csvFile, "\"%s\",", methodAssemblyName);
}
fprintf(s_csvFile, "%u,", comp->info.compILCodeSize);
Expand Down
2 changes: 2 additions & 0 deletions src/coreclr/jit/compiler.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -8337,6 +8337,8 @@ class Compiler
void eePrintObjectDescription(const char* prefix, CORINFO_OBJECT_HANDLE handle);
const char* eeGetShortClassName(CORINFO_CLASS_HANDLE clsHnd);

const char* eeGetClassAssemblyName(CORINFO_CLASS_HANDLE clsHnd);

#if defined(DEBUG)
unsigned eeTryGetClassSize(CORINFO_CLASS_HANDLE clsHnd);
#endif
Expand Down
21 changes: 21 additions & 0 deletions src/coreclr/jit/eeinterface.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -596,6 +596,27 @@ const char* Compiler::eeGetShortClassName(CORINFO_CLASS_HANDLE clsHnd)
return printer.GetBuffer();
}

//------------------------------------------------------------------------
// eeGetClassAssemblyName:
// Get the assembly name of a type.
// If missing information (in SPMI), then return a placeholder string.
//
// Parameters:
// clsHnd - the handle of the class
//
// Return value:
// The name string.
//
const char* Compiler::eeGetClassAssemblyName(CORINFO_CLASS_HANDLE clsHnd)
{
const char* assemblyName = "<unknown assembly>";
eeRunFunctorWithSPMIErrorTrap([&]() {
assemblyName = info.compCompHnd->getClassAssemblyName(clsHnd);
});

return assemblyName != nullptr ? assemblyName : "<no assembly>";
}

void Compiler::eePrintObjectDescription(const char* prefix, CORINFO_OBJECT_HANDLE handle)
{
const size_t maxStrSize = 64;
Expand Down
17 changes: 11 additions & 6 deletions src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs
Original file line numberDiff line numberDiff line change
Expand Up@@ -2092,12 +2092,17 @@ private uint getClassAttribsInternal(TypeDesc type)
return (uint)result;
}

private CORINFO_MODULE_STRUCT_* getClassModule(CORINFO_CLASS_STRUCT_* cls)
{ throw new NotImplementedException("getClassModule"); }
private CORINFO_ASSEMBLY_STRUCT_* getModuleAssembly(CORINFO_MODULE_STRUCT_* mod)
{ throw new NotImplementedException("getModuleAssembly"); }
private byte* getAssemblyName(CORINFO_ASSEMBLY_STRUCT_* assem)
{ throw new NotImplementedException("getAssemblyName"); }
private byte* getClassAssemblyName(CORINFO_CLASS_STRUCT_* cls)
{
TypeDesc type = HandleToObject(cls);

if (type is MetadataType mdType)
{
return (byte*)GetPin(StringToUTF8(mdType.Module.Assembly.GetName().Name));
}

return null;
}

#pragma warning disable CA1822 // Mark members as static
private void* LongLifetimeMalloc(UIntPtr sz)
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions src/coreclr/inc/corinfo.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -930,7 +930,6 @@ struct PatchpointInfo;
// Cookie types consumed by the code generator (these are opaque values
// not inspected by the code generator):

typedef struct CORINFO_ASSEMBLY_STRUCT_* CORINFO_ASSEMBLY_HANDLE;
typedef struct CORINFO_MODULE_STRUCT_* CORINFO_MODULE_HANDLE;
typedef struct CORINFO_DEPENDENCY_STRUCT_* CORINFO_DEPENDENCY_HANDLE;
typedef struct CORINFO_CLASS_STRUCT_* CORINFO_CLASS_HANDLE;
Expand DownExpand Up@@ -2321,18 +2320,9 @@ class ICorStaticInfo
CORINFO_CLASS_HANDLE cls
) = 0;

virtual CORINFO_MODULE_HANDLE getClassModule (
CORINFO_CLASS_HANDLE cls
) = 0;

// Returns the assembly that contains the module "mod".
virtual CORINFO_ASSEMBLY_HANDLE getModuleAssembly (
Comment thread
hez2010 marked this conversation as resolved.
CORINFO_MODULE_HANDLE mod
) = 0;

// Returns the name of the assembly "assem".
virtual const char* getAssemblyName (
CORINFO_ASSEMBLY_HANDLE assem
// Returns the assembly name of the class "cls", or nullptr if there is none.
virtual const char* getClassAssemblyName (
CORINFO_CLASS_HANDLE cls
) = 0;

// Allocate and delete process-lifetime objects. Should only be
Expand Down
8 changes: 1 addition & 7 deletions src/coreclr/inc/icorjitinfoimpl_generated.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -193,15 +193,9 @@ bool isValueClass(
uint32_t getClassAttribs(
CORINFO_CLASS_HANDLE cls) override;

CORINFO_MODULE_HANDLE getClassModule(
const char* getClassAssemblyName(
CORINFO_CLASS_HANDLE cls) override;

CORINFO_ASSEMBLY_HANDLE getModuleAssembly(
CORINFO_MODULE_HANDLE mod) override;

const char* getAssemblyName(
CORINFO_ASSEMBLY_HANDLE assem) override;

void* LongLifetimeMalloc(
size_t sz) override;

Expand Down
10 changes: 5 additions & 5 deletions src/coreclr/inc/jiteeversionguid.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,11 +43,11 @@ typedef const GUID *LPCGUID;
#define GUID_DEFINED
#endif // !GUID_DEFINED

constexpr GUID JITEEVersionIdentifier = { /* 7f7fd340-4779-455a-8046-628f3cd8c3c7 */
0x7f7fd340,
0x4779,
0x455a,
{0x80, 0x46, 0x62, 0x8f, 0x3c, 0xd8, 0xc3, 0xc7}
constexpr GUID JITEEVersionIdentifier = { /* b75a5475-ff22-4078-9551-2024ce03d383 */
0xb75a5475,
0xff22,
0x4078,
{0x95, 0x51, 0x20, 0x24, 0xce, 0x03, 0xd3, 0x83}
};

//////////////////////////////////////////////////////////////////////////////////////////////////////////
Expand Down
4 changes: 1 addition & 3 deletions src/coreclr/jit/ICorJitInfo_names_generated.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,9 +45,7 @@ DEF_CLR_API(getTypeInstantiationArgument)
DEF_CLR_API(printClassName)
DEF_CLR_API(isValueClass)
DEF_CLR_API(getClassAttribs)
DEF_CLR_API(getClassModule)
DEF_CLR_API(getModuleAssembly)
DEF_CLR_API(getAssemblyName)
DEF_CLR_API(getClassAssemblyName)
DEF_CLR_API(LongLifetimeMalloc)
DEF_CLR_API(LongLifetimeFree)
DEF_CLR_API(getIsClassInitedFlagAddress)
Expand Down
26 changes: 4 additions & 22 deletions src/coreclr/jit/ICorJitInfo_wrapper_generated.hpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -416,30 +416,12 @@ uint32_t WrapICorJitInfo::getClassAttribs(
return temp;
}

CORINFO_MODULE_HANDLE WrapICorJitInfo::getClassModule(
const char* WrapICorJitInfo::getClassAssemblyName(
CORINFO_CLASS_HANDLE cls)
{
API_ENTER(getClassModule);
CORINFO_MODULE_HANDLE temp = wrapHnd->getClassModule(cls);
API_LEAVE(getClassModule);
return temp;
}

CORINFO_ASSEMBLY_HANDLE WrapICorJitInfo::getModuleAssembly(
CORINFO_MODULE_HANDLE mod)
{
API_ENTER(getModuleAssembly);
CORINFO_ASSEMBLY_HANDLE temp = wrapHnd->getModuleAssembly(mod);
API_LEAVE(getModuleAssembly);
return temp;
}

const char* WrapICorJitInfo::getAssemblyName(
CORINFO_ASSEMBLY_HANDLE assem)
{
API_ENTER(getAssemblyName);
const char* temp = wrapHnd->getAssemblyName(assem);
API_LEAVE(getAssemblyName);
API_ENTER(getClassAssemblyName);
const char* temp = wrapHnd->getClassAssemblyName(cls);
API_LEAVE(getClassAssemblyName);
return temp;
}

Expand Down
53 changes: 20 additions & 33 deletions src/coreclr/jit/compiler.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -2586,8 +2586,7 @@ void Compiler::compInitOptions(JitFlags* jitFlags)
// We have an exclusion list. See if this method is in an assembly that is on the list.
// Note that we check this for every method, since we might inline across modules, and
// if the inlinee module is on the list, we don't want to use the altjit for it.
const char* methodAssemblyName = info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
const char* methodAssemblyName = eeGetClassAssemblyName(info.compClassHnd);
if (s_pAltJitExcludeAssembliesList->IsInList(methodAssemblyName))
{
opts.altJit = false;
Expand All@@ -2614,8 +2613,7 @@ void Compiler::compInitOptions(JitFlags* jitFlags)
bool assemblyInIncludeList = true; // assume we'll dump, if there's not an include list (or it's empty).
if (s_pJitDisasmIncludeAssembliesList != nullptr && !s_pJitDisasmIncludeAssembliesList->IsEmpty())
{
const char* assemblyName = info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
const char* assemblyName = eeGetClassAssemblyName(info.compClassHnd);
if (!s_pJitDisasmIncludeAssembliesList->IsInList(assemblyName))
{
Comment thread
hez2010 marked this conversation as resolved.
// We have a list, and the current assembly is not in it, so we won't dump.
Expand DownExpand Up@@ -6335,39 +6333,29 @@ int Compiler::compCompile(CORINFO_MODULE_HANDLE classPtr,
#ifdef DEBUG
if (JitConfig.EnableExtraSuperPmiQueries())
{
// This call to getClassModule/getModuleAssembly/getAssemblyName fails in crossgen2 due to these
// APIs being unimplemented. So disable this extra info for pre-jit mode. See
// https://github.com/dotnet/runtime/issues/48888.
//
// Ditto for some of the class name queries for generic params.
//
if (!compileFlags->IsSet(JitFlags::JIT_FLAG_PREJIT))
{
// Get the assembly name, to aid finding any particular SuperPMI method context function
(void)info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
// Get the assembly name, to aid finding any particular SuperPMI method context function
(void)eeGetClassAssemblyName(info.compClassHnd);

// Fetch class names for the method's generic parameters.
//
CORINFO_SIG_INFO sig;
info.compCompHnd->getMethodSig(info.compMethodHnd, &sig, nullptr);
// Fetch class names for the method's generic parameters.
//
CORINFO_SIG_INFO sig;
info.compCompHnd->getMethodSig(info.compMethodHnd, &sig, nullptr);

const unsigned classInst = sig.sigInst.classInstCount;
if (classInst > 0)
const unsigned classInst = sig.sigInst.classInstCount;
if (classInst > 0)
{
for (unsigned i = 0; i < classInst; i++)
{
for (unsigned i = 0; i < classInst; i++)
{
eeGetClassName(sig.sigInst.classInst[i]);
}
eeGetClassName(sig.sigInst.classInst[i]);
}
}

const unsigned methodInst = sig.sigInst.methInstCount;
if (methodInst > 0)
const unsigned methodInst = sig.sigInst.methInstCount;
if (methodInst > 0)
{
for (unsigned i = 0; i < methodInst; i++)
{
for (unsigned i = 0; i < methodInst; i++)
{
eeGetClassName(sig.sigInst.methInst[i]);
}
eeGetClassName(sig.sigInst.methInst[i]);
}
}
}
Expand DownExpand Up@@ -9221,8 +9209,7 @@ void JitTimer::PrintCsvMethodStats(Compiler* comp)
}
else
{
const char* methodAssemblyName = comp->info.compCompHnd->getAssemblyName(
comp->info.compCompHnd->getModuleAssembly(comp->info.compCompHnd->getClassModule(comp->info.compClassHnd)));
const char* methodAssemblyName = comp->eeGetClassAssemblyName(comp->info.compClassHnd);
fprintf(s_csvFile, "\"%s\",", methodAssemblyName);
}
fprintf(s_csvFile, "%u,", comp->info.compILCodeSize);
Expand Down
2 changes: 2 additions & 0 deletions src/coreclr/jit/compiler.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -8337,6 +8337,8 @@ class Compiler
void eePrintObjectDescription(const char* prefix, CORINFO_OBJECT_HANDLE handle);
const char* eeGetShortClassName(CORINFO_CLASS_HANDLE clsHnd);

const char* eeGetClassAssemblyName(CORINFO_CLASS_HANDLE clsHnd);

#if defined(DEBUG)
unsigned eeTryGetClassSize(CORINFO_CLASS_HANDLE clsHnd);
#endif
Expand Down
21 changes: 21 additions & 0 deletions src/coreclr/jit/eeinterface.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -596,6 +596,27 @@ const char* Compiler::eeGetShortClassName(CORINFO_CLASS_HANDLE clsHnd)
return printer.GetBuffer();
}

//------------------------------------------------------------------------
// eeGetClassAssemblyName:
// Get the assembly name of a type.
// If missing information (in SPMI), then return a placeholder string.
//
// Parameters:
// clsHnd - the handle of the class
//
// Return value:
// The name string.
//
const char* Compiler::eeGetClassAssemblyName(CORINFO_CLASS_HANDLE clsHnd)
{
const char* assemblyName = "<unknown assembly>";
eeRunFunctorWithSPMIErrorTrap([&]() {
assemblyName = info.compCompHnd->getClassAssemblyName(clsHnd);
});

return assemblyName != nullptr ? assemblyName : "<no assembly>";
}

void Compiler::eePrintObjectDescription(const char* prefix, CORINFO_OBJECT_HANDLE handle)
{
const size_t maxStrSize = 64;
Expand Down
17 changes: 11 additions & 6 deletions src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs
Original file line numberDiff line numberDiff line change
Expand Up@@ -2092,12 +2092,17 @@ private uint getClassAttribsInternal(TypeDesc type)
return (uint)result;
}

private CORINFO_MODULE_STRUCT_* getClassModule(CORINFO_CLASS_STRUCT_* cls)
{ throw new NotImplementedException("getClassModule"); }
private CORINFO_ASSEMBLY_STRUCT_* getModuleAssembly(CORINFO_MODULE_STRUCT_* mod)
{ throw new NotImplementedException("getModuleAssembly"); }
private byte* getAssemblyName(CORINFO_ASSEMBLY_STRUCT_* assem)
{ throw new NotImplementedException("getAssemblyName"); }
private byte* getClassAssemblyName(CORINFO_CLASS_STRUCT_* cls)
{
TypeDesc type = HandleToObject(cls);

if (type is MetadataType mdType)
{
return (byte*)GetPin(StringToUTF8(mdType.Module.Assembly.GetName().Name));
}

return null;
}

#pragma warning disable CA1822 // Mark members as static
private void* LongLifetimeMalloc(UIntPtr sz)
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions src/coreclr/inc/corinfo.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -930,7 +930,6 @@ struct PatchpointInfo;
// Cookie types consumed by the code generator (these are opaque values
// not inspected by the code generator):

typedef struct CORINFO_ASSEMBLY_STRUCT_* CORINFO_ASSEMBLY_HANDLE;
typedef struct CORINFO_MODULE_STRUCT_* CORINFO_MODULE_HANDLE;
typedef struct CORINFO_DEPENDENCY_STRUCT_* CORINFO_DEPENDENCY_HANDLE;
typedef struct CORINFO_CLASS_STRUCT_* CORINFO_CLASS_HANDLE;
Expand DownExpand Up@@ -2321,18 +2320,9 @@ class ICorStaticInfo
CORINFO_CLASS_HANDLE cls
) = 0;

virtual CORINFO_MODULE_HANDLE getClassModule (
CORINFO_CLASS_HANDLE cls
) = 0;

// Returns the assembly that contains the module "mod".
virtual CORINFO_ASSEMBLY_HANDLE getModuleAssembly (
Comment thread
hez2010 marked this conversation as resolved.
CORINFO_MODULE_HANDLE mod
) = 0;

// Returns the name of the assembly "assem".
virtual const char* getAssemblyName (
CORINFO_ASSEMBLY_HANDLE assem
// Returns the assembly name of the class "cls", or nullptr if there is none.
virtual const char* getClassAssemblyName (
CORINFO_CLASS_HANDLE cls
) = 0;

// Allocate and delete process-lifetime objects. Should only be
Expand Down
8 changes: 1 addition & 7 deletions src/coreclr/inc/icorjitinfoimpl_generated.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -193,15 +193,9 @@ bool isValueClass(
uint32_t getClassAttribs(
CORINFO_CLASS_HANDLE cls) override;

CORINFO_MODULE_HANDLE getClassModule(
const char* getClassAssemblyName(
CORINFO_CLASS_HANDLE cls) override;

CORINFO_ASSEMBLY_HANDLE getModuleAssembly(
CORINFO_MODULE_HANDLE mod) override;

const char* getAssemblyName(
CORINFO_ASSEMBLY_HANDLE assem) override;

void* LongLifetimeMalloc(
size_t sz) override;

Expand Down
10 changes: 5 additions & 5 deletions src/coreclr/inc/jiteeversionguid.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,11 +43,11 @@ typedef const GUID *LPCGUID;
#define GUID_DEFINED
#endif // !GUID_DEFINED

constexpr GUID JITEEVersionIdentifier = { /* 7f7fd340-4779-455a-8046-628f3cd8c3c7 */
0x7f7fd340,
0x4779,
0x455a,
{0x80, 0x46, 0x62, 0x8f, 0x3c, 0xd8, 0xc3, 0xc7}
constexpr GUID JITEEVersionIdentifier = { /* b75a5475-ff22-4078-9551-2024ce03d383 */
0xb75a5475,
0xff22,
0x4078,
{0x95, 0x51, 0x20, 0x24, 0xce, 0x03, 0xd3, 0x83}
};

//////////////////////////////////////////////////////////////////////////////////////////////////////////
Expand Down
4 changes: 1 addition & 3 deletions src/coreclr/jit/ICorJitInfo_names_generated.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,9 +45,7 @@ DEF_CLR_API(getTypeInstantiationArgument)
DEF_CLR_API(printClassName)
DEF_CLR_API(isValueClass)
DEF_CLR_API(getClassAttribs)
DEF_CLR_API(getClassModule)
DEF_CLR_API(getModuleAssembly)
DEF_CLR_API(getAssemblyName)
DEF_CLR_API(getClassAssemblyName)
DEF_CLR_API(LongLifetimeMalloc)
DEF_CLR_API(LongLifetimeFree)
DEF_CLR_API(getIsClassInitedFlagAddress)
Expand Down
26 changes: 4 additions & 22 deletions src/coreclr/jit/ICorJitInfo_wrapper_generated.hpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -416,30 +416,12 @@ uint32_t WrapICorJitInfo::getClassAttribs(
return temp;
}

CORINFO_MODULE_HANDLE WrapICorJitInfo::getClassModule(
const char* WrapICorJitInfo::getClassAssemblyName(
CORINFO_CLASS_HANDLE cls)
{
API_ENTER(getClassModule);
CORINFO_MODULE_HANDLE temp = wrapHnd->getClassModule(cls);
API_LEAVE(getClassModule);
return temp;
}

CORINFO_ASSEMBLY_HANDLE WrapICorJitInfo::getModuleAssembly(
CORINFO_MODULE_HANDLE mod)
{
API_ENTER(getModuleAssembly);
CORINFO_ASSEMBLY_HANDLE temp = wrapHnd->getModuleAssembly(mod);
API_LEAVE(getModuleAssembly);
return temp;
}

const char* WrapICorJitInfo::getAssemblyName(
CORINFO_ASSEMBLY_HANDLE assem)
{
API_ENTER(getAssemblyName);
const char* temp = wrapHnd->getAssemblyName(assem);
API_LEAVE(getAssemblyName);
API_ENTER(getClassAssemblyName);
const char* temp = wrapHnd->getClassAssemblyName(cls);
API_LEAVE(getClassAssemblyName);
return temp;
}

Expand Down
53 changes: 20 additions & 33 deletions src/coreclr/jit/compiler.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -2586,8 +2586,7 @@ void Compiler::compInitOptions(JitFlags* jitFlags)
// We have an exclusion list. See if this method is in an assembly that is on the list.
// Note that we check this for every method, since we might inline across modules, and
// if the inlinee module is on the list, we don't want to use the altjit for it.
const char* methodAssemblyName = info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
const char* methodAssemblyName = eeGetClassAssemblyName(info.compClassHnd);
if (s_pAltJitExcludeAssembliesList->IsInList(methodAssemblyName))
{
opts.altJit = false;
Expand All@@ -2614,8 +2613,7 @@ void Compiler::compInitOptions(JitFlags* jitFlags)
bool assemblyInIncludeList = true; // assume we'll dump, if there's not an include list (or it's empty).
if (s_pJitDisasmIncludeAssembliesList != nullptr && !s_pJitDisasmIncludeAssembliesList->IsEmpty())
{
const char* assemblyName = info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
const char* assemblyName = eeGetClassAssemblyName(info.compClassHnd);
if (!s_pJitDisasmIncludeAssembliesList->IsInList(assemblyName))
{
Comment thread
hez2010 marked this conversation as resolved.
// We have a list, and the current assembly is not in it, so we won't dump.
Expand DownExpand Up@@ -6335,39 +6333,29 @@ int Compiler::compCompile(CORINFO_MODULE_HANDLE classPtr,
#ifdef DEBUG
if (JitConfig.EnableExtraSuperPmiQueries())
{
// This call to getClassModule/getModuleAssembly/getAssemblyName fails in crossgen2 due to these
// APIs being unimplemented. So disable this extra info for pre-jit mode. See
// https://github.com/dotnet/runtime/issues/48888.
//
// Ditto for some of the class name queries for generic params.
//
if (!compileFlags->IsSet(JitFlags::JIT_FLAG_PREJIT))
{
// Get the assembly name, to aid finding any particular SuperPMI method context function
(void)info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
// Get the assembly name, to aid finding any particular SuperPMI method context function
(void)eeGetClassAssemblyName(info.compClassHnd);

// Fetch class names for the method's generic parameters.
//
CORINFO_SIG_INFO sig;
info.compCompHnd->getMethodSig(info.compMethodHnd, &sig, nullptr);
// Fetch class names for the method's generic parameters.
//
CORINFO_SIG_INFO sig;
info.compCompHnd->getMethodSig(info.compMethodHnd, &sig, nullptr);

const unsigned classInst = sig.sigInst.classInstCount;
if (classInst > 0)
const unsigned classInst = sig.sigInst.classInstCount;
if (classInst > 0)
{
for (unsigned i = 0; i < classInst; i++)
{
for (unsigned i = 0; i < classInst; i++)
{
eeGetClassName(sig.sigInst.classInst[i]);
}
eeGetClassName(sig.sigInst.classInst[i]);
}
}

const unsigned methodInst = sig.sigInst.methInstCount;
if (methodInst > 0)
const unsigned methodInst = sig.sigInst.methInstCount;
if (methodInst > 0)
{
for (unsigned i = 0; i < methodInst; i++)
{
for (unsigned i = 0; i < methodInst; i++)
{
eeGetClassName(sig.sigInst.methInst[i]);
}
eeGetClassName(sig.sigInst.methInst[i]);
}
}
}
Expand DownExpand Up@@ -9221,8 +9209,7 @@ void JitTimer::PrintCsvMethodStats(Compiler* comp)
}
else
{
const char* methodAssemblyName = comp->info.compCompHnd->getAssemblyName(
comp->info.compCompHnd->getModuleAssembly(comp->info.compCompHnd->getClassModule(comp->info.compClassHnd)));
const char* methodAssemblyName = comp->eeGetClassAssemblyName(comp->info.compClassHnd);
fprintf(s_csvFile, "\"%s\",", methodAssemblyName);
}
fprintf(s_csvFile, "%u,", comp->info.compILCodeSize);
Expand Down
2 changes: 2 additions & 0 deletions src/coreclr/jit/compiler.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -8337,6 +8337,8 @@ class Compiler
void eePrintObjectDescription(const char* prefix, CORINFO_OBJECT_HANDLE handle);
const char* eeGetShortClassName(CORINFO_CLASS_HANDLE clsHnd);

const char* eeGetClassAssemblyName(CORINFO_CLASS_HANDLE clsHnd);

#if defined(DEBUG)
unsigned eeTryGetClassSize(CORINFO_CLASS_HANDLE clsHnd);
#endif
Expand Down
21 changes: 21 additions & 0 deletions src/coreclr/jit/eeinterface.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -596,6 +596,27 @@ const char* Compiler::eeGetShortClassName(CORINFO_CLASS_HANDLE clsHnd)
return printer.GetBuffer();
}

//------------------------------------------------------------------------
// eeGetClassAssemblyName:
// Get the assembly name of a type.
// If missing information (in SPMI), then return a placeholder string.
//
// Parameters:
// clsHnd - the handle of the class
//
// Return value:
// The name string.
//
const char* Compiler::eeGetClassAssemblyName(CORINFO_CLASS_HANDLE clsHnd)
{
const char* assemblyName = "<unknown assembly>";
eeRunFunctorWithSPMIErrorTrap([&]() {
assemblyName = info.compCompHnd->getClassAssemblyName(clsHnd);
});

return assemblyName != nullptr ? assemblyName : "<no assembly>";
}

void Compiler::eePrintObjectDescription(const char* prefix, CORINFO_OBJECT_HANDLE handle)
{
const size_t maxStrSize = 64;
Expand Down
17 changes: 11 additions & 6 deletions src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs
Original file line numberDiff line numberDiff line change
Expand Up@@ -2092,12 +2092,17 @@ private uint getClassAttribsInternal(TypeDesc type)
return (uint)result;
}

private CORINFO_MODULE_STRUCT_* getClassModule(CORINFO_CLASS_STRUCT_* cls)
{ throw new NotImplementedException("getClassModule"); }
private CORINFO_ASSEMBLY_STRUCT_* getModuleAssembly(CORINFO_MODULE_STRUCT_* mod)
{ throw new NotImplementedException("getModuleAssembly"); }
private byte* getAssemblyName(CORINFO_ASSEMBLY_STRUCT_* assem)
{ throw new NotImplementedException("getAssemblyName"); }
private byte* getClassAssemblyName(CORINFO_CLASS_STRUCT_* cls)
{
TypeDesc type = HandleToObject(cls);

if (type is MetadataType mdType)
{
return (byte*)GetPin(StringToUTF8(mdType.Module.Assembly.GetName().Name));
}

return null;
}

#pragma warning disable CA1822 // Mark members as static
private void* LongLifetimeMalloc(UIntPtr sz)
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions src/coreclr/inc/corinfo.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -930,7 +930,6 @@ struct PatchpointInfo;
// Cookie types consumed by the code generator (these are opaque values
// not inspected by the code generator):

typedef struct CORINFO_ASSEMBLY_STRUCT_* CORINFO_ASSEMBLY_HANDLE;
typedef struct CORINFO_MODULE_STRUCT_* CORINFO_MODULE_HANDLE;
typedef struct CORINFO_DEPENDENCY_STRUCT_* CORINFO_DEPENDENCY_HANDLE;
typedef struct CORINFO_CLASS_STRUCT_* CORINFO_CLASS_HANDLE;
Expand DownExpand Up@@ -2321,18 +2320,9 @@ class ICorStaticInfo
CORINFO_CLASS_HANDLE cls
) = 0;

virtual CORINFO_MODULE_HANDLE getClassModule (
CORINFO_CLASS_HANDLE cls
) = 0;

// Returns the assembly that contains the module "mod".
virtual CORINFO_ASSEMBLY_HANDLE getModuleAssembly (
Comment thread
hez2010 marked this conversation as resolved.
CORINFO_MODULE_HANDLE mod
) = 0;

// Returns the name of the assembly "assem".
virtual const char* getAssemblyName (
CORINFO_ASSEMBLY_HANDLE assem
// Returns the assembly name of the class "cls", or nullptr if there is none.
virtual const char* getClassAssemblyName (
CORINFO_CLASS_HANDLE cls
) = 0;

// Allocate and delete process-lifetime objects. Should only be
Expand Down
8 changes: 1 addition & 7 deletions src/coreclr/inc/icorjitinfoimpl_generated.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -193,15 +193,9 @@ bool isValueClass(
uint32_t getClassAttribs(
CORINFO_CLASS_HANDLE cls) override;

CORINFO_MODULE_HANDLE getClassModule(
const char* getClassAssemblyName(
CORINFO_CLASS_HANDLE cls) override;

CORINFO_ASSEMBLY_HANDLE getModuleAssembly(
CORINFO_MODULE_HANDLE mod) override;

const char* getAssemblyName(
CORINFO_ASSEMBLY_HANDLE assem) override;

void* LongLifetimeMalloc(
size_t sz) override;

Expand Down
10 changes: 5 additions & 5 deletions src/coreclr/inc/jiteeversionguid.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,11 +43,11 @@ typedef const GUID *LPCGUID;
#define GUID_DEFINED
#endif // !GUID_DEFINED

constexpr GUID JITEEVersionIdentifier = { /* 7f7fd340-4779-455a-8046-628f3cd8c3c7 */
0x7f7fd340,
0x4779,
0x455a,
{0x80, 0x46, 0x62, 0x8f, 0x3c, 0xd8, 0xc3, 0xc7}
constexpr GUID JITEEVersionIdentifier = { /* b75a5475-ff22-4078-9551-2024ce03d383 */
0xb75a5475,
0xff22,
0x4078,
{0x95, 0x51, 0x20, 0x24, 0xce, 0x03, 0xd3, 0x83}
};

//////////////////////////////////////////////////////////////////////////////////////////////////////////
Expand Down
4 changes: 1 addition & 3 deletions src/coreclr/jit/ICorJitInfo_names_generated.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,9 +45,7 @@ DEF_CLR_API(getTypeInstantiationArgument)
DEF_CLR_API(printClassName)
DEF_CLR_API(isValueClass)
DEF_CLR_API(getClassAttribs)
DEF_CLR_API(getClassModule)
DEF_CLR_API(getModuleAssembly)
DEF_CLR_API(getAssemblyName)
DEF_CLR_API(getClassAssemblyName)
DEF_CLR_API(LongLifetimeMalloc)
DEF_CLR_API(LongLifetimeFree)
DEF_CLR_API(getIsClassInitedFlagAddress)
Expand Down
26 changes: 4 additions & 22 deletions src/coreclr/jit/ICorJitInfo_wrapper_generated.hpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -416,30 +416,12 @@ uint32_t WrapICorJitInfo::getClassAttribs(
return temp;
}

CORINFO_MODULE_HANDLE WrapICorJitInfo::getClassModule(
const char* WrapICorJitInfo::getClassAssemblyName(
CORINFO_CLASS_HANDLE cls)
{
API_ENTER(getClassModule);
CORINFO_MODULE_HANDLE temp = wrapHnd->getClassModule(cls);
API_LEAVE(getClassModule);
return temp;
}

CORINFO_ASSEMBLY_HANDLE WrapICorJitInfo::getModuleAssembly(
CORINFO_MODULE_HANDLE mod)
{
API_ENTER(getModuleAssembly);
CORINFO_ASSEMBLY_HANDLE temp = wrapHnd->getModuleAssembly(mod);
API_LEAVE(getModuleAssembly);
return temp;
}

const char* WrapICorJitInfo::getAssemblyName(
CORINFO_ASSEMBLY_HANDLE assem)
{
API_ENTER(getAssemblyName);
const char* temp = wrapHnd->getAssemblyName(assem);
API_LEAVE(getAssemblyName);
API_ENTER(getClassAssemblyName);
const char* temp = wrapHnd->getClassAssemblyName(cls);
API_LEAVE(getClassAssemblyName);
return temp;
}

Expand Down
53 changes: 20 additions & 33 deletions src/coreclr/jit/compiler.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -2586,8 +2586,7 @@ void Compiler::compInitOptions(JitFlags* jitFlags)
// We have an exclusion list. See if this method is in an assembly that is on the list.
// Note that we check this for every method, since we might inline across modules, and
// if the inlinee module is on the list, we don't want to use the altjit for it.
const char* methodAssemblyName = info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
const char* methodAssemblyName = eeGetClassAssemblyName(info.compClassHnd);
if (s_pAltJitExcludeAssembliesList->IsInList(methodAssemblyName))
{
opts.altJit = false;
Expand All@@ -2614,8 +2613,7 @@ void Compiler::compInitOptions(JitFlags* jitFlags)
bool assemblyInIncludeList = true; // assume we'll dump, if there's not an include list (or it's empty).
if (s_pJitDisasmIncludeAssembliesList != nullptr && !s_pJitDisasmIncludeAssembliesList->IsEmpty())
{
const char* assemblyName = info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
const char* assemblyName = eeGetClassAssemblyName(info.compClassHnd);
if (!s_pJitDisasmIncludeAssembliesList->IsInList(assemblyName))
{
Comment thread
hez2010 marked this conversation as resolved.
// We have a list, and the current assembly is not in it, so we won't dump.
Expand DownExpand Up@@ -6335,39 +6333,29 @@ int Compiler::compCompile(CORINFO_MODULE_HANDLE classPtr,
#ifdef DEBUG
if (JitConfig.EnableExtraSuperPmiQueries())
{
// This call to getClassModule/getModuleAssembly/getAssemblyName fails in crossgen2 due to these
// APIs being unimplemented. So disable this extra info for pre-jit mode. See
// https://github.com/dotnet/runtime/issues/48888.
//
// Ditto for some of the class name queries for generic params.
//
if (!compileFlags->IsSet(JitFlags::JIT_FLAG_PREJIT))
{
// Get the assembly name, to aid finding any particular SuperPMI method context function
(void)info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
// Get the assembly name, to aid finding any particular SuperPMI method context function
(void)eeGetClassAssemblyName(info.compClassHnd);

// Fetch class names for the method's generic parameters.
//
CORINFO_SIG_INFO sig;
info.compCompHnd->getMethodSig(info.compMethodHnd, &sig, nullptr);
// Fetch class names for the method's generic parameters.
//
CORINFO_SIG_INFO sig;
info.compCompHnd->getMethodSig(info.compMethodHnd, &sig, nullptr);

const unsigned classInst = sig.sigInst.classInstCount;
if (classInst > 0)
const unsigned classInst = sig.sigInst.classInstCount;
if (classInst > 0)
{
for (unsigned i = 0; i < classInst; i++)
{
for (unsigned i = 0; i < classInst; i++)
{
eeGetClassName(sig.sigInst.classInst[i]);
}
eeGetClassName(sig.sigInst.classInst[i]);
}
}

const unsigned methodInst = sig.sigInst.methInstCount;
if (methodInst > 0)
const unsigned methodInst = sig.sigInst.methInstCount;
if (methodInst > 0)
{
for (unsigned i = 0; i < methodInst; i++)
{
for (unsigned i = 0; i < methodInst; i++)
{
eeGetClassName(sig.sigInst.methInst[i]);
}
eeGetClassName(sig.sigInst.methInst[i]);
}
}
}
Expand DownExpand Up@@ -9221,8 +9209,7 @@ void JitTimer::PrintCsvMethodStats(Compiler* comp)
}
else
{
const char* methodAssemblyName = comp->info.compCompHnd->getAssemblyName(
comp->info.compCompHnd->getModuleAssembly(comp->info.compCompHnd->getClassModule(comp->info.compClassHnd)));
const char* methodAssemblyName = comp->eeGetClassAssemblyName(comp->info.compClassHnd);
fprintf(s_csvFile, "\"%s\",", methodAssemblyName);
}
fprintf(s_csvFile, "%u,", comp->info.compILCodeSize);
Expand Down
2 changes: 2 additions & 0 deletions src/coreclr/jit/compiler.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -8337,6 +8337,8 @@ class Compiler
void eePrintObjectDescription(const char* prefix, CORINFO_OBJECT_HANDLE handle);
const char* eeGetShortClassName(CORINFO_CLASS_HANDLE clsHnd);

const char* eeGetClassAssemblyName(CORINFO_CLASS_HANDLE clsHnd);

#if defined(DEBUG)
unsigned eeTryGetClassSize(CORINFO_CLASS_HANDLE clsHnd);
#endif
Expand Down
21 changes: 21 additions & 0 deletions src/coreclr/jit/eeinterface.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -596,6 +596,27 @@ const char* Compiler::eeGetShortClassName(CORINFO_CLASS_HANDLE clsHnd)
return printer.GetBuffer();
}

//------------------------------------------------------------------------
// eeGetClassAssemblyName:
// Get the assembly name of a type.
// If missing information (in SPMI), then return a placeholder string.
//
// Parameters:
// clsHnd - the handle of the class
//
// Return value:
// The name string.
//
const char* Compiler::eeGetClassAssemblyName(CORINFO_CLASS_HANDLE clsHnd)
{
const char* assemblyName = "<unknown assembly>";
eeRunFunctorWithSPMIErrorTrap([&]() {
assemblyName = info.compCompHnd->getClassAssemblyName(clsHnd);
});

return assemblyName != nullptr ? assemblyName : "<no assembly>";
}

void Compiler::eePrintObjectDescription(const char* prefix, CORINFO_OBJECT_HANDLE handle)
{
const size_t maxStrSize = 64;
Expand Down
17 changes: 11 additions & 6 deletions src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs
Original file line numberDiff line numberDiff line change
Expand Up@@ -2092,12 +2092,17 @@ private uint getClassAttribsInternal(TypeDesc type)
return (uint)result;
}

private CORINFO_MODULE_STRUCT_* getClassModule(CORINFO_CLASS_STRUCT_* cls)
{ throw new NotImplementedException("getClassModule"); }
private CORINFO_ASSEMBLY_STRUCT_* getModuleAssembly(CORINFO_MODULE_STRUCT_* mod)
{ throw new NotImplementedException("getModuleAssembly"); }
private byte* getAssemblyName(CORINFO_ASSEMBLY_STRUCT_* assem)
{ throw new NotImplementedException("getAssemblyName"); }
private byte* getClassAssemblyName(CORINFO_CLASS_STRUCT_* cls)
{
TypeDesc type = HandleToObject(cls);

if (type is MetadataType mdType)
{
return (byte*)GetPin(StringToUTF8(mdType.Module.Assembly.GetName().Name));
}

return null;
}

#pragma warning disable CA1822 // Mark members as static
private void* LongLifetimeMalloc(UIntPtr sz)
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions src/coreclr/inc/corinfo.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -930,7 +930,6 @@ struct PatchpointInfo;
// Cookie types consumed by the code generator (these are opaque values
// not inspected by the code generator):

typedef struct CORINFO_ASSEMBLY_STRUCT_* CORINFO_ASSEMBLY_HANDLE;
typedef struct CORINFO_MODULE_STRUCT_* CORINFO_MODULE_HANDLE;
typedef struct CORINFO_DEPENDENCY_STRUCT_* CORINFO_DEPENDENCY_HANDLE;
typedef struct CORINFO_CLASS_STRUCT_* CORINFO_CLASS_HANDLE;
Expand DownExpand Up@@ -2321,18 +2320,9 @@ class ICorStaticInfo
CORINFO_CLASS_HANDLE cls
) = 0;

virtual CORINFO_MODULE_HANDLE getClassModule (
CORINFO_CLASS_HANDLE cls
) = 0;

// Returns the assembly that contains the module "mod".
virtual CORINFO_ASSEMBLY_HANDLE getModuleAssembly (
Comment thread
hez2010 marked this conversation as resolved.
CORINFO_MODULE_HANDLE mod
) = 0;

// Returns the name of the assembly "assem".
virtual const char* getAssemblyName (
CORINFO_ASSEMBLY_HANDLE assem
// Returns the assembly name of the class "cls", or nullptr if there is none.
virtual const char* getClassAssemblyName (
CORINFO_CLASS_HANDLE cls
) = 0;

// Allocate and delete process-lifetime objects. Should only be
Expand Down
8 changes: 1 addition & 7 deletions src/coreclr/inc/icorjitinfoimpl_generated.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -193,15 +193,9 @@ bool isValueClass(
uint32_t getClassAttribs(
CORINFO_CLASS_HANDLE cls) override;

CORINFO_MODULE_HANDLE getClassModule(
const char* getClassAssemblyName(
CORINFO_CLASS_HANDLE cls) override;

CORINFO_ASSEMBLY_HANDLE getModuleAssembly(
CORINFO_MODULE_HANDLE mod) override;

const char* getAssemblyName(
CORINFO_ASSEMBLY_HANDLE assem) override;

void* LongLifetimeMalloc(
size_t sz) override;

Expand Down
10 changes: 5 additions & 5 deletions src/coreclr/inc/jiteeversionguid.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -43,11 +43,11 @@ typedef const GUID *LPCGUID;
#define GUID_DEFINED
#endif // !GUID_DEFINED

constexpr GUID JITEEVersionIdentifier = { /* 7f7fd340-4779-455a-8046-628f3cd8c3c7 */
0x7f7fd340,
0x4779,
0x455a,
{0x80, 0x46, 0x62, 0x8f, 0x3c, 0xd8, 0xc3, 0xc7}
constexpr GUID JITEEVersionIdentifier = { /* b75a5475-ff22-4078-9551-2024ce03d383 */
0xb75a5475,
0xff22,
0x4078,
{0x95, 0x51, 0x20, 0x24, 0xce, 0x03, 0xd3, 0x83}
};

//////////////////////////////////////////////////////////////////////////////////////////////////////////
Expand Down
4 changes: 1 addition & 3 deletions src/coreclr/jit/ICorJitInfo_names_generated.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,9 +45,7 @@ DEF_CLR_API(getTypeInstantiationArgument)
DEF_CLR_API(printClassName)
DEF_CLR_API(isValueClass)
DEF_CLR_API(getClassAttribs)
DEF_CLR_API(getClassModule)
DEF_CLR_API(getModuleAssembly)
DEF_CLR_API(getAssemblyName)
DEF_CLR_API(getClassAssemblyName)
DEF_CLR_API(LongLifetimeMalloc)
DEF_CLR_API(LongLifetimeFree)
DEF_CLR_API(getIsClassInitedFlagAddress)
Expand Down
26 changes: 4 additions & 22 deletions src/coreclr/jit/ICorJitInfo_wrapper_generated.hpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -416,30 +416,12 @@ uint32_t WrapICorJitInfo::getClassAttribs(
return temp;
}

CORINFO_MODULE_HANDLE WrapICorJitInfo::getClassModule(
const char* WrapICorJitInfo::getClassAssemblyName(
CORINFO_CLASS_HANDLE cls)
{
API_ENTER(getClassModule);
CORINFO_MODULE_HANDLE temp = wrapHnd->getClassModule(cls);
API_LEAVE(getClassModule);
return temp;
}

CORINFO_ASSEMBLY_HANDLE WrapICorJitInfo::getModuleAssembly(
CORINFO_MODULE_HANDLE mod)
{
API_ENTER(getModuleAssembly);
CORINFO_ASSEMBLY_HANDLE temp = wrapHnd->getModuleAssembly(mod);
API_LEAVE(getModuleAssembly);
return temp;
}

const char* WrapICorJitInfo::getAssemblyName(
CORINFO_ASSEMBLY_HANDLE assem)
{
API_ENTER(getAssemblyName);
const char* temp = wrapHnd->getAssemblyName(assem);
API_LEAVE(getAssemblyName);
API_ENTER(getClassAssemblyName);
const char* temp = wrapHnd->getClassAssemblyName(cls);
API_LEAVE(getClassAssemblyName);
return temp;
}

Expand Down
53 changes: 20 additions & 33 deletions src/coreclr/jit/compiler.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -2586,8 +2586,7 @@ void Compiler::compInitOptions(JitFlags* jitFlags)
// We have an exclusion list. See if this method is in an assembly that is on the list.
// Note that we check this for every method, since we might inline across modules, and
// if the inlinee module is on the list, we don't want to use the altjit for it.
const char* methodAssemblyName = info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
const char* methodAssemblyName = eeGetClassAssemblyName(info.compClassHnd);
if (s_pAltJitExcludeAssembliesList->IsInList(methodAssemblyName))
{
opts.altJit = false;
Expand All@@ -2614,8 +2613,7 @@ void Compiler::compInitOptions(JitFlags* jitFlags)
bool assemblyInIncludeList = true; // assume we'll dump, if there's not an include list (or it's empty).
if (s_pJitDisasmIncludeAssembliesList != nullptr && !s_pJitDisasmIncludeAssembliesList->IsEmpty())
{
const char* assemblyName = info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
const char* assemblyName = eeGetClassAssemblyName(info.compClassHnd);
if (!s_pJitDisasmIncludeAssembliesList->IsInList(assemblyName))
{
Comment thread
hez2010 marked this conversation as resolved.
// We have a list, and the current assembly is not in it, so we won't dump.
Expand DownExpand Up@@ -6335,39 +6333,29 @@ int Compiler::compCompile(CORINFO_MODULE_HANDLE classPtr,
#ifdef DEBUG
if (JitConfig.EnableExtraSuperPmiQueries())
{
// This call to getClassModule/getModuleAssembly/getAssemblyName fails in crossgen2 due to these
// APIs being unimplemented. So disable this extra info for pre-jit mode. See
// https://github.com/dotnet/runtime/issues/48888.
//
// Ditto for some of the class name queries for generic params.
//
if (!compileFlags->IsSet(JitFlags::JIT_FLAG_PREJIT))
{
// Get the assembly name, to aid finding any particular SuperPMI method context function
(void)info.compCompHnd->getAssemblyName(
info.compCompHnd->getModuleAssembly(info.compCompHnd->getClassModule(info.compClassHnd)));
// Get the assembly name, to aid finding any particular SuperPMI method context function
(void)eeGetClassAssemblyName(info.compClassHnd);

// Fetch class names for the method's generic parameters.
//
CORINFO_SIG_INFO sig;
info.compCompHnd->getMethodSig(info.compMethodHnd, &sig, nullptr);
// Fetch class names for the method's generic parameters.
//
CORINFO_SIG_INFO sig;
info.compCompHnd->getMethodSig(info.compMethodHnd, &sig, nullptr);

const unsigned classInst = sig.sigInst.classInstCount;
if (classInst > 0)
const unsigned classInst = sig.sigInst.classInstCount;
if (classInst > 0)
{
for (unsigned i = 0; i < classInst; i++)
{
for (unsigned i = 0; i < classInst; i++)
{
eeGetClassName(sig.sigInst.classInst[i]);
}
eeGetClassName(sig.sigInst.classInst[i]);
}
}

const unsigned methodInst = sig.sigInst.methInstCount;
if (methodInst > 0)
const unsigned methodInst = sig.sigInst.methInstCount;
if (methodInst > 0)
{
for (unsigned i = 0; i < methodInst; i++)
{
for (unsigned i = 0; i < methodInst; i++)
{
eeGetClassName(sig.sigInst.methInst[i]);
}
eeGetClassName(sig.sigInst.methInst[i]);
}
}
}
Expand DownExpand Up@@ -9221,8 +9209,7 @@ void JitTimer::PrintCsvMethodStats(Compiler* comp)
}
else
{
const char* methodAssemblyName = comp->info.compCompHnd->getAssemblyName(
comp->info.compCompHnd->getModuleAssembly(comp->info.compCompHnd->getClassModule(comp->info.compClassHnd)));
const char* methodAssemblyName = comp->eeGetClassAssemblyName(comp->info.compClassHnd);
fprintf(s_csvFile, "\"%s\",", methodAssemblyName);
}
fprintf(s_csvFile, "%u,", comp->info.compILCodeSize);
Expand Down
2 changes: 2 additions & 0 deletions src/coreclr/jit/compiler.h
Original file line numberDiff line numberDiff line change
Expand Up@@ -8337,6 +8337,8 @@ class Compiler
void eePrintObjectDescription(const char* prefix, CORINFO_OBJECT_HANDLE handle);
const char* eeGetShortClassName(CORINFO_CLASS_HANDLE clsHnd);

const char* eeGetClassAssemblyName(CORINFO_CLASS_HANDLE clsHnd);

#if defined(DEBUG)
unsigned eeTryGetClassSize(CORINFO_CLASS_HANDLE clsHnd);
#endif
Expand Down
21 changes: 21 additions & 0 deletions src/coreclr/jit/eeinterface.cpp
Original file line numberDiff line numberDiff line change
Expand Up@@ -596,6 +596,27 @@ const char* Compiler::eeGetShortClassName(CORINFO_CLASS_HANDLE clsHnd)
return printer.GetBuffer();
}

//------------------------------------------------------------------------
// eeGetClassAssemblyName:
// Get the assembly name of a type.
// If missing information (in SPMI), then return a placeholder string.
//
// Parameters:
// clsHnd - the handle of the class
//
// Return value:
// The name string.
//
const char* Compiler::eeGetClassAssemblyName(CORINFO_CLASS_HANDLE clsHnd)
{
const char* assemblyName = "<unknown assembly>";
eeRunFunctorWithSPMIErrorTrap([&]() {
assemblyName = info.compCompHnd->getClassAssemblyName(clsHnd);
});

return assemblyName != nullptr ? assemblyName : "<no assembly>";
}

void Compiler::eePrintObjectDescription(const char* prefix, CORINFO_OBJECT_HANDLE handle)
{
const size_t maxStrSize = 64;
Expand Down
17 changes: 11 additions & 6 deletions src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs
Original file line numberDiff line numberDiff line change
Expand Up@@ -2092,12 +2092,17 @@ private uint getClassAttribsInternal(TypeDesc type)
return (uint)result;
}

private CORINFO_MODULE_STRUCT_* getClassModule(CORINFO_CLASS_STRUCT_* cls)
{ throw new NotImplementedException("getClassModule"); }
private CORINFO_ASSEMBLY_STRUCT_* getModuleAssembly(CORINFO_MODULE_STRUCT_* mod)
{ throw new NotImplementedException("getModuleAssembly"); }
private byte* getAssemblyName(CORINFO_ASSEMBLY_STRUCT_* assem)
{ throw new NotImplementedException("getAssemblyName"); }
private byte* getClassAssemblyName(CORINFO_CLASS_STRUCT_* cls)
{
TypeDesc type = HandleToObject(cls);

if (type is MetadataType mdType)
{
return (byte*)GetPin(StringToUTF8(mdType.Module.Assembly.GetName().Name));
}

return null;
}

#pragma warning disable CA1822 // Mark members as static
private void* LongLifetimeMalloc(UIntPtr sz)
Expand Down
Loading