[browser] Increase timeout and clean up after failed attempts of launching browser when testing - #107865

Closed
ilonatommy wants to merge 34 commits into
dotnet:mainfrom
ilonatommy:fix-107771
Closed

[browser] Increase timeout and clean up after failed attempts of launching browser when testing#107865
ilonatommy wants to merge 34 commits into
dotnet:mainfrom
ilonatommy:fix-107771

Conversation

@ilonatommy

@ilonatommyilonatommy commented Sep 16, 2024•
edited
Loading

Copy link
Copy Markdown
Member

This is a playground for fixing #107771.
The issue is hit only on Windows, where we are running WBT sequentially.

Changes:

  • Upgrade Playwright to "1.47.0" (newest available)
  • After upgrading Playwright, it is creating node dir in linux-x64 dir, not in linux. Node requires elevated execution rights, so chmod +x path was changed accordingly.
  • Killing all chrome processes before we call the problematic method that launches the browser.
  • Making sure we clean up after each run by closing Browser and disposing of Playwright.

@ilonatommyilonatommy added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Sep 16, 2024
@ilonatommyilonatommy self-assigned this Sep 16, 2024
pavelsavara
pavelsavara reviewed Sep 16, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs Outdated
lewing
lewing reviewed Sep 16, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs Outdated
@ilonatommy

ilonatommy commented Sep 16, 2024

Copy link
Copy Markdown
MemberAuthor

It does not help:

 Attempt 3 failed with TimeoutException: System.TimeoutException: Timeout 15000ms exceeded.
=========================== logs ===========================
<launching> C:\helix\work\correlation\chrome-win\chrome.exe --disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater --allow-pre-commit-input --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync --force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic --use-mock-keychain --no-service-autorun --export-tagged-pdf --headless --hide-scrollbars --mute-audio --blink-settings=primaryHoverType=2,availableHoverTypes=2,primaryPointerType=4,availablePointerTypes=4 --no-sandbox --explicitly-allowed-ports=49238 --ignore-certificate-errors --user-data-dir=C:\Users\ContainerAdministrator\AppData\Local\Temp\playwright_chromiumdev_profile-j7hftC --remote-debugging-pipe --no-startup-window
<launched> pid=9100
============================================================
at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](String guid, String method, Object args) in /_/src/Playwright/Transport/Connection.cs:line 164
at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal) in /_/src/Playwright/Transport/Connection.cs:line 475
at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options) in /_/src/Playwright/Core/BrowserType.cs:line 61
at Wasm.Build.Tests.BrowserRunner.SpawnBrowserAsync(String browserUrl, Boolean headless, Int32 timeout, Int32 maxRetries) in /_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs:line 120

log

This was referenced Sep 16, 2024
Closed
Closed
@lewing

lewing commented Sep 16, 2024

Copy link
Copy Markdown
Member

Can we check if there are other running chrome instances or something to help diagnose the issue?

@ilonatommy

ilonatommy commented Sep 17, 2024

Copy link
Copy Markdown
MemberAuthor

If we keep the last commit about killing all other chromes, running WBT locally can be a nuisance. If it works, we should check for running on CI and only then call TerminateExistingChromeInstances. I did not register local timeouts similar to these on CI, so it should be fine.

@ilonatommy

ilonatommy commented Sep 17, 2024

Copy link
Copy Markdown
MemberAuthor

It's not about chrome instances, Found 0 old Chrome processes. in log when it still timeouts.

@ilonatommy

ilonatommy commented Sep 18, 2024

Copy link
Copy Markdown
MemberAuthor

The chrome bump will be ready soon: #107504, maybe that might help?

@ilonatommy

ilonatommy commented Sep 20, 2024

Copy link
Copy Markdown
MemberAuthor

Failures are on Windows with Workloads-NoFingerprint-ST-Wasm.Build.Tests:

 Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations(forConsole: False, runOutsideProjectDirectory: True, extraProperties: "") [FAIL]
System.Exception : Timed out after 120s waiting for 'WASM EXIT' message
Stack Trace:
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(242,0): at Wasm.Build.Tests.BrowserRunner.WaitForExitMessageAsync(TimeSpan timeout)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(324,0): at Wasm.Build.Tests.WasmTemplateTests.BrowserRunTwiceWithAndThenWithoutBuildAsync(String config, String extraProperties, Boolean runOutsideProjectDirectory)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(325,0): at Wasm.Build.Tests.WasmTemplateTests.BrowserRunTwiceWithAndThenWithoutBuildAsync(String config, String extraProperties, Boolean runOutsideProjectDirectory)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(301,0): at Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations(Boolean forConsole, Boolean runOutsideProjectDirectory, String extraProperties)

@build-analysisbuild-analysisBot mentioned this pull request Sep 22, 2024
Closed
This was referenced Sep 30, 2024
Closed
Closed
This was referenced Sep 30, 2024
Closed
Open
Open
Closed
Closed
@ilonatommyilonatommy mentioned this pull request Oct 1, 2024
Closed
@ilonatommy

ilonatommy commented Oct 1, 2024

Copy link
Copy Markdown
MemberAuthor

The issue is still existing after the Playwright bump, see: https://helix.dot.net/api/2019-06-17/jobs/8d53b01d-113d-4e65-a893-6a5d825a52b6/workitems/Workloads-NoWebcil-ST-Wasm.Build.Tests.TestAppScenarios.LibraryInitializerTests/console.
I created an issue in Playwright repo: microsoft/playwright#32897, maybe we can get some suggestions about what could be going on.

@ilonatommyilonatommy mentioned this pull request Oct 1, 2024
Merged
@ilonatommy
ilonatommy marked this pull request as draft October 1, 2024 13:20
@ilonatommyilonatommy added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Oct 1, 2024
@ilonatommy

ilonatommy commented Oct 2, 2024

Copy link
Copy Markdown
MemberAuthor

Using default chromium from Playwright is broken on Linux:

Microsoft.Playwright.PlaywrightException : Executable doesn't exist at /home/helixbot/.cache/ms-playwright/chromium-1134/chrome-linux/chrome
╔════════════════════════════════════════════════════════════╗
║ Looks like Playwright was just installed or updated. ║
║ Please run the following command to download new browsers: ║
║ ║
║ pwsh bin/Debug/netX/playwright.ps1 install ║
║ ║
║ <3 Playwright Team ║
╚════════════════════════════════════════════════════════════╝
Stack Trace:
/_/src/Playwright/Transport/Connection.cs(206,0): at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](ChannelOwner object, String method, Dictionary`2 dictionary, Boolean keepNulls)
/_/src/Playwright/Transport/Connection.cs(532,0): at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal)
/_/src/Playwright/Core/BrowserType.cs(56,0): at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options)
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(129,0): at Wasm.Build.Tests.BrowserRunner.SpawnBrowserAsync(String browserUrl, Boolean headless, Nullable`1 timeout, Int32 maxRetries, String language)
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(201,0): at Wasm.Build.Tests.BrowserRunner.RunAsync(ToolCommand cmd, String args, Boolean headless, String language, Action`2 onConsoleMessage, Action`1 onServerMessage, Action`1 onError, Func`2 modifyBrowserUrl)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWasmTestBase.cs(202,0): at Wasm.Build.Tests.BlazorWasmTestBase.BlazorRunTest(String runArgs, String workingDirectory, BlazorRunOptions runOptions)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWasmTestBase.cs(229,0): at Wasm.Build.Tests.BlazorWasmTestBase.BlazorRunTest(String runArgs, String workingDirectory, BlazorRunOptions runOptions)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/WorkloadRequiredTests.cs(119,0): at Wasm.Build.Tests.Blazor.WorkloadRequiredTests.WorkloadNotRequiredForInvariantGlobalization(String config, Boolean invariant, Boolean publish)
--- End of stack trace from previous location ---

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-107865-merge-50c72d5eddc049108b/NoWorkload-NoWebcil-ST-Wasm.Build.Tests/1/console.47c37d30.log?helixlogtype=result

@ilonatommy

ilonatommy commented Oct 2, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

1st and 2nd run with default chrome + higher timeout: success.
3rd: timeout on Linux, Windows passes.
4th: passes.

@build-analysisbuild-analysisBot mentioned this pull request Oct 2, 2024
Open
3 tasks
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Nov 14, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewinglewinglewing left review comments
@pavelsavarapavelsavarapavelsavara approved these changes
@marafmarafmaraf approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Build-monoNO-MERGEThe PR is not ready for merge yet (see discussion for detailed reasons)os-browserBrowser variant of arch-wasm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ilonatommy@lewing@pavelsavara@maraf
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[browser] Increase timeout and clean up after failed attempts of launching browser when testing - #107865
Closed
ilonatommy wants to merge 34 commits into
dotnet:mainfrom 
ilonatommy:fix-107771
Closed
[browser] Increase timeout and clean up after failed attempts of launching browser when testing#107865
ilonatommy wants to merge 34 commits into
dotnet:mainfrom 
ilonatommy:fix-107771
Conversation
@ilonatommy
@ilonatommyilonatommy
commented
Sep 16, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This is a playground for fixing #107771.

The issue is hit only on Windows, where we are running WBT sequentially.
Changes:
  • Upgrade Playwright to "1.47.0" (newest available)
  • After upgrading Playwright, it is creating node dir in linux-x64 dir, not in linux. Node requires elevated execution rights, so chmod +x path was changed accordingly.
  • Killing all chrome processes before we call the problematic method that launches the browser.
  • Making sure we clean up after each run by closing Browser and disposing of Playwright.
@ilonatommyilonatommy
added

arch-wasm
WebAssembly architecture
area-Build-mono

os-browser
Browser variant of arch-wasm
labels
Sep 16, 2024
@ilonatommyilonatommy
self-assigned this
Sep 16, 2024
pavelsavara
pavelsavara
reviewed
Sep 16, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs
Outdated

lewing
lewing
reviewed
Sep 16, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs
Outdated

@ilonatommy
ilonatommy
commented
Sep 16, 2024

Copy link


Copy Markdown

MemberAuthor
It does not help:
 Attempt 3 failed with TimeoutException: System.TimeoutException: Timeout 15000ms exceeded.
=========================== logs ===========================
<launching> C:\helix\work\correlation\chrome-win\chrome.exe --disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater --allow-pre-commit-input --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync --force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic --use-mock-keychain --no-service-autorun --export-tagged-pdf --headless --hide-scrollbars --mute-audio --blink-settings=primaryHoverType=2,availableHoverTypes=2,primaryPointerType=4,availablePointerTypes=4 --no-sandbox --explicitly-allowed-ports=49238 --ignore-certificate-errors --user-data-dir=C:\Users\ContainerAdministrator\AppData\Local\Temp\playwright_chromiumdev_profile-j7hftC --remote-debugging-pipe --no-startup-window
<launched> pid=9100
============================================================
at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](String guid, String method, Object args) in /_/src/Playwright/Transport/Connection.cs:line 164
at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal) in /_/src/Playwright/Transport/Connection.cs:line 475
at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options) in /_/src/Playwright/Core/BrowserType.cs:line 61
at Wasm.Build.Tests.BrowserRunner.SpawnBrowserAsync(String browserUrl, Boolean headless, Int32 timeout, Int32 maxRetries) in /_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs:line 120

log

This was referenced Sep 16, 2024

Closed


Closed

@lewing
lewing
commented
Sep 16, 2024

Copy link


Copy Markdown

Member
Can we check if there are other running chrome instances or something to help diagnose the issue?
@ilonatommy
ilonatommy
commented
Sep 17, 2024

Copy link


Copy Markdown

MemberAuthor
If we keep the last commit about killing all other chromes, running WBT locally can be a nuisance. If it works, we should check for running on CI and only then call TerminateExistingChromeInstances. I did not register local timeouts similar to these on CI, so it should be fine.
@ilonatommy
ilonatommy
commented
Sep 17, 2024

Copy link


Copy Markdown

MemberAuthor
It's not about chrome instances, Found 0 old Chrome processes. in log when it still timeouts.
@ilonatommy
ilonatommy
commented
Sep 18, 2024

Copy link


Copy Markdown

MemberAuthor
The chrome bump will be ready soon: #107504, maybe that might help?
@ilonatommy
ilonatommy
commented
Sep 20, 2024

Copy link


Copy Markdown

MemberAuthor
Failures are on Windows with Workloads-NoFingerprint-ST-Wasm.Build.Tests:
 Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations(forConsole: False, runOutsideProjectDirectory: True, extraProperties: "") [FAIL]
System.Exception : Timed out after 120s waiting for 'WASM EXIT' message
Stack Trace:
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(242,0): at Wasm.Build.Tests.BrowserRunner.WaitForExitMessageAsync(TimeSpan timeout)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(324,0): at Wasm.Build.Tests.WasmTemplateTests.BrowserRunTwiceWithAndThenWithoutBuildAsync(String config, String extraProperties, Boolean runOutsideProjectDirectory)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(325,0): at Wasm.Build.Tests.WasmTemplateTests.BrowserRunTwiceWithAndThenWithoutBuildAsync(String config, String extraProperties, Boolean runOutsideProjectDirectory)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(301,0): at Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations(Boolean forConsole, Boolean runOutsideProjectDirectory, String extraProperties)

@build-analysisbuild-analysisBot
mentioned this pull request
Sep 22, 2024

Closed


This was referenced Sep 30, 2024

Closed


Closed


This was referenced Sep 30, 2024

Closed


Open


Open


Closed


Closed

@ilonatommyilonatommy
mentioned this pull request
Oct 1, 2024

Closed

@ilonatommy
ilonatommy
commented
Oct 1, 2024

Copy link


Copy Markdown

MemberAuthor
The issue is still existing after the Playwright bump, see: https://helix.dot.net/api/2019-06-17/jobs/8d53b01d-113d-4e65-a893-6a5d825a52b6/workitems/Workloads-NoWebcil-ST-Wasm.Build.Tests.TestAppScenarios.LibraryInitializerTests/console.

I created an issue in Playwright repo: microsoft/playwright#32897, maybe we can get some suggestions about what could be going on.
@ilonatommyilonatommy
mentioned this pull request
Oct 1, 2024
 Merged

@ilonatommy
ilonatommy
marked this pull request as draft
October 1, 2024 13:20
@ilonatommyilonatommy
added
the 
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
Oct 1, 2024
@ilonatommy
ilonatommy
commented
Oct 2, 2024

Copy link


Copy Markdown

MemberAuthor
Using default chromium from Playwright is broken on Linux:
Microsoft.Playwright.PlaywrightException : Executable doesn't exist at /home/helixbot/.cache/ms-playwright/chromium-1134/chrome-linux/chrome
╔════════════════════════════════════════════════════════════╗
║ Looks like Playwright was just installed or updated. ║
║ Please run the following command to download new browsers: ║
║ ║
║ pwsh bin/Debug/netX/playwright.ps1 install ║
║ ║
║ <3 Playwright Team ║
╚════════════════════════════════════════════════════════════╝
Stack Trace:
/_/src/Playwright/Transport/Connection.cs(206,0): at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](ChannelOwner object, String method, Dictionary`2 dictionary, Boolean keepNulls)
/_/src/Playwright/Transport/Connection.cs(532,0): at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal)
/_/src/Playwright/Core/BrowserType.cs(56,0): at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options)
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(129,0): at Wasm.Build.Tests.BrowserRunner.SpawnBrowserAsync(String browserUrl, Boolean headless, Nullable`1 timeout, Int32 maxRetries, String language)
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(201,0): at Wasm.Build.Tests.BrowserRunner.RunAsync(ToolCommand cmd, String args, Boolean headless, String language, Action`2 onConsoleMessage, Action`1 onServerMessage, Action`1 onError, Func`2 modifyBrowserUrl)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWasmTestBase.cs(202,0): at Wasm.Build.Tests.BlazorWasmTestBase.BlazorRunTest(String runArgs, String workingDirectory, BlazorRunOptions runOptions)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWasmTestBase.cs(229,0): at Wasm.Build.Tests.BlazorWasmTestBase.BlazorRunTest(String runArgs, String workingDirectory, BlazorRunOptions runOptions)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/WorkloadRequiredTests.cs(119,0): at Wasm.Build.Tests.Blazor.WorkloadRequiredTests.WorkloadNotRequiredForInvariantGlobalization(String config, Boolean invariant, Boolean publish)
--- End of stack trace from previous location ---

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-107865-merge-50c72d5eddc049108b/NoWorkload-NoWebcil-ST-Wasm.Build.Tests/1/console.47c37d30.log?helixlogtype=result
@ilonatommy
ilonatommy
commented
Oct 2, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
1st and 2nd run with default chrome + higher timeout: success.

3rd: timeout on Linux, Windows passes.

4th: passes.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 2, 2024

Open

3 tasks
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 14, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing left review comments
@pavelsavarapavelsavarapavelsavara approved these changes
@marafmarafmaraf approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Build-monoNO-MERGEThe PR is not ready for merge yet (see discussion for detailed reasons)os-browserBrowser variant of arch-wasm

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@ilonatommy@lewing@pavelsavara@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[browser] Increase timeout and clean up after failed attempts of launching browser when testing - #107865
Closed
ilonatommy wants to merge 34 commits into
dotnet:mainfrom 
ilonatommy:fix-107771
Closed
[browser] Increase timeout and clean up after failed attempts of launching browser when testing#107865
ilonatommy wants to merge 34 commits into
dotnet:mainfrom 
ilonatommy:fix-107771
Conversation
@ilonatommy
@ilonatommyilonatommy
commented
Sep 16, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This is a playground for fixing #107771.

The issue is hit only on Windows, where we are running WBT sequentially.
Changes:
  • Upgrade Playwright to "1.47.0" (newest available)
  • After upgrading Playwright, it is creating node dir in linux-x64 dir, not in linux. Node requires elevated execution rights, so chmod +x path was changed accordingly.
  • Killing all chrome processes before we call the problematic method that launches the browser.
  • Making sure we clean up after each run by closing Browser and disposing of Playwright.
@ilonatommyilonatommy
added

arch-wasm
WebAssembly architecture
area-Build-mono

os-browser
Browser variant of arch-wasm
labels
Sep 16, 2024
@ilonatommyilonatommy
self-assigned this
Sep 16, 2024
pavelsavara
pavelsavara
reviewed
Sep 16, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs
Outdated

lewing
lewing
reviewed
Sep 16, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs
Outdated

@ilonatommy
ilonatommy
commented
Sep 16, 2024

Copy link


Copy Markdown

MemberAuthor
It does not help:
 Attempt 3 failed with TimeoutException: System.TimeoutException: Timeout 15000ms exceeded.
=========================== logs ===========================
<launching> C:\helix\work\correlation\chrome-win\chrome.exe --disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater --allow-pre-commit-input --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync --force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic --use-mock-keychain --no-service-autorun --export-tagged-pdf --headless --hide-scrollbars --mute-audio --blink-settings=primaryHoverType=2,availableHoverTypes=2,primaryPointerType=4,availablePointerTypes=4 --no-sandbox --explicitly-allowed-ports=49238 --ignore-certificate-errors --user-data-dir=C:\Users\ContainerAdministrator\AppData\Local\Temp\playwright_chromiumdev_profile-j7hftC --remote-debugging-pipe --no-startup-window
<launched> pid=9100
============================================================
at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](String guid, String method, Object args) in /_/src/Playwright/Transport/Connection.cs:line 164
at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal) in /_/src/Playwright/Transport/Connection.cs:line 475
at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options) in /_/src/Playwright/Core/BrowserType.cs:line 61
at Wasm.Build.Tests.BrowserRunner.SpawnBrowserAsync(String browserUrl, Boolean headless, Int32 timeout, Int32 maxRetries) in /_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs:line 120

log

This was referenced Sep 16, 2024

Closed


Closed

@lewing
lewing
commented
Sep 16, 2024

Copy link


Copy Markdown

Member
Can we check if there are other running chrome instances or something to help diagnose the issue?
@ilonatommy
ilonatommy
commented
Sep 17, 2024

Copy link


Copy Markdown

MemberAuthor
If we keep the last commit about killing all other chromes, running WBT locally can be a nuisance. If it works, we should check for running on CI and only then call TerminateExistingChromeInstances. I did not register local timeouts similar to these on CI, so it should be fine.
@ilonatommy
ilonatommy
commented
Sep 17, 2024

Copy link


Copy Markdown

MemberAuthor
It's not about chrome instances, Found 0 old Chrome processes. in log when it still timeouts.
@ilonatommy
ilonatommy
commented
Sep 18, 2024

Copy link


Copy Markdown

MemberAuthor
The chrome bump will be ready soon: #107504, maybe that might help?
@ilonatommy
ilonatommy
commented
Sep 20, 2024

Copy link


Copy Markdown

MemberAuthor
Failures are on Windows with Workloads-NoFingerprint-ST-Wasm.Build.Tests:
 Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations(forConsole: False, runOutsideProjectDirectory: True, extraProperties: "") [FAIL]
System.Exception : Timed out after 120s waiting for 'WASM EXIT' message
Stack Trace:
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(242,0): at Wasm.Build.Tests.BrowserRunner.WaitForExitMessageAsync(TimeSpan timeout)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(324,0): at Wasm.Build.Tests.WasmTemplateTests.BrowserRunTwiceWithAndThenWithoutBuildAsync(String config, String extraProperties, Boolean runOutsideProjectDirectory)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(325,0): at Wasm.Build.Tests.WasmTemplateTests.BrowserRunTwiceWithAndThenWithoutBuildAsync(String config, String extraProperties, Boolean runOutsideProjectDirectory)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(301,0): at Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations(Boolean forConsole, Boolean runOutsideProjectDirectory, String extraProperties)

@build-analysisbuild-analysisBot
mentioned this pull request
Sep 22, 2024

Closed


This was referenced Sep 30, 2024

Closed


Closed


This was referenced Sep 30, 2024

Closed


Open


Open


Closed


Closed

@ilonatommyilonatommy
mentioned this pull request
Oct 1, 2024

Closed

@ilonatommy
ilonatommy
commented
Oct 1, 2024

Copy link


Copy Markdown

MemberAuthor
The issue is still existing after the Playwright bump, see: https://helix.dot.net/api/2019-06-17/jobs/8d53b01d-113d-4e65-a893-6a5d825a52b6/workitems/Workloads-NoWebcil-ST-Wasm.Build.Tests.TestAppScenarios.LibraryInitializerTests/console.

I created an issue in Playwright repo: microsoft/playwright#32897, maybe we can get some suggestions about what could be going on.
@ilonatommyilonatommy
mentioned this pull request
Oct 1, 2024
 Merged

@ilonatommy
ilonatommy
marked this pull request as draft
October 1, 2024 13:20
@ilonatommyilonatommy
added
the 
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
Oct 1, 2024
@ilonatommy
ilonatommy
commented
Oct 2, 2024

Copy link


Copy Markdown

MemberAuthor
Using default chromium from Playwright is broken on Linux:
Microsoft.Playwright.PlaywrightException : Executable doesn't exist at /home/helixbot/.cache/ms-playwright/chromium-1134/chrome-linux/chrome
╔════════════════════════════════════════════════════════════╗
║ Looks like Playwright was just installed or updated. ║
║ Please run the following command to download new browsers: ║
║ ║
║ pwsh bin/Debug/netX/playwright.ps1 install ║
║ ║
║ <3 Playwright Team ║
╚════════════════════════════════════════════════════════════╝
Stack Trace:
/_/src/Playwright/Transport/Connection.cs(206,0): at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](ChannelOwner object, String method, Dictionary`2 dictionary, Boolean keepNulls)
/_/src/Playwright/Transport/Connection.cs(532,0): at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal)
/_/src/Playwright/Core/BrowserType.cs(56,0): at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options)
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(129,0): at Wasm.Build.Tests.BrowserRunner.SpawnBrowserAsync(String browserUrl, Boolean headless, Nullable`1 timeout, Int32 maxRetries, String language)
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(201,0): at Wasm.Build.Tests.BrowserRunner.RunAsync(ToolCommand cmd, String args, Boolean headless, String language, Action`2 onConsoleMessage, Action`1 onServerMessage, Action`1 onError, Func`2 modifyBrowserUrl)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWasmTestBase.cs(202,0): at Wasm.Build.Tests.BlazorWasmTestBase.BlazorRunTest(String runArgs, String workingDirectory, BlazorRunOptions runOptions)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWasmTestBase.cs(229,0): at Wasm.Build.Tests.BlazorWasmTestBase.BlazorRunTest(String runArgs, String workingDirectory, BlazorRunOptions runOptions)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/WorkloadRequiredTests.cs(119,0): at Wasm.Build.Tests.Blazor.WorkloadRequiredTests.WorkloadNotRequiredForInvariantGlobalization(String config, Boolean invariant, Boolean publish)
--- End of stack trace from previous location ---

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-107865-merge-50c72d5eddc049108b/NoWorkload-NoWebcil-ST-Wasm.Build.Tests/1/console.47c37d30.log?helixlogtype=result
@ilonatommy
ilonatommy
commented
Oct 2, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
1st and 2nd run with default chrome + higher timeout: success.

3rd: timeout on Linux, Windows passes.

4th: passes.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 2, 2024

Open

3 tasks
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 14, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing left review comments
@pavelsavarapavelsavarapavelsavara approved these changes
@marafmarafmaraf approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Build-monoNO-MERGEThe PR is not ready for merge yet (see discussion for detailed reasons)os-browserBrowser variant of arch-wasm

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@ilonatommy@lewing@pavelsavara@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[browser] Increase timeout and clean up after failed attempts of launching browser when testing - #107865
Closed
ilonatommy wants to merge 34 commits into
dotnet:mainfrom 
ilonatommy:fix-107771
Closed
[browser] Increase timeout and clean up after failed attempts of launching browser when testing#107865
ilonatommy wants to merge 34 commits into
dotnet:mainfrom 
ilonatommy:fix-107771
Conversation
@ilonatommy
@ilonatommyilonatommy
commented
Sep 16, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This is a playground for fixing #107771.

The issue is hit only on Windows, where we are running WBT sequentially.
Changes:
  • Upgrade Playwright to "1.47.0" (newest available)
  • After upgrading Playwright, it is creating node dir in linux-x64 dir, not in linux. Node requires elevated execution rights, so chmod +x path was changed accordingly.
  • Killing all chrome processes before we call the problematic method that launches the browser.
  • Making sure we clean up after each run by closing Browser and disposing of Playwright.
@ilonatommyilonatommy
added

arch-wasm
WebAssembly architecture
area-Build-mono

os-browser
Browser variant of arch-wasm
labels
Sep 16, 2024
@ilonatommyilonatommy
self-assigned this
Sep 16, 2024
pavelsavara
pavelsavara
reviewed
Sep 16, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs
Outdated

lewing
lewing
reviewed
Sep 16, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs
Outdated

@ilonatommy
ilonatommy
commented
Sep 16, 2024

Copy link


Copy Markdown

MemberAuthor
It does not help:
 Attempt 3 failed with TimeoutException: System.TimeoutException: Timeout 15000ms exceeded.
=========================== logs ===========================
<launching> C:\helix\work\correlation\chrome-win\chrome.exe --disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater --allow-pre-commit-input --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync --force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic --use-mock-keychain --no-service-autorun --export-tagged-pdf --headless --hide-scrollbars --mute-audio --blink-settings=primaryHoverType=2,availableHoverTypes=2,primaryPointerType=4,availablePointerTypes=4 --no-sandbox --explicitly-allowed-ports=49238 --ignore-certificate-errors --user-data-dir=C:\Users\ContainerAdministrator\AppData\Local\Temp\playwright_chromiumdev_profile-j7hftC --remote-debugging-pipe --no-startup-window
<launched> pid=9100
============================================================
at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](String guid, String method, Object args) in /_/src/Playwright/Transport/Connection.cs:line 164
at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal) in /_/src/Playwright/Transport/Connection.cs:line 475
at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options) in /_/src/Playwright/Core/BrowserType.cs:line 61
at Wasm.Build.Tests.BrowserRunner.SpawnBrowserAsync(String browserUrl, Boolean headless, Int32 timeout, Int32 maxRetries) in /_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs:line 120

log

This was referenced Sep 16, 2024

Closed


Closed

@lewing
lewing
commented
Sep 16, 2024

Copy link


Copy Markdown

Member
Can we check if there are other running chrome instances or something to help diagnose the issue?
@ilonatommy
ilonatommy
commented
Sep 17, 2024

Copy link


Copy Markdown

MemberAuthor
If we keep the last commit about killing all other chromes, running WBT locally can be a nuisance. If it works, we should check for running on CI and only then call TerminateExistingChromeInstances. I did not register local timeouts similar to these on CI, so it should be fine.
@ilonatommy
ilonatommy
commented
Sep 17, 2024

Copy link


Copy Markdown

MemberAuthor
It's not about chrome instances, Found 0 old Chrome processes. in log when it still timeouts.
@ilonatommy
ilonatommy
commented
Sep 18, 2024

Copy link


Copy Markdown

MemberAuthor
The chrome bump will be ready soon: #107504, maybe that might help?
@ilonatommy
ilonatommy
commented
Sep 20, 2024

Copy link


Copy Markdown

MemberAuthor
Failures are on Windows with Workloads-NoFingerprint-ST-Wasm.Build.Tests:
 Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations(forConsole: False, runOutsideProjectDirectory: True, extraProperties: "") [FAIL]
System.Exception : Timed out after 120s waiting for 'WASM EXIT' message
Stack Trace:
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(242,0): at Wasm.Build.Tests.BrowserRunner.WaitForExitMessageAsync(TimeSpan timeout)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(324,0): at Wasm.Build.Tests.WasmTemplateTests.BrowserRunTwiceWithAndThenWithoutBuildAsync(String config, String extraProperties, Boolean runOutsideProjectDirectory)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(325,0): at Wasm.Build.Tests.WasmTemplateTests.BrowserRunTwiceWithAndThenWithoutBuildAsync(String config, String extraProperties, Boolean runOutsideProjectDirectory)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(301,0): at Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations(Boolean forConsole, Boolean runOutsideProjectDirectory, String extraProperties)

@build-analysisbuild-analysisBot
mentioned this pull request
Sep 22, 2024

Closed


This was referenced Sep 30, 2024

Closed


Closed


This was referenced Sep 30, 2024

Closed


Open


Open


Closed


Closed

@ilonatommyilonatommy
mentioned this pull request
Oct 1, 2024

Closed

@ilonatommy
ilonatommy
commented
Oct 1, 2024

Copy link


Copy Markdown

MemberAuthor
The issue is still existing after the Playwright bump, see: https://helix.dot.net/api/2019-06-17/jobs/8d53b01d-113d-4e65-a893-6a5d825a52b6/workitems/Workloads-NoWebcil-ST-Wasm.Build.Tests.TestAppScenarios.LibraryInitializerTests/console.

I created an issue in Playwright repo: microsoft/playwright#32897, maybe we can get some suggestions about what could be going on.
@ilonatommyilonatommy
mentioned this pull request
Oct 1, 2024
 Merged

@ilonatommy
ilonatommy
marked this pull request as draft
October 1, 2024 13:20
@ilonatommyilonatommy
added
the 
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
Oct 1, 2024
@ilonatommy
ilonatommy
commented
Oct 2, 2024

Copy link


Copy Markdown

MemberAuthor
Using default chromium from Playwright is broken on Linux:
Microsoft.Playwright.PlaywrightException : Executable doesn't exist at /home/helixbot/.cache/ms-playwright/chromium-1134/chrome-linux/chrome
╔════════════════════════════════════════════════════════════╗
║ Looks like Playwright was just installed or updated. ║
║ Please run the following command to download new browsers: ║
║ ║
║ pwsh bin/Debug/netX/playwright.ps1 install ║
║ ║
║ <3 Playwright Team ║
╚════════════════════════════════════════════════════════════╝
Stack Trace:
/_/src/Playwright/Transport/Connection.cs(206,0): at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](ChannelOwner object, String method, Dictionary`2 dictionary, Boolean keepNulls)
/_/src/Playwright/Transport/Connection.cs(532,0): at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal)
/_/src/Playwright/Core/BrowserType.cs(56,0): at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options)
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(129,0): at Wasm.Build.Tests.BrowserRunner.SpawnBrowserAsync(String browserUrl, Boolean headless, Nullable`1 timeout, Int32 maxRetries, String language)
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(201,0): at Wasm.Build.Tests.BrowserRunner.RunAsync(ToolCommand cmd, String args, Boolean headless, String language, Action`2 onConsoleMessage, Action`1 onServerMessage, Action`1 onError, Func`2 modifyBrowserUrl)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWasmTestBase.cs(202,0): at Wasm.Build.Tests.BlazorWasmTestBase.BlazorRunTest(String runArgs, String workingDirectory, BlazorRunOptions runOptions)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWasmTestBase.cs(229,0): at Wasm.Build.Tests.BlazorWasmTestBase.BlazorRunTest(String runArgs, String workingDirectory, BlazorRunOptions runOptions)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/WorkloadRequiredTests.cs(119,0): at Wasm.Build.Tests.Blazor.WorkloadRequiredTests.WorkloadNotRequiredForInvariantGlobalization(String config, Boolean invariant, Boolean publish)
--- End of stack trace from previous location ---

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-107865-merge-50c72d5eddc049108b/NoWorkload-NoWebcil-ST-Wasm.Build.Tests/1/console.47c37d30.log?helixlogtype=result
@ilonatommy
ilonatommy
commented
Oct 2, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
1st and 2nd run with default chrome + higher timeout: success.

3rd: timeout on Linux, Windows passes.

4th: passes.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 2, 2024

Open

3 tasks
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 14, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing left review comments
@pavelsavarapavelsavarapavelsavara approved these changes
@marafmarafmaraf approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Build-monoNO-MERGEThe PR is not ready for merge yet (see discussion for detailed reasons)os-browserBrowser variant of arch-wasm

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@ilonatommy@lewing@pavelsavara@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[browser] Increase timeout and clean up after failed attempts of launching browser when testing - #107865
Closed
ilonatommy wants to merge 34 commits into
dotnet:mainfrom 
ilonatommy:fix-107771
Closed
[browser] Increase timeout and clean up after failed attempts of launching browser when testing#107865
ilonatommy wants to merge 34 commits into
dotnet:mainfrom 
ilonatommy:fix-107771
Conversation
@ilonatommy
@ilonatommyilonatommy
commented
Sep 16, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This is a playground for fixing #107771.

The issue is hit only on Windows, where we are running WBT sequentially.
Changes:
  • Upgrade Playwright to "1.47.0" (newest available)
  • After upgrading Playwright, it is creating node dir in linux-x64 dir, not in linux. Node requires elevated execution rights, so chmod +x path was changed accordingly.
  • Killing all chrome processes before we call the problematic method that launches the browser.
  • Making sure we clean up after each run by closing Browser and disposing of Playwright.
@ilonatommyilonatommy
added

arch-wasm
WebAssembly architecture
area-Build-mono

os-browser
Browser variant of arch-wasm
labels
Sep 16, 2024
@ilonatommyilonatommy
self-assigned this
Sep 16, 2024
pavelsavara
pavelsavara
reviewed
Sep 16, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs
Outdated

lewing
lewing
reviewed
Sep 16, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs
Outdated

@ilonatommy
ilonatommy
commented
Sep 16, 2024

Copy link


Copy Markdown

MemberAuthor
It does not help:
 Attempt 3 failed with TimeoutException: System.TimeoutException: Timeout 15000ms exceeded.
=========================== logs ===========================
<launching> C:\helix\work\correlation\chrome-win\chrome.exe --disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater --allow-pre-commit-input --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync --force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic --use-mock-keychain --no-service-autorun --export-tagged-pdf --headless --hide-scrollbars --mute-audio --blink-settings=primaryHoverType=2,availableHoverTypes=2,primaryPointerType=4,availablePointerTypes=4 --no-sandbox --explicitly-allowed-ports=49238 --ignore-certificate-errors --user-data-dir=C:\Users\ContainerAdministrator\AppData\Local\Temp\playwright_chromiumdev_profile-j7hftC --remote-debugging-pipe --no-startup-window
<launched> pid=9100
============================================================
at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](String guid, String method, Object args) in /_/src/Playwright/Transport/Connection.cs:line 164
at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal) in /_/src/Playwright/Transport/Connection.cs:line 475
at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options) in /_/src/Playwright/Core/BrowserType.cs:line 61
at Wasm.Build.Tests.BrowserRunner.SpawnBrowserAsync(String browserUrl, Boolean headless, Int32 timeout, Int32 maxRetries) in /_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs:line 120

log

This was referenced Sep 16, 2024

Closed


Closed

@lewing
lewing
commented
Sep 16, 2024

Copy link


Copy Markdown

Member
Can we check if there are other running chrome instances or something to help diagnose the issue?
@ilonatommy
ilonatommy
commented
Sep 17, 2024

Copy link


Copy Markdown

MemberAuthor
If we keep the last commit about killing all other chromes, running WBT locally can be a nuisance. If it works, we should check for running on CI and only then call TerminateExistingChromeInstances. I did not register local timeouts similar to these on CI, so it should be fine.
@ilonatommy
ilonatommy
commented
Sep 17, 2024

Copy link


Copy Markdown

MemberAuthor
It's not about chrome instances, Found 0 old Chrome processes. in log when it still timeouts.
@ilonatommy
ilonatommy
commented
Sep 18, 2024

Copy link


Copy Markdown

MemberAuthor
The chrome bump will be ready soon: #107504, maybe that might help?
@ilonatommy
ilonatommy
commented
Sep 20, 2024

Copy link


Copy Markdown

MemberAuthor
Failures are on Windows with Workloads-NoFingerprint-ST-Wasm.Build.Tests:
 Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations(forConsole: False, runOutsideProjectDirectory: True, extraProperties: "") [FAIL]
System.Exception : Timed out after 120s waiting for 'WASM EXIT' message
Stack Trace:
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(242,0): at Wasm.Build.Tests.BrowserRunner.WaitForExitMessageAsync(TimeSpan timeout)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(324,0): at Wasm.Build.Tests.WasmTemplateTests.BrowserRunTwiceWithAndThenWithoutBuildAsync(String config, String extraProperties, Boolean runOutsideProjectDirectory)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(325,0): at Wasm.Build.Tests.WasmTemplateTests.BrowserRunTwiceWithAndThenWithoutBuildAsync(String config, String extraProperties, Boolean runOutsideProjectDirectory)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(301,0): at Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations(Boolean forConsole, Boolean runOutsideProjectDirectory, String extraProperties)

@build-analysisbuild-analysisBot
mentioned this pull request
Sep 22, 2024

Closed


This was referenced Sep 30, 2024

Closed


Closed


This was referenced Sep 30, 2024

Closed


Open


Open


Closed


Closed

@ilonatommyilonatommy
mentioned this pull request
Oct 1, 2024

Closed

@ilonatommy
ilonatommy
commented
Oct 1, 2024

Copy link


Copy Markdown

MemberAuthor
The issue is still existing after the Playwright bump, see: https://helix.dot.net/api/2019-06-17/jobs/8d53b01d-113d-4e65-a893-6a5d825a52b6/workitems/Workloads-NoWebcil-ST-Wasm.Build.Tests.TestAppScenarios.LibraryInitializerTests/console.

I created an issue in Playwright repo: microsoft/playwright#32897, maybe we can get some suggestions about what could be going on.
@ilonatommyilonatommy
mentioned this pull request
Oct 1, 2024
 Merged

@ilonatommy
ilonatommy
marked this pull request as draft
October 1, 2024 13:20
@ilonatommyilonatommy
added
the 
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
Oct 1, 2024
@ilonatommy
ilonatommy
commented
Oct 2, 2024

Copy link


Copy Markdown

MemberAuthor
Using default chromium from Playwright is broken on Linux:
Microsoft.Playwright.PlaywrightException : Executable doesn't exist at /home/helixbot/.cache/ms-playwright/chromium-1134/chrome-linux/chrome
╔════════════════════════════════════════════════════════════╗
║ Looks like Playwright was just installed or updated. ║
║ Please run the following command to download new browsers: ║
║ ║
║ pwsh bin/Debug/netX/playwright.ps1 install ║
║ ║
║ <3 Playwright Team ║
╚════════════════════════════════════════════════════════════╝
Stack Trace:
/_/src/Playwright/Transport/Connection.cs(206,0): at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](ChannelOwner object, String method, Dictionary`2 dictionary, Boolean keepNulls)
/_/src/Playwright/Transport/Connection.cs(532,0): at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal)
/_/src/Playwright/Core/BrowserType.cs(56,0): at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options)
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(129,0): at Wasm.Build.Tests.BrowserRunner.SpawnBrowserAsync(String browserUrl, Boolean headless, Nullable`1 timeout, Int32 maxRetries, String language)
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(201,0): at Wasm.Build.Tests.BrowserRunner.RunAsync(ToolCommand cmd, String args, Boolean headless, String language, Action`2 onConsoleMessage, Action`1 onServerMessage, Action`1 onError, Func`2 modifyBrowserUrl)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWasmTestBase.cs(202,0): at Wasm.Build.Tests.BlazorWasmTestBase.BlazorRunTest(String runArgs, String workingDirectory, BlazorRunOptions runOptions)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWasmTestBase.cs(229,0): at Wasm.Build.Tests.BlazorWasmTestBase.BlazorRunTest(String runArgs, String workingDirectory, BlazorRunOptions runOptions)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/WorkloadRequiredTests.cs(119,0): at Wasm.Build.Tests.Blazor.WorkloadRequiredTests.WorkloadNotRequiredForInvariantGlobalization(String config, Boolean invariant, Boolean publish)
--- End of stack trace from previous location ---

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-107865-merge-50c72d5eddc049108b/NoWorkload-NoWebcil-ST-Wasm.Build.Tests/1/console.47c37d30.log?helixlogtype=result
@ilonatommy
ilonatommy
commented
Oct 2, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
1st and 2nd run with default chrome + higher timeout: success.

3rd: timeout on Linux, Windows passes.

4th: passes.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 2, 2024

Open

3 tasks
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 14, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing left review comments
@pavelsavarapavelsavarapavelsavara approved these changes
@marafmarafmaraf approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Build-monoNO-MERGEThe PR is not ready for merge yet (see discussion for detailed reasons)os-browserBrowser variant of arch-wasm

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@ilonatommy@lewing@pavelsavara@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[browser] Increase timeout and clean up after failed attempts of launching browser when testing - #107865
Closed
ilonatommy wants to merge 34 commits into
dotnet:mainfrom 
ilonatommy:fix-107771
Closed
[browser] Increase timeout and clean up after failed attempts of launching browser when testing#107865
ilonatommy wants to merge 34 commits into
dotnet:mainfrom 
ilonatommy:fix-107771
Conversation
@ilonatommy
@ilonatommyilonatommy
commented
Sep 16, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This is a playground for fixing #107771.

The issue is hit only on Windows, where we are running WBT sequentially.
Changes:
  • Upgrade Playwright to "1.47.0" (newest available)
  • After upgrading Playwright, it is creating node dir in linux-x64 dir, not in linux. Node requires elevated execution rights, so chmod +x path was changed accordingly.
  • Killing all chrome processes before we call the problematic method that launches the browser.
  • Making sure we clean up after each run by closing Browser and disposing of Playwright.
@ilonatommyilonatommy
added

arch-wasm
WebAssembly architecture
area-Build-mono

os-browser
Browser variant of arch-wasm
labels
Sep 16, 2024
@ilonatommyilonatommy
self-assigned this
Sep 16, 2024
pavelsavara
pavelsavara
reviewed
Sep 16, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs
Outdated

lewing
lewing
reviewed
Sep 16, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs
Outdated

@ilonatommy
ilonatommy
commented
Sep 16, 2024

Copy link


Copy Markdown

MemberAuthor
It does not help:
 Attempt 3 failed with TimeoutException: System.TimeoutException: Timeout 15000ms exceeded.
=========================== logs ===========================
<launching> C:\helix\work\correlation\chrome-win\chrome.exe --disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater --allow-pre-commit-input --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync --force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic --use-mock-keychain --no-service-autorun --export-tagged-pdf --headless --hide-scrollbars --mute-audio --blink-settings=primaryHoverType=2,availableHoverTypes=2,primaryPointerType=4,availablePointerTypes=4 --no-sandbox --explicitly-allowed-ports=49238 --ignore-certificate-errors --user-data-dir=C:\Users\ContainerAdministrator\AppData\Local\Temp\playwright_chromiumdev_profile-j7hftC --remote-debugging-pipe --no-startup-window
<launched> pid=9100
============================================================
at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](String guid, String method, Object args) in /_/src/Playwright/Transport/Connection.cs:line 164
at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal) in /_/src/Playwright/Transport/Connection.cs:line 475
at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options) in /_/src/Playwright/Core/BrowserType.cs:line 61
at Wasm.Build.Tests.BrowserRunner.SpawnBrowserAsync(String browserUrl, Boolean headless, Int32 timeout, Int32 maxRetries) in /_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs:line 120

log

This was referenced Sep 16, 2024

Closed


Closed

@lewing
lewing
commented
Sep 16, 2024

Copy link


Copy Markdown

Member
Can we check if there are other running chrome instances or something to help diagnose the issue?
@ilonatommy
ilonatommy
commented
Sep 17, 2024

Copy link


Copy Markdown

MemberAuthor
If we keep the last commit about killing all other chromes, running WBT locally can be a nuisance. If it works, we should check for running on CI and only then call TerminateExistingChromeInstances. I did not register local timeouts similar to these on CI, so it should be fine.
@ilonatommy
ilonatommy
commented
Sep 17, 2024

Copy link


Copy Markdown

MemberAuthor
It's not about chrome instances, Found 0 old Chrome processes. in log when it still timeouts.
@ilonatommy
ilonatommy
commented
Sep 18, 2024

Copy link


Copy Markdown

MemberAuthor
The chrome bump will be ready soon: #107504, maybe that might help?
@ilonatommy
ilonatommy
commented
Sep 20, 2024

Copy link


Copy Markdown

MemberAuthor
Failures are on Windows with Workloads-NoFingerprint-ST-Wasm.Build.Tests:
 Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations(forConsole: False, runOutsideProjectDirectory: True, extraProperties: "") [FAIL]
System.Exception : Timed out after 120s waiting for 'WASM EXIT' message
Stack Trace:
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(242,0): at Wasm.Build.Tests.BrowserRunner.WaitForExitMessageAsync(TimeSpan timeout)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(324,0): at Wasm.Build.Tests.WasmTemplateTests.BrowserRunTwiceWithAndThenWithoutBuildAsync(String config, String extraProperties, Boolean runOutsideProjectDirectory)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(325,0): at Wasm.Build.Tests.WasmTemplateTests.BrowserRunTwiceWithAndThenWithoutBuildAsync(String config, String extraProperties, Boolean runOutsideProjectDirectory)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(301,0): at Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations(Boolean forConsole, Boolean runOutsideProjectDirectory, String extraProperties)

@build-analysisbuild-analysisBot
mentioned this pull request
Sep 22, 2024

Closed


This was referenced Sep 30, 2024

Closed


Closed


This was referenced Sep 30, 2024

Closed


Open


Open


Closed


Closed

@ilonatommyilonatommy
mentioned this pull request
Oct 1, 2024

Closed

@ilonatommy
ilonatommy
commented
Oct 1, 2024

Copy link


Copy Markdown

MemberAuthor
The issue is still existing after the Playwright bump, see: https://helix.dot.net/api/2019-06-17/jobs/8d53b01d-113d-4e65-a893-6a5d825a52b6/workitems/Workloads-NoWebcil-ST-Wasm.Build.Tests.TestAppScenarios.LibraryInitializerTests/console.

I created an issue in Playwright repo: microsoft/playwright#32897, maybe we can get some suggestions about what could be going on.
@ilonatommyilonatommy
mentioned this pull request
Oct 1, 2024
 Merged

@ilonatommy
ilonatommy
marked this pull request as draft
October 1, 2024 13:20
@ilonatommyilonatommy
added
the 
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
Oct 1, 2024
@ilonatommy
ilonatommy
commented
Oct 2, 2024

Copy link


Copy Markdown

MemberAuthor
Using default chromium from Playwright is broken on Linux:
Microsoft.Playwright.PlaywrightException : Executable doesn't exist at /home/helixbot/.cache/ms-playwright/chromium-1134/chrome-linux/chrome
╔════════════════════════════════════════════════════════════╗
║ Looks like Playwright was just installed or updated. ║
║ Please run the following command to download new browsers: ║
║ ║
║ pwsh bin/Debug/netX/playwright.ps1 install ║
║ ║
║ <3 Playwright Team ║
╚════════════════════════════════════════════════════════════╝
Stack Trace:
/_/src/Playwright/Transport/Connection.cs(206,0): at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](ChannelOwner object, String method, Dictionary`2 dictionary, Boolean keepNulls)
/_/src/Playwright/Transport/Connection.cs(532,0): at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal)
/_/src/Playwright/Core/BrowserType.cs(56,0): at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options)
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(129,0): at Wasm.Build.Tests.BrowserRunner.SpawnBrowserAsync(String browserUrl, Boolean headless, Nullable`1 timeout, Int32 maxRetries, String language)
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(201,0): at Wasm.Build.Tests.BrowserRunner.RunAsync(ToolCommand cmd, String args, Boolean headless, String language, Action`2 onConsoleMessage, Action`1 onServerMessage, Action`1 onError, Func`2 modifyBrowserUrl)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWasmTestBase.cs(202,0): at Wasm.Build.Tests.BlazorWasmTestBase.BlazorRunTest(String runArgs, String workingDirectory, BlazorRunOptions runOptions)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWasmTestBase.cs(229,0): at Wasm.Build.Tests.BlazorWasmTestBase.BlazorRunTest(String runArgs, String workingDirectory, BlazorRunOptions runOptions)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/WorkloadRequiredTests.cs(119,0): at Wasm.Build.Tests.Blazor.WorkloadRequiredTests.WorkloadNotRequiredForInvariantGlobalization(String config, Boolean invariant, Boolean publish)
--- End of stack trace from previous location ---

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-107865-merge-50c72d5eddc049108b/NoWorkload-NoWebcil-ST-Wasm.Build.Tests/1/console.47c37d30.log?helixlogtype=result
@ilonatommy
ilonatommy
commented
Oct 2, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
1st and 2nd run with default chrome + higher timeout: success.

3rd: timeout on Linux, Windows passes.

4th: passes.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 2, 2024

Open

3 tasks
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 14, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing left review comments
@pavelsavarapavelsavarapavelsavara approved these changes
@marafmarafmaraf approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Build-monoNO-MERGEThe PR is not ready for merge yet (see discussion for detailed reasons)os-browserBrowser variant of arch-wasm

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@ilonatommy@lewing@pavelsavara@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[browser] Increase timeout and clean up after failed attempts of launching browser when testing - #107865
Closed
ilonatommy wants to merge 34 commits into
dotnet:mainfrom 
ilonatommy:fix-107771
Closed
[browser] Increase timeout and clean up after failed attempts of launching browser when testing#107865
ilonatommy wants to merge 34 commits into
dotnet:mainfrom 
ilonatommy:fix-107771
Conversation
@ilonatommy
@ilonatommyilonatommy
commented
Sep 16, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This is a playground for fixing #107771.

The issue is hit only on Windows, where we are running WBT sequentially.
Changes:
  • Upgrade Playwright to "1.47.0" (newest available)
  • After upgrading Playwright, it is creating node dir in linux-x64 dir, not in linux. Node requires elevated execution rights, so chmod +x path was changed accordingly.
  • Killing all chrome processes before we call the problematic method that launches the browser.
  • Making sure we clean up after each run by closing Browser and disposing of Playwright.
@ilonatommyilonatommy
added

arch-wasm
WebAssembly architecture
area-Build-mono

os-browser
Browser variant of arch-wasm
labels
Sep 16, 2024
@ilonatommyilonatommy
self-assigned this
Sep 16, 2024
pavelsavara
pavelsavara
reviewed
Sep 16, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs
Outdated

lewing
lewing
reviewed
Sep 16, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs
Outdated

@ilonatommy
ilonatommy
commented
Sep 16, 2024

Copy link


Copy Markdown

MemberAuthor
It does not help:
 Attempt 3 failed with TimeoutException: System.TimeoutException: Timeout 15000ms exceeded.
=========================== logs ===========================
<launching> C:\helix\work\correlation\chrome-win\chrome.exe --disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater --allow-pre-commit-input --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync --force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic --use-mock-keychain --no-service-autorun --export-tagged-pdf --headless --hide-scrollbars --mute-audio --blink-settings=primaryHoverType=2,availableHoverTypes=2,primaryPointerType=4,availablePointerTypes=4 --no-sandbox --explicitly-allowed-ports=49238 --ignore-certificate-errors --user-data-dir=C:\Users\ContainerAdministrator\AppData\Local\Temp\playwright_chromiumdev_profile-j7hftC --remote-debugging-pipe --no-startup-window
<launched> pid=9100
============================================================
at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](String guid, String method, Object args) in /_/src/Playwright/Transport/Connection.cs:line 164
at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal) in /_/src/Playwright/Transport/Connection.cs:line 475
at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options) in /_/src/Playwright/Core/BrowserType.cs:line 61
at Wasm.Build.Tests.BrowserRunner.SpawnBrowserAsync(String browserUrl, Boolean headless, Int32 timeout, Int32 maxRetries) in /_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs:line 120

log

This was referenced Sep 16, 2024

Closed


Closed

@lewing
lewing
commented
Sep 16, 2024

Copy link


Copy Markdown

Member
Can we check if there are other running chrome instances or something to help diagnose the issue?
@ilonatommy
ilonatommy
commented
Sep 17, 2024

Copy link


Copy Markdown

MemberAuthor
If we keep the last commit about killing all other chromes, running WBT locally can be a nuisance. If it works, we should check for running on CI and only then call TerminateExistingChromeInstances. I did not register local timeouts similar to these on CI, so it should be fine.
@ilonatommy
ilonatommy
commented
Sep 17, 2024

Copy link


Copy Markdown

MemberAuthor
It's not about chrome instances, Found 0 old Chrome processes. in log when it still timeouts.
@ilonatommy
ilonatommy
commented
Sep 18, 2024

Copy link


Copy Markdown

MemberAuthor
The chrome bump will be ready soon: #107504, maybe that might help?
@ilonatommy
ilonatommy
commented
Sep 20, 2024

Copy link


Copy Markdown

MemberAuthor
Failures are on Windows with Workloads-NoFingerprint-ST-Wasm.Build.Tests:
 Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations(forConsole: False, runOutsideProjectDirectory: True, extraProperties: "") [FAIL]
System.Exception : Timed out after 120s waiting for 'WASM EXIT' message
Stack Trace:
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(242,0): at Wasm.Build.Tests.BrowserRunner.WaitForExitMessageAsync(TimeSpan timeout)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(324,0): at Wasm.Build.Tests.WasmTemplateTests.BrowserRunTwiceWithAndThenWithoutBuildAsync(String config, String extraProperties, Boolean runOutsideProjectDirectory)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(325,0): at Wasm.Build.Tests.WasmTemplateTests.BrowserRunTwiceWithAndThenWithoutBuildAsync(String config, String extraProperties, Boolean runOutsideProjectDirectory)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(301,0): at Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations(Boolean forConsole, Boolean runOutsideProjectDirectory, String extraProperties)

@build-analysisbuild-analysisBot
mentioned this pull request
Sep 22, 2024

Closed


This was referenced Sep 30, 2024

Closed


Closed


This was referenced Sep 30, 2024

Closed


Open


Open


Closed


Closed

@ilonatommyilonatommy
mentioned this pull request
Oct 1, 2024

Closed

@ilonatommy
ilonatommy
commented
Oct 1, 2024

Copy link


Copy Markdown

MemberAuthor
The issue is still existing after the Playwright bump, see: https://helix.dot.net/api/2019-06-17/jobs/8d53b01d-113d-4e65-a893-6a5d825a52b6/workitems/Workloads-NoWebcil-ST-Wasm.Build.Tests.TestAppScenarios.LibraryInitializerTests/console.

I created an issue in Playwright repo: microsoft/playwright#32897, maybe we can get some suggestions about what could be going on.
@ilonatommyilonatommy
mentioned this pull request
Oct 1, 2024
 Merged

@ilonatommy
ilonatommy
marked this pull request as draft
October 1, 2024 13:20
@ilonatommyilonatommy
added
the 
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
Oct 1, 2024
@ilonatommy
ilonatommy
commented
Oct 2, 2024

Copy link


Copy Markdown

MemberAuthor
Using default chromium from Playwright is broken on Linux:
Microsoft.Playwright.PlaywrightException : Executable doesn't exist at /home/helixbot/.cache/ms-playwright/chromium-1134/chrome-linux/chrome
╔════════════════════════════════════════════════════════════╗
║ Looks like Playwright was just installed or updated. ║
║ Please run the following command to download new browsers: ║
║ ║
║ pwsh bin/Debug/netX/playwright.ps1 install ║
║ ║
║ <3 Playwright Team ║
╚════════════════════════════════════════════════════════════╝
Stack Trace:
/_/src/Playwright/Transport/Connection.cs(206,0): at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](ChannelOwner object, String method, Dictionary`2 dictionary, Boolean keepNulls)
/_/src/Playwright/Transport/Connection.cs(532,0): at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal)
/_/src/Playwright/Core/BrowserType.cs(56,0): at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options)
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(129,0): at Wasm.Build.Tests.BrowserRunner.SpawnBrowserAsync(String browserUrl, Boolean headless, Nullable`1 timeout, Int32 maxRetries, String language)
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(201,0): at Wasm.Build.Tests.BrowserRunner.RunAsync(ToolCommand cmd, String args, Boolean headless, String language, Action`2 onConsoleMessage, Action`1 onServerMessage, Action`1 onError, Func`2 modifyBrowserUrl)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWasmTestBase.cs(202,0): at Wasm.Build.Tests.BlazorWasmTestBase.BlazorRunTest(String runArgs, String workingDirectory, BlazorRunOptions runOptions)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWasmTestBase.cs(229,0): at Wasm.Build.Tests.BlazorWasmTestBase.BlazorRunTest(String runArgs, String workingDirectory, BlazorRunOptions runOptions)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/WorkloadRequiredTests.cs(119,0): at Wasm.Build.Tests.Blazor.WorkloadRequiredTests.WorkloadNotRequiredForInvariantGlobalization(String config, Boolean invariant, Boolean publish)
--- End of stack trace from previous location ---

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-107865-merge-50c72d5eddc049108b/NoWorkload-NoWebcil-ST-Wasm.Build.Tests/1/console.47c37d30.log?helixlogtype=result
@ilonatommy
ilonatommy
commented
Oct 2, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
1st and 2nd run with default chrome + higher timeout: success.

3rd: timeout on Linux, Windows passes.

4th: passes.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 2, 2024

Open

3 tasks
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 14, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing left review comments
@pavelsavarapavelsavarapavelsavara approved these changes
@marafmarafmaraf approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Build-monoNO-MERGEThe PR is not ready for merge yet (see discussion for detailed reasons)os-browserBrowser variant of arch-wasm

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@ilonatommy@lewing@pavelsavara@maraf

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[browser] Increase timeout and clean up after failed attempts of launching browser when testing - #107865
Closed
ilonatommy wants to merge 34 commits into
dotnet:mainfrom 
ilonatommy:fix-107771
Closed
[browser] Increase timeout and clean up after failed attempts of launching browser when testing#107865
ilonatommy wants to merge 34 commits into
dotnet:mainfrom 
ilonatommy:fix-107771
Conversation
@ilonatommy
@ilonatommyilonatommy
commented
Sep 16, 2024•

edited

Loading

Copy link


Copy Markdown

Member
This is a playground for fixing #107771.

The issue is hit only on Windows, where we are running WBT sequentially.
Changes:
  • Upgrade Playwright to "1.47.0" (newest available)
  • After upgrading Playwright, it is creating node dir in linux-x64 dir, not in linux. Node requires elevated execution rights, so chmod +x path was changed accordingly.
  • Killing all chrome processes before we call the problematic method that launches the browser.
  • Making sure we clean up after each run by closing Browser and disposing of Playwright.
@ilonatommyilonatommy
added

arch-wasm
WebAssembly architecture
area-Build-mono

os-browser
Browser variant of arch-wasm
labels
Sep 16, 2024
@ilonatommyilonatommy
self-assigned this
Sep 16, 2024
pavelsavara
pavelsavara
reviewed
Sep 16, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs
Outdated

lewing
lewing
reviewed
Sep 16, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs
Outdated

@ilonatommy
ilonatommy
commented
Sep 16, 2024

Copy link


Copy Markdown

MemberAuthor
It does not help:
 Attempt 3 failed with TimeoutException: System.TimeoutException: Timeout 15000ms exceeded.
=========================== logs ===========================
<launching> C:\helix\work\correlation\chrome-win\chrome.exe --disable-background-networking --enable-features=NetworkService,NetworkServiceInProcess --disable-background-timer-throttling --disable-backgrounding-occluded-windows --disable-breakpad --disable-client-side-phishing-detection --disable-component-extensions-with-background-pages --disable-default-apps --disable-dev-shm-usage --disable-extensions --disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater --allow-pre-commit-input --disable-hang-monitor --disable-ipc-flooding-protection --disable-popup-blocking --disable-prompt-on-repost --disable-renderer-backgrounding --disable-sync --force-color-profile=srgb --metrics-recording-only --no-first-run --enable-automation --password-store=basic --use-mock-keychain --no-service-autorun --export-tagged-pdf --headless --hide-scrollbars --mute-audio --blink-settings=primaryHoverType=2,availableHoverTypes=2,primaryPointerType=4,availablePointerTypes=4 --no-sandbox --explicitly-allowed-ports=49238 --ignore-certificate-errors --user-data-dir=C:\Users\ContainerAdministrator\AppData\Local\Temp\playwright_chromiumdev_profile-j7hftC --remote-debugging-pipe --no-startup-window
<launched> pid=9100
============================================================
at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](String guid, String method, Object args) in /_/src/Playwright/Transport/Connection.cs:line 164
at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal) in /_/src/Playwright/Transport/Connection.cs:line 475
at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options) in /_/src/Playwright/Core/BrowserType.cs:line 61
at Wasm.Build.Tests.BrowserRunner.SpawnBrowserAsync(String browserUrl, Boolean headless, Int32 timeout, Int32 maxRetries) in /_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs:line 120

log

This was referenced Sep 16, 2024

Closed


Closed

@lewing
lewing
commented
Sep 16, 2024

Copy link


Copy Markdown

Member
Can we check if there are other running chrome instances or something to help diagnose the issue?
@ilonatommy
ilonatommy
commented
Sep 17, 2024

Copy link


Copy Markdown

MemberAuthor
If we keep the last commit about killing all other chromes, running WBT locally can be a nuisance. If it works, we should check for running on CI and only then call TerminateExistingChromeInstances. I did not register local timeouts similar to these on CI, so it should be fine.
@ilonatommy
ilonatommy
commented
Sep 17, 2024

Copy link


Copy Markdown

MemberAuthor
It's not about chrome instances, Found 0 old Chrome processes. in log when it still timeouts.
@ilonatommy
ilonatommy
commented
Sep 18, 2024

Copy link


Copy Markdown

MemberAuthor
The chrome bump will be ready soon: #107504, maybe that might help?
@ilonatommy
ilonatommy
commented
Sep 20, 2024

Copy link


Copy Markdown

MemberAuthor
Failures are on Windows with Workloads-NoFingerprint-ST-Wasm.Build.Tests:
 Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations(forConsole: False, runOutsideProjectDirectory: True, extraProperties: "") [FAIL]
System.Exception : Timed out after 120s waiting for 'WASM EXIT' message
Stack Trace:
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(242,0): at Wasm.Build.Tests.BrowserRunner.WaitForExitMessageAsync(TimeSpan timeout)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(324,0): at Wasm.Build.Tests.WasmTemplateTests.BrowserRunTwiceWithAndThenWithoutBuildAsync(String config, String extraProperties, Boolean runOutsideProjectDirectory)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(325,0): at Wasm.Build.Tests.WasmTemplateTests.BrowserRunTwiceWithAndThenWithoutBuildAsync(String config, String extraProperties, Boolean runOutsideProjectDirectory)
/_/src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs(301,0): at Wasm.Build.Tests.WasmTemplateTests.RunWithDifferentAppBundleLocations(Boolean forConsole, Boolean runOutsideProjectDirectory, String extraProperties)

@build-analysisbuild-analysisBot
mentioned this pull request
Sep 22, 2024

Closed


This was referenced Sep 30, 2024

Closed


Closed


This was referenced Sep 30, 2024

Closed


Open


Open


Closed


Closed

@ilonatommyilonatommy
mentioned this pull request
Oct 1, 2024

Closed

@ilonatommy
ilonatommy
commented
Oct 1, 2024

Copy link


Copy Markdown

MemberAuthor
The issue is still existing after the Playwright bump, see: https://helix.dot.net/api/2019-06-17/jobs/8d53b01d-113d-4e65-a893-6a5d825a52b6/workitems/Workloads-NoWebcil-ST-Wasm.Build.Tests.TestAppScenarios.LibraryInitializerTests/console.

I created an issue in Playwright repo: microsoft/playwright#32897, maybe we can get some suggestions about what could be going on.
@ilonatommyilonatommy
mentioned this pull request
Oct 1, 2024
 Merged

@ilonatommy
ilonatommy
marked this pull request as draft
October 1, 2024 13:20
@ilonatommyilonatommy
added
the 
NO-MERGE
The PR is not ready for merge yet (see discussion for detailed reasons)
label
Oct 1, 2024
@ilonatommy
ilonatommy
commented
Oct 2, 2024

Copy link


Copy Markdown

MemberAuthor
Using default chromium from Playwright is broken on Linux:
Microsoft.Playwright.PlaywrightException : Executable doesn't exist at /home/helixbot/.cache/ms-playwright/chromium-1134/chrome-linux/chrome
╔════════════════════════════════════════════════════════════╗
║ Looks like Playwright was just installed or updated. ║
║ Please run the following command to download new browsers: ║
║ ║
║ pwsh bin/Debug/netX/playwright.ps1 install ║
║ ║
║ <3 Playwright Team ║
╚════════════════════════════════════════════════════════════╝
Stack Trace:
/_/src/Playwright/Transport/Connection.cs(206,0): at Microsoft.Playwright.Transport.Connection.InnerSendMessageToServerAsync[T](ChannelOwner object, String method, Dictionary`2 dictionary, Boolean keepNulls)
/_/src/Playwright/Transport/Connection.cs(532,0): at Microsoft.Playwright.Transport.Connection.WrapApiCallAsync[T](Func`1 action, Boolean isInternal)
/_/src/Playwright/Core/BrowserType.cs(56,0): at Microsoft.Playwright.Core.BrowserType.LaunchAsync(BrowserTypeLaunchOptions options)
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(129,0): at Wasm.Build.Tests.BrowserRunner.SpawnBrowserAsync(String browserUrl, Boolean headless, Nullable`1 timeout, Int32 maxRetries, String language)
/_/src/mono/wasm/Wasm.Build.Tests/BrowserRunner.cs(201,0): at Wasm.Build.Tests.BrowserRunner.RunAsync(ToolCommand cmd, String args, Boolean headless, String language, Action`2 onConsoleMessage, Action`1 onServerMessage, Action`1 onError, Func`2 modifyBrowserUrl)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWasmTestBase.cs(202,0): at Wasm.Build.Tests.BlazorWasmTestBase.BlazorRunTest(String runArgs, String workingDirectory, BlazorRunOptions runOptions)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/BlazorWasmTestBase.cs(229,0): at Wasm.Build.Tests.BlazorWasmTestBase.BlazorRunTest(String runArgs, String workingDirectory, BlazorRunOptions runOptions)
/_/src/mono/wasm/Wasm.Build.Tests/Blazor/WorkloadRequiredTests.cs(119,0): at Wasm.Build.Tests.Blazor.WorkloadRequiredTests.WorkloadNotRequiredForInvariantGlobalization(String config, Boolean invariant, Boolean publish)
--- End of stack trace from previous location ---

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-pull-107865-merge-50c72d5eddc049108b/NoWorkload-NoWebcil-ST-Wasm.Build.Tests/1/console.47c37d30.log?helixlogtype=result
@ilonatommy
ilonatommy
commented
Oct 2, 2024•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
1st and 2nd run with default chrome + higher timeout: success.

3rd: timeout on Linux, Windows passes.

4th: passes.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 2, 2024

Open

3 tasks
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 14, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@lewinglewinglewing left review comments
@pavelsavarapavelsavarapavelsavara approved these changes
@marafmarafmaraf approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplinger
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Build-monoNO-MERGEThe PR is not ready for merge yet (see discussion for detailed reasons)os-browserBrowser variant of arch-wasm

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@ilonatommy@lewing@pavelsavara@maraf