[NativeAOT] Add sampling profiler by filipnavara · Pull Request #108083 · dotnet/runtime

filipnavara · 2024-09-20T21:11:06Z

Presumably this is pretty useless since we don't do the rundown to get readable method names... but since I already have it laying around, anyone can think of a use for this?

dotnet-policy-service · 2024-09-20T21:11:34Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

MichalStrehovsky · 2024-09-30T07:13:46Z

@LakshanF do you think we'd be able to implement the rest?

If there is a rundown for this, we do have names of methods available in stack trace metadata. If the rundown can run managed code, we could get it there. Maybe. Depending on what actually involves the rundown.

filipnavara · 2024-09-30T07:22:28Z

I only tried to run it with dotnet-trace and conversion to Speedscope format, which was quite useless, since you could see the stack traces but instead of method names there was just "?!?". I wonder if PerfView could perhaps show the addresses or correlate that to image base addresses. That would be already good enough for tools that can perform native symbolication (eg. Sentry).

Stack trace metadata sound like an interesting thing to try...

LakshanF · 2024-10-01T17:41:48Z

There is a work item in the diagnostic repo to lookup type information for native AOT GCDump, which could be expanded to include method information as well.

dotnet-policy-service · 2024-10-31T18:57:09Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

MichalStrehovsky · 2025-06-04T05:29:12Z

This is useful on its own - without this, dotnet-gcdump will just hang at "Flushing the type table".

MichalStrehovsky

Thank you!

Copilot

Pull Request Overview

This PR introduces a basic sampling profiler for NativeAOT by adding helper methods and integrating stack walking logic.

Added a new GetTransitionFrameForSampling method in thread.h
Extended the sampling event capture logic in ep-rt-aot.cpp
Introduced a GetControlPC method in StackFrameIterator.h

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/coreclr/nativeaot/Runtime/thread.h	Added a helper method to support sampling profiler functionality
src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp	Integrated sampling profiler logic to capture stack frames and emit events
src/coreclr/nativeaot/Runtime/StackFrameIterator.h	Exposed the control PC via a new method for use by the profiler

Comments suppressed due to low confidence (3)

src/coreclr/nativeaot/Runtime/thread.h:323

Consider adding a brief comment to clarify the purpose and usage of GetTransitionFrameForSampling for future maintainability.

PInvokeTransitionFrame* GetTransitionFrameForSampling() { return GetTransitionFrame(); }

src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp:113

[nitpick] Clarify or document in a tracking issue whether the differentiation between managed and external code will be addressed later to improve future code maintainability.

 // TODO: We can actually detect whether we are in managed or external code but does it matter?!

src/coreclr/nativeaot/Runtime/StackFrameIterator.h:58

Consider adding a comment to describe the role of GetControlPC in the sampling process to aid future maintainers.

PTR_VOID GetControlPC() { return m_ControlPC; }

MichalStrehovsky · 2025-06-04T11:10:11Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-06-04T11:10:28Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2025-06-04T21:00:14Z

/ba-g the arm32 build break was fixed and the rest are known

filipnavara · 2024-09-20T21:11:06Z

Presumably this is pretty useless since we don't do the rundown to get readable method names... but since I already have it laying around, anyone can think of a use for this?

dotnet-policy-service · 2024-09-20T21:11:34Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

MichalStrehovsky · 2024-09-30T07:13:46Z

@LakshanF do you think we'd be able to implement the rest?

If there is a rundown for this, we do have names of methods available in stack trace metadata. If the rundown can run managed code, we could get it there. Maybe. Depending on what actually involves the rundown.

filipnavara · 2024-09-30T07:22:28Z

I only tried to run it with dotnet-trace and conversion to Speedscope format, which was quite useless, since you could see the stack traces but instead of method names there was just "?!?". I wonder if PerfView could perhaps show the addresses or correlate that to image base addresses. That would be already good enough for tools that can perform native symbolication (eg. Sentry).

Stack trace metadata sound like an interesting thing to try...

LakshanF · 2024-10-01T17:41:48Z

There is a work item in the diagnostic repo to lookup type information for native AOT GCDump, which could be expanded to include method information as well.

dotnet-policy-service · 2024-10-31T18:57:09Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

MichalStrehovsky · 2025-06-04T05:29:12Z

This is useful on its own - without this, dotnet-gcdump will just hang at "Flushing the type table".

MichalStrehovsky

Thank you!

Copilot

Pull Request Overview

This PR introduces a basic sampling profiler for NativeAOT by adding helper methods and integrating stack walking logic.

Added a new GetTransitionFrameForSampling method in thread.h
Extended the sampling event capture logic in ep-rt-aot.cpp
Introduced a GetControlPC method in StackFrameIterator.h

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/coreclr/nativeaot/Runtime/thread.h	Added a helper method to support sampling profiler functionality
src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp	Integrated sampling profiler logic to capture stack frames and emit events
src/coreclr/nativeaot/Runtime/StackFrameIterator.h	Exposed the control PC via a new method for use by the profiler

Comments suppressed due to low confidence (3)

src/coreclr/nativeaot/Runtime/thread.h:323

Consider adding a brief comment to clarify the purpose and usage of GetTransitionFrameForSampling for future maintainability.

PInvokeTransitionFrame* GetTransitionFrameForSampling() { return GetTransitionFrame(); }

src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp:113

[nitpick] Clarify or document in a tracking issue whether the differentiation between managed and external code will be addressed later to improve future code maintainability.

 // TODO: We can actually detect whether we are in managed or external code but does it matter?!

src/coreclr/nativeaot/Runtime/StackFrameIterator.h:58

Consider adding a comment to describe the role of GetControlPC in the sampling process to aid future maintainers.

PTR_VOID GetControlPC() { return m_ControlPC; }

MichalStrehovsky · 2025-06-04T11:10:11Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-06-04T11:10:28Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2025-06-04T21:00:14Z

/ba-g the arm32 build break was fixed and the rest are known

filipnavara · 2024-09-20T21:11:06Z

Presumably this is pretty useless since we don't do the rundown to get readable method names... but since I already have it laying around, anyone can think of a use for this?

dotnet-policy-service · 2024-09-20T21:11:34Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

MichalStrehovsky · 2024-09-30T07:13:46Z

@LakshanF do you think we'd be able to implement the rest?

If there is a rundown for this, we do have names of methods available in stack trace metadata. If the rundown can run managed code, we could get it there. Maybe. Depending on what actually involves the rundown.

filipnavara · 2024-09-30T07:22:28Z

I only tried to run it with dotnet-trace and conversion to Speedscope format, which was quite useless, since you could see the stack traces but instead of method names there was just "?!?". I wonder if PerfView could perhaps show the addresses or correlate that to image base addresses. That would be already good enough for tools that can perform native symbolication (eg. Sentry).

Stack trace metadata sound like an interesting thing to try...

LakshanF · 2024-10-01T17:41:48Z

There is a work item in the diagnostic repo to lookup type information for native AOT GCDump, which could be expanded to include method information as well.

dotnet-policy-service · 2024-10-31T18:57:09Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

MichalStrehovsky · 2025-06-04T05:29:12Z

This is useful on its own - without this, dotnet-gcdump will just hang at "Flushing the type table".

MichalStrehovsky

Thank you!

Copilot

Pull Request Overview

This PR introduces a basic sampling profiler for NativeAOT by adding helper methods and integrating stack walking logic.

Added a new GetTransitionFrameForSampling method in thread.h
Extended the sampling event capture logic in ep-rt-aot.cpp
Introduced a GetControlPC method in StackFrameIterator.h

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/coreclr/nativeaot/Runtime/thread.h	Added a helper method to support sampling profiler functionality
src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp	Integrated sampling profiler logic to capture stack frames and emit events
src/coreclr/nativeaot/Runtime/StackFrameIterator.h	Exposed the control PC via a new method for use by the profiler

Comments suppressed due to low confidence (3)

src/coreclr/nativeaot/Runtime/thread.h:323

Consider adding a brief comment to clarify the purpose and usage of GetTransitionFrameForSampling for future maintainability.

PInvokeTransitionFrame* GetTransitionFrameForSampling() { return GetTransitionFrame(); }

src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp:113

[nitpick] Clarify or document in a tracking issue whether the differentiation between managed and external code will be addressed later to improve future code maintainability.

 // TODO: We can actually detect whether we are in managed or external code but does it matter?!

src/coreclr/nativeaot/Runtime/StackFrameIterator.h:58

Consider adding a comment to describe the role of GetControlPC in the sampling process to aid future maintainers.

PTR_VOID GetControlPC() { return m_ControlPC; }

MichalStrehovsky · 2025-06-04T11:10:11Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-06-04T11:10:28Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2025-06-04T21:00:14Z

/ba-g the arm32 build break was fixed and the rest are known

filipnavara · 2024-09-20T21:11:06Z

Presumably this is pretty useless since we don't do the rundown to get readable method names... but since I already have it laying around, anyone can think of a use for this?

dotnet-policy-service · 2024-09-20T21:11:34Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

MichalStrehovsky · 2024-09-30T07:13:46Z

@LakshanF do you think we'd be able to implement the rest?

If there is a rundown for this, we do have names of methods available in stack trace metadata. If the rundown can run managed code, we could get it there. Maybe. Depending on what actually involves the rundown.

filipnavara · 2024-09-30T07:22:28Z

I only tried to run it with dotnet-trace and conversion to Speedscope format, which was quite useless, since you could see the stack traces but instead of method names there was just "?!?". I wonder if PerfView could perhaps show the addresses or correlate that to image base addresses. That would be already good enough for tools that can perform native symbolication (eg. Sentry).

Stack trace metadata sound like an interesting thing to try...

LakshanF · 2024-10-01T17:41:48Z

There is a work item in the diagnostic repo to lookup type information for native AOT GCDump, which could be expanded to include method information as well.

dotnet-policy-service · 2024-10-31T18:57:09Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

MichalStrehovsky · 2025-06-04T05:29:12Z

This is useful on its own - without this, dotnet-gcdump will just hang at "Flushing the type table".

MichalStrehovsky

Thank you!

Copilot

Pull Request Overview

This PR introduces a basic sampling profiler for NativeAOT by adding helper methods and integrating stack walking logic.

Added a new GetTransitionFrameForSampling method in thread.h
Extended the sampling event capture logic in ep-rt-aot.cpp
Introduced a GetControlPC method in StackFrameIterator.h

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/coreclr/nativeaot/Runtime/thread.h	Added a helper method to support sampling profiler functionality
src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp	Integrated sampling profiler logic to capture stack frames and emit events
src/coreclr/nativeaot/Runtime/StackFrameIterator.h	Exposed the control PC via a new method for use by the profiler

Comments suppressed due to low confidence (3)

src/coreclr/nativeaot/Runtime/thread.h:323

Consider adding a brief comment to clarify the purpose and usage of GetTransitionFrameForSampling for future maintainability.

PInvokeTransitionFrame* GetTransitionFrameForSampling() { return GetTransitionFrame(); }

src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp:113

[nitpick] Clarify or document in a tracking issue whether the differentiation between managed and external code will be addressed later to improve future code maintainability.

 // TODO: We can actually detect whether we are in managed or external code but does it matter?!

src/coreclr/nativeaot/Runtime/StackFrameIterator.h:58

Consider adding a comment to describe the role of GetControlPC in the sampling process to aid future maintainers.

PTR_VOID GetControlPC() { return m_ControlPC; }

MichalStrehovsky · 2025-06-04T11:10:11Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-06-04T11:10:28Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2025-06-04T21:00:14Z

/ba-g the arm32 build break was fixed and the rest are known

filipnavara · 2024-09-20T21:11:06Z

Presumably this is pretty useless since we don't do the rundown to get readable method names... but since I already have it laying around, anyone can think of a use for this?

dotnet-policy-service · 2024-09-20T21:11:34Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

MichalStrehovsky · 2024-09-30T07:13:46Z

@LakshanF do you think we'd be able to implement the rest?

If there is a rundown for this, we do have names of methods available in stack trace metadata. If the rundown can run managed code, we could get it there. Maybe. Depending on what actually involves the rundown.

filipnavara · 2024-09-30T07:22:28Z

I only tried to run it with dotnet-trace and conversion to Speedscope format, which was quite useless, since you could see the stack traces but instead of method names there was just "?!?". I wonder if PerfView could perhaps show the addresses or correlate that to image base addresses. That would be already good enough for tools that can perform native symbolication (eg. Sentry).

Stack trace metadata sound like an interesting thing to try...

LakshanF · 2024-10-01T17:41:48Z

There is a work item in the diagnostic repo to lookup type information for native AOT GCDump, which could be expanded to include method information as well.

dotnet-policy-service · 2024-10-31T18:57:09Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

MichalStrehovsky · 2025-06-04T05:29:12Z

This is useful on its own - without this, dotnet-gcdump will just hang at "Flushing the type table".

MichalStrehovsky

Thank you!

Copilot

Pull Request Overview

This PR introduces a basic sampling profiler for NativeAOT by adding helper methods and integrating stack walking logic.

Added a new GetTransitionFrameForSampling method in thread.h
Extended the sampling event capture logic in ep-rt-aot.cpp
Introduced a GetControlPC method in StackFrameIterator.h

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/coreclr/nativeaot/Runtime/thread.h	Added a helper method to support sampling profiler functionality
src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp	Integrated sampling profiler logic to capture stack frames and emit events
src/coreclr/nativeaot/Runtime/StackFrameIterator.h	Exposed the control PC via a new method for use by the profiler

Comments suppressed due to low confidence (3)

src/coreclr/nativeaot/Runtime/thread.h:323

Consider adding a brief comment to clarify the purpose and usage of GetTransitionFrameForSampling for future maintainability.

PInvokeTransitionFrame* GetTransitionFrameForSampling() { return GetTransitionFrame(); }

src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp:113

[nitpick] Clarify or document in a tracking issue whether the differentiation between managed and external code will be addressed later to improve future code maintainability.

 // TODO: We can actually detect whether we are in managed or external code but does it matter?!

src/coreclr/nativeaot/Runtime/StackFrameIterator.h:58

Consider adding a comment to describe the role of GetControlPC in the sampling process to aid future maintainers.

PTR_VOID GetControlPC() { return m_ControlPC; }

MichalStrehovsky · 2025-06-04T11:10:11Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-06-04T11:10:28Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2025-06-04T21:00:14Z

/ba-g the arm32 build break was fixed and the rest are known

filipnavara · 2024-09-20T21:11:06Z

Presumably this is pretty useless since we don't do the rundown to get readable method names... but since I already have it laying around, anyone can think of a use for this?

dotnet-policy-service · 2024-09-20T21:11:34Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

MichalStrehovsky · 2024-09-30T07:13:46Z

@LakshanF do you think we'd be able to implement the rest?

If there is a rundown for this, we do have names of methods available in stack trace metadata. If the rundown can run managed code, we could get it there. Maybe. Depending on what actually involves the rundown.

filipnavara · 2024-09-30T07:22:28Z

I only tried to run it with dotnet-trace and conversion to Speedscope format, which was quite useless, since you could see the stack traces but instead of method names there was just "?!?". I wonder if PerfView could perhaps show the addresses or correlate that to image base addresses. That would be already good enough for tools that can perform native symbolication (eg. Sentry).

Stack trace metadata sound like an interesting thing to try...

LakshanF · 2024-10-01T17:41:48Z

There is a work item in the diagnostic repo to lookup type information for native AOT GCDump, which could be expanded to include method information as well.

dotnet-policy-service · 2024-10-31T18:57:09Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

MichalStrehovsky · 2025-06-04T05:29:12Z

This is useful on its own - without this, dotnet-gcdump will just hang at "Flushing the type table".

MichalStrehovsky

Thank you!

Copilot

Pull Request Overview

This PR introduces a basic sampling profiler for NativeAOT by adding helper methods and integrating stack walking logic.

Added a new GetTransitionFrameForSampling method in thread.h
Extended the sampling event capture logic in ep-rt-aot.cpp
Introduced a GetControlPC method in StackFrameIterator.h

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/coreclr/nativeaot/Runtime/thread.h	Added a helper method to support sampling profiler functionality
src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp	Integrated sampling profiler logic to capture stack frames and emit events
src/coreclr/nativeaot/Runtime/StackFrameIterator.h	Exposed the control PC via a new method for use by the profiler

Comments suppressed due to low confidence (3)

src/coreclr/nativeaot/Runtime/thread.h:323

Consider adding a brief comment to clarify the purpose and usage of GetTransitionFrameForSampling for future maintainability.

PInvokeTransitionFrame* GetTransitionFrameForSampling() { return GetTransitionFrame(); }

src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp:113

[nitpick] Clarify or document in a tracking issue whether the differentiation between managed and external code will be addressed later to improve future code maintainability.

 // TODO: We can actually detect whether we are in managed or external code but does it matter?!

src/coreclr/nativeaot/Runtime/StackFrameIterator.h:58

Consider adding a comment to describe the role of GetControlPC in the sampling process to aid future maintainers.

PTR_VOID GetControlPC() { return m_ControlPC; }

MichalStrehovsky · 2025-06-04T11:10:11Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-06-04T11:10:28Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2025-06-04T21:00:14Z

/ba-g the arm32 build break was fixed and the rest are known

filipnavara · 2024-09-20T21:11:06Z

Presumably this is pretty useless since we don't do the rundown to get readable method names... but since I already have it laying around, anyone can think of a use for this?

dotnet-policy-service · 2024-09-20T21:11:34Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

MichalStrehovsky · 2024-09-30T07:13:46Z

@LakshanF do you think we'd be able to implement the rest?

If there is a rundown for this, we do have names of methods available in stack trace metadata. If the rundown can run managed code, we could get it there. Maybe. Depending on what actually involves the rundown.

filipnavara · 2024-09-30T07:22:28Z

I only tried to run it with dotnet-trace and conversion to Speedscope format, which was quite useless, since you could see the stack traces but instead of method names there was just "?!?". I wonder if PerfView could perhaps show the addresses or correlate that to image base addresses. That would be already good enough for tools that can perform native symbolication (eg. Sentry).

Stack trace metadata sound like an interesting thing to try...

LakshanF · 2024-10-01T17:41:48Z

There is a work item in the diagnostic repo to lookup type information for native AOT GCDump, which could be expanded to include method information as well.

dotnet-policy-service · 2024-10-31T18:57:09Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

MichalStrehovsky · 2025-06-04T05:29:12Z

This is useful on its own - without this, dotnet-gcdump will just hang at "Flushing the type table".

MichalStrehovsky

Thank you!

Copilot

Pull Request Overview

This PR introduces a basic sampling profiler for NativeAOT by adding helper methods and integrating stack walking logic.

Added a new GetTransitionFrameForSampling method in thread.h
Extended the sampling event capture logic in ep-rt-aot.cpp
Introduced a GetControlPC method in StackFrameIterator.h

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/coreclr/nativeaot/Runtime/thread.h	Added a helper method to support sampling profiler functionality
src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp	Integrated sampling profiler logic to capture stack frames and emit events
src/coreclr/nativeaot/Runtime/StackFrameIterator.h	Exposed the control PC via a new method for use by the profiler

Comments suppressed due to low confidence (3)

src/coreclr/nativeaot/Runtime/thread.h:323

Consider adding a brief comment to clarify the purpose and usage of GetTransitionFrameForSampling for future maintainability.

PInvokeTransitionFrame* GetTransitionFrameForSampling() { return GetTransitionFrame(); }

src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp:113

[nitpick] Clarify or document in a tracking issue whether the differentiation between managed and external code will be addressed later to improve future code maintainability.

 // TODO: We can actually detect whether we are in managed or external code but does it matter?!

src/coreclr/nativeaot/Runtime/StackFrameIterator.h:58

Consider adding a comment to describe the role of GetControlPC in the sampling process to aid future maintainers.

PTR_VOID GetControlPC() { return m_ControlPC; }

MichalStrehovsky · 2025-06-04T11:10:11Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-06-04T11:10:28Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2025-06-04T21:00:14Z

/ba-g the arm32 build break was fixed and the rest are known

filipnavara · 2024-09-20T21:11:06Z

Presumably this is pretty useless since we don't do the rundown to get readable method names... but since I already have it laying around, anyone can think of a use for this?

dotnet-policy-service · 2024-09-20T21:11:34Z

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

MichalStrehovsky · 2024-09-30T07:13:46Z

@LakshanF do you think we'd be able to implement the rest?

If there is a rundown for this, we do have names of methods available in stack trace metadata. If the rundown can run managed code, we could get it there. Maybe. Depending on what actually involves the rundown.

filipnavara · 2024-09-30T07:22:28Z

I only tried to run it with dotnet-trace and conversion to Speedscope format, which was quite useless, since you could see the stack traces but instead of method names there was just "?!?". I wonder if PerfView could perhaps show the addresses or correlate that to image base addresses. That would be already good enough for tools that can perform native symbolication (eg. Sentry).

Stack trace metadata sound like an interesting thing to try...

LakshanF · 2024-10-01T17:41:48Z

There is a work item in the diagnostic repo to lookup type information for native AOT GCDump, which could be expanded to include method information as well.

dotnet-policy-service · 2024-10-31T18:57:09Z

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

MichalStrehovsky · 2025-06-04T05:29:12Z

This is useful on its own - without this, dotnet-gcdump will just hang at "Flushing the type table".

MichalStrehovsky

Thank you!

Copilot

Pull Request Overview

This PR introduces a basic sampling profiler for NativeAOT by adding helper methods and integrating stack walking logic.

Added a new GetTransitionFrameForSampling method in thread.h
Extended the sampling event capture logic in ep-rt-aot.cpp
Introduced a GetControlPC method in StackFrameIterator.h

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/coreclr/nativeaot/Runtime/thread.h	Added a helper method to support sampling profiler functionality
src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp	Integrated sampling profiler logic to capture stack frames and emit events
src/coreclr/nativeaot/Runtime/StackFrameIterator.h	Exposed the control PC via a new method for use by the profiler

Comments suppressed due to low confidence (3)

src/coreclr/nativeaot/Runtime/thread.h:323

Consider adding a brief comment to clarify the purpose and usage of GetTransitionFrameForSampling for future maintainability.

PInvokeTransitionFrame* GetTransitionFrameForSampling() { return GetTransitionFrame(); }

src/coreclr/nativeaot/Runtime/eventpipe/ep-rt-aot.cpp:113

[nitpick] Clarify or document in a tracking issue whether the differentiation between managed and external code will be addressed later to improve future code maintainability.

 // TODO: We can actually detect whether we are in managed or external code but does it matter?!

src/coreclr/nativeaot/Runtime/StackFrameIterator.h:58

Consider adding a comment to describe the role of GetControlPC in the sampling process to aid future maintainers.

PTR_VOID GetControlPC() { return m_ControlPC; }

MichalStrehovsky · 2025-06-04T11:10:11Z

/azp run runtime-nativeaot-outerloop

azure-pipelines · 2025-06-04T11:10:28Z

Azure Pipelines successfully started running 1 pipeline(s).

MichalStrehovsky · 2025-06-04T21:00:14Z

/ba-g the arm32 build break was fixed and the rest are known

Add AOT sampling profiler
cf3554a

ghost added the area-NativeAOT-coreclr label Sep 20, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Sep 20, 2024

build-analysisBot mentioned this pull request Sep 22, 2024
Test failure: Assertion failed 'likelihood <= 1.0' #108100
Closed

dotnet-policy-serviceBot closed this Oct 31, 2024

github-actionsBot locked and limited conversation to collaborators Dec 1, 2024

filipnavara mentioned this pull request Feb 8, 2025
GC events from Native AOT don't contain type names #112291
Closed

MichalStrehovsky reopened this Jun 4, 2025

dotnet unlocked this conversation Jun 4, 2025

Merge branch 'main' into aot-sampling
4c4540c

MichalStrehovsky marked this pull request as ready for review June 4, 2025 05:29

CopilotAI review requested due to automatic review settings June 4, 2025 05:29

MichalStrehovsky self-requested a review as a code owner June 4, 2025 05:29

MichalStrehovsky approved these changes Jun 4, 2025
View reviewed changes

CopilotAI reviewed Jun 4, 2025
View reviewed changes

This was referenced Jun 4, 2025
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
TimeSpan overflowed because the duration is too long. #116276
Closed
Test failure: System.IO.IOException : Too many open files #116278
Closed

MichalStrehovsky merged commit 3427e5f into dotnet:mainJun 4, 2025

filipnavara deleted the aot-sampling branch June 4, 2025 21:01

jkotas mentioned this pull request Jun 8, 2025
SampleProfiler test failure: !pThreadToWalk->IsHijacked() #116407
Closed

github-actionsBot locked and limited conversation to collaborators Jul 5, 2025

Add AOT sampling profiler
cf3554a

ghost added the area-NativeAOT-coreclr label Sep 20, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Sep 20, 2024

build-analysisBot mentioned this pull request Sep 22, 2024
Test failure: Assertion failed 'likelihood <= 1.0' #108100
Closed

dotnet-policy-serviceBot closed this Oct 31, 2024

github-actionsBot locked and limited conversation to collaborators Dec 1, 2024

filipnavara mentioned this pull request Feb 8, 2025
GC events from Native AOT don't contain type names #112291
Closed

MichalStrehovsky reopened this Jun 4, 2025

dotnet unlocked this conversation Jun 4, 2025

Merge branch 'main' into aot-sampling
4c4540c

MichalStrehovsky marked this pull request as ready for review June 4, 2025 05:29

CopilotAI review requested due to automatic review settings June 4, 2025 05:29

MichalStrehovsky self-requested a review as a code owner June 4, 2025 05:29

MichalStrehovsky approved these changes Jun 4, 2025
View reviewed changes

CopilotAI reviewed Jun 4, 2025
View reviewed changes

This was referenced Jun 4, 2025
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
TimeSpan overflowed because the duration is too long. #116276
Closed
Test failure: System.IO.IOException : Too many open files #116278
Closed

MichalStrehovsky merged commit 3427e5f into dotnet:mainJun 4, 2025

filipnavara deleted the aot-sampling branch June 4, 2025 21:01

jkotas mentioned this pull request Jun 8, 2025
SampleProfiler test failure: !pThreadToWalk->IsHijacked() #116407
Closed

github-actionsBot locked and limited conversation to collaborators Jul 5, 2025

Add AOT sampling profiler
cf3554a

ghost added the area-NativeAOT-coreclr label Sep 20, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Sep 20, 2024

build-analysisBot mentioned this pull request Sep 22, 2024
Test failure: Assertion failed 'likelihood <= 1.0' #108100
Closed

dotnet-policy-serviceBot closed this Oct 31, 2024

github-actionsBot locked and limited conversation to collaborators Dec 1, 2024

filipnavara mentioned this pull request Feb 8, 2025
GC events from Native AOT don't contain type names #112291
Closed

MichalStrehovsky reopened this Jun 4, 2025

dotnet unlocked this conversation Jun 4, 2025

Merge branch 'main' into aot-sampling
4c4540c

MichalStrehovsky marked this pull request as ready for review June 4, 2025 05:29

CopilotAI review requested due to automatic review settings June 4, 2025 05:29

MichalStrehovsky self-requested a review as a code owner June 4, 2025 05:29

MichalStrehovsky approved these changes Jun 4, 2025
View reviewed changes

CopilotAI reviewed Jun 4, 2025
View reviewed changes

This was referenced Jun 4, 2025
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
TimeSpan overflowed because the duration is too long. #116276
Closed
Test failure: System.IO.IOException : Too many open files #116278
Closed

MichalStrehovsky merged commit 3427e5f into dotnet:mainJun 4, 2025

filipnavara deleted the aot-sampling branch June 4, 2025 21:01

jkotas mentioned this pull request Jun 8, 2025
SampleProfiler test failure: !pThreadToWalk->IsHijacked() #116407
Closed

github-actionsBot locked and limited conversation to collaborators Jul 5, 2025

Add AOT sampling profiler
cf3554a

ghost added the area-NativeAOT-coreclr label Sep 20, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Sep 20, 2024

build-analysisBot mentioned this pull request Sep 22, 2024
Test failure: Assertion failed 'likelihood <= 1.0' #108100
Closed

dotnet-policy-serviceBot closed this Oct 31, 2024

github-actionsBot locked and limited conversation to collaborators Dec 1, 2024

filipnavara mentioned this pull request Feb 8, 2025
GC events from Native AOT don't contain type names #112291
Closed

MichalStrehovsky reopened this Jun 4, 2025

dotnet unlocked this conversation Jun 4, 2025

Merge branch 'main' into aot-sampling
4c4540c

MichalStrehovsky marked this pull request as ready for review June 4, 2025 05:29

CopilotAI review requested due to automatic review settings June 4, 2025 05:29

MichalStrehovsky self-requested a review as a code owner June 4, 2025 05:29

MichalStrehovsky approved these changes Jun 4, 2025
View reviewed changes

CopilotAI reviewed Jun 4, 2025
View reviewed changes

This was referenced Jun 4, 2025
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
TimeSpan overflowed because the duration is too long. #116276
Closed
Test failure: System.IO.IOException : Too many open files #116278
Closed

MichalStrehovsky merged commit 3427e5f into dotnet:mainJun 4, 2025

filipnavara deleted the aot-sampling branch June 4, 2025 21:01

jkotas mentioned this pull request Jun 8, 2025
SampleProfiler test failure: !pThreadToWalk->IsHijacked() #116407
Closed

github-actionsBot locked and limited conversation to collaborators Jul 5, 2025

Add AOT sampling profiler
cf3554a

ghost added the area-NativeAOT-coreclr label Sep 20, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Sep 20, 2024

build-analysisBot mentioned this pull request Sep 22, 2024
Test failure: Assertion failed 'likelihood <= 1.0' #108100
Closed

dotnet-policy-serviceBot closed this Oct 31, 2024

github-actionsBot locked and limited conversation to collaborators Dec 1, 2024

filipnavara mentioned this pull request Feb 8, 2025
GC events from Native AOT don't contain type names #112291
Closed

MichalStrehovsky reopened this Jun 4, 2025

dotnet unlocked this conversation Jun 4, 2025

Merge branch 'main' into aot-sampling
4c4540c

MichalStrehovsky marked this pull request as ready for review June 4, 2025 05:29

CopilotAI review requested due to automatic review settings June 4, 2025 05:29

MichalStrehovsky self-requested a review as a code owner June 4, 2025 05:29

MichalStrehovsky approved these changes Jun 4, 2025
View reviewed changes

CopilotAI reviewed Jun 4, 2025
View reviewed changes

This was referenced Jun 4, 2025
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
TimeSpan overflowed because the duration is too long. #116276
Closed
Test failure: System.IO.IOException : Too many open files #116278
Closed

MichalStrehovsky merged commit 3427e5f into dotnet:mainJun 4, 2025

filipnavara deleted the aot-sampling branch June 4, 2025 21:01

jkotas mentioned this pull request Jun 8, 2025
SampleProfiler test failure: !pThreadToWalk->IsHijacked() #116407
Closed

github-actionsBot locked and limited conversation to collaborators Jul 5, 2025

Add AOT sampling profiler
cf3554a

ghost added the area-NativeAOT-coreclr label Sep 20, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Sep 20, 2024

build-analysisBot mentioned this pull request Sep 22, 2024
Test failure: Assertion failed 'likelihood <= 1.0' #108100
Closed

dotnet-policy-serviceBot closed this Oct 31, 2024

github-actionsBot locked and limited conversation to collaborators Dec 1, 2024

filipnavara mentioned this pull request Feb 8, 2025
GC events from Native AOT don't contain type names #112291
Closed

MichalStrehovsky reopened this Jun 4, 2025

dotnet unlocked this conversation Jun 4, 2025

Merge branch 'main' into aot-sampling
4c4540c

MichalStrehovsky marked this pull request as ready for review June 4, 2025 05:29

CopilotAI review requested due to automatic review settings June 4, 2025 05:29

MichalStrehovsky self-requested a review as a code owner June 4, 2025 05:29

MichalStrehovsky approved these changes Jun 4, 2025
View reviewed changes

CopilotAI reviewed Jun 4, 2025
View reviewed changes

This was referenced Jun 4, 2025
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
TimeSpan overflowed because the duration is too long. #116276
Closed
Test failure: System.IO.IOException : Too many open files #116278
Closed

MichalStrehovsky merged commit 3427e5f into dotnet:mainJun 4, 2025

filipnavara deleted the aot-sampling branch June 4, 2025 21:01

jkotas mentioned this pull request Jun 8, 2025
SampleProfiler test failure: !pThreadToWalk->IsHijacked() #116407
Closed

github-actionsBot locked and limited conversation to collaborators Jul 5, 2025

Add AOT sampling profiler
cf3554a

ghost added the area-NativeAOT-coreclr label Sep 20, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Sep 20, 2024

build-analysisBot mentioned this pull request Sep 22, 2024
Test failure: Assertion failed 'likelihood <= 1.0' #108100
Closed

dotnet-policy-serviceBot closed this Oct 31, 2024

github-actionsBot locked and limited conversation to collaborators Dec 1, 2024

filipnavara mentioned this pull request Feb 8, 2025
GC events from Native AOT don't contain type names #112291
Closed

MichalStrehovsky reopened this Jun 4, 2025

dotnet unlocked this conversation Jun 4, 2025

Merge branch 'main' into aot-sampling
4c4540c

MichalStrehovsky marked this pull request as ready for review June 4, 2025 05:29

CopilotAI review requested due to automatic review settings June 4, 2025 05:29

MichalStrehovsky self-requested a review as a code owner June 4, 2025 05:29

MichalStrehovsky approved these changes Jun 4, 2025
View reviewed changes

CopilotAI reviewed Jun 4, 2025
View reviewed changes

This was referenced Jun 4, 2025
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
TimeSpan overflowed because the duration is too long. #116276
Closed
Test failure: System.IO.IOException : Too many open files #116278
Closed

MichalStrehovsky merged commit 3427e5f into dotnet:mainJun 4, 2025

filipnavara deleted the aot-sampling branch June 4, 2025 21:01

jkotas mentioned this pull request Jun 8, 2025
SampleProfiler test failure: !pThreadToWalk->IsHijacked() #116407
Closed

github-actionsBot locked and limited conversation to collaborators Jul 5, 2025

Add AOT sampling profiler
cf3554a

ghost added the area-NativeAOT-coreclr label Sep 20, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Sep 20, 2024

build-analysisBot mentioned this pull request Sep 22, 2024
Test failure: Assertion failed 'likelihood <= 1.0' #108100
Closed

dotnet-policy-serviceBot closed this Oct 31, 2024

github-actionsBot locked and limited conversation to collaborators Dec 1, 2024

filipnavara mentioned this pull request Feb 8, 2025
GC events from Native AOT don't contain type names #112291
Closed

MichalStrehovsky reopened this Jun 4, 2025

dotnet unlocked this conversation Jun 4, 2025

Merge branch 'main' into aot-sampling
4c4540c

MichalStrehovsky marked this pull request as ready for review June 4, 2025 05:29

CopilotAI review requested due to automatic review settings June 4, 2025 05:29

MichalStrehovsky self-requested a review as a code owner June 4, 2025 05:29

MichalStrehovsky approved these changes Jun 4, 2025
View reviewed changes

CopilotAI reviewed Jun 4, 2025
View reviewed changes

This was referenced Jun 4, 2025
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
TimeSpan overflowed because the duration is too long. #116276
Closed
Test failure: System.IO.IOException : Too many open files #116278
Closed

MichalStrehovsky merged commit 3427e5f into dotnet:mainJun 4, 2025

filipnavara deleted the aot-sampling branch June 4, 2025 21:01

jkotas mentioned this pull request Jun 8, 2025
SampleProfiler test failure: !pThreadToWalk->IsHijacked() #116407
Closed

github-actionsBot locked and limited conversation to collaborators Jul 5, 2025

Uh oh!

Conversation

filipnavara commented Sep 20, 2024

Uh oh!

dotnet-policy-serviceBot commented Sep 20, 2024

Uh oh!

MichalStrehovsky commented Sep 30, 2024

Uh oh!

filipnavara commented Sep 30, 2024

Uh oh!

LakshanF commented Oct 1, 2024

Uh oh!

dotnet-policy-serviceBot commented Oct 31, 2024

Uh oh!

MichalStrehovsky commented Jun 4, 2025

Uh oh!

MichalStrehovsky left a comment

Choose a reason for hiding this comment

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

MichalStrehovsky commented Jun 4, 2025

Uh oh!

azure-pipelinesBot commented Jun 4, 2025

Uh oh!

MichalStrehovsky commented Jun 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

filipnavara commented Sep 20, 2024

Uh oh!

dotnet-policy-serviceBot commented Sep 20, 2024

Uh oh!

MichalStrehovsky commented Sep 30, 2024

Uh oh!

filipnavara commented Sep 30, 2024

Uh oh!

LakshanF commented Oct 1, 2024

Uh oh!

dotnet-policy-serviceBot commented Oct 31, 2024

Uh oh!

MichalStrehovsky commented Jun 4, 2025

Uh oh!

MichalStrehovsky left a comment

Choose a reason for hiding this comment

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

MichalStrehovsky commented Jun 4, 2025

Uh oh!

azure-pipelinesBot commented Jun 4, 2025

Uh oh!

MichalStrehovsky commented Jun 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

filipnavara commented Sep 20, 2024

Uh oh!