delete deadcode from nsutilpriv.h by kasperk81 · Pull Request #108104 · dotnet/runtime

kasperk81 · 2024-09-21T23:41:04Z

No description provided.

dotnet-policy-service · 2024-09-21T23:41:32Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

jkotas · 2024-09-21T23:53:53Z

+// Concatenate type names to assembly names
 //*****************************************************************************
 static
 bool MakeAssemblyQualifiedName( // true if ok, false if out of memory


MakeAssemblyQualifiedName methods look like dead code. Could you please delete them instead?

jkotas · 2024-09-22T00:01:21Z

- int dwAssemblyName); // Number of characters (not including null)
-
-static
-int MakeNestedTypeName( // true ok, false out of memory


MakeNestedTypeName is used

only third one with stack string is in use

jkotas · 2024-09-22T00:01:59Z

-// Concatinate type names to assembly names
-//*****************************************************************************
-static
-bool MakeAssemblyQualifiedName( // true if ok, false if out of memory


Also delete the implementation in https://github.com/dotnet/runtime/blob/main/src/coreclr/utilcode/namespaceutil.cpp

jkotas · 2024-09-22T15:50:50Z

+#ifdef _PREFAST_
+// need to set ptr=NULL so we don't get a build error because ptr isn't inited in a couple cases
+#define MAKE_FULLY_QUALIFIED_MEMBER_NAME(ptr, pszNameSpace, pszClassName, pszMemberName, pszSig) ptr=NULL;
+#else //_PREFAST_


Suggested change
#ifdef_PREFAST_
// need to set ptr=NULL so we don't get a build error because ptr isn't inited in a couple cases
#defineMAKE_FULLY_QUALIFIED_MEMBER_NAME(ptr, pszNameSpace, pszClassName, pszMemberName, pszSig) ptr=NULL;
#else//_PREFAST_
This should not be needed.

jkotas · 2024-09-22T15:53:47Z

 int __i##ptr = ns::GetFullLength(pszNameSpace, pszClassName); \
 __i##ptr += (pszMemberName ? (int) strlen(pszMemberName) : 0); \
- __i##ptr += (NAMESPACE_SEPARATOR_LEN * 2); \
+ __i##ptr += (int)strlen(NAMESPACE_SEPARATOR_STR) + 1; \


This change does not look right. The code below adds NAMESPACE_SEPARATOR_STR up to two times, so it makes sense that NAMESPACE_SEPARATOR_LEN was multiplied by two.

jkotas

Thanks

kasperk81 · 2024-09-21T23:41:04Z

No description provided.

dotnet-policy-service · 2024-09-21T23:41:32Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

jkotas · 2024-09-21T23:53:53Z

+// Concatenate type names to assembly names
 //*****************************************************************************
 static
 bool MakeAssemblyQualifiedName( // true if ok, false if out of memory


MakeAssemblyQualifiedName methods look like dead code. Could you please delete them instead?

jkotas · 2024-09-22T00:01:21Z

- int dwAssemblyName); // Number of characters (not including null)
-
-static
-int MakeNestedTypeName( // true ok, false out of memory


MakeNestedTypeName is used

only third one with stack string is in use

jkotas · 2024-09-22T00:01:59Z

-// Concatinate type names to assembly names
-//*****************************************************************************
-static
-bool MakeAssemblyQualifiedName( // true if ok, false if out of memory


Also delete the implementation in https://github.com/dotnet/runtime/blob/main/src/coreclr/utilcode/namespaceutil.cpp

jkotas · 2024-09-22T15:50:50Z

+#ifdef _PREFAST_
+// need to set ptr=NULL so we don't get a build error because ptr isn't inited in a couple cases
+#define MAKE_FULLY_QUALIFIED_MEMBER_NAME(ptr, pszNameSpace, pszClassName, pszMemberName, pszSig) ptr=NULL;
+#else //_PREFAST_


Suggested change
#ifdef_PREFAST_
// need to set ptr=NULL so we don't get a build error because ptr isn't inited in a couple cases
#defineMAKE_FULLY_QUALIFIED_MEMBER_NAME(ptr, pszNameSpace, pszClassName, pszMemberName, pszSig) ptr=NULL;
#else//_PREFAST_
This should not be needed.

jkotas · 2024-09-22T15:53:47Z

 int __i##ptr = ns::GetFullLength(pszNameSpace, pszClassName); \
 __i##ptr += (pszMemberName ? (int) strlen(pszMemberName) : 0); \
- __i##ptr += (NAMESPACE_SEPARATOR_LEN * 2); \
+ __i##ptr += (int)strlen(NAMESPACE_SEPARATOR_STR) + 1; \


This change does not look right. The code below adds NAMESPACE_SEPARATOR_STR up to two times, so it makes sense that NAMESPACE_SEPARATOR_LEN was multiplied by two.

jkotas

Thanks

kasperk81 · 2024-09-21T23:41:04Z

No description provided.

dotnet-policy-service · 2024-09-21T23:41:32Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

jkotas · 2024-09-21T23:53:53Z

+// Concatenate type names to assembly names
 //*****************************************************************************
 static
 bool MakeAssemblyQualifiedName( // true if ok, false if out of memory


MakeAssemblyQualifiedName methods look like dead code. Could you please delete them instead?

jkotas · 2024-09-22T00:01:21Z

- int dwAssemblyName); // Number of characters (not including null)
-
-static
-int MakeNestedTypeName( // true ok, false out of memory


MakeNestedTypeName is used

only third one with stack string is in use

jkotas · 2024-09-22T00:01:59Z

-// Concatinate type names to assembly names
-//*****************************************************************************
-static
-bool MakeAssemblyQualifiedName( // true if ok, false if out of memory


Also delete the implementation in https://github.com/dotnet/runtime/blob/main/src/coreclr/utilcode/namespaceutil.cpp

jkotas · 2024-09-22T15:50:50Z

+#ifdef _PREFAST_
+// need to set ptr=NULL so we don't get a build error because ptr isn't inited in a couple cases
+#define MAKE_FULLY_QUALIFIED_MEMBER_NAME(ptr, pszNameSpace, pszClassName, pszMemberName, pszSig) ptr=NULL;
+#else //_PREFAST_


Suggested change
#ifdef_PREFAST_
// need to set ptr=NULL so we don't get a build error because ptr isn't inited in a couple cases
#defineMAKE_FULLY_QUALIFIED_MEMBER_NAME(ptr, pszNameSpace, pszClassName, pszMemberName, pszSig) ptr=NULL;
#else//_PREFAST_
This should not be needed.

jkotas · 2024-09-22T15:53:47Z

 int __i##ptr = ns::GetFullLength(pszNameSpace, pszClassName); \
 __i##ptr += (pszMemberName ? (int) strlen(pszMemberName) : 0); \
- __i##ptr += (NAMESPACE_SEPARATOR_LEN * 2); \
+ __i##ptr += (int)strlen(NAMESPACE_SEPARATOR_STR) + 1; \


This change does not look right. The code below adds NAMESPACE_SEPARATOR_STR up to two times, so it makes sense that NAMESPACE_SEPARATOR_LEN was multiplied by two.

jkotas

Thanks

kasperk81 · 2024-09-21T23:41:04Z

No description provided.

dotnet-policy-service · 2024-09-21T23:41:32Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

jkotas · 2024-09-21T23:53:53Z

+// Concatenate type names to assembly names
 //*****************************************************************************
 static
 bool MakeAssemblyQualifiedName( // true if ok, false if out of memory


MakeAssemblyQualifiedName methods look like dead code. Could you please delete them instead?

jkotas · 2024-09-22T00:01:21Z

- int dwAssemblyName); // Number of characters (not including null)
-
-static
-int MakeNestedTypeName( // true ok, false out of memory


MakeNestedTypeName is used

only third one with stack string is in use

jkotas · 2024-09-22T00:01:59Z

-// Concatinate type names to assembly names
-//*****************************************************************************
-static
-bool MakeAssemblyQualifiedName( // true if ok, false if out of memory


Also delete the implementation in https://github.com/dotnet/runtime/blob/main/src/coreclr/utilcode/namespaceutil.cpp

jkotas · 2024-09-22T15:50:50Z

+#ifdef _PREFAST_
+// need to set ptr=NULL so we don't get a build error because ptr isn't inited in a couple cases
+#define MAKE_FULLY_QUALIFIED_MEMBER_NAME(ptr, pszNameSpace, pszClassName, pszMemberName, pszSig) ptr=NULL;
+#else //_PREFAST_


Suggested change
#ifdef_PREFAST_
// need to set ptr=NULL so we don't get a build error because ptr isn't inited in a couple cases
#defineMAKE_FULLY_QUALIFIED_MEMBER_NAME(ptr, pszNameSpace, pszClassName, pszMemberName, pszSig) ptr=NULL;
#else//_PREFAST_
This should not be needed.

jkotas · 2024-09-22T15:53:47Z

 int __i##ptr = ns::GetFullLength(pszNameSpace, pszClassName); \
 __i##ptr += (pszMemberName ? (int) strlen(pszMemberName) : 0); \
- __i##ptr += (NAMESPACE_SEPARATOR_LEN * 2); \
+ __i##ptr += (int)strlen(NAMESPACE_SEPARATOR_STR) + 1; \


This change does not look right. The code below adds NAMESPACE_SEPARATOR_STR up to two times, so it makes sense that NAMESPACE_SEPARATOR_LEN was multiplied by two.

jkotas

Thanks

kasperk81 · 2024-09-21T23:41:04Z

No description provided.

dotnet-policy-service · 2024-09-21T23:41:32Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

jkotas · 2024-09-21T23:53:53Z

+// Concatenate type names to assembly names
 //*****************************************************************************
 static
 bool MakeAssemblyQualifiedName( // true if ok, false if out of memory


MakeAssemblyQualifiedName methods look like dead code. Could you please delete them instead?

jkotas · 2024-09-22T00:01:21Z

- int dwAssemblyName); // Number of characters (not including null)
-
-static
-int MakeNestedTypeName( // true ok, false out of memory


MakeNestedTypeName is used

only third one with stack string is in use

jkotas · 2024-09-22T00:01:59Z

-// Concatinate type names to assembly names
-//*****************************************************************************
-static
-bool MakeAssemblyQualifiedName( // true if ok, false if out of memory


Also delete the implementation in https://github.com/dotnet/runtime/blob/main/src/coreclr/utilcode/namespaceutil.cpp

jkotas · 2024-09-22T15:50:50Z

+#ifdef _PREFAST_
+// need to set ptr=NULL so we don't get a build error because ptr isn't inited in a couple cases
+#define MAKE_FULLY_QUALIFIED_MEMBER_NAME(ptr, pszNameSpace, pszClassName, pszMemberName, pszSig) ptr=NULL;
+#else //_PREFAST_


Suggested change
#ifdef_PREFAST_
// need to set ptr=NULL so we don't get a build error because ptr isn't inited in a couple cases
#defineMAKE_FULLY_QUALIFIED_MEMBER_NAME(ptr, pszNameSpace, pszClassName, pszMemberName, pszSig) ptr=NULL;
#else//_PREFAST_
This should not be needed.

jkotas · 2024-09-22T15:53:47Z

 int __i##ptr = ns::GetFullLength(pszNameSpace, pszClassName); \
 __i##ptr += (pszMemberName ? (int) strlen(pszMemberName) : 0); \
- __i##ptr += (NAMESPACE_SEPARATOR_LEN * 2); \
+ __i##ptr += (int)strlen(NAMESPACE_SEPARATOR_STR) + 1; \


This change does not look right. The code below adds NAMESPACE_SEPARATOR_STR up to two times, so it makes sense that NAMESPACE_SEPARATOR_LEN was multiplied by two.

jkotas

Thanks

kasperk81 · 2024-09-21T23:41:04Z

No description provided.

dotnet-policy-service · 2024-09-21T23:41:32Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

jkotas · 2024-09-21T23:53:53Z

+// Concatenate type names to assembly names
 //*****************************************************************************
 static
 bool MakeAssemblyQualifiedName( // true if ok, false if out of memory


MakeAssemblyQualifiedName methods look like dead code. Could you please delete them instead?

jkotas · 2024-09-22T00:01:21Z

- int dwAssemblyName); // Number of characters (not including null)
-
-static
-int MakeNestedTypeName( // true ok, false out of memory


MakeNestedTypeName is used

only third one with stack string is in use

jkotas · 2024-09-22T00:01:59Z

-// Concatinate type names to assembly names
-//*****************************************************************************
-static
-bool MakeAssemblyQualifiedName( // true if ok, false if out of memory


Also delete the implementation in https://github.com/dotnet/runtime/blob/main/src/coreclr/utilcode/namespaceutil.cpp

jkotas · 2024-09-22T15:50:50Z

+#ifdef _PREFAST_
+// need to set ptr=NULL so we don't get a build error because ptr isn't inited in a couple cases
+#define MAKE_FULLY_QUALIFIED_MEMBER_NAME(ptr, pszNameSpace, pszClassName, pszMemberName, pszSig) ptr=NULL;
+#else //_PREFAST_


Suggested change
#ifdef_PREFAST_
// need to set ptr=NULL so we don't get a build error because ptr isn't inited in a couple cases
#defineMAKE_FULLY_QUALIFIED_MEMBER_NAME(ptr, pszNameSpace, pszClassName, pszMemberName, pszSig) ptr=NULL;
#else//_PREFAST_
This should not be needed.

jkotas · 2024-09-22T15:53:47Z

 int __i##ptr = ns::GetFullLength(pszNameSpace, pszClassName); \
 __i##ptr += (pszMemberName ? (int) strlen(pszMemberName) : 0); \
- __i##ptr += (NAMESPACE_SEPARATOR_LEN * 2); \
+ __i##ptr += (int)strlen(NAMESPACE_SEPARATOR_STR) + 1; \


This change does not look right. The code below adds NAMESPACE_SEPARATOR_STR up to two times, so it makes sense that NAMESPACE_SEPARATOR_LEN was multiplied by two.

jkotas

Thanks

kasperk81 · 2024-09-21T23:41:04Z

No description provided.

dotnet-policy-service · 2024-09-21T23:41:32Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

jkotas · 2024-09-21T23:53:53Z

+// Concatenate type names to assembly names
 //*****************************************************************************
 static
 bool MakeAssemblyQualifiedName( // true if ok, false if out of memory


MakeAssemblyQualifiedName methods look like dead code. Could you please delete them instead?

jkotas · 2024-09-22T00:01:21Z

- int dwAssemblyName); // Number of characters (not including null)
-
-static
-int MakeNestedTypeName( // true ok, false out of memory


MakeNestedTypeName is used

only third one with stack string is in use

jkotas · 2024-09-22T00:01:59Z

-// Concatinate type names to assembly names
-//*****************************************************************************
-static
-bool MakeAssemblyQualifiedName( // true if ok, false if out of memory


Also delete the implementation in https://github.com/dotnet/runtime/blob/main/src/coreclr/utilcode/namespaceutil.cpp

jkotas · 2024-09-22T15:50:50Z

+#ifdef _PREFAST_
+// need to set ptr=NULL so we don't get a build error because ptr isn't inited in a couple cases
+#define MAKE_FULLY_QUALIFIED_MEMBER_NAME(ptr, pszNameSpace, pszClassName, pszMemberName, pszSig) ptr=NULL;
+#else //_PREFAST_


Suggested change
#ifdef_PREFAST_
// need to set ptr=NULL so we don't get a build error because ptr isn't inited in a couple cases
#defineMAKE_FULLY_QUALIFIED_MEMBER_NAME(ptr, pszNameSpace, pszClassName, pszMemberName, pszSig) ptr=NULL;
#else//_PREFAST_
This should not be needed.

jkotas · 2024-09-22T15:53:47Z

 int __i##ptr = ns::GetFullLength(pszNameSpace, pszClassName); \
 __i##ptr += (pszMemberName ? (int) strlen(pszMemberName) : 0); \
- __i##ptr += (NAMESPACE_SEPARATOR_LEN * 2); \
+ __i##ptr += (int)strlen(NAMESPACE_SEPARATOR_STR) + 1; \


This change does not look right. The code below adds NAMESPACE_SEPARATOR_STR up to two times, so it makes sense that NAMESPACE_SEPARATOR_LEN was multiplied by two.

jkotas

Thanks

kasperk81 · 2024-09-21T23:41:04Z

No description provided.

dotnet-policy-service · 2024-09-21T23:41:32Z

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

jkotas · 2024-09-21T23:53:53Z

+// Concatenate type names to assembly names
 //*****************************************************************************
 static
 bool MakeAssemblyQualifiedName( // true if ok, false if out of memory


MakeAssemblyQualifiedName methods look like dead code. Could you please delete them instead?

jkotas · 2024-09-22T00:01:21Z

- int dwAssemblyName); // Number of characters (not including null)
-
-static
-int MakeNestedTypeName( // true ok, false out of memory


MakeNestedTypeName is used

only third one with stack string is in use

jkotas · 2024-09-22T00:01:59Z

-// Concatinate type names to assembly names
-//*****************************************************************************
-static
-bool MakeAssemblyQualifiedName( // true if ok, false if out of memory


Also delete the implementation in https://github.com/dotnet/runtime/blob/main/src/coreclr/utilcode/namespaceutil.cpp

jkotas · 2024-09-22T15:50:50Z

+#ifdef _PREFAST_
+// need to set ptr=NULL so we don't get a build error because ptr isn't inited in a couple cases
+#define MAKE_FULLY_QUALIFIED_MEMBER_NAME(ptr, pszNameSpace, pszClassName, pszMemberName, pszSig) ptr=NULL;
+#else //_PREFAST_


Suggested change
#ifdef_PREFAST_
// need to set ptr=NULL so we don't get a build error because ptr isn't inited in a couple cases
#defineMAKE_FULLY_QUALIFIED_MEMBER_NAME(ptr, pszNameSpace, pszClassName, pszMemberName, pszSig) ptr=NULL;
#else//_PREFAST_
This should not be needed.

jkotas · 2024-09-22T15:53:47Z

 int __i##ptr = ns::GetFullLength(pszNameSpace, pszClassName); \
 __i##ptr += (pszMemberName ? (int) strlen(pszMemberName) : 0); \
- __i##ptr += (NAMESPACE_SEPARATOR_LEN * 2); \
+ __i##ptr += (int)strlen(NAMESPACE_SEPARATOR_STR) + 1; \


This change does not look right. The code below adds NAMESPACE_SEPARATOR_STR up to two times, so it makes sense that NAMESPACE_SEPARATOR_LEN was multiplied by two.

jkotas

Thanks

ghost added the area-VM-coreclr label Sep 21, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Sep 21, 2024

jkotas reviewed Sep 21, 2024
View reviewed changes

kasperk81 changed the title ~~fix a typo~~delete deadcode from nsutilpriv.hSep 21, 2024

jkotas reviewed Sep 22, 2024
View reviewed changes

kasperk81 force-pushed the patch-5 branch from 62f0baa to 17bf075Compare September 22, 2024 01:07

build-analysisBot mentioned this pull request Sep 22, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

kasperk81 force-pushed the patch-5 branch 4 times, most recently from 255b288 to 47c3cfbCompare September 22, 2024 10:39

delete deadcode from nsutilpriv.h
7f94b28

kasperk81 force-pushed the patch-5 branch from 47c3cfb to 7f94b28Compare September 22, 2024 14:22

jkotas reviewed Sep 22, 2024
View reviewed changes

review
9f6ab10

jkotas approved these changes Sep 22, 2024
View reviewed changes

jkotas merged commit 619d4b3 into dotnet:mainSep 22, 2024

build-analysisBot mentioned this pull request Sep 22, 2024
Test failure: Assertion failed 'likelihood <= 1.0' #108100
Closed

jkotas mentioned this pull request Sep 22, 2024
Delete unused RedirectFunctor abstraction #108113
Merged

kasperk81 deleted the patch-5 branch September 23, 2024 23:05

sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
delete deadcode from nsutilpriv.h (dotnet#108104)
a523e97

github-actionsBot locked and limited conversation to collaborators Oct 24, 2024

ghost added the area-VM-coreclr label Sep 21, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Sep 21, 2024

jkotas reviewed Sep 21, 2024
View reviewed changes

kasperk81 changed the title ~~fix a typo~~delete deadcode from nsutilpriv.hSep 21, 2024

jkotas reviewed Sep 22, 2024
View reviewed changes

kasperk81 force-pushed the patch-5 branch from 62f0baa to 17bf075Compare September 22, 2024 01:07

build-analysisBot mentioned this pull request Sep 22, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

kasperk81 force-pushed the patch-5 branch 4 times, most recently from 255b288 to 47c3cfbCompare September 22, 2024 10:39

delete deadcode from nsutilpriv.h
7f94b28

kasperk81 force-pushed the patch-5 branch from 47c3cfb to 7f94b28Compare September 22, 2024 14:22

jkotas reviewed Sep 22, 2024
View reviewed changes

review
9f6ab10

jkotas approved these changes Sep 22, 2024
View reviewed changes

jkotas merged commit 619d4b3 into dotnet:mainSep 22, 2024

build-analysisBot mentioned this pull request Sep 22, 2024
Test failure: Assertion failed 'likelihood <= 1.0' #108100
Closed

jkotas mentioned this pull request Sep 22, 2024
Delete unused RedirectFunctor abstraction #108113
Merged

kasperk81 deleted the patch-5 branch September 23, 2024 23:05

sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
delete deadcode from nsutilpriv.h (dotnet#108104)
a523e97

github-actionsBot locked and limited conversation to collaborators Oct 24, 2024

ghost added the area-VM-coreclr label Sep 21, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Sep 21, 2024

jkotas reviewed Sep 21, 2024
View reviewed changes

kasperk81 changed the title ~~fix a typo~~delete deadcode from nsutilpriv.hSep 21, 2024

jkotas reviewed Sep 22, 2024
View reviewed changes

kasperk81 force-pushed the patch-5 branch from 62f0baa to 17bf075Compare September 22, 2024 01:07

build-analysisBot mentioned this pull request Sep 22, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

kasperk81 force-pushed the patch-5 branch 4 times, most recently from 255b288 to 47c3cfbCompare September 22, 2024 10:39

delete deadcode from nsutilpriv.h
7f94b28

kasperk81 force-pushed the patch-5 branch from 47c3cfb to 7f94b28Compare September 22, 2024 14:22

jkotas reviewed Sep 22, 2024
View reviewed changes

review
9f6ab10

jkotas approved these changes Sep 22, 2024
View reviewed changes

jkotas merged commit 619d4b3 into dotnet:mainSep 22, 2024

build-analysisBot mentioned this pull request Sep 22, 2024
Test failure: Assertion failed 'likelihood <= 1.0' #108100
Closed

jkotas mentioned this pull request Sep 22, 2024
Delete unused RedirectFunctor abstraction #108113
Merged

kasperk81 deleted the patch-5 branch September 23, 2024 23:05

sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
delete deadcode from nsutilpriv.h (dotnet#108104)
a523e97

github-actionsBot locked and limited conversation to collaborators Oct 24, 2024

ghost added the area-VM-coreclr label Sep 21, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Sep 21, 2024

jkotas reviewed Sep 21, 2024
View reviewed changes

kasperk81 changed the title ~~fix a typo~~delete deadcode from nsutilpriv.hSep 21, 2024

jkotas reviewed Sep 22, 2024
View reviewed changes

kasperk81 force-pushed the patch-5 branch from 62f0baa to 17bf075Compare September 22, 2024 01:07

build-analysisBot mentioned this pull request Sep 22, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

kasperk81 force-pushed the patch-5 branch 4 times, most recently from 255b288 to 47c3cfbCompare September 22, 2024 10:39

delete deadcode from nsutilpriv.h
7f94b28

kasperk81 force-pushed the patch-5 branch from 47c3cfb to 7f94b28Compare September 22, 2024 14:22

jkotas reviewed Sep 22, 2024
View reviewed changes

review
9f6ab10

jkotas approved these changes Sep 22, 2024
View reviewed changes

jkotas merged commit 619d4b3 into dotnet:mainSep 22, 2024

build-analysisBot mentioned this pull request Sep 22, 2024
Test failure: Assertion failed 'likelihood <= 1.0' #108100
Closed

jkotas mentioned this pull request Sep 22, 2024
Delete unused RedirectFunctor abstraction #108113
Merged

kasperk81 deleted the patch-5 branch September 23, 2024 23:05

sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
delete deadcode from nsutilpriv.h (dotnet#108104)
a523e97

github-actionsBot locked and limited conversation to collaborators Oct 24, 2024

ghost added the area-VM-coreclr label Sep 21, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Sep 21, 2024

jkotas reviewed Sep 21, 2024
View reviewed changes

kasperk81 changed the title ~~fix a typo~~delete deadcode from nsutilpriv.hSep 21, 2024

jkotas reviewed Sep 22, 2024
View reviewed changes

kasperk81 force-pushed the patch-5 branch from 62f0baa to 17bf075Compare September 22, 2024 01:07

build-analysisBot mentioned this pull request Sep 22, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

kasperk81 force-pushed the patch-5 branch 4 times, most recently from 255b288 to 47c3cfbCompare September 22, 2024 10:39

delete deadcode from nsutilpriv.h
7f94b28

kasperk81 force-pushed the patch-5 branch from 47c3cfb to 7f94b28Compare September 22, 2024 14:22

jkotas reviewed Sep 22, 2024
View reviewed changes

review
9f6ab10

jkotas approved these changes Sep 22, 2024
View reviewed changes

jkotas merged commit 619d4b3 into dotnet:mainSep 22, 2024

build-analysisBot mentioned this pull request Sep 22, 2024
Test failure: Assertion failed 'likelihood <= 1.0' #108100
Closed

jkotas mentioned this pull request Sep 22, 2024
Delete unused RedirectFunctor abstraction #108113
Merged

kasperk81 deleted the patch-5 branch September 23, 2024 23:05

sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
delete deadcode from nsutilpriv.h (dotnet#108104)
a523e97

github-actionsBot locked and limited conversation to collaborators Oct 24, 2024

ghost added the area-VM-coreclr label Sep 21, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Sep 21, 2024

jkotas reviewed Sep 21, 2024
View reviewed changes

kasperk81 changed the title ~~fix a typo~~delete deadcode from nsutilpriv.hSep 21, 2024

jkotas reviewed Sep 22, 2024
View reviewed changes

kasperk81 force-pushed the patch-5 branch from 62f0baa to 17bf075Compare September 22, 2024 01:07

build-analysisBot mentioned this pull request Sep 22, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

kasperk81 force-pushed the patch-5 branch 4 times, most recently from 255b288 to 47c3cfbCompare September 22, 2024 10:39

delete deadcode from nsutilpriv.h
7f94b28

kasperk81 force-pushed the patch-5 branch from 47c3cfb to 7f94b28Compare September 22, 2024 14:22

jkotas reviewed Sep 22, 2024
View reviewed changes

review
9f6ab10

jkotas approved these changes Sep 22, 2024
View reviewed changes

jkotas merged commit 619d4b3 into dotnet:mainSep 22, 2024

build-analysisBot mentioned this pull request Sep 22, 2024
Test failure: Assertion failed 'likelihood <= 1.0' #108100
Closed

jkotas mentioned this pull request Sep 22, 2024
Delete unused RedirectFunctor abstraction #108113
Merged

kasperk81 deleted the patch-5 branch September 23, 2024 23:05

sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
delete deadcode from nsutilpriv.h (dotnet#108104)
a523e97

github-actionsBot locked and limited conversation to collaborators Oct 24, 2024

ghost added the area-VM-coreclr label Sep 21, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Sep 21, 2024

jkotas reviewed Sep 21, 2024
View reviewed changes

kasperk81 changed the title ~~fix a typo~~delete deadcode from nsutilpriv.hSep 21, 2024

jkotas reviewed Sep 22, 2024
View reviewed changes

kasperk81 force-pushed the patch-5 branch from 62f0baa to 17bf075Compare September 22, 2024 01:07

build-analysisBot mentioned this pull request Sep 22, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

kasperk81 force-pushed the patch-5 branch 4 times, most recently from 255b288 to 47c3cfbCompare September 22, 2024 10:39

delete deadcode from nsutilpriv.h
7f94b28

kasperk81 force-pushed the patch-5 branch from 47c3cfb to 7f94b28Compare September 22, 2024 14:22

jkotas reviewed Sep 22, 2024
View reviewed changes

review
9f6ab10

jkotas approved these changes Sep 22, 2024
View reviewed changes

jkotas merged commit 619d4b3 into dotnet:mainSep 22, 2024

build-analysisBot mentioned this pull request Sep 22, 2024
Test failure: Assertion failed 'likelihood <= 1.0' #108100
Closed

jkotas mentioned this pull request Sep 22, 2024
Delete unused RedirectFunctor abstraction #108113
Merged

kasperk81 deleted the patch-5 branch September 23, 2024 23:05

sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
delete deadcode from nsutilpriv.h (dotnet#108104)
a523e97

github-actionsBot locked and limited conversation to collaborators Oct 24, 2024

ghost added the area-VM-coreclr label Sep 21, 2024

dotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Sep 21, 2024

jkotas reviewed Sep 21, 2024
View reviewed changes

kasperk81 changed the title ~~fix a typo~~delete deadcode from nsutilpriv.hSep 21, 2024

jkotas reviewed Sep 22, 2024
View reviewed changes

kasperk81 force-pushed the patch-5 branch from 62f0baa to 17bf075Compare September 22, 2024 01:07

build-analysisBot mentioned this pull request Sep 22, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

kasperk81 force-pushed the patch-5 branch 4 times, most recently from 255b288 to 47c3cfbCompare September 22, 2024 10:39

delete deadcode from nsutilpriv.h
7f94b28

kasperk81 force-pushed the patch-5 branch from 47c3cfb to 7f94b28Compare September 22, 2024 14:22

jkotas reviewed Sep 22, 2024
View reviewed changes

review
9f6ab10

jkotas approved these changes Sep 22, 2024
View reviewed changes

jkotas merged commit 619d4b3 into dotnet:mainSep 22, 2024

build-analysisBot mentioned this pull request Sep 22, 2024
Test failure: Assertion failed 'likelihood <= 1.0' #108100
Closed

jkotas mentioned this pull request Sep 22, 2024
Delete unused RedirectFunctor abstraction #108113
Merged

kasperk81 deleted the patch-5 branch September 23, 2024 23:05

sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
delete deadcode from nsutilpriv.h (dotnet#108104)
a523e97

github-actionsBot locked and limited conversation to collaborators Oct 24, 2024

-#ifdef_PREFAST_
-// need to set ptr=NULL so we don't get a build error because ptr isn't inited in a couple cases
-#defineMAKE_FULLY_QUALIFIED_MEMBER_NAME(ptr, pszNameSpace, pszClassName, pszMemberName, pszSig) ptr=NULL;
-#else//_PREFAST_

Uh oh!

Conversation

kasperk81 commented Sep 21, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Sep 21, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

kasperk81 commented Sep 21, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Sep 21, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

kasperk81 commented Sep 21, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Sep 21, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jkotas left a comment

kasperk81 commented Sep 21, 2024•
edited
Loading

kasperk81 commented Sep 21, 2024•
edited
Loading

kasperk81 commented Sep 21, 2024•
edited
Loading

kasperk81 commented Sep 21, 2024•
edited
Loading