Misc cleanup of VM threading code - #108171

Merged
jkotas merged 1 commit into
dotnet:mainfrom
jkotas:ApartmentState
Sep 24, 2024
Merged

Misc cleanup of VM threading code#108171
jkotas merged 1 commit into
dotnet:mainfrom
jkotas:ApartmentState

Conversation

@jkotas

@jkotasjkotas commented Sep 24, 2024

Copy link
Copy Markdown
Member
  • Delete special-casing of thread finalizer
  • Factor out Get/SetApartment of unstarted threads
  • Delete some dead code
  • Fix comments

@jkotas
Misc cleanup of VM threading code
a361b8c
- Delete special-casing of thread finalizer
- Factor out Get/SetApartment of unstarted threads
- Delete some dead code
- Fix comments
@dotnet-policy-service

dotnet-policy-serviceBot commented Sep 24, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

jkotas
jkotas commented Sep 24, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
{
_mayNeedResetForThreadPool = true;
}
_mayNeedResetForThreadPool = true;

@jkotasjkotasSep 24, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not handling the case of finalizer threads.

Comment threadsrc/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Thread.NativeAot.Windows.cs
{
public sealed partial class Thread
{
[ThreadStatic]

@jkotasjkotasSep 24, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code

Comment threadsrc/coreclr/vm/finalizerthread.cpp

LOG((LF_GC, LL_INFO10, "Finalizer thread starting...\n"));

#if defined(FEATURE_COMINTEROP_APARTMENT_SUPPORT) && !defined(FEATURE_COMINTEROP)

@jkotasjkotasSep 24, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition was always false.

Comment threadsrc/coreclr/vm/threads.cpp
}
CONTRACTL_END;

// This method can be called on current thread only

@jkotasjkotasSep 24, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the non-current thread callers to use SetApartmentOfUnstartedThread

@jkotas

jkotas commented Sep 24, 2024

Copy link
Copy Markdown
MemberAuthor

Motivated by HMF->QCall conversion codereviews

@jkotas

jkotas commented Sep 24, 2024

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-coreclr outerloop

@azure-pipelines

azure-pipelinesBot commented Sep 24, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Sep 24, 2024
Open
Open
Open
Closed
@jkotas
jkotas merged commit 23b3d41 into dotnet:mainSep 24, 2024
@JulieLeeMSFT

JulieLeeMSFT commented Sep 24, 2024

Copy link
Copy Markdown
Member

@jkotas, all test legs failed in runtime-coreclr libraries-jitstress/20240924.1. PTAL.

@jkotas
jkotas deleted the ApartmentState branch September 24, 2024 17:57
@jkotas

jkotas commented Sep 24, 2024

Copy link
Copy Markdown
MemberAuthor

I have looked at some of the failures. The failures are either asserts in the JIT

Assertion failed '!"Inconsistent profile data"' in 'Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.Lexer:LexXmlDocCommentLeadingTrivia(byref):this' during 'Recognize Switch' (IL size 730; hash 0xe3243bf9; Tier1)

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-a4b3f25a20cf46ce8d/System.Text.RegularExpressions.Tests/1/console.2ae64c75.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A02%3A37Z&ske=2024-09-24T19%3A02%3A37Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A02%3A37Z&se=2024-09-24T19%3A02%3A37Z&sr=c&sp=r&sig=e35ir71XB%2BNVh0DzOhQSt7pwGDj9BrlFxUC2QGob%2BAk%3D

Or asserts/crashes in libraries that suggest bad codegen:

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-5f622e8df388454594/System.Text.Json.Tests/1/console.dbf8d227.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A04%3A02Z&ske=2024-09-24T19%3A04%3A02Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A04%3A02Z&se=2024-09-24T19%3A04%3A02Z&sr=c&sp=r&sig=bL%2BAUD%2Bxfmt5N6ov%2F8w6uwftzRUy0AkdDHRY%2FSGXwbI%3D

@jkotas

jkotas commented Sep 24, 2024

Copy link
Copy Markdown
MemberAuthor

Similar set of failures was hit in https://dev.azure.com/dnceng-public/public/_build/results?buildId=815402&view=ms.vss-test-web.build-test-results-tab that did not include this change.

@LoopedBard3LoopedBard3 mentioned this pull request Sep 26, 2024
Closed
@JulieLeeMSFT

JulieLeeMSFT commented Sep 27, 2024

Copy link
Copy Markdown
Member

I have looked at some of the failures. The failures are either asserts in the JIT

Assertion failed '!"Inconsistent profile data"' in 'Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.Lexer:LexXmlDocCommentLeadingTrivia(byref):this' during 'Recognize Switch' (IL size 730; hash 0xe3243bf9; Tier1)

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-a4b3f25a20cf46ce8d/System.Text.RegularExpressions.Tests/1/console.2ae64c75.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A02%3A37Z&ske=2024-09-24T19%3A02%3A37Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A02%3A37Z&se=2024-09-24T19%3A02%3A37Z&sr=c&sp=r&sig=e35ir71XB%2BNVh0DzOhQSt7pwGDj9BrlFxUC2QGob%2BAk%3D

Or asserts/crashes in libraries that suggest bad codegen:

https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-5f622e8df388454594/System.Text.Json.Tests/1/console.dbf8d227.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A04%3A02Z&ske=2024-09-24T19%3A04%3A02Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A04%3A02Z&se=2024-09-24T19%3A04%3A02Z&sr=c&sp=r&sig=bL%2BAUD%2Bxfmt5N6ov%2F8w6uwftzRUy0AkdDHRY%2FSGXwbI%3D

@EgorBo, PTAL.

@jkotas

jkotas commented Sep 27, 2024

Copy link
Copy Markdown
MemberAuthor

These failures should be fixed by #108169

sirntar pushed a commit to sirntar/runtime that referenced this pull request Sep 30, 2024
@jkotas@sirntar
Misc cleanup of VM threading code (dotnet#108171)
92783de
- Delete special-casing of thread finalizer
- Factor out Get/SetApartment of unstarted threads
- Delete some dead code
- Fix comments
This was referenced Oct 2, 2024
Open
Open
@kotlarmiloskotlarmilos mentioned this pull request Oct 2, 2024
Open
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Oct 28, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

@jkotasjkotas

Labels

area-System.Threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jkotas@JulieLeeMSFT@AaronRobinsonMSFT
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Misc cleanup of VM threading code - #108171
Merged
jkotas merged 1 commit into
dotnet:mainfrom 
jkotas:ApartmentState
Sep 24, 2024
Merged
Misc cleanup of VM threading code#108171
jkotas merged 1 commit into
dotnet:mainfrom 
jkotas:ApartmentState
Conversation
@jkotas
@jkotasjkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

Member
  • Delete special-casing of thread finalizer
  • Factor out Get/SetApartment of unstarted threads
  • Delete some dead code
  • Fix comments
@jkotas
Misc cleanup of VM threading code
a361b8c
- Delete special-casing of thread finalizer
- Factor out Get/SetApartment of unstarted threads
- Delete some dead code
- Fix comments
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Sep 24, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
jkotas
jkotas
commented
Sep 24, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
 {
 _mayNeedResetForThreadPool = true;
 }
 _mayNeedResetForThreadPool = true;
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not handling the case of finalizer threads.
Comment threadsrc/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Thread.NativeAot.Windows.cs
{
 public sealed partial class Thread
 {
 [ThreadStatic]
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code
Comment threadsrc/coreclr/vm/finalizerthread.cpp

 LOG((LF_GC, LL_INFO10, "Finalizer thread starting...\n"));

#if defined(FEATURE_COMINTEROP_APARTMENT_SUPPORT) && !defined(FEATURE_COMINTEROP)
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition was always false.
Comment threadsrc/coreclr/vm/threads.cpp
 }
 CONTRACTL_END;

 // This method can be called on current thread only
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the non-current thread callers to use SetApartmentOfUnstartedThread
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Motivated by HMF->QCall conversion codereviews
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Sep 24, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Sep 24, 2024

Open


Open


Open


Closed

@jkotas
jkotas
merged commit 23b3d41
into
dotnet:mainSep 24, 2024
@JulieLeeMSFT
JulieLeeMSFT
commented
Sep 24, 2024

Copy link


Copy Markdown

Member
@jkotas, all test legs failed in runtime-coreclr libraries-jitstress/20240924.1. PTAL.
@jkotas
jkotas
deleted the

ApartmentState

branch
September 24, 2024 17:57
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
I have looked at some of the failures. The failures are either asserts in the JIT
 Assertion failed '!"Inconsistent profile data"' in 'Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.Lexer:LexXmlDocCommentLeadingTrivia(byref):this' during 'Recognize Switch' (IL size 730; hash 0xe3243bf9; Tier1)
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-a4b3f25a20cf46ce8d/System.Text.RegularExpressions.Tests/1/console.2ae64c75.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A02%3A37Z&ske=2024-09-24T19%3A02%3A37Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A02%3A37Z&se=2024-09-24T19%3A02%3A37Z&sr=c&sp=r&sig=e35ir71XB%2BNVh0DzOhQSt7pwGDj9BrlFxUC2QGob%2BAk%3D
Or asserts/crashes in libraries that suggest bad codegen:
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-5f622e8df388454594/System.Text.Json.Tests/1/console.dbf8d227.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A04%3A02Z&ske=2024-09-24T19%3A04%3A02Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A04%3A02Z&se=2024-09-24T19%3A04%3A02Z&sr=c&sp=r&sig=bL%2BAUD%2Bxfmt5N6ov%2F8w6uwftzRUy0AkdDHRY%2FSGXwbI%3D
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Similar set of failures was hit in https://dev.azure.com/dnceng-public/public/_build/results?buildId=815402&view=ms.vss-test-web.build-test-results-tab that did not include this change.
@LoopedBard3LoopedBard3
mentioned this pull request
Sep 26, 2024

Closed

@JulieLeeMSFT
JulieLeeMSFT
commented
Sep 27, 2024

Copy link


Copy Markdown

Member
I have looked at some of the failures. The failures are either asserts in the JIT
 Assertion failed '!"Inconsistent profile data"' in 'Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.Lexer:LexXmlDocCommentLeadingTrivia(byref):this' during 'Recognize Switch' (IL size 730; hash 0xe3243bf9; Tier1)
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-a4b3f25a20cf46ce8d/System.Text.RegularExpressions.Tests/1/console.2ae64c75.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A02%3A37Z&ske=2024-09-24T19%3A02%3A37Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A02%3A37Z&se=2024-09-24T19%3A02%3A37Z&sr=c&sp=r&sig=e35ir71XB%2BNVh0DzOhQSt7pwGDj9BrlFxUC2QGob%2BAk%3D
Or asserts/crashes in libraries that suggest bad codegen:
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-5f622e8df388454594/System.Text.Json.Tests/1/console.dbf8d227.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A04%3A02Z&ske=2024-09-24T19%3A04%3A02Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A04%3A02Z&se=2024-09-24T19%3A04%3A02Z&sr=c&sp=r&sig=bL%2BAUD%2Bxfmt5N6ov%2F8w6uwftzRUy0AkdDHRY%2FSGXwbI%3D
@EgorBo, PTAL.
@jkotas
jkotas
commented
Sep 27, 2024

Copy link


Copy Markdown

MemberAuthor
These failures should be fixed by #108169
sirntar pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
@jkotas@sirntar
Misc cleanup of VM threading code (dotnet#108171)
92783de
- Delete special-casing of thread finalizer
- Factor out Get/SetApartment of unstarted threads
- Delete some dead code
- Fix comments

This was referenced Oct 2, 2024

Open


Open

@kotlarmiloskotlarmilos
mentioned this pull request
Oct 2, 2024

Open

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Oct 28, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

@jkotasjkotas

Labels

area-System.Threading

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jkotas@JulieLeeMSFT@AaronRobinsonMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Misc cleanup of VM threading code - #108171
Merged
jkotas merged 1 commit into
dotnet:mainfrom 
jkotas:ApartmentState
Sep 24, 2024
Merged
Misc cleanup of VM threading code#108171
jkotas merged 1 commit into
dotnet:mainfrom 
jkotas:ApartmentState
Conversation
@jkotas
@jkotasjkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

Member
  • Delete special-casing of thread finalizer
  • Factor out Get/SetApartment of unstarted threads
  • Delete some dead code
  • Fix comments
@jkotas
Misc cleanup of VM threading code
a361b8c
- Delete special-casing of thread finalizer
- Factor out Get/SetApartment of unstarted threads
- Delete some dead code
- Fix comments
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Sep 24, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
jkotas
jkotas
commented
Sep 24, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
 {
 _mayNeedResetForThreadPool = true;
 }
 _mayNeedResetForThreadPool = true;
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not handling the case of finalizer threads.
Comment threadsrc/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Thread.NativeAot.Windows.cs
{
 public sealed partial class Thread
 {
 [ThreadStatic]
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code
Comment threadsrc/coreclr/vm/finalizerthread.cpp

 LOG((LF_GC, LL_INFO10, "Finalizer thread starting...\n"));

#if defined(FEATURE_COMINTEROP_APARTMENT_SUPPORT) && !defined(FEATURE_COMINTEROP)
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition was always false.
Comment threadsrc/coreclr/vm/threads.cpp
 }
 CONTRACTL_END;

 // This method can be called on current thread only
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the non-current thread callers to use SetApartmentOfUnstartedThread
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Motivated by HMF->QCall conversion codereviews
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Sep 24, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Sep 24, 2024

Open


Open


Open


Closed

@jkotas
jkotas
merged commit 23b3d41
into
dotnet:mainSep 24, 2024
@JulieLeeMSFT
JulieLeeMSFT
commented
Sep 24, 2024

Copy link


Copy Markdown

Member
@jkotas, all test legs failed in runtime-coreclr libraries-jitstress/20240924.1. PTAL.
@jkotas
jkotas
deleted the

ApartmentState

branch
September 24, 2024 17:57
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
I have looked at some of the failures. The failures are either asserts in the JIT
 Assertion failed '!"Inconsistent profile data"' in 'Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.Lexer:LexXmlDocCommentLeadingTrivia(byref):this' during 'Recognize Switch' (IL size 730; hash 0xe3243bf9; Tier1)
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-a4b3f25a20cf46ce8d/System.Text.RegularExpressions.Tests/1/console.2ae64c75.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A02%3A37Z&ske=2024-09-24T19%3A02%3A37Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A02%3A37Z&se=2024-09-24T19%3A02%3A37Z&sr=c&sp=r&sig=e35ir71XB%2BNVh0DzOhQSt7pwGDj9BrlFxUC2QGob%2BAk%3D
Or asserts/crashes in libraries that suggest bad codegen:
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-5f622e8df388454594/System.Text.Json.Tests/1/console.dbf8d227.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A04%3A02Z&ske=2024-09-24T19%3A04%3A02Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A04%3A02Z&se=2024-09-24T19%3A04%3A02Z&sr=c&sp=r&sig=bL%2BAUD%2Bxfmt5N6ov%2F8w6uwftzRUy0AkdDHRY%2FSGXwbI%3D
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Similar set of failures was hit in https://dev.azure.com/dnceng-public/public/_build/results?buildId=815402&view=ms.vss-test-web.build-test-results-tab that did not include this change.
@LoopedBard3LoopedBard3
mentioned this pull request
Sep 26, 2024

Closed

@JulieLeeMSFT
JulieLeeMSFT
commented
Sep 27, 2024

Copy link


Copy Markdown

Member
I have looked at some of the failures. The failures are either asserts in the JIT
 Assertion failed '!"Inconsistent profile data"' in 'Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.Lexer:LexXmlDocCommentLeadingTrivia(byref):this' during 'Recognize Switch' (IL size 730; hash 0xe3243bf9; Tier1)
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-a4b3f25a20cf46ce8d/System.Text.RegularExpressions.Tests/1/console.2ae64c75.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A02%3A37Z&ske=2024-09-24T19%3A02%3A37Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A02%3A37Z&se=2024-09-24T19%3A02%3A37Z&sr=c&sp=r&sig=e35ir71XB%2BNVh0DzOhQSt7pwGDj9BrlFxUC2QGob%2BAk%3D
Or asserts/crashes in libraries that suggest bad codegen:
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-5f622e8df388454594/System.Text.Json.Tests/1/console.dbf8d227.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A04%3A02Z&ske=2024-09-24T19%3A04%3A02Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A04%3A02Z&se=2024-09-24T19%3A04%3A02Z&sr=c&sp=r&sig=bL%2BAUD%2Bxfmt5N6ov%2F8w6uwftzRUy0AkdDHRY%2FSGXwbI%3D
@EgorBo, PTAL.
@jkotas
jkotas
commented
Sep 27, 2024

Copy link


Copy Markdown

MemberAuthor
These failures should be fixed by #108169
sirntar pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
@jkotas@sirntar
Misc cleanup of VM threading code (dotnet#108171)
92783de
- Delete special-casing of thread finalizer
- Factor out Get/SetApartment of unstarted threads
- Delete some dead code
- Fix comments

This was referenced Oct 2, 2024

Open


Open

@kotlarmiloskotlarmilos
mentioned this pull request
Oct 2, 2024

Open

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Oct 28, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

@jkotasjkotas

Labels

area-System.Threading

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jkotas@JulieLeeMSFT@AaronRobinsonMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Misc cleanup of VM threading code - #108171
Merged
jkotas merged 1 commit into
dotnet:mainfrom 
jkotas:ApartmentState
Sep 24, 2024
Merged
Misc cleanup of VM threading code#108171
jkotas merged 1 commit into
dotnet:mainfrom 
jkotas:ApartmentState
Conversation
@jkotas
@jkotasjkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

Member
  • Delete special-casing of thread finalizer
  • Factor out Get/SetApartment of unstarted threads
  • Delete some dead code
  • Fix comments
@jkotas
Misc cleanup of VM threading code
a361b8c
- Delete special-casing of thread finalizer
- Factor out Get/SetApartment of unstarted threads
- Delete some dead code
- Fix comments
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Sep 24, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
jkotas
jkotas
commented
Sep 24, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
 {
 _mayNeedResetForThreadPool = true;
 }
 _mayNeedResetForThreadPool = true;
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not handling the case of finalizer threads.
Comment threadsrc/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Thread.NativeAot.Windows.cs
{
 public sealed partial class Thread
 {
 [ThreadStatic]
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code
Comment threadsrc/coreclr/vm/finalizerthread.cpp

 LOG((LF_GC, LL_INFO10, "Finalizer thread starting...\n"));

#if defined(FEATURE_COMINTEROP_APARTMENT_SUPPORT) && !defined(FEATURE_COMINTEROP)
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition was always false.
Comment threadsrc/coreclr/vm/threads.cpp
 }
 CONTRACTL_END;

 // This method can be called on current thread only
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the non-current thread callers to use SetApartmentOfUnstartedThread
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Motivated by HMF->QCall conversion codereviews
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Sep 24, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Sep 24, 2024

Open


Open


Open


Closed

@jkotas
jkotas
merged commit 23b3d41
into
dotnet:mainSep 24, 2024
@JulieLeeMSFT
JulieLeeMSFT
commented
Sep 24, 2024

Copy link


Copy Markdown

Member
@jkotas, all test legs failed in runtime-coreclr libraries-jitstress/20240924.1. PTAL.
@jkotas
jkotas
deleted the

ApartmentState

branch
September 24, 2024 17:57
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
I have looked at some of the failures. The failures are either asserts in the JIT
 Assertion failed '!"Inconsistent profile data"' in 'Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.Lexer:LexXmlDocCommentLeadingTrivia(byref):this' during 'Recognize Switch' (IL size 730; hash 0xe3243bf9; Tier1)
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-a4b3f25a20cf46ce8d/System.Text.RegularExpressions.Tests/1/console.2ae64c75.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A02%3A37Z&ske=2024-09-24T19%3A02%3A37Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A02%3A37Z&se=2024-09-24T19%3A02%3A37Z&sr=c&sp=r&sig=e35ir71XB%2BNVh0DzOhQSt7pwGDj9BrlFxUC2QGob%2BAk%3D
Or asserts/crashes in libraries that suggest bad codegen:
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-5f622e8df388454594/System.Text.Json.Tests/1/console.dbf8d227.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A04%3A02Z&ske=2024-09-24T19%3A04%3A02Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A04%3A02Z&se=2024-09-24T19%3A04%3A02Z&sr=c&sp=r&sig=bL%2BAUD%2Bxfmt5N6ov%2F8w6uwftzRUy0AkdDHRY%2FSGXwbI%3D
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Similar set of failures was hit in https://dev.azure.com/dnceng-public/public/_build/results?buildId=815402&view=ms.vss-test-web.build-test-results-tab that did not include this change.
@LoopedBard3LoopedBard3
mentioned this pull request
Sep 26, 2024

Closed

@JulieLeeMSFT
JulieLeeMSFT
commented
Sep 27, 2024

Copy link


Copy Markdown

Member
I have looked at some of the failures. The failures are either asserts in the JIT
 Assertion failed '!"Inconsistent profile data"' in 'Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.Lexer:LexXmlDocCommentLeadingTrivia(byref):this' during 'Recognize Switch' (IL size 730; hash 0xe3243bf9; Tier1)
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-a4b3f25a20cf46ce8d/System.Text.RegularExpressions.Tests/1/console.2ae64c75.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A02%3A37Z&ske=2024-09-24T19%3A02%3A37Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A02%3A37Z&se=2024-09-24T19%3A02%3A37Z&sr=c&sp=r&sig=e35ir71XB%2BNVh0DzOhQSt7pwGDj9BrlFxUC2QGob%2BAk%3D
Or asserts/crashes in libraries that suggest bad codegen:
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-5f622e8df388454594/System.Text.Json.Tests/1/console.dbf8d227.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A04%3A02Z&ske=2024-09-24T19%3A04%3A02Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A04%3A02Z&se=2024-09-24T19%3A04%3A02Z&sr=c&sp=r&sig=bL%2BAUD%2Bxfmt5N6ov%2F8w6uwftzRUy0AkdDHRY%2FSGXwbI%3D
@EgorBo, PTAL.
@jkotas
jkotas
commented
Sep 27, 2024

Copy link


Copy Markdown

MemberAuthor
These failures should be fixed by #108169
sirntar pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
@jkotas@sirntar
Misc cleanup of VM threading code (dotnet#108171)
92783de
- Delete special-casing of thread finalizer
- Factor out Get/SetApartment of unstarted threads
- Delete some dead code
- Fix comments

This was referenced Oct 2, 2024

Open


Open

@kotlarmiloskotlarmilos
mentioned this pull request
Oct 2, 2024

Open

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Oct 28, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

@jkotasjkotas

Labels

area-System.Threading

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jkotas@JulieLeeMSFT@AaronRobinsonMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Misc cleanup of VM threading code - #108171
Merged
jkotas merged 1 commit into
dotnet:mainfrom 
jkotas:ApartmentState
Sep 24, 2024
Merged
Misc cleanup of VM threading code#108171
jkotas merged 1 commit into
dotnet:mainfrom 
jkotas:ApartmentState
Conversation
@jkotas
@jkotasjkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

Member
  • Delete special-casing of thread finalizer
  • Factor out Get/SetApartment of unstarted threads
  • Delete some dead code
  • Fix comments
@jkotas
Misc cleanup of VM threading code
a361b8c
- Delete special-casing of thread finalizer
- Factor out Get/SetApartment of unstarted threads
- Delete some dead code
- Fix comments
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Sep 24, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
jkotas
jkotas
commented
Sep 24, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
 {
 _mayNeedResetForThreadPool = true;
 }
 _mayNeedResetForThreadPool = true;
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not handling the case of finalizer threads.
Comment threadsrc/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Thread.NativeAot.Windows.cs
{
 public sealed partial class Thread
 {
 [ThreadStatic]
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code
Comment threadsrc/coreclr/vm/finalizerthread.cpp

 LOG((LF_GC, LL_INFO10, "Finalizer thread starting...\n"));

#if defined(FEATURE_COMINTEROP_APARTMENT_SUPPORT) && !defined(FEATURE_COMINTEROP)
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition was always false.
Comment threadsrc/coreclr/vm/threads.cpp
 }
 CONTRACTL_END;

 // This method can be called on current thread only
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the non-current thread callers to use SetApartmentOfUnstartedThread
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Motivated by HMF->QCall conversion codereviews
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Sep 24, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Sep 24, 2024

Open


Open


Open


Closed

@jkotas
jkotas
merged commit 23b3d41
into
dotnet:mainSep 24, 2024
@JulieLeeMSFT
JulieLeeMSFT
commented
Sep 24, 2024

Copy link


Copy Markdown

Member
@jkotas, all test legs failed in runtime-coreclr libraries-jitstress/20240924.1. PTAL.
@jkotas
jkotas
deleted the

ApartmentState

branch
September 24, 2024 17:57
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
I have looked at some of the failures. The failures are either asserts in the JIT
 Assertion failed '!"Inconsistent profile data"' in 'Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.Lexer:LexXmlDocCommentLeadingTrivia(byref):this' during 'Recognize Switch' (IL size 730; hash 0xe3243bf9; Tier1)
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-a4b3f25a20cf46ce8d/System.Text.RegularExpressions.Tests/1/console.2ae64c75.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A02%3A37Z&ske=2024-09-24T19%3A02%3A37Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A02%3A37Z&se=2024-09-24T19%3A02%3A37Z&sr=c&sp=r&sig=e35ir71XB%2BNVh0DzOhQSt7pwGDj9BrlFxUC2QGob%2BAk%3D
Or asserts/crashes in libraries that suggest bad codegen:
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-5f622e8df388454594/System.Text.Json.Tests/1/console.dbf8d227.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A04%3A02Z&ske=2024-09-24T19%3A04%3A02Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A04%3A02Z&se=2024-09-24T19%3A04%3A02Z&sr=c&sp=r&sig=bL%2BAUD%2Bxfmt5N6ov%2F8w6uwftzRUy0AkdDHRY%2FSGXwbI%3D
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Similar set of failures was hit in https://dev.azure.com/dnceng-public/public/_build/results?buildId=815402&view=ms.vss-test-web.build-test-results-tab that did not include this change.
@LoopedBard3LoopedBard3
mentioned this pull request
Sep 26, 2024

Closed

@JulieLeeMSFT
JulieLeeMSFT
commented
Sep 27, 2024

Copy link


Copy Markdown

Member
I have looked at some of the failures. The failures are either asserts in the JIT
 Assertion failed '!"Inconsistent profile data"' in 'Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.Lexer:LexXmlDocCommentLeadingTrivia(byref):this' during 'Recognize Switch' (IL size 730; hash 0xe3243bf9; Tier1)
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-a4b3f25a20cf46ce8d/System.Text.RegularExpressions.Tests/1/console.2ae64c75.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A02%3A37Z&ske=2024-09-24T19%3A02%3A37Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A02%3A37Z&se=2024-09-24T19%3A02%3A37Z&sr=c&sp=r&sig=e35ir71XB%2BNVh0DzOhQSt7pwGDj9BrlFxUC2QGob%2BAk%3D
Or asserts/crashes in libraries that suggest bad codegen:
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-5f622e8df388454594/System.Text.Json.Tests/1/console.dbf8d227.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A04%3A02Z&ske=2024-09-24T19%3A04%3A02Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A04%3A02Z&se=2024-09-24T19%3A04%3A02Z&sr=c&sp=r&sig=bL%2BAUD%2Bxfmt5N6ov%2F8w6uwftzRUy0AkdDHRY%2FSGXwbI%3D
@EgorBo, PTAL.
@jkotas
jkotas
commented
Sep 27, 2024

Copy link


Copy Markdown

MemberAuthor
These failures should be fixed by #108169
sirntar pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
@jkotas@sirntar
Misc cleanup of VM threading code (dotnet#108171)
92783de
- Delete special-casing of thread finalizer
- Factor out Get/SetApartment of unstarted threads
- Delete some dead code
- Fix comments

This was referenced Oct 2, 2024

Open


Open

@kotlarmiloskotlarmilos
mentioned this pull request
Oct 2, 2024

Open

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Oct 28, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

@jkotasjkotas

Labels

area-System.Threading

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jkotas@JulieLeeMSFT@AaronRobinsonMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Misc cleanup of VM threading code - #108171
Merged
jkotas merged 1 commit into
dotnet:mainfrom 
jkotas:ApartmentState
Sep 24, 2024
Merged
Misc cleanup of VM threading code#108171
jkotas merged 1 commit into
dotnet:mainfrom 
jkotas:ApartmentState
Conversation
@jkotas
@jkotasjkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

Member
  • Delete special-casing of thread finalizer
  • Factor out Get/SetApartment of unstarted threads
  • Delete some dead code
  • Fix comments
@jkotas
Misc cleanup of VM threading code
a361b8c
- Delete special-casing of thread finalizer
- Factor out Get/SetApartment of unstarted threads
- Delete some dead code
- Fix comments
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Sep 24, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
jkotas
jkotas
commented
Sep 24, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
 {
 _mayNeedResetForThreadPool = true;
 }
 _mayNeedResetForThreadPool = true;
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not handling the case of finalizer threads.
Comment threadsrc/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Thread.NativeAot.Windows.cs
{
 public sealed partial class Thread
 {
 [ThreadStatic]
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code
Comment threadsrc/coreclr/vm/finalizerthread.cpp

 LOG((LF_GC, LL_INFO10, "Finalizer thread starting...\n"));

#if defined(FEATURE_COMINTEROP_APARTMENT_SUPPORT) && !defined(FEATURE_COMINTEROP)
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition was always false.
Comment threadsrc/coreclr/vm/threads.cpp
 }
 CONTRACTL_END;

 // This method can be called on current thread only
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the non-current thread callers to use SetApartmentOfUnstartedThread
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Motivated by HMF->QCall conversion codereviews
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Sep 24, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Sep 24, 2024

Open


Open


Open


Closed

@jkotas
jkotas
merged commit 23b3d41
into
dotnet:mainSep 24, 2024
@JulieLeeMSFT
JulieLeeMSFT
commented
Sep 24, 2024

Copy link


Copy Markdown

Member
@jkotas, all test legs failed in runtime-coreclr libraries-jitstress/20240924.1. PTAL.
@jkotas
jkotas
deleted the

ApartmentState

branch
September 24, 2024 17:57
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
I have looked at some of the failures. The failures are either asserts in the JIT
 Assertion failed '!"Inconsistent profile data"' in 'Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.Lexer:LexXmlDocCommentLeadingTrivia(byref):this' during 'Recognize Switch' (IL size 730; hash 0xe3243bf9; Tier1)
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-a4b3f25a20cf46ce8d/System.Text.RegularExpressions.Tests/1/console.2ae64c75.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A02%3A37Z&ske=2024-09-24T19%3A02%3A37Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A02%3A37Z&se=2024-09-24T19%3A02%3A37Z&sr=c&sp=r&sig=e35ir71XB%2BNVh0DzOhQSt7pwGDj9BrlFxUC2QGob%2BAk%3D
Or asserts/crashes in libraries that suggest bad codegen:
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-5f622e8df388454594/System.Text.Json.Tests/1/console.dbf8d227.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A04%3A02Z&ske=2024-09-24T19%3A04%3A02Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A04%3A02Z&se=2024-09-24T19%3A04%3A02Z&sr=c&sp=r&sig=bL%2BAUD%2Bxfmt5N6ov%2F8w6uwftzRUy0AkdDHRY%2FSGXwbI%3D
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Similar set of failures was hit in https://dev.azure.com/dnceng-public/public/_build/results?buildId=815402&view=ms.vss-test-web.build-test-results-tab that did not include this change.
@LoopedBard3LoopedBard3
mentioned this pull request
Sep 26, 2024

Closed

@JulieLeeMSFT
JulieLeeMSFT
commented
Sep 27, 2024

Copy link


Copy Markdown

Member
I have looked at some of the failures. The failures are either asserts in the JIT
 Assertion failed '!"Inconsistent profile data"' in 'Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.Lexer:LexXmlDocCommentLeadingTrivia(byref):this' during 'Recognize Switch' (IL size 730; hash 0xe3243bf9; Tier1)
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-a4b3f25a20cf46ce8d/System.Text.RegularExpressions.Tests/1/console.2ae64c75.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A02%3A37Z&ske=2024-09-24T19%3A02%3A37Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A02%3A37Z&se=2024-09-24T19%3A02%3A37Z&sr=c&sp=r&sig=e35ir71XB%2BNVh0DzOhQSt7pwGDj9BrlFxUC2QGob%2BAk%3D
Or asserts/crashes in libraries that suggest bad codegen:
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-5f622e8df388454594/System.Text.Json.Tests/1/console.dbf8d227.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A04%3A02Z&ske=2024-09-24T19%3A04%3A02Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A04%3A02Z&se=2024-09-24T19%3A04%3A02Z&sr=c&sp=r&sig=bL%2BAUD%2Bxfmt5N6ov%2F8w6uwftzRUy0AkdDHRY%2FSGXwbI%3D
@EgorBo, PTAL.
@jkotas
jkotas
commented
Sep 27, 2024

Copy link


Copy Markdown

MemberAuthor
These failures should be fixed by #108169
sirntar pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
@jkotas@sirntar
Misc cleanup of VM threading code (dotnet#108171)
92783de
- Delete special-casing of thread finalizer
- Factor out Get/SetApartment of unstarted threads
- Delete some dead code
- Fix comments

This was referenced Oct 2, 2024

Open


Open

@kotlarmiloskotlarmilos
mentioned this pull request
Oct 2, 2024

Open

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Oct 28, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

@jkotasjkotas

Labels

area-System.Threading

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jkotas@JulieLeeMSFT@AaronRobinsonMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Misc cleanup of VM threading code - #108171
Merged
jkotas merged 1 commit into
dotnet:mainfrom 
jkotas:ApartmentState
Sep 24, 2024
Merged
Misc cleanup of VM threading code#108171
jkotas merged 1 commit into
dotnet:mainfrom 
jkotas:ApartmentState
Conversation
@jkotas
@jkotasjkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

Member
  • Delete special-casing of thread finalizer
  • Factor out Get/SetApartment of unstarted threads
  • Delete some dead code
  • Fix comments
@jkotas
Misc cleanup of VM threading code
a361b8c
- Delete special-casing of thread finalizer
- Factor out Get/SetApartment of unstarted threads
- Delete some dead code
- Fix comments
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Sep 24, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
jkotas
jkotas
commented
Sep 24, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
 {
 _mayNeedResetForThreadPool = true;
 }
 _mayNeedResetForThreadPool = true;
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not handling the case of finalizer threads.
Comment threadsrc/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Thread.NativeAot.Windows.cs
{
 public sealed partial class Thread
 {
 [ThreadStatic]
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code
Comment threadsrc/coreclr/vm/finalizerthread.cpp

 LOG((LF_GC, LL_INFO10, "Finalizer thread starting...\n"));

#if defined(FEATURE_COMINTEROP_APARTMENT_SUPPORT) && !defined(FEATURE_COMINTEROP)
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition was always false.
Comment threadsrc/coreclr/vm/threads.cpp
 }
 CONTRACTL_END;

 // This method can be called on current thread only
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the non-current thread callers to use SetApartmentOfUnstartedThread
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Motivated by HMF->QCall conversion codereviews
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Sep 24, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Sep 24, 2024

Open


Open


Open


Closed

@jkotas
jkotas
merged commit 23b3d41
into
dotnet:mainSep 24, 2024
@JulieLeeMSFT
JulieLeeMSFT
commented
Sep 24, 2024

Copy link


Copy Markdown

Member
@jkotas, all test legs failed in runtime-coreclr libraries-jitstress/20240924.1. PTAL.
@jkotas
jkotas
deleted the

ApartmentState

branch
September 24, 2024 17:57
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
I have looked at some of the failures. The failures are either asserts in the JIT
 Assertion failed '!"Inconsistent profile data"' in 'Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.Lexer:LexXmlDocCommentLeadingTrivia(byref):this' during 'Recognize Switch' (IL size 730; hash 0xe3243bf9; Tier1)
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-a4b3f25a20cf46ce8d/System.Text.RegularExpressions.Tests/1/console.2ae64c75.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A02%3A37Z&ske=2024-09-24T19%3A02%3A37Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A02%3A37Z&se=2024-09-24T19%3A02%3A37Z&sr=c&sp=r&sig=e35ir71XB%2BNVh0DzOhQSt7pwGDj9BrlFxUC2QGob%2BAk%3D
Or asserts/crashes in libraries that suggest bad codegen:
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-5f622e8df388454594/System.Text.Json.Tests/1/console.dbf8d227.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A04%3A02Z&ske=2024-09-24T19%3A04%3A02Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A04%3A02Z&se=2024-09-24T19%3A04%3A02Z&sr=c&sp=r&sig=bL%2BAUD%2Bxfmt5N6ov%2F8w6uwftzRUy0AkdDHRY%2FSGXwbI%3D
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Similar set of failures was hit in https://dev.azure.com/dnceng-public/public/_build/results?buildId=815402&view=ms.vss-test-web.build-test-results-tab that did not include this change.
@LoopedBard3LoopedBard3
mentioned this pull request
Sep 26, 2024

Closed

@JulieLeeMSFT
JulieLeeMSFT
commented
Sep 27, 2024

Copy link


Copy Markdown

Member
I have looked at some of the failures. The failures are either asserts in the JIT
 Assertion failed '!"Inconsistent profile data"' in 'Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.Lexer:LexXmlDocCommentLeadingTrivia(byref):this' during 'Recognize Switch' (IL size 730; hash 0xe3243bf9; Tier1)
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-a4b3f25a20cf46ce8d/System.Text.RegularExpressions.Tests/1/console.2ae64c75.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A02%3A37Z&ske=2024-09-24T19%3A02%3A37Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A02%3A37Z&se=2024-09-24T19%3A02%3A37Z&sr=c&sp=r&sig=e35ir71XB%2BNVh0DzOhQSt7pwGDj9BrlFxUC2QGob%2BAk%3D
Or asserts/crashes in libraries that suggest bad codegen:
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-5f622e8df388454594/System.Text.Json.Tests/1/console.dbf8d227.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A04%3A02Z&ske=2024-09-24T19%3A04%3A02Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A04%3A02Z&se=2024-09-24T19%3A04%3A02Z&sr=c&sp=r&sig=bL%2BAUD%2Bxfmt5N6ov%2F8w6uwftzRUy0AkdDHRY%2FSGXwbI%3D
@EgorBo, PTAL.
@jkotas
jkotas
commented
Sep 27, 2024

Copy link


Copy Markdown

MemberAuthor
These failures should be fixed by #108169
sirntar pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
@jkotas@sirntar
Misc cleanup of VM threading code (dotnet#108171)
92783de
- Delete special-casing of thread finalizer
- Factor out Get/SetApartment of unstarted threads
- Delete some dead code
- Fix comments

This was referenced Oct 2, 2024

Open


Open

@kotlarmiloskotlarmilos
mentioned this pull request
Oct 2, 2024

Open

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Oct 28, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

@jkotasjkotas

Labels

area-System.Threading

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jkotas@JulieLeeMSFT@AaronRobinsonMSFT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Misc cleanup of VM threading code - #108171
Merged
jkotas merged 1 commit into
dotnet:mainfrom 
jkotas:ApartmentState
Sep 24, 2024
Merged
Misc cleanup of VM threading code#108171
jkotas merged 1 commit into
dotnet:mainfrom 
jkotas:ApartmentState
Conversation
@jkotas
@jkotasjkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

Member
  • Delete special-casing of thread finalizer
  • Factor out Get/SetApartment of unstarted threads
  • Delete some dead code
  • Fix comments
@jkotas
Misc cleanup of VM threading code
a361b8c
- Delete special-casing of thread finalizer
- Factor out Get/SetApartment of unstarted threads
- Delete some dead code
- Fix comments
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Sep 24, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @mangod9

See info in area-owners.md if you want to be subscribed.
jkotas
jkotas
commented
Sep 24, 2024
View reviewed changes
Comment threadsrc/coreclr/System.Private.CoreLib/src/System/Threading/Thread.CoreCLR.cs
 {
 _mayNeedResetForThreadPool = true;
 }
 _mayNeedResetForThreadPool = true;
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not handling the case of finalizer threads.
Comment threadsrc/coreclr/nativeaot/System.Private.CoreLib/src/System/Threading/Thread.NativeAot.Windows.cs
{
 public sealed partial class Thread
 {
 [ThreadStatic]
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code
Comment threadsrc/coreclr/vm/finalizerthread.cpp

 LOG((LF_GC, LL_INFO10, "Finalizer thread starting...\n"));

#if defined(FEATURE_COMINTEROP_APARTMENT_SUPPORT) && !defined(FEATURE_COMINTEROP)
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition was always false.
Comment threadsrc/coreclr/vm/threads.cpp
 }
 CONTRACTL_END;

 // This method can be called on current thread only
@jkotasjkotasSep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the non-current thread callers to use SetApartmentOfUnstartedThread
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Motivated by HMF->QCall conversion codereviews
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
/azp run runtime-coreclr outerloop
@azure-pipelines
azure-pipelinesBot
commented
Sep 24, 2024

Copy link


Copy Markdown


Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Sep 24, 2024

Open


Open


Open


Closed

@jkotas
jkotas
merged commit 23b3d41
into
dotnet:mainSep 24, 2024
@JulieLeeMSFT
JulieLeeMSFT
commented
Sep 24, 2024

Copy link


Copy Markdown

Member
@jkotas, all test legs failed in runtime-coreclr libraries-jitstress/20240924.1. PTAL.
@jkotas
jkotas
deleted the

ApartmentState

branch
September 24, 2024 17:57
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
I have looked at some of the failures. The failures are either asserts in the JIT
 Assertion failed '!"Inconsistent profile data"' in 'Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.Lexer:LexXmlDocCommentLeadingTrivia(byref):this' during 'Recognize Switch' (IL size 730; hash 0xe3243bf9; Tier1)
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-a4b3f25a20cf46ce8d/System.Text.RegularExpressions.Tests/1/console.2ae64c75.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A02%3A37Z&ske=2024-09-24T19%3A02%3A37Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A02%3A37Z&se=2024-09-24T19%3A02%3A37Z&sr=c&sp=r&sig=e35ir71XB%2BNVh0DzOhQSt7pwGDj9BrlFxUC2QGob%2BAk%3D
Or asserts/crashes in libraries that suggest bad codegen:
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-5f622e8df388454594/System.Text.Json.Tests/1/console.dbf8d227.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A04%3A02Z&ske=2024-09-24T19%3A04%3A02Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A04%3A02Z&se=2024-09-24T19%3A04%3A02Z&sr=c&sp=r&sig=bL%2BAUD%2Bxfmt5N6ov%2F8w6uwftzRUy0AkdDHRY%2FSGXwbI%3D
@jkotas
jkotas
commented
Sep 24, 2024

Copy link


Copy Markdown

MemberAuthor
Similar set of failures was hit in https://dev.azure.com/dnceng-public/public/_build/results?buildId=815402&view=ms.vss-test-web.build-test-results-tab that did not include this change.
@LoopedBard3LoopedBard3
mentioned this pull request
Sep 26, 2024

Closed

@JulieLeeMSFT
JulieLeeMSFT
commented
Sep 27, 2024

Copy link


Copy Markdown

Member
I have looked at some of the failures. The failures are either asserts in the JIT
 Assertion failed '!"Inconsistent profile data"' in 'Microsoft.CodeAnalysis.CSharp.Syntax.InternalSyntax.Lexer:LexXmlDocCommentLeadingTrivia(byref):this' during 'Recognize Switch' (IL size 730; hash 0xe3243bf9; Tier1)
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-a4b3f25a20cf46ce8d/System.Text.RegularExpressions.Tests/1/console.2ae64c75.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A02%3A37Z&ske=2024-09-24T19%3A02%3A37Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A02%3A37Z&se=2024-09-24T19%3A02%3A37Z&sr=c&sp=r&sig=e35ir71XB%2BNVh0DzOhQSt7pwGDj9BrlFxUC2QGob%2BAk%3D
Or asserts/crashes in libraries that suggest bad codegen:
https://helixre107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-5f622e8df388454594/System.Text.Json.Tests/1/console.dbf8d227.log?skoid=8eda00af-b5ec-4be9-b69b-0919a2338892&sktid=72f988bf-86f1-41af-91ab-2d7cd011db47&skt=2024-09-24T18%3A04%3A02Z&ske=2024-09-24T19%3A04%3A02Z&sks=b&skv=2024-05-04&sv=2024-05-04&st=2024-09-24T18%3A04%3A02Z&se=2024-09-24T19%3A04%3A02Z&sr=c&sp=r&sig=bL%2BAUD%2Bxfmt5N6ov%2F8w6uwftzRUy0AkdDHRY%2FSGXwbI%3D
@EgorBo, PTAL.
@jkotas
jkotas
commented
Sep 27, 2024

Copy link


Copy Markdown

MemberAuthor
These failures should be fixed by #108169
sirntar pushed a commit
to sirntar/runtime
that referenced
this pull request
Sep 30, 2024
@jkotas@sirntar
Misc cleanup of VM threading code (dotnet#108171)
92783de
- Delete special-casing of thread finalizer
- Factor out Get/SetApartment of unstarted threads
- Delete some dead code
- Fix comments

This was referenced Oct 2, 2024

Open


Open

@kotlarmiloskotlarmilos
mentioned this pull request
Oct 2, 2024

Open

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Oct 28, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovskyMichalStrehovsky is a code owner

Assignees

@jkotasjkotas

Labels

area-System.Threading

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jkotas@JulieLeeMSFT@AaronRobinsonMSFT