Uh oh!
There was an error while loading. Please reload this page.
[browser] disable debugger tests on CI - #108178
Merged
pavelsavara merged 3 commits intoNov 19, 2024
Merged
Conversation
This was referenced Sep 24, 2024
Closed
This was referenced Sep 26, 2024
lewing
commented
Oct 1, 2024
Member
@thaystg what should we do here? |
thaystg
commented
Oct 2, 2024
Member
@lewing I am just back from vacation. I disagree about disabling all the tests while they are not enabled somewhere else. Can't we only disable the ones that are failing? |
pavelsavara
commented
Oct 2, 2024
MemberAuthor
Nobody attended them for months |
MemberAuthor
@thaystg do you have ETA ? |
# Conflicts: # eng/testing/tests.browser.targets # src/libraries/sendtohelix-browser.targets
This was referenced Nov 18, 2024
pavelsavara
marked this pull request as ready for review
November 18, 2024 17:14
pavelsavara
requested review from
akoeplinger, ilonatommy, lewing and thaystg
as code ownersNovember 18, 2024 17:14
lewing
approved these changes
Nov 18, 2024
mikelle-rogers pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
akoeplinger
commented
May 13, 2026
Member
/backport to release/9.0-staging |
Contributor
Started backporting to |
Contributor
@akoeplinger backporting to git am output$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patchApplying: disable browser debugger tests on CIUsing index info to reconstruct a base tree...M eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.ymlM eng/pipelines/runtime.ymlM eng/testing/tests.browser.targetsM src/libraries/sendtohelix-browser.targetsM src/libraries/tests.projFalling back to patching base and 3-way merge...Auto-merging eng/pipelines/extra-platforms/runtime-extra-platforms-wasm.ymlAuto-merging eng/pipelines/runtime.ymlAuto-merging eng/testing/tests.browser.targetsCONFLICT (content): Merge conflict in eng/testing/tests.browser.targetsAuto-merging src/libraries/sendtohelix-browser.targetsCONFLICT (content): Merge conflict in src/libraries/sendtohelix-browser.targetsAuto-merging src/libraries/tests.projerror: Failed to merge in the changes.hint: Use 'git am --show-current-patch=diff' to see the failed patchhint: When you have resolved this problem, run "git am --continue".hint: If you prefer to skip this patch, run "git am --skip" instead.hint: To restore the original branch and stop patching, run "git am --abort".hint: Disable this message with "git config set advice.mergeConflict false"Patch failed at 0001 disable browser debugger tests on CIError: The process '/usr/bin/git' failed with exit code 128 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disable browser debugger tests on CI
Related
#106376
#98086
#89909
#89409
#86496
#52102