Uh oh!
There was an error while loading. Please reload this page.
[release/9.0] Fix createdump 'stack smashing detected' error on arm64 - #108208
Merged
Conversation
Contributor
Tagging subscribers to this area: @tommcdon |
hoyosjs
approved these changes
Sep 24, 2024
am11
approved these changes
Sep 24, 2024
tommcdon
approved these changes
Sep 24, 2024
jeffschwMSFT
approved these changes
Sep 24, 2024
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
lgtm. we will take for consideration in GA
This was referenced Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #108166 to release/9.0
/cc @mikem8361
Customer Impact
Customers (in this case RHEL dev) can not create core dumps on linux arm64 platforms.
This change restores the fix from PR #91865 by changing the size back to SpecialDiagInfoSize but uses the 4 parameter MemoryRegion constructor that doesn't assert the address/size is on a PAGE_SIZE alignment (PR #95433).
Issue: #108023
Regression
The changes from PR #91865 were reverted by PR #95433.
Testing
The dev that reported the issue has verified this fix.
Risk
Low. Restoring original working code.