[cdac] Implement NibbleMap lookup and tests by lambdageek · Pull Request #108403 · dotnet/runtime

lambdageek · 2024-09-30T17:26:39Z

The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method.

Implement the lookup algorithm for a nibble map.

Start adding unit tests for the nibble map

Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader.

dotnet-policy-service · 2024-09-30T17:29:15Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method. Implement the lookup algorithm for a nibble map. Start adding unit tests for the nibble map Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader.

Co-authored-by: Filip Navara <filip.navara@gmail.com>

Add an example

davidwrighton

I have two design questions, but other than that it looks good.

davidwrighton · 2024-10-08T17:04:35Z

+// We will then align the map index to the start of the current map unit (map index 8) and move back to the previous map unit (map index 7)
+// At that point, we scan backwards for non-zero map units. Since there are none, we return null.
+
+internal class NibbleMap


Should we think about putting version numbers on these classes. For instance, we know that there are more optimal forms of the NibbleMap that we might implement in the future, and I don't want to get rid of the existing code here, as it could be used to support an old version of the runtime. Do we want to think about calling these things NibbleMap_1 or something?

yep. we could do it now, or we could do it when we have a second algorithm. NibbleMap doesn't leak out of the ExecutionManager contract, so we can cross that bridge when we get to it (also maybe we'll have better names than _1 and _2)

davidwrighton · 2024-10-08T17:10:50Z

+ public bool Equals(TargetCodePointer x, TargetCodePointer y) => x.Value == y.Value;
+ public int GetHashCode(TargetCodePointer obj) => obj.Value.GetHashCode();
+
+ public TargetPointer AsTargetPointer => new(Value);


On ARM32 platforms should this strip off the thumb bit? For reference, on ARM32 Thumb2 targets, the lowest bit is typically set on a code address, to indicate that the pointer refers to a code using the Thumb2 instruction set instead of the ARM instruction set.
I see this as a potential problem around the conversion to ulong here, as well as the AsTargetPointer api.

yea that's a good idea. Elsewhere (in the PrecodeStubs contract) I have an explicit helper that strips off the thumb bit:
internalTargetPointerCodePointerReadableInstrPointer(TargetCodePointercodePointer){// Mask off the thumb bit, if we're on arm32, to get the actual instruction pointerulonginstrPointer=(ulong)codePointer.AsTargetPointer&MachineDescriptor.CodePointerToInstrPointerMask.Value;returnnewTargetPointer(instrPointer);}
I couldn't decide if that's something we want on the TargetCodePointer or on the Target (or on a contract, as I've prototyped it so far)
I think on TargetCodePointer makes the most sense, but then i'll need to store the mask in the code pointer instance at creation time (or make the conversion to a TargetPointer depend on the current target) - and i wasn't sure about the usability of that approach

lambdageek · 2024-09-30T17:26:39Z

The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method.

Implement the lookup algorithm for a nibble map.

Start adding unit tests for the nibble map

Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader.

dotnet-policy-service · 2024-09-30T17:29:15Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method. Implement the lookup algorithm for a nibble map. Start adding unit tests for the nibble map Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader.

Co-authored-by: Filip Navara <filip.navara@gmail.com>

Add an example

davidwrighton

I have two design questions, but other than that it looks good.

davidwrighton · 2024-10-08T17:04:35Z

+// We will then align the map index to the start of the current map unit (map index 8) and move back to the previous map unit (map index 7)
+// At that point, we scan backwards for non-zero map units. Since there are none, we return null.
+
+internal class NibbleMap


Should we think about putting version numbers on these classes. For instance, we know that there are more optimal forms of the NibbleMap that we might implement in the future, and I don't want to get rid of the existing code here, as it could be used to support an old version of the runtime. Do we want to think about calling these things NibbleMap_1 or something?

yep. we could do it now, or we could do it when we have a second algorithm. NibbleMap doesn't leak out of the ExecutionManager contract, so we can cross that bridge when we get to it (also maybe we'll have better names than _1 and _2)

davidwrighton · 2024-10-08T17:10:50Z

+ public bool Equals(TargetCodePointer x, TargetCodePointer y) => x.Value == y.Value;
+ public int GetHashCode(TargetCodePointer obj) => obj.Value.GetHashCode();
+
+ public TargetPointer AsTargetPointer => new(Value);


On ARM32 platforms should this strip off the thumb bit? For reference, on ARM32 Thumb2 targets, the lowest bit is typically set on a code address, to indicate that the pointer refers to a code using the Thumb2 instruction set instead of the ARM instruction set.
I see this as a potential problem around the conversion to ulong here, as well as the AsTargetPointer api.

yea that's a good idea. Elsewhere (in the PrecodeStubs contract) I have an explicit helper that strips off the thumb bit:
internalTargetPointerCodePointerReadableInstrPointer(TargetCodePointercodePointer){// Mask off the thumb bit, if we're on arm32, to get the actual instruction pointerulonginstrPointer=(ulong)codePointer.AsTargetPointer&MachineDescriptor.CodePointerToInstrPointerMask.Value;returnnewTargetPointer(instrPointer);}
I couldn't decide if that's something we want on the TargetCodePointer or on the Target (or on a contract, as I've prototyped it so far)
I think on TargetCodePointer makes the most sense, but then i'll need to store the mask in the code pointer instance at creation time (or make the conversion to a TargetPointer depend on the current target) - and i wasn't sure about the usability of that approach

lambdageek · 2024-09-30T17:26:39Z

The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method.

Implement the lookup algorithm for a nibble map.

Start adding unit tests for the nibble map

Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader.

dotnet-policy-service · 2024-09-30T17:29:15Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method. Implement the lookup algorithm for a nibble map. Start adding unit tests for the nibble map Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader.

Co-authored-by: Filip Navara <filip.navara@gmail.com>

Add an example

davidwrighton

I have two design questions, but other than that it looks good.

davidwrighton · 2024-10-08T17:04:35Z

+// We will then align the map index to the start of the current map unit (map index 8) and move back to the previous map unit (map index 7)
+// At that point, we scan backwards for non-zero map units. Since there are none, we return null.
+
+internal class NibbleMap


Should we think about putting version numbers on these classes. For instance, we know that there are more optimal forms of the NibbleMap that we might implement in the future, and I don't want to get rid of the existing code here, as it could be used to support an old version of the runtime. Do we want to think about calling these things NibbleMap_1 or something?

yep. we could do it now, or we could do it when we have a second algorithm. NibbleMap doesn't leak out of the ExecutionManager contract, so we can cross that bridge when we get to it (also maybe we'll have better names than _1 and _2)

davidwrighton · 2024-10-08T17:10:50Z

+ public bool Equals(TargetCodePointer x, TargetCodePointer y) => x.Value == y.Value;
+ public int GetHashCode(TargetCodePointer obj) => obj.Value.GetHashCode();
+
+ public TargetPointer AsTargetPointer => new(Value);


On ARM32 platforms should this strip off the thumb bit? For reference, on ARM32 Thumb2 targets, the lowest bit is typically set on a code address, to indicate that the pointer refers to a code using the Thumb2 instruction set instead of the ARM instruction set.
I see this as a potential problem around the conversion to ulong here, as well as the AsTargetPointer api.

yea that's a good idea. Elsewhere (in the PrecodeStubs contract) I have an explicit helper that strips off the thumb bit:
internalTargetPointerCodePointerReadableInstrPointer(TargetCodePointercodePointer){// Mask off the thumb bit, if we're on arm32, to get the actual instruction pointerulonginstrPointer=(ulong)codePointer.AsTargetPointer&MachineDescriptor.CodePointerToInstrPointerMask.Value;returnnewTargetPointer(instrPointer);}
I couldn't decide if that's something we want on the TargetCodePointer or on the Target (or on a contract, as I've prototyped it so far)
I think on TargetCodePointer makes the most sense, but then i'll need to store the mask in the code pointer instance at creation time (or make the conversion to a TargetPointer depend on the current target) - and i wasn't sure about the usability of that approach

lambdageek · 2024-09-30T17:26:39Z

The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method.

Implement the lookup algorithm for a nibble map.

Start adding unit tests for the nibble map

Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader.

dotnet-policy-service · 2024-09-30T17:29:15Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method. Implement the lookup algorithm for a nibble map. Start adding unit tests for the nibble map Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader.

Co-authored-by: Filip Navara <filip.navara@gmail.com>

Add an example

davidwrighton

I have two design questions, but other than that it looks good.

davidwrighton · 2024-10-08T17:04:35Z

+// We will then align the map index to the start of the current map unit (map index 8) and move back to the previous map unit (map index 7)
+// At that point, we scan backwards for non-zero map units. Since there are none, we return null.
+
+internal class NibbleMap


Should we think about putting version numbers on these classes. For instance, we know that there are more optimal forms of the NibbleMap that we might implement in the future, and I don't want to get rid of the existing code here, as it could be used to support an old version of the runtime. Do we want to think about calling these things NibbleMap_1 or something?

yep. we could do it now, or we could do it when we have a second algorithm. NibbleMap doesn't leak out of the ExecutionManager contract, so we can cross that bridge when we get to it (also maybe we'll have better names than _1 and _2)

davidwrighton · 2024-10-08T17:10:50Z

+ public bool Equals(TargetCodePointer x, TargetCodePointer y) => x.Value == y.Value;
+ public int GetHashCode(TargetCodePointer obj) => obj.Value.GetHashCode();
+
+ public TargetPointer AsTargetPointer => new(Value);


On ARM32 platforms should this strip off the thumb bit? For reference, on ARM32 Thumb2 targets, the lowest bit is typically set on a code address, to indicate that the pointer refers to a code using the Thumb2 instruction set instead of the ARM instruction set.
I see this as a potential problem around the conversion to ulong here, as well as the AsTargetPointer api.

yea that's a good idea. Elsewhere (in the PrecodeStubs contract) I have an explicit helper that strips off the thumb bit:
internalTargetPointerCodePointerReadableInstrPointer(TargetCodePointercodePointer){// Mask off the thumb bit, if we're on arm32, to get the actual instruction pointerulonginstrPointer=(ulong)codePointer.AsTargetPointer&MachineDescriptor.CodePointerToInstrPointerMask.Value;returnnewTargetPointer(instrPointer);}
I couldn't decide if that's something we want on the TargetCodePointer or on the Target (or on a contract, as I've prototyped it so far)
I think on TargetCodePointer makes the most sense, but then i'll need to store the mask in the code pointer instance at creation time (or make the conversion to a TargetPointer depend on the current target) - and i wasn't sure about the usability of that approach

lambdageek · 2024-09-30T17:26:39Z

The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method.

Implement the lookup algorithm for a nibble map.

Start adding unit tests for the nibble map

Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader.

dotnet-policy-service · 2024-09-30T17:29:15Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method. Implement the lookup algorithm for a nibble map. Start adding unit tests for the nibble map Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader.

Co-authored-by: Filip Navara <filip.navara@gmail.com>

Add an example

davidwrighton

I have two design questions, but other than that it looks good.

davidwrighton · 2024-10-08T17:04:35Z

+// We will then align the map index to the start of the current map unit (map index 8) and move back to the previous map unit (map index 7)
+// At that point, we scan backwards for non-zero map units. Since there are none, we return null.
+
+internal class NibbleMap


Should we think about putting version numbers on these classes. For instance, we know that there are more optimal forms of the NibbleMap that we might implement in the future, and I don't want to get rid of the existing code here, as it could be used to support an old version of the runtime. Do we want to think about calling these things NibbleMap_1 or something?

yep. we could do it now, or we could do it when we have a second algorithm. NibbleMap doesn't leak out of the ExecutionManager contract, so we can cross that bridge when we get to it (also maybe we'll have better names than _1 and _2)

davidwrighton · 2024-10-08T17:10:50Z

+ public bool Equals(TargetCodePointer x, TargetCodePointer y) => x.Value == y.Value;
+ public int GetHashCode(TargetCodePointer obj) => obj.Value.GetHashCode();
+
+ public TargetPointer AsTargetPointer => new(Value);


On ARM32 platforms should this strip off the thumb bit? For reference, on ARM32 Thumb2 targets, the lowest bit is typically set on a code address, to indicate that the pointer refers to a code using the Thumb2 instruction set instead of the ARM instruction set.
I see this as a potential problem around the conversion to ulong here, as well as the AsTargetPointer api.

yea that's a good idea. Elsewhere (in the PrecodeStubs contract) I have an explicit helper that strips off the thumb bit:
internalTargetPointerCodePointerReadableInstrPointer(TargetCodePointercodePointer){// Mask off the thumb bit, if we're on arm32, to get the actual instruction pointerulonginstrPointer=(ulong)codePointer.AsTargetPointer&MachineDescriptor.CodePointerToInstrPointerMask.Value;returnnewTargetPointer(instrPointer);}
I couldn't decide if that's something we want on the TargetCodePointer or on the Target (or on a contract, as I've prototyped it so far)
I think on TargetCodePointer makes the most sense, but then i'll need to store the mask in the code pointer instance at creation time (or make the conversion to a TargetPointer depend on the current target) - and i wasn't sure about the usability of that approach

lambdageek · 2024-09-30T17:26:39Z

The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method.

Implement the lookup algorithm for a nibble map.

Start adding unit tests for the nibble map

Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader.

dotnet-policy-service · 2024-09-30T17:29:15Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method. Implement the lookup algorithm for a nibble map. Start adding unit tests for the nibble map Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader.

Co-authored-by: Filip Navara <filip.navara@gmail.com>

Add an example

davidwrighton

I have two design questions, but other than that it looks good.

davidwrighton · 2024-10-08T17:04:35Z

+// We will then align the map index to the start of the current map unit (map index 8) and move back to the previous map unit (map index 7)
+// At that point, we scan backwards for non-zero map units. Since there are none, we return null.
+
+internal class NibbleMap


Should we think about putting version numbers on these classes. For instance, we know that there are more optimal forms of the NibbleMap that we might implement in the future, and I don't want to get rid of the existing code here, as it could be used to support an old version of the runtime. Do we want to think about calling these things NibbleMap_1 or something?

yep. we could do it now, or we could do it when we have a second algorithm. NibbleMap doesn't leak out of the ExecutionManager contract, so we can cross that bridge when we get to it (also maybe we'll have better names than _1 and _2)

davidwrighton · 2024-10-08T17:10:50Z

+ public bool Equals(TargetCodePointer x, TargetCodePointer y) => x.Value == y.Value;
+ public int GetHashCode(TargetCodePointer obj) => obj.Value.GetHashCode();
+
+ public TargetPointer AsTargetPointer => new(Value);


On ARM32 platforms should this strip off the thumb bit? For reference, on ARM32 Thumb2 targets, the lowest bit is typically set on a code address, to indicate that the pointer refers to a code using the Thumb2 instruction set instead of the ARM instruction set.
I see this as a potential problem around the conversion to ulong here, as well as the AsTargetPointer api.

yea that's a good idea. Elsewhere (in the PrecodeStubs contract) I have an explicit helper that strips off the thumb bit:
internalTargetPointerCodePointerReadableInstrPointer(TargetCodePointercodePointer){// Mask off the thumb bit, if we're on arm32, to get the actual instruction pointerulonginstrPointer=(ulong)codePointer.AsTargetPointer&MachineDescriptor.CodePointerToInstrPointerMask.Value;returnnewTargetPointer(instrPointer);}
I couldn't decide if that's something we want on the TargetCodePointer or on the Target (or on a contract, as I've prototyped it so far)
I think on TargetCodePointer makes the most sense, but then i'll need to store the mask in the code pointer instance at creation time (or make the conversion to a TargetPointer depend on the current target) - and i wasn't sure about the usability of that approach

lambdageek · 2024-09-30T17:26:39Z

The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method.

Implement the lookup algorithm for a nibble map.

Start adding unit tests for the nibble map

Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader.

dotnet-policy-service · 2024-09-30T17:29:15Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method. Implement the lookup algorithm for a nibble map. Start adding unit tests for the nibble map Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader.

Co-authored-by: Filip Navara <filip.navara@gmail.com>

Add an example

davidwrighton

I have two design questions, but other than that it looks good.

davidwrighton · 2024-10-08T17:04:35Z

+// We will then align the map index to the start of the current map unit (map index 8) and move back to the previous map unit (map index 7)
+// At that point, we scan backwards for non-zero map units. Since there are none, we return null.
+
+internal class NibbleMap


Should we think about putting version numbers on these classes. For instance, we know that there are more optimal forms of the NibbleMap that we might implement in the future, and I don't want to get rid of the existing code here, as it could be used to support an old version of the runtime. Do we want to think about calling these things NibbleMap_1 or something?

yep. we could do it now, or we could do it when we have a second algorithm. NibbleMap doesn't leak out of the ExecutionManager contract, so we can cross that bridge when we get to it (also maybe we'll have better names than _1 and _2)

davidwrighton · 2024-10-08T17:10:50Z

+ public bool Equals(TargetCodePointer x, TargetCodePointer y) => x.Value == y.Value;
+ public int GetHashCode(TargetCodePointer obj) => obj.Value.GetHashCode();
+
+ public TargetPointer AsTargetPointer => new(Value);


On ARM32 platforms should this strip off the thumb bit? For reference, on ARM32 Thumb2 targets, the lowest bit is typically set on a code address, to indicate that the pointer refers to a code using the Thumb2 instruction set instead of the ARM instruction set.
I see this as a potential problem around the conversion to ulong here, as well as the AsTargetPointer api.

yea that's a good idea. Elsewhere (in the PrecodeStubs contract) I have an explicit helper that strips off the thumb bit:
internalTargetPointerCodePointerReadableInstrPointer(TargetCodePointercodePointer){// Mask off the thumb bit, if we're on arm32, to get the actual instruction pointerulonginstrPointer=(ulong)codePointer.AsTargetPointer&MachineDescriptor.CodePointerToInstrPointerMask.Value;returnnewTargetPointer(instrPointer);}
I couldn't decide if that's something we want on the TargetCodePointer or on the Target (or on a contract, as I've prototyped it so far)
I think on TargetCodePointer makes the most sense, but then i'll need to store the mask in the code pointer instance at creation time (or make the conversion to a TargetPointer depend on the current target) - and i wasn't sure about the usability of that approach

lambdageek · 2024-09-30T17:26:39Z

The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method.

Implement the lookup algorithm for a nibble map.

Start adding unit tests for the nibble map

Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader.

dotnet-policy-service · 2024-09-30T17:29:15Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method. Implement the lookup algorithm for a nibble map. Start adding unit tests for the nibble map Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader.

Co-authored-by: Filip Navara <filip.navara@gmail.com>

Add an example

davidwrighton

I have two design questions, but other than that it looks good.

davidwrighton · 2024-10-08T17:04:35Z

+// We will then align the map index to the start of the current map unit (map index 8) and move back to the previous map unit (map index 7)
+// At that point, we scan backwards for non-zero map units. Since there are none, we return null.
+
+internal class NibbleMap


Should we think about putting version numbers on these classes. For instance, we know that there are more optimal forms of the NibbleMap that we might implement in the future, and I don't want to get rid of the existing code here, as it could be used to support an old version of the runtime. Do we want to think about calling these things NibbleMap_1 or something?

yep. we could do it now, or we could do it when we have a second algorithm. NibbleMap doesn't leak out of the ExecutionManager contract, so we can cross that bridge when we get to it (also maybe we'll have better names than _1 and _2)

davidwrighton · 2024-10-08T17:10:50Z

+ public bool Equals(TargetCodePointer x, TargetCodePointer y) => x.Value == y.Value;
+ public int GetHashCode(TargetCodePointer obj) => obj.Value.GetHashCode();
+
+ public TargetPointer AsTargetPointer => new(Value);


On ARM32 platforms should this strip off the thumb bit? For reference, on ARM32 Thumb2 targets, the lowest bit is typically set on a code address, to indicate that the pointer refers to a code using the Thumb2 instruction set instead of the ARM instruction set.
I see this as a potential problem around the conversion to ulong here, as well as the AsTargetPointer api.

yea that's a good idea. Elsewhere (in the PrecodeStubs contract) I have an explicit helper that strips off the thumb bit:
internalTargetPointerCodePointerReadableInstrPointer(TargetCodePointercodePointer){// Mask off the thumb bit, if we're on arm32, to get the actual instruction pointerulonginstrPointer=(ulong)codePointer.AsTargetPointer&MachineDescriptor.CodePointerToInstrPointerMask.Value;returnnewTargetPointer(instrPointer);}
I couldn't decide if that's something we want on the TargetCodePointer or on the Target (or on a contract, as I've prototyped it so far)
I think on TargetCodePointer makes the most sense, but then i'll need to store the mask in the code pointer instance at creation time (or make the conversion to a TargetPointer depend on the current target) - and i wasn't sure about the usability of that approach

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 30, 2024

dotnet-policy-serviceBot assigned lambdageek Sep 30, 2024

lambdageek added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 30, 2024

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and max-charlamb September 30, 2024 17:28

lambdageek added 3 commits September 30, 2024 15:23

remove fixed fixme
43fb677

remove one more TODO
dc3c1a4

lambdageek force-pushed the cdac-nibblemap-standalone branch from abb763c to dc3c1a4Compare September 30, 2024 19:23

build-analysisBot mentioned this pull request Sep 30, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

filipnavara reviewed Oct 1, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated

lambdageekand others added 6 commits October 1, 2024 09:55

spelling
2620440
Co-authored-by: Filip Navara <filip.navara@gmail.com>

NibbleMap: remove unused _codeHeaderSize field
2a82299

cleanup NibbleMap and tests
10a2b6a

NibbleMap: use a struct for MapUnit
e71aa09

NibbleMap: use types
c3f51db

Clarify termination condition; clean up docs
599d533
Add an example

max-charlamb reviewed Oct 7, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated
Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated

lambdageek force-pushed the cdac-nibblemap-standalone branch from 5c161e9 to 51d7696Compare October 7, 2024 23:40

fix dodgy math in example
4182125

lambdageek force-pushed the cdac-nibblemap-standalone branch from 51d7696 to 4182125Compare October 7, 2024 23:51

davidwrighton approved these changes Oct 8, 2024
View reviewed changes

lambdageek merged commit 9d923b8 into dotnet:mainOct 8, 2024

github-actionsBot locked and limited conversation to collaborators Nov 8, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 30, 2024

dotnet-policy-serviceBot assigned lambdageek Sep 30, 2024

lambdageek added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 30, 2024

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and max-charlamb September 30, 2024 17:28

lambdageek added 3 commits September 30, 2024 15:23

remove fixed fixme
43fb677

remove one more TODO
dc3c1a4

lambdageek force-pushed the cdac-nibblemap-standalone branch from abb763c to dc3c1a4Compare September 30, 2024 19:23

build-analysisBot mentioned this pull request Sep 30, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

filipnavara reviewed Oct 1, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated

lambdageekand others added 6 commits October 1, 2024 09:55

spelling
2620440
Co-authored-by: Filip Navara <filip.navara@gmail.com>

NibbleMap: remove unused _codeHeaderSize field
2a82299

cleanup NibbleMap and tests
10a2b6a

NibbleMap: use a struct for MapUnit
e71aa09

NibbleMap: use types
c3f51db

Clarify termination condition; clean up docs
599d533
Add an example

max-charlamb reviewed Oct 7, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated
Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated

lambdageek force-pushed the cdac-nibblemap-standalone branch from 5c161e9 to 51d7696Compare October 7, 2024 23:40

fix dodgy math in example
4182125

lambdageek force-pushed the cdac-nibblemap-standalone branch from 51d7696 to 4182125Compare October 7, 2024 23:51

davidwrighton approved these changes Oct 8, 2024
View reviewed changes

lambdageek merged commit 9d923b8 into dotnet:mainOct 8, 2024

github-actionsBot locked and limited conversation to collaborators Nov 8, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 30, 2024

dotnet-policy-serviceBot assigned lambdageek Sep 30, 2024

lambdageek added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 30, 2024

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and max-charlamb September 30, 2024 17:28

lambdageek added 3 commits September 30, 2024 15:23

remove fixed fixme
43fb677

remove one more TODO
dc3c1a4

lambdageek force-pushed the cdac-nibblemap-standalone branch from abb763c to dc3c1a4Compare September 30, 2024 19:23

build-analysisBot mentioned this pull request Sep 30, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

filipnavara reviewed Oct 1, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated

lambdageekand others added 6 commits October 1, 2024 09:55

spelling
2620440
Co-authored-by: Filip Navara <filip.navara@gmail.com>

NibbleMap: remove unused _codeHeaderSize field
2a82299

cleanup NibbleMap and tests
10a2b6a

NibbleMap: use a struct for MapUnit
e71aa09

NibbleMap: use types
c3f51db

Clarify termination condition; clean up docs
599d533
Add an example

max-charlamb reviewed Oct 7, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated
Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated

lambdageek force-pushed the cdac-nibblemap-standalone branch from 5c161e9 to 51d7696Compare October 7, 2024 23:40

fix dodgy math in example
4182125

lambdageek force-pushed the cdac-nibblemap-standalone branch from 51d7696 to 4182125Compare October 7, 2024 23:51

davidwrighton approved these changes Oct 8, 2024
View reviewed changes

lambdageek merged commit 9d923b8 into dotnet:mainOct 8, 2024

github-actionsBot locked and limited conversation to collaborators Nov 8, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 30, 2024

dotnet-policy-serviceBot assigned lambdageek Sep 30, 2024

lambdageek added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 30, 2024

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and max-charlamb September 30, 2024 17:28

lambdageek added 3 commits September 30, 2024 15:23

remove fixed fixme
43fb677

remove one more TODO
dc3c1a4

lambdageek force-pushed the cdac-nibblemap-standalone branch from abb763c to dc3c1a4Compare September 30, 2024 19:23

build-analysisBot mentioned this pull request Sep 30, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

filipnavara reviewed Oct 1, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated

lambdageekand others added 6 commits October 1, 2024 09:55

spelling
2620440
Co-authored-by: Filip Navara <filip.navara@gmail.com>

NibbleMap: remove unused _codeHeaderSize field
2a82299

cleanup NibbleMap and tests
10a2b6a

NibbleMap: use a struct for MapUnit
e71aa09

NibbleMap: use types
c3f51db

Clarify termination condition; clean up docs
599d533
Add an example

max-charlamb reviewed Oct 7, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated
Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated

lambdageek force-pushed the cdac-nibblemap-standalone branch from 5c161e9 to 51d7696Compare October 7, 2024 23:40

fix dodgy math in example
4182125

lambdageek force-pushed the cdac-nibblemap-standalone branch from 51d7696 to 4182125Compare October 7, 2024 23:51

davidwrighton approved these changes Oct 8, 2024
View reviewed changes

lambdageek merged commit 9d923b8 into dotnet:mainOct 8, 2024

github-actionsBot locked and limited conversation to collaborators Nov 8, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 30, 2024

dotnet-policy-serviceBot assigned lambdageek Sep 30, 2024

lambdageek added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 30, 2024

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and max-charlamb September 30, 2024 17:28

lambdageek added 3 commits September 30, 2024 15:23

remove fixed fixme
43fb677

remove one more TODO
dc3c1a4

lambdageek force-pushed the cdac-nibblemap-standalone branch from abb763c to dc3c1a4Compare September 30, 2024 19:23

build-analysisBot mentioned this pull request Sep 30, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

filipnavara reviewed Oct 1, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated

lambdageekand others added 6 commits October 1, 2024 09:55

spelling
2620440
Co-authored-by: Filip Navara <filip.navara@gmail.com>

NibbleMap: remove unused _codeHeaderSize field
2a82299

cleanup NibbleMap and tests
10a2b6a

NibbleMap: use a struct for MapUnit
e71aa09

NibbleMap: use types
c3f51db

Clarify termination condition; clean up docs
599d533
Add an example

max-charlamb reviewed Oct 7, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated
Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated

lambdageek force-pushed the cdac-nibblemap-standalone branch from 5c161e9 to 51d7696Compare October 7, 2024 23:40

fix dodgy math in example
4182125

lambdageek force-pushed the cdac-nibblemap-standalone branch from 51d7696 to 4182125Compare October 7, 2024 23:51

davidwrighton approved these changes Oct 8, 2024
View reviewed changes

lambdageek merged commit 9d923b8 into dotnet:mainOct 8, 2024

github-actionsBot locked and limited conversation to collaborators Nov 8, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 30, 2024

dotnet-policy-serviceBot assigned lambdageek Sep 30, 2024

lambdageek added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 30, 2024

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and max-charlamb September 30, 2024 17:28

lambdageek added 3 commits September 30, 2024 15:23

remove fixed fixme
43fb677

remove one more TODO
dc3c1a4

lambdageek force-pushed the cdac-nibblemap-standalone branch from abb763c to dc3c1a4Compare September 30, 2024 19:23

build-analysisBot mentioned this pull request Sep 30, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

filipnavara reviewed Oct 1, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated

lambdageekand others added 6 commits October 1, 2024 09:55

spelling
2620440
Co-authored-by: Filip Navara <filip.navara@gmail.com>

NibbleMap: remove unused _codeHeaderSize field
2a82299

cleanup NibbleMap and tests
10a2b6a

NibbleMap: use a struct for MapUnit
e71aa09

NibbleMap: use types
c3f51db

Clarify termination condition; clean up docs
599d533
Add an example

max-charlamb reviewed Oct 7, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated
Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated

lambdageek force-pushed the cdac-nibblemap-standalone branch from 5c161e9 to 51d7696Compare October 7, 2024 23:40

fix dodgy math in example
4182125

lambdageek force-pushed the cdac-nibblemap-standalone branch from 51d7696 to 4182125Compare October 7, 2024 23:51

davidwrighton approved these changes Oct 8, 2024
View reviewed changes

lambdageek merged commit 9d923b8 into dotnet:mainOct 8, 2024

github-actionsBot locked and limited conversation to collaborators Nov 8, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 30, 2024

dotnet-policy-serviceBot assigned lambdageek Sep 30, 2024

lambdageek added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 30, 2024

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and max-charlamb September 30, 2024 17:28

lambdageek added 3 commits September 30, 2024 15:23

remove fixed fixme
43fb677

remove one more TODO
dc3c1a4

lambdageek force-pushed the cdac-nibblemap-standalone branch from abb763c to dc3c1a4Compare September 30, 2024 19:23

build-analysisBot mentioned this pull request Sep 30, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

filipnavara reviewed Oct 1, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated

lambdageekand others added 6 commits October 1, 2024 09:55

spelling
2620440
Co-authored-by: Filip Navara <filip.navara@gmail.com>

NibbleMap: remove unused _codeHeaderSize field
2a82299

cleanup NibbleMap and tests
10a2b6a

NibbleMap: use a struct for MapUnit
e71aa09

NibbleMap: use types
c3f51db

Clarify termination condition; clean up docs
599d533
Add an example

max-charlamb reviewed Oct 7, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated
Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated

lambdageek force-pushed the cdac-nibblemap-standalone branch from 5c161e9 to 51d7696Compare October 7, 2024 23:40

fix dodgy math in example
4182125

lambdageek force-pushed the cdac-nibblemap-standalone branch from 51d7696 to 4182125Compare October 7, 2024 23:51

davidwrighton approved these changes Oct 8, 2024
View reviewed changes

lambdageek merged commit 9d923b8 into dotnet:mainOct 8, 2024

github-actionsBot locked and limited conversation to collaborators Nov 8, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 30, 2024

dotnet-policy-serviceBot assigned lambdageek Sep 30, 2024

lambdageek added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 30, 2024

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and max-charlamb September 30, 2024 17:28

lambdageek added 3 commits September 30, 2024 15:23

remove fixed fixme
43fb677

remove one more TODO
dc3c1a4

lambdageek force-pushed the cdac-nibblemap-standalone branch from abb763c to dc3c1a4Compare September 30, 2024 19:23

build-analysisBot mentioned this pull request Sep 30, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

filipnavara reviewed Oct 1, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated

lambdageekand others added 6 commits October 1, 2024 09:55

spelling
2620440
Co-authored-by: Filip Navara <filip.navara@gmail.com>

NibbleMap: remove unused _codeHeaderSize field
2a82299

cleanup NibbleMap and tests
10a2b6a

NibbleMap: use a struct for MapUnit
e71aa09

NibbleMap: use types
c3f51db

Clarify termination condition; clean up docs
599d533
Add an example

max-charlamb reviewed Oct 7, 2024
View reviewed changes

Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated
Comment threaddocs/design/datacontracts/ExecutionManager.md Outdated

lambdageek force-pushed the cdac-nibblemap-standalone branch from 5c161e9 to 51d7696Compare October 7, 2024 23:40

fix dodgy math in example
4182125

lambdageek force-pushed the cdac-nibblemap-standalone branch from 51d7696 to 4182125Compare October 7, 2024 23:51

davidwrighton approved these changes Oct 8, 2024
View reviewed changes

lambdageek merged commit 9d923b8 into dotnet:mainOct 8, 2024

github-actionsBot locked and limited conversation to collaborators Nov 8, 2024

Uh oh!

Conversation

lambdageek commented Sep 30, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Sep 30, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidwrighton left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

lambdageek commented Sep 30, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Sep 30, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidwrighton left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

lambdageek commented Sep 30, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Sep 30, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidwrighton left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

lambdageek commented Sep 30, 2024•
edited
Loading

lambdageek commented Sep 30, 2024•
edited
Loading

lambdageek commented Sep 30, 2024•
edited
Loading

lambdageek commented Sep 30, 2024•
edited
Loading