Skip to content

Update stepping through MulticastDelegate under the Debugger - #108414

Merged
mikelle-rogers merged 11 commits into
dotnet:mainfrom
mikelle-rogers:dev/mirogers/testingMulticastDelegateMac
Oct 9, 2024
Merged

Update stepping through MulticastDelegate under the Debugger#108414
mikelle-rogers merged 11 commits into
dotnet:mainfrom
mikelle-rogers:dev/mirogers/testingMulticastDelegateMac

Conversation

@mikelle-rogers

@mikelle-rogersmikelle-rogers commented Sep 30, 2024

Copy link
Copy Markdown
Member

This PR updates how the Debugger steps through a multicast delegate. Rather than putting a breakpoint on the entry of a helper method, we now call the helper method, which calls the relevant functions to find where we are to step next.

@mikelle-rogersmikelle-rogers self-assigned this Sep 30, 2024
@ghostghost added the area-VM-coreclr label Sep 30, 2024
@dotnet-policy-service

dotnet-policy-serviceBot commented Sep 30, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

@mikelle-rogers
mikelle-rogers marked this pull request as ready for review September 30, 2024 22:51
@mikelle-rogers
mikelle-rogers requested review from a team, jkotas and noahfalkSeptember 30, 2024 22:51
@mikelle-rogers

mikelle-rogers commented Sep 30, 2024

Copy link
Copy Markdown
MemberAuthor

contributes to #68018

jkotas
jkotas reviewed Sep 30, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/stubhelpers.cpp Outdated
Comment threadsrc/coreclr/vm/stubhelpers.cpp Outdated
Comment threadsrc/coreclr/debug/ee/debugger.cpp Outdated
@build-analysisbuild-analysisBot mentioned this pull request Oct 1, 2024
Closed
3 tasks
jkotas
jkotas reviewed Oct 1, 2024
View reviewed changes
Comment threadsrc/coreclr/debug/ee/controller.cpp
huoyaoyuan
huoyaoyuan reviewed Oct 1, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/stubhelpers.cpp Outdated
@mikelle-rogers
mikelle-rogersforce-pushed the dev/mirogers/testingMulticastDelegateMac branch from e7b864f to bcc0cf9CompareOctober 1, 2024 21:52
jkotas
jkotas reviewed Oct 2, 2024
View reviewed changes
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
@jkotas

jkotas commented Oct 2, 2024

Copy link
Copy Markdown
Member

The VM side of the change LGTM. I do not understand the debugger side well enough to sign-off on it.

noahfalk
noahfalk reviewed Oct 2, 2024
View reviewed changes

@noahfalknoahfalk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see it coming along!

Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
Comment threadsrc/coreclr/debug/ee/debugger.cpp Outdated
@mikelle-rogers
mikelle-rogersforce-pushed the dev/mirogers/testingMulticastDelegateMac branch from f5f3709 to c152b10CompareOctober 2, 2024 21:54
jkotas
jkotas reviewed Oct 3, 2024
View reviewed changes
Comment threadsrc/coreclr/vm/comdelegate.cpp
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Oct 8, 2024
View reviewed changes
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Oct 8, 2024
View reviewed changes
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Oct 8, 2024
View reviewed changes
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Oct 8, 2024
View reviewed changes
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
AaronRobinsonMSFT
AaronRobinsonMSFT reviewed Oct 8, 2024
View reviewed changes
Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
@build-analysisbuild-analysisBot mentioned this pull request Oct 8, 2024
Closed
noahfalk
noahfalk reviewed Oct 8, 2024
View reviewed changes

@noahfalknoahfalk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions, but overall looks good 👍

Comment threadsrc/coreclr/debug/ee/controller.cpp Outdated
Comment threadsrc/coreclr/vm/stubmgr.cpp Outdated
@mikelle-rogers
mikelle-rogers merged commit abde3f9 into dotnet:mainOct 9, 2024
@DrewScogginsDrewScoggins mentioned this pull request Oct 15, 2024
Closed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Nov 8, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes
@jkotasjkotasAwaiting requested review from jkotas
@noahfalknoahfalkAwaiting requested review from noahfalk
+1 more reviewer
@huoyaoyuanhuoyaoyuanhuoyaoyuan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mikelle-rogersmikelle-rogers

Labels

area-VM-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mikelle-rogers@jkotas@huoyaoyuan@noahfalk@AaronRobinsonMSFT