Skip to content

[ppc64le] Fixed assertion failure which was occurring while running System.Runtime.Serialization.Formatters tests - #108429

Merged
akoeplinger merged 32 commits into
dotnet:mainfrom
alhad-deshpande:main
Oct 9, 2024
Merged

[ppc64le] Fixed assertion failure which was occurring while running System.Runtime.Serialization.Formatters tests#108429
akoeplinger merged 32 commits into
dotnet:mainfrom
alhad-deshpande:main

Conversation

@alhad-deshpande

@alhad-deshpandealhad-deshpande commented Oct 1, 2024

Copy link
Copy Markdown
Contributor

This PR fixes assertion failure mentioned in PR 107678.

alhad-deshpandeand others added 30 commits September 8, 2022 10:55
@alhad-deshpande
[ppc64le] Fixed thunk address 8 byte alignment issue
a9d9b6d
@alhad-deshpande
Merge branch 'main' ofhttps://github.com/Sapana-Khemkar/runtimeinto…
2b2092f
… main
@alhad-deshpande
Fixed FSharp crash issue
3531291
@alhad-deshpande
Merge branch 'dotnet:main' into main
9a042d7
@alhad-deshpande
[ppc64le] Implementation of mono_arch_get_delegate_virtual_invoke_imp…
96f7c4d
…l method for ppc64le architecture
@alhad-deshpande
Fixed clang15 build issues and returning address of sc_sp instead of …
6a05d50
…value
@alhad-deshpande
Merge branch 'dotnet:main' into main
8110ac8
@alhad-deshpande
Merge branch 'dotnet:main' into main
18910e3
@alhad-deshpande
Merge branch 'dotnet:main' into main
5fc3241
@alhad-deshpande
Merge branch 'dotnet:main' into main
6a89b7c
@alhad-deshpande
Added float32 support and implemented related opcodes
1a1a0e2
@alhad-deshpande
Correction in OP_RCONV_TO_R cases
6b2758d
@alhad-deshpande
Merge branch 'dotnet:main' into main
5d9a5db
@alhad-deshpande
Merge branch 'dotnet:main' into main
d1ebd9a
@alhad-deshpande
Corrected code for few opcodes
fe1b890
@alhad-deshpande
Merge branch 'main' ofhttps://github.com/Sapana-Khemkar/runtimeinto…
3fef59b
… main
@alhad-deshpande
Merge branch 'main' ofhttps://github.com/Sapana-Khemkar/runtimeinto…
0cb3cec
… main
@alhad-deshpande
[ppc64le] performance improvements while branching
a1fec64
@alhad-deshpande
Merge branch 'dotnet:main' into main
e94afeb
@alhad-deshpande
Merge branch 'dotnet:main' into main
c01f25e
@alhad-deshpande
Merge branch 'dotnet:main' into main
ae9a4dc
@alhad-deshpande
Merge branch 'dotnet:main' into main
7a07fd5
@alhad-deshpande
[ppc64le] Fixed insufficient memory exception issue
c4adfa9
@alhad-deshpande
Merge branch 'dotnet:main' into main
6bac22e
@alhad-deshpande
Merge branch 'main' ofhttps://github.com/Sapana-Khemkar/runtimeinto…
21a1761
… main
@alhad-deshpande
Merge branch 'dotnet:main' into main
6c45c29
@alhad-deshpande
Merge branch 'dotnet:main' into main
903adff
@alhad-deshpande
Merge branch 'dotnet:main' into main
378f310
@alhad-deshpande
Merge branch 'dotnet:main' into main
9f0cede
@alhad-deshpande
[ppc64le] Fixed assertion failure which was occurring while running S…
65fbba0
…ystem.Runtime.Serialization.Formatters tests
@ghostghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 1, 2024
@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Oct 1, 2024
@alhad-deshpande

alhad-deshpande commented Oct 1, 2024

Copy link
Copy Markdown
ContributorAuthor

@akoeplinger
This PR fixes assertion failure mentioned in PR #107678 (comment). Can you please approve/merge this PR?

This was referenced Oct 1, 2024
Closed
Open
Closed
Closed
Closed
Closed
@alhad-deshpande

alhad-deshpande commented Oct 9, 2024

Copy link
Copy Markdown
ContributorAuthor

@lambdageek
Can you please approve/merge this PR?

@akoeplinger

akoeplinger commented Oct 9, 2024

Copy link
Copy Markdown
Member

/azp run runtime-community

@azure-pipelines

azure-pipelinesBot commented Oct 9, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@akoeplinger

akoeplinger commented Oct 9, 2024

Copy link
Copy Markdown
Member

sorry for the late response, I was on vacation and am still catching up on GitHub notifications 😄

@akoeplinger

akoeplinger commented Oct 9, 2024

Copy link
Copy Markdown
Member

/azp run runtime-community

@azure-pipelines

azure-pipelinesBot commented Oct 9, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@alhad-deshpande

alhad-deshpande commented Oct 9, 2024

Copy link
Copy Markdown
ContributorAuthor

sorry for the late response, I was on vacation and am still catching up on GitHub notifications 😄

No problem. Thanks for approving!

@alhad-deshpande

alhad-deshpande commented Oct 9, 2024

Copy link
Copy Markdown
ContributorAuthor

@akoeplinger
The build failed due to new vulnerability warning https://dev.azure.com/dnceng-public/public/_build/results?buildId=835423&view=results.

I have merged latest main and the build should pass now.
Can you please rerun CLI?

@akoeplinger

akoeplinger commented Oct 9, 2024

Copy link
Copy Markdown
Member

/azp run runtime-community

@azure-pipelines

azure-pipelinesBot commented Oct 9, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@build-analysisbuild-analysisBot mentioned this pull request Oct 9, 2024
Open
3 tasks
@akoeplinger

akoeplinger commented Oct 9, 2024

Copy link
Copy Markdown
Member

/ba-g this only changes ppc64le codepaths so the other failures are unrelated

@akoeplinger
akoeplinger merged commit 6fad376 into dotnet:mainOct 9, 2024
@alhad-deshpandealhad-deshpande mentioned this pull request Oct 10, 2024
Merged
4 tasks
rzikm pushed a commit to rzikm/dotnet-runtime that referenced this pull request Oct 11, 2024
@alhad-deshpande@rzikm
[ppc64le] Fixed assertion failure which was occurring while running S…
93dd112
…ystem.Runtime.Serialization.Formatters tests (dotnet#108429)
* [ppc64le] Fixed thunk address 8 byte alignment issue
* Fixed FSharp crash issue
* [ppc64le] Implementation of mono_arch_get_delegate_virtual_invoke_impl method for ppc64le architecture
* Fixed clang15 build issues and returning address of sc_sp instead of value
* Added float32 support and implemented related opcodes
* Correction in OP_RCONV_TO_R cases
* Corrected code for few opcodes
* [ppc64le] performance improvements while branching
* [ppc64le] Fixed insufficient memory exception issue
* [ppc64le] Fixed assertion failure which was occurring while running System.Runtime.Serialization.Formatters tests
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Nov 9, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@lambdageeklambdageekAwaiting requested review from lambdageek

Assignees

No one assigned

Labels

community-contributionIndicates that the PR has been added by a community memberneeds-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alhad-deshpande@akoeplinger