[browser] stop testing with nodejs - #108582

Merged
ilonatommy merged 4 commits into
dotnet:mainfrom
pavelsavara:browser_stop_testing_with_nodejs
Oct 8, 2024
Merged

[browser] stop testing with nodejs#108582
ilonatommy merged 4 commits into
dotnet:mainfrom
pavelsavara:browser_stop_testing_with_nodejs

Conversation

@pavelsavara

@pavelsavarapavelsavara commented Oct 7, 2024•
edited by ilonatommy
Loading

Copy link
Copy Markdown
Member

To reduce WASM test matrix

  • removed pipelines
  • WasmTestOnNodeJS scenario
  • Wasm.Build.Tests tests
  • Old Blazor_net50 project that was added in [wasm] Don't use workload for tfm < net6.0 #56606 to be used in WBT but we started using different logic to test Blazor since then and it can be safely removed.

I left in place

  • PlatformDetection.IsNotNodeJS
    • HTTP & WS tests
    • Hybrid globalization tests
  • detection in `src\mono\browser\test-main.js
  • any production code

@pavelsavarapavelsavara added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Oct 7, 2024
@pavelsavarapavelsavara added this to the 10.0.0 milestone Oct 7, 2024
@pavelsavarapavelsavara self-assigned this Oct 7, 2024
@pavelsavara
pavelsavara marked this pull request as ready for review October 7, 2024 12:34
ilonatommy
ilonatommy reviewed Oct 7, 2024
View reviewed changes
Comment threadsrc/libraries/sendtohelix-browser.targets Outdated
ilonatommy
ilonatommy approved these changes Oct 7, 2024
View reviewed changes

@ilonatommyilonatommy left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be missing removal of this and places it's being called at:

Edit: it's not called from anywhere...

kasperk81
kasperk81 reviewed Oct 7, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
@pavelsavara

pavelsavara commented Oct 7, 2024

Copy link
Copy Markdown
MemberAuthor
  • UpdateRuntimeconfigTemplateForNode

Is used for wasmconsole template testing, which is V8. Do we want to drop that template too and simplify the host ?

@ilonatommy

ilonatommy commented Oct 7, 2024•
edited
Loading

Copy link
Copy Markdown
Member
  • UpdateRuntimeconfigTemplateForNode

Is used for wasmconsole template testing, which is V8. Do we want to drop that template too and simplify the host ?

We're not testing libs with v8 anymore, so that would make it consistent.
Edit: actually we are, in outerloop and extra-platforms. Sorry, then this argument does not make sense.

kasperk81
kasperk81 reviewed Oct 8, 2024
View reviewed changes
Comment threadsrc/libraries/sendtohelix-browser.targets Outdated
@maraf

maraf commented Oct 8, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Do we want to drop that template too and simplify the host ?

Yes, it can be done here or in a follow up.

Are we going to explicitly remove parts of typescript related to node?

@pavelsavara

pavelsavara commented Oct 8, 2024

Copy link
Copy Markdown
MemberAuthor

Do we want to drop that template too and simplify the host ?

Yes, it can be done here or in a follow up.

Let's do it in follow up.

@lewing please confirm we have quorum on removing console from dotnet new and dotnet run

Are we going to explicitly remove parts of typescript related to node?

Let's do that in yet another separate PR and we will see how many things there are. I guess it's not that many and possibly we could leave it in place.

@ilonatommy

ilonatommy commented Oct 8, 2024•
edited
Loading

Copy link
Copy Markdown
Member

I understand that we are using v8 to save resources during running tests, however I don't see much difference in the time used in
/p:Scenario=WasmTestOnChrome and /p:Scenario=WasmTestOnV8, checking biggest lib test project: System.Runtime.Tests (test count differs, so let's look at the averaged value)

V8: total="64976" time="122.362"
Chrome: total="64970" time="114.317" Averaged chome time if it had same number of tests as v8: 122,350

I am proposing:

lanecurrent scenariosfuture scenarioschanged?
LibraryTests LinuxWasmTestOnV8,WasmTestOnChrome,WasmTestOnFirefoxWasmTestOnChrome,WasmTestOnFirefoxY
LibraryTests WindowsWasmTestOnChromeWasmTestOnChromeN
LibraryTests_Smoke_AOT LinuxWasmTestOnV8WasmTestOnChromeY
LibraryTests_Smoke_AOT WindowsWasmTestOnChromeWasmTestOnChromeN
LibraryTests_EAT LinuxWasmTestOnV8WasmTestOnChromeY
LibraryTests_Threading LinuxWasmTestOnChrome,WasmTestOnFirefoxWasmTestOnChrome,WasmTestOnFirefoxN
extra-platformsWasmTestOnV8, WasmTestOnChromeWasmTestOnChromeY
outer-loopWasmTestOnV8WasmTestOnChromeY

@build-analysisbuild-analysisBot mentioned this pull request Oct 8, 2024
Closed
3 tasks
@ilonatommyilonatommy mentioned this pull request Oct 8, 2024
Closed
This was referenced Oct 8, 2024
Closed
Closed
Closed
Closed
@build-analysisbuild-analysisBot mentioned this pull request Oct 8, 2024
Closed
@ilonatommy

ilonatommy commented Oct 8, 2024

Copy link
Copy Markdown
Member

/ba-g failures are DebuggerTests, not related

@ilonatommy
ilonatommy merged commit 59a460a into dotnet:mainOct 8, 2024
@ilonatommyilonatommy mentioned this pull request Oct 9, 2024
Merged
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Nov 8, 2024
@ilonatommyilonatommy mentioned this pull request Jul 7, 2025
Merged
This was referenced Aug 26, 2025
Closed
Open
CopilotAI mentioned this pull request Aug 26, 2025
Closed
@ilonatommy

ilonatommy commented Aug 26, 2025

Copy link
Copy Markdown
Member

/backport to release/9.0-staging

@github-actionsgithub-actionsBot unlocked this conversation Aug 26, 2025
@github-actions

github-actionsBot commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/17240338021

@github-actions

github-actionsBot commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

@ilonatommy backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: stop testing with nodejs
Using index info to reconstruct a base tree...
M	eng/pipelines/runtime.yml
M	eng/testing/WasmRunnerTemplate.cmd
M	src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
M	src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
M	src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
M	src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
M	src/mono/wasm/Wasm.Build.Tests/ConfigSrcTests.cs
M	src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs
M	src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
M	src/mono/wasm/Wasm.Build.Tests/WasmSIMDTests.cs
M	src/mono/wasm/features.md
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/runtime.yml
CONFLICT (content): Merge conflict in eng/pipelines/runtime.yml
Auto-merging eng/testing/WasmRunnerTemplate.cmd
Auto-merging src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
Auto-merging src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
Auto-merging src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (modify/delete): src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs deleted in stop testing with nodejs and modified in HEAD. Version HEAD of src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs left in tree.
Auto-merging src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
Auto-merging src/mono/wasm/features.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 stop testing with nodejs
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actionsgithub-actionsBot locked as resolved and limited conversation to collaborators Aug 26, 2025
@pavelsavara
pavelsavara deleted the browser_stop_testing_with_nodejs branch September 10, 2025 12:58
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ilonatommyilonatommyilonatommy approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger is a code owner
@marafmarafAwaiting requested review from marafmaraf is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner
+1 more reviewer
@kasperk81kasperk81kasperk81 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara

@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Build-monoos-browserBrowser variant of arch-wasm

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pavelsavara@ilonatommy@maraf@kasperk81
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[browser] stop testing with nodejs - #108582
Merged
ilonatommy merged 4 commits into
dotnet:mainfrom 
pavelsavara:browser_stop_testing_with_nodejs
Oct 8, 2024
Merged
[browser] stop testing with nodejs#108582
ilonatommy merged 4 commits into
dotnet:mainfrom 
pavelsavara:browser_stop_testing_with_nodejs
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Oct 7, 2024•

edited by ilonatommy

Loading

Copy link


Copy Markdown

Member
To reduce WASM test matrix
  • removed pipelines
  • WasmTestOnNodeJS scenario
  • Wasm.Build.Tests tests
  • Old Blazor_net50 project that was added in [wasm] Don't use workload for tfm < net6.0 #56606 to be used in WBT but we started using different logic to test Blazor since then and it can be safely removed.
I left in place
  • PlatformDetection.IsNotNodeJS
    • HTTP & WS tests
    • Hybrid globalization tests
  • detection in `src\mono\browser\test-main.js
  • any production code
@pavelsavarapavelsavara
added

arch-wasm
WebAssembly architecture
area-Build-mono

os-browser
Browser variant of arch-wasm
labels
Oct 7, 2024
@pavelsavarapavelsavara
added this to the 10.0.0 milestone
Oct 7, 2024
@pavelsavarapavelsavara
self-assigned this
Oct 7, 2024
@pavelsavara
pavelsavara
marked this pull request as ready for review
October 7, 2024 12:34
ilonatommy
ilonatommy
reviewed
Oct 7, 2024
View reviewed changes
Comment threadsrc/libraries/sendtohelix-browser.targets
Outdated

ilonatommy
ilonatommy
approved these changes
Oct 7, 2024
View reviewed changes
@ilonatommyilonatommy
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be missing removal of this and places it's being called at:
Edit: it's not called from anywhere...
kasperk81
kasperk81
reviewed
Oct 7, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
@pavelsavara
pavelsavara
commented
Oct 7, 2024

Copy link


Copy Markdown

MemberAuthor
  • UpdateRuntimeconfigTemplateForNode
Is used for wasmconsole template testing, which is V8. Do we want to drop that template too and simplify the host ?
@ilonatommy
ilonatommy
commented
Oct 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
  • UpdateRuntimeconfigTemplateForNode
Is used for wasmconsole template testing, which is V8. Do we want to drop that template too and simplify the host ?
We're not testing libs with v8 anymore, so that would make it consistent.

Edit: actually we are, in outerloop and extra-platforms. Sorry, then this argument does not make sense.
kasperk81
kasperk81
reviewed
Oct 8, 2024
View reviewed changes
Comment threadsrc/libraries/sendtohelix-browser.targets
Outdated

@maraf
maraf
commented
Oct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Do we want to drop that template too and simplify the host ?
Yes, it can be done here or in a follow up.
Are we going to explicitly remove parts of typescript related to node?
@pavelsavara
pavelsavara
commented
Oct 8, 2024

Copy link


Copy Markdown

MemberAuthor
Do we want to drop that template too and simplify the host ?
Yes, it can be done here or in a follow up.
Let's do it in follow up.
@lewing please confirm we have quorum on removing console from dotnet new and dotnet run
Are we going to explicitly remove parts of typescript related to node?
Let's do that in yet another separate PR and we will see how many things there are. I guess it's not that many and possibly we could leave it in place.
@ilonatommy
ilonatommy
commented
Oct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Member
I understand that we are using v8 to save resources during running tests, however I don't see much difference in the time used in
/p:Scenario=WasmTestOnChrome and /p:Scenario=WasmTestOnV8, checking biggest lib test project: System.Runtime.Tests (test count differs, so let's look at the averaged value)
V8: total="64976" time="122.362"
Chrome: total="64970" time="114.317" Averaged chome time if it had same number of tests as v8: 122,350

I am proposing:
lanecurrent scenariosfuture scenarioschanged?
LibraryTests LinuxWasmTestOnV8,WasmTestOnChrome,WasmTestOnFirefoxWasmTestOnChrome,WasmTestOnFirefoxY
LibraryTests WindowsWasmTestOnChromeWasmTestOnChromeN
LibraryTests_Smoke_AOT LinuxWasmTestOnV8WasmTestOnChromeY
LibraryTests_Smoke_AOT WindowsWasmTestOnChromeWasmTestOnChromeN
LibraryTests_EAT LinuxWasmTestOnV8WasmTestOnChromeY
LibraryTests_Threading LinuxWasmTestOnChrome,WasmTestOnFirefoxWasmTestOnChrome,WasmTestOnFirefoxN
extra-platformsWasmTestOnV8, WasmTestOnChromeWasmTestOnChromeY
outer-loopWasmTestOnV8WasmTestOnChromeY
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 8, 2024

Closed

3 tasks
@ilonatommyilonatommy
mentioned this pull request
Oct 8, 2024

Closed


This was referenced Oct 8, 2024

Closed


Closed


Closed


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 8, 2024

Closed

@ilonatommy
ilonatommy
commented
Oct 8, 2024

Copy link


Copy Markdown

Member
/ba-g failures are DebuggerTests, not related
@ilonatommy
ilonatommy
merged commit 59a460a
into
dotnet:mainOct 8, 2024
@ilonatommyilonatommy
mentioned this pull request
Oct 9, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 8, 2024
@ilonatommyilonatommy
mentioned this pull request
Jul 7, 2025
 Merged


This was referenced Aug 26, 2025

Closed


Open

CopilotAI
mentioned this pull request
Aug 26, 2025
 Closed

@ilonatommy
ilonatommy
commented
Aug 26, 2025

Copy link


Copy Markdown

Member
/backport to release/9.0-staging
@github-actionsgithub-actionsBot
unlocked this conversation
Aug 26, 2025
@github-actions
github-actionsBot
commented
Aug 26, 2025

Copy link


Copy Markdown

Contributor
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/17240338021
@github-actions
github-actionsBot
commented
Aug 26, 2025

Copy link


Copy Markdown

Contributor
@ilonatommy backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts:
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: stop testing with nodejs
Using index info to reconstruct a base tree...
M	eng/pipelines/runtime.yml
M	eng/testing/WasmRunnerTemplate.cmd
M	src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
M	src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
M	src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
M	src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
M	src/mono/wasm/Wasm.Build.Tests/ConfigSrcTests.cs
M	src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs
M	src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
M	src/mono/wasm/Wasm.Build.Tests/WasmSIMDTests.cs
M	src/mono/wasm/features.md
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/runtime.yml
CONFLICT (content): Merge conflict in eng/pipelines/runtime.yml
Auto-merging eng/testing/WasmRunnerTemplate.cmd
Auto-merging src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
Auto-merging src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
Auto-merging src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (modify/delete): src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs deleted in stop testing with nodejs and modified in HEAD. Version HEAD of src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs left in tree.
Auto-merging src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
Auto-merging src/mono/wasm/features.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 stop testing with nodejs
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
Aug 26, 2025
@pavelsavara
pavelsavara
deleted the

browser_stop_testing_with_nodejs

branch
September 10, 2025 12:58
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ilonatommyilonatommyilonatommy approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger is a code owner
@marafmarafAwaiting requested review from marafmaraf is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner

+1 more reviewer

@kasperk81kasperk81kasperk81 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara
@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Build-monoos-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pavelsavara@ilonatommy@maraf@kasperk81

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[browser] stop testing with nodejs - #108582
Merged
ilonatommy merged 4 commits into
dotnet:mainfrom 
pavelsavara:browser_stop_testing_with_nodejs
Oct 8, 2024
Merged
[browser] stop testing with nodejs#108582
ilonatommy merged 4 commits into
dotnet:mainfrom 
pavelsavara:browser_stop_testing_with_nodejs
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Oct 7, 2024•

edited by ilonatommy

Loading

Copy link


Copy Markdown

Member
To reduce WASM test matrix
  • removed pipelines
  • WasmTestOnNodeJS scenario
  • Wasm.Build.Tests tests
  • Old Blazor_net50 project that was added in [wasm] Don't use workload for tfm < net6.0 #56606 to be used in WBT but we started using different logic to test Blazor since then and it can be safely removed.
I left in place
  • PlatformDetection.IsNotNodeJS
    • HTTP & WS tests
    • Hybrid globalization tests
  • detection in `src\mono\browser\test-main.js
  • any production code
@pavelsavarapavelsavara
added

arch-wasm
WebAssembly architecture
area-Build-mono

os-browser
Browser variant of arch-wasm
labels
Oct 7, 2024
@pavelsavarapavelsavara
added this to the 10.0.0 milestone
Oct 7, 2024
@pavelsavarapavelsavara
self-assigned this
Oct 7, 2024
@pavelsavara
pavelsavara
marked this pull request as ready for review
October 7, 2024 12:34
ilonatommy
ilonatommy
reviewed
Oct 7, 2024
View reviewed changes
Comment threadsrc/libraries/sendtohelix-browser.targets
Outdated

ilonatommy
ilonatommy
approved these changes
Oct 7, 2024
View reviewed changes
@ilonatommyilonatommy
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be missing removal of this and places it's being called at:
Edit: it's not called from anywhere...
kasperk81
kasperk81
reviewed
Oct 7, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
@pavelsavara
pavelsavara
commented
Oct 7, 2024

Copy link


Copy Markdown

MemberAuthor
  • UpdateRuntimeconfigTemplateForNode
Is used for wasmconsole template testing, which is V8. Do we want to drop that template too and simplify the host ?
@ilonatommy
ilonatommy
commented
Oct 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
  • UpdateRuntimeconfigTemplateForNode
Is used for wasmconsole template testing, which is V8. Do we want to drop that template too and simplify the host ?
We're not testing libs with v8 anymore, so that would make it consistent.

Edit: actually we are, in outerloop and extra-platforms. Sorry, then this argument does not make sense.
kasperk81
kasperk81
reviewed
Oct 8, 2024
View reviewed changes
Comment threadsrc/libraries/sendtohelix-browser.targets
Outdated

@maraf
maraf
commented
Oct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Do we want to drop that template too and simplify the host ?
Yes, it can be done here or in a follow up.
Are we going to explicitly remove parts of typescript related to node?
@pavelsavara
pavelsavara
commented
Oct 8, 2024

Copy link


Copy Markdown

MemberAuthor
Do we want to drop that template too and simplify the host ?
Yes, it can be done here or in a follow up.
Let's do it in follow up.
@lewing please confirm we have quorum on removing console from dotnet new and dotnet run
Are we going to explicitly remove parts of typescript related to node?
Let's do that in yet another separate PR and we will see how many things there are. I guess it's not that many and possibly we could leave it in place.
@ilonatommy
ilonatommy
commented
Oct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Member
I understand that we are using v8 to save resources during running tests, however I don't see much difference in the time used in
/p:Scenario=WasmTestOnChrome and /p:Scenario=WasmTestOnV8, checking biggest lib test project: System.Runtime.Tests (test count differs, so let's look at the averaged value)
V8: total="64976" time="122.362"
Chrome: total="64970" time="114.317" Averaged chome time if it had same number of tests as v8: 122,350

I am proposing:
lanecurrent scenariosfuture scenarioschanged?
LibraryTests LinuxWasmTestOnV8,WasmTestOnChrome,WasmTestOnFirefoxWasmTestOnChrome,WasmTestOnFirefoxY
LibraryTests WindowsWasmTestOnChromeWasmTestOnChromeN
LibraryTests_Smoke_AOT LinuxWasmTestOnV8WasmTestOnChromeY
LibraryTests_Smoke_AOT WindowsWasmTestOnChromeWasmTestOnChromeN
LibraryTests_EAT LinuxWasmTestOnV8WasmTestOnChromeY
LibraryTests_Threading LinuxWasmTestOnChrome,WasmTestOnFirefoxWasmTestOnChrome,WasmTestOnFirefoxN
extra-platformsWasmTestOnV8, WasmTestOnChromeWasmTestOnChromeY
outer-loopWasmTestOnV8WasmTestOnChromeY
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 8, 2024

Closed

3 tasks
@ilonatommyilonatommy
mentioned this pull request
Oct 8, 2024

Closed


This was referenced Oct 8, 2024

Closed


Closed


Closed


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 8, 2024

Closed

@ilonatommy
ilonatommy
commented
Oct 8, 2024

Copy link


Copy Markdown

Member
/ba-g failures are DebuggerTests, not related
@ilonatommy
ilonatommy
merged commit 59a460a
into
dotnet:mainOct 8, 2024
@ilonatommyilonatommy
mentioned this pull request
Oct 9, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 8, 2024
@ilonatommyilonatommy
mentioned this pull request
Jul 7, 2025
 Merged


This was referenced Aug 26, 2025

Closed


Open

CopilotAI
mentioned this pull request
Aug 26, 2025
 Closed

@ilonatommy
ilonatommy
commented
Aug 26, 2025

Copy link


Copy Markdown

Member
/backport to release/9.0-staging
@github-actionsgithub-actionsBot
unlocked this conversation
Aug 26, 2025
@github-actions
github-actionsBot
commented
Aug 26, 2025

Copy link


Copy Markdown

Contributor
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/17240338021
@github-actions
github-actionsBot
commented
Aug 26, 2025

Copy link


Copy Markdown

Contributor
@ilonatommy backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts:
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: stop testing with nodejs
Using index info to reconstruct a base tree...
M	eng/pipelines/runtime.yml
M	eng/testing/WasmRunnerTemplate.cmd
M	src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
M	src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
M	src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
M	src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
M	src/mono/wasm/Wasm.Build.Tests/ConfigSrcTests.cs
M	src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs
M	src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
M	src/mono/wasm/Wasm.Build.Tests/WasmSIMDTests.cs
M	src/mono/wasm/features.md
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/runtime.yml
CONFLICT (content): Merge conflict in eng/pipelines/runtime.yml
Auto-merging eng/testing/WasmRunnerTemplate.cmd
Auto-merging src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
Auto-merging src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
Auto-merging src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (modify/delete): src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs deleted in stop testing with nodejs and modified in HEAD. Version HEAD of src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs left in tree.
Auto-merging src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
Auto-merging src/mono/wasm/features.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 stop testing with nodejs
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
Aug 26, 2025
@pavelsavara
pavelsavara
deleted the

browser_stop_testing_with_nodejs

branch
September 10, 2025 12:58
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ilonatommyilonatommyilonatommy approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger is a code owner
@marafmarafAwaiting requested review from marafmaraf is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner

+1 more reviewer

@kasperk81kasperk81kasperk81 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara
@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Build-monoos-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pavelsavara@ilonatommy@maraf@kasperk81

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[browser] stop testing with nodejs - #108582
Merged
ilonatommy merged 4 commits into
dotnet:mainfrom 
pavelsavara:browser_stop_testing_with_nodejs
Oct 8, 2024
Merged
[browser] stop testing with nodejs#108582
ilonatommy merged 4 commits into
dotnet:mainfrom 
pavelsavara:browser_stop_testing_with_nodejs
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Oct 7, 2024•

edited by ilonatommy

Loading

Copy link


Copy Markdown

Member
To reduce WASM test matrix
  • removed pipelines
  • WasmTestOnNodeJS scenario
  • Wasm.Build.Tests tests
  • Old Blazor_net50 project that was added in [wasm] Don't use workload for tfm < net6.0 #56606 to be used in WBT but we started using different logic to test Blazor since then and it can be safely removed.
I left in place
  • PlatformDetection.IsNotNodeJS
    • HTTP & WS tests
    • Hybrid globalization tests
  • detection in `src\mono\browser\test-main.js
  • any production code
@pavelsavarapavelsavara
added

arch-wasm
WebAssembly architecture
area-Build-mono

os-browser
Browser variant of arch-wasm
labels
Oct 7, 2024
@pavelsavarapavelsavara
added this to the 10.0.0 milestone
Oct 7, 2024
@pavelsavarapavelsavara
self-assigned this
Oct 7, 2024
@pavelsavara
pavelsavara
marked this pull request as ready for review
October 7, 2024 12:34
ilonatommy
ilonatommy
reviewed
Oct 7, 2024
View reviewed changes
Comment threadsrc/libraries/sendtohelix-browser.targets
Outdated

ilonatommy
ilonatommy
approved these changes
Oct 7, 2024
View reviewed changes
@ilonatommyilonatommy
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be missing removal of this and places it's being called at:
Edit: it's not called from anywhere...
kasperk81
kasperk81
reviewed
Oct 7, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
@pavelsavara
pavelsavara
commented
Oct 7, 2024

Copy link


Copy Markdown

MemberAuthor
  • UpdateRuntimeconfigTemplateForNode
Is used for wasmconsole template testing, which is V8. Do we want to drop that template too and simplify the host ?
@ilonatommy
ilonatommy
commented
Oct 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
  • UpdateRuntimeconfigTemplateForNode
Is used for wasmconsole template testing, which is V8. Do we want to drop that template too and simplify the host ?
We're not testing libs with v8 anymore, so that would make it consistent.

Edit: actually we are, in outerloop and extra-platforms. Sorry, then this argument does not make sense.
kasperk81
kasperk81
reviewed
Oct 8, 2024
View reviewed changes
Comment threadsrc/libraries/sendtohelix-browser.targets
Outdated

@maraf
maraf
commented
Oct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Do we want to drop that template too and simplify the host ?
Yes, it can be done here or in a follow up.
Are we going to explicitly remove parts of typescript related to node?
@pavelsavara
pavelsavara
commented
Oct 8, 2024

Copy link


Copy Markdown

MemberAuthor
Do we want to drop that template too and simplify the host ?
Yes, it can be done here or in a follow up.
Let's do it in follow up.
@lewing please confirm we have quorum on removing console from dotnet new and dotnet run
Are we going to explicitly remove parts of typescript related to node?
Let's do that in yet another separate PR and we will see how many things there are. I guess it's not that many and possibly we could leave it in place.
@ilonatommy
ilonatommy
commented
Oct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Member
I understand that we are using v8 to save resources during running tests, however I don't see much difference in the time used in
/p:Scenario=WasmTestOnChrome and /p:Scenario=WasmTestOnV8, checking biggest lib test project: System.Runtime.Tests (test count differs, so let's look at the averaged value)
V8: total="64976" time="122.362"
Chrome: total="64970" time="114.317" Averaged chome time if it had same number of tests as v8: 122,350

I am proposing:
lanecurrent scenariosfuture scenarioschanged?
LibraryTests LinuxWasmTestOnV8,WasmTestOnChrome,WasmTestOnFirefoxWasmTestOnChrome,WasmTestOnFirefoxY
LibraryTests WindowsWasmTestOnChromeWasmTestOnChromeN
LibraryTests_Smoke_AOT LinuxWasmTestOnV8WasmTestOnChromeY
LibraryTests_Smoke_AOT WindowsWasmTestOnChromeWasmTestOnChromeN
LibraryTests_EAT LinuxWasmTestOnV8WasmTestOnChromeY
LibraryTests_Threading LinuxWasmTestOnChrome,WasmTestOnFirefoxWasmTestOnChrome,WasmTestOnFirefoxN
extra-platformsWasmTestOnV8, WasmTestOnChromeWasmTestOnChromeY
outer-loopWasmTestOnV8WasmTestOnChromeY
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 8, 2024

Closed

3 tasks
@ilonatommyilonatommy
mentioned this pull request
Oct 8, 2024

Closed


This was referenced Oct 8, 2024

Closed


Closed


Closed


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 8, 2024

Closed

@ilonatommy
ilonatommy
commented
Oct 8, 2024

Copy link


Copy Markdown

Member
/ba-g failures are DebuggerTests, not related
@ilonatommy
ilonatommy
merged commit 59a460a
into
dotnet:mainOct 8, 2024
@ilonatommyilonatommy
mentioned this pull request
Oct 9, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 8, 2024
@ilonatommyilonatommy
mentioned this pull request
Jul 7, 2025
 Merged


This was referenced Aug 26, 2025

Closed


Open

CopilotAI
mentioned this pull request
Aug 26, 2025
 Closed

@ilonatommy
ilonatommy
commented
Aug 26, 2025

Copy link


Copy Markdown

Member
/backport to release/9.0-staging
@github-actionsgithub-actionsBot
unlocked this conversation
Aug 26, 2025
@github-actions
github-actionsBot
commented
Aug 26, 2025

Copy link


Copy Markdown

Contributor
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/17240338021
@github-actions
github-actionsBot
commented
Aug 26, 2025

Copy link


Copy Markdown

Contributor
@ilonatommy backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts:
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: stop testing with nodejs
Using index info to reconstruct a base tree...
M	eng/pipelines/runtime.yml
M	eng/testing/WasmRunnerTemplate.cmd
M	src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
M	src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
M	src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
M	src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
M	src/mono/wasm/Wasm.Build.Tests/ConfigSrcTests.cs
M	src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs
M	src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
M	src/mono/wasm/Wasm.Build.Tests/WasmSIMDTests.cs
M	src/mono/wasm/features.md
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/runtime.yml
CONFLICT (content): Merge conflict in eng/pipelines/runtime.yml
Auto-merging eng/testing/WasmRunnerTemplate.cmd
Auto-merging src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
Auto-merging src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
Auto-merging src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (modify/delete): src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs deleted in stop testing with nodejs and modified in HEAD. Version HEAD of src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs left in tree.
Auto-merging src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
Auto-merging src/mono/wasm/features.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 stop testing with nodejs
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
Aug 26, 2025
@pavelsavara
pavelsavara
deleted the

browser_stop_testing_with_nodejs

branch
September 10, 2025 12:58
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ilonatommyilonatommyilonatommy approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger is a code owner
@marafmarafAwaiting requested review from marafmaraf is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner

+1 more reviewer

@kasperk81kasperk81kasperk81 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara
@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Build-monoos-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pavelsavara@ilonatommy@maraf@kasperk81

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[browser] stop testing with nodejs - #108582
Merged
ilonatommy merged 4 commits into
dotnet:mainfrom 
pavelsavara:browser_stop_testing_with_nodejs
Oct 8, 2024
Merged
[browser] stop testing with nodejs#108582
ilonatommy merged 4 commits into
dotnet:mainfrom 
pavelsavara:browser_stop_testing_with_nodejs
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Oct 7, 2024•

edited by ilonatommy

Loading

Copy link


Copy Markdown

Member
To reduce WASM test matrix
  • removed pipelines
  • WasmTestOnNodeJS scenario
  • Wasm.Build.Tests tests
  • Old Blazor_net50 project that was added in [wasm] Don't use workload for tfm < net6.0 #56606 to be used in WBT but we started using different logic to test Blazor since then and it can be safely removed.
I left in place
  • PlatformDetection.IsNotNodeJS
    • HTTP & WS tests
    • Hybrid globalization tests
  • detection in `src\mono\browser\test-main.js
  • any production code
@pavelsavarapavelsavara
added

arch-wasm
WebAssembly architecture
area-Build-mono

os-browser
Browser variant of arch-wasm
labels
Oct 7, 2024
@pavelsavarapavelsavara
added this to the 10.0.0 milestone
Oct 7, 2024
@pavelsavarapavelsavara
self-assigned this
Oct 7, 2024
@pavelsavara
pavelsavara
marked this pull request as ready for review
October 7, 2024 12:34
ilonatommy
ilonatommy
reviewed
Oct 7, 2024
View reviewed changes
Comment threadsrc/libraries/sendtohelix-browser.targets
Outdated

ilonatommy
ilonatommy
approved these changes
Oct 7, 2024
View reviewed changes
@ilonatommyilonatommy
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be missing removal of this and places it's being called at:
Edit: it's not called from anywhere...
kasperk81
kasperk81
reviewed
Oct 7, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
@pavelsavara
pavelsavara
commented
Oct 7, 2024

Copy link


Copy Markdown

MemberAuthor
  • UpdateRuntimeconfigTemplateForNode
Is used for wasmconsole template testing, which is V8. Do we want to drop that template too and simplify the host ?
@ilonatommy
ilonatommy
commented
Oct 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
  • UpdateRuntimeconfigTemplateForNode
Is used for wasmconsole template testing, which is V8. Do we want to drop that template too and simplify the host ?
We're not testing libs with v8 anymore, so that would make it consistent.

Edit: actually we are, in outerloop and extra-platforms. Sorry, then this argument does not make sense.
kasperk81
kasperk81
reviewed
Oct 8, 2024
View reviewed changes
Comment threadsrc/libraries/sendtohelix-browser.targets
Outdated

@maraf
maraf
commented
Oct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Do we want to drop that template too and simplify the host ?
Yes, it can be done here or in a follow up.
Are we going to explicitly remove parts of typescript related to node?
@pavelsavara
pavelsavara
commented
Oct 8, 2024

Copy link


Copy Markdown

MemberAuthor
Do we want to drop that template too and simplify the host ?
Yes, it can be done here or in a follow up.
Let's do it in follow up.
@lewing please confirm we have quorum on removing console from dotnet new and dotnet run
Are we going to explicitly remove parts of typescript related to node?
Let's do that in yet another separate PR and we will see how many things there are. I guess it's not that many and possibly we could leave it in place.
@ilonatommy
ilonatommy
commented
Oct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Member
I understand that we are using v8 to save resources during running tests, however I don't see much difference in the time used in
/p:Scenario=WasmTestOnChrome and /p:Scenario=WasmTestOnV8, checking biggest lib test project: System.Runtime.Tests (test count differs, so let's look at the averaged value)
V8: total="64976" time="122.362"
Chrome: total="64970" time="114.317" Averaged chome time if it had same number of tests as v8: 122,350

I am proposing:
lanecurrent scenariosfuture scenarioschanged?
LibraryTests LinuxWasmTestOnV8,WasmTestOnChrome,WasmTestOnFirefoxWasmTestOnChrome,WasmTestOnFirefoxY
LibraryTests WindowsWasmTestOnChromeWasmTestOnChromeN
LibraryTests_Smoke_AOT LinuxWasmTestOnV8WasmTestOnChromeY
LibraryTests_Smoke_AOT WindowsWasmTestOnChromeWasmTestOnChromeN
LibraryTests_EAT LinuxWasmTestOnV8WasmTestOnChromeY
LibraryTests_Threading LinuxWasmTestOnChrome,WasmTestOnFirefoxWasmTestOnChrome,WasmTestOnFirefoxN
extra-platformsWasmTestOnV8, WasmTestOnChromeWasmTestOnChromeY
outer-loopWasmTestOnV8WasmTestOnChromeY
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 8, 2024

Closed

3 tasks
@ilonatommyilonatommy
mentioned this pull request
Oct 8, 2024

Closed


This was referenced Oct 8, 2024

Closed


Closed


Closed


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 8, 2024

Closed

@ilonatommy
ilonatommy
commented
Oct 8, 2024

Copy link


Copy Markdown

Member
/ba-g failures are DebuggerTests, not related
@ilonatommy
ilonatommy
merged commit 59a460a
into
dotnet:mainOct 8, 2024
@ilonatommyilonatommy
mentioned this pull request
Oct 9, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 8, 2024
@ilonatommyilonatommy
mentioned this pull request
Jul 7, 2025
 Merged


This was referenced Aug 26, 2025

Closed


Open

CopilotAI
mentioned this pull request
Aug 26, 2025
 Closed

@ilonatommy
ilonatommy
commented
Aug 26, 2025

Copy link


Copy Markdown

Member
/backport to release/9.0-staging
@github-actionsgithub-actionsBot
unlocked this conversation
Aug 26, 2025
@github-actions
github-actionsBot
commented
Aug 26, 2025

Copy link


Copy Markdown

Contributor
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/17240338021
@github-actions
github-actionsBot
commented
Aug 26, 2025

Copy link


Copy Markdown

Contributor
@ilonatommy backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts:
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: stop testing with nodejs
Using index info to reconstruct a base tree...
M	eng/pipelines/runtime.yml
M	eng/testing/WasmRunnerTemplate.cmd
M	src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
M	src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
M	src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
M	src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
M	src/mono/wasm/Wasm.Build.Tests/ConfigSrcTests.cs
M	src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs
M	src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
M	src/mono/wasm/Wasm.Build.Tests/WasmSIMDTests.cs
M	src/mono/wasm/features.md
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/runtime.yml
CONFLICT (content): Merge conflict in eng/pipelines/runtime.yml
Auto-merging eng/testing/WasmRunnerTemplate.cmd
Auto-merging src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
Auto-merging src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
Auto-merging src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (modify/delete): src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs deleted in stop testing with nodejs and modified in HEAD. Version HEAD of src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs left in tree.
Auto-merging src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
Auto-merging src/mono/wasm/features.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 stop testing with nodejs
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
Aug 26, 2025
@pavelsavara
pavelsavara
deleted the

browser_stop_testing_with_nodejs

branch
September 10, 2025 12:58
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ilonatommyilonatommyilonatommy approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger is a code owner
@marafmarafAwaiting requested review from marafmaraf is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner

+1 more reviewer

@kasperk81kasperk81kasperk81 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara
@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Build-monoos-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pavelsavara@ilonatommy@maraf@kasperk81

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[browser] stop testing with nodejs - #108582
Merged
ilonatommy merged 4 commits into
dotnet:mainfrom 
pavelsavara:browser_stop_testing_with_nodejs
Oct 8, 2024
Merged
[browser] stop testing with nodejs#108582
ilonatommy merged 4 commits into
dotnet:mainfrom 
pavelsavara:browser_stop_testing_with_nodejs
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Oct 7, 2024•

edited by ilonatommy

Loading

Copy link


Copy Markdown

Member
To reduce WASM test matrix
  • removed pipelines
  • WasmTestOnNodeJS scenario
  • Wasm.Build.Tests tests
  • Old Blazor_net50 project that was added in [wasm] Don't use workload for tfm < net6.0 #56606 to be used in WBT but we started using different logic to test Blazor since then and it can be safely removed.
I left in place
  • PlatformDetection.IsNotNodeJS
    • HTTP & WS tests
    • Hybrid globalization tests
  • detection in `src\mono\browser\test-main.js
  • any production code
@pavelsavarapavelsavara
added

arch-wasm
WebAssembly architecture
area-Build-mono

os-browser
Browser variant of arch-wasm
labels
Oct 7, 2024
@pavelsavarapavelsavara
added this to the 10.0.0 milestone
Oct 7, 2024
@pavelsavarapavelsavara
self-assigned this
Oct 7, 2024
@pavelsavara
pavelsavara
marked this pull request as ready for review
October 7, 2024 12:34
ilonatommy
ilonatommy
reviewed
Oct 7, 2024
View reviewed changes
Comment threadsrc/libraries/sendtohelix-browser.targets
Outdated

ilonatommy
ilonatommy
approved these changes
Oct 7, 2024
View reviewed changes
@ilonatommyilonatommy
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be missing removal of this and places it's being called at:
Edit: it's not called from anywhere...
kasperk81
kasperk81
reviewed
Oct 7, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
@pavelsavara
pavelsavara
commented
Oct 7, 2024

Copy link


Copy Markdown

MemberAuthor
  • UpdateRuntimeconfigTemplateForNode
Is used for wasmconsole template testing, which is V8. Do we want to drop that template too and simplify the host ?
@ilonatommy
ilonatommy
commented
Oct 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
  • UpdateRuntimeconfigTemplateForNode
Is used for wasmconsole template testing, which is V8. Do we want to drop that template too and simplify the host ?
We're not testing libs with v8 anymore, so that would make it consistent.

Edit: actually we are, in outerloop and extra-platforms. Sorry, then this argument does not make sense.
kasperk81
kasperk81
reviewed
Oct 8, 2024
View reviewed changes
Comment threadsrc/libraries/sendtohelix-browser.targets
Outdated

@maraf
maraf
commented
Oct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Do we want to drop that template too and simplify the host ?
Yes, it can be done here or in a follow up.
Are we going to explicitly remove parts of typescript related to node?
@pavelsavara
pavelsavara
commented
Oct 8, 2024

Copy link


Copy Markdown

MemberAuthor
Do we want to drop that template too and simplify the host ?
Yes, it can be done here or in a follow up.
Let's do it in follow up.
@lewing please confirm we have quorum on removing console from dotnet new and dotnet run
Are we going to explicitly remove parts of typescript related to node?
Let's do that in yet another separate PR and we will see how many things there are. I guess it's not that many and possibly we could leave it in place.
@ilonatommy
ilonatommy
commented
Oct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Member
I understand that we are using v8 to save resources during running tests, however I don't see much difference in the time used in
/p:Scenario=WasmTestOnChrome and /p:Scenario=WasmTestOnV8, checking biggest lib test project: System.Runtime.Tests (test count differs, so let's look at the averaged value)
V8: total="64976" time="122.362"
Chrome: total="64970" time="114.317" Averaged chome time if it had same number of tests as v8: 122,350

I am proposing:
lanecurrent scenariosfuture scenarioschanged?
LibraryTests LinuxWasmTestOnV8,WasmTestOnChrome,WasmTestOnFirefoxWasmTestOnChrome,WasmTestOnFirefoxY
LibraryTests WindowsWasmTestOnChromeWasmTestOnChromeN
LibraryTests_Smoke_AOT LinuxWasmTestOnV8WasmTestOnChromeY
LibraryTests_Smoke_AOT WindowsWasmTestOnChromeWasmTestOnChromeN
LibraryTests_EAT LinuxWasmTestOnV8WasmTestOnChromeY
LibraryTests_Threading LinuxWasmTestOnChrome,WasmTestOnFirefoxWasmTestOnChrome,WasmTestOnFirefoxN
extra-platformsWasmTestOnV8, WasmTestOnChromeWasmTestOnChromeY
outer-loopWasmTestOnV8WasmTestOnChromeY
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 8, 2024

Closed

3 tasks
@ilonatommyilonatommy
mentioned this pull request
Oct 8, 2024

Closed


This was referenced Oct 8, 2024

Closed


Closed


Closed


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 8, 2024

Closed

@ilonatommy
ilonatommy
commented
Oct 8, 2024

Copy link


Copy Markdown

Member
/ba-g failures are DebuggerTests, not related
@ilonatommy
ilonatommy
merged commit 59a460a
into
dotnet:mainOct 8, 2024
@ilonatommyilonatommy
mentioned this pull request
Oct 9, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 8, 2024
@ilonatommyilonatommy
mentioned this pull request
Jul 7, 2025
 Merged


This was referenced Aug 26, 2025

Closed


Open

CopilotAI
mentioned this pull request
Aug 26, 2025
 Closed

@ilonatommy
ilonatommy
commented
Aug 26, 2025

Copy link


Copy Markdown

Member
/backport to release/9.0-staging
@github-actionsgithub-actionsBot
unlocked this conversation
Aug 26, 2025
@github-actions
github-actionsBot
commented
Aug 26, 2025

Copy link


Copy Markdown

Contributor
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/17240338021
@github-actions
github-actionsBot
commented
Aug 26, 2025

Copy link


Copy Markdown

Contributor
@ilonatommy backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts:
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: stop testing with nodejs
Using index info to reconstruct a base tree...
M	eng/pipelines/runtime.yml
M	eng/testing/WasmRunnerTemplate.cmd
M	src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
M	src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
M	src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
M	src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
M	src/mono/wasm/Wasm.Build.Tests/ConfigSrcTests.cs
M	src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs
M	src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
M	src/mono/wasm/Wasm.Build.Tests/WasmSIMDTests.cs
M	src/mono/wasm/features.md
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/runtime.yml
CONFLICT (content): Merge conflict in eng/pipelines/runtime.yml
Auto-merging eng/testing/WasmRunnerTemplate.cmd
Auto-merging src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
Auto-merging src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
Auto-merging src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (modify/delete): src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs deleted in stop testing with nodejs and modified in HEAD. Version HEAD of src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs left in tree.
Auto-merging src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
Auto-merging src/mono/wasm/features.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 stop testing with nodejs
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
Aug 26, 2025
@pavelsavara
pavelsavara
deleted the

browser_stop_testing_with_nodejs

branch
September 10, 2025 12:58
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ilonatommyilonatommyilonatommy approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger is a code owner
@marafmarafAwaiting requested review from marafmaraf is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner

+1 more reviewer

@kasperk81kasperk81kasperk81 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara
@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Build-monoos-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pavelsavara@ilonatommy@maraf@kasperk81

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[browser] stop testing with nodejs - #108582
Merged
ilonatommy merged 4 commits into
dotnet:mainfrom 
pavelsavara:browser_stop_testing_with_nodejs
Oct 8, 2024
Merged
[browser] stop testing with nodejs#108582
ilonatommy merged 4 commits into
dotnet:mainfrom 
pavelsavara:browser_stop_testing_with_nodejs
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Oct 7, 2024•

edited by ilonatommy

Loading

Copy link


Copy Markdown

Member
To reduce WASM test matrix
  • removed pipelines
  • WasmTestOnNodeJS scenario
  • Wasm.Build.Tests tests
  • Old Blazor_net50 project that was added in [wasm] Don't use workload for tfm < net6.0 #56606 to be used in WBT but we started using different logic to test Blazor since then and it can be safely removed.
I left in place
  • PlatformDetection.IsNotNodeJS
    • HTTP & WS tests
    • Hybrid globalization tests
  • detection in `src\mono\browser\test-main.js
  • any production code
@pavelsavarapavelsavara
added

arch-wasm
WebAssembly architecture
area-Build-mono

os-browser
Browser variant of arch-wasm
labels
Oct 7, 2024
@pavelsavarapavelsavara
added this to the 10.0.0 milestone
Oct 7, 2024
@pavelsavarapavelsavara
self-assigned this
Oct 7, 2024
@pavelsavara
pavelsavara
marked this pull request as ready for review
October 7, 2024 12:34
ilonatommy
ilonatommy
reviewed
Oct 7, 2024
View reviewed changes
Comment threadsrc/libraries/sendtohelix-browser.targets
Outdated

ilonatommy
ilonatommy
approved these changes
Oct 7, 2024
View reviewed changes
@ilonatommyilonatommy
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be missing removal of this and places it's being called at:
Edit: it's not called from anywhere...
kasperk81
kasperk81
reviewed
Oct 7, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
@pavelsavara
pavelsavara
commented
Oct 7, 2024

Copy link


Copy Markdown

MemberAuthor
  • UpdateRuntimeconfigTemplateForNode
Is used for wasmconsole template testing, which is V8. Do we want to drop that template too and simplify the host ?
@ilonatommy
ilonatommy
commented
Oct 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
  • UpdateRuntimeconfigTemplateForNode
Is used for wasmconsole template testing, which is V8. Do we want to drop that template too and simplify the host ?
We're not testing libs with v8 anymore, so that would make it consistent.

Edit: actually we are, in outerloop and extra-platforms. Sorry, then this argument does not make sense.
kasperk81
kasperk81
reviewed
Oct 8, 2024
View reviewed changes
Comment threadsrc/libraries/sendtohelix-browser.targets
Outdated

@maraf
maraf
commented
Oct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Do we want to drop that template too and simplify the host ?
Yes, it can be done here or in a follow up.
Are we going to explicitly remove parts of typescript related to node?
@pavelsavara
pavelsavara
commented
Oct 8, 2024

Copy link


Copy Markdown

MemberAuthor
Do we want to drop that template too and simplify the host ?
Yes, it can be done here or in a follow up.
Let's do it in follow up.
@lewing please confirm we have quorum on removing console from dotnet new and dotnet run
Are we going to explicitly remove parts of typescript related to node?
Let's do that in yet another separate PR and we will see how many things there are. I guess it's not that many and possibly we could leave it in place.
@ilonatommy
ilonatommy
commented
Oct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Member
I understand that we are using v8 to save resources during running tests, however I don't see much difference in the time used in
/p:Scenario=WasmTestOnChrome and /p:Scenario=WasmTestOnV8, checking biggest lib test project: System.Runtime.Tests (test count differs, so let's look at the averaged value)
V8: total="64976" time="122.362"
Chrome: total="64970" time="114.317" Averaged chome time if it had same number of tests as v8: 122,350

I am proposing:
lanecurrent scenariosfuture scenarioschanged?
LibraryTests LinuxWasmTestOnV8,WasmTestOnChrome,WasmTestOnFirefoxWasmTestOnChrome,WasmTestOnFirefoxY
LibraryTests WindowsWasmTestOnChromeWasmTestOnChromeN
LibraryTests_Smoke_AOT LinuxWasmTestOnV8WasmTestOnChromeY
LibraryTests_Smoke_AOT WindowsWasmTestOnChromeWasmTestOnChromeN
LibraryTests_EAT LinuxWasmTestOnV8WasmTestOnChromeY
LibraryTests_Threading LinuxWasmTestOnChrome,WasmTestOnFirefoxWasmTestOnChrome,WasmTestOnFirefoxN
extra-platformsWasmTestOnV8, WasmTestOnChromeWasmTestOnChromeY
outer-loopWasmTestOnV8WasmTestOnChromeY
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 8, 2024

Closed

3 tasks
@ilonatommyilonatommy
mentioned this pull request
Oct 8, 2024

Closed


This was referenced Oct 8, 2024

Closed


Closed


Closed


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 8, 2024

Closed

@ilonatommy
ilonatommy
commented
Oct 8, 2024

Copy link


Copy Markdown

Member
/ba-g failures are DebuggerTests, not related
@ilonatommy
ilonatommy
merged commit 59a460a
into
dotnet:mainOct 8, 2024
@ilonatommyilonatommy
mentioned this pull request
Oct 9, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 8, 2024
@ilonatommyilonatommy
mentioned this pull request
Jul 7, 2025
 Merged


This was referenced Aug 26, 2025

Closed


Open

CopilotAI
mentioned this pull request
Aug 26, 2025
 Closed

@ilonatommy
ilonatommy
commented
Aug 26, 2025

Copy link


Copy Markdown

Member
/backport to release/9.0-staging
@github-actionsgithub-actionsBot
unlocked this conversation
Aug 26, 2025
@github-actions
github-actionsBot
commented
Aug 26, 2025

Copy link


Copy Markdown

Contributor
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/17240338021
@github-actions
github-actionsBot
commented
Aug 26, 2025

Copy link


Copy Markdown

Contributor
@ilonatommy backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts:
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: stop testing with nodejs
Using index info to reconstruct a base tree...
M	eng/pipelines/runtime.yml
M	eng/testing/WasmRunnerTemplate.cmd
M	src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
M	src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
M	src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
M	src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
M	src/mono/wasm/Wasm.Build.Tests/ConfigSrcTests.cs
M	src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs
M	src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
M	src/mono/wasm/Wasm.Build.Tests/WasmSIMDTests.cs
M	src/mono/wasm/features.md
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/runtime.yml
CONFLICT (content): Merge conflict in eng/pipelines/runtime.yml
Auto-merging eng/testing/WasmRunnerTemplate.cmd
Auto-merging src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
Auto-merging src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
Auto-merging src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (modify/delete): src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs deleted in stop testing with nodejs and modified in HEAD. Version HEAD of src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs left in tree.
Auto-merging src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
Auto-merging src/mono/wasm/features.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 stop testing with nodejs
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
Aug 26, 2025
@pavelsavara
pavelsavara
deleted the

browser_stop_testing_with_nodejs

branch
September 10, 2025 12:58
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ilonatommyilonatommyilonatommy approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger is a code owner
@marafmarafAwaiting requested review from marafmaraf is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner

+1 more reviewer

@kasperk81kasperk81kasperk81 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara
@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Build-monoos-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pavelsavara@ilonatommy@maraf@kasperk81

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[browser] stop testing with nodejs - #108582
Merged
ilonatommy merged 4 commits into
dotnet:mainfrom 
pavelsavara:browser_stop_testing_with_nodejs
Oct 8, 2024
Merged
[browser] stop testing with nodejs#108582
ilonatommy merged 4 commits into
dotnet:mainfrom 
pavelsavara:browser_stop_testing_with_nodejs
Conversation
@pavelsavara
@pavelsavarapavelsavara
commented
Oct 7, 2024•

edited by ilonatommy

Loading

Copy link


Copy Markdown

Member
To reduce WASM test matrix
  • removed pipelines
  • WasmTestOnNodeJS scenario
  • Wasm.Build.Tests tests
  • Old Blazor_net50 project that was added in [wasm] Don't use workload for tfm < net6.0 #56606 to be used in WBT but we started using different logic to test Blazor since then and it can be safely removed.
I left in place
  • PlatformDetection.IsNotNodeJS
    • HTTP & WS tests
    • Hybrid globalization tests
  • detection in `src\mono\browser\test-main.js
  • any production code
@pavelsavarapavelsavara
added

arch-wasm
WebAssembly architecture
area-Build-mono

os-browser
Browser variant of arch-wasm
labels
Oct 7, 2024
@pavelsavarapavelsavara
added this to the 10.0.0 milestone
Oct 7, 2024
@pavelsavarapavelsavara
self-assigned this
Oct 7, 2024
@pavelsavara
pavelsavara
marked this pull request as ready for review
October 7, 2024 12:34
ilonatommy
ilonatommy
reviewed
Oct 7, 2024
View reviewed changes
Comment threadsrc/libraries/sendtohelix-browser.targets
Outdated

ilonatommy
ilonatommy
approved these changes
Oct 7, 2024
View reviewed changes
@ilonatommyilonatommy
left a comment
•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might be missing removal of this and places it's being called at:
Edit: it's not called from anywhere...
kasperk81
kasperk81
reviewed
Oct 7, 2024
View reviewed changes
Comment threadsrc/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
@pavelsavara
pavelsavara
commented
Oct 7, 2024

Copy link


Copy Markdown

MemberAuthor
  • UpdateRuntimeconfigTemplateForNode
Is used for wasmconsole template testing, which is V8. Do we want to drop that template too and simplify the host ?
@ilonatommy
ilonatommy
commented
Oct 7, 2024•

edited

Loading

Copy link


Copy Markdown

Member
  • UpdateRuntimeconfigTemplateForNode
Is used for wasmconsole template testing, which is V8. Do we want to drop that template too and simplify the host ?
We're not testing libs with v8 anymore, so that would make it consistent.

Edit: actually we are, in outerloop and extra-platforms. Sorry, then this argument does not make sense.
kasperk81
kasperk81
reviewed
Oct 8, 2024
View reviewed changes
Comment threadsrc/libraries/sendtohelix-browser.targets
Outdated

@maraf
maraf
commented
Oct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Member
Do we want to drop that template too and simplify the host ?
Yes, it can be done here or in a follow up.
Are we going to explicitly remove parts of typescript related to node?
@pavelsavara
pavelsavara
commented
Oct 8, 2024

Copy link


Copy Markdown

MemberAuthor
Do we want to drop that template too and simplify the host ?
Yes, it can be done here or in a follow up.
Let's do it in follow up.
@lewing please confirm we have quorum on removing console from dotnet new and dotnet run
Are we going to explicitly remove parts of typescript related to node?
Let's do that in yet another separate PR and we will see how many things there are. I guess it's not that many and possibly we could leave it in place.
@ilonatommy
ilonatommy
commented
Oct 8, 2024•

edited

Loading

Copy link


Copy Markdown

Member
I understand that we are using v8 to save resources during running tests, however I don't see much difference in the time used in
/p:Scenario=WasmTestOnChrome and /p:Scenario=WasmTestOnV8, checking biggest lib test project: System.Runtime.Tests (test count differs, so let's look at the averaged value)
V8: total="64976" time="122.362"
Chrome: total="64970" time="114.317" Averaged chome time if it had same number of tests as v8: 122,350

I am proposing:
lanecurrent scenariosfuture scenarioschanged?
LibraryTests LinuxWasmTestOnV8,WasmTestOnChrome,WasmTestOnFirefoxWasmTestOnChrome,WasmTestOnFirefoxY
LibraryTests WindowsWasmTestOnChromeWasmTestOnChromeN
LibraryTests_Smoke_AOT LinuxWasmTestOnV8WasmTestOnChromeY
LibraryTests_Smoke_AOT WindowsWasmTestOnChromeWasmTestOnChromeN
LibraryTests_EAT LinuxWasmTestOnV8WasmTestOnChromeY
LibraryTests_Threading LinuxWasmTestOnChrome,WasmTestOnFirefoxWasmTestOnChrome,WasmTestOnFirefoxN
extra-platformsWasmTestOnV8, WasmTestOnChromeWasmTestOnChromeY
outer-loopWasmTestOnV8WasmTestOnChromeY
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 8, 2024

Closed

3 tasks
@ilonatommyilonatommy
mentioned this pull request
Oct 8, 2024

Closed


This was referenced Oct 8, 2024

Closed


Closed


Closed


Closed

@build-analysisbuild-analysisBot
mentioned this pull request
Oct 8, 2024

Closed

@ilonatommy
ilonatommy
commented
Oct 8, 2024

Copy link


Copy Markdown

Member
/ba-g failures are DebuggerTests, not related
@ilonatommy
ilonatommy
merged commit 59a460a
into
dotnet:mainOct 8, 2024
@ilonatommyilonatommy
mentioned this pull request
Oct 9, 2024
 Merged

@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Nov 8, 2024
@ilonatommyilonatommy
mentioned this pull request
Jul 7, 2025
 Merged


This was referenced Aug 26, 2025

Closed


Open

CopilotAI
mentioned this pull request
Aug 26, 2025
 Closed

@ilonatommy
ilonatommy
commented
Aug 26, 2025

Copy link


Copy Markdown

Member
/backport to release/9.0-staging
@github-actionsgithub-actionsBot
unlocked this conversation
Aug 26, 2025
@github-actions
github-actionsBot
commented
Aug 26, 2025

Copy link


Copy Markdown

Contributor
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/17240338021
@github-actions
github-actionsBot
commented
Aug 26, 2025

Copy link


Copy Markdown

Contributor
@ilonatommy backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts:
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: stop testing with nodejs
Using index info to reconstruct a base tree...
M	eng/pipelines/runtime.yml
M	eng/testing/WasmRunnerTemplate.cmd
M	src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
M	src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
M	src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
M	src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
M	src/mono/wasm/Wasm.Build.Tests/ConfigSrcTests.cs
M	src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs
M	src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
M	src/mono/wasm/Wasm.Build.Tests/WasmSIMDTests.cs
M	src/mono/wasm/features.md
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/runtime.yml
CONFLICT (content): Merge conflict in eng/pipelines/runtime.yml
Auto-merging eng/testing/WasmRunnerTemplate.cmd
Auto-merging src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj
Auto-merging src/libraries/System.Net.WebSockets.Client/tests/System.Net.WebSockets.Client.Tests.csproj
Auto-merging src/mono/wasm/Wasm.Build.Tests/BuildTestBase.cs
Auto-merging src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/Common/RunHost.cs
CONFLICT (modify/delete): src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs deleted in stop testing with nodejs and modified in HEAD. Version HEAD of src/mono/wasm/Wasm.Build.Tests/HostRunner/NodeJSHostRunner.cs left in tree.
Auto-merging src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
CONFLICT (content): Merge conflict in src/mono/wasm/Wasm.Build.Tests/MainWithArgsTests.cs
Auto-merging src/mono/wasm/features.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 stop testing with nodejs
Error: The process '/usr/bin/git' failed with exit code 128
Please backport manually!
@github-actionsgithub-actionsBot
locked as resolved and limited conversation to collaborators
Aug 26, 2025
@pavelsavara
pavelsavara
deleted the

browser_stop_testing_with_nodejs

branch
September 10, 2025 12:58
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@ilonatommyilonatommyilonatommy approved these changes
@akoeplingerakoeplingerAwaiting requested review from akoeplingerakoeplinger is a code owner
@marafmarafAwaiting requested review from marafmaraf is a code owner
@lewinglewingAwaiting requested review from lewinglewing is a code owner

+1 more reviewer

@kasperk81kasperk81kasperk81 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@pavelsavarapavelsavara
@ilonatommyilonatommy

Labels

arch-wasmWebAssembly architecturearea-Build-monoos-browserBrowser variant of arch-wasm

Projects


None yet


Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pavelsavara@ilonatommy@maraf@kasperk81