Do not ignore MemoryMarshal.TryWrite result

[xtqqczze]

It is unidiomatic to ignore the return value of a Try method.

Supersedes #104728

[xtqqczze]

@MihuBot

[stephentoub]

Do not ignore MemoryMarshal.TryWrite result in Guid

What is the concern?

[xtqqczze]

Do not ignore MemoryMarshal.TryWrite result in Guid

What is the concern?

Code style, it is unidiomatic to ignore the return value of a Try method.

[vcsjones]

All the Write is going to do is length checks, which is already known at the call site.

In S.S.Cryptography we do use Debug.Assert for calls like this so we don't "ignore" the return value, but release builds don't pay the penalty of doing a length check that is otherwise known to be safe. Something like

boolret=MemoryMarshal.TryWrite(bytes,inthis);Debug.Assert(ret);

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

[am11]

All the Write is going to do is length checks, which is already known at the call site.

Looks like both Write and TryWrite are same in terms of number of checks. (Try has one less throw statement)

[xtqqczze]

@stephentoub It looks the use of MemoryMarshal.TryWrite was a workaround to improve codegen, but is no longer beneficial.

[stephentoub]

Just doesn't seem worth the churn to me.

[xtqqczze]

@MihuBot

[xtqqczze]

@stephentoub minimized churn and rebased

[xtqqczze]

It looks the use of MemoryMarshal.TryWrite was a workaround to improve codegen, but is no longer beneficial.

Found 261 files with textual diffs.
Summary of Code Size diffs:
(Lower is better)
Total bytes of base: 40203552
Total bytes of diff: 40203552
Total bytes of delta: 0 (0.00 % of base)
0 total files with Code Size differences (0 improved, 0 regressed), 259 unchanged.
0 total methods with Code Size differences (0 improved, 0 regressed), 232934 unchanged.
--------------------------------------------------------------------------------

[tannergooding]

@stephentoub any concern with the new version that switches it to just use Write rather than TryWrite?

This is very minor code cleanup, and so if we don't want to take the churn here I'd be liable to just close it.

[stephentoub]

I'm fine either way.

[tannergooding]

I'll take this then since it does remove the ignored result and makes the code a little bit cleaner.