[cdac] ExecutionManager contract and RangeSectionMap lookup unit tests by lambdageek · Pull Request #108685 · dotnet/runtime

lambdageek · 2024-10-08T19:49:26Z

RangeSectionMap is a data structure for coarse-grained lookups to man native code pointers to managed method descriptors that cover the entire addressable memory.

This PR adds unit tests for the cdac reader RangeSectionMap lookup algorithm and some unit tests for the ExecutionManager contract APIs that use a RangeSectionMap and NibbleMap together to do a full TargetCodePointer->MethodDesc lookup

Contributes to #108553

dotnet-policy-service · 2024-10-08T19:58:15Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

* add RangeSectionMap docs * exhaustively test RangeSectionMap.EffectiveBitsForLevel * fix lookup in RangeSection.Find RangeSectionLookupAlgorithm.FindFragment finds the slot containing the range section fragment pointer. Have to dereference it once to get the actual RangeSectionFragment pointer from the slot. This "worked" before because RangeSectionFragment.Next is at offset 0, so the first lookup would have a garbage range, so we would follow the "next" field and get to the correct fragment * make a testable RangeSectionMap.FindFragmentInternal * brief nibble map summary * [cdac] Implement NibbleMap lookup and tests The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method. Implement the lookup algorithm for a nibble map. Start adding unit tests for the nibble map Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader. * NibbleMap: fix bug and add test Previously we incorrectly computed the prior map index when doing the backward linear search * [testing] display Target values in hex in debugger views * MockMemorySpace: simplify ReaderContext there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader * refactor ExecutionManager * ExecutionManager contract the presence of RangeSection.R2RModule is a discriminator for whether we're looking at EE code or R2R code * WIP NibbleMap * WIP JitCodeToMethodInfo * WIP RangeSectionMap

The EECodeInfo includes the relative offset (given ip - start of method) so it's not ok to share for different code pointers into the same method

…lazy

elinor-fung · 2024-10-15T20:23:59Z

+ return FindFragmentInternal(target, topRangeSectionMap.TopLevelData, jittedCodeAddress)?.LoadValue(target).Address ?? TargetPointer.Null;
+ }
+
+ internal Cursor? FindFragmentInternal(Target target, TargetPointer topMap, TargetCodePointer jittedCodeAddress)


Can this just be merged into FindFragment? What is the split into FindFragmentInternal getting us?

Easier testing. I don't need to mock up a Data.RangeSectionMap value

Actually it's a bit more than that. We also avoid making the Cursor type visible in callers.

lambdageek · 2024-10-16T19:03:28Z

@elinor-fung applied all of your suggestions

elinor-fung · 2024-10-16T21:48:49Z

+
+ [Theory]
+ [ClassData(typeof(MockTarget.StdArch))]
+ public void TestLookupOne(MockTarget.Architecture arch)


Would it be useful to also cover:
failing when there are (one or more) ranges in the map
success with more than one range fragments in the map

elinor-fung · 2024-10-16T21:58:28Z

Last comments were minor around tests and test coverage. Since we already know there will be MethodDesc-related follow-ups (and this already made it through PR builds), I'm entirely fine with this going as-is.

Co-authored-by: Elinor Fung <elfung@microsoft.com>

lambdageek · 2024-10-08T19:49:26Z

RangeSectionMap is a data structure for coarse-grained lookups to man native code pointers to managed method descriptors that cover the entire addressable memory.

This PR adds unit tests for the cdac reader RangeSectionMap lookup algorithm and some unit tests for the ExecutionManager contract APIs that use a RangeSectionMap and NibbleMap together to do a full TargetCodePointer->MethodDesc lookup

Contributes to #108553

dotnet-policy-service · 2024-10-08T19:58:15Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

* add RangeSectionMap docs * exhaustively test RangeSectionMap.EffectiveBitsForLevel * fix lookup in RangeSection.Find RangeSectionLookupAlgorithm.FindFragment finds the slot containing the range section fragment pointer. Have to dereference it once to get the actual RangeSectionFragment pointer from the slot. This "worked" before because RangeSectionFragment.Next is at offset 0, so the first lookup would have a garbage range, so we would follow the "next" field and get to the correct fragment * make a testable RangeSectionMap.FindFragmentInternal * brief nibble map summary * [cdac] Implement NibbleMap lookup and tests The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method. Implement the lookup algorithm for a nibble map. Start adding unit tests for the nibble map Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader. * NibbleMap: fix bug and add test Previously we incorrectly computed the prior map index when doing the backward linear search * [testing] display Target values in hex in debugger views * MockMemorySpace: simplify ReaderContext there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader * refactor ExecutionManager * ExecutionManager contract the presence of RangeSection.R2RModule is a discriminator for whether we're looking at EE code or R2R code * WIP NibbleMap * WIP JitCodeToMethodInfo * WIP RangeSectionMap

The EECodeInfo includes the relative offset (given ip - start of method) so it's not ok to share for different code pointers into the same method

…lazy

elinor-fung · 2024-10-15T20:23:59Z

+ return FindFragmentInternal(target, topRangeSectionMap.TopLevelData, jittedCodeAddress)?.LoadValue(target).Address ?? TargetPointer.Null;
+ }
+
+ internal Cursor? FindFragmentInternal(Target target, TargetPointer topMap, TargetCodePointer jittedCodeAddress)


Can this just be merged into FindFragment? What is the split into FindFragmentInternal getting us?

Easier testing. I don't need to mock up a Data.RangeSectionMap value

Actually it's a bit more than that. We also avoid making the Cursor type visible in callers.

lambdageek · 2024-10-16T19:03:28Z

@elinor-fung applied all of your suggestions

elinor-fung · 2024-10-16T21:48:49Z

+
+ [Theory]
+ [ClassData(typeof(MockTarget.StdArch))]
+ public void TestLookupOne(MockTarget.Architecture arch)


Would it be useful to also cover:
failing when there are (one or more) ranges in the map
success with more than one range fragments in the map

elinor-fung · 2024-10-16T21:58:28Z

Last comments were minor around tests and test coverage. Since we already know there will be MethodDesc-related follow-ups (and this already made it through PR builds), I'm entirely fine with this going as-is.

Co-authored-by: Elinor Fung <elfung@microsoft.com>

lambdageek · 2024-10-08T19:49:26Z

RangeSectionMap is a data structure for coarse-grained lookups to man native code pointers to managed method descriptors that cover the entire addressable memory.

This PR adds unit tests for the cdac reader RangeSectionMap lookup algorithm and some unit tests for the ExecutionManager contract APIs that use a RangeSectionMap and NibbleMap together to do a full TargetCodePointer->MethodDesc lookup

Contributes to #108553

dotnet-policy-service · 2024-10-08T19:58:15Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

* add RangeSectionMap docs * exhaustively test RangeSectionMap.EffectiveBitsForLevel * fix lookup in RangeSection.Find RangeSectionLookupAlgorithm.FindFragment finds the slot containing the range section fragment pointer. Have to dereference it once to get the actual RangeSectionFragment pointer from the slot. This "worked" before because RangeSectionFragment.Next is at offset 0, so the first lookup would have a garbage range, so we would follow the "next" field and get to the correct fragment * make a testable RangeSectionMap.FindFragmentInternal * brief nibble map summary * [cdac] Implement NibbleMap lookup and tests The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method. Implement the lookup algorithm for a nibble map. Start adding unit tests for the nibble map Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader. * NibbleMap: fix bug and add test Previously we incorrectly computed the prior map index when doing the backward linear search * [testing] display Target values in hex in debugger views * MockMemorySpace: simplify ReaderContext there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader * refactor ExecutionManager * ExecutionManager contract the presence of RangeSection.R2RModule is a discriminator for whether we're looking at EE code or R2R code * WIP NibbleMap * WIP JitCodeToMethodInfo * WIP RangeSectionMap

The EECodeInfo includes the relative offset (given ip - start of method) so it's not ok to share for different code pointers into the same method

…lazy

elinor-fung · 2024-10-15T20:23:59Z

+ return FindFragmentInternal(target, topRangeSectionMap.TopLevelData, jittedCodeAddress)?.LoadValue(target).Address ?? TargetPointer.Null;
+ }
+
+ internal Cursor? FindFragmentInternal(Target target, TargetPointer topMap, TargetCodePointer jittedCodeAddress)


Can this just be merged into FindFragment? What is the split into FindFragmentInternal getting us?

Easier testing. I don't need to mock up a Data.RangeSectionMap value

Actually it's a bit more than that. We also avoid making the Cursor type visible in callers.

lambdageek · 2024-10-16T19:03:28Z

@elinor-fung applied all of your suggestions

elinor-fung · 2024-10-16T21:48:49Z

+
+ [Theory]
+ [ClassData(typeof(MockTarget.StdArch))]
+ public void TestLookupOne(MockTarget.Architecture arch)


Would it be useful to also cover:
failing when there are (one or more) ranges in the map
success with more than one range fragments in the map

elinor-fung · 2024-10-16T21:58:28Z

Last comments were minor around tests and test coverage. Since we already know there will be MethodDesc-related follow-ups (and this already made it through PR builds), I'm entirely fine with this going as-is.

Co-authored-by: Elinor Fung <elfung@microsoft.com>

lambdageek · 2024-10-08T19:49:26Z

RangeSectionMap is a data structure for coarse-grained lookups to man native code pointers to managed method descriptors that cover the entire addressable memory.

This PR adds unit tests for the cdac reader RangeSectionMap lookup algorithm and some unit tests for the ExecutionManager contract APIs that use a RangeSectionMap and NibbleMap together to do a full TargetCodePointer->MethodDesc lookup

Contributes to #108553

dotnet-policy-service · 2024-10-08T19:58:15Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

* add RangeSectionMap docs * exhaustively test RangeSectionMap.EffectiveBitsForLevel * fix lookup in RangeSection.Find RangeSectionLookupAlgorithm.FindFragment finds the slot containing the range section fragment pointer. Have to dereference it once to get the actual RangeSectionFragment pointer from the slot. This "worked" before because RangeSectionFragment.Next is at offset 0, so the first lookup would have a garbage range, so we would follow the "next" field and get to the correct fragment * make a testable RangeSectionMap.FindFragmentInternal * brief nibble map summary * [cdac] Implement NibbleMap lookup and tests The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method. Implement the lookup algorithm for a nibble map. Start adding unit tests for the nibble map Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader. * NibbleMap: fix bug and add test Previously we incorrectly computed the prior map index when doing the backward linear search * [testing] display Target values in hex in debugger views * MockMemorySpace: simplify ReaderContext there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader * refactor ExecutionManager * ExecutionManager contract the presence of RangeSection.R2RModule is a discriminator for whether we're looking at EE code or R2R code * WIP NibbleMap * WIP JitCodeToMethodInfo * WIP RangeSectionMap

The EECodeInfo includes the relative offset (given ip - start of method) so it's not ok to share for different code pointers into the same method

…lazy

elinor-fung · 2024-10-15T20:23:59Z

+ return FindFragmentInternal(target, topRangeSectionMap.TopLevelData, jittedCodeAddress)?.LoadValue(target).Address ?? TargetPointer.Null;
+ }
+
+ internal Cursor? FindFragmentInternal(Target target, TargetPointer topMap, TargetCodePointer jittedCodeAddress)


Can this just be merged into FindFragment? What is the split into FindFragmentInternal getting us?

Easier testing. I don't need to mock up a Data.RangeSectionMap value

Actually it's a bit more than that. We also avoid making the Cursor type visible in callers.

lambdageek · 2024-10-16T19:03:28Z

@elinor-fung applied all of your suggestions

elinor-fung · 2024-10-16T21:48:49Z

+
+ [Theory]
+ [ClassData(typeof(MockTarget.StdArch))]
+ public void TestLookupOne(MockTarget.Architecture arch)


Would it be useful to also cover:
failing when there are (one or more) ranges in the map
success with more than one range fragments in the map

elinor-fung · 2024-10-16T21:58:28Z

Last comments were minor around tests and test coverage. Since we already know there will be MethodDesc-related follow-ups (and this already made it through PR builds), I'm entirely fine with this going as-is.

Co-authored-by: Elinor Fung <elfung@microsoft.com>

lambdageek · 2024-10-08T19:49:26Z

RangeSectionMap is a data structure for coarse-grained lookups to man native code pointers to managed method descriptors that cover the entire addressable memory.

This PR adds unit tests for the cdac reader RangeSectionMap lookup algorithm and some unit tests for the ExecutionManager contract APIs that use a RangeSectionMap and NibbleMap together to do a full TargetCodePointer->MethodDesc lookup

Contributes to #108553

dotnet-policy-service · 2024-10-08T19:58:15Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

* add RangeSectionMap docs * exhaustively test RangeSectionMap.EffectiveBitsForLevel * fix lookup in RangeSection.Find RangeSectionLookupAlgorithm.FindFragment finds the slot containing the range section fragment pointer. Have to dereference it once to get the actual RangeSectionFragment pointer from the slot. This "worked" before because RangeSectionFragment.Next is at offset 0, so the first lookup would have a garbage range, so we would follow the "next" field and get to the correct fragment * make a testable RangeSectionMap.FindFragmentInternal * brief nibble map summary * [cdac] Implement NibbleMap lookup and tests The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method. Implement the lookup algorithm for a nibble map. Start adding unit tests for the nibble map Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader. * NibbleMap: fix bug and add test Previously we incorrectly computed the prior map index when doing the backward linear search * [testing] display Target values in hex in debugger views * MockMemorySpace: simplify ReaderContext there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader * refactor ExecutionManager * ExecutionManager contract the presence of RangeSection.R2RModule is a discriminator for whether we're looking at EE code or R2R code * WIP NibbleMap * WIP JitCodeToMethodInfo * WIP RangeSectionMap

The EECodeInfo includes the relative offset (given ip - start of method) so it's not ok to share for different code pointers into the same method

…lazy

elinor-fung · 2024-10-15T20:23:59Z

+ return FindFragmentInternal(target, topRangeSectionMap.TopLevelData, jittedCodeAddress)?.LoadValue(target).Address ?? TargetPointer.Null;
+ }
+
+ internal Cursor? FindFragmentInternal(Target target, TargetPointer topMap, TargetCodePointer jittedCodeAddress)


Can this just be merged into FindFragment? What is the split into FindFragmentInternal getting us?

Easier testing. I don't need to mock up a Data.RangeSectionMap value

Actually it's a bit more than that. We also avoid making the Cursor type visible in callers.

lambdageek · 2024-10-16T19:03:28Z

@elinor-fung applied all of your suggestions

elinor-fung · 2024-10-16T21:48:49Z

+
+ [Theory]
+ [ClassData(typeof(MockTarget.StdArch))]
+ public void TestLookupOne(MockTarget.Architecture arch)


Would it be useful to also cover:
failing when there are (one or more) ranges in the map
success with more than one range fragments in the map

elinor-fung · 2024-10-16T21:58:28Z

Last comments were minor around tests and test coverage. Since we already know there will be MethodDesc-related follow-ups (and this already made it through PR builds), I'm entirely fine with this going as-is.

Co-authored-by: Elinor Fung <elfung@microsoft.com>

lambdageek · 2024-10-08T19:49:26Z

RangeSectionMap is a data structure for coarse-grained lookups to man native code pointers to managed method descriptors that cover the entire addressable memory.

This PR adds unit tests for the cdac reader RangeSectionMap lookup algorithm and some unit tests for the ExecutionManager contract APIs that use a RangeSectionMap and NibbleMap together to do a full TargetCodePointer->MethodDesc lookup

Contributes to #108553

dotnet-policy-service · 2024-10-08T19:58:15Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

* add RangeSectionMap docs * exhaustively test RangeSectionMap.EffectiveBitsForLevel * fix lookup in RangeSection.Find RangeSectionLookupAlgorithm.FindFragment finds the slot containing the range section fragment pointer. Have to dereference it once to get the actual RangeSectionFragment pointer from the slot. This "worked" before because RangeSectionFragment.Next is at offset 0, so the first lookup would have a garbage range, so we would follow the "next" field and get to the correct fragment * make a testable RangeSectionMap.FindFragmentInternal * brief nibble map summary * [cdac] Implement NibbleMap lookup and tests The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method. Implement the lookup algorithm for a nibble map. Start adding unit tests for the nibble map Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader. * NibbleMap: fix bug and add test Previously we incorrectly computed the prior map index when doing the backward linear search * [testing] display Target values in hex in debugger views * MockMemorySpace: simplify ReaderContext there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader * refactor ExecutionManager * ExecutionManager contract the presence of RangeSection.R2RModule is a discriminator for whether we're looking at EE code or R2R code * WIP NibbleMap * WIP JitCodeToMethodInfo * WIP RangeSectionMap

The EECodeInfo includes the relative offset (given ip - start of method) so it's not ok to share for different code pointers into the same method

…lazy

elinor-fung · 2024-10-15T20:23:59Z

+ return FindFragmentInternal(target, topRangeSectionMap.TopLevelData, jittedCodeAddress)?.LoadValue(target).Address ?? TargetPointer.Null;
+ }
+
+ internal Cursor? FindFragmentInternal(Target target, TargetPointer topMap, TargetCodePointer jittedCodeAddress)


Can this just be merged into FindFragment? What is the split into FindFragmentInternal getting us?

Easier testing. I don't need to mock up a Data.RangeSectionMap value

Actually it's a bit more than that. We also avoid making the Cursor type visible in callers.

lambdageek · 2024-10-16T19:03:28Z

@elinor-fung applied all of your suggestions

elinor-fung · 2024-10-16T21:48:49Z

+
+ [Theory]
+ [ClassData(typeof(MockTarget.StdArch))]
+ public void TestLookupOne(MockTarget.Architecture arch)


Would it be useful to also cover:
failing when there are (one or more) ranges in the map
success with more than one range fragments in the map

elinor-fung · 2024-10-16T21:58:28Z

Last comments were minor around tests and test coverage. Since we already know there will be MethodDesc-related follow-ups (and this already made it through PR builds), I'm entirely fine with this going as-is.

Co-authored-by: Elinor Fung <elfung@microsoft.com>

lambdageek · 2024-10-08T19:49:26Z

RangeSectionMap is a data structure for coarse-grained lookups to man native code pointers to managed method descriptors that cover the entire addressable memory.

This PR adds unit tests for the cdac reader RangeSectionMap lookup algorithm and some unit tests for the ExecutionManager contract APIs that use a RangeSectionMap and NibbleMap together to do a full TargetCodePointer->MethodDesc lookup

Contributes to #108553

dotnet-policy-service · 2024-10-08T19:58:15Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

* add RangeSectionMap docs * exhaustively test RangeSectionMap.EffectiveBitsForLevel * fix lookup in RangeSection.Find RangeSectionLookupAlgorithm.FindFragment finds the slot containing the range section fragment pointer. Have to dereference it once to get the actual RangeSectionFragment pointer from the slot. This "worked" before because RangeSectionFragment.Next is at offset 0, so the first lookup would have a garbage range, so we would follow the "next" field and get to the correct fragment * make a testable RangeSectionMap.FindFragmentInternal * brief nibble map summary * [cdac] Implement NibbleMap lookup and tests The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method. Implement the lookup algorithm for a nibble map. Start adding unit tests for the nibble map Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader. * NibbleMap: fix bug and add test Previously we incorrectly computed the prior map index when doing the backward linear search * [testing] display Target values in hex in debugger views * MockMemorySpace: simplify ReaderContext there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader * refactor ExecutionManager * ExecutionManager contract the presence of RangeSection.R2RModule is a discriminator for whether we're looking at EE code or R2R code * WIP NibbleMap * WIP JitCodeToMethodInfo * WIP RangeSectionMap

The EECodeInfo includes the relative offset (given ip - start of method) so it's not ok to share for different code pointers into the same method

…lazy

elinor-fung · 2024-10-15T20:23:59Z

+ return FindFragmentInternal(target, topRangeSectionMap.TopLevelData, jittedCodeAddress)?.LoadValue(target).Address ?? TargetPointer.Null;
+ }
+
+ internal Cursor? FindFragmentInternal(Target target, TargetPointer topMap, TargetCodePointer jittedCodeAddress)


Can this just be merged into FindFragment? What is the split into FindFragmentInternal getting us?

Easier testing. I don't need to mock up a Data.RangeSectionMap value

Actually it's a bit more than that. We also avoid making the Cursor type visible in callers.

lambdageek · 2024-10-16T19:03:28Z

@elinor-fung applied all of your suggestions

elinor-fung · 2024-10-16T21:48:49Z

+
+ [Theory]
+ [ClassData(typeof(MockTarget.StdArch))]
+ public void TestLookupOne(MockTarget.Architecture arch)


Would it be useful to also cover:
failing when there are (one or more) ranges in the map
success with more than one range fragments in the map

elinor-fung · 2024-10-16T21:58:28Z

Last comments were minor around tests and test coverage. Since we already know there will be MethodDesc-related follow-ups (and this already made it through PR builds), I'm entirely fine with this going as-is.

Co-authored-by: Elinor Fung <elfung@microsoft.com>

lambdageek · 2024-10-08T19:49:26Z

RangeSectionMap is a data structure for coarse-grained lookups to man native code pointers to managed method descriptors that cover the entire addressable memory.

This PR adds unit tests for the cdac reader RangeSectionMap lookup algorithm and some unit tests for the ExecutionManager contract APIs that use a RangeSectionMap and NibbleMap together to do a full TargetCodePointer->MethodDesc lookup

Contributes to #108553

dotnet-policy-service · 2024-10-08T19:58:15Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

* add RangeSectionMap docs * exhaustively test RangeSectionMap.EffectiveBitsForLevel * fix lookup in RangeSection.Find RangeSectionLookupAlgorithm.FindFragment finds the slot containing the range section fragment pointer. Have to dereference it once to get the actual RangeSectionFragment pointer from the slot. This "worked" before because RangeSectionFragment.Next is at offset 0, so the first lookup would have a garbage range, so we would follow the "next" field and get to the correct fragment * make a testable RangeSectionMap.FindFragmentInternal * brief nibble map summary * [cdac] Implement NibbleMap lookup and tests The execution manager uses a nibble map to quickly map program counter pointers to the beginnings of the native code for the managed method. Implement the lookup algorithm for a nibble map. Start adding unit tests for the nibble map Also for testing in MockMemorySpace simplify ReaderContext, there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader. * NibbleMap: fix bug and add test Previously we incorrectly computed the prior map index when doing the backward linear search * [testing] display Target values in hex in debugger views * MockMemorySpace: simplify ReaderContext there's nothing special about the descriptor HeapFragments anymore. We can use a uniform reader * refactor ExecutionManager * ExecutionManager contract the presence of RangeSection.R2RModule is a discriminator for whether we're looking at EE code or R2R code * WIP NibbleMap * WIP JitCodeToMethodInfo * WIP RangeSectionMap

The EECodeInfo includes the relative offset (given ip - start of method) so it's not ok to share for different code pointers into the same method

…lazy

elinor-fung · 2024-10-15T20:23:59Z

+ return FindFragmentInternal(target, topRangeSectionMap.TopLevelData, jittedCodeAddress)?.LoadValue(target).Address ?? TargetPointer.Null;
+ }
+
+ internal Cursor? FindFragmentInternal(Target target, TargetPointer topMap, TargetCodePointer jittedCodeAddress)


Can this just be merged into FindFragment? What is the split into FindFragmentInternal getting us?

Easier testing. I don't need to mock up a Data.RangeSectionMap value

Actually it's a bit more than that. We also avoid making the Cursor type visible in callers.

lambdageek · 2024-10-16T19:03:28Z

@elinor-fung applied all of your suggestions

elinor-fung · 2024-10-16T21:48:49Z

+
+ [Theory]
+ [ClassData(typeof(MockTarget.StdArch))]
+ public void TestLookupOne(MockTarget.Architecture arch)


Would it be useful to also cover:
failing when there are (one or more) ranges in the map
success with more than one range fragments in the map

elinor-fung · 2024-10-16T21:58:28Z

Last comments were minor around tests and test coverage. Since we already know there will be MethodDesc-related follow-ups (and this already made it through PR builds), I'm entirely fine with this going as-is.

Co-authored-by: Elinor Fung <elfung@microsoft.com>

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 8, 2024

lambdageek added the area-Diagnostics-coreclr label Oct 8, 2024

dotnet-policy-serviceBot assigned lambdageek Oct 8, 2024

lambdageek removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 8, 2024

lambdageek force-pushed the cdac-execution-manager branch from 0c04ca3 to af2387fCompare October 8, 2024 20:07

lambdageek added 15 commits October 10, 2024 16:22

NibbleMap: use a struct for MapUnit
ee5616b

Add some very basic ExecutionManager tests that return null
cbeb33a

fixup RangeSectionMapTests
c4af08a

use better cdac_data friends
0cab907

one more friend
e27de51

fix typos
04cd55f

markdown cleanup
848aea2

document the ExecutionManager methods
4dca4d8

cache EECodeInfo based on given code pointer, not start of the method
af85abc
The EECodeInfo includes the relative offset (given ip - start of method) so it's not ok to share for different code pointers into the same method

WIP: execution manager RangeSectionFragment test
f31e7f2

Make TestPlaceholderTarget data cache more useful; make TestRegistry …
6f3d208
…lazy

WIP: execution manager tests (still failing)
89db889

bugfix: stubCodeBlockLast is uint8
cffad93

checkpoint: unit test is working
2f26c73

lambdageek force-pushed the cdac-execution-manager branch from eb190a2 to 2f26c73Compare October 10, 2024 20:22

lambdageek added 3 commits October 11, 2024 11:10

add a simple bump allocator to MockMemorySpace
7048c4f

Add a field layout algorithm to TargetTestHelpers
159c188

use allocators a bit more
6e8fd1c

build-analysisBot mentioned this pull request Oct 11, 2024
[Mono AOT] Failed to compile System.Private.CoreLib.dll.bc #103520
Open

lambdageek marked this pull request as ready for review October 14, 2024 14:40

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and max-charlamb October 14, 2024 14:42

lambdageek added 3 commits October 14, 2024 13:37

move all the test builders to a separate class
f76ec3c

cleanup test infra
288d4ca

remove a few more magic constants
a640354

build-analysisBot mentioned this pull request Oct 14, 2024
ReadECDsaPrivateKey_BrainpoolP160r1_Pfx test failure on windows #108815
Closed

Merge branch 'main' into cdac-execution-manager
04e7de1

elinor-fung reviewed Oct 15, 2024
View reviewed changes

lambdageek added 3 commits October 16, 2024 12:11

EECodeInfo -> CodeBlock
2898390

EffectiveBitsForLevel -> GetIndexForLevel
d028a59

add documentation to managed contract impl
138c4f0

This was referenced Oct 16, 2024
WasmTestOnChrome timeouts in CI #105363
Closed
System.Runtime.Tests.WorkItemExecution "crash" on tvOS #106319
Closed
[WASI] Sockets - unknown handle index #108726
Closed
DebuggerTests other than WasmTestOnChrome timeouts in CI #108921
Closed

elinor-fung approved these changes Oct 16, 2024
View reviewed changes

lambdageekand others added 2 commits October 16, 2024 18:45

Apply suggestions from code review
4b77d68
Co-authored-by: Elinor Fung <elfung@microsoft.com>

RSLATestTarget -> RSMTestTarget
ab6d6e6

lambdageek merged commit 1b8f744 into dotnet:mainOct 17, 2024

This was referenced Oct 17, 2024
[cdac] Implement !PrintException#99302
Closed
[cdac] .NET10: Implement DAC APIs used by CLRMA #108553
Closed

github-actionsBot locked and limited conversation to collaborators Nov 17, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 8, 2024

lambdageek added the area-Diagnostics-coreclr label Oct 8, 2024

dotnet-policy-serviceBot assigned lambdageek Oct 8, 2024

lambdageek removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 8, 2024

lambdageek force-pushed the cdac-execution-manager branch from 0c04ca3 to af2387fCompare October 8, 2024 20:07

lambdageek added 15 commits October 10, 2024 16:22

NibbleMap: use a struct for MapUnit
ee5616b

Add some very basic ExecutionManager tests that return null
cbeb33a

fixup RangeSectionMapTests
c4af08a

use better cdac_data friends
0cab907

one more friend
e27de51

fix typos
04cd55f

markdown cleanup
848aea2

document the ExecutionManager methods
4dca4d8

cache EECodeInfo based on given code pointer, not start of the method
af85abc
The EECodeInfo includes the relative offset (given ip - start of method) so it's not ok to share for different code pointers into the same method

WIP: execution manager RangeSectionFragment test
f31e7f2

Make TestPlaceholderTarget data cache more useful; make TestRegistry …
6f3d208
…lazy

WIP: execution manager tests (still failing)
89db889

bugfix: stubCodeBlockLast is uint8
cffad93

checkpoint: unit test is working
2f26c73

lambdageek force-pushed the cdac-execution-manager branch from eb190a2 to 2f26c73Compare October 10, 2024 20:22

lambdageek added 3 commits October 11, 2024 11:10

add a simple bump allocator to MockMemorySpace
7048c4f

Add a field layout algorithm to TargetTestHelpers
159c188

use allocators a bit more
6e8fd1c

build-analysisBot mentioned this pull request Oct 11, 2024
[Mono AOT] Failed to compile System.Private.CoreLib.dll.bc #103520
Open

lambdageek marked this pull request as ready for review October 14, 2024 14:40

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and max-charlamb October 14, 2024 14:42

lambdageek added 3 commits October 14, 2024 13:37

move all the test builders to a separate class
f76ec3c

cleanup test infra
288d4ca

remove a few more magic constants
a640354

build-analysisBot mentioned this pull request Oct 14, 2024
ReadECDsaPrivateKey_BrainpoolP160r1_Pfx test failure on windows #108815
Closed

Merge branch 'main' into cdac-execution-manager
04e7de1

elinor-fung reviewed Oct 15, 2024
View reviewed changes

lambdageek added 3 commits October 16, 2024 12:11

EECodeInfo -> CodeBlock
2898390

EffectiveBitsForLevel -> GetIndexForLevel
d028a59

add documentation to managed contract impl
138c4f0

This was referenced Oct 16, 2024
WasmTestOnChrome timeouts in CI #105363
Closed
System.Runtime.Tests.WorkItemExecution "crash" on tvOS #106319
Closed
[WASI] Sockets - unknown handle index #108726
Closed
DebuggerTests other than WasmTestOnChrome timeouts in CI #108921
Closed

elinor-fung approved these changes Oct 16, 2024
View reviewed changes

lambdageekand others added 2 commits October 16, 2024 18:45

Apply suggestions from code review
4b77d68
Co-authored-by: Elinor Fung <elfung@microsoft.com>

RSLATestTarget -> RSMTestTarget
ab6d6e6

lambdageek merged commit 1b8f744 into dotnet:mainOct 17, 2024

This was referenced Oct 17, 2024
[cdac] Implement !PrintException#99302
Closed
[cdac] .NET10: Implement DAC APIs used by CLRMA #108553
Closed

github-actionsBot locked and limited conversation to collaborators Nov 17, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 8, 2024

lambdageek added the area-Diagnostics-coreclr label Oct 8, 2024

dotnet-policy-serviceBot assigned lambdageek Oct 8, 2024

lambdageek removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 8, 2024

lambdageek force-pushed the cdac-execution-manager branch from 0c04ca3 to af2387fCompare October 8, 2024 20:07

lambdageek added 15 commits October 10, 2024 16:22

NibbleMap: use a struct for MapUnit
ee5616b

Add some very basic ExecutionManager tests that return null
cbeb33a

fixup RangeSectionMapTests
c4af08a

use better cdac_data friends
0cab907

one more friend
e27de51

fix typos
04cd55f

markdown cleanup
848aea2

document the ExecutionManager methods
4dca4d8

cache EECodeInfo based on given code pointer, not start of the method
af85abc
The EECodeInfo includes the relative offset (given ip - start of method) so it's not ok to share for different code pointers into the same method

WIP: execution manager RangeSectionFragment test
f31e7f2

Make TestPlaceholderTarget data cache more useful; make TestRegistry …
6f3d208
…lazy

WIP: execution manager tests (still failing)
89db889

bugfix: stubCodeBlockLast is uint8
cffad93

checkpoint: unit test is working
2f26c73

lambdageek force-pushed the cdac-execution-manager branch from eb190a2 to 2f26c73Compare October 10, 2024 20:22

lambdageek added 3 commits October 11, 2024 11:10

add a simple bump allocator to MockMemorySpace
7048c4f

Add a field layout algorithm to TargetTestHelpers
159c188

use allocators a bit more
6e8fd1c

build-analysisBot mentioned this pull request Oct 11, 2024
[Mono AOT] Failed to compile System.Private.CoreLib.dll.bc #103520
Open

lambdageek marked this pull request as ready for review October 14, 2024 14:40

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and max-charlamb October 14, 2024 14:42

lambdageek added 3 commits October 14, 2024 13:37

move all the test builders to a separate class
f76ec3c

cleanup test infra
288d4ca

remove a few more magic constants
a640354

build-analysisBot mentioned this pull request Oct 14, 2024
ReadECDsaPrivateKey_BrainpoolP160r1_Pfx test failure on windows #108815
Closed

Merge branch 'main' into cdac-execution-manager
04e7de1

elinor-fung reviewed Oct 15, 2024
View reviewed changes

lambdageek added 3 commits October 16, 2024 12:11

EECodeInfo -> CodeBlock
2898390

EffectiveBitsForLevel -> GetIndexForLevel
d028a59

add documentation to managed contract impl
138c4f0

This was referenced Oct 16, 2024
WasmTestOnChrome timeouts in CI #105363
Closed
System.Runtime.Tests.WorkItemExecution "crash" on tvOS #106319
Closed
[WASI] Sockets - unknown handle index #108726
Closed
DebuggerTests other than WasmTestOnChrome timeouts in CI #108921
Closed

elinor-fung approved these changes Oct 16, 2024
View reviewed changes

lambdageekand others added 2 commits October 16, 2024 18:45

Apply suggestions from code review
4b77d68
Co-authored-by: Elinor Fung <elfung@microsoft.com>

RSLATestTarget -> RSMTestTarget
ab6d6e6

lambdageek merged commit 1b8f744 into dotnet:mainOct 17, 2024

This was referenced Oct 17, 2024
[cdac] Implement !PrintException#99302
Closed
[cdac] .NET10: Implement DAC APIs used by CLRMA #108553
Closed

github-actionsBot locked and limited conversation to collaborators Nov 17, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 8, 2024

lambdageek added the area-Diagnostics-coreclr label Oct 8, 2024

dotnet-policy-serviceBot assigned lambdageek Oct 8, 2024

lambdageek removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 8, 2024

lambdageek force-pushed the cdac-execution-manager branch from 0c04ca3 to af2387fCompare October 8, 2024 20:07

lambdageek added 15 commits October 10, 2024 16:22

NibbleMap: use a struct for MapUnit
ee5616b

Add some very basic ExecutionManager tests that return null
cbeb33a

fixup RangeSectionMapTests
c4af08a

use better cdac_data friends
0cab907

one more friend
e27de51

fix typos
04cd55f

markdown cleanup
848aea2

document the ExecutionManager methods
4dca4d8

cache EECodeInfo based on given code pointer, not start of the method
af85abc
The EECodeInfo includes the relative offset (given ip - start of method) so it's not ok to share for different code pointers into the same method

WIP: execution manager RangeSectionFragment test
f31e7f2

Make TestPlaceholderTarget data cache more useful; make TestRegistry …
6f3d208
…lazy

WIP: execution manager tests (still failing)
89db889

bugfix: stubCodeBlockLast is uint8
cffad93

checkpoint: unit test is working
2f26c73

lambdageek force-pushed the cdac-execution-manager branch from eb190a2 to 2f26c73Compare October 10, 2024 20:22

lambdageek added 3 commits October 11, 2024 11:10

add a simple bump allocator to MockMemorySpace
7048c4f

Add a field layout algorithm to TargetTestHelpers
159c188

use allocators a bit more
6e8fd1c

build-analysisBot mentioned this pull request Oct 11, 2024
[Mono AOT] Failed to compile System.Private.CoreLib.dll.bc #103520
Open

lambdageek marked this pull request as ready for review October 14, 2024 14:40

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and max-charlamb October 14, 2024 14:42

lambdageek added 3 commits October 14, 2024 13:37

move all the test builders to a separate class
f76ec3c

cleanup test infra
288d4ca

remove a few more magic constants
a640354

build-analysisBot mentioned this pull request Oct 14, 2024
ReadECDsaPrivateKey_BrainpoolP160r1_Pfx test failure on windows #108815
Closed

Merge branch 'main' into cdac-execution-manager
04e7de1

elinor-fung reviewed Oct 15, 2024
View reviewed changes

lambdageek added 3 commits October 16, 2024 12:11

EECodeInfo -> CodeBlock
2898390

EffectiveBitsForLevel -> GetIndexForLevel
d028a59

add documentation to managed contract impl
138c4f0

This was referenced Oct 16, 2024
WasmTestOnChrome timeouts in CI #105363
Closed
System.Runtime.Tests.WorkItemExecution "crash" on tvOS #106319
Closed
[WASI] Sockets - unknown handle index #108726
Closed
DebuggerTests other than WasmTestOnChrome timeouts in CI #108921
Closed

elinor-fung approved these changes Oct 16, 2024
View reviewed changes

lambdageekand others added 2 commits October 16, 2024 18:45

Apply suggestions from code review
4b77d68
Co-authored-by: Elinor Fung <elfung@microsoft.com>

RSLATestTarget -> RSMTestTarget
ab6d6e6

lambdageek merged commit 1b8f744 into dotnet:mainOct 17, 2024

This was referenced Oct 17, 2024
[cdac] Implement !PrintException#99302
Closed
[cdac] .NET10: Implement DAC APIs used by CLRMA #108553
Closed

github-actionsBot locked and limited conversation to collaborators Nov 17, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 8, 2024

lambdageek added the area-Diagnostics-coreclr label Oct 8, 2024

dotnet-policy-serviceBot assigned lambdageek Oct 8, 2024

lambdageek removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 8, 2024

lambdageek force-pushed the cdac-execution-manager branch from 0c04ca3 to af2387fCompare October 8, 2024 20:07

lambdageek added 15 commits October 10, 2024 16:22

NibbleMap: use a struct for MapUnit
ee5616b

Add some very basic ExecutionManager tests that return null
cbeb33a

fixup RangeSectionMapTests
c4af08a

use better cdac_data friends
0cab907

one more friend
e27de51

fix typos
04cd55f

markdown cleanup
848aea2

document the ExecutionManager methods
4dca4d8

cache EECodeInfo based on given code pointer, not start of the method
af85abc
The EECodeInfo includes the relative offset (given ip - start of method) so it's not ok to share for different code pointers into the same method

WIP: execution manager RangeSectionFragment test
f31e7f2

Make TestPlaceholderTarget data cache more useful; make TestRegistry …
6f3d208
…lazy

WIP: execution manager tests (still failing)
89db889

bugfix: stubCodeBlockLast is uint8
cffad93

checkpoint: unit test is working
2f26c73

lambdageek force-pushed the cdac-execution-manager branch from eb190a2 to 2f26c73Compare October 10, 2024 20:22

lambdageek added 3 commits October 11, 2024 11:10

add a simple bump allocator to MockMemorySpace
7048c4f

Add a field layout algorithm to TargetTestHelpers
159c188

use allocators a bit more
6e8fd1c

build-analysisBot mentioned this pull request Oct 11, 2024
[Mono AOT] Failed to compile System.Private.CoreLib.dll.bc #103520
Open

lambdageek marked this pull request as ready for review October 14, 2024 14:40

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and max-charlamb October 14, 2024 14:42

lambdageek added 3 commits October 14, 2024 13:37

move all the test builders to a separate class
f76ec3c

cleanup test infra
288d4ca

remove a few more magic constants
a640354

build-analysisBot mentioned this pull request Oct 14, 2024
ReadECDsaPrivateKey_BrainpoolP160r1_Pfx test failure on windows #108815
Closed

Merge branch 'main' into cdac-execution-manager
04e7de1

elinor-fung reviewed Oct 15, 2024
View reviewed changes

lambdageek added 3 commits October 16, 2024 12:11

EECodeInfo -> CodeBlock
2898390

EffectiveBitsForLevel -> GetIndexForLevel
d028a59

add documentation to managed contract impl
138c4f0

This was referenced Oct 16, 2024
WasmTestOnChrome timeouts in CI #105363
Closed
System.Runtime.Tests.WorkItemExecution "crash" on tvOS #106319
Closed
[WASI] Sockets - unknown handle index #108726
Closed
DebuggerTests other than WasmTestOnChrome timeouts in CI #108921
Closed

elinor-fung approved these changes Oct 16, 2024
View reviewed changes

lambdageekand others added 2 commits October 16, 2024 18:45

Apply suggestions from code review
4b77d68
Co-authored-by: Elinor Fung <elfung@microsoft.com>

RSLATestTarget -> RSMTestTarget
ab6d6e6

lambdageek merged commit 1b8f744 into dotnet:mainOct 17, 2024

This was referenced Oct 17, 2024
[cdac] Implement !PrintException#99302
Closed
[cdac] .NET10: Implement DAC APIs used by CLRMA #108553
Closed

github-actionsBot locked and limited conversation to collaborators Nov 17, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 8, 2024

lambdageek added the area-Diagnostics-coreclr label Oct 8, 2024

dotnet-policy-serviceBot assigned lambdageek Oct 8, 2024

lambdageek removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 8, 2024

lambdageek force-pushed the cdac-execution-manager branch from 0c04ca3 to af2387fCompare October 8, 2024 20:07

lambdageek added 15 commits October 10, 2024 16:22

NibbleMap: use a struct for MapUnit
ee5616b

Add some very basic ExecutionManager tests that return null
cbeb33a

fixup RangeSectionMapTests
c4af08a

use better cdac_data friends
0cab907

one more friend
e27de51

fix typos
04cd55f

markdown cleanup
848aea2

document the ExecutionManager methods
4dca4d8

cache EECodeInfo based on given code pointer, not start of the method
af85abc
The EECodeInfo includes the relative offset (given ip - start of method) so it's not ok to share for different code pointers into the same method

WIP: execution manager RangeSectionFragment test
f31e7f2

Make TestPlaceholderTarget data cache more useful; make TestRegistry …
6f3d208
…lazy

WIP: execution manager tests (still failing)
89db889

bugfix: stubCodeBlockLast is uint8
cffad93

checkpoint: unit test is working
2f26c73

lambdageek force-pushed the cdac-execution-manager branch from eb190a2 to 2f26c73Compare October 10, 2024 20:22

lambdageek added 3 commits October 11, 2024 11:10

add a simple bump allocator to MockMemorySpace
7048c4f

Add a field layout algorithm to TargetTestHelpers
159c188

use allocators a bit more
6e8fd1c

build-analysisBot mentioned this pull request Oct 11, 2024
[Mono AOT] Failed to compile System.Private.CoreLib.dll.bc #103520
Open

lambdageek marked this pull request as ready for review October 14, 2024 14:40

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and max-charlamb October 14, 2024 14:42

lambdageek added 3 commits October 14, 2024 13:37

move all the test builders to a separate class
f76ec3c

cleanup test infra
288d4ca

remove a few more magic constants
a640354

build-analysisBot mentioned this pull request Oct 14, 2024
ReadECDsaPrivateKey_BrainpoolP160r1_Pfx test failure on windows #108815
Closed

Merge branch 'main' into cdac-execution-manager
04e7de1

elinor-fung reviewed Oct 15, 2024
View reviewed changes

lambdageek added 3 commits October 16, 2024 12:11

EECodeInfo -> CodeBlock
2898390

EffectiveBitsForLevel -> GetIndexForLevel
d028a59

add documentation to managed contract impl
138c4f0

This was referenced Oct 16, 2024
WasmTestOnChrome timeouts in CI #105363
Closed
System.Runtime.Tests.WorkItemExecution "crash" on tvOS #106319
Closed
[WASI] Sockets - unknown handle index #108726
Closed
DebuggerTests other than WasmTestOnChrome timeouts in CI #108921
Closed

elinor-fung approved these changes Oct 16, 2024
View reviewed changes

lambdageekand others added 2 commits October 16, 2024 18:45

Apply suggestions from code review
4b77d68
Co-authored-by: Elinor Fung <elfung@microsoft.com>

RSLATestTarget -> RSMTestTarget
ab6d6e6

lambdageek merged commit 1b8f744 into dotnet:mainOct 17, 2024

This was referenced Oct 17, 2024
[cdac] Implement !PrintException#99302
Closed
[cdac] .NET10: Implement DAC APIs used by CLRMA #108553
Closed

github-actionsBot locked and limited conversation to collaborators Nov 17, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 8, 2024

lambdageek added the area-Diagnostics-coreclr label Oct 8, 2024

dotnet-policy-serviceBot assigned lambdageek Oct 8, 2024

lambdageek removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 8, 2024

lambdageek force-pushed the cdac-execution-manager branch from 0c04ca3 to af2387fCompare October 8, 2024 20:07

lambdageek added 15 commits October 10, 2024 16:22

NibbleMap: use a struct for MapUnit
ee5616b

Add some very basic ExecutionManager tests that return null
cbeb33a

fixup RangeSectionMapTests
c4af08a

use better cdac_data friends
0cab907

one more friend
e27de51

fix typos
04cd55f

markdown cleanup
848aea2

document the ExecutionManager methods
4dca4d8

cache EECodeInfo based on given code pointer, not start of the method
af85abc
The EECodeInfo includes the relative offset (given ip - start of method) so it's not ok to share for different code pointers into the same method

WIP: execution manager RangeSectionFragment test
f31e7f2

Make TestPlaceholderTarget data cache more useful; make TestRegistry …
6f3d208
…lazy

WIP: execution manager tests (still failing)
89db889

bugfix: stubCodeBlockLast is uint8
cffad93

checkpoint: unit test is working
2f26c73

lambdageek force-pushed the cdac-execution-manager branch from eb190a2 to 2f26c73Compare October 10, 2024 20:22

lambdageek added 3 commits October 11, 2024 11:10

add a simple bump allocator to MockMemorySpace
7048c4f

Add a field layout algorithm to TargetTestHelpers
159c188

use allocators a bit more
6e8fd1c

build-analysisBot mentioned this pull request Oct 11, 2024
[Mono AOT] Failed to compile System.Private.CoreLib.dll.bc #103520
Open

lambdageek marked this pull request as ready for review October 14, 2024 14:40

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and max-charlamb October 14, 2024 14:42

lambdageek added 3 commits October 14, 2024 13:37

move all the test builders to a separate class
f76ec3c

cleanup test infra
288d4ca

remove a few more magic constants
a640354

build-analysisBot mentioned this pull request Oct 14, 2024
ReadECDsaPrivateKey_BrainpoolP160r1_Pfx test failure on windows #108815
Closed

Merge branch 'main' into cdac-execution-manager
04e7de1

elinor-fung reviewed Oct 15, 2024
View reviewed changes

lambdageek added 3 commits October 16, 2024 12:11

EECodeInfo -> CodeBlock
2898390

EffectiveBitsForLevel -> GetIndexForLevel
d028a59

add documentation to managed contract impl
138c4f0

This was referenced Oct 16, 2024
WasmTestOnChrome timeouts in CI #105363
Closed
System.Runtime.Tests.WorkItemExecution "crash" on tvOS #106319
Closed
[WASI] Sockets - unknown handle index #108726
Closed
DebuggerTests other than WasmTestOnChrome timeouts in CI #108921
Closed

elinor-fung approved these changes Oct 16, 2024
View reviewed changes

lambdageekand others added 2 commits October 16, 2024 18:45

Apply suggestions from code review
4b77d68
Co-authored-by: Elinor Fung <elfung@microsoft.com>

RSLATestTarget -> RSMTestTarget
ab6d6e6

lambdageek merged commit 1b8f744 into dotnet:mainOct 17, 2024

This was referenced Oct 17, 2024
[cdac] Implement !PrintException#99302
Closed
[cdac] .NET10: Implement DAC APIs used by CLRMA #108553
Closed

github-actionsBot locked and limited conversation to collaborators Nov 17, 2024

ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 8, 2024

lambdageek added the area-Diagnostics-coreclr label Oct 8, 2024

dotnet-policy-serviceBot assigned lambdageek Oct 8, 2024

lambdageek removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 8, 2024

lambdageek force-pushed the cdac-execution-manager branch from 0c04ca3 to af2387fCompare October 8, 2024 20:07

lambdageek added 15 commits October 10, 2024 16:22

NibbleMap: use a struct for MapUnit
ee5616b

Add some very basic ExecutionManager tests that return null
cbeb33a

fixup RangeSectionMapTests
c4af08a

use better cdac_data friends
0cab907

one more friend
e27de51

fix typos
04cd55f

markdown cleanup
848aea2

document the ExecutionManager methods
4dca4d8

cache EECodeInfo based on given code pointer, not start of the method
af85abc
The EECodeInfo includes the relative offset (given ip - start of method) so it's not ok to share for different code pointers into the same method

WIP: execution manager RangeSectionFragment test
f31e7f2

Make TestPlaceholderTarget data cache more useful; make TestRegistry …
6f3d208
…lazy

WIP: execution manager tests (still failing)
89db889

bugfix: stubCodeBlockLast is uint8
cffad93

checkpoint: unit test is working
2f26c73

lambdageek force-pushed the cdac-execution-manager branch from eb190a2 to 2f26c73Compare October 10, 2024 20:22

lambdageek added 3 commits October 11, 2024 11:10

add a simple bump allocator to MockMemorySpace
7048c4f

Add a field layout algorithm to TargetTestHelpers
159c188

use allocators a bit more
6e8fd1c

build-analysisBot mentioned this pull request Oct 11, 2024
[Mono AOT] Failed to compile System.Private.CoreLib.dll.bc #103520
Open

lambdageek marked this pull request as ready for review October 14, 2024 14:40

lambdageek requested review from AaronRobinsonMSFT, davidwrighton, elinor-fung and max-charlamb October 14, 2024 14:42

lambdageek added 3 commits October 14, 2024 13:37

move all the test builders to a separate class
f76ec3c

cleanup test infra
288d4ca

remove a few more magic constants
a640354

build-analysisBot mentioned this pull request Oct 14, 2024
ReadECDsaPrivateKey_BrainpoolP160r1_Pfx test failure on windows #108815
Closed

Merge branch 'main' into cdac-execution-manager
04e7de1

elinor-fung reviewed Oct 15, 2024
View reviewed changes

lambdageek added 3 commits October 16, 2024 12:11

EECodeInfo -> CodeBlock
2898390

EffectiveBitsForLevel -> GetIndexForLevel
d028a59

add documentation to managed contract impl
138c4f0

This was referenced Oct 16, 2024
WasmTestOnChrome timeouts in CI #105363
Closed
System.Runtime.Tests.WorkItemExecution "crash" on tvOS #106319
Closed
[WASI] Sockets - unknown handle index #108726
Closed
DebuggerTests other than WasmTestOnChrome timeouts in CI #108921
Closed

elinor-fung approved these changes Oct 16, 2024
View reviewed changes

lambdageekand others added 2 commits October 16, 2024 18:45

Apply suggestions from code review
4b77d68
Co-authored-by: Elinor Fung <elfung@microsoft.com>

RSLATestTarget -> RSMTestTarget
ab6d6e6

lambdageek merged commit 1b8f744 into dotnet:mainOct 17, 2024

This was referenced Oct 17, 2024
[cdac] Implement !PrintException#99302
Closed
[cdac] .NET10: Implement DAC APIs used by CLRMA #108553
Closed

github-actionsBot locked and limited conversation to collaborators Nov 17, 2024

Uh oh!

Conversation

lambdageek commented Oct 8, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Oct 8, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lambdageek commented Oct 16, 2024

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elinor-fung commented Oct 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

lambdageek commented Oct 8, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-serviceBot commented Oct 8, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lambdageek commented Oct 16, 2024

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elinor-fung commented Oct 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

lambdageek commented Oct 8, 2024•
edited
Loading

lambdageek commented Oct 8, 2024•
edited
Loading

lambdageek commented Oct 8, 2024•
edited
Loading

lambdageek commented Oct 8, 2024•
edited
Loading