Bump versions of maintenance-packages dependencies consumed in runtime - #108806

Merged
carlossanlop merged 13 commits into
dotnet:mainfrom
carlossanlop:BumpMaintenancePackagesDependencies
Nov 22, 2024
Merged

Bump versions of maintenance-packages dependencies consumed in runtime#108806
carlossanlop merged 13 commits into
dotnet:mainfrom
carlossanlop:BumpMaintenancePackagesDependencies

Conversation

@carlossanlop

@carlossanlopcarlossanlop commented Oct 11, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

dotnet/runtime depends on these packages that we are now publishing from dotnet/maintenance-packages:

  • Microsoft.Bcl.HashCode
  • System.Buffers
  • System.Memory
  • System.Threading.Tasks.Extensions
  • System.Runtime.CompilerServices.Unsafe

Bumping their versions to consume the new preview versions, available in the dotnet-libraries feed: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet-libraries

Related PRs:

@carlossanlopcarlossanlop self-assigned this Oct 11, 2024
@dotnet-policy-service

dotnet-policy-serviceBot commented Oct 11, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

This was referenced Oct 11, 2024
Closed
Merged
ericstj
ericstj reviewed Oct 14, 2024
View reviewed changes
Comment threadeng/Versions.props Outdated
@ericstjericstj mentioned this pull request Oct 14, 2024
Closed
This was referenced Oct 18, 2024
Closed
Closed
@carlossanlop

carlossanlop commented Oct 18, 2024

Copy link
Copy Markdown
ContributorAuthor

There's a CI failure indicating that a triple slash cref pointing to MathF is ambiguous. I see that the updated System.Numerics.Vectors OOB package defines MathF but it is an internal class there. I don't see how it could be conflicting.

@carlossanlopcarlossanlop mentioned this pull request Oct 18, 2024
Closed
@carlossanlop

carlossanlop commented Oct 18, 2024

Copy link
Copy Markdown
ContributorAuthor

@ericstj@michaelgsharp@ViktorHofer I don't think the problem is in the package. When comparing the DLLs with ILSpy, before and after maintenance-packages, they all contain the MathF class and it's internal. So I don't know what could be causing the cref conflict.

The old nupkg:

  • net462
    image
  • netstandard2.0
    image

The new preview nupkg:

  • net462:
    image
  • netstandard2.0:
    image

@ericstj

ericstj commented Oct 19, 2024•
edited
Loading

Copy link
Copy Markdown
Member

The old package contained a reference assembly, which didn't include the internal MathF type. That's why the new package is hitting this. The new package only exposes the implementation, which has the internal type. This is issue dotnet/roslyn#71442.

We can workaround it by aliasing the problematic assembly, and then referring to it by the alias. I'll submit a fix.

Another way to fix this would be to put the internal MathF type in a different namespace, but I don't think we need to do that. I doubt customers will hit this bug.

@build-analysisbuild-analysisBot mentioned this pull request Oct 19, 2024
Closed
@carlossanlop

carlossanlop commented Oct 19, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks for the fix @ericstj

I doubt customers will hit this bug

So there's no way a customer will do what Tensors is doing? Is Tensors special and unique enough because of the way runtime works and consumes the package?

@carlossanlop

carlossanlop commented Oct 19, 2024

Copy link
Copy Markdown
ContributorAuthor

@MichaelSimons what specific thing abouy these nupkgs is considered a prebuilt?
We are hitting this error:

error : 6 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml. See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. Package IDs are: Microsoft.Bcl.HashCode.6.0.0-preview.1.24517.1 System.Buffers.4.6.0-preview.1.24517.1 System.Memory.4.6.0-preview.1.24517.1 System.Numerics.Vectors.4.6.0-preview.1.24517.1 System.Runtime.CompilerServices.Unsafe.6.1.0-preview.1.24517.1 System.Threading.Tasks.Extensions.4.6.0-preview.1.24517.1

@ericstj

ericstj commented Oct 21, 2024

Copy link
Copy Markdown
Member

So there's no way a customer will do what Tensors is doing?

It's not impossible, just unlikely for a customer to crefMathF from their doc comments.

what specific thing about these nupkgs is considered a prebuilt?

They're built from a repo that's not part of source build yet, and they aren't provided by SBRP. Maybe we should bring maintenance-packages into source build @MichaelSimons. In the meantime I think we can mark these as permitted prebuilts.

@ericstjericstj mentioned this pull request Oct 21, 2024
Closed
@MichaelSimons

MichaelSimons commented Oct 21, 2024

Copy link
Copy Markdown
Member

They're built from a repo that's not part of source build yet, and they aren't provided by SBRP. Maybe we should bring maintenance-packages into source build @MichaelSimons. In the meantime I think we can mark these as permitted prebuilts.

If you do this the runtime flow will fail in the sdk repo until the dotnet/maintenance-packages repo is onboarded onto SB. If you don't want to block the flow I would wait merging this PR until you have onboarded dotnet/maintenance-packages into source-build.

This was referenced Oct 21, 2024
Open
Closed
Closed
@MichaelSimonsMichaelSimons mentioned this pull request Oct 22, 2024
Closed
@carlossanlopcarlossanlop added the blocked Issue/PR is blocked on something - see comments label Oct 29, 2024
@carlossanlopcarlossanlop mentioned this pull request Oct 29, 2024
Merged
carlossanlop
carlossanlop commented Oct 30, 2024
View reviewed changes

@carlossanlopcarlossanlop left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump the versions to the preview used in SBRP.

Comment threadeng/Versions.props Outdated
Comment threadeng/Versions.props Outdated
Comment threadeng/Versions.props Outdated
Comment threadeng/Versions.props Outdated
Comment threadeng/Versions.props Outdated
@carlossanlopcarlossanlop mentioned this pull request Oct 30, 2024
Merged
@carlossanlop

carlossanlop commented Oct 30, 2024

Copy link
Copy Markdown
ContributorAuthor

I'll address the conflict after I merge #109390 which unblocks this PR (so that I don't restart the CI unnecessarily).

@build-analysisbuild-analysisBot mentioned this pull request Nov 12, 2024
Closed
@carlossanlop

carlossanlop commented Nov 12, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@ViktorHofer I updated this PR to also consume the new System.Data.SqlClient prerelease version and there's an ApiCompat failure that makes sense: The old package used to contain a netcoreapp2.1 folder, but the new package contains a net6.0 and a net8.0 folder.

Is this failure expected and supressable, or should we add a placeholder for netcoreapp2.1 in System.Data.SqlClient? (My gut says expected).

src/libraries/apicompat/ApiCompat.proj(93,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "Microsoft.DotNet.ApiCompat.Task.ValidateAssembliesTask" task failed unexpectedly.
System.IO.DirectoryNotFoundException: Could not find a part of the path '/__w/1/s/.packages/system.data.sqlclient/4.9.0-rtm.24561.10/lib/netcoreapp2.1/System.Data.SqlClient.dll'.

@ViktorHofer

ViktorHofer commented Nov 12, 2024

Copy link
Copy Markdown
Member

This line needs an update: https://github.com/dotnet/runtime/blob/main/src%2Flibraries%2Fapicompat%2FApiCompat.proj#L46

The TFM

@build-analysisbuild-analysisBot mentioned this pull request Nov 13, 2024
Closed
@carlossanlop

carlossanlop commented Nov 14, 2024

Copy link
Copy Markdown
ContributorAuthor

@cheenamalhotra@David-Engel we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?

@David-Engel

David-Engel commented Nov 14, 2024

Copy link
Copy Markdown
Contributor

we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?

Suppress, IMO.

@cheenamalhotra

cheenamalhotra commented Nov 14, 2024•
edited
Loading

Copy link
Copy Markdown
Member

@cheenamalhotra@David-Engel we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?

For tests, we can suppress.
But if its used as a product dependency, I'd recommend creating an issue to track migration to Microsoft.Data.SqlClient in future releases of .NET runtime.

@carlossanlop
Add CS0618 to System.Data.Common.Tests.csproj NoWarn list - 'SqlClien…
f362c9e
…tFactory' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.
@carlossanlop

carlossanlop commented Nov 19, 2024

Copy link
Copy Markdown
ContributorAuthor

@cheenamalhotra@David-Engel I suppressed the warning in System.Data.Common.Tests.csproj with a comment reminding to remove the suppression after the migration to Microsoft.Data.SqlClient happens in the runtime repo.

I did not see the same warning show up in product code, only test code.

ViktorHofer
ViktorHofer reviewed Nov 19, 2024
View reviewed changes
Comment threadsrc/libraries/System.Data.Common/tests/System.Data.Common.Tests.csproj Outdated
@carlossanlop

carlossanlop commented Nov 21, 2024

Copy link
Copy Markdown
ContributorAuthor

Sigh. Source build once again complaining about prebuilts:

.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24556.2/tools/SourceBuild/AfterSourceBuild.proj(81,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 6 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.Bcl.HashCode.6.0.0
System.Buffers.4.6.0
System.Memory.4.6.0
System.Numerics.Vectors.4.6.0
System.Runtime.CompilerServices.Unsafe.6.1.0
System.Threading.Tasks.Extensions.4.6.0

@carlossanlop

carlossanlop commented Nov 21, 2024

Copy link
Copy Markdown
ContributorAuthor

The wasm failures are unrelated:

@MichaelSimons

MichaelSimons commented Nov 21, 2024

Copy link
Copy Markdown
Member

Sigh. Source build once again complaining about prebuilts:

It looks like these need to be added to SBRP because of the update to use stable versions in ec8185f. This was the plan discussed in dotnet/maintenance-packages#140 (comment).

@carlossanlopcarlossanlop mentioned this pull request Nov 21, 2024
Merged
@carlossanlop

carlossanlop commented Nov 21, 2024

Copy link
Copy Markdown
ContributorAuthor

It looks like these need to be added to SBRP

Here you go dotnet/source-build-assets#1082

@carlossanlopcarlossanlop mentioned this pull request Nov 22, 2024
Merged
@carlossanlop

carlossanlop commented Nov 22, 2024

Copy link
Copy Markdown
ContributorAuthor

Darc flow PR #110071

@build-analysisbuild-analysisBot mentioned this pull request Nov 22, 2024
Open
3 tasks
@carlossanlopcarlossanlop mentioned this pull request Nov 22, 2024
Closed
@carlossanlop
carlossanlop merged commit 45b7520 into dotnet:mainNov 22, 2024
@carlossanlop
carlossanlop deleted the BumpMaintenancePackagesDependencies branch November 22, 2024 19:19
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
@carlossanlop@ericstj
@ViktorHofer@akoeplinger@mikelle-rogers
Bump versions of maintenance-packages dependencies consumed in runtime (
d9e1e95
dotnet#108806)
* Bump dependency versions of packages that now ship out of maintenance-packages (preview)
- Microsoft.Bcl.HashCode
- System.Buffers
- System.Memory
- System.Threading.Tasks.Extensions
- System.Runtime.CompilerServices.Unsafe
* Workaround name conflict for MathF: See dotnet/roslyn#71442 We refer to MathF from
a comment which hits this bug problem in Roslyn where it thinks it's
ambiguous because visibility is not considered when resolving cref's in
doc comments.
* Permit maintenance-packages prebuilts
* Suppress CS0618 on site in System.Data.Common.Tests - 'Sql*' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.
---------
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 23, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@ericstjericstjAwaiting requested review from ericstj
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomer
@marafmarafAwaiting requested review from maraf
@ilonatommyilonatommyAwaiting requested review from ilonatommy
@lewinglewingAwaiting requested review from lewing
@pavelsavarapavelsavaraAwaiting requested review from pavelsavara
@steveisoksteveisokAwaiting requested review from steveisok
@vitek-karasvitek-karasAwaiting requested review from vitek-karas
@BrzVladBrzVladAwaiting requested review from BrzVlad
@kgkgAwaiting requested review from kg
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmilos
@thaystgthaystgAwaiting requested review from thaystg
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovsky

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@carlossanlop@ericstj@MichaelSimons@ViktorHofer@David-Engel@cheenamalhotra@akoeplinger
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Bump versions of maintenance-packages dependencies consumed in runtime - #108806
Merged
carlossanlop merged 13 commits into
dotnet:mainfrom 
carlossanlop:BumpMaintenancePackagesDependencies
Nov 22, 2024
Merged
Bump versions of maintenance-packages dependencies consumed in runtime#108806
carlossanlop merged 13 commits into
dotnet:mainfrom 
carlossanlop:BumpMaintenancePackagesDependencies
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Oct 11, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
dotnet/runtime depends on these packages that we are now publishing from dotnet/maintenance-packages:
  • Microsoft.Bcl.HashCode
  • System.Buffers
  • System.Memory
  • System.Threading.Tasks.Extensions
  • System.Runtime.CompilerServices.Unsafe
Bumping their versions to consume the new preview versions, available in the dotnet-libraries feed: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet-libraries
Related PRs:
@carlossanlopcarlossanlop
self-assigned this
Oct 11, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Oct 11, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.

This was referenced Oct 11, 2024
 Closed

 Merged

ericstj
ericstj
reviewed
Oct 14, 2024
View reviewed changes
Comment threadeng/Versions.props
Outdated

@ericstjericstj
mentioned this pull request
Oct 14, 2024

Closed


This was referenced Oct 18, 2024

Closed


Closed

@carlossanlop
carlossanlop
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
There's a CI failure indicating that a triple slash cref pointing to MathF is ambiguous. I see that the updated System.Numerics.Vectors OOB package defines MathF but it is an internal class there. I don't see how it could be conflicting.
@carlossanlopcarlossanlop
mentioned this pull request
Oct 18, 2024
 Closed

@carlossanlop
carlossanlop
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
@ericstj@michaelgsharp@ViktorHofer I don't think the problem is in the package. When comparing the DLLs with ILSpy, before and after maintenance-packages, they all contain the MathF class and it's internal. So I don't know what could be causing the cref conflict.
The old nupkg:
  • net462
    image
  • netstandard2.0
    image
The new preview nupkg:
  • net462:
    image
  • netstandard2.0:
    image
@ericstj
ericstj
commented
Oct 19, 2024•

edited

Loading

Copy link


Copy Markdown

Member
The old package contained a reference assembly, which didn't include the internal MathF type. That's why the new package is hitting this. The new package only exposes the implementation, which has the internal type. This is issue dotnet/roslyn#71442.
We can workaround it by aliasing the problematic assembly, and then referring to it by the alias. I'll submit a fix.
Another way to fix this would be to put the internal MathF type in a different namespace, but I don't think we need to do that. I doubt customers will hit this bug.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 19, 2024

Closed

@carlossanlop
carlossanlop
commented
Oct 19, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks for the fix @ericstj
I doubt customers will hit this bug
So there's no way a customer will do what Tensors is doing? Is Tensors special and unique enough because of the way runtime works and consumes the package?
@carlossanlop
carlossanlop
commented
Oct 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@MichaelSimons what specific thing abouy these nupkgs is considered a prebuilt?

We are hitting this error:
error : 6 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml. See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. Package IDs are: Microsoft.Bcl.HashCode.6.0.0-preview.1.24517.1 System.Buffers.4.6.0-preview.1.24517.1 System.Memory.4.6.0-preview.1.24517.1 System.Numerics.Vectors.4.6.0-preview.1.24517.1 System.Runtime.CompilerServices.Unsafe.6.1.0-preview.1.24517.1 System.Threading.Tasks.Extensions.4.6.0-preview.1.24517.1

@ericstj
ericstj
commented
Oct 21, 2024

Copy link


Copy Markdown

Member
So there's no way a customer will do what Tensors is doing?
It's not impossible, just unlikely for a customer to crefMathF from their doc comments.
what specific thing about these nupkgs is considered a prebuilt?
They're built from a repo that's not part of source build yet, and they aren't provided by SBRP. Maybe we should bring maintenance-packages into source build @MichaelSimons. In the meantime I think we can mark these as permitted prebuilts.
@ericstjericstj
mentioned this pull request
Oct 21, 2024

Closed

@MichaelSimons
MichaelSimons
commented
Oct 21, 2024

Copy link


Copy Markdown

Member
They're built from a repo that's not part of source build yet, and they aren't provided by SBRP. Maybe we should bring maintenance-packages into source build @MichaelSimons. In the meantime I think we can mark these as permitted prebuilts.
If you do this the runtime flow will fail in the sdk repo until the dotnet/maintenance-packages repo is onboarded onto SB. If you don't want to block the flow I would wait merging this PR until you have onboarded dotnet/maintenance-packages into source-build.

This was referenced Oct 21, 2024

Open


Closed


Closed

@MichaelSimonsMichaelSimons
mentioned this pull request
Oct 22, 2024
 Closed

@carlossanlopcarlossanlop
added
the 
blocked
Issue/PR is blocked on something - see comments
label
Oct 29, 2024
@carlossanlopcarlossanlop
mentioned this pull request
Oct 29, 2024
 Merged

carlossanlop
carlossanlop
commented
Oct 30, 2024
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump the versions to the preview used in SBRP.
Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

@carlossanlopcarlossanlop
mentioned this pull request
Oct 30, 2024
 Merged

@carlossanlop
carlossanlop
commented
Oct 30, 2024

Copy link


Copy Markdown

ContributorAuthor
I'll address the conflict after I merge #109390 which unblocks this PR (so that I don't restart the CI unnecessarily).
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 12, 2024

Closed

@carlossanlop
carlossanlop
commented
Nov 12, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@ViktorHofer I updated this PR to also consume the new System.Data.SqlClient prerelease version and there's an ApiCompat failure that makes sense: The old package used to contain a netcoreapp2.1 folder, but the new package contains a net6.0 and a net8.0 folder.
Is this failure expected and supressable, or should we add a placeholder for netcoreapp2.1 in System.Data.SqlClient? (My gut says expected).
src/libraries/apicompat/ApiCompat.proj(93,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "Microsoft.DotNet.ApiCompat.Task.ValidateAssembliesTask" task failed unexpectedly.
System.IO.DirectoryNotFoundException: Could not find a part of the path '/__w/1/s/.packages/system.data.sqlclient/4.9.0-rtm.24561.10/lib/netcoreapp2.1/System.Data.SqlClient.dll'.

@ViktorHofer
ViktorHofer
commented
Nov 12, 2024

Copy link


Copy Markdown

Member
This line needs an update: https://github.com/dotnet/runtime/blob/main/src%2Flibraries%2Fapicompat%2FApiCompat.proj#L46
The TFM
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 13, 2024

Closed

@carlossanlop
carlossanlop
commented
Nov 14, 2024

Copy link


Copy Markdown

ContributorAuthor
@cheenamalhotra@David-Engel we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
@David-Engel
David-Engel
commented
Nov 14, 2024

Copy link


Copy Markdown

Contributor
we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
Suppress, IMO.
@cheenamalhotra
cheenamalhotra
commented
Nov 14, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@cheenamalhotra@David-Engel we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
For tests, we can suppress.

But if its used as a product dependency, I'd recommend creating an issue to track migration to Microsoft.Data.SqlClient in future releases of .NET runtime.
@carlossanlop
Add CS0618 to System.Data.Common.Tests.csproj NoWarn list - 'SqlClien…
f362c9e
…tFactory' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.
@carlossanlop
carlossanlop
commented
Nov 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@cheenamalhotra@David-Engel I suppressed the warning in System.Data.Common.Tests.csproj with a comment reminding to remove the suppression after the migration to Microsoft.Data.SqlClient happens in the runtime repo.
I did not see the same warning show up in product code, only test code.
ViktorHofer
ViktorHofer
reviewed
Nov 19, 2024
View reviewed changes
Comment threadsrc/libraries/System.Data.Common/tests/System.Data.Common.Tests.csproj
Outdated

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
Sigh. Source build once again complaining about prebuilts:
.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24556.2/tools/SourceBuild/AfterSourceBuild.proj(81,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 6 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.Bcl.HashCode.6.0.0
System.Buffers.4.6.0
System.Memory.4.6.0
System.Numerics.Vectors.4.6.0
System.Runtime.CompilerServices.Unsafe.6.1.0
System.Threading.Tasks.Extensions.4.6.0

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
The wasm failures are unrelated:
@MichaelSimons
MichaelSimons
commented
Nov 21, 2024

Copy link


Copy Markdown

Member
Sigh. Source build once again complaining about prebuilts:
It looks like these need to be added to SBRP because of the update to use stable versions in ec8185f. This was the plan discussed in dotnet/maintenance-packages#140 (comment).
@carlossanlopcarlossanlop
mentioned this pull request
Nov 21, 2024
 Merged

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
It looks like these need to be added to SBRP
Here you go dotnet/source-build-assets#1082
@carlossanlopcarlossanlop
mentioned this pull request
Nov 22, 2024
 Merged

@carlossanlop
carlossanlop
commented
Nov 22, 2024

Copy link


Copy Markdown

ContributorAuthor
Darc flow PR #110071
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 22, 2024

Open

3 tasks
@carlossanlopcarlossanlop
mentioned this pull request
Nov 22, 2024

Closed

@carlossanlop
carlossanlop
merged commit 45b7520
into
dotnet:mainNov 22, 2024
@carlossanlop
carlossanlop
deleted the

BumpMaintenancePackagesDependencies

branch
November 22, 2024 19:19
mikelle-rogers pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
@carlossanlop@ericstj
@ViktorHofer@akoeplinger@mikelle-rogers
Bump versions of maintenance-packages dependencies consumed in runtime (
d9e1e95
dotnet#108806)
* Bump dependency versions of packages that now ship out of maintenance-packages (preview)
- Microsoft.Bcl.HashCode
- System.Buffers
- System.Memory
- System.Threading.Tasks.Extensions
- System.Runtime.CompilerServices.Unsafe
* Workaround name conflict for MathF: See dotnet/roslyn#71442 We refer to MathF from
a comment which hits this bug problem in Roslyn where it thinks it's
ambiguous because visibility is not considered when resolving cref's in
doc comments.
* Permit maintenance-packages prebuilts
* Suppress CS0618 on site in System.Data.Common.Tests - 'Sql*' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.
---------
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@ericstjericstjAwaiting requested review from ericstj
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomer
@marafmarafAwaiting requested review from maraf
@ilonatommyilonatommyAwaiting requested review from ilonatommy
@lewinglewingAwaiting requested review from lewing
@pavelsavarapavelsavaraAwaiting requested review from pavelsavara
@steveisoksteveisokAwaiting requested review from steveisok
@vitek-karasvitek-karasAwaiting requested review from vitek-karas
@BrzVladBrzVladAwaiting requested review from BrzVlad
@kgkgAwaiting requested review from kg
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmilos
@thaystgthaystgAwaiting requested review from thaystg
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovsky

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@carlossanlop@ericstj@MichaelSimons@ViktorHofer@David-Engel@cheenamalhotra@akoeplinger

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Bump versions of maintenance-packages dependencies consumed in runtime - #108806
Merged
carlossanlop merged 13 commits into
dotnet:mainfrom 
carlossanlop:BumpMaintenancePackagesDependencies
Nov 22, 2024
Merged
Bump versions of maintenance-packages dependencies consumed in runtime#108806
carlossanlop merged 13 commits into
dotnet:mainfrom 
carlossanlop:BumpMaintenancePackagesDependencies
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Oct 11, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
dotnet/runtime depends on these packages that we are now publishing from dotnet/maintenance-packages:
  • Microsoft.Bcl.HashCode
  • System.Buffers
  • System.Memory
  • System.Threading.Tasks.Extensions
  • System.Runtime.CompilerServices.Unsafe
Bumping their versions to consume the new preview versions, available in the dotnet-libraries feed: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet-libraries
Related PRs:
@carlossanlopcarlossanlop
self-assigned this
Oct 11, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Oct 11, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.

This was referenced Oct 11, 2024
 Closed

 Merged

ericstj
ericstj
reviewed
Oct 14, 2024
View reviewed changes
Comment threadeng/Versions.props
Outdated

@ericstjericstj
mentioned this pull request
Oct 14, 2024

Closed


This was referenced Oct 18, 2024

Closed


Closed

@carlossanlop
carlossanlop
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
There's a CI failure indicating that a triple slash cref pointing to MathF is ambiguous. I see that the updated System.Numerics.Vectors OOB package defines MathF but it is an internal class there. I don't see how it could be conflicting.
@carlossanlopcarlossanlop
mentioned this pull request
Oct 18, 2024
 Closed

@carlossanlop
carlossanlop
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
@ericstj@michaelgsharp@ViktorHofer I don't think the problem is in the package. When comparing the DLLs with ILSpy, before and after maintenance-packages, they all contain the MathF class and it's internal. So I don't know what could be causing the cref conflict.
The old nupkg:
  • net462
    image
  • netstandard2.0
    image
The new preview nupkg:
  • net462:
    image
  • netstandard2.0:
    image
@ericstj
ericstj
commented
Oct 19, 2024•

edited

Loading

Copy link


Copy Markdown

Member
The old package contained a reference assembly, which didn't include the internal MathF type. That's why the new package is hitting this. The new package only exposes the implementation, which has the internal type. This is issue dotnet/roslyn#71442.
We can workaround it by aliasing the problematic assembly, and then referring to it by the alias. I'll submit a fix.
Another way to fix this would be to put the internal MathF type in a different namespace, but I don't think we need to do that. I doubt customers will hit this bug.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 19, 2024

Closed

@carlossanlop
carlossanlop
commented
Oct 19, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks for the fix @ericstj
I doubt customers will hit this bug
So there's no way a customer will do what Tensors is doing? Is Tensors special and unique enough because of the way runtime works and consumes the package?
@carlossanlop
carlossanlop
commented
Oct 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@MichaelSimons what specific thing abouy these nupkgs is considered a prebuilt?

We are hitting this error:
error : 6 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml. See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. Package IDs are: Microsoft.Bcl.HashCode.6.0.0-preview.1.24517.1 System.Buffers.4.6.0-preview.1.24517.1 System.Memory.4.6.0-preview.1.24517.1 System.Numerics.Vectors.4.6.0-preview.1.24517.1 System.Runtime.CompilerServices.Unsafe.6.1.0-preview.1.24517.1 System.Threading.Tasks.Extensions.4.6.0-preview.1.24517.1

@ericstj
ericstj
commented
Oct 21, 2024

Copy link


Copy Markdown

Member
So there's no way a customer will do what Tensors is doing?
It's not impossible, just unlikely for a customer to crefMathF from their doc comments.
what specific thing about these nupkgs is considered a prebuilt?
They're built from a repo that's not part of source build yet, and they aren't provided by SBRP. Maybe we should bring maintenance-packages into source build @MichaelSimons. In the meantime I think we can mark these as permitted prebuilts.
@ericstjericstj
mentioned this pull request
Oct 21, 2024

Closed

@MichaelSimons
MichaelSimons
commented
Oct 21, 2024

Copy link


Copy Markdown

Member
They're built from a repo that's not part of source build yet, and they aren't provided by SBRP. Maybe we should bring maintenance-packages into source build @MichaelSimons. In the meantime I think we can mark these as permitted prebuilts.
If you do this the runtime flow will fail in the sdk repo until the dotnet/maintenance-packages repo is onboarded onto SB. If you don't want to block the flow I would wait merging this PR until you have onboarded dotnet/maintenance-packages into source-build.

This was referenced Oct 21, 2024

Open


Closed


Closed

@MichaelSimonsMichaelSimons
mentioned this pull request
Oct 22, 2024
 Closed

@carlossanlopcarlossanlop
added
the 
blocked
Issue/PR is blocked on something - see comments
label
Oct 29, 2024
@carlossanlopcarlossanlop
mentioned this pull request
Oct 29, 2024
 Merged

carlossanlop
carlossanlop
commented
Oct 30, 2024
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump the versions to the preview used in SBRP.
Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

@carlossanlopcarlossanlop
mentioned this pull request
Oct 30, 2024
 Merged

@carlossanlop
carlossanlop
commented
Oct 30, 2024

Copy link


Copy Markdown

ContributorAuthor
I'll address the conflict after I merge #109390 which unblocks this PR (so that I don't restart the CI unnecessarily).
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 12, 2024

Closed

@carlossanlop
carlossanlop
commented
Nov 12, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@ViktorHofer I updated this PR to also consume the new System.Data.SqlClient prerelease version and there's an ApiCompat failure that makes sense: The old package used to contain a netcoreapp2.1 folder, but the new package contains a net6.0 and a net8.0 folder.
Is this failure expected and supressable, or should we add a placeholder for netcoreapp2.1 in System.Data.SqlClient? (My gut says expected).
src/libraries/apicompat/ApiCompat.proj(93,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "Microsoft.DotNet.ApiCompat.Task.ValidateAssembliesTask" task failed unexpectedly.
System.IO.DirectoryNotFoundException: Could not find a part of the path '/__w/1/s/.packages/system.data.sqlclient/4.9.0-rtm.24561.10/lib/netcoreapp2.1/System.Data.SqlClient.dll'.

@ViktorHofer
ViktorHofer
commented
Nov 12, 2024

Copy link


Copy Markdown

Member
This line needs an update: https://github.com/dotnet/runtime/blob/main/src%2Flibraries%2Fapicompat%2FApiCompat.proj#L46
The TFM
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 13, 2024

Closed

@carlossanlop
carlossanlop
commented
Nov 14, 2024

Copy link


Copy Markdown

ContributorAuthor
@cheenamalhotra@David-Engel we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
@David-Engel
David-Engel
commented
Nov 14, 2024

Copy link


Copy Markdown

Contributor
we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
Suppress, IMO.
@cheenamalhotra
cheenamalhotra
commented
Nov 14, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@cheenamalhotra@David-Engel we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
For tests, we can suppress.

But if its used as a product dependency, I'd recommend creating an issue to track migration to Microsoft.Data.SqlClient in future releases of .NET runtime.
@carlossanlop
Add CS0618 to System.Data.Common.Tests.csproj NoWarn list - 'SqlClien…
f362c9e
…tFactory' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.
@carlossanlop
carlossanlop
commented
Nov 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@cheenamalhotra@David-Engel I suppressed the warning in System.Data.Common.Tests.csproj with a comment reminding to remove the suppression after the migration to Microsoft.Data.SqlClient happens in the runtime repo.
I did not see the same warning show up in product code, only test code.
ViktorHofer
ViktorHofer
reviewed
Nov 19, 2024
View reviewed changes
Comment threadsrc/libraries/System.Data.Common/tests/System.Data.Common.Tests.csproj
Outdated

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
Sigh. Source build once again complaining about prebuilts:
.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24556.2/tools/SourceBuild/AfterSourceBuild.proj(81,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 6 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.Bcl.HashCode.6.0.0
System.Buffers.4.6.0
System.Memory.4.6.0
System.Numerics.Vectors.4.6.0
System.Runtime.CompilerServices.Unsafe.6.1.0
System.Threading.Tasks.Extensions.4.6.0

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
The wasm failures are unrelated:
@MichaelSimons
MichaelSimons
commented
Nov 21, 2024

Copy link


Copy Markdown

Member
Sigh. Source build once again complaining about prebuilts:
It looks like these need to be added to SBRP because of the update to use stable versions in ec8185f. This was the plan discussed in dotnet/maintenance-packages#140 (comment).
@carlossanlopcarlossanlop
mentioned this pull request
Nov 21, 2024
 Merged

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
It looks like these need to be added to SBRP
Here you go dotnet/source-build-assets#1082
@carlossanlopcarlossanlop
mentioned this pull request
Nov 22, 2024
 Merged

@carlossanlop
carlossanlop
commented
Nov 22, 2024

Copy link


Copy Markdown

ContributorAuthor
Darc flow PR #110071
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 22, 2024

Open

3 tasks
@carlossanlopcarlossanlop
mentioned this pull request
Nov 22, 2024

Closed

@carlossanlop
carlossanlop
merged commit 45b7520
into
dotnet:mainNov 22, 2024
@carlossanlop
carlossanlop
deleted the

BumpMaintenancePackagesDependencies

branch
November 22, 2024 19:19
mikelle-rogers pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
@carlossanlop@ericstj
@ViktorHofer@akoeplinger@mikelle-rogers
Bump versions of maintenance-packages dependencies consumed in runtime (
d9e1e95
dotnet#108806)
* Bump dependency versions of packages that now ship out of maintenance-packages (preview)
- Microsoft.Bcl.HashCode
- System.Buffers
- System.Memory
- System.Threading.Tasks.Extensions
- System.Runtime.CompilerServices.Unsafe
* Workaround name conflict for MathF: See dotnet/roslyn#71442 We refer to MathF from
a comment which hits this bug problem in Roslyn where it thinks it's
ambiguous because visibility is not considered when resolving cref's in
doc comments.
* Permit maintenance-packages prebuilts
* Suppress CS0618 on site in System.Data.Common.Tests - 'Sql*' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.
---------
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@ericstjericstjAwaiting requested review from ericstj
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomer
@marafmarafAwaiting requested review from maraf
@ilonatommyilonatommyAwaiting requested review from ilonatommy
@lewinglewingAwaiting requested review from lewing
@pavelsavarapavelsavaraAwaiting requested review from pavelsavara
@steveisoksteveisokAwaiting requested review from steveisok
@vitek-karasvitek-karasAwaiting requested review from vitek-karas
@BrzVladBrzVladAwaiting requested review from BrzVlad
@kgkgAwaiting requested review from kg
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmilos
@thaystgthaystgAwaiting requested review from thaystg
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovsky

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@carlossanlop@ericstj@MichaelSimons@ViktorHofer@David-Engel@cheenamalhotra@akoeplinger

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Bump versions of maintenance-packages dependencies consumed in runtime - #108806
Merged
carlossanlop merged 13 commits into
dotnet:mainfrom 
carlossanlop:BumpMaintenancePackagesDependencies
Nov 22, 2024
Merged
Bump versions of maintenance-packages dependencies consumed in runtime#108806
carlossanlop merged 13 commits into
dotnet:mainfrom 
carlossanlop:BumpMaintenancePackagesDependencies
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Oct 11, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
dotnet/runtime depends on these packages that we are now publishing from dotnet/maintenance-packages:
  • Microsoft.Bcl.HashCode
  • System.Buffers
  • System.Memory
  • System.Threading.Tasks.Extensions
  • System.Runtime.CompilerServices.Unsafe
Bumping their versions to consume the new preview versions, available in the dotnet-libraries feed: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet-libraries
Related PRs:
@carlossanlopcarlossanlop
self-assigned this
Oct 11, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Oct 11, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.

This was referenced Oct 11, 2024
 Closed

 Merged

ericstj
ericstj
reviewed
Oct 14, 2024
View reviewed changes
Comment threadeng/Versions.props
Outdated

@ericstjericstj
mentioned this pull request
Oct 14, 2024

Closed


This was referenced Oct 18, 2024

Closed


Closed

@carlossanlop
carlossanlop
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
There's a CI failure indicating that a triple slash cref pointing to MathF is ambiguous. I see that the updated System.Numerics.Vectors OOB package defines MathF but it is an internal class there. I don't see how it could be conflicting.
@carlossanlopcarlossanlop
mentioned this pull request
Oct 18, 2024
 Closed

@carlossanlop
carlossanlop
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
@ericstj@michaelgsharp@ViktorHofer I don't think the problem is in the package. When comparing the DLLs with ILSpy, before and after maintenance-packages, they all contain the MathF class and it's internal. So I don't know what could be causing the cref conflict.
The old nupkg:
  • net462
    image
  • netstandard2.0
    image
The new preview nupkg:
  • net462:
    image
  • netstandard2.0:
    image
@ericstj
ericstj
commented
Oct 19, 2024•

edited

Loading

Copy link


Copy Markdown

Member
The old package contained a reference assembly, which didn't include the internal MathF type. That's why the new package is hitting this. The new package only exposes the implementation, which has the internal type. This is issue dotnet/roslyn#71442.
We can workaround it by aliasing the problematic assembly, and then referring to it by the alias. I'll submit a fix.
Another way to fix this would be to put the internal MathF type in a different namespace, but I don't think we need to do that. I doubt customers will hit this bug.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 19, 2024

Closed

@carlossanlop
carlossanlop
commented
Oct 19, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks for the fix @ericstj
I doubt customers will hit this bug
So there's no way a customer will do what Tensors is doing? Is Tensors special and unique enough because of the way runtime works and consumes the package?
@carlossanlop
carlossanlop
commented
Oct 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@MichaelSimons what specific thing abouy these nupkgs is considered a prebuilt?

We are hitting this error:
error : 6 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml. See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. Package IDs are: Microsoft.Bcl.HashCode.6.0.0-preview.1.24517.1 System.Buffers.4.6.0-preview.1.24517.1 System.Memory.4.6.0-preview.1.24517.1 System.Numerics.Vectors.4.6.0-preview.1.24517.1 System.Runtime.CompilerServices.Unsafe.6.1.0-preview.1.24517.1 System.Threading.Tasks.Extensions.4.6.0-preview.1.24517.1

@ericstj
ericstj
commented
Oct 21, 2024

Copy link


Copy Markdown

Member
So there's no way a customer will do what Tensors is doing?
It's not impossible, just unlikely for a customer to crefMathF from their doc comments.
what specific thing about these nupkgs is considered a prebuilt?
They're built from a repo that's not part of source build yet, and they aren't provided by SBRP. Maybe we should bring maintenance-packages into source build @MichaelSimons. In the meantime I think we can mark these as permitted prebuilts.
@ericstjericstj
mentioned this pull request
Oct 21, 2024

Closed

@MichaelSimons
MichaelSimons
commented
Oct 21, 2024

Copy link


Copy Markdown

Member
They're built from a repo that's not part of source build yet, and they aren't provided by SBRP. Maybe we should bring maintenance-packages into source build @MichaelSimons. In the meantime I think we can mark these as permitted prebuilts.
If you do this the runtime flow will fail in the sdk repo until the dotnet/maintenance-packages repo is onboarded onto SB. If you don't want to block the flow I would wait merging this PR until you have onboarded dotnet/maintenance-packages into source-build.

This was referenced Oct 21, 2024

Open


Closed


Closed

@MichaelSimonsMichaelSimons
mentioned this pull request
Oct 22, 2024
 Closed

@carlossanlopcarlossanlop
added
the 
blocked
Issue/PR is blocked on something - see comments
label
Oct 29, 2024
@carlossanlopcarlossanlop
mentioned this pull request
Oct 29, 2024
 Merged

carlossanlop
carlossanlop
commented
Oct 30, 2024
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump the versions to the preview used in SBRP.
Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

@carlossanlopcarlossanlop
mentioned this pull request
Oct 30, 2024
 Merged

@carlossanlop
carlossanlop
commented
Oct 30, 2024

Copy link


Copy Markdown

ContributorAuthor
I'll address the conflict after I merge #109390 which unblocks this PR (so that I don't restart the CI unnecessarily).
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 12, 2024

Closed

@carlossanlop
carlossanlop
commented
Nov 12, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@ViktorHofer I updated this PR to also consume the new System.Data.SqlClient prerelease version and there's an ApiCompat failure that makes sense: The old package used to contain a netcoreapp2.1 folder, but the new package contains a net6.0 and a net8.0 folder.
Is this failure expected and supressable, or should we add a placeholder for netcoreapp2.1 in System.Data.SqlClient? (My gut says expected).
src/libraries/apicompat/ApiCompat.proj(93,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "Microsoft.DotNet.ApiCompat.Task.ValidateAssembliesTask" task failed unexpectedly.
System.IO.DirectoryNotFoundException: Could not find a part of the path '/__w/1/s/.packages/system.data.sqlclient/4.9.0-rtm.24561.10/lib/netcoreapp2.1/System.Data.SqlClient.dll'.

@ViktorHofer
ViktorHofer
commented
Nov 12, 2024

Copy link


Copy Markdown

Member
This line needs an update: https://github.com/dotnet/runtime/blob/main/src%2Flibraries%2Fapicompat%2FApiCompat.proj#L46
The TFM
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 13, 2024

Closed

@carlossanlop
carlossanlop
commented
Nov 14, 2024

Copy link


Copy Markdown

ContributorAuthor
@cheenamalhotra@David-Engel we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
@David-Engel
David-Engel
commented
Nov 14, 2024

Copy link


Copy Markdown

Contributor
we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
Suppress, IMO.
@cheenamalhotra
cheenamalhotra
commented
Nov 14, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@cheenamalhotra@David-Engel we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
For tests, we can suppress.

But if its used as a product dependency, I'd recommend creating an issue to track migration to Microsoft.Data.SqlClient in future releases of .NET runtime.
@carlossanlop
Add CS0618 to System.Data.Common.Tests.csproj NoWarn list - 'SqlClien…
f362c9e
…tFactory' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.
@carlossanlop
carlossanlop
commented
Nov 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@cheenamalhotra@David-Engel I suppressed the warning in System.Data.Common.Tests.csproj with a comment reminding to remove the suppression after the migration to Microsoft.Data.SqlClient happens in the runtime repo.
I did not see the same warning show up in product code, only test code.
ViktorHofer
ViktorHofer
reviewed
Nov 19, 2024
View reviewed changes
Comment threadsrc/libraries/System.Data.Common/tests/System.Data.Common.Tests.csproj
Outdated

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
Sigh. Source build once again complaining about prebuilts:
.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24556.2/tools/SourceBuild/AfterSourceBuild.proj(81,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 6 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.Bcl.HashCode.6.0.0
System.Buffers.4.6.0
System.Memory.4.6.0
System.Numerics.Vectors.4.6.0
System.Runtime.CompilerServices.Unsafe.6.1.0
System.Threading.Tasks.Extensions.4.6.0

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
The wasm failures are unrelated:
@MichaelSimons
MichaelSimons
commented
Nov 21, 2024

Copy link


Copy Markdown

Member
Sigh. Source build once again complaining about prebuilts:
It looks like these need to be added to SBRP because of the update to use stable versions in ec8185f. This was the plan discussed in dotnet/maintenance-packages#140 (comment).
@carlossanlopcarlossanlop
mentioned this pull request
Nov 21, 2024
 Merged

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
It looks like these need to be added to SBRP
Here you go dotnet/source-build-assets#1082
@carlossanlopcarlossanlop
mentioned this pull request
Nov 22, 2024
 Merged

@carlossanlop
carlossanlop
commented
Nov 22, 2024

Copy link


Copy Markdown

ContributorAuthor
Darc flow PR #110071
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 22, 2024

Open

3 tasks
@carlossanlopcarlossanlop
mentioned this pull request
Nov 22, 2024

Closed

@carlossanlop
carlossanlop
merged commit 45b7520
into
dotnet:mainNov 22, 2024
@carlossanlop
carlossanlop
deleted the

BumpMaintenancePackagesDependencies

branch
November 22, 2024 19:19
mikelle-rogers pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
@carlossanlop@ericstj
@ViktorHofer@akoeplinger@mikelle-rogers
Bump versions of maintenance-packages dependencies consumed in runtime (
d9e1e95
dotnet#108806)
* Bump dependency versions of packages that now ship out of maintenance-packages (preview)
- Microsoft.Bcl.HashCode
- System.Buffers
- System.Memory
- System.Threading.Tasks.Extensions
- System.Runtime.CompilerServices.Unsafe
* Workaround name conflict for MathF: See dotnet/roslyn#71442 We refer to MathF from
a comment which hits this bug problem in Roslyn where it thinks it's
ambiguous because visibility is not considered when resolving cref's in
doc comments.
* Permit maintenance-packages prebuilts
* Suppress CS0618 on site in System.Data.Common.Tests - 'Sql*' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.
---------
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@ericstjericstjAwaiting requested review from ericstj
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomer
@marafmarafAwaiting requested review from maraf
@ilonatommyilonatommyAwaiting requested review from ilonatommy
@lewinglewingAwaiting requested review from lewing
@pavelsavarapavelsavaraAwaiting requested review from pavelsavara
@steveisoksteveisokAwaiting requested review from steveisok
@vitek-karasvitek-karasAwaiting requested review from vitek-karas
@BrzVladBrzVladAwaiting requested review from BrzVlad
@kgkgAwaiting requested review from kg
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmilos
@thaystgthaystgAwaiting requested review from thaystg
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovsky

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@carlossanlop@ericstj@MichaelSimons@ViktorHofer@David-Engel@cheenamalhotra@akoeplinger

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Bump versions of maintenance-packages dependencies consumed in runtime - #108806
Merged
carlossanlop merged 13 commits into
dotnet:mainfrom 
carlossanlop:BumpMaintenancePackagesDependencies
Nov 22, 2024
Merged
Bump versions of maintenance-packages dependencies consumed in runtime#108806
carlossanlop merged 13 commits into
dotnet:mainfrom 
carlossanlop:BumpMaintenancePackagesDependencies
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Oct 11, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
dotnet/runtime depends on these packages that we are now publishing from dotnet/maintenance-packages:
  • Microsoft.Bcl.HashCode
  • System.Buffers
  • System.Memory
  • System.Threading.Tasks.Extensions
  • System.Runtime.CompilerServices.Unsafe
Bumping their versions to consume the new preview versions, available in the dotnet-libraries feed: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet-libraries
Related PRs:
@carlossanlopcarlossanlop
self-assigned this
Oct 11, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Oct 11, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.

This was referenced Oct 11, 2024
 Closed

 Merged

ericstj
ericstj
reviewed
Oct 14, 2024
View reviewed changes
Comment threadeng/Versions.props
Outdated

@ericstjericstj
mentioned this pull request
Oct 14, 2024

Closed


This was referenced Oct 18, 2024

Closed


Closed

@carlossanlop
carlossanlop
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
There's a CI failure indicating that a triple slash cref pointing to MathF is ambiguous. I see that the updated System.Numerics.Vectors OOB package defines MathF but it is an internal class there. I don't see how it could be conflicting.
@carlossanlopcarlossanlop
mentioned this pull request
Oct 18, 2024
 Closed

@carlossanlop
carlossanlop
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
@ericstj@michaelgsharp@ViktorHofer I don't think the problem is in the package. When comparing the DLLs with ILSpy, before and after maintenance-packages, they all contain the MathF class and it's internal. So I don't know what could be causing the cref conflict.
The old nupkg:
  • net462
    image
  • netstandard2.0
    image
The new preview nupkg:
  • net462:
    image
  • netstandard2.0:
    image
@ericstj
ericstj
commented
Oct 19, 2024•

edited

Loading

Copy link


Copy Markdown

Member
The old package contained a reference assembly, which didn't include the internal MathF type. That's why the new package is hitting this. The new package only exposes the implementation, which has the internal type. This is issue dotnet/roslyn#71442.
We can workaround it by aliasing the problematic assembly, and then referring to it by the alias. I'll submit a fix.
Another way to fix this would be to put the internal MathF type in a different namespace, but I don't think we need to do that. I doubt customers will hit this bug.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 19, 2024

Closed

@carlossanlop
carlossanlop
commented
Oct 19, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks for the fix @ericstj
I doubt customers will hit this bug
So there's no way a customer will do what Tensors is doing? Is Tensors special and unique enough because of the way runtime works and consumes the package?
@carlossanlop
carlossanlop
commented
Oct 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@MichaelSimons what specific thing abouy these nupkgs is considered a prebuilt?

We are hitting this error:
error : 6 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml. See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. Package IDs are: Microsoft.Bcl.HashCode.6.0.0-preview.1.24517.1 System.Buffers.4.6.0-preview.1.24517.1 System.Memory.4.6.0-preview.1.24517.1 System.Numerics.Vectors.4.6.0-preview.1.24517.1 System.Runtime.CompilerServices.Unsafe.6.1.0-preview.1.24517.1 System.Threading.Tasks.Extensions.4.6.0-preview.1.24517.1

@ericstj
ericstj
commented
Oct 21, 2024

Copy link


Copy Markdown

Member
So there's no way a customer will do what Tensors is doing?
It's not impossible, just unlikely for a customer to crefMathF from their doc comments.
what specific thing about these nupkgs is considered a prebuilt?
They're built from a repo that's not part of source build yet, and they aren't provided by SBRP. Maybe we should bring maintenance-packages into source build @MichaelSimons. In the meantime I think we can mark these as permitted prebuilts.
@ericstjericstj
mentioned this pull request
Oct 21, 2024

Closed

@MichaelSimons
MichaelSimons
commented
Oct 21, 2024

Copy link


Copy Markdown

Member
They're built from a repo that's not part of source build yet, and they aren't provided by SBRP. Maybe we should bring maintenance-packages into source build @MichaelSimons. In the meantime I think we can mark these as permitted prebuilts.
If you do this the runtime flow will fail in the sdk repo until the dotnet/maintenance-packages repo is onboarded onto SB. If you don't want to block the flow I would wait merging this PR until you have onboarded dotnet/maintenance-packages into source-build.

This was referenced Oct 21, 2024

Open


Closed


Closed

@MichaelSimonsMichaelSimons
mentioned this pull request
Oct 22, 2024
 Closed

@carlossanlopcarlossanlop
added
the 
blocked
Issue/PR is blocked on something - see comments
label
Oct 29, 2024
@carlossanlopcarlossanlop
mentioned this pull request
Oct 29, 2024
 Merged

carlossanlop
carlossanlop
commented
Oct 30, 2024
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump the versions to the preview used in SBRP.
Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

@carlossanlopcarlossanlop
mentioned this pull request
Oct 30, 2024
 Merged

@carlossanlop
carlossanlop
commented
Oct 30, 2024

Copy link


Copy Markdown

ContributorAuthor
I'll address the conflict after I merge #109390 which unblocks this PR (so that I don't restart the CI unnecessarily).
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 12, 2024

Closed

@carlossanlop
carlossanlop
commented
Nov 12, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@ViktorHofer I updated this PR to also consume the new System.Data.SqlClient prerelease version and there's an ApiCompat failure that makes sense: The old package used to contain a netcoreapp2.1 folder, but the new package contains a net6.0 and a net8.0 folder.
Is this failure expected and supressable, or should we add a placeholder for netcoreapp2.1 in System.Data.SqlClient? (My gut says expected).
src/libraries/apicompat/ApiCompat.proj(93,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "Microsoft.DotNet.ApiCompat.Task.ValidateAssembliesTask" task failed unexpectedly.
System.IO.DirectoryNotFoundException: Could not find a part of the path '/__w/1/s/.packages/system.data.sqlclient/4.9.0-rtm.24561.10/lib/netcoreapp2.1/System.Data.SqlClient.dll'.

@ViktorHofer
ViktorHofer
commented
Nov 12, 2024

Copy link


Copy Markdown

Member
This line needs an update: https://github.com/dotnet/runtime/blob/main/src%2Flibraries%2Fapicompat%2FApiCompat.proj#L46
The TFM
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 13, 2024

Closed

@carlossanlop
carlossanlop
commented
Nov 14, 2024

Copy link


Copy Markdown

ContributorAuthor
@cheenamalhotra@David-Engel we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
@David-Engel
David-Engel
commented
Nov 14, 2024

Copy link


Copy Markdown

Contributor
we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
Suppress, IMO.
@cheenamalhotra
cheenamalhotra
commented
Nov 14, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@cheenamalhotra@David-Engel we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
For tests, we can suppress.

But if its used as a product dependency, I'd recommend creating an issue to track migration to Microsoft.Data.SqlClient in future releases of .NET runtime.
@carlossanlop
Add CS0618 to System.Data.Common.Tests.csproj NoWarn list - 'SqlClien…
f362c9e
…tFactory' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.
@carlossanlop
carlossanlop
commented
Nov 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@cheenamalhotra@David-Engel I suppressed the warning in System.Data.Common.Tests.csproj with a comment reminding to remove the suppression after the migration to Microsoft.Data.SqlClient happens in the runtime repo.
I did not see the same warning show up in product code, only test code.
ViktorHofer
ViktorHofer
reviewed
Nov 19, 2024
View reviewed changes
Comment threadsrc/libraries/System.Data.Common/tests/System.Data.Common.Tests.csproj
Outdated

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
Sigh. Source build once again complaining about prebuilts:
.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24556.2/tools/SourceBuild/AfterSourceBuild.proj(81,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 6 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.Bcl.HashCode.6.0.0
System.Buffers.4.6.0
System.Memory.4.6.0
System.Numerics.Vectors.4.6.0
System.Runtime.CompilerServices.Unsafe.6.1.0
System.Threading.Tasks.Extensions.4.6.0

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
The wasm failures are unrelated:
@MichaelSimons
MichaelSimons
commented
Nov 21, 2024

Copy link


Copy Markdown

Member
Sigh. Source build once again complaining about prebuilts:
It looks like these need to be added to SBRP because of the update to use stable versions in ec8185f. This was the plan discussed in dotnet/maintenance-packages#140 (comment).
@carlossanlopcarlossanlop
mentioned this pull request
Nov 21, 2024
 Merged

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
It looks like these need to be added to SBRP
Here you go dotnet/source-build-assets#1082
@carlossanlopcarlossanlop
mentioned this pull request
Nov 22, 2024
 Merged

@carlossanlop
carlossanlop
commented
Nov 22, 2024

Copy link


Copy Markdown

ContributorAuthor
Darc flow PR #110071
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 22, 2024

Open

3 tasks
@carlossanlopcarlossanlop
mentioned this pull request
Nov 22, 2024

Closed

@carlossanlop
carlossanlop
merged commit 45b7520
into
dotnet:mainNov 22, 2024
@carlossanlop
carlossanlop
deleted the

BumpMaintenancePackagesDependencies

branch
November 22, 2024 19:19
mikelle-rogers pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
@carlossanlop@ericstj
@ViktorHofer@akoeplinger@mikelle-rogers
Bump versions of maintenance-packages dependencies consumed in runtime (
d9e1e95
dotnet#108806)
* Bump dependency versions of packages that now ship out of maintenance-packages (preview)
- Microsoft.Bcl.HashCode
- System.Buffers
- System.Memory
- System.Threading.Tasks.Extensions
- System.Runtime.CompilerServices.Unsafe
* Workaround name conflict for MathF: See dotnet/roslyn#71442 We refer to MathF from
a comment which hits this bug problem in Roslyn where it thinks it's
ambiguous because visibility is not considered when resolving cref's in
doc comments.
* Permit maintenance-packages prebuilts
* Suppress CS0618 on site in System.Data.Common.Tests - 'Sql*' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.
---------
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@ericstjericstjAwaiting requested review from ericstj
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomer
@marafmarafAwaiting requested review from maraf
@ilonatommyilonatommyAwaiting requested review from ilonatommy
@lewinglewingAwaiting requested review from lewing
@pavelsavarapavelsavaraAwaiting requested review from pavelsavara
@steveisoksteveisokAwaiting requested review from steveisok
@vitek-karasvitek-karasAwaiting requested review from vitek-karas
@BrzVladBrzVladAwaiting requested review from BrzVlad
@kgkgAwaiting requested review from kg
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmilos
@thaystgthaystgAwaiting requested review from thaystg
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovsky

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@carlossanlop@ericstj@MichaelSimons@ViktorHofer@David-Engel@cheenamalhotra@akoeplinger

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Bump versions of maintenance-packages dependencies consumed in runtime - #108806
Merged
carlossanlop merged 13 commits into
dotnet:mainfrom 
carlossanlop:BumpMaintenancePackagesDependencies
Nov 22, 2024
Merged
Bump versions of maintenance-packages dependencies consumed in runtime#108806
carlossanlop merged 13 commits into
dotnet:mainfrom 
carlossanlop:BumpMaintenancePackagesDependencies
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Oct 11, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
dotnet/runtime depends on these packages that we are now publishing from dotnet/maintenance-packages:
  • Microsoft.Bcl.HashCode
  • System.Buffers
  • System.Memory
  • System.Threading.Tasks.Extensions
  • System.Runtime.CompilerServices.Unsafe
Bumping their versions to consume the new preview versions, available in the dotnet-libraries feed: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet-libraries
Related PRs:
@carlossanlopcarlossanlop
self-assigned this
Oct 11, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Oct 11, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.

This was referenced Oct 11, 2024
 Closed

 Merged

ericstj
ericstj
reviewed
Oct 14, 2024
View reviewed changes
Comment threadeng/Versions.props
Outdated

@ericstjericstj
mentioned this pull request
Oct 14, 2024

Closed


This was referenced Oct 18, 2024

Closed


Closed

@carlossanlop
carlossanlop
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
There's a CI failure indicating that a triple slash cref pointing to MathF is ambiguous. I see that the updated System.Numerics.Vectors OOB package defines MathF but it is an internal class there. I don't see how it could be conflicting.
@carlossanlopcarlossanlop
mentioned this pull request
Oct 18, 2024
 Closed

@carlossanlop
carlossanlop
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
@ericstj@michaelgsharp@ViktorHofer I don't think the problem is in the package. When comparing the DLLs with ILSpy, before and after maintenance-packages, they all contain the MathF class and it's internal. So I don't know what could be causing the cref conflict.
The old nupkg:
  • net462
    image
  • netstandard2.0
    image
The new preview nupkg:
  • net462:
    image
  • netstandard2.0:
    image
@ericstj
ericstj
commented
Oct 19, 2024•

edited

Loading

Copy link


Copy Markdown

Member
The old package contained a reference assembly, which didn't include the internal MathF type. That's why the new package is hitting this. The new package only exposes the implementation, which has the internal type. This is issue dotnet/roslyn#71442.
We can workaround it by aliasing the problematic assembly, and then referring to it by the alias. I'll submit a fix.
Another way to fix this would be to put the internal MathF type in a different namespace, but I don't think we need to do that. I doubt customers will hit this bug.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 19, 2024

Closed

@carlossanlop
carlossanlop
commented
Oct 19, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks for the fix @ericstj
I doubt customers will hit this bug
So there's no way a customer will do what Tensors is doing? Is Tensors special and unique enough because of the way runtime works and consumes the package?
@carlossanlop
carlossanlop
commented
Oct 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@MichaelSimons what specific thing abouy these nupkgs is considered a prebuilt?

We are hitting this error:
error : 6 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml. See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. Package IDs are: Microsoft.Bcl.HashCode.6.0.0-preview.1.24517.1 System.Buffers.4.6.0-preview.1.24517.1 System.Memory.4.6.0-preview.1.24517.1 System.Numerics.Vectors.4.6.0-preview.1.24517.1 System.Runtime.CompilerServices.Unsafe.6.1.0-preview.1.24517.1 System.Threading.Tasks.Extensions.4.6.0-preview.1.24517.1

@ericstj
ericstj
commented
Oct 21, 2024

Copy link


Copy Markdown

Member
So there's no way a customer will do what Tensors is doing?
It's not impossible, just unlikely for a customer to crefMathF from their doc comments.
what specific thing about these nupkgs is considered a prebuilt?
They're built from a repo that's not part of source build yet, and they aren't provided by SBRP. Maybe we should bring maintenance-packages into source build @MichaelSimons. In the meantime I think we can mark these as permitted prebuilts.
@ericstjericstj
mentioned this pull request
Oct 21, 2024

Closed

@MichaelSimons
MichaelSimons
commented
Oct 21, 2024

Copy link


Copy Markdown

Member
They're built from a repo that's not part of source build yet, and they aren't provided by SBRP. Maybe we should bring maintenance-packages into source build @MichaelSimons. In the meantime I think we can mark these as permitted prebuilts.
If you do this the runtime flow will fail in the sdk repo until the dotnet/maintenance-packages repo is onboarded onto SB. If you don't want to block the flow I would wait merging this PR until you have onboarded dotnet/maintenance-packages into source-build.

This was referenced Oct 21, 2024

Open


Closed


Closed

@MichaelSimonsMichaelSimons
mentioned this pull request
Oct 22, 2024
 Closed

@carlossanlopcarlossanlop
added
the 
blocked
Issue/PR is blocked on something - see comments
label
Oct 29, 2024
@carlossanlopcarlossanlop
mentioned this pull request
Oct 29, 2024
 Merged

carlossanlop
carlossanlop
commented
Oct 30, 2024
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump the versions to the preview used in SBRP.
Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

@carlossanlopcarlossanlop
mentioned this pull request
Oct 30, 2024
 Merged

@carlossanlop
carlossanlop
commented
Oct 30, 2024

Copy link


Copy Markdown

ContributorAuthor
I'll address the conflict after I merge #109390 which unblocks this PR (so that I don't restart the CI unnecessarily).
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 12, 2024

Closed

@carlossanlop
carlossanlop
commented
Nov 12, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@ViktorHofer I updated this PR to also consume the new System.Data.SqlClient prerelease version and there's an ApiCompat failure that makes sense: The old package used to contain a netcoreapp2.1 folder, but the new package contains a net6.0 and a net8.0 folder.
Is this failure expected and supressable, or should we add a placeholder for netcoreapp2.1 in System.Data.SqlClient? (My gut says expected).
src/libraries/apicompat/ApiCompat.proj(93,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "Microsoft.DotNet.ApiCompat.Task.ValidateAssembliesTask" task failed unexpectedly.
System.IO.DirectoryNotFoundException: Could not find a part of the path '/__w/1/s/.packages/system.data.sqlclient/4.9.0-rtm.24561.10/lib/netcoreapp2.1/System.Data.SqlClient.dll'.

@ViktorHofer
ViktorHofer
commented
Nov 12, 2024

Copy link


Copy Markdown

Member
This line needs an update: https://github.com/dotnet/runtime/blob/main/src%2Flibraries%2Fapicompat%2FApiCompat.proj#L46
The TFM
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 13, 2024

Closed

@carlossanlop
carlossanlop
commented
Nov 14, 2024

Copy link


Copy Markdown

ContributorAuthor
@cheenamalhotra@David-Engel we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
@David-Engel
David-Engel
commented
Nov 14, 2024

Copy link


Copy Markdown

Contributor
we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
Suppress, IMO.
@cheenamalhotra
cheenamalhotra
commented
Nov 14, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@cheenamalhotra@David-Engel we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
For tests, we can suppress.

But if its used as a product dependency, I'd recommend creating an issue to track migration to Microsoft.Data.SqlClient in future releases of .NET runtime.
@carlossanlop
Add CS0618 to System.Data.Common.Tests.csproj NoWarn list - 'SqlClien…
f362c9e
…tFactory' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.
@carlossanlop
carlossanlop
commented
Nov 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@cheenamalhotra@David-Engel I suppressed the warning in System.Data.Common.Tests.csproj with a comment reminding to remove the suppression after the migration to Microsoft.Data.SqlClient happens in the runtime repo.
I did not see the same warning show up in product code, only test code.
ViktorHofer
ViktorHofer
reviewed
Nov 19, 2024
View reviewed changes
Comment threadsrc/libraries/System.Data.Common/tests/System.Data.Common.Tests.csproj
Outdated

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
Sigh. Source build once again complaining about prebuilts:
.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24556.2/tools/SourceBuild/AfterSourceBuild.proj(81,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 6 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.Bcl.HashCode.6.0.0
System.Buffers.4.6.0
System.Memory.4.6.0
System.Numerics.Vectors.4.6.0
System.Runtime.CompilerServices.Unsafe.6.1.0
System.Threading.Tasks.Extensions.4.6.0

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
The wasm failures are unrelated:
@MichaelSimons
MichaelSimons
commented
Nov 21, 2024

Copy link


Copy Markdown

Member
Sigh. Source build once again complaining about prebuilts:
It looks like these need to be added to SBRP because of the update to use stable versions in ec8185f. This was the plan discussed in dotnet/maintenance-packages#140 (comment).
@carlossanlopcarlossanlop
mentioned this pull request
Nov 21, 2024
 Merged

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
It looks like these need to be added to SBRP
Here you go dotnet/source-build-assets#1082
@carlossanlopcarlossanlop
mentioned this pull request
Nov 22, 2024
 Merged

@carlossanlop
carlossanlop
commented
Nov 22, 2024

Copy link


Copy Markdown

ContributorAuthor
Darc flow PR #110071
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 22, 2024

Open

3 tasks
@carlossanlopcarlossanlop
mentioned this pull request
Nov 22, 2024

Closed

@carlossanlop
carlossanlop
merged commit 45b7520
into
dotnet:mainNov 22, 2024
@carlossanlop
carlossanlop
deleted the

BumpMaintenancePackagesDependencies

branch
November 22, 2024 19:19
mikelle-rogers pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
@carlossanlop@ericstj
@ViktorHofer@akoeplinger@mikelle-rogers
Bump versions of maintenance-packages dependencies consumed in runtime (
d9e1e95
dotnet#108806)
* Bump dependency versions of packages that now ship out of maintenance-packages (preview)
- Microsoft.Bcl.HashCode
- System.Buffers
- System.Memory
- System.Threading.Tasks.Extensions
- System.Runtime.CompilerServices.Unsafe
* Workaround name conflict for MathF: See dotnet/roslyn#71442 We refer to MathF from
a comment which hits this bug problem in Roslyn where it thinks it's
ambiguous because visibility is not considered when resolving cref's in
doc comments.
* Permit maintenance-packages prebuilts
* Suppress CS0618 on site in System.Data.Common.Tests - 'Sql*' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.
---------
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@ericstjericstjAwaiting requested review from ericstj
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomer
@marafmarafAwaiting requested review from maraf
@ilonatommyilonatommyAwaiting requested review from ilonatommy
@lewinglewingAwaiting requested review from lewing
@pavelsavarapavelsavaraAwaiting requested review from pavelsavara
@steveisoksteveisokAwaiting requested review from steveisok
@vitek-karasvitek-karasAwaiting requested review from vitek-karas
@BrzVladBrzVladAwaiting requested review from BrzVlad
@kgkgAwaiting requested review from kg
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmilos
@thaystgthaystgAwaiting requested review from thaystg
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovsky

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@carlossanlop@ericstj@MichaelSimons@ViktorHofer@David-Engel@cheenamalhotra@akoeplinger

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Bump versions of maintenance-packages dependencies consumed in runtime - #108806
Merged
carlossanlop merged 13 commits into
dotnet:mainfrom 
carlossanlop:BumpMaintenancePackagesDependencies
Nov 22, 2024
Merged
Bump versions of maintenance-packages dependencies consumed in runtime#108806
carlossanlop merged 13 commits into
dotnet:mainfrom 
carlossanlop:BumpMaintenancePackagesDependencies
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Oct 11, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
dotnet/runtime depends on these packages that we are now publishing from dotnet/maintenance-packages:
  • Microsoft.Bcl.HashCode
  • System.Buffers
  • System.Memory
  • System.Threading.Tasks.Extensions
  • System.Runtime.CompilerServices.Unsafe
Bumping their versions to consume the new preview versions, available in the dotnet-libraries feed: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet-libraries
Related PRs:
@carlossanlopcarlossanlop
self-assigned this
Oct 11, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Oct 11, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.

This was referenced Oct 11, 2024
 Closed

 Merged

ericstj
ericstj
reviewed
Oct 14, 2024
View reviewed changes
Comment threadeng/Versions.props
Outdated

@ericstjericstj
mentioned this pull request
Oct 14, 2024

Closed


This was referenced Oct 18, 2024

Closed


Closed

@carlossanlop
carlossanlop
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
There's a CI failure indicating that a triple slash cref pointing to MathF is ambiguous. I see that the updated System.Numerics.Vectors OOB package defines MathF but it is an internal class there. I don't see how it could be conflicting.
@carlossanlopcarlossanlop
mentioned this pull request
Oct 18, 2024
 Closed

@carlossanlop
carlossanlop
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
@ericstj@michaelgsharp@ViktorHofer I don't think the problem is in the package. When comparing the DLLs with ILSpy, before and after maintenance-packages, they all contain the MathF class and it's internal. So I don't know what could be causing the cref conflict.
The old nupkg:
  • net462
    image
  • netstandard2.0
    image
The new preview nupkg:
  • net462:
    image
  • netstandard2.0:
    image
@ericstj
ericstj
commented
Oct 19, 2024•

edited

Loading

Copy link


Copy Markdown

Member
The old package contained a reference assembly, which didn't include the internal MathF type. That's why the new package is hitting this. The new package only exposes the implementation, which has the internal type. This is issue dotnet/roslyn#71442.
We can workaround it by aliasing the problematic assembly, and then referring to it by the alias. I'll submit a fix.
Another way to fix this would be to put the internal MathF type in a different namespace, but I don't think we need to do that. I doubt customers will hit this bug.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 19, 2024

Closed

@carlossanlop
carlossanlop
commented
Oct 19, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks for the fix @ericstj
I doubt customers will hit this bug
So there's no way a customer will do what Tensors is doing? Is Tensors special and unique enough because of the way runtime works and consumes the package?
@carlossanlop
carlossanlop
commented
Oct 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@MichaelSimons what specific thing abouy these nupkgs is considered a prebuilt?

We are hitting this error:
error : 6 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml. See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. Package IDs are: Microsoft.Bcl.HashCode.6.0.0-preview.1.24517.1 System.Buffers.4.6.0-preview.1.24517.1 System.Memory.4.6.0-preview.1.24517.1 System.Numerics.Vectors.4.6.0-preview.1.24517.1 System.Runtime.CompilerServices.Unsafe.6.1.0-preview.1.24517.1 System.Threading.Tasks.Extensions.4.6.0-preview.1.24517.1

@ericstj
ericstj
commented
Oct 21, 2024

Copy link


Copy Markdown

Member
So there's no way a customer will do what Tensors is doing?
It's not impossible, just unlikely for a customer to crefMathF from their doc comments.
what specific thing about these nupkgs is considered a prebuilt?
They're built from a repo that's not part of source build yet, and they aren't provided by SBRP. Maybe we should bring maintenance-packages into source build @MichaelSimons. In the meantime I think we can mark these as permitted prebuilts.
@ericstjericstj
mentioned this pull request
Oct 21, 2024

Closed

@MichaelSimons
MichaelSimons
commented
Oct 21, 2024

Copy link


Copy Markdown

Member
They're built from a repo that's not part of source build yet, and they aren't provided by SBRP. Maybe we should bring maintenance-packages into source build @MichaelSimons. In the meantime I think we can mark these as permitted prebuilts.
If you do this the runtime flow will fail in the sdk repo until the dotnet/maintenance-packages repo is onboarded onto SB. If you don't want to block the flow I would wait merging this PR until you have onboarded dotnet/maintenance-packages into source-build.

This was referenced Oct 21, 2024

Open


Closed


Closed

@MichaelSimonsMichaelSimons
mentioned this pull request
Oct 22, 2024
 Closed

@carlossanlopcarlossanlop
added
the 
blocked
Issue/PR is blocked on something - see comments
label
Oct 29, 2024
@carlossanlopcarlossanlop
mentioned this pull request
Oct 29, 2024
 Merged

carlossanlop
carlossanlop
commented
Oct 30, 2024
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump the versions to the preview used in SBRP.
Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

@carlossanlopcarlossanlop
mentioned this pull request
Oct 30, 2024
 Merged

@carlossanlop
carlossanlop
commented
Oct 30, 2024

Copy link


Copy Markdown

ContributorAuthor
I'll address the conflict after I merge #109390 which unblocks this PR (so that I don't restart the CI unnecessarily).
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 12, 2024

Closed

@carlossanlop
carlossanlop
commented
Nov 12, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@ViktorHofer I updated this PR to also consume the new System.Data.SqlClient prerelease version and there's an ApiCompat failure that makes sense: The old package used to contain a netcoreapp2.1 folder, but the new package contains a net6.0 and a net8.0 folder.
Is this failure expected and supressable, or should we add a placeholder for netcoreapp2.1 in System.Data.SqlClient? (My gut says expected).
src/libraries/apicompat/ApiCompat.proj(93,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "Microsoft.DotNet.ApiCompat.Task.ValidateAssembliesTask" task failed unexpectedly.
System.IO.DirectoryNotFoundException: Could not find a part of the path '/__w/1/s/.packages/system.data.sqlclient/4.9.0-rtm.24561.10/lib/netcoreapp2.1/System.Data.SqlClient.dll'.

@ViktorHofer
ViktorHofer
commented
Nov 12, 2024

Copy link


Copy Markdown

Member
This line needs an update: https://github.com/dotnet/runtime/blob/main/src%2Flibraries%2Fapicompat%2FApiCompat.proj#L46
The TFM
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 13, 2024

Closed

@carlossanlop
carlossanlop
commented
Nov 14, 2024

Copy link


Copy Markdown

ContributorAuthor
@cheenamalhotra@David-Engel we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
@David-Engel
David-Engel
commented
Nov 14, 2024

Copy link


Copy Markdown

Contributor
we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
Suppress, IMO.
@cheenamalhotra
cheenamalhotra
commented
Nov 14, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@cheenamalhotra@David-Engel we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
For tests, we can suppress.

But if its used as a product dependency, I'd recommend creating an issue to track migration to Microsoft.Data.SqlClient in future releases of .NET runtime.
@carlossanlop
Add CS0618 to System.Data.Common.Tests.csproj NoWarn list - 'SqlClien…
f362c9e
…tFactory' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.
@carlossanlop
carlossanlop
commented
Nov 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@cheenamalhotra@David-Engel I suppressed the warning in System.Data.Common.Tests.csproj with a comment reminding to remove the suppression after the migration to Microsoft.Data.SqlClient happens in the runtime repo.
I did not see the same warning show up in product code, only test code.
ViktorHofer
ViktorHofer
reviewed
Nov 19, 2024
View reviewed changes
Comment threadsrc/libraries/System.Data.Common/tests/System.Data.Common.Tests.csproj
Outdated

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
Sigh. Source build once again complaining about prebuilts:
.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24556.2/tools/SourceBuild/AfterSourceBuild.proj(81,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 6 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.Bcl.HashCode.6.0.0
System.Buffers.4.6.0
System.Memory.4.6.0
System.Numerics.Vectors.4.6.0
System.Runtime.CompilerServices.Unsafe.6.1.0
System.Threading.Tasks.Extensions.4.6.0

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
The wasm failures are unrelated:
@MichaelSimons
MichaelSimons
commented
Nov 21, 2024

Copy link


Copy Markdown

Member
Sigh. Source build once again complaining about prebuilts:
It looks like these need to be added to SBRP because of the update to use stable versions in ec8185f. This was the plan discussed in dotnet/maintenance-packages#140 (comment).
@carlossanlopcarlossanlop
mentioned this pull request
Nov 21, 2024
 Merged

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
It looks like these need to be added to SBRP
Here you go dotnet/source-build-assets#1082
@carlossanlopcarlossanlop
mentioned this pull request
Nov 22, 2024
 Merged

@carlossanlop
carlossanlop
commented
Nov 22, 2024

Copy link


Copy Markdown

ContributorAuthor
Darc flow PR #110071
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 22, 2024

Open

3 tasks
@carlossanlopcarlossanlop
mentioned this pull request
Nov 22, 2024

Closed

@carlossanlop
carlossanlop
merged commit 45b7520
into
dotnet:mainNov 22, 2024
@carlossanlop
carlossanlop
deleted the

BumpMaintenancePackagesDependencies

branch
November 22, 2024 19:19
mikelle-rogers pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
@carlossanlop@ericstj
@ViktorHofer@akoeplinger@mikelle-rogers
Bump versions of maintenance-packages dependencies consumed in runtime (
d9e1e95
dotnet#108806)
* Bump dependency versions of packages that now ship out of maintenance-packages (preview)
- Microsoft.Bcl.HashCode
- System.Buffers
- System.Memory
- System.Threading.Tasks.Extensions
- System.Runtime.CompilerServices.Unsafe
* Workaround name conflict for MathF: See dotnet/roslyn#71442 We refer to MathF from
a comment which hits this bug problem in Roslyn where it thinks it's
ambiguous because visibility is not considered when resolving cref's in
doc comments.
* Permit maintenance-packages prebuilts
* Suppress CS0618 on site in System.Data.Common.Tests - 'Sql*' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.
---------
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@ericstjericstjAwaiting requested review from ericstj
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomer
@marafmarafAwaiting requested review from maraf
@ilonatommyilonatommyAwaiting requested review from ilonatommy
@lewinglewingAwaiting requested review from lewing
@pavelsavarapavelsavaraAwaiting requested review from pavelsavara
@steveisoksteveisokAwaiting requested review from steveisok
@vitek-karasvitek-karasAwaiting requested review from vitek-karas
@BrzVladBrzVladAwaiting requested review from BrzVlad
@kgkgAwaiting requested review from kg
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmilos
@thaystgthaystgAwaiting requested review from thaystg
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovsky

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@carlossanlop@ericstj@MichaelSimons@ViktorHofer@David-Engel@cheenamalhotra@akoeplinger

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Bump versions of maintenance-packages dependencies consumed in runtime - #108806
Merged
carlossanlop merged 13 commits into
dotnet:mainfrom 
carlossanlop:BumpMaintenancePackagesDependencies
Nov 22, 2024
Merged
Bump versions of maintenance-packages dependencies consumed in runtime#108806
carlossanlop merged 13 commits into
dotnet:mainfrom 
carlossanlop:BumpMaintenancePackagesDependencies
Conversation
@carlossanlop
@carlossanlopcarlossanlop
commented
Oct 11, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
dotnet/runtime depends on these packages that we are now publishing from dotnet/maintenance-packages:
  • Microsoft.Bcl.HashCode
  • System.Buffers
  • System.Memory
  • System.Threading.Tasks.Extensions
  • System.Runtime.CompilerServices.Unsafe
Bumping their versions to consume the new preview versions, available in the dotnet-libraries feed: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet-libraries
Related PRs:
@carlossanlopcarlossanlop
self-assigned this
Oct 11, 2024
@dotnet-policy-service
dotnet-policy-serviceBot
commented
Oct 11, 2024

Copy link


Copy Markdown

Contributor
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries

See info in area-owners.md if you want to be subscribed.

This was referenced Oct 11, 2024
 Closed

 Merged

ericstj
ericstj
reviewed
Oct 14, 2024
View reviewed changes
Comment threadeng/Versions.props
Outdated

@ericstjericstj
mentioned this pull request
Oct 14, 2024

Closed


This was referenced Oct 18, 2024

Closed


Closed

@carlossanlop
carlossanlop
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
There's a CI failure indicating that a triple slash cref pointing to MathF is ambiguous. I see that the updated System.Numerics.Vectors OOB package defines MathF but it is an internal class there. I don't see how it could be conflicting.
@carlossanlopcarlossanlop
mentioned this pull request
Oct 18, 2024
 Closed

@carlossanlop
carlossanlop
commented
Oct 18, 2024

Copy link


Copy Markdown

ContributorAuthor
@ericstj@michaelgsharp@ViktorHofer I don't think the problem is in the package. When comparing the DLLs with ILSpy, before and after maintenance-packages, they all contain the MathF class and it's internal. So I don't know what could be causing the cref conflict.
The old nupkg:
  • net462
    image
  • netstandard2.0
    image
The new preview nupkg:
  • net462:
    image
  • netstandard2.0:
    image
@ericstj
ericstj
commented
Oct 19, 2024•

edited

Loading

Copy link


Copy Markdown

Member
The old package contained a reference assembly, which didn't include the internal MathF type. That's why the new package is hitting this. The new package only exposes the implementation, which has the internal type. This is issue dotnet/roslyn#71442.
We can workaround it by aliasing the problematic assembly, and then referring to it by the alias. I'll submit a fix.
Another way to fix this would be to put the internal MathF type in a different namespace, but I don't think we need to do that. I doubt customers will hit this bug.
@build-analysisbuild-analysisBot
mentioned this pull request
Oct 19, 2024

Closed

@carlossanlop
carlossanlop
commented
Oct 19, 2024

Copy link


Copy Markdown

ContributorAuthor
Thanks for the fix @ericstj
I doubt customers will hit this bug
So there's no way a customer will do what Tensors is doing? Is Tensors special and unique enough because of the way runtime works and consumes the package?
@carlossanlop
carlossanlop
commented
Oct 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@MichaelSimons what specific thing abouy these nupkgs is considered a prebuilt?

We are hitting this error:
error : 6 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml. See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. Package IDs are: Microsoft.Bcl.HashCode.6.0.0-preview.1.24517.1 System.Buffers.4.6.0-preview.1.24517.1 System.Memory.4.6.0-preview.1.24517.1 System.Numerics.Vectors.4.6.0-preview.1.24517.1 System.Runtime.CompilerServices.Unsafe.6.1.0-preview.1.24517.1 System.Threading.Tasks.Extensions.4.6.0-preview.1.24517.1

@ericstj
ericstj
commented
Oct 21, 2024

Copy link


Copy Markdown

Member
So there's no way a customer will do what Tensors is doing?
It's not impossible, just unlikely for a customer to crefMathF from their doc comments.
what specific thing about these nupkgs is considered a prebuilt?
They're built from a repo that's not part of source build yet, and they aren't provided by SBRP. Maybe we should bring maintenance-packages into source build @MichaelSimons. In the meantime I think we can mark these as permitted prebuilts.
@ericstjericstj
mentioned this pull request
Oct 21, 2024

Closed

@MichaelSimons
MichaelSimons
commented
Oct 21, 2024

Copy link


Copy Markdown

Member
They're built from a repo that's not part of source build yet, and they aren't provided by SBRP. Maybe we should bring maintenance-packages into source build @MichaelSimons. In the meantime I think we can mark these as permitted prebuilts.
If you do this the runtime flow will fail in the sdk repo until the dotnet/maintenance-packages repo is onboarded onto SB. If you don't want to block the flow I would wait merging this PR until you have onboarded dotnet/maintenance-packages into source-build.

This was referenced Oct 21, 2024

Open


Closed


Closed

@MichaelSimonsMichaelSimons
mentioned this pull request
Oct 22, 2024
 Closed

@carlossanlopcarlossanlop
added
the 
blocked
Issue/PR is blocked on something - see comments
label
Oct 29, 2024
@carlossanlopcarlossanlop
mentioned this pull request
Oct 29, 2024
 Merged

carlossanlop
carlossanlop
commented
Oct 30, 2024
View reviewed changes
@carlossanlopcarlossanlop
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump the versions to the preview used in SBRP.
Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

Comment threadeng/Versions.props
Outdated

@carlossanlopcarlossanlop
mentioned this pull request
Oct 30, 2024
 Merged

@carlossanlop
carlossanlop
commented
Oct 30, 2024

Copy link


Copy Markdown

ContributorAuthor
I'll address the conflict after I merge #109390 which unblocks this PR (so that I don't restart the CI unnecessarily).
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 12, 2024

Closed

@carlossanlop
carlossanlop
commented
Nov 12, 2024•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@ViktorHofer I updated this PR to also consume the new System.Data.SqlClient prerelease version and there's an ApiCompat failure that makes sense: The old package used to contain a netcoreapp2.1 folder, but the new package contains a net6.0 and a net8.0 folder.
Is this failure expected and supressable, or should we add a placeholder for netcoreapp2.1 in System.Data.SqlClient? (My gut says expected).
src/libraries/apicompat/ApiCompat.proj(93,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "Microsoft.DotNet.ApiCompat.Task.ValidateAssembliesTask" task failed unexpectedly.
System.IO.DirectoryNotFoundException: Could not find a part of the path '/__w/1/s/.packages/system.data.sqlclient/4.9.0-rtm.24561.10/lib/netcoreapp2.1/System.Data.SqlClient.dll'.

@ViktorHofer
ViktorHofer
commented
Nov 12, 2024

Copy link


Copy Markdown

Member
This line needs an update: https://github.com/dotnet/runtime/blob/main/src%2Flibraries%2Fapicompat%2FApiCompat.proj#L46
The TFM
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 13, 2024

Closed

@carlossanlop
carlossanlop
commented
Nov 14, 2024

Copy link


Copy Markdown

ContributorAuthor
@cheenamalhotra@David-Engel we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
@David-Engel
David-Engel
commented
Nov 14, 2024

Copy link


Copy Markdown

Contributor
we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
Suppress, IMO.
@cheenamalhotra
cheenamalhotra
commented
Nov 14, 2024•

edited

Loading

Copy link


Copy Markdown

Member
@cheenamalhotra@David-Engel we're updating the SqlClient dependency in runtime to the latest. I suppose the warning is expected since it's now marked as obsolete. Should we suppress it or what do you suggest?
For tests, we can suppress.

But if its used as a product dependency, I'd recommend creating an issue to track migration to Microsoft.Data.SqlClient in future releases of .NET runtime.
@carlossanlop
Add CS0618 to System.Data.Common.Tests.csproj NoWarn list - 'SqlClien…
f362c9e
…tFactory' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.
@carlossanlop
carlossanlop
commented
Nov 19, 2024

Copy link


Copy Markdown

ContributorAuthor
@cheenamalhotra@David-Engel I suppressed the warning in System.Data.Common.Tests.csproj with a comment reminding to remove the suppression after the migration to Microsoft.Data.SqlClient happens in the runtime repo.
I did not see the same warning show up in product code, only test code.
ViktorHofer
ViktorHofer
reviewed
Nov 19, 2024
View reviewed changes
Comment threadsrc/libraries/System.Data.Common/tests/System.Data.Common.Tests.csproj
Outdated

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
Sigh. Source build once again complaining about prebuilts:
.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24556.2/tools/SourceBuild/AfterSourceBuild.proj(81,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 6 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.Bcl.HashCode.6.0.0
System.Buffers.4.6.0
System.Memory.4.6.0
System.Numerics.Vectors.4.6.0
System.Runtime.CompilerServices.Unsafe.6.1.0
System.Threading.Tasks.Extensions.4.6.0

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
The wasm failures are unrelated:
@MichaelSimons
MichaelSimons
commented
Nov 21, 2024

Copy link


Copy Markdown

Member
Sigh. Source build once again complaining about prebuilts:
It looks like these need to be added to SBRP because of the update to use stable versions in ec8185f. This was the plan discussed in dotnet/maintenance-packages#140 (comment).
@carlossanlopcarlossanlop
mentioned this pull request
Nov 21, 2024
 Merged

@carlossanlop
carlossanlop
commented
Nov 21, 2024

Copy link


Copy Markdown

ContributorAuthor
It looks like these need to be added to SBRP
Here you go dotnet/source-build-assets#1082
@carlossanlopcarlossanlop
mentioned this pull request
Nov 22, 2024
 Merged

@carlossanlop
carlossanlop
commented
Nov 22, 2024

Copy link


Copy Markdown

ContributorAuthor
Darc flow PR #110071
@build-analysisbuild-analysisBot
mentioned this pull request
Nov 22, 2024

Open

3 tasks
@carlossanlopcarlossanlop
mentioned this pull request
Nov 22, 2024

Closed

@carlossanlop
carlossanlop
merged commit 45b7520
into
dotnet:mainNov 22, 2024
@carlossanlop
carlossanlop
deleted the

BumpMaintenancePackagesDependencies

branch
November 22, 2024 19:19
mikelle-rogers pushed a commit
to mikelle-rogers/runtime
that referenced
this pull request
Dec 10, 2024
@carlossanlop@ericstj
@ViktorHofer@akoeplinger@mikelle-rogers
Bump versions of maintenance-packages dependencies consumed in runtime (
d9e1e95
dotnet#108806)
* Bump dependency versions of packages that now ship out of maintenance-packages (preview)
- Microsoft.Bcl.HashCode
- System.Buffers
- System.Memory
- System.Threading.Tasks.Extensions
- System.Runtime.CompilerServices.Unsafe
* Workaround name conflict for MathF: See dotnet/roslyn#71442 We refer to MathF from
a comment which hits this bug problem in Roslyn where it thinks it's
ambiguous because visibility is not considered when resolving cref's in
doc comments.
* Permit maintenance-packages prebuilts
* Suppress CS0618 on site in System.Data.Common.Tests - 'Sql*' is obsolete: 'Use the Microsoft.Data.SqlClient package instead.
---------
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
@github-actionsgithub-actionsBot
locked and limited conversation to collaborators
Dec 23, 2024
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers

@akoeplingerakoeplingerakoeplinger approved these changes
@ViktorHoferViktorHoferViktorHofer approved these changes
@ericstjericstjAwaiting requested review from ericstj
@jeffhandleyjeffhandleyAwaiting requested review from jeffhandley
@marek-safarmarek-safarAwaiting requested review from marek-safar
@sbomersbomerAwaiting requested review from sbomer
@marafmarafAwaiting requested review from maraf
@ilonatommyilonatommyAwaiting requested review from ilonatommy
@lewinglewingAwaiting requested review from lewing
@pavelsavarapavelsavaraAwaiting requested review from pavelsavara
@steveisoksteveisokAwaiting requested review from steveisok
@vitek-karasvitek-karasAwaiting requested review from vitek-karas
@BrzVladBrzVladAwaiting requested review from BrzVlad
@kgkgAwaiting requested review from kg
@kotlarmiloskotlarmilosAwaiting requested review from kotlarmilos
@thaystgthaystgAwaiting requested review from thaystg
@MichalStrehovskyMichalStrehovskyAwaiting requested review from MichalStrehovsky

Assignees

@carlossanlopcarlossanlop

Labels

area-Infrastructure-libraries

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

7 participants

@carlossanlop@ericstj@MichaelSimons@ViktorHofer@David-Engel@cheenamalhotra@akoeplinger