Uh oh!
There was an error while loading. Please reload this page.
Update stepping through ExternalMethodFixup under the Debugger - #108942
Merged
mikelle-rogers merged 5 commits intoOct 28, 2024
Conversation
Contributor
Tagging subscribers to this area: @mangod9 |
mikelle-rogers
requested review from
a team, AaronRobinsonMSFT, jkotas and noahfalkOctober 16, 2024 19:45
mikelle-rogers
marked this pull request as ready for review
October 16, 2024 19:46
jkotas
reviewed
Oct 16, 2024
Uh oh!
There was an error while loading. Please reload this page.
noahfalk
approved these changes
Oct 16, 2024
noahfalk
left a comment
Member
There was a problem hiding this comment.
LGTM, a few minor suggestions inline 👍
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jkotas
reviewed
Oct 22, 2024
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates stepping through the ExternalMethodFixup stub, used when calling other modules in a R2R app, under the debugger by introducing a callback rather than setting a breakpoint within the stub. This is needed as a result of the app crashing on MacOS arm64 if the breakpoint is set on the text section of the module.