Skip to content

Conditionally check the compiler flags in libs.native - #109228

Merged
jkoritzinsky merged 1 commit into
dotnet:mainfrom
am11:patch-13
Nov 5, 2024
Merged

Conditionally check the compiler flags in libs.native#109228
jkoritzinsky merged 1 commit into
dotnet:mainfrom
am11:patch-13

Conversation

@am11

@am11am11 commented Oct 25, 2024

Copy link
Copy Markdown
Member

Instead of suppressing all unknown options.

@ghostghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 25, 2024
@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Oct 25, 2024
@am11am11 added area-Infrastructure-libraries and removed community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 25, 2024
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@am11

am11 commented Nov 5, 2024

Copy link
Copy Markdown
MemberAuthor

@jkoritzinsky, I think we would need to backport this to 9.0 as well?

@jkoritzinsky

Copy link
Copy Markdown
Member

I'll merge this in and backport it

@jkoritzinsky

Copy link
Copy Markdown
Member

/backport to release/9.0-staging

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/11689727211

@jkoritzinsky

Copy link
Copy Markdown
Member

/ba-g failures known

@jkoritzinsky
jkoritzinsky merged commit 837e004 into dotnet:mainNov 5, 2024
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 6, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@am11@jkoritzinsky