Skip to content

[release/9.0-staging] Automate dl 9 0 - #109291

Closed
lewing wants to merge 1 commit into
dotnet:release/9.0-stagingfrom
lewing:automate-dl-9-0
Closed

[release/9.0-staging] Automate dl 9 0#109291
lewing wants to merge 1 commit into
dotnet:release/9.0-stagingfrom
lewing:automate-dl-9-0

Conversation

@lewing

@lewinglewing commented Oct 28, 2024

Copy link
Copy Markdown
Member

No description provided.

@lewinglewing added this to the 9.0.1 milestone Oct 28, 2024
@ghostghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 28, 2024
@lewinglewing added area-Workloads Workloads like wasm-tools and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 28, 2024
carlossanlop
carlossanlop suggested changes Oct 28, 2024
View reviewed changes

@carlossanlopcarlossanlop left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lewing - Please retarget this PR to the release/9.0-staging branch.

You can retarget to that branch by clicking on the Edit button on the top right (next to the PR title) and choosing the release/9.0-staging branch from the dropdown. Important: Please make sure you don't bring any unrelated changes from the release/9.0 branch when retargeting to release/9.0-staging.

@lewing
lewing changed the base branch from release/9.0 to release/9.0-stagingOctober 31, 2024 17:21
This was referenced Oct 31, 2024
Open
Closed
Closed
Closed
@carlossanlopcarlossanlop modified the milestones: 9.0.1, 9.0.2Nov 21, 2024
@carlossanlopcarlossanlop changed the title [release/9/0] Automate dl 9 0[release/9.0-staging] Automate dl 9 0Nov 21, 2024
marcpopMSFT
marcpopMSFT reviewed Dec 10, 2024
View reviewed changes
Comment threadeng/Versions.props
<PatchVersion>0</PatchVersion>
<SdkBandVersion>9.0.100</SdkBandVersion>
<PackageVersionNet8>8.0.11</PackageVersionNet8>
<PackageVersionNet8>8.0.$([MSBuild]::Add($([System.Version]::Parse('$(ProductVersion)').Build),11))</PackageVersionNet8>

@marcpopMSFTmarcpopMSFTDec 10, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want PatchVersion here and not ProductVersion

@lewinglewingDec 10, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It parses the ProductVersion, at least in 8.0 that also changed? Is there some reason it is still 9.0.0 here?

@marcpopMSFTmarcpopMSFTDec 10, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, I just saw the productversion and didn't notice the parse. Does parsing that and grabbing build do the right thing? I actually don't know.

@carlossanlop

carlossanlop commented Dec 10, 2024

Copy link
Copy Markdown
Contributor

We'll merge the other one instead of this one: #110586

@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jan 10, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@marcpopMSFTmarcpopMSFTmarcpopMSFT left review comments
@wtgodbewtgodbeAwaiting requested review from wtgodbe
@carlossanlopcarlossanlopAwaiting requested review from carlossanlop

Assignees

@lewinglewing

Labels

area-WorkloadsWorkloads like wasm-tools

Projects

None yet

Milestone

9.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@lewing@carlossanlop@marcpopMSFT