Uh oh!
There was an error while loading. Please reload this page.
Haiku: Initial CoreCLR support - #109580
Merged
Merged
Conversation
Contributor
Tagging subscribers to this area: @hoyosjs |
trungnt2910
commented
Nov 6, 2024
ContributorAuthor
Changes to |
trungnt2910force-pushed
the
dev/trungnt2910/haiku-coreclr
branch
from
November 6, 2024 13:35
23b8049 to
0b8188dComparejanvorli
reviewed
Nov 7, 2024
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
janvorli
commented
Nov 7, 2024
Member
@trungnt2910 can you please resolve the conflict so that I can merge the change? |
This contains a part of the code required to build CoreCLR and get `paltests` to pass on Haiku. This commit covers `src/coreclr/**`, except the PAL files included in the previous commit. Co-authored-by: Jessica Hamilton <jessica.l.hamilton@gmail.com>
This was removed in dotnet#103441 but required for Haiku builds.
trungnt2910force-pushed
the
dev/trungnt2910/haiku-coreclr
branch
from
November 8, 2024 02:20
0b8188d to
1df901aCompareContributorAuthor
Done. Best to wait for the Haiku builds CI to succeed as well before merging though. UPDATE: It's successful now. |
janvorli
commented
Dec 6, 2024
Member
@trungnt2910 I am sorry, I've missed you've added note that the Haiku build CI succeeded. Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains a part of the code required to build CoreCLR and get
palteststo pass on Haiku.This commit covers
src/coreclr/**, except the PAL files included in the previous commit.Part of #55803.