Uh oh!
There was an error while loading. Please reload this page.
Merging internal commits for release/9.0 - #109744
Merged
carlossanlop merged 48 commits intoNov 26, 2024
Merged
Conversation
# Description Use explicit full-path for loading MsQuic.dll - it prevents accidental load of MsQuic.dll from another unintended directory (e.g. CWD = Current Working Directory) if the bundled MsQuic.dll fails to load (which can happen e.g. on WinServer 2012, where MsQuic is not supported). # Customer Impact Defense-in-depth # Regression No # Testing Targeted manual test on affected OS (Windows Server 2012), including self-contained and single-file publish scenarios. # Risk Low, changes are contained and have been thoroughly tested manually and in CI suite.
…bstract array types Jagged arrays in the payload can contain cycles. In that scenario, no value is correct for `ArrayRecord.FlattenedLength`, and `ArrayRecord.GetArray` does not have enough context to know how to handle the cycles. To address these issues, jagged array handling is simplified so that calling code can handle the cycles in the most appropriate way for the application. Single-dimension arrays can be represented in the payload using abstract types such as `IComparable[]` where the concrete element type is not known. When the concrete element type is known, `ArrayRecord.GetArray` could return either `SZArrayRecord<ClassRecord>` or `SZArrayRecord<object>`; without a concrete type, we need to return something that represents the element abstractly. 1. `ArrayRecord.FlattenedLength` is removed from the API 2. `ArrayRecord.GetArray` now returns `ArrayRecord[]` for jagged arrays instead of trying to populate them 3. `ArrayRecord.GetArray` now returns `SZArrayRecord<SerializationRecord>` for single-dimension arrays instead of either `SZArrayRecord<ClassRecord>` or `SZArrayRecord<object>`
A call to `Assembly.Location` was added in a recent fix. It has `IL30000` suppressed via `#pragma warning disable`, but that only applies to the compilation of the library itself. Consumers will hit it when doing something like publishing their app as NativeAOT. This change adds an `[UnconditionalSuppressMessage]` to the `MsQuicApi` static constructor such that `IL30000` should also be suppressed for apps consuming the runtime. This was caught in an aspnetcore deps flow PR coming from runtime.
…-merge-9.0-2024-11-12-1248
ghost
commented
Nov 12, 2024
Note regarding the |
1 similar comment
ghost
commented
Nov 12, 2024
Note regarding the |
carlossanlop
approved these changes
Nov 12, 2024
This was referenced Nov 12, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.