Skip to content

[release/9.0-staging] fix stack 2x2 tensor along dimension 1 - #110053

Merged
michaelgsharp merged 2 commits into
release/9.0-stagingfrom
backport/pr-108620-to-release/9.0-staging
Jan 28, 2025
Merged

[release/9.0-staging] fix stack 2x2 tensor along dimension 1#110053
michaelgsharp merged 2 commits into
release/9.0-stagingfrom
backport/pr-108620-to-release/9.0-staging

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Nov 21, 2024•
edited by tannergooding
Loading

Copy link
Copy Markdown
Contributor

Backport of #108620 to release/9.0-staging

/cc @tannergooding@kasperk81

Customer Impact

  • Customer reported
  • Found internally

#108615. Incorrect results will be computed for StackAlongDimension

Regression

  • Yes
  • No

This is a net new and in-preview API for .NET 9

Testing

Additional tests covering the relevant scenario were added.

Risk

Low. This is a net new API in .NET 9 and shipped as experimental.

Fixing it will help ensure developers can use the feature and provide feedback as part of stabilizing the API surface.

@dotnet-policy-service

dotnet-policy-serviceBot commented Nov 21, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-numerics-tensors
See info in area-owners.md if you want to be subscribed.

@tannergoodingtannergooding added the Servicing-consider Issue for next servicing release review label Nov 21, 2024
@tannergooding

tannergooding commented Nov 21, 2024

Copy link
Copy Markdown
Member

CC. @jeffhandley

jeffhandley
jeffhandley approved these changes Nov 21, 2024
View reviewed changes

@jeffhandleyjeffhandley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @artl93

@jeffhandleyjeffhandley added this to the 9.0.x milestone Nov 21, 2024
@build-analysisbuild-analysisBot mentioned this pull request Nov 21, 2024
Open
3 tasks
@tannergoodingtannergooding removed the Servicing-consider Issue for next servicing release review label Nov 21, 2024
@tannergooding

tannergooding commented Nov 21, 2024

Copy link
Copy Markdown
Member

Removed servicing-consider temporarily as @MihaZupan pointed out that another line needs updating for the latter method to be correct. This likely means we also need another test to cover that overload

@carlossanlop

carlossanlop commented Jan 13, 2025

Copy link
Copy Markdown
Contributor

@tannergooding@jeffhandley friendly reminder that today's code complete for the Feb 2025 Release. Please merge this change by 4pm PT if you'd like it included in that release version. Otherwise, it will have to wait until next month.

@tannergooding

tannergooding commented Jan 13, 2025

Copy link
Copy Markdown
Member

@michaelgsharp is looking into the other issue that is pending

@michaelgsharp

michaelgsharp commented Jan 14, 2025

Copy link
Copy Markdown
Contributor

@tannergooding@carlossanlop fix is pushed. I know code complete is now tomorrow AM so hopefully this can still get in.

@carlossanlop

carlossanlop commented Jan 14, 2025

Copy link
Copy Markdown
Contributor

Make sure to get a Tactics approval.

This was referenced Jan 14, 2025
Open
Closed
@ericstjericstj added the Servicing-consider Issue for next servicing release review label Jan 27, 2025
ericstj
ericstj approved these changes Jan 27, 2025
View reviewed changes

@ericstjericstj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to combine #108620 and #111390

@ericstj

ericstj commented Jan 27, 2025

Copy link
Copy Markdown
Member

/azp run runtime

@azure-pipelines

azure-pipelinesBot commented Jan 27, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ericstjericstj added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 28, 2025
@ericstj

ericstj commented Jan 28, 2025

Copy link
Copy Markdown
Member

Approved over mail.

@michaelgsharp
michaelgsharp merged commit db5ef46 into release/9.0-stagingJan 28, 2025
@michaelgsharp
michaelgsharp deleted the backport/pr-108620-to-release/9.0-staging branch January 28, 2025 00:32
@build-analysisbuild-analysisBot mentioned this pull request Jan 28, 2025
Open
3 tasks
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Feb 27, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeffhandleyjeffhandleyjeffhandley approved these changes
@ericstjericstjericstj approved these changes

Assignees

@michaelgsharpmichaelgsharp

Labels

area-System.Numerics.TensorsServicing-approvedApproved for servicing release

Projects

None yet

Milestone

9.0.x

Development

Successfully merging this pull request may close these issues.

6 participants

@tannergooding@carlossanlop@michaelgsharp@ericstj@jeffhandley@kasperk81