Skip to content

Fix System.Reflection.Emit SetChecksum creating invalid pdb - #110097

Merged
steveharter merged 2 commits into
dotnet:mainfrom
tgjones:issue-110096
Nov 26, 2024
Merged

Fix System.Reflection.Emit SetChecksum creating invalid pdb#110097
steveharter merged 2 commits into
dotnet:mainfrom
tgjones:issue-110096

Conversation

@tgjones

@tgjonestgjones commented Nov 22, 2024

Copy link
Copy Markdown
Contributor

Fixes#110096.

@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Nov 22, 2024
@tgjonestgjones changed the title Fix document SetChecksum creating invalid pdbFix System.Reflection.Emit SetChecksum creating invalid pdbNov 22, 2024
@build-analysisbuild-analysisBot mentioned this pull request Nov 23, 2024
Closed
@tgjones

tgjones commented Nov 23, 2024

Copy link
Copy Markdown
ContributorAuthor

The CI failures look like instabilities to me - I can't see anything that could be related to my changes amongst the failures.

@steveharter
steveharter self-requested a review November 25, 2024 14:37
steveharter
steveharter approved these changes Nov 25, 2024
View reviewed changes

@stevehartersteveharter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for researching and fixing this.

Do you need this backported to v9?

@tgjones

tgjones commented Nov 25, 2024

Copy link
Copy Markdown
ContributorAuthor

Thanks for approving the PR.

I do need it backported to v9. I don’t know the process for that. Should I make a PR targeting the v9 branch, or is there something automated for that, or…?

@steveharter

steveharter commented Nov 25, 2024

Copy link
Copy Markdown
Contributor

Test failures likely due to #110127

@steveharter

steveharter commented Nov 25, 2024

Copy link
Copy Markdown
Contributor

I do need it backported to v9. I don’t know the process for that. Should I make a PR targeting the v9 branch, or is there something automated for that, or…?

I'll take care of it once this PR is in.

@stevehartersteveharter added this to the 10.0.0 milestone Nov 25, 2024
@stevehartersteveharter self-assigned this Nov 25, 2024
@stevehartersteveharter mentioned this pull request Nov 26, 2024
Open
3 tasks
@steveharter
steveharter merged commit ead4d81 into dotnet:mainNov 26, 2024
@steveharter

steveharter commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

/backport to release/9.0-staging

@github-actions

github-actionsBot commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/12040136075

@github-actionsgithub-actionsBot mentioned this pull request Nov 26, 2024
Merged
3 tasks
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
@tgjones@mikelle-rogers
Fix document checksums in emitted pdbs (dotnet#110097)
209e102
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Dec 28, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@steveharterstevehartersteveharter approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@stevehartersteveharter

Labels

area-System.Reflection.Emitbugcommunity-contributionIndicates that the PR has been added by a community member

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

System.Reflection.Emit SetChecksum produces invalid pdb

2 participants

@tgjones@steveharter