Skip to content

Update to .NET 10 build images - #110198

Merged
sbomer merged 5 commits into
dotnet:mainfrom
sbomer:net10AzLinux
Dec 20, 2024
Merged

Update to .NET 10 build images#110198
sbomer merged 5 commits into
dotnet:mainfrom
sbomer:net10AzLinux

Conversation

@sbomer

@sbomersbomer commented Nov 26, 2024

Copy link
Copy Markdown
Member

This updates the libc requirement to:

  • glibc 2.27
  • musl libc 1.2.3

These images have LLVM 19.

Contributes to #109939

@sbomer
Update to .NET 10 build images
c420dbf
This updates the libc requirement to:
- glibc 2.27
- musl libc 1.2.3
These images have LLVM 19.
@dotnet-policy-service

dotnet-policy-serviceBot commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@sbomer
sbomer requested review from a team and richlanderNovember 26, 2024 18:45
richlander
richlander reviewed Nov 26, 2024
View reviewed changes
Comment threadeng/pipelines/common/templates/pipeline-with-resources.yml Outdated
@sbomersbomer added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Nov 26, 2024
This was referenced Nov 26, 2024
Open
Open
@sbomersbomer removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Dec 2, 2024
@jkoritzinsky

jkoritzinsky commented Dec 3, 2024

Copy link
Copy Markdown
Member

Looks like there's some issues with the ARM32 images with zlib-ng, in particular around intrinsics.

Other than that, this looks good to me.

@sbomer
Fix arm32 build
3360529
The NEON_AVAILABLE and NEON_HAS_LD4 checks in zlib-ng attempt to pass
-mfpu=neon via CMAKE_REQUIRED_FLAGS, but our toolchain.cmake sets
-mfpu=vfpv4 via add_compile_options, which overrides the former.
Work around this by disabling neon on arm32 linux, matching .NET 9.
@sbomer

sbomer commented Dec 10, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

The update to clang-19 includes support for neon intrinsics on arm32. However, the cmake check for NEON_HAS_LD4 in zlib-ng is failing. The check uses CMAKE_REQUIRED_FLAGS to pass -mfpu=neon, but this gets overridden settings in our toolchain.cmake (which passes -mfpu=vfpv3 via add_compile_options). This failed check results in a downstream compilation error (we attempt to compile https://github.com/zlib-ng/zlib-ng/blob/43d74a223b30902b44b01bf4c4888d8deb35e253/arch/arm/neon_intrins.h#L36-L38 in an environment that already provides the ld4 intrinsics).

We could fix this by changing our toolchain.cmake to pass -mfpu=vfpv3 via CMAKE_C_FLAGS and CMAKE_CXX_FLAGS instead of add_compile_options, which would let the CMAKE_REQUIRED_FLAGS setting take precedence. It might also be possible to fix the check in zlib-ng. zlib-ng/zlib-ng#1281 attempted to address a similar problem. Overall the pattern of setting compiler options in a toolchain doesn't work so well with compiler checks that try to set their own flags.

We decided to just disable neon for now, matching the .NET 9 configuration. Thanks for the help investigating this @jkoritzinsky!

am11
am11 reviewed Dec 11, 2024
View reviewed changes
Comment threadeng/pipelines/common/templates/pipeline-with-resources.yml Outdated
am11
am11 reviewed Dec 11, 2024
View reviewed changes
Comment threaddocs/workflow/using-docker.md Outdated
@sbomer@am11
Use FreeBSD 14 images
1f88bce
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
@am11

am11 commented Dec 11, 2024

Copy link
Copy Markdown
Member

alpine arm32 build fixes: main...am11:runtime:feature/native/build-fixes

@build-analysisbuild-analysisBot mentioned this pull request Dec 11, 2024
Closed
@sbomer

sbomer commented Dec 11, 2024

Copy link
Copy Markdown
MemberAuthor

Thanks @am11!

This was referenced Dec 11, 2024
Closed
Closed
@am11am11 mentioned this pull request Dec 12, 2024
Open
@akoeplingerakoeplinger mentioned this pull request Dec 13, 2024
Merged
@build-analysisbuild-analysisBot mentioned this pull request Dec 13, 2024
Closed
@akoeplinger

akoeplinger commented Dec 14, 2024

Copy link
Copy Markdown
Member

/ba-g test timeout is due to #110285 which is fixed in main and closed so Build Analysis didn't link it.

@ericstj

ericstj commented Dec 17, 2024

Copy link
Copy Markdown
Member

@akoeplinger signed off and flipped to green, @sbomer is this ready to merge?

@akoeplinger

akoeplinger commented Dec 17, 2024

Copy link
Copy Markdown
Member

According to Outlook he's OOF until 12/19

@sbomer
sbomer merged commit d08dff5 into dotnet:mainDec 20, 2024
@matouskozakmatouskozak mentioned this pull request Dec 27, 2024
Closed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jan 20, 2025
@sbomer
sbomer deleted the net10AzLinux branch June 26, 2026 18:08
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@richlanderrichlanderrichlander left review comments
@akoeplingerakoeplingerakoeplinger approved these changes
+1 more reviewer
@am11am11am11 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@sbomersbomer

Labels

area-Infrastructure-libraries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sbomer@jkoritzinsky@am11@akoeplinger@ericstj@richlander