Skip to content

[release/9.0-staging] Avoid exception when parsing AD path for port number - #110224

Merged
ericstj merged 1 commit into
release/9.0-stagingfrom
backport/pr-109977-to-release/9.0-staging
Dec 17, 2024
Merged

[release/9.0-staging] Avoid exception when parsing AD path for port number#110224
ericstj merged 1 commit into
release/9.0-stagingfrom
backport/pr-109977-to-release/9.0-staging

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Nov 27, 2024

Copy link
Copy Markdown
Contributor

Backport of #109977 to release/9.0-staging

Fixes#109858

Customer Impact

  • Customer reported

This is breaking existing users of Active Directory through System.DirectoryServices.AccountManagement although there appears to be a workaround.

Regression

  • Yes
  • No

Regression in v9 from #89787.

Testing

There is pending community testing.

This is an ActiveDirectory issue which is hard to test since it requires either local usage of AD or a setup of virtual machine(s) to test. There are no automated tests.

Risk

Low; even though the test has not yet been verified the change is to simply change from calling the constructor of the System.Uri class to using System.Uri.TryCreate().

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-directoryservices, @jay98014
See info in area-owners.md if you want to be subscribed.

@stevehartersteveharter added this to the 9.0.x milestone Nov 27, 2024
@stevehartersteveharter added the Servicing-consider Issue for next servicing release review label Nov 27, 2024
@stevehartersteveharter self-assigned this Nov 27, 2024
@rbhandarbhanda modified the milestones: 9.0.x, 9.0.2Dec 10, 2024
@rbhandarbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 10, 2024
@ericstj
ericstj merged commit 43515e5 into release/9.0-stagingDec 17, 2024
@jkotas
jkotas deleted the backport/pr-109977-to-release/9.0-staging branch December 29, 2024 15:49
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jan 29, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@ericstj@artl93@steveharter@rbhanda