Uh oh!
There was an error while loading. Please reload this page.
[release/9.0-staging] [debugger] Support step into a tail call - #110438
Merged
thaystg merged 2 commits intoDec 11, 2024
Conversation
Contributor
Tagging subscribers to this area: @tommcdon |
tommcdon
approved these changes
Dec 5, 2024
Addressing Tom's and Mikelle's comments Removing unrelated change and adding enum Changing the comment.
github-actionsBotforce-pushed
the
backport/pr-110334-to-release/9.0-staging
branch
from
December 5, 2024 14:49
306002e to
cf2be04Comparetommcdon
approved these changes
Dec 5, 2024
jeffschwMSFT
approved these changes
Dec 5, 2024
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
lgtm. we will take for consideration in 9.0.x
This was referenced Dec 5, 2024
thaystg
commented
Dec 9, 2024
Member
Approved by email. |
thaystg
commented
Dec 11, 2024
Member
/ba-g Build analysis blocked by #110517 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #110334 to release/9.0-staging
/cc @thaystg
Customer Impact
#110441
A customer ships a compiler that uses tail calls and when their customers are debugging the app generated by this compiler and try to step into a tail call it behaves like a resume.
Regression
It works before .NET 6.
Testing
We manually tested using this internal test https://github.com/dotnet/runtime/blob/e99557baffbe864d624cc1c95c9cbf2eefae684f/src/tests/JIT/Regression/JitBlue/Runtime_39581/Runtime_39581.il and trying to step into the Callee.
Risk
Low risk, this will only affect the scenarios where we emit a tail call using the StoreTailCallArgs, which is not used a lot. As far as I understood it's impossible to generate it from a C# code, only F# and IL.