[main] Update dependencies from dotnet/arcade by dotnet-maestro[bot] · Pull Request #110477 · dotnet/runtime

dotnet-maestro · 2024-12-06T15:39:54Z

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
Build: 20241213.2
Date Produced: December 13, 2024 7:51:52 PM UTC
Commit: 255d5e0c89958af276883a988108c2d616438805
Branch: refs/heads/main

Updates:
- Microsoft.SourceBuild.Intermediate.arcade: from 10.0.0-beta.24605.1 to 10.0.0-beta.24613.2
- Microsoft.DotNet.Arcade.Sdk: from 10.0.0-beta.24605.1 to 10.0.0-beta.24613.2
- Microsoft.DotNet.Build.Tasks.Archives: from 10.0.0-beta.24605.1 to 10.0.0-beta.24613.2
- Microsoft.DotNet.Build.Tasks.Feed: from 10.0.0-beta.24605.1 to 10.0.0-beta.24613.2
- Microsoft.DotNet.Build.Tasks.Installers: from 10.0.0-beta.24605.1 to 10.0.0-beta.24613.2
- Microsoft.DotNet.Build.Tasks.Packaging: from 10.0.0-beta.24605.1 to 10.0.0-beta.24613.2
- Microsoft.DotNet.Build.Tasks.TargetFramework: from 10.0.0-beta.24605.1 to 10.0.0-beta.24613.2
- Microsoft.DotNet.Build.Tasks.Templating: from 10.0.0-beta.24605.1 to 10.0.0-beta.24613.2
- Microsoft.DotNet.Build.Tasks.Workloads: from 10.0.0-beta.24605.1 to 10.0.0-beta.24613.2
- Microsoft.DotNet.CodeAnalysis: from 10.0.0-beta.24605.1 to 10.0.0-beta.24613.2
- Microsoft.DotNet.GenAPI: from 10.0.0-beta.24605.1 to 10.0.0-beta.24613.2
- Microsoft.DotNet.GenFacades: from 10.0.0-beta.24605.1 to 10.0.0-beta.24613.2
- Microsoft.DotNet.Helix.Sdk: from 10.0.0-beta.24605.1 to 10.0.0-beta.24613.2
- Microsoft.DotNet.PackageTesting: from 10.0.0-beta.24605.1 to 10.0.0-beta.24613.2
- Microsoft.DotNet.RemoteExecutor: from 10.0.0-beta.24605.1 to 10.0.0-beta.24613.2
- Microsoft.DotNet.SharedFramework.Sdk: from 10.0.0-beta.24605.1 to 10.0.0-beta.24613.2
- Microsoft.DotNet.VersionTools.Tasks: from 10.0.0-beta.24605.1 to 10.0.0-beta.24613.2
- Microsoft.DotNet.XliffTasks: from 10.0.0-beta.24605.1 to 10.0.0-beta.24613.2
- Microsoft.DotNet.XUnitAssert: from 2.9.2-beta.24605.1 to 2.9.2-beta.24613.2
- Microsoft.DotNet.XUnitConsoleRunner: from 2.9.2-beta.24605.1 to 2.9.2-beta.24613.2
- Microsoft.DotNet.XUnitExtensions: from 10.0.0-beta.24605.1 to 10.0.0-beta.24613.2

…205.6 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 10.0.0-beta.24605.1 -> To Version 10.0.0-beta.24605.6

akoeplinger · 2024-12-06T18:04:08Z

@dotnet/illink three linker tests are failing with this bump:

DataFlow.NullableAnnotations
BCLFeatures.ETW.CustomEventSource
UnreachableBlock.ComplexConditions

akoeplinger · 2024-12-06T18:05:11Z

@dotnet/ilc-contrib ILC fails to compile crossgen2 on windows x86:

 crossgen2_publish -> D:\a\_work\1\s\artifacts\bin\crossgen2_publish\x86\Checked\crossgen2.dll
Generating native code
EXEC : error : One or more errors occurred. (Code generation failed for method '[S.P.CoreLib]System.Numerics.BitOperations.TrailingZeroCount(uint64)') [D:\a\_work\1\s\src\coreclr\tools\aot\crossgen2\crossgen2_publish.csproj]
##[error]EXEC(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) One or more errors occurred. (Code generation failed for method '[S.P.CoreLib]System.Numerics.BitOperations.TrailingZeroCount(uint64)')
System.AggregateException: One or more errors occurred. (Code generation failed for method '[S.P.CoreLib]System.Numerics.BitOperations.TrailingZeroCount(uint64)')
---> ILCompiler.CodeGenerationFailedException: Code generation failed for method '[S.P.CoreLib]System.Numerics.BitOperations.TrailingZeroCount(uint64)'
---> System.Collections.Generic.KeyNotFoundException: The given key 'Bmi1_X64' was not present in the dictionary.
at ILCompiler.HardwareIntrinsicILProvider.GetMethodIL(MethodDesc) + 0x1ec
at ILCompiler.SubstitutedILProvider.TryGetMethodConstantValue(MethodDesc, Int32&, Int32) + 0xc2
at ILCompiler.SubstitutedILProvider.TryGetConstantArgument(MethodIL, Byte[], SubstitutedILProvider.OpcodeFlags[], Int32, Int32, Int32&) + 0x608
at ILCompiler.SubstitutedILProvider.GetMethodILWithInlinedSubstitutions(MethodIL) + 0x1cf9
at ILCompiler.SubstitutedILProvider.GetMethodIL(MethodDesc) + 0x60
at ILCompiler.Compilation.CombinedILProvider.GetMethodIL(MethodDesc) + 0x21
at ILCompiler.Compilation.ILCache.CreateValueFromKey(MethodDesc) + 0x3c
at Internal.TypeSystem.LockFreeReaderHashtable`2.CreateValueAndEnsureValueIsInTable(TKey) + 0x18
at ILCompiler.Compilation.GetMethodIL(MethodDesc) + 0xb6
at Internal.IL.ILImporter..ctor(ILScanner, MethodDesc, MethodIL) + 0x55
at ILCompiler.ILScanner.CompileSingleMethod(ScannedMethodNode) + 0x53
--- End of inner exception stack trace ---
at ILCompiler.ILScanner.CompileSingleMethod(ScannedMethodNode) + 0x128
at System.Threading.Tasks.Parallel.<>c__DisplayClass19_0`2.<ForWorker>b__1(RangeWorker&, Int64, Boolean&) + 0x10d
--- End of stack trace from previous location ---
at System.Threading.Tasks.Parallel.<>c__DisplayClass19_0`2.<ForWorker>b__1(RangeWorker&, Int64, Boolean&) + 0x4e4
at System.Threading.Tasks.TaskReplicator.Replica.Execute() + 0xb1
--- End of inner exception stack trace ---
at System.Threading.Tasks.TaskReplicator.Run[TState](TaskReplicator.ReplicatableUserAction`1, ParallelOptions, Boolean) + 0x2b2
at System.Threading.Tasks.Parallel.ForWorker[TLocal,TInt](TInt, TInt, ParallelOptions, Action`1, Action`2, Func`4, Func`1, Action`1) + 0x21f
--- End of stack trace from previous location ---
at System.Threading.Tasks.Parallel.ThrowSingleCancellationExceptionOrOtherException(ICollection, CancellationToken, Exception) + 0x30
at System.Threading.Tasks.Parallel.ForWorker[TLocal,TInt](TInt, TInt, ParallelOptions, Action`1, Action`2, Func`4, Func`1, Action`1) + 0x449
at ILCompiler.ILScanner.CompileMultiThreaded(List`1) + 0x264
at ILCompiler.ILScanner.ComputeDependencyNodeDependencies(List`1) + 0x153
at ILCompiler.DependencyAnalysisFramework.DependencyAnalyzer`2.ComputeMarkedNodes() + 0xa3
at ILCompiler.ILScanner.ILCompiler.IILScanner.Scan() + 0x1b
at ILCompiler.Program.<Run>g__RunScanner|4_0(Program.<>c__DisplayClass4_0&) + 0x1fa
at ILCompiler.Program.Run() + 0x292b
at ILCompiler.ILCompilerRootCommand.<>c__DisplayClass246_0.<.ctor>b__0(ParseResult) + 0x321
D:\a\_work\1\s\.packages\microsoft.dotnet.ilcompiler\10.0.0-alpha.1.24570.9\build\Microsoft.NETCore.Native.targets(315,5): error MSB3073: The command ""D:\a\_work\1\s\.packages\runtime.win-x64.microsoft.dotnet.ilcompiler\10.0.0-alpha.1.24570.9\tools\\ilc" @"D:\a\_work\1\s\artifacts\obj\coreclr\crossgen2_publish\windows.x86.Checked\native\crossgen2.ilc.rsp"" exited with code 1. [D:\a\_work\1\s\src\coreclr\tools\aot\crossgen2\crossgen2_publish.csproj]

#110001 updated annotations on EventSource. This adjusts the expected preserved members to match.

With https://github.com/dotnet/runtime/pull/106497/files, object.GetType is no longer an internalcall. This means we no longer mark the ctor of the return type, System.Type, so the type check removal optimization is kicking in where it didn't before.

jkotas · 2024-12-07T04:06:36Z

@dotnet/ilc-contrib ILC fails to compile crossgen2 on windows x86:

It should be fixed by #110238

…206.6 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 10.0.0-beta.24605.1 -> To Version 10.0.0-beta.24606.6

am11 · 2024-12-08T20:09:51Z

@dotnet/ilc-contrib ILC fails to compile crossgen2 on windows x86:
It should be fixed by #110238

It is blocked on dotnet/sdk#45042, which in turn is blocked on other things. We can disable nativeaot publishing on win-x86 after this line

runtime/eng/Subsets.props

Line 127 in 5ae9467

 <UseNativeAotForComponentsCondition="'$(NativeAotSupported)' == 'true' and '$(TargetOS)' == '$(HostOS)' and '$(TargetsLinuxBionic)' != 'true'">true</UseNativeAotForComponents> 

to unblock this PR:

<!-- TODO: remove once SDK is updated to 10.0 preview 1 (needs https://github.com/dotnet/runtime/pull/110238) -->
<UseNativeAotForComponentsCondition="'$(TargetOS)' == 'windows' and '$(TargetArchitecture)' == 'x86'">false</UseNativeAotForComponents>

…211.4 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 10.0.0-beta.24605.1 -> To Version 10.0.0-beta.24611.4

…45a5-433c-8ef5-b5807629e7e2 # Conflicts: # src/mono/wasm/Wasm.Build.Tests/NonWasmTemplateBuildTests.cs # src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTests.cs # src/mono/wasm/Wasm.Build.Tests/Templates/WasmTemplateTestsBase.cs # src/mono/wasm/Wasm.Build.Tests/TestMainJsTestBase.cs

…212.4 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 10.0.0-beta.24605.1 -> To Version 10.0.0-beta.24612.4

…213.2 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 10.0.0-beta.24605.1 -> To Version 10.0.0-beta.24613.2

akoeplinger · 2024-12-16T18:47:32Z

/ba-g OOM in the browser-wasm linux Release LibraryTests_Threading job is unrelated

am11 · 2024-12-20T19:41:35Z

 <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
+ <PublishTrimmed>true</PublishTrimmed>
 <PublishAot Condition="'$(UseNativeAotForComponents)' == 'true'">true</PublishAot>
+ <PublishSingleFile Condition="'$(UseNativeAotForComponents)' != 'true'">true</PublishSingleFile>


@jkoritzinsky, I am unable to build src/tests on riscv64 since this change was merged in main https://github.com/am11/CrossRepoCITesting/actions/runs/12436232286/job/34723677126
/runtime/.dotnet/sdk/10.0.100-alpha.1.24610.7/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(237,5): error NETSDK1067: Self-contained applications are required to use the application host. Either set SelfContained to false or set UseAppHost to true. [/runtime/src/tests/Common/XUnitLogChecker/XUnitLogChecker.csproj]
My workflow is same as @dotnet/samsung. We can either merge #105004 and announce the new multistage worlflow for community platforms or (if we cannot fast track that) revert 9fc21e0.

As a quick unblocker, I'd recommend disabling the log checker for the riscv64 build. It's never used in local testing and I don't believe anyone does cloud testing like we do for the Microsoft CI builds.

Sounds good. Would you make the change you've mentioned or do you want me to investigate?

I don't have much time for the next week. Can you take a look at it? Since you have the test harness, I think it's best if you can write and validate the change.

ghost added the area-codeflow for labeling automated codeflow label Dec 6, 2024

akoeplinger added 2 commits December 6, 2024 17:02

Set roll forward for cdac-build-tool
9d57e6e

Bump NetCoreAppToolCurrent to net10.0
f8f00a8

akoeplinger requested review from akoeplinger, maraf, steveisok and vitek-karas as code owners December 6, 2024 17:08

Fix CustomEventSource test
497ed57
#110001 updated annotations on EventSource. This adjusts the expected preserved members to match.

sbomer requested a review from marek-safar as a code owner December 6, 2024 19:13

sbomer requested a review from a teamDecember 6, 2024 19:13

Fix tests with Type checks
15a30ef
With https://github.com/dotnet/runtime/pull/106497/files, object.GetType is no longer an internalcall. This means we no longer mark the ctor of the return type, System.Type, so the type check removal optimization is kicking in where it didn't before.

sbomer force-pushed the darc-main-9dbe0517-45a5-433c-8ef5-b5807629e7e2 branch from 06cab35 to 15a30efCompare December 6, 2024 19:13

build-analysisBot mentioned this pull request Dec 7, 2024
Crash in Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests.WorkItemExecution #90019
Open

ViktorHofer added 5 commits December 9, 2024 10:19

Disable nativeAOT components for win-x86 temporarily
660beb4

Merge branch 'main' into darc-main-9dbe0517-45a5-433c-8ef5-b5807629e7e2
b239a96

Update baseline entries
89dcd4d

Bump AspNetCoreAppCurrent
09f0e26

Update pinned package versions
6321b4c

ViktorHofer requested a review from ilonatommy as a code owner December 9, 2024 10:48

dotnet-maestroBotand others added 10 commits December 12, 2024 13:08

Use feature switch to disable DataSet xml serialization related tests
a149938

Workload fixes and improvements
96bf283

Remove runtimes-windows from workload manifest, it is unused
c587848

Add net10 entries in workloads.csproj
c33f055

Fix mistakes in net8 workload manifest
a2b10a0

Update emsdk
5f83c2c

Fix msbuild conditions
bbdd012

This was referenced Dec 14, 2024
System.Runtime.Tests.WorkItemExecution "crash" on tvOS #106319
Closed
Test failure: baseservices/exceptions/stackoverflow/stackoverflowtester/stackoverflowtester.cmd #110173
Open

build-analysisBot mentioned this pull request Dec 14, 2024
[WASI] Sockets - unknown handle index #108726
Closed

am11 mentioned this pull request Dec 16, 2024
[RISC-V] Test build doesn't make crossgen2 executable in RISC-V. #108973
Closed

akoeplinger added 4 commits December 16, 2024 12:08

Fix regex for runtime pack path to allow space
30461f3

Fix condition in WorkloadManifest.targets.in to actually match net10.0
ae3e00f

Fix net version in wasm templates
36b80ec

Fix one more hardcoded net9.0
a0c7ed7

ViktorHofer approved these changes Dec 16, 2024
View reviewed changes

akoeplinger approved these changes Dec 16, 2024
View reviewed changes

akoeplinger merged commit 373f048 into mainDec 16, 2024

dotnet-maestroBot deleted the darc-main-9dbe0517-45a5-433c-8ef5-b5807629e7e2 branch December 16, 2024 18:52

ivanpovazan mentioned this pull request Dec 17, 2024
[mono][tvos] DataSet Xml serialization tests failing on tvos lanes #110771
Closed

akoeplinger mentioned this pull request Dec 20, 2024
[release/9.0-staging] Fix wrong alias-to for tvos AOT packs in net8 workload manifest #110871
Merged
4 tasks

am11 reviewed Dec 20, 2024
View reviewed changes

github-actionsBot locked and limited conversation to collaborators Jan 20, 2025

Navigation Menu

Uh oh!

[main] Update dependencies from dotnet/arcade - #110477

[main] Update dependencies from dotnet/arcade#110477
akoeplinger merged 41 commits into
mainfrom
darc-main-9dbe0517-45a5-433c-8ef5-b5807629e7e2

dotnet-maestroBot commented Dec 6, 2024•
edited
Loading

Uh oh!

akoeplinger commented Dec 6, 2024

Uh oh!

akoeplinger commented Dec 6, 2024

Uh oh!

jkotas commented Dec 7, 2024

Uh oh!

am11 commented Dec 8, 2024

Uh oh!

akoeplinger commented Dec 16, 2024

Uh oh!

am11Dec 20, 2024

Uh oh!

jkoritzinskyDec 20, 2024

Uh oh!

am11Dec 21, 2024

Uh oh!

jkoritzinskyDec 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

dotnet-maestroBot commented Dec 6, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/dotnet/arcade

Uh oh!

akoeplinger commented Dec 6, 2024

Uh oh!

akoeplinger commented Dec 6, 2024

Uh oh!

jkotas commented Dec 7, 2024

Uh oh!

am11 commented Dec 8, 2024

Uh oh!

akoeplinger commented Dec 16, 2024

Uh oh!

am11Dec 20, 2024

Choose a reason for hiding this comment

Uh oh!

jkoritzinskyDec 20, 2024

Choose a reason for hiding this comment

Uh oh!

am11Dec 21, 2024

Choose a reason for hiding this comment

Uh oh!

jkoritzinskyDec 21, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dotnet-maestroBot commented Dec 6, 2024•
edited
Loading