Uh oh!
There was an error while loading. Please reload this page.
Don't wait for finalizers in 'IReferenceTrackerHost::ReleaseDisconnectedReferenceSources' - #110551
Merged
jkotas merged 3 commits intoDec 10, 2024
Conversation
Contributor
Tagging subscribers to this area: @dotnet/interop-contrib |
Sergio0694
commented
Dec 9, 2024
ContributorAuthor
@jkotas I'm targeting |
jkotas
commented
Dec 9, 2024
Member
Yes, the right workflow for this repo is to merge the change into main first. |
jkotas
approved these changes
Dec 9, 2024
AaronRobinsonMSFT
approved these changes
Dec 9, 2024
jkoritzinsky
approved these changes
Dec 9, 2024
jkoritzinsky
left a comment
Member
There was a problem hiding this comment.
Just a comment wording nit, otherwise LGTM
Uh oh!
There was an error while loading. Please reload this page.
AaronRobinsonMSFT
approved these changes
Dec 9, 2024
3 tasks
jkotas
commented
Dec 10, 2024
Member
/backport to release/9.0-staging |
Contributor
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/12247939420 |
Open
3 tasks
4 tasks
hez2010 pushed a commit
to hez2010/runtime
that referenced
this pull request
Dec 14, 2024
…tedReferenceSources' (dotnet#110551) This PR updates the IReferenceTrackerHost::ReleaseDisconnectedReferenceSources implementation for CoreCLR and NativeAOT to match what .NET Native was doing, and not wait for finalizers, to avoid deadlocks in ASTA scenarios (UWP). Finalizers will just continue running normally, and if the process is suspended (which can only happen on UWP anyway), they'll resume when the process is resumed later on. Worst case scenario this would only cause a non-optimal memory use cleanup before suspension (which is better than a deadlock anyway). Can be revisited and improved for .NET 10 if needed. Contributes to dotnet#109538
Sergio0694 added a commit
to Sergio0694/runtime
that referenced
this pull request
Jan 7, 2025
…tedReferenceSources' (dotnet#110551) This PR updates the IReferenceTrackerHost::ReleaseDisconnectedReferenceSources implementation for CoreCLR and NativeAOT to match what .NET Native was doing, and not wait for finalizers, to avoid deadlocks in ASTA scenarios (UWP). Finalizers will just continue running normally, and if the process is suspended (which can only happen on UWP anyway), they'll resume when the process is resumed later on. Worst case scenario this would only cause a non-optimal memory use cleanup before suspension (which is better than a deadlock anyway). Can be revisited and improved for .NET 10 if needed. Contributes to dotnet#109538
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #109538
This PR updates the
IReferenceTrackerHost::ReleaseDisconnectedReferenceSourcesimplementation for CoreCLR and NativeAOT to match what .NET Native was doing, and not wait for finalizers, to avoid deadlocks in ASTA scenarios (UWP). Finalizers will just continue running normally, and if the process is suspended (which can only happen on UWP anyway), they'll resume when the process is resumed later on. Worst case scenario this would only cause a non-optimal memory use cleanup before suspension (which is better than a deadlock anyway). Can be revisited and improved for .NET 10 if needed.