Skip to content

Remove unsafe bool casts - #111024

Merged
EgorBo merged 4 commits into
dotnet:mainfrom
xtqqczze:avoid-Unsafe-BitCast
Jan 28, 2025
Merged

Remove unsafe bool casts#111024
EgorBo merged 4 commits into
dotnet:mainfrom
xtqqczze:avoid-Unsafe-BitCast

Conversation

@xtqqczze

@xtqqczzextqqczze commented Jan 2, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Contributes to #94941.

@ghostghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jan 2, 2025
@dotnet-policy-servicedotnet-policy-serviceBot added the community-contribution Indicates that the PR has been added by a community member label Jan 2, 2025
This was referenced Jan 2, 2025
Open
Open
Closed
@xtqqczze

xtqqczze commented Jan 2, 2025

Copy link
Copy Markdown
ContributorAuthor

@MihuBot

@MihuBotMihuBot mentioned this pull request Jan 2, 2025
Open
xtqqczze
xtqqczze commented Jan 2, 2025
View reviewed changes
Comment threadsrc/libraries/System.Private.CoreLib/src/System/Half.cs
@xtqqczze

xtqqczze commented Jan 2, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@tannergooding Is this beneficial? 2 bytes higher in code size, but 0.75 lower PerfScore.

MihuBot/runtime-utils#854

 ; Assembly listing for method System.Half:op_Explicit(float):System.Half (FullOpts)
+ xor ecx, ecx+ mov edx, -1
vucomiss xmm0, xmm0
- setp cl- movzx rcx, cl- dec ecx+ cmovnp ecx, edx

Related: #61761 (comment)

EgorBo
EgorBo approved these changes Jan 2, 2025
View reviewed changes

@EgorBoEgorBo left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, thanks!. Wonder if we have more such bool <--> int unsafe conversions

@xtqqczze

xtqqczze commented Jan 3, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

LGTM otherwise, thanks!. Wonder if we have more such bool <--> int unsafe conversions

These were the only conversions I found searching for:

  • Unsafe.As<bool
  • Unsafe.BitCast<bool
  • *(byte*)&
  • *(sbyte*)&

@EgorBo

EgorBo commented Jan 10, 2025

Copy link
Copy Markdown
Member

Is this ready?

@xtqqczze

xtqqczze commented Jan 10, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Is this ready?

@EgorBo I had a question about codegen: #111024 (comment)

I'm guessing the diff codegen in that comment is preferable?

@xtqqczze
xtqqczze marked this pull request as ready for review January 11, 2025 00:32
@EgorBoEgorBo mentioned this pull request Jan 13, 2025
Closed
15 tasks
@build-analysisbuild-analysisBot mentioned this pull request Jan 28, 2025
Closed
@EgorBoEgorBo added area-System.Runtime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jan 28, 2025
@dotnet-policy-service

dotnet-policy-serviceBot commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

@EgorBo
EgorBo merged commit 21ab780 into dotnet:mainJan 28, 2025
@EgorBo

EgorBo commented Jan 28, 2025

Copy link
Copy Markdown
Member

Thanks!

grendello added a commit to grendello/runtime that referenced this pull request Jan 30, 2025
@grendello
Merge branch 'main' into dev/grendel/android-clr-host-local
3ff6056
* main:
Make cdac APIs public but experimental (dotnet#111180)
JIT: Enable inlining for late devirtualization (dotnet#110827)
Remove unsafe `bool` casts (dotnet#111024)
Fix shimmed implementation of TryGetHashAndReset to handle HMAC.
@LoopedBard3LoopedBard3 mentioned this pull request Feb 4, 2025
Closed
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Feb 28, 2025
@xtqqczze
xtqqczze deleted the avoid-Unsafe-BitCast branch October 4, 2025 11:32
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@EgorBoEgorBoEgorBo approved these changes

Assignees

No one assigned

Labels

area-System.Runtimecommunity-contributionIndicates that the PR has been added by a community memberreduce-unsafe

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xtqqczze@EgorBo