Uh oh!
There was an error while loading. Please reload this page.
[release/9.0-staging] [mono] [llvm-aot] Fixed storing Vector3 into memory - #111069
Merged
jkurdek merged 2 commits intoFeb 4, 2025
Merged
Conversation
github-actionsBot
requested review from
fanyang-mono and steveisok
as code ownersJanuary 3, 2025 16:48
jkurdek
requested review from
matouskozak and tannergooding
and removed request for
fanyang-monoJanuary 3, 2025 16:55
Contributor
Tagging subscribers to this area: @steveisok, @vitek-karas |
jkurdek
commented
Jan 3, 2025
Contributor
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Jan 3, 2025
Open
carlossanlop
commented
Jan 13, 2025
Contributor
@jkurdek friendly reminder that today's code complete for the Feb 2025 Release. Please merge this change by 4pm PT if you'd like it included in that release version. Otherwise, it will have to wait until next month. |
jeffschwMSFT
approved these changes
Jan 14, 2025
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
lgtm. please get a code review. we will take for consideration in 9.0.x
matouskozak
approved these changes
Jan 16, 2025
steveisok
approved these changes
Jan 16, 2025
jeffschwMSFT
commented
Jan 30, 2025
Member
@jkurdek can you take a look at the CI failures? we can merge when ready |
jkurdek
commented
Jan 31, 2025
Contributor
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jkurdek
commented
Feb 4, 2025
Contributor
/ba-g runtime-extra-platforms failures are known and unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #111000 to release/9.0-staging. Fixes storing of Vector3 into memory on mono-llvm-aot.
Customer Impact
Reported in #110820. Storing Vector3 into memory was is working incorrectly when using mono aot llvm. Instead of being saved as Vector3 it is saved as Vector4 (Vector3 + trailing 0) effectively overwriting the next memory cell with 0. Customer experienced their data being overwritten with 0s.
Regression
Regression introduced in #97416. This change implemented some intrinsics for Vector3 - for those intrinsics purposes Vector3 is being represented as Vector4 (Vector3 + 0).
Testing
Added test a new test verifying that saving Vector3 works correctly.
Risk
Low. Change applies only to mono aot llvm Vector3 save to memory path.