Skip to content

[release/9.0-staging] Use alternative format string specifier to ensure decimal point is present - #111444

Merged
jkoritzinsky merged 1 commit into
release/9.0-stagingfrom
backport/pr-111254-to-release/9.0-staging
Jan 30, 2025
Merged

[release/9.0-staging] Use alternative format string specifier to ensure decimal point is present#111444
jkoritzinsky merged 1 commit into
release/9.0-stagingfrom
backport/pr-111254-to-release/9.0-staging

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Jan 15, 2025

Copy link
Copy Markdown
Contributor

Backport of #111254 to release/9.0-staging

/cc @jkoritzinsky

Customer Impact

  • Customer reported
  • Found internally

ILDasm (9.0) outputs the wrong format in float64(...) and float32(...) for double and float values without decimal places. The decimal point is missing.
ILAsm interprets these as int64 and therefore casts them to double or float values, which leads to incorrect values.

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Regression from .NET 9

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

Manual verification

Risk

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

Low risk. Impacts ildasm usage only and the fix has been validated.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

Package authoring no longer needed in .NET 9

IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

@jeffschwMSFTjeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we will take for consideration in 9.0.x

@jeffschwMSFTjeffschwMSFT added the Servicing-consider Issue for next servicing release review label Jan 15, 2025
@jeffschwMSFTjeffschwMSFT added this to the 9.0.x milestone Jan 15, 2025
@rbhandarbhanda modified the milestones: 9.0.x, 9.0.3Jan 28, 2025
@rbhandarbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jan 28, 2025
@jeffschwMSFT

Copy link
Copy Markdown
Member

@jkoritzinsky can you take a look at the CI failures? we can merge when ready

@jkoritzinsky

Copy link
Copy Markdown
Member

/ba-g all failures are known

@jkoritzinsky
jkoritzinsky merged commit 99b4e84 into release/9.0-stagingJan 30, 2025
@jkotas
jkotas deleted the backport/pr-111254-to-release/9.0-staging branch February 2, 2025 18:49
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 5, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-ILTools-coreclrServicing-approvedApproved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jeffschwMSFT@jkoritzinsky@jkotas@rbhanda