Skip to content

Make CalculateAssemblyAction virtual. - #112154

Merged
sbomer merged 1 commit into
dotnet:mainfrom
Unity-Technologies:linker-expose-calc-asm-action
Feb 5, 2025
Merged

Make CalculateAssemblyAction virtual.#112154
sbomer merged 1 commit into
dotnet:mainfrom
Unity-Technologies:linker-expose-calc-asm-action

Conversation

@mrvoorhe

Copy link
Copy Markdown
Contributor

We need to override this in UnityLinker

We need to override this in UnityLinker
@ghostghost added the area-Tools-ILLink .NET linker development as well as trimming analyzers label Feb 4, 2025
@dotnet-policy-servicedotnet-policy-serviceBot added linkable-framework Issues associated with delivering a linker friendly framework community-contribution Indicates that the PR has been added by a community member labels Feb 4, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/illink
See info in area-owners.md if you want to be subscribed.

@mrvoorhe

Copy link
Copy Markdown
ContributorAuthor

Not sure who's in charge of merging changes these days. Pinging you @sbomer in case @marek-safar isn't checking on PRs.

@mrvoorhe

Copy link
Copy Markdown
ContributorAuthor

@sbomer I don't think the failures are related to this change. How do I get the PR merged?

@sbomer

Copy link
Copy Markdown
Member

/ba-g "Unrelated timeouts"

@sbomer
sbomer merged commit 726903d into dotnet:mainFeb 5, 2025
mrvoorhe added a commit to Unity-Technologies/runtime that referenced this pull request Feb 6, 2025
We need to override this in UnityLinker
grendello added a commit to grendello/runtime that referenced this pull request Feb 6, 2025
* main: (23 commits)
add important remarks to NrbfDecoder (dotnet#111286)
docs: fix spelling grammar and missing words in clr-code-guide.md (dotnet#112222)
Consider type declaration order in MethodImpls (dotnet#111998)
Add a feature flag to not use GVM in Linq Select (dotnet#109978)
[cDAC] Implement ISOSDacInterface::GetMethodDescPtrFromIp (dotnet#110755)
Restructure JSImport/JSExport generators to share more code and utilize more Microsoft.Interop.SourceGeneration shared code (dotnet#107769)
Add more detailed explanations to control-flow RegexOpcode values (dotnet#112170)
Add repo-specific condition to labeling workflows (dotnet#112169)
Fix bad assembly when a nested exported type is marked via link.xml (dotnet#107945)
Make `CalculateAssemblyAction` virtual. (dotnet#112154)
JIT: Enable reusing profile-aware DFS trees between phases (dotnet#112198)
Add support for LDAPTLS_CACERTDIR \ TrustedCertificateDirectory (dotnet#111877)
JIT: Support custom `ClassLayout` instances with GC pointers in them (dotnet#112064)
Factor positive lookaheads better into find optimizations (dotnet#112107)
Add ImmutableCollectionsMarshal.AsMemory (dotnet#112177)
[mono] ILStrip write directly to the output filestream (dotnet#112142)
Allow the NativeAOT runtime pack to be specified as the ILC runtime package (dotnet#111876)
JIT: some reworking for conditional escape analysis (dotnet#112194)
Replace HELPER_METHOD_FRAME with DynamicHelperFrame in patchpoints (dotnet#112025)
[Android] Decouple runtime initialization and entry point execution for Android sample (dotnet#111742)
...
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 8, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Tools-ILLink.NET linker development as well as trimming analyzerscommunity-contributionIndicates that the PR has been added by a community memberlinkable-frameworkIssues associated with delivering a linker friendly framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mrvoorhe@sbomer