Skip to content

Wait to complete the test before releasing the agile reference. - #112387

Merged
jkoritzinsky merged 1 commit into
dotnet:mainfrom
jkoritzinsky:cross-apartment-test-fix
Feb 11, 2025
Merged

Wait to complete the test before releasing the agile reference.#112387
jkoritzinsky merged 1 commit into
dotnet:mainfrom
jkoritzinsky:cross-apartment-test-fix

Conversation

@jkoritzinsky

@jkoritzinskyjkoritzinsky commented Feb 11, 2025

Copy link
Copy Markdown
Member

Otherwise we can end up with a use-after-free of the agile reference if the cleanup runs before the MTA thread calls Resolve.

I believe this fixes#112305 and fixes#112386

Otherwise we can end up with a use-after-free
@jkoritzinsky
jkoritzinsky merged commit 7e82ad9 into dotnet:mainFeb 11, 2025
@jkoritzinsky
jkoritzinsky deleted the cross-apartment-test-fix branch February 11, 2025 22:02
grendello added a commit to grendello/runtime that referenced this pull request Feb 12, 2025
* main:
[Android] Run CoreCLR functional tests on Android (dotnet#112283)
[LoongArch64] Fix some assertion failures for Debug ILC building Debug NativeAOT testcases. (dotnet#112229)
Fix suspicious code fragments (dotnet#112384)
`__ComObject` doesn't support dynamic interface map (dotnet#112375)
Native DLLs: only load imported DLLs from System32 (dotnet#112359)
[main] Update dependencies from dotnet/roslyn (dotnet#112314)
Update SVE instructions that writes to GC regs (dotnet#112389)
Bring up android+coreclr windows build. (dotnet#112256)
Never use heap for return buffers (dotnet#112060)
Wait to complete the test before releasing the agile reference. (dotnet#112387)
Prevent returning disposed HTTP/1.1 connections to the pool (dotnet#112383)
Fingerprint dotnet.js if writing import map to html is enabled (dotnet#112407)
Remove duplicate definition of CORECLR_HOSTING_API_LINKAGE (dotnet#112096)
Update the exception message to reflect current behavior. (dotnet#112355)
Use enum for frametype not v table (dotnet#112166)
Enable AltJits build for LoongArch64 and RiscV64 (dotnet#110282)
Guard members of MonoType union & fix related bugs (dotnet#111645)
Add optional hooks for debugging OpenSSL memory allocations (dotnet#111539)
JIT: Optimize struct parameter register accesses in the backend (dotnet#110819)
NativeAOT: Cover more opcodes in type preinitializer (dotnet#112073)
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 14, 2025
@AaronRobinsonMSFT

Copy link
Copy Markdown
Member

/backport to release/9.0

@github-actionsgithub-actionsBot unlocked this conversation Jun 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0 (link to workflow run)

@AaronRobinsonMSFT

Copy link
Copy Markdown
Member

/backport to release/9.0-staging

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/9.0-staging (link to workflow run)

AaronRobinsonMSFT pushed a commit that referenced this pull request Jun 16, 2026
…agile reference. (#129430)
Backport of #112387 to release/9.0-staging
/cc @AaronRobinsonMSFT@jkoritzinskyCloses#129421
## Customer Impact
- [ ] Customer reported
- [x] Found internally
This is flaky test issue that is impacting the 9.0 branch. It was fixed
in 10, but missed 11.
## Regression
- [ ] Yes
- [x] No
Flaky test.
## Testing
This fix has been in 10 and 11 with no further issues.
## Risk
Zero as it has no impact to the product.
Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Jul 16, 2026
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

3 participants

@jkoritzinsky@AaronRobinsonMSFT@jkotas