Skip to content

[Android] Remove CoreCLR functional tests on Android from extra-platforms - #112496

Merged
kotlarmilos merged 4 commits into
dotnet:mainfrom
kotlarmilos:improvement/coreclr-android-functional-tests
Feb 13, 2025
Merged

[Android] Remove CoreCLR functional tests on Android from extra-platforms#112496
kotlarmilos merged 4 commits into
dotnet:mainfrom
kotlarmilos:improvement/coreclr-android-functional-tests

Conversation

@kotlarmilos

Copy link
Copy Markdown
Member

Description

This PR removes a redundant job from extra-platforms. We we include the full libraries run in the extra-platforms.

Follow-up #112283

CopilotAI review requested due to automatic review settings February 12, 2025 20:08
@ghostghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 12, 2025

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@kotlarmiloskotlarmilos self-assigned this Feb 12, 2025
@kotlarmiloskotlarmilos added area-Infrastructure-coreclr Only use for closed issues os-android and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 12, 2025
@kotlarmiloskotlarmilos added this to the 10.0.0 milestone Feb 12, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@kotlarmilos

Copy link
Copy Markdown
MemberAuthor

/azp run runtime-androidemulator

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@matouskozakmatouskozak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the update.

One thing, I'm not sure if we shouldn't include
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_coreclr.containsChange'], true), in

or(
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_libraries.containsChange'], true),
eq(stageDependencies.EvaluatePaths.evaluate_paths.outputs['SetPathVars_installer.containsChange'], true),
eq(variables['isRollingBuild'], true))

Comment threadeng/pipelines/runtime.yml Outdated
kotlarmilosand others added 2 commits February 13, 2025 09:30
Co-authored-by: Matous Kozak <55735845+matouskozak@users.noreply.github.com>
@kotlarmilos
kotlarmilos merged commit 4058c09 into dotnet:mainFeb 13, 2025
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Mar 27, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Infrastructure-coreclrOnly use for closed issuesos-android

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants

@kotlarmilos@steveisok@matouskozak